Re: [Qemu-devel] [RFC V6 27/33] qcow2: Adapt checking of QCOW_OFLAG_COPIED for dedup.

2013-03-01 Thread Kevin Wolf
Am 28.02.2013 um 17:14 hat Benoît Canet geschrieben: > Le Thursday 28 Feb 2013 à 11:14:34 (+0100), Kevin Wolf a écrit : > > Am 28.02.2013 um 10:41 hat Stefan Hajnoczi geschrieben: > > > On Wed, Feb 27, 2013 at 04:00:28PM +0100, Benoît Canet wrote: > > > > > > -if ((refcount == 1) !=

[Qemu-devel] [RfC PATCH 04/12] qxl: zap qxl0 global

2013-03-01 Thread Gerd Hoffmann
DisplayChangeListener is passed now to all DisplayChangeListenerOps callbacks, so we can use that to access the qxl state and kill the qxl0 global variable. Signed-off-by: Gerd Hoffmann --- hw/qxl.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --gi

[Qemu-devel] [RfC PATCH 10/12] gtk: stop using DisplayState

2013-03-01 Thread Gerd Hoffmann
Rework DisplayStateListener callbacks to not use the DisplayState any more. Factor out the window size handling to a separate function, so the zoom callbacks can call that directly instead of abusing the gd_switch DisplayStateListener callback for that. Signed-off-by: Gerd Hoffmann --- ui/gtk.c

[Qemu-devel] [RfC PATCH 00/12] console/display: cleanup & untangle data structures.

2013-03-01 Thread Gerd Hoffmann
Hi, This patch series continues the console & display code cleanups. It's RfC because it is (a) not complete yet and (b) most likely breaks the build (xen, cocoa). If someone wants help fill the gaps (especially cocoa) patches are very welcome. The short-team goal I'm heading to is to make the

[Qemu-devel] [RfC PATCH 06/12] sdl: drop dead code

2013-03-01 Thread Gerd Hoffmann
DisplayAllocator removal made this a nop. Signed-off-by: Gerd Hoffmann --- ui/sdl.c |5 - 1 file changed, 5 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 5baffa0..fc4dc1b 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -458,11 +458,6 @@ static void sdl_scale(DisplayState *ds, int width, i

[Qemu-devel] [RfC PATCH 09/12] console: add surface_*() getters

2013-03-01 Thread Gerd Hoffmann
Add convinence wrappers to query DisplaySurface properties. Simliar to ds_get_*, but operating in the DisplaySurface not the DisplayState. With this patch in place ui frontents can stop using DisplayState in the rendering code paths, they can simply operate using the DisplaySurface passed in via d

[Qemu-devel] [RfC PATCH 05/12] qxl: better vga init in enter_vga_mode

2013-03-01 Thread Gerd Hoffmann
Ask the vga core to update the display. Will trigger dpy_gfx_resize if needed. More complete than just calling dpy_gfx_resize. Signed-off-by: Gerd Hoffmann --- hw/qxl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index cc0ba40..8177008 100644 ---

[Qemu-devel] [RfC PATCH 11/12] vnc: stop using DisplayState

2013-03-01 Thread Gerd Hoffmann
Rework DisplayStateListener callbacks to not use the DisplayState any more. Signed-off-by: Gerd Hoffmann --- ui/vnc-enc-tight.c |7 ++--- ui/vnc-jobs.c |1 - ui/vnc.c | 73 +--- ui/vnc.h |3 +-- 4 files change

[Qemu-devel] [RfC PATCH 03/12] spice: zap sdpy global

2013-03-01 Thread Gerd Hoffmann
DisplayChangeListener is passed now to all DisplayChangeListenerOps callbacks, so we can use that to access the spice display state and kill the sdpy global variable. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 30 -- 1 file changed, 16 insertions(+), 14 d

[Qemu-devel] [RfC PATCH 12/12] sdl: stop using DisplayState

2013-03-01 Thread Gerd Hoffmann
Rework DisplayStateListener callbacks to not use the DisplayState any more. Signed-off-by: Gerd Hoffmann --- ui/sdl.c | 92 ++ 1 file changed, 51 insertions(+), 41 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 85eefdf..58f16bc

[Qemu-devel] [RfC PATCH 01/12] console: fix displaychangelisteners interface

2013-03-01 Thread Gerd Hoffmann
Split callbacks into separate Ops struct. Pass DisplayChangeListener pointer as first argument to all callbacks. Uninline a bunch of display functions and move them from console.h to console.c Signed-off-by: Gerd Hoffmann --- hw/qxl.c | 18 ++-- include/ui/console.h |

[Qemu-devel] [RfC PATCH 02/12] console: kill DisplayState->opaque

2013-03-01 Thread Gerd Hoffmann
It's broken by design. There can be multiple DisplayChangeListener instances, so they simply can't store state in the (single) DisplayState struct. Try 'qemu -display gtk -vnc :0', watch it crash & burn. With DisplayChangeListenerOps having a more sane interface now we can simply use the Display

[Qemu-devel] [RfC PATCH 08/12] console: rework DisplaySurface handling [dcl/ui side]

2013-03-01 Thread Gerd Hoffmann
Replace the dpy_gfx_resize and dpy_gfx_setdata DisplayChangeListener callbacks with a dpy_gfx_switch callback which notifies the ui code when the framebuffer backing storage changes. Signed-off-by: Gerd Hoffmann --- hw/qxl.c |9 + include/ui/console.h |7 +

[Qemu-devel] [RfC PATCH 07/12] console: rework DisplaySurface handling [vga emu side]

2013-03-01 Thread Gerd Hoffmann
Decouple DisplaySurface allocation & deallocation from DisplayState. Replace dpy_gfx_resize + dpy_gfx_setdata with a dpy_gfx_replace_surface function. This handles the graphic hardware emulation. Signed-off-by: Gerd Hoffmann --- hw/nseries.c |7 - hw/palm.c|7 ---

Re: [Qemu-devel] [RFC PATCH 0/4] savevm: save vmsate with fixed size

2013-03-01 Thread Kevin Wolf
Am 01.03.2013 um 03:35 hat Wenchao Xia geschrieben: > 于 2013-2-28 18:50, Kevin Wolf 写道: > >Am 28.02.2013 um 09:09 hat Wenchao Xia geschrieben: > >>This version have following limitation: > >> 1 in patch 3 only dirty page got written, clean page is not touched, so > >>it will have trouble when sav

[Qemu-devel] [PATCH 0/2 v3] Time resync support by qemu-ga

2013-03-01 Thread Lei Li
This patch series attempts to add time resync support to qemu-ga by introducing qemu-ga commands guest-get-time and guest-set-time. Right now, when a guest is paused or migrated to a file then loaded from that file, the guest OS has no idea that there was a big gap in the time. Depending on how lo

[Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-03-01 Thread Lei Li
Signed-off-by: Lei Li --- qga/commands-posix.c | 16 qga/qapi-schema.json | 16 2 files changed, 32 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 0ad73f3..f159e25 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -119

Re: [Qemu-devel] [RFC V6 27/33] qcow2: Adapt checking of QCOW_OFLAG_COPIED for dedup.

2013-03-01 Thread Stefan Hajnoczi
On Fri, Mar 01, 2013 at 09:59:33AM +0100, Kevin Wolf wrote: > Am 28.02.2013 um 17:14 hat Benoît Canet geschrieben: > > Le Thursday 28 Feb 2013 à 11:14:34 (+0100), Kevin Wolf a écrit : > > > Am 28.02.2013 um 10:41 hat Stefan Hajnoczi geschrieben: > > > > On Wed, Feb 27, 2013 at 04:00:28PM +0100, Ben

[Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-01 Thread Lei Li
Signed-off-by: Lei Li --- qga/commands-posix.c | 55 qga/qapi-schema.json | 27 ++ 2 files changed, 82 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index f159e25..e246a0d 100644 --- a/qga/comma

Re: [Qemu-devel] [PATCH] net: use socket_set_nodelay() for -netdev socket

2013-03-01 Thread Stefan Hajnoczi
On Thu, Feb 28, 2013 at 01:55:58PM +, Daniel P. Berrange wrote: > On Thu, Feb 28, 2013 at 02:49:51PM +0100, Stefan Hajnoczi wrote: > > On Wed, Feb 27, 2013 at 04:49:16PM +, Daniel P. Berrange wrote: > > > On Wed, Feb 27, 2013 at 03:05:47PM +0100, Stefan Hajnoczi wrote: > > > > Reduce -netde

Re: [Qemu-devel] [RFC] parallelize migration_bitmap_sync()

2013-03-01 Thread Paolo Bonzini
Il 01/03/2013 00:22, Michael R. Hines ha scritto:te > Hi, > > Currently migration_bitmap_sync() is very expensive: on the order of > 15-20 milliseconds by my count using timestamps (for a simple 2GB ram > virtual machine). > Until new EPT processor versions come out in 2014, we need software > sup

Re: [Qemu-devel] virtio-rng and fd passing

2013-03-01 Thread Paolo Bonzini
Il 01/03/2013 01:36, Eric Blake ha scritto: > For fd passing to work, we have to use qemu_open() instead of raw > open(). Is there any way to enforce that all files being opened by qemu > go through the appropriate qemu_open() wrapper? > > Meanwhile, we have a quandary on the libvirt side of thin

Re: [Qemu-devel] Advice on some configuration parameters

2013-03-01 Thread Fabio Fantoni
Il 12/02/2013 14:05, Fabio Fantoni ha scritto: I'm making patches to enable some qemu upstream features in xen that are missing in libxl. I'm trying to do it just by giving arguments to qemu, and I want them to be dynamic (e.g. without physical addresses if possible) and concise. I'm confused

Re: [Qemu-devel] [ARM] Cortex-R4F and VFP3-D16

2013-03-01 Thread Fabien Chouteau
On 02/28/2013 07:42 PM, Peter Maydell wrote: > On 28 February 2013 17:39, Fabien Chouteau wrote: >> On 02/28/2013 03:16 PM, Peter Maydell wrote: >>> On 28 February 2013 14:01, Fabien Chouteau wrote: In fact I'm working on a big-endian R4F (TMS570) and I have endianness issue in the

Re: [Qemu-devel] [PATCH v10 0/7] trace: Generic event state description

2013-03-01 Thread Stefan Hajnoczi
On Thu, Feb 28, 2013 at 02:48:27PM +0100, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > On Fri, Jan 25, 2013 at 05:33:46PM +0100, Lluís Vilanova wrote: > >> Provides a generic event state description structure (TraceEvent) and a > >> more > >> detailed event control and query interface. >

Re: [Qemu-devel] [ARM] Cortex-R4F and VFP3-D16

2013-03-01 Thread Peter Maydell
On 1 March 2013 10:13, Fabien Chouteau wrote: > On 02/28/2013 07:42 PM, Peter Maydell wrote: >> How are you handling the SCTLR IE and EE bits? > > I did nothing, as far as I know it's not possible to switch endianness > in QEMU. Yes, that's why I'm wondering how you're handling them. > TMS570 ar

Re: [Qemu-devel] Block I/O optimizations

2013-03-01 Thread Stefan Hajnoczi
On Thu, Feb 28, 2013 at 08:20:08PM +0200, Abel Gordon wrote: > Stefan Hajnoczi wrote on 28/02/2013 04:43:04 PM: > > I think extending and tuning the existing mechanisms is the way to go. > > I don't see obvious advantages other than reducing context switches. > > Maybe it is worth checking... > W

Re: [Qemu-devel] [ARM] Cortex-R4F and VFP3-D16

2013-03-01 Thread Fabien Chouteau
On 03/01/2013 11:40 AM, Peter Maydell wrote: > On 1 March 2013 10:13, Fabien Chouteau wrote: >> On 02/28/2013 07:42 PM, Peter Maydell wrote: >>> How are you handling the SCTLR IE and EE bits? >> >> I did nothing, as far as I know it's not possible to switch endianness >> in QEMU. > > Yes, that's w

Re: [Qemu-devel] [ARM] Cortex-R4F and VFP3-D16

2013-03-01 Thread Peter Maydell
On 1 March 2013 11:21, Fabien Chouteau wrote: > On 03/01/2013 11:40 AM, Peter Maydell wrote: >> On 1 March 2013 10:13, Fabien Chouteau wrote: >>> TMS570 are configured for big-endian only, so this is not a >>> problem for me. >> >> Do you mean they are BE8 for load/stores always (ie SCTLR.EE is >

[Qemu-devel] [PATCH] page_cache: use multiplicative hash for page position calculation

2013-03-01 Thread Peter Lieven
instead of a linear mapping we use a multiplicative hash with the golden ratio to derive the cache bucket from the address. this helps to reduce collisions if memory positions are multiple of the cache size and it avoids a division in the position calculation. Signed-off-by: Peter Lieven --- pa

Re: [Qemu-devel] [ARM] Cortex-R4F and VFP3-D16

2013-03-01 Thread Fabien Chouteau
On 03/01/2013 12:32 PM, Peter Maydell wrote: > On 1 March 2013 11:21, Fabien Chouteau wrote: >> TMS570LS31x/21x Technical Reference Manual: >> >> "The TMS570 family is based on the ARM® CortexTM-R4F core. ARM has >> designed this core to be used in big-endian and little-endian systems. >> For the

Re: [Qemu-devel] [ARM] Cortex-R4F and VFP3-D16

2013-03-01 Thread Peter Maydell
On 1 March 2013 12:07, Fabien Chouteau wrote: > On 03/01/2013 12:32 PM, Peter Maydell wrote: >> I think you're going to have to run some tests on the actual >> hardware to find out what it really does. Specifically, what >> are the values of SCTLR.IE, SCTLR.EE and CPSR.E when you think >> you're i

Re: [Qemu-devel] Advice on some configuration parameters

2013-03-01 Thread Paolo Bonzini
Il 12/02/2013 14:05, Fabio Fantoni ha scritto: > I'm making patches to enable some qemu upstream features in xen that are > missing in libxl. > I'm trying to do it just by giving arguments to qemu, and I want them to > be dynamic (e.g. without physical addresses if possible) and concise. They shou

Re: [Qemu-devel] [PATCH] page_cache: use multiplicative hash for page position calculation

2013-03-01 Thread Laszlo Ersek
On 03/01/13 12:53, Peter Lieven wrote: > instead of a linear mapping we use a multiplicative hash > with the golden ratio to derive the cache bucket from the > address. this helps to reduce collisions if memory positions > are multiple of the cache size and it avoids a division > in the position ca

[Qemu-devel] [Bug 1129571] Re: libreoffice armhf FTBFS

2013-03-01 Thread John Rigby
Trying to build on a raring amd64 host in a raring armhf chroot, two failures so far. First time was a hang checking ant, an xlc-ls showed several java threads hung. Second time was a segfault again in java. So I have no problems reproducing this now locally. Hang seems like thread waiting for

Re: [Qemu-devel] libvirt<->QEMU interfaces for CPU models

2013-03-01 Thread Jiri Denemark
On Thu, Feb 21, 2013 at 11:58:18 -0300, Eduardo Habkost wrote: > Hi, > > After a long time trying to figure out the proper modelling inside QEMU, > I believe the plans are now clearer in QEMU, so it's time to coordinate > more closely with libvirt to try to make use of the new stuff. > > I tried

[Qemu-devel] [Bug 1129571] Re: libreoffice armhf FTBFS

2013-03-01 Thread Peter Maydell
John: you might also like to try with this patchset applied: http://lists.nongnu.org/archive/html/qemu-devel/2013-02/msg04207.html as that fixes one category of races. There are still other races that can cause segfaults and other problems (as the cover letter describes) but it's possible this pa

Re: [Qemu-devel] [PATCH] page_cache: use multiplicative hash for page position calculation

2013-03-01 Thread Peter Lieven
On 01.03.2013 13:50, Laszlo Ersek wrote: On 03/01/13 12:53, Peter Lieven wrote: instead of a linear mapping we use a multiplicative hash with the golden ratio to derive the cache bucket from the address. this helps to reduce collisions if memory positions are multiple of the cache size and it av

Re: [Qemu-devel] libvirt<->QEMU interfaces for CPU models

2013-03-01 Thread Jiri Denemark
On Thu, Feb 21, 2013 at 11:58:18 -0300, Eduardo Habkost wrote: > = Querying host capabilities = > > Requirement: libvirt needs to know which feature can really be enabled, before > it tries to start a VM, and before it tries to start a live-migration process. > > The set of available capabilities

[Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage

2013-03-01 Thread Peter Lieven
at the beginning of migration all pages are marked dirty and in the first round a bulk migration of all pages is performed. currently all these pages are copied to the page cache regardless if there are frequently updated or not. this doesn't make sense since most of these pages are never transfe

[Qemu-devel] [PATCH 02/18] hw: move fifo.[ch] to libqemuutil

2013-03-01 Thread Paolo Bonzini
fifo.c is generic code that can be easily unit tested. So it belongs in libqemuutil. Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/xilinx_spi.c | 2 +- hw/xilinx_spips.c | 2 +- include/migration/vmstate.h | 2 ++ hw/fifo.h

[Qemu-devel] [PATCH 01/18] hw: move char backends to backends/

2013-03-01 Thread Paolo Bonzini
Braille and msmouse support is in hw/, but it is not hardware. Move it to the backends/ directory. Signed-off-by: Paolo Bonzini --- backends/Makefile.objs | 4 {hw => backends}/baum.c| 4 ++-- {hw => backends}/msmouse.c | 2 +- hw/Makefile.objs | 4 +--- {h

[Qemu-devel] [PATCH 05/18] virtio-9p: use CONFIG_VIRTFS, not CONFIG_LINUX

2013-03-01 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/virtio-pci.h | 2 +- hw/virtio.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio-pci.h b/hw/virtio-pci.h index d24957c..e775525 100644 --- a/hw/virtio-pci.h +++ b/hw/virtio-pci.h @@ -75,7 +75,7 @@ struct VirtIOPCIProxy {

[Qemu-devel] [PATCH 00/18] hw/ reorganization, part 1: out of hw/ + into hw/ARCH

2013-03-01 Thread Paolo Bonzini
This series includes all the preparatory changes for reorganizing hw/. It also moves boards and CPU-specific files to hw/ARCH, for which there was clear consensus. The following changes since commit 288f1e3f87ec24abeac38399f175fe74243f7bc5: cadence_gem: Add debug msgs for rx desc movement (201

[Qemu-devel] [PATCH 03/18] hw: move qdev-monitor.o to toplevel directory

2013-03-01 Thread Paolo Bonzini
qdev-monitor.c is the only "core qdev" file that is not used in user-mode emulation, and it does not define anything that is used by hardware models. Remove it from the hw/ directory and remove hw/qdev-monitor.h from hw/qdev.h too; this requires some files to have some new explicitly includes. Si

[Qemu-devel] [PATCH 07/18] vt82c686: vt82c686 is not a PCI host bridge

2013-03-01 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/vt82c686.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/vt82c686.c b/hw/vt82c686.c index 2d8e398..c2b1bfc 100644 --- a/hw/vt82c686.c +++ b/hw/vt82c686.c @@ -26,8 +26,6 @@ #include "qemu/timer.h" #include "exec/address-spaces.h" -typedef uint32_t

[Qemu-devel] [PATCH 12/18] hw: move boards and other isolated files to hw/ARCH

2013-03-01 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/Makefile.objs | 1 - hw/alpha/Makefile.objs| 4 ++- hw/{alpha_dp264.c => alpha/dp264.c} | 0 hw/{alpha_pci.c => alpha/pci.c} | 0 hw/arm/Makefile.objs

[Qemu-devel] [PATCH 16/18] ppc: move files referencing CPU to hw/ppc/

2013-03-01 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/ppc/Makefile.objs| 13 ++--- hw/{ => ppc}/mpc8544_guts.c | 0 hw/{ => ppc}/ppc4xx_devs.c | 0 hw/{ => ppc}/ppce500_spin.c | 0 hw/{ => ppc}/spapr_vio.c| 0 hw/{ => ppc}/xics.c | 0 6 files changed, 6 insertions(+), 7 deletions(

[Qemu-devel] [PATCH 08/18] ppc: do not use ../ in include files

2013-03-01 Thread Paolo Bonzini
This simplifies the scripted execution of the next patch. Signed-off-by: Paolo Bonzini --- hw/ppc/e500-ccsr.h | 2 +- hw/ppc/e500plat.c | 2 +- hw/ppc/mpc8544ds.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ppc/e500-ccsr.h b/hw/ppc/e500-ccsr.h index f20f51b..12a2ba

[Qemu-devel] [PATCH 15/18] m68k: move files referencing CPU to hw/m68k/

2013-03-01 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/m68k/Makefile.objs| 3 ++- hw/{ => m68k}/mcf5206.c | 0 hw/{ => m68k}/mcf_intc.c | 0 3 files changed, 2 insertions(+), 1 deletion(-) rename hw/{ => m68k}/mcf5206.c (100%) rename hw/{ => m68k}/mcf_intc.c (100%) diff --git a/hw/m68k/Makefile.objs b/hw/m6

[Qemu-devel] [PATCH 06/18] virtio-9p: remove PCI dependencies from hw/9pfs/

2013-03-01 Thread Paolo Bonzini
Also move the 9p.h file to 9pfs/virtio-9p-device.h, for consistency with the corresponding .c file. Signed-off-by: Paolo Bonzini --- hw/9pfs/virtio-9p-device.c | 53 +--- hw/{9p.h => 9pfs/virtio-9p-device.h} | 4 +-- hw/9pfs/virtio-9p.c

[Qemu-devel] [PATCH 17/18] ppc: move more files to hw/ppc

2013-03-01 Thread Paolo Bonzini
These sPAPR files do not implement devices, move them over. Signed-off-by: Paolo Bonzini --- hw/ppc/Makefile.objs| 8 hw/{ => ppc}/spapr_events.c | 0 hw/{ => ppc}/spapr_hcall.c | 0 hw/{ => ppc}/spapr_iommu.c | 0 hw/{ => ppc}/spapr_rtas.c | 0 5 files changed, 4 insertions

[Qemu-devel] [PATCH 10/18] build: always link device_tree.o into emulators if libfdt available

2013-03-01 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.target | 1 + configure | 7 +-- hw/arm/Makefile.objs| 1 - hw/microblaze/Makefile.objs | 1 - hw/ppc/Makefile.objs| 1 - 5 files changed, 2 insertions(+), 9 deletions(-) diff --git a/Makefile.target b/Ma

[Qemu-devel] [PATCH 11/18] ppc: express FDT dependency of pSeries and e500 boards via default-configs/

2013-03-01 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 3 --- default-configs/ppc-softmmu.mak| 1 + default-configs/ppc64-softmmu.mak | 2 ++ default-configs/ppcemb-softmmu.mak | 1 + hw/ppc/Makefile.objs | 4 ++-- 5 files changed, 6 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH 14/18] i386: move files referencing CPU to hw/i386/

2013-03-01 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/i386/Makefile.objs| 4 +++- hw/{ => i386}/kvmvapic.c | 0 2 files changed, 3 insertions(+), 1 deletion(-) rename hw/{ => i386}/kvmvapic.c (100%) diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs index 5d071f4..a78c0b2 100644 --- a/hw/i386/Makefil

Re: [Qemu-devel] [ARM] Cortex-R4F and VFP3-D16

2013-03-01 Thread Fabien Chouteau
On 03/01/2013 01:16 PM, Peter Maydell wrote: > On 1 March 2013 12:07, Fabien Chouteau wrote: >> On 03/01/2013 12:32 PM, Peter Maydell wrote: >>> I think you're going to have to run some tests on the actual >>> hardware to find out what it really does. Specifically, what >>> are the values of SCTLR

Re: [Qemu-devel] [PATCH] Use qemu_open / qemu_close in rng backend

2013-03-01 Thread Eric Blake
[don't you also need to cc the main qemu list, even for trivial patches?] On 03/01/2013 05:53 AM, Stefan Berger wrote: > In the rng backend use qemu_open and qemu_close rather than POSIX > open/close. > > Signed-off-by: Stefan Berger Reviewed-by: Eric Blake > > diff --git a/backends/rng-rand

Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage

2013-03-01 Thread Eric Blake
On 03/01/2013 06:31 AM, Peter Lieven wrote: > at the beginning of migration all pages are marked dirty and > in the first round a bulk migration of all pages is performed. > > currently all these pages are copied to the page cache regardless > if there are frequently updated or not. this doesn't m

Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage

2013-03-01 Thread Paolo Bonzini
Il 01/03/2013 14:52, Eric Blake ha scritto: > On 03/01/2013 06:31 AM, Peter Lieven wrote: >> at the beginning of migration all pages are marked dirty and >> in the first round a bulk migration of all pages is performed. >> >> currently all these pages are copied to the page cache regardless >> if t

[Qemu-devel] [PATCH 13/18] arm: move files referencing CPU to hw/arm/

2013-03-01 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/arm/Makefile.objs | 13 - hw/{ => arm}/armv7m.c | 0 hw/{ => arm}/exynos4210.c | 0 hw/{ => arm}/omap1.c | 0 hw/{ => arm}/omap2.c | 0 hw/{ => arm}/pxa2xx.c | 0 hw/{ => arm}/pxa2xx_gpio.c | 0 hw/{ => arm}/pxa2xx

Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage

2013-03-01 Thread Peter Lieven
On 01.03.2013 14:52, Eric Blake wrote: On 03/01/2013 06:31 AM, Peter Lieven wrote: at the beginning of migration all pages are marked dirty and in the first round a bulk migration of all pages is performed. currently all these pages are copied to the page cache regardless if there are frequentl

[Qemu-devel] [PATCH 04/18] hw: move device-hotplug.o to toplevel, compile it once

2013-03-01 Thread Paolo Bonzini
The situation with device-hotplug.c is similar to qdev-monitor.c. Add a stub for pci_drive_hot_add, so that it can be compiled once, and move it out of hw/. Signed-off-by: Paolo Bonzini --- Makefile.objs | 2 +- hw/device-hotplug.c => device-hotplug.c | 13 ++--

Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage

2013-03-01 Thread Eric Blake
On 03/01/2013 07:06 AM, Peter Lieven wrote: >> Do you have any benchmark numbers? At any rate, the explanation seems >> sound, so a benchmark should show this. > > Do you have a particular test pattern in mind? If there is nothing going on > in the VM XBZRLE will not be better than normal copy at

Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage

2013-03-01 Thread Peter Lieven
On 01.03.2013 15:08, Eric Blake wrote: On 03/01/2013 07:06 AM, Peter Lieven wrote: Do you have any benchmark numbers? At any rate, the explanation seems sound, so a benchmark should show this. Do you have a particular test pattern in mind? If there is nothing going on in the VM XBZRLE will no

[Qemu-devel] [PATCH 18/18] sh: move files referencing CPU to hw/sh4/

2013-03-01 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/sh4/Makefile.objs | 4 +++- hw/{ => sh4}/sh7750.c | 0 hw/{ => sh4}/sh7750_regnames.c | 0 3 files changed, 3 insertions(+), 1 deletion(-) rename hw/{ => sh4}/sh7750.c (100%) rename hw/{ => sh4}/sh7750_regnames.c (100%) diff --git a/hw/sh4

Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage

2013-03-01 Thread Eric Blake
On 03/01/2013 07:13 AM, Peter Lieven wrote: > On 01.03.2013 15:08, Eric Blake wrote: >> On 03/01/2013 07:06 AM, Peter Lieven wrote: Do you have any benchmark numbers? At any rate, the explanation seems sound, so a benchmark should show this. >>> >>> Do you have a particular test pattern

Re: [Qemu-devel] [PATCH v2] pci: Teach PCI Bridges about VGA routing

2013-03-01 Thread Michael S. Tsirkin
On Thu, Feb 28, 2013 at 02:58:13PM -0700, Alex Williamson wrote: > Each PCI Bridge has a set of implied VGA regions that are enabled > when the VGA bit is set in the bridge control register. This allows > VGA devices behind bridges. > > Signed-off-by: Alex Williamson Off-topic: As I was review

Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage

2013-03-01 Thread Peter Lieven
On 01.03.2013 15:23, Eric Blake wrote: On 03/01/2013 07:13 AM, Peter Lieven wrote: On 01.03.2013 15:08, Eric Blake wrote: On 03/01/2013 07:06 AM, Peter Lieven wrote: Do you have any benchmark numbers? At any rate, the explanation seems sound, so a benchmark should show this. Do you have a p

Re: [Qemu-devel] libvirt<->QEMU interfaces for CPU models

2013-03-01 Thread Eduardo Habkost
On Fri, Mar 01, 2013 at 02:12:38PM +0100, Jiri Denemark wrote: > On Thu, Feb 21, 2013 at 11:58:18 -0300, Eduardo Habkost wrote: > > Hi, > > > > After a long time trying to figure out the proper modelling inside QEMU, > > I believe the plans are now clearer in QEMU, so it's time to coordinate > >

Re: [Qemu-devel] [ARM] Cortex-R4F and VFP3-D16

2013-03-01 Thread Fabien Chouteau
On 03/01/2013 02:43 PM, Fabien Chouteau wrote: > On 03/01/2013 01:16 PM, Peter Maydell wrote: >> On 1 March 2013 12:07, Fabien Chouteau wrote: >>> On 03/01/2013 12:32 PM, Peter Maydell wrote: I think you're going to have to run some tests on the actual hardware to find out what it really

Re: [Qemu-devel] [ARM] Cortex-R4F and VFP3-D16

2013-03-01 Thread Peter Maydell
On 1 March 2013 15:10, Fabien Chouteau wrote: > On 03/01/2013 02:43 PM, Fabien Chouteau wrote: >> On 03/01/2013 01:16 PM, Peter Maydell wrote: >>> OK, that makes sense. I think it's also a reasonable thing for >>> qemu's qemu-system-armeb model to present to the guest. Have >>> you changed QEMU to

[Qemu-devel] [PATCH v11 1/7] trace: [tracetool] Explicitly identify public backends

2013-03-01 Thread Lluís Vilanova
Public backends are those printed by "--list-backends" and thus considered valid by the configure script. Signed-off-by: Lluís Vilanova --- scripts/tracetool.py |4 ++-- scripts/tracetool/backend/__init__.py | 16 +++- scripts/tracetool/backend/dtrace.py |

[Qemu-devel] [PATCH v11 0/7] trace: Generic event state description

2013-03-01 Thread Lluís Vilanova
Provides a generic event state description structure (TraceEvent) and a more detailed event control and query interface. This is achieved by creating a new "non-public" tracing backend (i.e., not selectable by the user at configure time) that will generate the appropriate event description informa

[Qemu-devel] [PATCH v11 2/7] trace: Provide a generic tracing event descriptor

2013-03-01 Thread Lluís Vilanova
Uses tracetool to generate a backend-independent tracing event description (struct TraceEvent). The values for such structure are generated with the non-public "events" backend ("events-c" frontend). The generation of the defines to check if an event is statically enabled is also moved to the "ev

Re: [Qemu-devel] libvirt<->QEMU interfaces for CPU models

2013-03-01 Thread Eduardo Habkost
On Fri, Mar 01, 2013 at 02:28:37PM +0100, Jiri Denemark wrote: > On Thu, Feb 21, 2013 at 11:58:18 -0300, Eduardo Habkost wrote: > > = Querying host capabilities = > > > > Requirement: libvirt needs to know which feature can really be enabled, > > before > > it tries to start a VM, and before it t

[Qemu-devel] APIC-V and QEMU block IO performance

2013-03-01 Thread Benoît Canet
Hello lists, As a QEMU developper I am looking for a way to help improving qemu/kvm block performance for $customer. Having read about APIC-V on #qemu I looked at the intel manual in order to have an idea of what is an APIC and what is APIC-V. Here is a summary that I am posting so it can help

[Qemu-devel] [PATCH v11 3/7] trace: Provide a detailed event control interface

2013-03-01 Thread Lluís Vilanova
This interface decouples event obtaining from interaction. Events can be obtained through three different methods: * identifier * name * simple wildcard pattern Signed-off-by: Lluís Vilanova --- docs/tracing.txt | 44 --- trace/control-internal.h | 67 trac

[Qemu-devel] [PATCH v11 4/7] trace: [monitor] Use new event control interface

2013-03-01 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- monitor.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 32a6e74..e287c06 100644 --- a/monitor.c +++ b/monitor.c @@ -740,9 +740,18 @@ static void do_trace_event_set_state(Monitor *mon, const QDict

[Qemu-devel] [PATCH v11 5/7] trace: [default] Port to generic event information and new control interface

2013-03-01 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- trace/default.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/trace/default.c b/trace/default.c index c9b27a2..6e07a47 100644 --- a/trace/default.c +++ b/trace/default.c @@ -1,7 +1,7 @@ /* * Default implementation for backend init

[Qemu-devel] [PATCH v11 7/7] trace: [stderr] Port to generic event information and new control interface

2013-03-01 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/stderr.py | 27 --- trace/stderr.c | 34 ++ trace/stderr.h | 11 --- 3 files changed, 14 insertions(+), 58 deletions(-) dele

[Qemu-devel] [PATCH v11 6/7] trace: [simple] Port to generic event information and new control interface

2013-03-01 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/simple.py | 18 +- trace/simple.c | 32 +--- trace/simple.h |6 +- 3 files changed, 11 insertions(+), 45 deletions(-) diff --git a/scripts

Re: [Qemu-devel] Advice on some configuration parameters

2013-03-01 Thread Fabio Fantoni
Il 01/03/2013 13:45, Paolo Bonzini ha scritto: Il 12/02/2013 14:05, Fabio Fantoni ha scritto: I'm making patches to enable some qemu upstream features in xen that are missing in libxl. I'm trying to do it just by giving arguments to qemu, and I want them to be dynamic (e.g. without physical addr

Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage

2013-03-01 Thread Eric Blake
On 03/01/2013 07:50 AM, Peter Lieven wrote: > just a quick test on my desktop: > > ~/git/qemu$ x86_64-softmmu/qemu-system-x86_64 -k de -enable-kvm -m 1024 > -drive > if=virtio,file=iscsi://172.21.200.31/iqn.2001-05.com.equallogic:0-8a0906-16470e107-713001aa6de511e0-001-test/0 > -vnc :1 -boot dc -

Re: [Qemu-devel] [PATCH] check-qjson: More thorough testing of UTF-8 in strings

2013-03-01 Thread Markus Armbruster
Blue Swirl writes: > On Thu, Feb 28, 2013 at 7:42 PM, Markus Armbruster wrote: >> Blue Swirl writes: >> >>> On Thu, Feb 28, 2013 at 8:14 AM, Markus Armbruster >>> wrote: [...] Looks like the JSON formatter is not just broken (we knew that already), it's broken in machine-dependent w

[Qemu-devel] [Bug 1130769] Re: VirtFS (virtio-9p-pci) error: Parameter 'driver' expects device type

2013-03-01 Thread Tim Comer
Same result: -fsdev local,id=fsdev-fs0,path=/srv/files,security_model=passthrough,writeout=immediate -device virtio-9p-pci,fsdev=fsdev-fs0,mount_tag=files qemu-kvm: -device virtio-9p-pci,fsdev=fsdev-fs0,mount_tag=files: Parameter 'driver' expects device type Same result with a "shor

Re: [Qemu-devel] [PATCH v13 1/8] save/load cpu runstate

2013-03-01 Thread Eric Blake
On 03/01/2013 12:36 AM, Hu Tao wrote: > On Thu, Feb 28, 2013 at 02:12:37PM -0700, Eric Blake wrote: >> On 02/28/2013 05:13 AM, Hu Tao wrote: >>> This patch enables preservation of cpu runstate during save/load vm. >>> So when a vm is restored from snapshot, the cpu runstate is restored, >>> too. >>

Re: [Qemu-devel] [PATCH v13 5/8] add a new qevent: QEVENT_GUEST_PANICKED

2013-03-01 Thread Eric Blake
On 02/28/2013 05:13 AM, Hu Tao wrote: > This event will be emited when the guest is panicked. > > Signed-off-by: Wen Congyang > --- > include/monitor/monitor.h | 1 + > monitor.c | 1 + > 2 files changed, 2 insertions(+) Missing documentation in QMP/qmp-events.txt -- Eric Blak

Re: [Qemu-devel] [PATCH] pci vga: Support VGA behind bridges

2013-03-01 Thread Alex Williamson
On Thu, 2013-02-28 at 23:03 -0500, Kevin O'Connor wrote: > On Thu, Feb 28, 2013 at 10:52:49AM -0700, Alex Williamson wrote: > > We currently expect to find VGA devices on the root bus but we will > > also support them below bridges iff the VGA routing across the bridges > > is pre-configured. This

[Qemu-devel] [PATCH v3] pci: Teach PCI Bridges about VGA routing

2013-03-01 Thread Alex Williamson
Each PCI Bridge has a set of implied VGA regions that are enabled when the VGA bit is set in the bridge control register. This allows VGA devices behind bridges. Unfortunately with VGA Enable, which we formerly allowed but didn't back, comes along some required VGA baggage. VGA Palette Snooping

[Qemu-devel] [PATCH] pci_host: Drop write-only address_space field

2013-03-01 Thread Peter Maydell
The address_space field of PCIHostState was only ever written, never used. Drop it completely. Signed-off-by: Peter Maydell --- Noticed this when looking at converting versatile_pci to be a subclass of pci_host; it's nice to be able to drop the ugly fishing around in the object struct that the tw

Re: [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-03-01 Thread Eric Blake
On 03/01/2013 02:32 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-posix.c | 16 > qga/qapi-schema.json | 16 > 2 files changed, 32 insertions(+) > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index 0ad73f3..f159e25 100644 > --- a

[Qemu-devel] [PATCH v2] exec: make -mem-path filenames deterministic

2013-03-01 Thread peter
From: Peter Feiner Adds ramblocks' names to their backing files when using -mem-path. Eases introspection and debugging. Signed-off-by: Peter Feiner --- On Tue, Jan 8, 2013 at 2:04 PM, Anthony Liguori wrote: > > Yes, please submit the oneliner. Here it is :) The commit should probably be c

[Qemu-devel] [PATCH 3/4] target-arm: Fix VFP register byte order in GDB remote

2013-03-01 Thread Fabien Chouteau
>From GDB Remote Serial Protocol doc: "The bytes with the register are transmitted in target byte order." Signed-off-by: Fabien Chouteau --- target-arm/helper.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index e9

[Qemu-devel] [PATCH 2/4] Add default config for armeb-softmmu

2013-03-01 Thread Fabien Chouteau
Just create one that includes arm-softmmu.mak. Signed-off-by: Fabien Chouteau --- default-configs/armeb-softmmu.mak |3 +++ 1 file changed, 3 insertions(+) create mode 100644 default-configs/armeb-softmmu.mak diff --git a/default-configs/armeb-softmmu.mak b/default-configs/armeb-softmmu.m

[Qemu-devel] [PATCH 1/4] QAPI: Add ARMEB target-type

2013-03-01 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- qapi-schema.json |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 28b070f..0615715 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -2993,10 +2993,11 @@ # Since: 1.2.0 ## { 'enum

[Qemu-devel] [PATCH 4/4] target-arm: always set endian bits in big-endian mode

2013-03-01 Thread Fabien Chouteau
CPSR.E, SCTLR.EE and SCTLR.IE Signed-off-by: Fabien Chouteau --- target-arm/cpu.c| 11 +++ target-arm/helper.c | 18 ++ 2 files changed, 29 insertions(+) diff --git a/target-arm/cpu.c b/target-arm/cpu.c index 5dfcb74..354843e 100644 --- a/target-arm/cpu.c +++ b/t

[Qemu-devel] [PATCH 0/4] ARM: Misc ARM big-endian bug fixes

2013-03-01 Thread Fabien Chouteau
Fabien Chouteau (4): QAPI: Add ARMEB target-type Add default config for armeb-softmmu target-arm: Fix VFP register byte order in GDB remote target-arm: always set endian bits in big-endian mode default-configs/armeb-softmmu.mak |3 +++ qapi-schema.json |9 +--

Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-01 Thread Eric Blake
On 03/01/2013 02:33 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-posix.c | 55 > > qga/qapi-schema.json | 27 ++ > 2 files changed, 82 insertions(+) > > diff --git a/qga/commands-posix.c b/qga/command

Re: [Qemu-devel] [Bug 1130769] Re: VirtFS (virtio-9p-pci) error: Parameter 'driver' expects device type

2013-03-01 Thread Markus Armbruster
Tim Comer writes: > Same result: > > -fsdev > local,id=fsdev-fs0,path=/srv/files,security_model=passthrough,writeout=immediate > -device virtio-9p-pci,fsdev=fsdev-fs0,mount_tag=files > > qemu-kvm: -device virtio-9p-pci,fsdev=fsdev-fs0,mount_tag=files: > Parameter 'driver' expects devi

[Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-01 Thread Michael Roth
Hosts hold on to handles provided by guest-file-open for periods that can span beyond the life of the qemu-ga process that issued them. Since these are issued starting from 0 on every restart, we run the risk of issuing duplicate handles after restarts/reboots. As a result, users with a stale copy

  1   2   >