On Thu, Feb 28, 2013 at 01:55:58PM +0000, Daniel P. Berrange wrote: > On Thu, Feb 28, 2013 at 02:49:51PM +0100, Stefan Hajnoczi wrote: > > On Wed, Feb 27, 2013 at 04:49:16PM +0000, Daniel P. Berrange wrote: > > > On Wed, Feb 27, 2013 at 03:05:47PM +0100, Stefan Hajnoczi wrote: > > > > Reduce -netdev socket latency by disabling the Nagle algorithm on > > > > SOCK_STREAM sockets in net/socket.c. Since we are tunelling Ethernet > > > > over TCP we shouldn't artificially delay outgoing packets, let the guest > > > > decide packet scheduling. > > > > > > > > I already get sub-millisecond -netdev socket ping times on localhost, so > > > > there was no measurable difference in my testing. This won't hurt > > > > though and may improve remote socket performance. > > > > > > > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > > > > > > ACK. > > > > > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > > > Hi Dan, > > QEMU usually only uses Singed-off-by: for authors and subsystem > > maintainers who merge the patch. > > Ah, ok. > > > > > Is it okay if I add a Reviewed-by: Daniel P. Berrange > > <berra...@redhat.com> instead? > > Of course.
Thanks, done. Stefan
