Re: [Qemu-devel] q35 machine type and libvirt.

2013-02-07 Thread Markus Armbruster
Cc'ing a few QOMmers... Laine Stump writes: > Now that qemu is getting the q35 machine type, libvirt needs to support it. > > As far as I understand, from libvirt's point of view, q35 is just > another x86_64 system, but with a different set of implicit devices, > and possibly some extra rules l

Re: [Qemu-devel] [PATCH v3 08/10] aio: extract aio_dispatch() from aio_poll()

2013-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 07:24:42PM +0100, Laszlo Ersek wrote: > On 02/04/13 13:12, Stefan Hajnoczi wrote: > > We will need to loop over AioHandlers calling ->io_read()/->io_write() > > when aio_poll() is converted from select(2) to g_poll(2). > > > > Luckily the code for this already exists, extra

Re: [Qemu-devel] q35 machine type and libvirt.

2013-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2013 at 09:22:35AM +0100, Markus Armbruster wrote: > Ceterum censeo we need full qdevification plaxi

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2013 at 11:33:04AM +1030, Rusty Russell wrote: > Vadim Rozenfeld writes: > > On Tue, 2013-02-05 at 13:58 +0200, Michael S. Tsirkin wrote: > >> On Tue, Feb 05, 2013 at 03:45:38PM +0400, Michael Tokarev wrote: > >> Is it really > >> > that bad that the config space size changed? Wh

Re: [Qemu-devel] [PATCH for-1.4] net: fix infinite loop on exit

2013-02-07 Thread Amos Kong
On Wed, Feb 06, 2013 at 06:25:48PM -0600, Michael Roth wrote: > 1ceef9f27359cbe92ef124bf74de6f792e71f6fb added handling for cleaning > up multiple queues in qemu_del_nic() for cases where multiqueue is in > use. To determine the number of queues it looks at nic->conf->queues, > then iterates throug

Re: [Qemu-devel] [PATCH v3 09/10] aio: convert aio_poll() to g_poll(3)

2013-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 10:05:15PM +0100, Laszlo Ersek wrote: > comments in-line > > On 02/04/13 13:12, Stefan Hajnoczi wrote: > > AioHandler already has a GPollFD so we can directly use its > > events/revents. > > > > Add the int pollfds_idx field to AioContext so we can map g_poll(3) > > results

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Michael S. Tsirkin
On Tue, Feb 05, 2013 at 05:47:16PM -0600, Jesse Larrew wrote: > Currently, the config size for virtio devices is hard coded. When a new > feature is added that changes the config size, drivers that assume a static > config size will break. For purposes of backward compatibility, there needs > to be

Re: [Qemu-devel] [PATCH] s390x: silence warning from GCC on uninitialized values

2013-02-07 Thread Cornelia Huck
On Tue, 5 Feb 2013 10:27:00 +0100 Cornelia Huck wrote: > On Mon, 04 Feb 2013 22:57:43 +0100 > Stefan Weil wrote: > > > Am 04.02.2013 22:23, schrieb Anthony Liguori: > > > As best I can tell, this is a false positive. > > > > > > [aliguori@ccnode4 qemu-s390]$ make > > > CCs390x-softmmu

Re: [Qemu-devel] [RFC PATCH v1] iov: Factor out hexdumper

2013-02-07 Thread Stefan Hajnoczi
On Thu, Feb 07, 2013 at 04:22:02PM +1000, Peter Crosthwaite wrote: > diff --git a/util/hexdump.c b/util/hexdump.c > new file mode 100644 > index 000..38d64ca > --- /dev/null > +++ b/util/hexdump.c > @@ -0,0 +1,23 @@ License/copyright header missing. Looks good otherwise. Stefan

Re: [Qemu-devel] [PATCH V2 0/3] set config size using available features

2013-02-07 Thread Michael S. Tsirkin
On Wed, Feb 06, 2013 at 07:45:15PM -0600, Anthony Liguori wrote: > Jesse Larrew writes: > > > This patch set fixes an issue with virtio Windows drivers when multiqueue > > is enabled. This is a narrow fix for 1.4, and I intend to generalize the > > approach for all virtio devices in 1.5. > > I a

Re: [Qemu-devel] [PATCH for-1.4] net: fix infinite loop on exit

2013-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 06:25:48PM -0600, Michael Roth wrote: > 1ceef9f27359cbe92ef124bf74de6f792e71f6fb added handling for cleaning > up multiple queues in qemu_del_nic() for cases where multiqueue is in > use. To determine the number of queues it looks at nic->conf->queues, > then iterates throug

Re: [Qemu-devel] [PATCH 1/3] virtio-net: pass host features to virtio_net_init

2013-02-07 Thread KONRAD Frédéric
On 06/02/2013 00:47, Jesse Larrew wrote: From: Anthony Liguori Signed-off-by: Anthony Liguori --- hw/s390x/s390-virtio-bus.c | 3 ++- hw/s390x/virtio-ccw.c | 3 ++- hw/virtio-net.c| 3 ++- hw/virtio-pci.c| 3 ++- hw/virtio.h| 3 ++- 5 files c

[Qemu-devel] [PATCHv2 0/2] virtio-net: mq feature fixes

2013-02-07 Thread Michael S. Tsirkin
mq feature is not needed: we can look at the number of queues and set the flag accordingly. Removing this feature removes ambiguity (what does it mean to have queues=2 with mq=off?). Changes from v1: - split the patch so each one can be applied separately - add comments as suggested by mjt Signed

Re: [Qemu-devel] [RFC V6 09/33] qcow2: Implement qcow2_compute_cluster_hash.

2013-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 01:31:42PM +0100, Benoît Canet wrote: > diff --git a/configure b/configure > index 0657b1a..389f8aa 100755 > --- a/configure > +++ b/configure > @@ -1749,6 +1749,28 @@ EOF > fi > > ## > +# QCOW Deduplication gnutls detection > +cat

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-07 Thread Vadim Rozenfeld
On Thu, 2013-02-07 at 11:33 +1030, Rusty Russell wrote: > Vadim Rozenfeld writes: > > On Tue, 2013-02-05 at 13:58 +0200, Michael S. Tsirkin wrote: > >> On Tue, Feb 05, 2013 at 03:45:38PM +0400, Michael Tokarev wrote: > >> Is it really > >> > that bad that the config space size changed? Why it ha

Re: [Qemu-devel] [RFC V6 10/33] qcow2: Extract qcow2_dedup_grow_table

2013-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 01:31:43PM +0100, Benoît Canet wrote: > diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c > index 63a7241..dbcb6d2 100644 > --- a/block/qcow2-cluster.c > +++ b/block/qcow2-cluster.c > @@ -29,44 +29,48 @@ > #include "block/qcow2.h" > #include "trace.h" > > -int q

[Qemu-devel] [PATCHv2 1/2] virtio-net: remove mq feature

2013-02-07 Thread Michael S. Tsirkin
mq feature is not needed: we can look at the number of queues and set the flag accordingly. Removing this feature removes ambiguity (what does it mean to have queues=2 with mq=off?). Signed-off-by: Michael S. Tsirkin --- These are just the bits that remove the feature. The windows bug workaround

Re: [Qemu-devel] [RFC V6 13/33] qcow2: make the deduplication forget a cluster hash when a cluster is to dedupe

2013-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 01:31:46PM +0100, Benoît Canet wrote: > diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c > index ef91216..5b1d20d 100644 > --- a/block/qcow2-cluster.c > +++ b/block/qcow2-cluster.c > @@ -710,6 +710,7 @@ int qcow2_alloc_cluster_link_l2(BlockDriverState *bs, > QCowL

Re: [Qemu-devel] [RFC V6 14/33] qcow2: Create qcow2_is_cluster_to_dedup.

2013-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 01:31:47PM +0100, Benoît Canet wrote: > diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c > index 5b1d20d..fedcf57 100644 > --- a/block/qcow2-cluster.c > +++ b/block/qcow2-cluster.c > @@ -514,6 +514,58 @@ out: > return ret; > } > > +/* Check if a cluster is

Re: [Qemu-devel] [RFC V6 15/33] qcow2: Load and save deduplication table header extension.

2013-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 01:31:48PM +0100, Benoît Canet wrote: > @@ -148,6 +158,19 @@ static int qcow2_read_extensions(BlockDriverState *bs, > uint64_t start_offset, > } > break; > > +case QCOW2_EXT_MAGIC_DEDUP_TABLE: > +ret = bdrv_pread(bs->file,

Re: [Qemu-devel] [RFC V6 12/33] qcow2: Makes qcow2_alloc_cluster_link_l2 mark to deduplicate clusters.

2013-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 01:31:45PM +0100, Benoît Canet wrote: > --- > block/qcow2-cluster.c |8 ++-- > block/qcow2-dedup.c |7 +++ > block/qcow2.h |3 +++ > 3 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster

Re: [Qemu-devel] [RFC V6 16/33] qcow2: Extract qcow2_do_table_init.

2013-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 01:31:49PM +0100, Benoît Canet wrote: > diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c > index 296c440..9c16816 100644 > --- a/block/qcow2-refcount.c > +++ b/block/qcow2-refcount.c > @@ -31,27 +31,44 @@ static int64_t alloc_clusters_noref(BlockDriverState *bs,

Re: [Qemu-devel] [RFC V6 18/33] qcow2: Extract qcow2_add_feature and qcow2_remove_feature.

2013-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 01:31:51PM +0100, Benoît Canet wrote: > diff --git a/block/qcow2.c b/block/qcow2.c > index e48f0b0..ad202fa 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -239,61 +239,72 @@ static void report_unsupported_feature(BlockDriverState > *bs, > } > > /* > - * Sets th

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2013 at 08:24:10PM +1100, Vadim Rozenfeld wrote: > On Thu, 2013-02-07 at 11:33 +1030, Rusty Russell wrote: > > Vadim Rozenfeld writes: > > > On Tue, 2013-02-05 at 13:58 +0200, Michael S. Tsirkin wrote: > > >> On Tue, Feb 05, 2013 at 03:45:38PM +0400, Michael Tokarev wrote: > > >>

Re: [Qemu-devel] [RFC V6 19/33] block: Add qcow2_dedup format and image creation code.

2013-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 01:31:52PM +0100, Benoît Canet wrote: > diff --git a/block/qcow2.c b/block/qcow2.c > index ad202fa..9cbb2f0 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -277,6 +277,11 @@ int qcow2_mark_dirty(BlockDriverState *bs) > return qcow2_add_feature(bs, QCOW2_INCOMPAT

[Qemu-devel] [PATCHv2 2/2] virtio-net: work around for windows driver bug

2013-02-07 Thread Michael S. Tsirkin
Windows drivers from 22 Jan 2013 and older fail when config size != 32, which was the size before max_virtqueue_pairs was added. Force config size to a value these drivers expect to avoid breakage unless we really need max_virtqueue_pairs. Signed-off-by: Michael S. Tsirkin --- hw/virtio-net.c |

Re: [Qemu-devel] [RFC V6 21/33] qcow2: Drop hash for a given cluster when dedup makes refcount > 2^16/2.

2013-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 01:31:54PM +0100, Benoît Canet wrote: > diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c > index a932ff6..fa2559f 100644 > --- a/block/qcow2-refcount.c > +++ b/block/qcow2-refcount.c > @@ -489,6 +489,9 @@ int QEMU_WARN_UNUSED_RESULT > update_refcount(BlockDriver

Re: [Qemu-devel] [RFC V6 20/33] qcow2: Add a deduplication boolean to update_refcount.

2013-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 01:31:53PM +0100, Benoît Canet wrote: > @@ -427,7 +427,7 @@ fail_block: > > /* XXX: cache several refcount block clusters ? */ > int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs, > -int64_t offset, int64_t length, int addend) > +int64_t offset, in

Re: [Qemu-devel] [RFC V6 22/33] qcow2: Remove hash when cluster is deleted.

2013-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 01:31:55PM +0100, Benoît Canet wrote: > diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c > index 4819eb3..1ed219d 100644 > --- a/block/qcow2-dedup.c > +++ b/block/qcow2-dedup.c > @@ -942,6 +942,32 @@ int qcow2_dedup_store_new_hashes(BlockDriverState *bs, > return

Re: [Qemu-devel] [PATCH] m25p80.c: Use QOM classes for part differentiation

2013-02-07 Thread Andreas Färber
Am 07.02.2013 06:51, schrieb Peter Crosthwaite: > Currently, M25P80 uses an object property to differentiate between flash > parts. > Changed this over to use QOM sub-classes - the actual names of the different > parts > are used to create a set of dynamic classes which passes the part info as >

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-07 Thread Vadim Rozenfeld
On Thu, 2013-02-07 at 12:18 +0200, Michael S. Tsirkin wrote: > On Thu, Feb 07, 2013 at 08:24:10PM +1100, Vadim Rozenfeld wrote: > > On Thu, 2013-02-07 at 11:33 +1030, Rusty Russell wrote: > > > Vadim Rozenfeld writes: > > > > On Tue, 2013-02-05 at 13:58 +0200, Michael S. Tsirkin wrote: > > > >> On

Re: [Qemu-devel] [PATCH v1 0/2] DTC as submodule

2013-02-07 Thread Andreas Färber
Am 07.02.2013 07:08, schrieb Peter Crosthwaite: > These two patches add and use dtc as a submodule as per the RFC: > > http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg05000.html > > There is a remaining action item to mandate libfdt for arm/microblaze and PPC > which is left as follow up

[Qemu-devel] [PATCH] pseries: Implements h_read hcall

2013-02-07 Thread Erlon Cruz
From: Erlon Cruz This h_call is useful for DLPAR in future amongst other things. Given an index it fetches the corresponding PTE stored in the htab. Signed-off-by: Erlon Cruz --- hw/spapr_hcall.c | 58 ++ 1 file changed, 58 insertions(+) d

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2013 at 09:53:39PM +1100, Vadim Rozenfeld wrote: > On Thu, 2013-02-07 at 12:18 +0200, Michael S. Tsirkin wrote: > > On Thu, Feb 07, 2013 at 08:24:10PM +1100, Vadim Rozenfeld wrote: > > > On Thu, 2013-02-07 at 11:33 +1030, Rusty Russell wrote: > > > > Vadim Rozenfeld writes: > > > >

Re: [Qemu-devel] [PATCH v3 20/20] arm: add Faraday FTSPI020 SPI flash controller support

2013-02-07 Thread Andreas Färber
Am 07.02.2013 07:59, schrieb Kuo-Jung Su: > 2013/2/7 Peter Crosthwaite : >> On Wed, Feb 6, 2013 at 7:45 PM, Kuo-Jung Su wrote: >>> diff --git a/hw/arm/ftspi020.h b/hw/arm/ftspi020.h >>> new file mode 100644 >>> index 000..a8a0930 >>> --- /dev/null >>> +++ b/hw/arm/ftspi020.h >>> @@ -0,0 +1,50

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-07 Thread Vadim Rozenfeld
On Thu, 2013-02-07 at 13:33 +0200, Michael S. Tsirkin wrote: > On Thu, Feb 07, 2013 at 09:53:39PM +1100, Vadim Rozenfeld wrote: > > On Thu, 2013-02-07 at 12:18 +0200, Michael S. Tsirkin wrote: > > > On Thu, Feb 07, 2013 at 08:24:10PM +1100, Vadim Rozenfeld wrote: > > > > On Thu, 2013-02-07 at 11:33

Re: [Qemu-devel] [PATCH V20 1/8] Support for TPM command line options

2013-02-07 Thread Stefan Berger
On 02/04/2013 06:21 AM, Luiz Capitulino wrote: On Fri, 01 Feb 2013 10:33:01 -0500 Corey Bryant wrote: +## +# @TPMInfo: +# +# Information about the TPM +# +# @model: The TPM frontend model, i.e., tpm-tis +# +# @id: The ID of the TPM +# +# @type: The type of TPM backend, i.e., passthrough +# +#

Re: [Qemu-devel] [PATCH V20 1/8] Support for TPM command line options

2013-02-07 Thread Stefan Berger
On 02/01/2013 10:33 AM, Corey Bryant wrote: +monitor_printf(mon, "TPM device:\n"); + +for (info = info_list; info; info = info->next) { +TPMInfo *ti = info->value; +monitor_printf(mon, " tpm%d: model=%s\n", + c, ti->model); +monitor_printf(mon

Re: [Qemu-devel] [PATCH v3 20/20] arm: add Faraday FTSPI020 SPI flash controller support

2013-02-07 Thread Andreas Färber
Am 07.02.2013 13:04, schrieb Peter Maydell: > On 7 February 2013 11:50, Andreas Färber wrote: >> Am 07.02.2013 07:59, schrieb Kuo-Jung Su: > +/** > + * FTSPI020 registers > + >

[Qemu-devel] [PATCH for-1.4 0/2] s390: I/O interrupt fixes.

2013-02-07 Thread Cornelia Huck
Hi, here are two fixes for the new s390 I/O interrupt code that I'd really want to have in 1.4. The first patch has already been sent (see http://marc.info/?l=qemu-devel&m=136005644027411&w=2). The second one fixes a thinko in the isc handling code. Patches are against master, as s390-next is m

[Qemu-devel] [PATCH 2/2] s390: Fix handling of iscs.

2013-02-07 Thread Cornelia Huck
There are two ways to express an interruption subclass: - As a bitmask, as used in cr6. - As a number, as used in the I/O interruption word. Unfortunately, we have treated to I/O interruption word as if it contained the bitmask as well, which went unnoticed so far as - (queued-for-next) kvm made t

[Qemu-devel] [PATCH 1/2] s390: Keep I/O interrupts enabled for all iscs.

2013-02-07 Thread Cornelia Huck
do_io_interrupt() would stop scanning further iscs if it found an I/O interrupt it could inject. This might cause the pending interrupt indication for I/O interrupts to be reset although there might be queued I/O interrupts for subsequent iscs. Fix this by reordering the logic: Inject the I/O inte

Re: [Qemu-devel] [PATCH v3 20/20] arm: add Faraday FTSPI020 SPI flash controller support

2013-02-07 Thread Peter Maydell
On 7 February 2013 11:50, Andreas Färber wrote: > Am 07.02.2013 07:59, schrieb Kuo-Jung Su: +/** + * FTSPI020 registers + */

Re: [Qemu-devel] [PATCH 2/2] qxl: change rom size to 8192

2013-02-07 Thread Alon Levy
> On 02/06/2013 05:52 PM, Cole Robinson wrote: > > On 01/22/2013 05:09 AM, Gerd Hoffmann wrote: > >> From: Alon Levy > >> > >> This is a simpler solution to 869981, where migration breaks since > >> qxl's > >> rom bar size has changed. Instead of ignoring fields in QXLRom, > >> which is what has >

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-07 Thread Yan Vugenfirer
On Feb 7, 2013, at 1:46 PM, Vadim Rozenfeld wrote: > On Thu, 2013-02-07 at 13:33 +0200, Michael S. Tsirkin wrote: >> On Thu, Feb 07, 2013 at 09:53:39PM +1100, Vadim Rozenfeld wrote: >>> On Thu, 2013-02-07 at 12:18 +0200, Michael S. Tsirkin wrote: On Thu, Feb 07, 2013 at 08:24:10PM +1100, Vad

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2013 at 03:02:45PM +0200, Yan Vugenfirer wrote: > > On Feb 7, 2013, at 1:46 PM, Vadim Rozenfeld wrote: > > > On Thu, 2013-02-07 at 13:33 +0200, Michael S. Tsirkin wrote: > >> On Thu, Feb 07, 2013 at 09:53:39PM +1100, Vadim Rozenfeld wrote: > >>> On Thu, 2013-02-07 at 12:18 +0200,

Re: [Qemu-devel] [PATCH v3 20/20] arm: add Faraday FTSPI020 SPI flash controller support

2013-02-07 Thread Paolo Bonzini
Il 07/02/2013 13:13, Andreas Färber ha scritto: > Am 07.02.2013 13:04, schrieb Peter Maydell: >> On 7 February 2013 11:50, Andreas Färber wrote: >>> Am 07.02.2013 07:59, schrieb Kuo-Jung Su: >> +/** >> + * FTSPI020

Re: [Qemu-devel] [RFC for-1.4] Revert "block: fix block tray status"

2013-02-07 Thread Kevin Wolf
Am 06.02.2013 21:02, schrieb Luiz Capitulino: > This reverts commit 9ca111544c64b5abed2e79cf52e19a8f227b347b. > > That commit has added a weird side effect to QMP: on shutdown, > QMP emits the DEVICE_TRAY_MOVED event for all empty drives > that have closed trays. > > This happens because the tray

Re: [Qemu-devel] [RFC for-1.4] Revert "block: fix block tray status"

2013-02-07 Thread Luiz Capitulino
On Thu, 07 Feb 2013 14:12:10 +0100 Kevin Wolf wrote: > Am 06.02.2013 21:02, schrieb Luiz Capitulino: > > This reverts commit 9ca111544c64b5abed2e79cf52e19a8f227b347b. > > > > That commit has added a weird side effect to QMP: on shutdown, > > QMP emits the DEVICE_TRAY_MOVED event for all empty dr

Re: [Qemu-devel] [PATCH v3 20/20] arm: add Faraday FTSPI020 SPI flash controller support

2013-02-07 Thread Peter Maydell
On 7 February 2013 12:13, Andreas Färber wrote: > Am 07.02.2013 13:04, schrieb Peter Maydell: >> Do we really want to change the public/private boundaries of >> our source code just for the benefit of the test framework? Ugh. > > The truth is (and that applies to the hw/ refactoring series as well

Re: [Qemu-devel] [RFC for-1.4] Revert "block: fix block tray status"

2013-02-07 Thread Kevin Wolf
Am 07.02.2013 14:15, schrieb Luiz Capitulino: > On Thu, 07 Feb 2013 14:12:10 +0100 > Kevin Wolf wrote: >> I think the right solution is to move the bdrv_dev_change_media_cb() >> call to those callers of bdrv_close() that actually need it. I haven't >> checked it yet in detail, but at the first sig

Re: [Qemu-devel] [RFC for-1.4] Revert "block: fix block tray status"

2013-02-07 Thread Luiz Capitulino
On Thu, 07 Feb 2013 14:28:33 +0100 Kevin Wolf wrote: > Am 07.02.2013 14:15, schrieb Luiz Capitulino: > > On Thu, 07 Feb 2013 14:12:10 +0100 > > Kevin Wolf wrote: > >> I think the right solution is to move the bdrv_dev_change_media_cb() > >> call to those callers of bdrv_close() that actually nee

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-07 Thread Laszlo Ersek
Apologies in advance for asking a possibly exorbitantly lame question... On 02/06/13 10:47, Vadim Rozenfeld wrote: > On Tue, 2013-02-05 at 13:58 +0200, Michael S. Tsirkin wrote: >> On Tue, Feb 05, 2013 at 03:45:38PM +0400, Michael Tokarev wrote: >>> 05.02.2013 15:31, Vadim Rozenfeld wrote: On

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2013 at 02:33:28PM +0100, Laszlo Ersek wrote: > Apologies in advance for asking a possibly exorbitantly lame question... > > On 02/06/13 10:47, Vadim Rozenfeld wrote: > > On Tue, 2013-02-05 at 13:58 +0200, Michael S. Tsirkin wrote: > >> On Tue, Feb 05, 2013 at 03:45:38PM +0400, Mic

Re: [Qemu-devel] [PATCHv2 0/2] virtio-net: mq feature fixes

2013-02-07 Thread Stefan Hajnoczi
On Thu, Feb 07, 2013 at 11:26:03AM +0200, Michael S. Tsirkin wrote: > mq feature is not needed: we can look at the number of queues and set > the flag accordingly. > Removing this feature removes ambiguity (what does it mean to have > queues=2 with mq=off?). > > Changes from v1: > - split the patc

Re: [Qemu-devel] [PATCHv2 0/2] virtio-net: mq feature fixes

2013-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2013 at 02:54:19PM +0100, Stefan Hajnoczi wrote: > On Thu, Feb 07, 2013 at 11:26:03AM +0200, Michael S. Tsirkin wrote: > > mq feature is not needed: we can look at the number of queues and set > > the flag accordingly. > > Removing this feature removes ambiguity (what does it mean t

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Stefan Hajnoczi
On Tue, Feb 05, 2013 at 05:47:16PM -0600, Jesse Larrew wrote: > diff --git a/hw/virtio-net.c b/hw/virtio-net.c > index f1c2884..8f521b3 100644 > --- a/hw/virtio-net.c > +++ b/hw/virtio-net.c > @@ -73,8 +73,31 @@ typedef struct VirtIONet > int multiqueue; > uint16_t max_queues; > uint

Re: [Qemu-devel] [PATCHv2 0/2] virtio-net: mq feature fixes

2013-02-07 Thread Laszlo Ersek
On 02/07/13 10:26, Michael S. Tsirkin wrote: > mq feature is not needed: we can look at the number of queues and set > the flag accordingly. > Removing this feature removes ambiguity (what does it mean to have > queues=2 with mq=off?). > > Changes from v1: > - split the patch so each one can be ap

[Qemu-devel] Sigsegv error when create JVM, called by bdrv_create in block.c

2013-02-07 Thread harryxiyou
HI all : I write a new block driver based on hdfs of hadoop, it need to connect to hdfs when create step (called by bdrv_create in block.c) by use libhdfs ( hdfs c++ api) 。 libhdfs use jni api to will create jvm . The problem is —— it will cause sigsegv error when create jvm . #0 0x000

Re: [Qemu-devel] [PATCH 2/5] target-i386: Split command line parsing out of cpu_x86_register()

2013-02-07 Thread Eduardo Habkost
On Tue, Feb 05, 2013 at 05:39:21PM +0100, Igor Mammedov wrote: > From: Andreas Färber > > In order to instantiate a CPU subtype we will need to know which type, > so move the cpu_model splitting into cpu_x86_init(). > > Parameters need to be set on the X86CPU instance, so move > cpu_x86_parse_fe

Re: [Qemu-devel] [RFC] configuring thin provisioning for drives

2013-02-07 Thread Paolo Bonzini
Il 06/02/2013 19:37, Kevin Wolf ha scritto: >> I'll call these "full", "anchor", "unmap". Kevin pointed out to me that >> you may need to control these at both the format and protocol levels, >> which gives 9 possibilities. At the API level there is no problem >> supporting all of them, but what

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Laszlo Ersek
On 02/07/13 09:55, Michael S. Tsirkin wrote: > On Tue, Feb 05, 2013 at 05:47:16PM -0600, Jesse Larrew wrote: >> Currently, the config size for virtio devices is hard coded. When a new >> feature is added that changes the config size, drivers that assume a static >> config size will break. For purpo

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-07 Thread Eduardo Habkost
On Tue, Feb 05, 2013 at 05:39:22PM +0100, Igor Mammedov wrote: > From: Andreas Färber > > Move x86_def_t definition to header and embed into X86CPUClass. > Register types per built-in model definition. > > Move version initialization from x86_cpudef_setup() to class_init. > > Inline cpu_x86_reg

Re: [Qemu-devel] [PATCH 4/5] Remove cpudef_setup() hooks

2013-02-07 Thread Eduardo Habkost
On Tue, Feb 05, 2013 at 05:39:23PM +0100, Igor Mammedov wrote: > From: Andreas Färber > > QOM (and KVM) infrastructure have obsoleted x86_cpudef_setup(). > Drop the conditional callers that are now unused. > > Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost > --- > arch_init.c

Re: [Qemu-devel] [PATCH 2/2] qxl: change rom size to 8192

2013-02-07 Thread Cole Robinson
On 02/07/2013 07:31 AM, Alon Levy wrote: >> On 02/06/2013 05:52 PM, Cole Robinson wrote: >>> On 01/22/2013 05:09 AM, Gerd Hoffmann wrote: From: Alon Levy This is a simpler solution to 869981, where migration breaks since qxl's rom bar size has changed. Instead of ignoring

Re: [Qemu-devel] Google Summer of Code 2013 ideas wiki open

2013-02-07 Thread Stefan Hajnoczi
On Thu, Feb 7, 2013 at 4:19 PM, Stefan Hajnoczi wrote: CCed libvir-list to see if libvirt would like to do a joint application with QEMU. As mentioned, it's early days and GSoC 2013 has not been announced yet. I just want to start gathering ideas and seeing who is willing to mentor this year. S

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Stefan Hajnoczi
On Thu, Feb 7, 2013 at 3:43 PM, Laszlo Ersek wrote: > Instead, what about > > #define endof(container, field) \ > (offsetof(container, field) + sizeof ((container *)0)->field) As mentioned in my reply, I think endof() isn't necessary. Just use offsetof() the *next* field or sizeof() the enti

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2013 at 03:43:51PM +0100, Laszlo Ersek wrote: > #define endof(container, field) \ > (offsetof(container, field) + sizeof ((container *)0)->field) Indeed, this looks cleaner.

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Laszlo Ersek
On 02/07/13 15:43, Laszlo Ersek wrote: > On 02/07/13 09:55, Michael S. Tsirkin wrote: >> On Tue, Feb 05, 2013 at 05:47:16PM -0600, Jesse Larrew wrote: >>> +#define endof(container, field) \ >>> +((intptr_t)(&(((container *)0)->field)+1)) >> > Furthermore, taking the pointer to "one past" &fie

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Laszlo Ersek
On 02/07/13 16:22, Stefan Hajnoczi wrote: > On Thu, Feb 7, 2013 at 3:43 PM, Laszlo Ersek wrote: >> Instead, what about >> >> #define endof(container, field) \ >> (offsetof(container, field) + sizeof ((container *)0)->field) > > As mentioned in my reply, I think endof() isn't necessary. > > J

Re: [Qemu-devel] [RFC V2 11/16] qcow2: Count deduplication refcount overflow metric.

2013-02-07 Thread Eric Blake
On 02/06/2013 05:32 AM, Benoît Canet wrote: > --- > block/qcow2-dedup.c |1 + > 1 file changed, 1 insertion(+) It wouldn't hurt to squash several of these one-liner patches into a bigger patch that turns on collection of all stats in one go. > > diff --git a/block/qcow2-dedup.c b/block/qcow

Re: [Qemu-devel] [RFC V2 12/16] qapi: Add support for deduplication infos in qapi-schema.json.

2013-02-07 Thread Eric Blake
On 02/06/2013 05:32 AM, Benoît Canet wrote: > --- > qapi-schema.json | 40 +++- > 1 file changed, 39 insertions(+), 1 deletion(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index cf4e9d6..ec61f6a 100644 > --- a/qapi-schema.json > +++ b/qapi-schema

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2013 at 09:45:54AM -0600, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Tue, Feb 05, 2013 at 05:47:16PM -0600, Jesse Larrew wrote: > >> Currently, the config size for virtio devices is hard coded. When a new > >> feature is added that changes the config size, driv

Re: [Qemu-devel] [RFC V2 5/7] qcow2: Add qcow2_dedup_control.

2013-02-07 Thread Eric Blake
On 02/06/2013 05:32 AM, Benoît Canet wrote: > --- > block/qcow2-dedup.c | 31 +++ > block/qcow2.c |2 ++ > block/qcow2.h |1 + > 3 files changed, 34 insertions(+) > > diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c > index 1ac..66fb415

Re: [Qemu-devel] Sigsegv error when create JVM, called by bdrv_create in block.c

2013-02-07 Thread Stefan Hajnoczi
On Thu, Feb 7, 2013 at 3:12 PM, harryxiyou wrote: > The above debug info show jni will be used in coroutine. I do not > familay with coroutine, however I guess if coroutine not allow to > spawn a new thread? ,or it's stack corrupte with java jvm stack ? , > For when I modify bdrv_create out of cor

[Qemu-devel] [PATCH v3 3/5] qemu-img: fix missing space in qemu-img check output

2013-02-07 Thread Stefan Hajnoczi
The qemu-img check fragmentation printf() is missing a space before the '=' sign. The human output is not guaranteed to be stable and we are not aware of screen scrapers, so add the missing space. Also fix the missing indentation of the printf() arguments. Signed-off-by: Stefan Hajnoczi --- qe

Re: [Qemu-devel] [RFC qom-cpu v2 04/28] target-i386: Update X86CPU to QOM realizefn

2013-02-07 Thread Eduardo Habkost
On Sun, Jan 20, 2013 at 08:22:27AM +0100, Andreas Färber wrote: > Adapt the signature of x86_cpu_realize(), hook up to > DeviceClass::realize and set realized = true in cpu_x86_init(). > > The QOM realizefn cannot depend on errp being non-NULL as in > cpu_x86_init(), so use a local Error to preser

[Qemu-devel] [PATCH v3 4/5] qemu-img: add compressed clusters to BlockFragInfo

2013-02-07 Thread Stefan Hajnoczi
Show how many clusters are compressed. This can be used to monitor how many compressed clusters remain and whether to recompress the image. Suggested-by: Cole Robinson Signed-off-by: Stefan Hajnoczi --- include/block/block.h| 1 + qapi-schema.json | 6 +- qemu-img.c

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-02-07 Thread Michael S. Tsirkin
On Thu, Feb 07, 2013 at 05:56:16PM +0200, Michael S. Tsirkin wrote: > On Thu, Feb 07, 2013 at 09:45:54AM -0600, Anthony Liguori wrote: > > "Michael S. Tsirkin" writes: > > > > > On Tue, Feb 05, 2013 at 05:47:16PM -0600, Jesse Larrew wrote: > > >> Currently, the config size for virtio devices is h

Re: [Qemu-devel] [RFC qom-cpu v2 03/28] target-arm: Update ARMCPU to QOM realizefn

2013-02-07 Thread Eduardo Habkost
On Sun, Jan 20, 2013 at 08:22:26AM +0100, Andreas Färber wrote: > Turn arm_cpu_realize() into a QOM realize function, no longer called > via cpu.h prototype. To maintain the semantics of cpu_init(), set > realized = true explicitly in cpu_arm_init(). > > Move GDB coprocessor registration, CPU rese

[Qemu-devel] [PULL] tests/test-string-input-visitor: Handle errors provoked by fuzz test

2013-02-07 Thread Luiz Capitulino
From: Peter Maydell It's OK and expected for visitors to return errors when presented with the fuzz test's random data. Since the fuzzer doesn't care about errors, we pass in NULL rather than an Error**. This fixes a bug in the fuzzer where it was passing the same Error** into each visitor, with

Re: [Qemu-devel] [PATCH RFC qom-cpu-next 1/6] cpu: Register VMStateDescription through CPUState

2013-02-07 Thread Eduardo Habkost
On Sat, Feb 02, 2013 at 04:04:11PM +0100, Andreas Färber wrote: > In comparison to DeviceClass::vmsd, CPU VMState is split in two, > "cpu_common" and "cpu", and uses cpu_index as instance_id instead of -1. > Therefore add a CPU-specific CPUClass::vmsd field. > > Unlike the legacy CPUArchState regi

[Qemu-devel] [PATCH v3 5/5] qcow2: support compressed clusters in BlockFragInfo

2013-02-07 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- block/qcow2-refcount.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 771b7b2..55543ed 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -968,6 +968,7 @@ static int check_refcounts_l2(B

[Qemu-devel] [PULL for-1.4] QMP queue

2013-02-07 Thread Luiz Capitulino
The changes (since ecd8d4715ea33aa2c146a5047bacb031e86af599) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Peter Maydell (1): tests/test-string-input-visitor: Handle errors provoked by fuzz test tests/test-string-input-visitor.c | 12 ++---

[Qemu-devel] [PATCH v3 0/5] qcow2: add fragmentation and compression info support

2013-02-07 Thread Stefan Hajnoczi
Applies on kevin/block-next (2700d627e4d73bb2aacb832a93ffac8fec78b1fd). This series adds fragmentation info support to qcow2 and then adds compression info. Previously only QED supported fragmentation info. Note that fragmentation info only covers the current image, internal snapshots are not in

Re: [Qemu-devel] [PATCH RFC qom-cpu-next 2/6] target-i386: Update VMStateDescription to X86CPU

2013-02-07 Thread Eduardo Habkost
On Sat, Feb 02, 2013 at 04:04:12PM +0100, Andreas Färber wrote: > Expose vmstate_cpu as vmstate_x86_cpu and hook it up to CPUClass::vmsd. > Adapt opaques and VMState fields to X86CPU. Drop cpu_{save,load}(). > > Signed-off-by: Andreas Färber > --- > target-i386/cpu-qom.h |2 + > target-i386/

Re: [Qemu-devel] [PATCH v2 03/15] qdev_prop_parse(): extend signature with Error

2013-02-07 Thread Eduardo Habkost
On Tue, Feb 05, 2013 at 09:39:16PM +0100, Laszlo Ersek wrote: > Error handling is not changed yet. > > Signed-off-by: Laszlo Ersek The extra parameter seems useless and even misleading (because Error info won't be set even if the function returns -1) without patch 04/15. What about squashing bot

Re: [Qemu-devel] [PATCH v2 04/15] qdev_prop_parse(): push error handling to callers

2013-02-07 Thread Eduardo Habkost
On Tue, Feb 05, 2013 at 09:39:17PM +0100, Laszlo Ersek wrote: > Error consumption is moved from qdev_prop_parse() to its direct callers. > > Conversion status (call chains covered or substituted by error propagation > marked with square brackets): > > do_device_add -> [qemu_find_opts -> error_rep

[Qemu-devel] [PATCH qom-cpu-next v2 1/1] target-cris: Introduce CRISCPU subclasses

2013-02-07 Thread Andreas Färber
Use class_init functions to initialize the VR in preparation for overriding v32+ behavior there. Move cpu_cris_init() to cpu.c and hook up a class_by_name callback. This change leads to unknown -cpu model names no longer falling back to a CPU with VR 32 but instead returning NULL. Signed-off-by:

[Qemu-devel] [PATCH qom-cpu-next v2 0/1] QOM'ify CRIS CPU

2013-02-07 Thread Andreas Färber
Hi Edgar, This patch takes a second attempt at introducing CPU subclasses for cris. In v1 I had used a declarative CRISCPUInfo-based class initialization; this v2 now proposes a TypeInfo/class_init based approach, removing the field duplication and preparing to manually extend the crisv32 class_i

Re: [Qemu-devel] [PATCH v2 02/15] do_device_add(): look up "device" opts list with qemu_find_opts_err()

2013-02-07 Thread Laszlo Ersek
On 02/07/13 18:01, Eduardo Habkost wrote: > On Tue, Feb 05, 2013 at 09:39:15PM +0100, Laszlo Ersek wrote: >> Conversion status (call chains covered or substituted by error propagation >> marked with square brackets): >> >> do_device_add -> [qemu_find_opts -> error_report] >> do_device_add -> qdev_d

Re: [Qemu-devel] [PATCH v2 05/15] qdev_prop_parse(): change return type to void

2013-02-07 Thread Eduardo Habkost
On Tue, Feb 05, 2013 at 09:39:18PM +0100, Laszlo Ersek wrote: > Problems are now reported via Error only. > > Signed-off-by: Laszlo Ersek > --- > hw/qdev-properties.h |4 ++-- > hw/qdev-monitor.c|3 ++- > hw/qdev-properties.c | 14 ++ > 3 files changed, 10 insertions(+)

Re: [Qemu-devel] [PATCH 2/2] qxl: change rom size to 8192

2013-02-07 Thread Alon Levy
> On 02/07/2013 07:31 AM, Alon Levy wrote: > >> On 02/06/2013 05:52 PM, Cole Robinson wrote: > >>> On 01/22/2013 05:09 AM, Gerd Hoffmann wrote: > From: Alon Levy > > This is a simpler solution to 869981, where migration breaks > since > qxl's > rom bar size has change

Re: [Qemu-devel] [PATCH v2 06/15] set_property(): extend signature with Error

2013-02-07 Thread Eduardo Habkost
On Tue, Feb 05, 2013 at 09:39:19PM +0100, Laszlo Ersek wrote: > > Signed-off-by: Laszlo Ersek > --- > hw/qdev-monitor.c | 21 - > 1 files changed, 16 insertions(+), 5 deletions(-) > > diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c > index cf96046..545e66c 100644 > ---

Re: [Qemu-devel] [PATCH RFC qom-cpu-next 1/6] cpu: Register VMStateDescription through CPUState

2013-02-07 Thread Andreas Färber
Am 07.02.2013 17:40, schrieb Eduardo Habkost: > On Sat, Feb 02, 2013 at 04:04:11PM +0100, Andreas Färber wrote: >> In comparison to DeviceClass::vmsd, CPU VMState is split in two, >> "cpu_common" and "cpu", and uses cpu_index as instance_id instead of -1. >> Therefore add a CPU-specific CPUClass::v

[Qemu-devel] [PATCH v3 2/5] qcow2: record fragmentation statistics during check

2013-02-07 Thread Stefan Hajnoczi
The qemu-img check command can display fragmentation statistics: * Total number of clusters in virtual disk * Number of allocated clusters * Number of fragmented clusters This patch adds fragmentation statistics support to qcow2. Compressed and normal clusters count as allocated. Zero cluster

Re: [Qemu-devel] [PATCH v3 02/20] arm: add Faraday a369 SoC platform support

2013-02-07 Thread Igor Mitsyanko
On 02/06/2013 01:45 PM, Kuo-Jung Su wrote: From: Kuo-Jung Su The Faraday A369 EVB is a Faraday SoC platform evalution board used for Faraday IP functional verification based on the well-known ARM AMBA 2.0 architecture. Signed-off-by: Kuo-Jung Su --- hw/arm/Makefile.objs |1 + hw

Re: [Qemu-devel] [PATCH qom-cpu-next v2 1/1] target-cris: Introduce CRISCPU subclasses

2013-02-07 Thread Andreas Färber
Am 07.02.2013 18:04, schrieb Andreas Färber: > diff --git a/target-cris/cpu.c b/target-cris/cpu.c > index fedf641..8008988 100644 > --- a/target-cris/cpu.c > +++ b/target-cris/cpu.c > @@ -55,6 +55,84 @@ static void cris_cpu_reset(CPUState *s) > #endif > } > > +static ObjectClass *cris_cpu_class

[Qemu-devel] What limitions when run in coroutine mode ?

2013-02-07 Thread Kang Hua
HI all : I write a new block driver based on hdfs of hadoop, it need to connect to hdfs when create step (called by bdrv_create in block.c) by use libhdfs ( hdfs c++ api) 。 libhdfs use jni api to will create jvm . The problem is —— it will cause sigsegv error when create jvm . #0 0x000

Re: [Qemu-devel] [PATCH v3 01/20] arm: add Faraday a360 SoC platform support

2013-02-07 Thread Igor Mitsyanko
On 02/06/2013 01:45 PM, Kuo-Jung Su wrote: > From: Kuo-Jung Su > > The Faraday A360 EVB is a Faraday SoC platform evaluation board used for > Faraday IP functional verification based on the well-known ARM AMBA 2.0 > architecture. > > Signed-off-by: Kuo-Jung Su > --- > hw/arm/Makefile.objs |

  1   2   >