Re: [Qemu-devel] [PATCH prep for-1.4] prep: Move PReP machine to hw/ppc/

2013-01-30 Thread Andreas Färber
Am 26.01.2013 20:49, schrieb Andreas Färber: > Signed-off-by: Andreas Färber > --- > hw/ppc/Makefile.objs |3 ++- > hw/{ppc_prep.c => ppc/prep.c} | 28 ++-- > 2 Dateien geändert, 16 Zeilen hinzugefügt(+), 15 Zeilen entfernt(-) > rename hw/{ppc_prep.c => ppc

Re: [Qemu-devel] [PATCH v2] vmdk: Allow selecting SCSI adapter in image creation

2013-01-30 Thread Stefan Hajnoczi
On Wed, Jan 30, 2013 at 12:26:52AM +0100, Othmar Pasteka wrote: > Introduce a new option "adapter_type" when converting to vmdk images. > It can be one of the following: ide (default), buslogic, lsilogic > or legacyESX (according to the vmdk spec from vmware). > > In case of a non-ide adapter, hea

Re: [Qemu-devel] [PULL] virtio,make,pci,e1000

2013-01-30 Thread Stefan Hajnoczi
On Tue, Jan 29, 2013 at 06:19:21PM -0600, Anthony Liguori wrote: > Andreas Färber writes: > > > Am 30.01.2013 00:28, schrieb Michael S. Tsirkin: > >> On Tue, Jan 29, 2013 at 04:54:35PM -0600, Anthony Liguori wrote: > >>> ERROR:/home/aliguori/git/qemu/tests/fdc-test.c:84:floppy_send: assertion >

Re: [Qemu-devel] [PATCH] vmdk: Allow space in file name

2013-01-30 Thread Markus Armbruster
Philipp Hahn writes: > The previous scanf() format string stopped parsing the file name on the > first white white space, which seems to be allowed at least by VMware > Wokrstation. > > Change the format string to collect everything between the first and > second quote as the file name, disallowi

Re: [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-01-30 Thread Lei Li
Sorry, missing replied... It should be the reply to Eric here. On 01/30/2013 03:37 PM, Lei Li wrote: On 01/29/2013 04:24 AM, Anthony Liguori wrote: Eric Blake writes: On 01/27/2013 11:14 AM, Lei Li wrote: Signed-off-by: Lei Li --- include/qapi/qmp/qerror.h |3 +++ qga/commands-posix

Re: [Qemu-devel] What to do about non-qdevified devices?

2013-01-30 Thread Andreas Färber
Am 30.01.2013 08:02, schrieb Markus Armbruster: > Anthony Liguori writes: > > [...] >> The problems I ran into were (1) this is a lot of work (2) it basically >> requires that all bus children have been qdev/QOM-ified. Even with >> something like the ISA bus which is where I started, quite a few

Re: [Qemu-devel] [PATCH][v2] linux-user: correct setsockopt()

2013-01-30 Thread Riku Voipio
Hi, On Sat, Jan 26, 2013 at 12:24:56PM +0100, Laurent Vivier wrote: > Le dimanche 20 janvier 2013 à 00:32 +0100, Laurent Vivier a écrit : > > ping ? > > ping I'm really not managing to find time for qemu linux-user maintainance at the moment. I suggest you send the patches directly as pull reque

Re: [Qemu-devel] [PATCH for-1.4 1/2] linux-user: Fix cpu_copy() usage

2013-01-30 Thread Igor Mammedov
On Wed, 30 Jan 2013 08:46:34 +0100 Andreas Färber wrote: > Am 30.01.2013 08:18, schrieb Igor Mammedov: > > On Wed, 30 Jan 2013 01:34:18 +0100 > > Andreas Färber wrote: > > > >> Commit b4558d7481aefc865b0b52bf9b285ebcf2e8b59f ((x86/Sparc/PPC)-user: > >> fix cpu_copy) added a CPU reset after cpu_

Re: [Qemu-devel] [PATCH for-1.4 1/2] linux-user: Fix cpu_copy() usage

2013-01-30 Thread Andreas Färber
Am 30.01.2013 09:46, schrieb Igor Mammedov: > On Wed, 30 Jan 2013 08:46:34 +0100 > Andreas Färber wrote: > >> Am 30.01.2013 08:18, schrieb Igor Mammedov: >>> On Wed, 30 Jan 2013 01:34:18 +0100 >>> Andreas Färber wrote: >>> Commit b4558d7481aefc865b0b52bf9b285ebcf2e8b59f ((x86/Sparc/PPC)-use

Re: [Qemu-devel] [PATCH v2] sheepdog: pass vdi_id to sheep daemon for sd_close()

2013-01-30 Thread Stefan Hajnoczi
On Tue, Jan 29, 2013 at 05:14:16PM +0800, Liu Yuan wrote: > From: Liu Yuan > > Sheep daemon needs vdi_id to identify which vdi is closed to release resources > such as object cache. > > Cc: MORITA Kazutaka > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Signed-off-by: Liu Yuan > --- > v2: rename b

Re: [Qemu-devel] a probem about qemu doesn't support for setting ma

2013-01-30 Thread Paolo Bonzini
Il 30/01/2013 02:37, liequan@i-soft.com.cn ha scritto: > Hi Paolo: > I recompile the qemu-kvm-0.12.1.2-2.295.el6.10.src.rpm > with --enable-mixemu. > It makes no effect yet. The code to do this is then not be included in that version of qemu-kvm. > Did the new version 1.3.1 slove this prob

Re: [Qemu-devel] [PATCH v2 0/6] bdrv_open() error return fixes

2013-01-30 Thread Stefan Hajnoczi
On Fri, Jan 25, 2013 at 05:07:26PM +0100, Kevin Wolf wrote: > Kevin Wolf (6): > bochs: Fix bdrv_open() error handling > cloop: Fix bdrv_open() error handling > vpc: Fix bdrv_open() error handling > dmg: Fix bdrv_open() error handling > dmg: Use g_free instead of free > parallels: Fix bd

Re: [Qemu-devel] [Bug 1105670] [NEW] Converting vpc image to raw results in an image that is smaller than it should be.

2013-01-30 Thread Stefan Hajnoczi
On Sat, Jan 26, 2013 at 03:21:27AM -, Peter Rehley wrote: > Public bug reported: CCed Stefan Weil and Jeff Cody who may be thoughts on this bug. If you would like to contribute your patch, please see http://wiki.qemu.org/Contribute/SubmitAPatch. (Patches attached on the bug tracker are not r

[Qemu-devel] [PATCH 1/3] prep_pci: Create PCIBus and PCIDevice in-place

2013-01-30 Thread Andreas Färber
Prepares for QOM realizefn by removing object creation from qdev initfn. Signed-off-by: Andreas Färber --- hw/prep_pci.c | 50 +- 1 Datei geändert, 37 Zeilen hinzugefügt(+), 13 Zeilen entfernt(-) diff --git a/hw/prep_pci.c b/hw/prep_pci.c index

Re: [Qemu-devel] [PULL 0/3] PReP patch queue 2013-01-30

2013-01-30 Thread Andreas Färber
Am 30.01.2013 10:30, schrieb Andreas Färber: > Hello, > > Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master. > > It includes: > * QOM'ish prep_pci.c cleanups, > * hw/ppc_prep.c -> hw/ppc/prep.c move. > > The following changes since commit 13144781d4e9e6100b398213f90005

Re: [Qemu-devel] QEMU buildbot maintenance state

2013-01-30 Thread Stefan Hajnoczi
On Tue, Jan 29, 2013 at 04:04:39PM +0100, Christian Berendt wrote: > On 01/28/2013 03:29 PM, Daniel Gollub wrote: > >JFYI, the main buildbot configuration which controls everything (beside > >buildslave credentials) is accessible to everyone: > >http://people.b1-systems.de/~gollub/buildbot/ > > > >

[Qemu-devel] [PATCH 1/3] prep_pci: Create PCIBus and PCIDevice in-place

2013-01-30 Thread Andreas Färber
Prepares for QOM realizefn by removing object creation from qdev initfn. Signed-off-by: Andreas Färber --- hw/prep_pci.c | 50 +- 1 Datei geändert, 37 Zeilen hinzugefügt(+), 13 Zeilen entfernt(-) diff --git a/hw/prep_pci.c b/hw/prep_pci.c index

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 1/5] add openfabrics RDMA libraries and base RDMA code to build

2013-01-30 Thread Stefan Hajnoczi
On Mon, Jan 28, 2013 at 05:01:41PM -0500, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > > Signed-off-by: Michael R. Hines > --- > Makefile.target |5 +- > include/qemu/rdma.h | 249 ++ > qemu-rdma.c | 1357 > +

[Qemu-devel] [PATCH 3/3] prep: Move PReP machine to hw/ppc/

2013-01-30 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/ppc/Makefile.objs |3 ++- hw/{ppc_prep.c => ppc/prep.c} | 28 ++-- 2 Dateien geändert, 16 Zeilen hinzugefügt(+), 15 Zeilen entfernt(-) rename hw/{ppc_prep.c => ppc/prep.c} (98%) diff --git a/hw/ppc/Makefile.objs b/hw/pp

Re: [Qemu-devel] [PATCH V2 11/20] tap: support enabling or disabling a queue

2013-01-30 Thread Jason Wang
On 01/30/2013 07:03 AM, Michael S. Tsirkin wrote: > On Tue, Jan 29, 2013 at 04:55:25PM -0600, Anthony Liguori wrote: >> "Michael S. Tsirkin" writes: >> >>> On Tue, Jan 29, 2013 at 08:10:26PM +, Blue Swirl wrote: On Tue, Jan 29, 2013 at 1:50 PM, Jason Wang wrote: > On 01/26/2013 03:13

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] Xilinx Trivial Patches

2013-01-30 Thread Stefan Hajnoczi
On Sat, Jan 26, 2013 at 12:54:32PM -0800, Peter Crosthwaite wrote: > Current queue of trivial patches from the Xilinx tree. > > Peter Crosthwaite (4): > cadence_ttc: Debug mode compile fixes > cadence_gem: Debug mode compile fixes > xilinx_axidma: Fix debug mode compile messages > qemu/log

[Qemu-devel] [PATCH 2/3] prep_pci: Convert to QOM realizefn

2013-01-30 Thread Andreas Färber
SysBusDeviceClass' initfn merely calls SysBusDeviceClass::init, so we can already hook up our own realizefn overwriting this behavior. A symmetric unrealizefn is not necessary, knowing that the child's unrealizefn is still no-op, too. Avoids ripping it out again when recursive realization at Devic

Re: [Qemu-devel] [PATCH] sparc: disable qtest in make check

2013-01-30 Thread Gerd Hoffmann
On 01/29/13 22:42, Anthony Liguori wrote: > We've seen this repeatedly in buildbot but I can now reliably > reproduce it myself too. With a few hundred runs of 'make check', > qemu-system-sparc will hang consuming 100% CPU. I've attached GDB > to the hung process and unfortunately, I can't get an

[Qemu-devel] [PULL v2 0/3] PReP patch queue 2013-01-30

2013-01-30 Thread Andreas Färber
Hello, Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master. It includes: * QOM'ish prep_pci.c cleanups, * hw/ppc_prep.c -> hw/ppc/prep.c move. The following changes since commit 13144781d4e9e6100b398213f9000576a3dc88f9: Merge branch 'ppc-for-upstream' of git://repo.or

[Qemu-devel] [PATCH 3/3] prep: Move PReP machine to hw/ppc/

2013-01-30 Thread Andreas Färber
Signed-off-by: Andreas Färber --- MAINTAINERS |2 +- hw/ppc/Makefile.objs |3 ++- hw/{ppc_prep.c => ppc/prep.c} | 28 ++-- 3 Dateien geändert, 17 Zeilen hinzugefügt(+), 16 Zeilen entfernt(-) rename hw/{ppc_prep.c => ppc/prep.c} (98%)

Re: [Qemu-devel] QEMU buildbot maintenance state

2013-01-30 Thread Gerd Hoffmann
Hi, > Gerd: Are you willing to co-maintain the QEMU buildmaster with Daniel > and Christian? It would be awesome if you could do this given your > experience running and customizing buildbot. I'll try to set aside some time for that. Christians idea to host the config at github is good, that

[Qemu-devel] [PULL 0/3] PReP patch queue 2013-01-30

2013-01-30 Thread Andreas Färber
Hello, Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master. It includes: * QOM'ish prep_pci.c cleanups, * hw/ppc_prep.c -> hw/ppc/prep.c move. The following changes since commit 13144781d4e9e6100b398213f9000576a3dc88f9: Merge branch 'ppc-for-upstream' of git://repo.or

Re: [Qemu-devel] [PATCH for-1.4 02/19] target-ppc: Fix target_ulong vs. hwaddr format mismatches

2013-01-30 Thread Alexander Graf
On 27.01.2013, at 14:32, Andreas Färber wrote: > To keep log format backwards compatible, cast to target_ulong > rather than using HWADDR_PRIx. > > Signed-off-by: Andreas Färber > --- > target-ppc/mmu_helper.c |8 +--- > 1 Datei geändert, 5 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) >

Re: [Qemu-devel] [PATCH v2] qemu-pixman.h: Avoid mutual inclusion loop with console.h

2013-01-30 Thread Stefan Hajnoczi
On Mon, Jan 21, 2013 at 12:03:47PM +, Peter Maydell wrote: > Remove an unnecessary mutual inclusion loop between qemu-pixman.h and > console.h, since the former was only including the latter for > 'PixelFormat*', which can be provided by typedefs.h. This requires a > minor adjustment to the fi

Re: [Qemu-devel] [PATCH for-1.4 03/19] target-ppc: Fix unused variable warning for FLUSH_ALL_TLBS

2013-01-30 Thread Alexander Graf
On 27.01.2013, at 14:32, Andreas Färber wrote: > Signed-off-by: Andreas Färber Thanks, applied to ppc-next. Alex > --- > target-ppc/mmu_helper.c |3 ++- > 1 Datei geändert, 2 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) > > diff --git a/target-ppc/mmu_helper.c b/target-ppc/mmu_helper.c > in

Re: [Qemu-devel] [PATCH for-1.4 04/19] target-ppc: Fix build for PPC_DEBUG_DISAS

2013-01-30 Thread Alexander Graf
On 27.01.2013, at 14:32, Andreas Färber wrote: > In r5949 / 76db3ba44ee8db671f804755f13b016eefd13288 (target-ppc: memory > load/store rework) variable little_endian was replaced with ctx.le_mode. > Update the debug code. > > Signed-off-by: Andreas Färber Thanks, applied to ppc-next. Alex > -

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-1.4] tests: Fix {rtc, m48t59}-test build on illumos

2013-01-30 Thread Stefan Hajnoczi
On Sat, Jan 26, 2013 at 03:27:59PM +0100, Andreas Färber wrote: > Struct tm does not have tm_gmtoff field on illumos. > Fix the build by not zero-initializing these fields on Solaris. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Andreas Färber > --- > tests/m48t59-test.c |2 ++ > tests/rt

[Qemu-devel] [PATCH 2/3] prep_pci: Convert to QOM realizefn

2013-01-30 Thread Andreas Färber
SysBusDeviceClass' initfn merely calls SysBusDeviceClass::init, so we can already hook up our own realizefn overwriting this behavior. A symmetric unrealizefn is not necessary, knowing that the child's unrealizefn is still no-op, too. Avoids ripping it out again when recursive realization at Devic

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema

2013-01-30 Thread Stefan Hajnoczi
On Tue, Jan 29, 2013 at 05:58:41PM +0100, Michal Privoznik wrote: > Currently, we are using 'tray_open' in QMP and 'tray-open' in > HMP. However, the QMP documentation was mistakenly using the > HMP version. > > Signed-off-by: Michal Privoznik > --- Thanks, applied to the trivial patches tree: h

[Qemu-devel] [PATCH 1/4] hw: Spelling fix in log message

2013-01-30 Thread Stefan Hajnoczi
From: Stefan Weil defineition -> definition Signed-off-by: Stefan Weil Reviewed-by: Andreas F=E4rber Signed-off-by: Stefan Hajnoczi --- hw/openrisc_sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/openrisc_sim.c b/hw/openrisc_sim.c index fb47cdc..6c443ba 100644 --

[Qemu-devel] [PATCH 04/18] xilinx_axidma: Fix debug mode compile messages

2013-01-30 Thread Stefan Hajnoczi
From: Peter Crosthwaite Missing cast one one of the conditionally compiled printfs. Signed-off-by: Peter Crosthwaite Signed-off-by: Stefan Hajnoczi --- hw/xilinx_axidma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xilinx_axidma.c b/hw/xilinx_axidma.c index d0ee566.

[Qemu-devel] [PATCH 09/18] spice: Fix unchecked strdup() by converting to g_strdup()

2013-01-30 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- ui/spice-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 3f2c565..bcc4199 100644 --- a/ui/spice-core.c +++

[Qemu-devel] [PATCH 03/18] cadence_gem: Debug mode compile fixes

2013-01-30 Thread Stefan Hajnoczi
From: Peter Crosthwaite Some printfs are throwing warnings when debug mode is enabled. Fixed. Signed-off-by: Peter Crosthwaite Signed-off-by: Stefan Hajnoczi --- hw/cadence_gem.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/cadence_gem.c b/hw/caden

[Qemu-devel] [PATCH 15/18] qemu-ga: Fix unchecked strdup() by converting to g_strdup()

2013-01-30 Thread Stefan Hajnoczi
From: Markus Armbruster I figure it's freed somewhere deep down in QAPI, with g_free(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino Signed-off-by: Stefan Hajnoczi --- qga/commands.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[Qemu-devel] [PATCH 3/4] configure: silence pkg-config's check for curses

2013-01-30 Thread Stefan Hajnoczi
From: Vadim Evard Signed-off-by: Vadim Evard Signed-off-by: Stefan Hajnoczi --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 4ebb60d..6211db9 100755 --- a/configure +++ b/configure @@ -2039,7 +2039,7 @@ fi if test "$mingw32" = "yes"

[Qemu-devel] [PATCH 02/18] cadence_ttc: Debug mode compile fixes

2013-01-30 Thread Stefan Hajnoczi
From: Peter Crosthwaite Some printfs are throwing warnings when debug mode is enabled. Fixed. Signed-off-by: Peter Crosthwaite Signed-off-by: Stefan Hajnoczi --- hw/cadence_ttc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/cadence_ttc.c b/hw/cadence_ttc.c index

[Qemu-devel] [PATCH 0/5] XBZRLE Fixes

2013-01-30 Thread Orit Wasserman
This series adds some testing to the XBZRLE compression, disables it from migration to file (exec) to eliminate errors during load from file. Orit Wasserman (5): Move XBZRLE encoding code to a separate file to allow testing Add XBZRLE testing Fix example for query-migrate-capabilities Disa

[Qemu-devel] [PATCH 5/5] Fix error message in migrate_set_capability HMP command

2013-01-30 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- hmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hmp.c b/hmp.c index 249b89b..1689e6f 100644 --- a/hmp.c +++ b/hmp.c @@ -892,7 +892,7 @@ void hmp_migrate_set_capability(Monitor *mon, const QDict *qdict) qapi_free_MigrationCapability

Re: [Qemu-devel] What to do about non-qdevified devices? (was: KVM call minutes 2013-01-29)

2013-01-30 Thread Peter Maydell
On 30 January 2013 07:02, Markus Armbruster wrote: > Anthony Liguori writes: > > [...] >> The problems I ran into were (1) this is a lot of work (2) it basically >> requires that all bus children have been qdev/QOM-ified. Even with >> something like the ISA bus which is where I started, quite a

Re: [Qemu-devel] [PATCH for-1.4 05/19] target-s390x: Fix debug output

2013-01-30 Thread Alexander Graf
On 27.01.2013, at 14:32, Andreas Färber wrote: > Commit 71e470886fb6092504503a5fe41092ace71c096c (target-s390x: fix > style) renamed the cpu_s390x_handle_mmu_fault() argument from _vaddr to > orig_vaddr. Update the debug output code. > > Signed-off-by: Andreas Färber Thanks, applied this and 0

Re: [Qemu-devel] [PATCH for-1.4 02/19] target-ppc: Fix target_ulong vs. hwaddr format mismatches

2013-01-30 Thread Andreas Färber
Am 30.01.2013 11:15, schrieb Alexander Graf: > > On 27.01.2013, at 14:32, Andreas Färber wrote: > >> To keep log format backwards compatible, cast to target_ulong >> rather than using HWADDR_PRIx. >> >> Signed-off-by: Andreas Färber >> --- >> target-ppc/mmu_helper.c |8 +--- >> 1 Datei ge

Re: [Qemu-devel] [PATCH][v2] linux-user: correct setsockopt()

2013-01-30 Thread Peter Maydell
On 30 January 2013 08:45, Riku Voipio wrote: > On Sat, Jan 26, 2013 at 12:24:56PM +0100, Laurent Vivier wrote: >> Le dimanche 20 janvier 2013 à 00:32 +0100, Laurent Vivier a écrit : >> > ping ? >> >> ping > > I'm really not managing to find time for qemu linux-user maintainance > at the moment. I

Re: [Qemu-devel] [PATCH 4/5] Disable XBZRLE during migrate to file if it is active

2013-01-30 Thread Paolo Bonzini
> XBZRLE is not effective when migrating to file. > > Disabling it automatically will remove the need to update the > command line to allow loading a guest from a file that was in XBZRLE > format. What about savevm? Paolo > Signed-off-by: Orit Wasserman > --- > include/migration/migration.h

Re: [Qemu-devel] [PATCH 2/5] Add XBZRLE testing

2013-01-30 Thread Paolo Bonzini
> Signed-off-by: Orit Wasserman > --- > tests/Makefile | 2 + > tests/test-xbzrle.c | 185 > > 2 files changed, 187 insertions(+) > create mode 100644 tests/test-xbzrle.c > > diff --git a/tests/Makefile b/tests/Makefile > index c681c

Re: [Qemu-devel] [PATCH for-1.4 1/2] linux-user: Fix cpu_copy() usage

2013-01-30 Thread Igor Mammedov
On Wed, 30 Jan 2013 09:53:29 +0100 Andreas Färber wrote: > Am 30.01.2013 09:46, schrieb Igor Mammedov: > > On Wed, 30 Jan 2013 08:46:34 +0100 > > Andreas Färber wrote: > > > >> Am 30.01.2013 08:18, schrieb Igor Mammedov: > >>> On Wed, 30 Jan 2013 01:34:18 +0100 > >>> Andreas Färber wrote: > >>

Re: [Qemu-devel] [PATCH 4/5] Disable XBZRLE during migrate to file if it is active

2013-01-30 Thread Orit Wasserman
On 01/30/2013 12:49 PM, Paolo Bonzini wrote: > >> XBZRLE is not effective when migrating to file. >> >> Disabling it automatically will remove the need to update the >> command line to allow loading a guest from a file that was in XBZRLE >> format. > > What about savevm? I think a user that activ

[Qemu-devel] [PATCH 1/5] Move XBZRLE encoding code to a separate file to allow testing

2013-01-30 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- Makefile.objs | 2 +- savevm.c | 159 - xbzrle.c | 173 ++ 3 files changed, 174 insertions(+), 160 deletions(-) create mode 100644 xbzrle.c d

[Qemu-devel] vCPU hotplug roadmap (was: Minutes for KVM call 2013-01-15)

2013-01-30 Thread Andreas Färber
Am 15.01.2013 17:16, schrieb Juan Quintela: > > * cpu hot plug > - use qdev propierties conected to a set of socket objects (anthony) > - cpusets are the wrong interface (anthony) > - make a link between cpu <-> socket instead of a propierty? > - how far are we from being able to describe

[Qemu-devel] [PATCH 05/18] g_malloc(0) and g_malloc0(0) return NULL; simplify

2013-01-30 Thread Stefan Hajnoczi
From: Markus Armbruster Once upon a time, it was decided that qemu_malloc(0) should abort. Switching to glib retired that bright idea. Some code that was added to cope with it (e.g. in commits 702ef63, b76b6e9) is still around. Bury it. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake

[Qemu-devel] [PATCH 10/18] virtfs-proxy-helper: Fix unchecked strdup() by conv. to g_strdup()

2013-01-30 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- fsdev/virtfs-proxy-helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c index 6b9afd3..36f6

Re: [Qemu-devel] [PATCH for-1.4 02/19] target-ppc: Fix target_ulong vs. hwaddr format mismatches

2013-01-30 Thread Alexander Graf
On 30.01.2013, at 11:40, Andreas Färber wrote: > Am 30.01.2013 11:15, schrieb Alexander Graf: >> >> On 27.01.2013, at 14:32, Andreas Färber wrote: >> >>> To keep log format backwards compatible, cast to target_ulong >>> rather than using HWADDR_PRIx. >>> >>> Signed-off-by: Andreas Färber >>>

[Qemu-devel] [PATCH 16/18] qemu-pixman.h: Avoid mutual inclusion loop with console.h

2013-01-30 Thread Stefan Hajnoczi
From: Peter Maydell Remove an unnecessary mutual inclusion loop between qemu-pixman.h and console.h, since the former was only including the latter for 'PixelFormat*', which can be provided by typedefs.h. This requires a minor adjustment to the files which included qemu-pixman.h, since they were

Re: [Qemu-devel] [PATCH for-1.4 02/19] target-ppc: Fix target_ulong vs. hwaddr format mismatches

2013-01-30 Thread Andreas Färber
Am 30.01.2013 12:02, schrieb Alexander Graf: > > On 30.01.2013, at 11:40, Andreas Färber wrote: > >> Am 30.01.2013 11:15, schrieb Alexander Graf: >>> >>> On 27.01.2013, at 14:32, Andreas Färber wrote: >>> To keep log format backwards compatible, cast to target_ulong rather than using HW

Re: [Qemu-devel] [PATCH 4/5] Disable XBZRLE during migrate to file if it is active

2013-01-30 Thread Paolo Bonzini
> On 01/30/2013 12:49 PM, Paolo Bonzini wrote: > >> XBZRLE is not effective when migrating to file. > >> > >> Disabling it automatically will remove the need to update the > >> command line to allow loading a guest from a file that was in > >> XBZRLE format. > > > > What about savevm? > I think a

[Qemu-devel] [PULL 00/18] Trivial patches for 22 to 30 January 2013

2013-01-30 Thread Stefan Hajnoczi
Trivial fixes for QEMU 1.4. I was going to hold off Markus' malloc(0) cleanups but they are straightforward and risk conflicting if I leave them out-of-tree for too long. The following changes since commit 0893d46014b0300fb8aec92df94effea34d04b61: Merge remote-tracking branch 'qemu-kvm/uq/mast

[Qemu-devel] [PATCH 4/5] Disable XBZRLE during migrate to file if it is active

2013-01-30 Thread Orit Wasserman
XBZRLE is not effective when migrating to file. Disabling it automatically will remove the need to update the command line to allow loading a guest from a file that was in XBZRLE format. Signed-off-by: Orit Wasserman --- include/migration/migration.h | 1 + migration-exec.c | 6 +++

[Qemu-devel] How to map a small portion of address space to DCache in QEMU?

2013-01-30 Thread Muhammad Nouman
Hi! There is a special segment in Octeon processors (CVMSEG) which maps a small portion of MIPS64 address space to Data Cache. This region is used by the user applications as scratch space and this space is saved by Octeon Kernel on context switches. How can we do this mapping (i.e. some part of M

[Qemu-devel] [PATCH 14/18] qapi: Fix unchecked strdup() by converting to g_strdup()

2013-01-30 Thread Stefan Hajnoczi
From: Markus Armbruster Note that we already free with g_free(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino Signed-off-by: Stefan Hajnoczi --- qapi/qmp-registry.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/qmp-registry

Re: [Qemu-devel] [PATCH][v2] linux-user: correct setsockopt()

2013-01-30 Thread Laurent Vivier
Le 30 janvier 2013 à 11:42, Peter Maydell a écrit : > On 30 January 2013 08:45, Riku Voipio wrote: > > On Sat, Jan 26, 2013 at 12:24:56PM +0100, Laurent Vivier wrote: > >> Le dimanche 20 janvier 2013 à 00:32 +0100, Laurent Vivier a écrit : > >> > ping ? > >> > >> ping > > > > I'm really not mana

[Qemu-devel] [PATCH 08/18] readline: Fix unchecked strdup() by converting to g_strdup()

2013-01-30 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- readline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/readline.c b/readline.c index a0c9638..d6e04d4 100644 --- a/readline.c +++ b/readline.c @@ -24

[Qemu-devel] [PATCH 2/4] acpitable: open the data file in binary mode

2013-01-30 Thread Stefan Hajnoczi
From: Michael Tokarev -acpitable {file|data}=file reads the content of file, but it is in binary form, so the file should be opened usin O_BINARY flag. On *nix it is a no-op, but on windows and other weird platform it is really needed. Signed-off-by: Michael Tokarev Signed-off-by: Stefan Hajnoc

[Qemu-devel] [PATCH 17/18] tests: Fix {rtc, m48t59}-test build on illumos

2013-01-30 Thread Stefan Hajnoczi
From: Andreas Färber Struct tm does not have tm_gmtoff field on illumos. Fix the build by not zero-initializing these fields on Solaris. Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber Signed-off-by: Stefan Hajnoczi --- tests/m48t59-test.c | 2 ++ tests/rtc-test.c| 2 ++ 2 files

Re: [Qemu-devel] [PATCH 4/5] Disable XBZRLE during migrate to file if it is active

2013-01-30 Thread Orit Wasserman
On 01/30/2013 01:07 PM, Paolo Bonzini wrote: > >> On 01/30/2013 12:49 PM, Paolo Bonzini wrote: XBZRLE is not effective when migrating to file. Disabling it automatically will remove the need to update the command line to allow loading a guest from a file that was in XBZRLE

[Qemu-devel] [PATCH V4 00/22] Multiqueue virtio-net

2013-01-30 Thread Jason Wang
Hello all: This seires is an update of last version of multiqueue virtio-net support. This series tries to brings multiqueue support to virtio-net through a multiqueue support tap backend and multiple vhost threads. Patch 1 converts bitfield in TAPState to bool. Patch 2 replace assert(0) with ab

[Qemu-devel] [PATCH V4 08/22] net: introduce NetClientState destructor

2013-01-30 Thread Jason Wang
To allow allocating an array of NetClientState and free it once, this patch introduces destructor of NetClientState. Which could do type specific free, which could be used by multiqueue to free the array once. Signed-off-by: Jason Wang --- include/net/net.h |2 ++ net/net.c | 17 ++

[Qemu-devel] [PATCH V4 10/22] tap: import linux multiqueue constants

2013-01-30 Thread Jason Wang
Import multiqueue constants from if_tun.h from 3.8-rc3. A new ifr flag IFF_MULTI_QUEUE were introduced to create a multiqueue backend by calling TUNSETIFF with the this flag and with the same interface name many times. A new ioctl TUNSETQUEUE were introduced. When doing this ioctl with IFF_DETACH_

Re: [Qemu-devel] [PATCH v2] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema

2013-01-30 Thread Luiz Capitulino
On Tue, 29 Jan 2013 17:58:41 +0100 Michal Privoznik wrote: > Currently, we are using 'tray_open' in QMP and 'tray-open' in > HMP. However, the QMP documentation was mistakenly using the > HMP version. > > Signed-off-by: Michal Privoznik Reviewed-by: Luiz Capitulino > --- > > diff to v1: > -

[Qemu-devel] [PATCH 13/18] libcacard: Fix unchecked strdup() by converting to g_strdup()

2013-01-30 Thread Stefan Hajnoczi
From: Markus Armbruster Note that we already free with g_free(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- libcacard/vcard_emul_nss.c | 4 ++-- libcacard/vreader.c| 2 +- libcacard/vscclient.c | 4 ++-- 3 files changed, 5 inserti

[Qemu-devel] [PULL 0/4] generic linux-user patches

2013-01-30 Thread Laurent Vivier
Hi, Please pull this linux-user patches queue into master. All these patches have already been sent and reviewed on the mailing list. The following changes since commit 4c37ef022381e777251d7084591978a4dc622efe: host-utils: add ffsl (2013-01-25 18:18:32 +0100) are available in the git reposito

[Qemu-devel] [PATCH V4 04/22] net: introduce qemu_get_nic()

2013-01-30 Thread Jason Wang
To support multiqueue, this patch introduces a helper qemu_get_nic() to get NICState from a NetClientState. The following patches would refactor this helper to support multiqueue. Signed-off-by: Jason Wang --- hw/cadence_gem.c|8 hw/dp8393x.c|6 +++--- hw/e10

[Qemu-devel] [PATCH 18/18] qmp-commands.hx: s/tray-open/tray_open/ to match qapi schema

2013-01-30 Thread Stefan Hajnoczi
From: Michal Privoznik Currently, we are using 'tray_open' in QMP and 'tray-open' in HMP. However, the QMP documentation was mistakenly using the HMP version. Signed-off-by: Michal Privoznik Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- qmp-commands.hx | 2 +- 1 file changed, 1

[Qemu-devel] [PATCH 2/5] Add XBZRLE testing

2013-01-30 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- tests/Makefile | 2 + tests/test-xbzrle.c | 185 2 files changed, 187 insertions(+) create mode 100644 tests/test-xbzrle.c diff --git a/tests/Makefile b/tests/Makefile index c681ceb..c6d3999 100644 ---

[Qemu-devel] KVM call minutes 2013-01-29 - Port I/O

2013-01-30 Thread Andreas Färber
Am 29.01.2013 16:41, schrieb Juan Quintela: > * Portio port to new memory regions? > Andreas, could you fill? MemoryRegion's .old_portio mechanism requires workarounds for VGA on ppc, affecting among others the sPAPR PCI host bridge: http://git.qemu.org/?p=qemu.git;a=commit;h=a3cfa18eb075c7ef783

[Qemu-devel] [PATCH V4 06/22] net: introduce qemu_find_net_clients_except()

2013-01-30 Thread Jason Wang
In multiqueue, all NetClientState that belongs to the same netdev or nic has the same id. So this patches introduces an helper qemu_find_net_clients_except() which finds all NetClientState with the same id. This will be used by multiqueue networking. Signed-off-by: Jason Wang --- include/net/net

[Qemu-devel] [PATCH v2 3/5] Fix example for query-migrate-capabilities

2013-01-30 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- qmp-commands.hx | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index f58a841..ba43062 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -2601,10 +2601,8 @@ Arguments: Example: -> { "execute": "q

[Qemu-devel] [PATCH v2 5/5] Fix error message in migrate_set_capability HMP command

2013-01-30 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- hmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hmp.c b/hmp.c index 249b89b..1689e6f 100644 --- a/hmp.c +++ b/hmp.c @@ -892,7 +892,7 @@ void hmp_migrate_set_capability(Monitor *mon, const QDict *qdict) qapi_free_MigrationCapability

[Qemu-devel] [PATCH V4 01/22] net: tap: using bool instead of bitfield

2013-01-30 Thread Jason Wang
Signed-off-by: Jason Wang --- hw/virtio-net.c |2 +- include/net/tap.h |4 ++-- net/tap-win32.c |6 +++--- net/tap.c | 38 ++ 4 files changed, 24 insertions(+), 26 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 3bb0

[Qemu-devel] [PATCH V4 05/22] net: intorduce qemu_del_nic()

2013-01-30 Thread Jason Wang
To support multiqueue nic, this patch separate the nic destructor from qemu_del_net_client() to a new helper qemu_del_nic() since the mapping bettween NiCState and NetClientState were not 1:1 in multiqueue. The following patches would refactor this function to support multiqueue nic. Signed-off-by

[Qemu-devel] Char flow control patches

2013-01-30 Thread Amit Shah
Hi Anthony, I did some basic testing of the char flow control patches from your char-flow.2 branch. With the following patch applied, things seem to be working fine. I tested the isa-serial and virtio-serial devices. I haven't yet tested with virtio-serial flow control, but at least no regressi

[Qemu-devel] [PATCH V4 07/22] net: introduce qemu_net_client_setup()

2013-01-30 Thread Jason Wang
This patch separates the setup of NetClientState from its allocation, this will allow allocating an arrays of NetClientState and does the initialization one by one which is what multiqueue needs. Signed-off-by: Jason Wang --- net/net.c | 29 +++-- 1 files changed, 19 in

[Qemu-devel] [PATCH V4 12/22] tap: add Linux multiqueue support

2013-01-30 Thread Jason Wang
This patch add basic multiqueue support for Linux. When multiqueue is needed, we will first check whether kernel support multiqueue tap before creating more queues. Two new functions tap_fd_enable() and tap_fd_disable() were introduced to enable and disable a specific queue. Since the multiqueue is

[Qemu-devel] [PATCH 01/18] vnc: Clean up vncws_send_handshake_response()

2013-01-30 Thread Stefan Hajnoczi
From: Markus Armbruster Use appropriate types, drop superfluous casts, use sizeof, don't exploit that this particular call of gnutls_fingerprint() doesn't change its last argument. Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- ui/vnc-ws.c | 11 ++- 1 file changed

[Qemu-devel] [PATCH V4 13/22] tap: support enabling or disabling a queue

2013-01-30 Thread Jason Wang
This patch introduce a new bit - enabled in TAPState which tracks whether a specific queue/fd is enabled. The tap/fd is enabled during initialization and could be enabled/disabled by tap_enalbe() and tap_disable() which calls platform specific helpers to do the real work. Polling of a tap fd can on

[Qemu-devel] [PATCH V4 15/22] tap: multiqueue support

2013-01-30 Thread Jason Wang
Recently, linux support multiqueue tap which could let userspace call TUNSETIFF for a signle device many times to create multiple file descriptors as independent queues. User could also enable/disabe a specific queue through TUNSETQUEUE. The patch adds the generic infrastructure to create multique

Re: [Qemu-devel] [PATCH for-1.4 2/2] linux-user: bsd-user: Don't reset X86CPU twice

2013-01-30 Thread Igor Mammedov
On Wed, 30 Jan 2013 01:34:19 +0100 Andreas Färber wrote: > Since commit 65dee38052597b6285eb208125369f01b29ba6c1 (target-i386: > move cpu_reset and reset callback to cpu.c) the x86 CPU is reset through > cpu_init() but was still reset immediately after in linux-user and > bsd-user. Similarly it w

Re: [Qemu-devel] [PATCH][v3] linux-user: correct semctl() and shmctl()

2013-01-30 Thread Peter Maydell
On 21 January 2013 06:25, Laurent Vivier wrote> case GETALL: > case SETALL: > -err = target_to_host_semarray(semid, &array, target_su.array); > -if (err) > +err = target_to_host_semarray(semid, &array, > + ts

[Qemu-devel] [PATCH V4 09/22] net: multiqueue support

2013-01-30 Thread Jason Wang
This patch adds basic multiqueue support for qemu. The idea is simple, an array of NetClientStates were introduced in NICState, parse_netdev() were extended to find and match all NetClientStates belongs to the backend and place their pointers in NICConf. Then qemu_new_nic can setup a N:N mapping be

[Qemu-devel] [PATCH 4/4] hw/tpci200: Fix compiler warning (redefined symbol with MinGW)

2013-01-30 Thread Stefan Hajnoczi
From: Stefan Weil STATUS_TIMEOUT is defined in winnt.h: CChw/tpci200.o hw/tpci200.c:34:0: warning: "STATUS_TIMEOUT" redefined [enabled by default] /usr/lib/gcc/x86_64-w64-mingw32/4.6/../../../../x86_64-w64-mingw32/include/winnt.h:1036:0: note: this is the location of the previous definit

Re: [Qemu-devel] KVM call minutes 2013-01-29 - Port I/O

2013-01-30 Thread Peter Maydell
On 30 January 2013 11:39, Andreas Färber wrote: > Proposal by hpoussin was to move _list_add() code to ISADevice: > http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg00508.html > > Concerns: > * PCI devices (VGA, QXL) register I/O ports as well > => above patches add dependency on ISABus t

[Qemu-devel] [PATCH V4 11/22] tap: factor out common tap initialization

2013-01-30 Thread Jason Wang
This patch factors out the common initialization of tap into a new helper net_init_tap_one(). This will be used by multiqueue tap patches. Signed-off-by: Jason Wang --- net/tap.c | 130 ++--- 1 files changed, 73 insertions(+), 57 deletions

[Qemu-devel] [PATCH 07/18] hw/9pfs: Fix unchecked strdup() by converting to g_strdup()

2013-01-30 Thread Stefan Hajnoczi
From: Markus Armbruster Note: the allocation in virtio_9p_init() is still leaked. To be fixed in a followup commit. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- hw/9pfs/virtio-9p-device.c | 2 +- hw/9pfs/virtio-9p-local.c | 8 2 files

[Qemu-devel] [PATCH V4 02/22] net: tap: use abort() instead of assert(0)

2013-01-30 Thread Jason Wang
Signed-off-by: Jason Wang --- net/tap-linux.c |4 ++-- net/tap-win32.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/tap-linux.c b/net/tap-linux.c index 059f5f3..0a6acc7 100644 --- a/net/tap-linux.c +++ b/net/tap-linux.c @@ -164,7 +164,7 @@ int tap_probe_vnet_h

[Qemu-devel] [PATCH 11/18] qemu-log: Fix unchecked strdup() by converting to g_strdup()

2013-01-30 Thread Stefan Hajnoczi
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- qemu-log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-log.c b/qemu-log.c index b655b30..64a1b88 100644 --- a/qemu-log.c +++ b/qemu-log.c @@ -84,7 +

[Qemu-devel] [PATCH V4 03/22] net: introduce qemu_get_queue()

2013-01-30 Thread Jason Wang
To support multiqueue, the patch introduce a helper qemu_get_queue() which is used to get the NetClientState of a device. The following patches would refactor this helper to support multiqueue. Signed-off-by: Jason Wang --- hw/cadence_gem.c|9 +++-- hw/dp8393x.c|9 +++

[Qemu-devel] [PATCH V4 14/22] tap: introduce a helper to get the name of an interface

2013-01-30 Thread Jason Wang
This patch introduces a helper tap_get_ifname() to get the device name of tap device. This is needed when ifname is unspecified in the command line and qemu were asked to create tap device by itself. In this situation, the name were allocated by kernel, so if multiqueue is asked, we need to fetch i

  1   2   3   >