Re: [Qemu-devel] [PATCH][v3] linux-user: correct semctl() and shmctl()

[Peter Maydell]

On 21 January 2013 06:25, Laurent Vivier <laur...@vivier.eu> wrote>
     case GETALL:
>         case SETALL:
> -            err = target_to_host_semarray(semid, &array, target_su.array);
> -            if (err)
> +            err = target_to_host_semarray(semid, &array,
> +                                          tswapal(target_su->array));
> +            if (err) {
> +                unlock_user_struct(target_su, ptr, 0);
>                  return err;
> +            }

     if (err) {
         ret = err;
         break;
     }

avoids the error prone repetition of the unlock_user_struct call.

-- PMM