Re: [Qemu-devel] [kvmarm] [RFC] Virtio-desktop: Virtio-based virtual desktop

2013-01-27 Thread Gleb Natapov
On Fri, Jan 25, 2013 at 08:31:54PM +0100, Alexander Graf wrote: > > On 25.01.2013, at 20:04, Blue Swirl wrote: > > > On Thu, Jan 24, 2013 at 6:10 AM, Anup Patel wrote: > >> Hi All, > >> > >> How about having a generic Virtio-based machine for emulating a virtual > >> desktop ? > > > > I have a

Re: [Qemu-devel] [kvmarm] [RFC] Virtio-desktop: Virtio-based virtual desktop

2013-01-27 Thread Blue Swirl
On Sun, Jan 27, 2013 at 8:20 AM, Gleb Natapov wrote: > On Fri, Jan 25, 2013 at 08:31:54PM +0100, Alexander Graf wrote: >> >> On 25.01.2013, at 20:04, Blue Swirl wrote: >> >> > On Thu, Jan 24, 2013 at 6:10 AM, Anup Patel wrote: >> >> Hi All, >> >> >> >> How about having a generic Virtio-based mach

Re: [Qemu-devel] [PATCH] add fd limitations for avoiding a buffer overflow

2013-01-27 Thread Michael S. Tsirkin
On Fri, Jan 25, 2013 at 04:14:49PM +0800, Amos Kong wrote: > FD_SET() and FD_CLR() are used to add and remove one descriptor from a > set, the 'fd' should be less than FD_SETSIZE. Glibc will give a warning > and crash the qemu when we set a fd (1024) to a set. > > # qemu -device virtio-net-pci,ne

[Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

2013-01-27 Thread Andreas Färber
Make LOG_DISAS() arguments compile-testable even if disabled. Signed-off-by: Andreas Färber --- target-alpha/translate.c | 12 ++-- 1 Datei geändert, 6 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index f687b95..c1da5bf 1

[Qemu-devel] [RFC 14/19] target-microblaze: Refactor debug output macros

2013-01-27 Thread Andreas Färber
Make debug output compile-testable even if disabled. Drop unused D(x) macros. Signed-off-by: Andreas Färber --- target-microblaze/helper.c| 25 ++--- target-microblaze/mmu.c | 28 +--- target-microblaze/op_helper.c |2 -- target-micr

[Qemu-devel] [PATCH for-1.4 06/19] target-s390x: Fix debug output (continued)

2013-01-27 Thread Andreas Färber
Since its introduction in d5a439645a5a70fed5431318c3bce9dc2caa950f (s390x: helper functions for system emulation) the variable name was raddr. Fix this. Signed-off-by: Andreas Färber --- target-s390x/helper.c |4 ++-- 1 Datei geändert, 2 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --gi

[Qemu-devel] [PATCH for-1.4 04/19] target-ppc: Fix build for PPC_DEBUG_DISAS

2013-01-27 Thread Andreas Färber
In r5949 / 76db3ba44ee8db671f804755f13b016eefd13288 (target-ppc: memory load/store rework) variable little_endian was replaced with ctx.le_mode. Update the debug code. Signed-off-by: Andreas Färber --- target-ppc/translate.c |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-

[Qemu-devel] [RFC 12/19] target-i386: Refactor debug output macros

2013-01-27 Thread Andreas Färber
Make debug output compile-testable even if disabled. Signed-off-by: Andreas Färber Cc: Richard Henderson --- target-i386/helper.c | 33 - target-i386/kvm.c| 16 +++- target-i386/seg_helper.c | 20 +++- 3 Dateien geänd

[Qemu-devel] [RFC 19/19] target-unicore32: Refactor debug output macros

2013-01-27 Thread Andreas Färber
Make debug output compile-testable even if disabled. Signed-off-by: Andreas Färber --- target-unicore32/helper.c | 12 ++-- target-unicore32/softmmu.c | 12 ++-- 2 Dateien geändert, 12 Zeilen hinzugefügt(+), 12 Zeilen entfernt(-) diff --git a/target-unicore32/helper.c b/tar

Re: [Qemu-devel] [kvmarm] [RFC] Virtio-desktop: Virtio-based virtual desktop

2013-01-27 Thread Gleb Natapov
On Sun, Jan 27, 2013 at 10:12:20AM +, Blue Swirl wrote: > On Sun, Jan 27, 2013 at 8:20 AM, Gleb Natapov wrote: > > On Fri, Jan 25, 2013 at 08:31:54PM +0100, Alexander Graf wrote: > >> > >> On 25.01.2013, at 20:04, Blue Swirl wrote: > >> > >> > On Thu, Jan 24, 2013 at 6:10 AM, Anup Patel > >>

[Qemu-devel] [PATCH for-1.4 03/19] target-ppc: Fix unused variable warning for FLUSH_ALL_TLBS

2013-01-27 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-ppc/mmu_helper.c |3 ++- 1 Datei geändert, 2 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/target-ppc/mmu_helper.c b/target-ppc/mmu_helper.c index 14fa25a..ee168f1 100644 --- a/target-ppc/mmu_helper.c +++ b/target-ppc/mmu_helper.c @@ -2262,8

[Qemu-devel] [Libvirt][QEMU]The relationships between Libvirt and QEMU indetails

2013-01-27 Thread harryxiyou
Hi Daniel and other developers, We have programed a HLFS(HDFS based Log-Structured FileSystem) driver for QEMU, which you can see it here. http://cloudxy.googlecode.com/svn/trunk/hlfs/patches/hlfs_driver_for_qemu_1.3.0.patch And i have tested in QEMU environment, which works well for us. Now, we

[Qemu-devel] [PATCH RESEND for-1.4 01/19] target-cris: Build fix for debug output

2013-01-27 Thread Andreas Färber
Around r3361 (81fdc5f8d2d681da8d255baf0713144f8656bac9) env->debug1 used to contain the address of an MMU fault. This is now written into env->pregs[PR_EDA] instead. Signed-off-by: Andreas Färber --- target-cris/op_helper.c |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)

[Qemu-devel] [RFC 18/19] target-sparc: Refactor debug output macros

2013-01-27 Thread Andreas Färber
Make debug output compile-testable even if disabled. Inline DEBUG_FEATURES and introduce FEATURES_DPRINTF() in cpu.c. Inline DEBUG_MMU in ldst_helper.c but leave DPRINTF_MMU() outside. Inline DEBUG_{MXCC,ASI} in ldst_helper.c. Signed-off-by: Andreas Färber --- target-sparc/cpu.c | 30

Re: [Qemu-devel] [RFC] Virtio-desktop: Virtio-based virtual desktop

2013-01-27 Thread Anthony Liguori
Anup Patel writes: > Hi All, > > How about having a generic Virtio-based machine for emulating a virtual > desktop ? > > I know folks have already thought about this and probably also tried > something or other on this front but, it will be good to know the downsides. > > Virtio-desktop can be a

Re: [Qemu-devel] [RFC 16/19] target-ppc: Refactor debug output macros

2013-01-27 Thread Anthony Liguori
Andreas Färber writes: > Make debug output compile-testable even if disabled. > > Inline DEBUG_OP check in excp_helper.c. > Inline LOG_MMU_STATE() in mmu_helper.c. > Inline PPC_DEBUG_SPR check in translate_init.c. > > Signed-off-by: Andreas Färber > --- > target-ppc/excp_helper.c| 22

[Qemu-devel] [RFC 15/19] target-openrisc: Refactor debug output macros

2013-01-27 Thread Andreas Färber
Make debug output compile-testable even if disabled. Signed-off-by: Andreas Färber --- target-openrisc/translate.c | 20 ++-- 1 Datei geändert, 10 Zeilen hinzugefügt(+), 10 Zeilen entfernt(-) diff --git a/target-openrisc/translate.c b/target-openrisc/translate.c index 1e1b30c.

[Qemu-devel] [PATCH for-1.4 07/19] target-sparc: Fix debug output for DEBUG_MMU

2013-01-27 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-sparc/ldst_helper.c |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/target-sparc/ldst_helper.c b/target-sparc/ldst_helper.c index cf1bddf..7decd66 100644 --- a/target-sparc/ldst_helper.c +++ b/target-sparc/ldst_helper

Re: [Qemu-devel] [QEMU RFC 0/2] Spying on Memory to implement ethernet can_recieve()

2013-01-27 Thread Anthony Liguori
Peter Crosthwaite writes: > Hi All, > > Have a bit of a tricky question about ethernet controllers. We are > maintaining two ethernet controllers the cadence GEM and the Xilinx AXI > Ethernet both of which are scatter gather (SG) DMA capable. The issue comes > about when trying to impelement t

[Qemu-devel] [PATCH for-1.4 02/19] target-ppc: Fix target_ulong vs. hwaddr format mismatches

2013-01-27 Thread Andreas Färber
To keep log format backwards compatible, cast to target_ulong rather than using HWADDR_PRIx. Signed-off-by: Andreas Färber --- target-ppc/mmu_helper.c |8 +--- 1 Datei geändert, 5 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/target-ppc/mmu_helper.c b/target-ppc/mmu_helper.c

Re: [Qemu-devel] [RFC] FDT as a git submodule?

2013-01-27 Thread Anthony Liguori
Alexander Graf writes: > Am 26.01.2013 um 19:13 schrieb Peter Crosthwaite > : > >> Hi All, >> >> On Sat, Jan 26, 2013 at 2:49 AM, Peter Maydell >> wrote: >>> On 26 January 2013 10:11, Andreas Färber wrote: You forget that a "distro" is pretty much a Linux concept. There is no such

[Qemu-devel] [RFC 16/19] target-ppc: Refactor debug output macros

2013-01-27 Thread Andreas Färber
Make debug output compile-testable even if disabled. Inline DEBUG_OP check in excp_helper.c. Inline LOG_MMU_STATE() in mmu_helper.c. Inline PPC_DEBUG_SPR check in translate_init.c. Signed-off-by: Andreas Färber --- target-ppc/excp_helper.c| 22 +++ target-ppc/kvm.c

Re: [Qemu-devel] [RFC 16/19] target-ppc: Refactor debug output macros

2013-01-27 Thread Andreas Färber
Am 27.01.2013 15:14, schrieb Anthony Liguori: > Andreas Färber writes: >> diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_helper.c >> index 0a1ac86..54722c4 100644 >> --- a/target-ppc/excp_helper.c >> +++ b/target-ppc/excp_helper.c >> @@ -21,14 +21,14 @@ >> >> #include "helper_regs.h" >

[Qemu-devel] [PATCH for-1.4 05/19] target-s390x: Fix debug output

2013-01-27 Thread Andreas Färber
Commit 71e470886fb6092504503a5fe41092ace71c096c (target-s390x: fix style) renamed the cpu_s390x_handle_mmu_fault() argument from _vaddr to orig_vaddr. Update the debug output code. Signed-off-by: Andreas Färber --- target-s390x/helper.c |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeil

Re: [Qemu-devel] [PATCH qom-cpu for-1.4 00/14] QOM CPU fixes for 1.4

2013-01-27 Thread Andreas Färber
Am 26.01.2013 18:16, schrieb Andreas Färber: > Am 23.01.2013 13:07, schrieb Andreas Färber: >> Hello, >> >> This series fixes a number of bugs surrounding QOM CPU instantiation. >> Please ack. > > Ping. > >> First, two remaining users of type_register_static() for iterative CPU type >> registrati

[Qemu-devel] [RFC 17/19] target-s390x: Refactor debug output macros

2013-01-27 Thread Andreas Färber
Make debug output compile-testable even if disabled. Inline S390X_DEBUG_DISAS in translate.c. Signed-off-by: Andreas Färber --- target-s390x/cc_helper.c | 13 +++-- target-s390x/fpu_helper.c | 13 +++-- target-s390x/helper.c | 42 ++-

Re: [Qemu-devel] [RFC 16/19] target-ppc: Refactor debug output macros

2013-01-27 Thread Alexander Graf
On 27.01.2013, at 15:35, Andreas Färber wrote: > Am 27.01.2013 15:14, schrieb Anthony Liguori: >> Andreas Färber writes: >>> diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_helper.c >>> index 0a1ac86..54722c4 100644 >>> --- a/target-ppc/excp_helper.c >>> +++ b/target-ppc/excp_helper.c >>

[Qemu-devel] [RFC 13/19] target-lm32: Refactor debug output macros

2013-01-27 Thread Andreas Färber
Already enabled and thus compile-tested, but align with other targets. Signed-off-by: Andreas Färber --- target-lm32/translate.c | 10 +- 1 Datei geändert, 5 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-) diff --git a/target-lm32/translate.c b/target-lm32/translate.c index 6b87340..01ef7

Re: [Qemu-devel] [RFC 16/19] target-ppc: Refactor debug output macros

2013-01-27 Thread Andreas Färber
Am 27.01.2013 15:46, schrieb Alexander Graf: > > On 27.01.2013, at 15:35, Andreas Färber wrote: > >> Am 27.01.2013 15:14, schrieb Anthony Liguori: >>> Andreas Färber writes: diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_helper.c index 0a1ac86..54722c4 100644 --- a/target

[Qemu-devel] [RFC 11/19] target-cris: Refactor debug output macros

2013-01-27 Thread Andreas Färber
Make debug output compile-testable even if disabled. Introduce DPRINTF() in helper.c and consolidate stdout and stderr output. Introduce DPRINTF() in mmu.c and inline remaining D(x). Drop unused D(x) macro in op_helper.c. Signed-off-by: Andreas Färber --- target-cris/helper.c| 21

[Qemu-devel] [RFC 00/19] Debug output revamp

2013-01-27 Thread Andreas Färber
Hello, Based on a suggestion from Igor Mitsyanko, this series aims to expose debug output to compile-testing, so that it doesn't constantly break. The basic requirement is to move format strings and arguments out of #ifdef sections or no-op macros, so that the C compiler sees them. For one thing

[Qemu-devel] [PATCH for-1.4? 09/19] target-cris/mmu.c: Update Coding Style of cris_mmu_translate_page()

2013-01-27 Thread Andreas Färber
Reindent, add braces, adjust whitespace. Prepares for touching the logging macros. Signed-off-by: Andreas Färber --- target-cris/mmu.c | 312 +++-- 1 Datei geändert, 160 Zeilen hinzugefügt(+), 152 Zeilen entfernt(-) diff --git a/target-cris/mmu.

[Qemu-devel] [PATCH RESEND for-1.4? 08/19] target-cris/helper.c: Update Coding Style

2013-01-27 Thread Andreas Färber
Reindent, add missing braces and drop/adjust whitespace. Prepares for CPUArchState-to-CPUState field movements in cpu_cris_handle_mmu_fault(), do_interruptv10() and do_interrupt(). The remaining functions were so minor that they can be fixed in one go. Signed-off-by: Andreas Färber --- target-c

Re: [Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-27 Thread Blue Swirl
On Sat, Jan 26, 2013 at 8:43 PM, David Woodhouse wrote: > For OVMF we really want to have a way to store non-volatile variables, > other than the dirty hack that currently puts them on a file in the EFI > system partition. > > It looks like we've supported writing to fw_cfg items fairly much since

[Qemu-devel] [PATCH for-1.4] configure: Keep -Werror enabled for Release Candidates

2013-01-27 Thread Andreas Färber
The automatic drop of -Werror during the RC phases has in the past led to warnings creeping into submaintainer trees. Last QEMU Summit it was concluded that -Werror should stay on and enabled only as part of the release process. To relieve our release manager, instead of always enabling -Werror o

Re: [Qemu-devel] [PATCH for-1.4] configure: Keep -Werror enabled for Release Candidates

2013-01-27 Thread Andreas Färber
Am 27.01.2013 16:16, schrieb Andreas Färber: > The automatic drop of -Werror during the RC phases has in the past led > to warnings creeping into submaintainer trees. > > Last QEMU Summit it was concluded that -Werror should stay on and > enabled only as part of the release process. be disabled,

Re: [Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-27 Thread David Woodhouse
On Sun, 2013-01-27 at 15:14 +, Blue Swirl wrote: > It looks like this duplicates rom_add_file() and fw_cfg_add_file(), so > I don't see the point. Both of those are read-only, surely? The firmware inside the guest can't use them for non-volatile storage. It doesn't duplicate fw_cfg_add_file()

Re: [Qemu-devel] qtest tmp105-test endianness issue

2013-01-27 Thread Blue Swirl
On Sat, Jan 26, 2013 at 10:51 PM, Andreas Färber wrote: > Am 26.01.2013 23:21, schrieb Alexander Graf: >> >> On 26.01.2013, at 23:12, Andreas Färber wrote: >> >>> I've found that my tmp105-test fails on Mac OS X ppc(64), i.e. Little >>> Endian arm-softmmu target and Big Endian host: >>> >>> GTESTE

Re: [Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-27 Thread Blue Swirl
On Sun, Jan 27, 2013 at 3:50 PM, David Woodhouse wrote: > On Sun, 2013-01-27 at 15:14 +, Blue Swirl wrote: >> It looks like this duplicates rom_add_file() and fw_cfg_add_file(), so >> I don't see the point. > > Both of those are read-only, surely? The firmware inside the guest can't > use them

Re: [Qemu-devel] [RFC 16/19] target-ppc: Refactor debug output macros

2013-01-27 Thread Alexander Graf
Am 27.01.2013 um 15:54 schrieb Andreas Färber : > Am 27.01.2013 15:46, schrieb Alexander Graf: >> >> On 27.01.2013, at 15:35, Andreas Färber wrote: >> >>> Am 27.01.2013 15:14, schrieb Anthony Liguori: Andreas Färber writes: > diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_he

Re: [Qemu-devel] [kvmarm] [RFC] Virtio-desktop: Virtio-based virtual desktop

2013-01-27 Thread Alexander Graf
On 27.01.2013, at 15:07, Anthony Liguori wrote: > Anup Patel writes: > >> Hi All, >> >> How about having a generic Virtio-based machine for emulating a virtual >> desktop ? >> >> I know folks have already thought about this and probably also tried >> something or other on this front but, it w

Re: [Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-27 Thread Anthony Liguori
David Woodhouse writes: > For OVMF we really want to have a way to store non-volatile variables, > other than the dirty hack that currently puts them on a file in the EFI > system partition. > > It looks like we've supported writing to fw_cfg items fairly much since > they were introduced, but we

[Qemu-devel] [PATCH qom-cpu for-1.4] target-arm: Rename CPU types

2013-01-27 Thread Andreas Färber
In the initial conversion of CPU models to QOM types, model names were mapped 1:1 to type names. As a side effect this gained us a type "any", which is now a device. To avoid "-device any" silliness and to pave the way for compiling multiple targets into one executable, adopt a --cpu scheme. This

Re: [Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-27 Thread David Woodhouse
On Sun, 2013-01-27 at 16:02 +, Blue Swirl wrote: > On Sun, Jan 27, 2013 at 3:50 PM, David Woodhouse wrote: > > On Sun, 2013-01-27 at 15:14 +, Blue Swirl wrote: > >> It looks like this duplicates rom_add_file() and fw_cfg_add_file(), so > >> I don't see the point. > > > > Both of those are

Re: [Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-27 Thread David Woodhouse
On Sun, 2013-01-27 at 10:29 -0600, Anthony Liguori wrote: > David Woodhouse writes: > > > For OVMF we really want to have a way to store non-volatile variables, > > other than the dirty hack that currently puts them on a file in the EFI > > system partition. > > > > It looks like we've supported

Re: [Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-27 Thread Blue Swirl
On Sun, Jan 27, 2013 at 4:38 PM, David Woodhouse wrote: > On Sun, 2013-01-27 at 16:02 +, Blue Swirl wrote: >> On Sun, Jan 27, 2013 at 3:50 PM, David Woodhouse wrote: >> > On Sun, 2013-01-27 at 15:14 +, Blue Swirl wrote: >> >> It looks like this duplicates rom_add_file() and fw_cfg_add_fil

Re: [Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-27 Thread David Woodhouse
On Sun, 2013-01-27 at 16:55 +, Blue Swirl wrote: > > > That problem could be easily solved by allowing a combination of two > images with different RO/RW settings, for example -bios > bios.bin[,offset=0,ro] -bios flash.img, offset=0x8000,rw. /me shudders at the idea of co-ordinating that wit

Re: [Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-27 Thread David Woodhouse
On Sun, 2013-01-27 at 16:59 +, Blue Swirl wrote: > For example hw/spapr_nvram.c implements a similar device. If the user > does not specify any backing file for nvram, its contents will not be > saved. I'll look at that; thanks. -- dwmw2 smime.p7s Description: S/MIME cryptographic signatu

Re: [Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-27 Thread Blue Swirl
On Sun, Jan 27, 2013 at 4:47 PM, David Woodhouse wrote: > On Sun, 2013-01-27 at 10:29 -0600, Anthony Liguori wrote: >> David Woodhouse writes: >> >> > For OVMF we really want to have a way to store non-volatile variables, >> > other than the dirty hack that currently puts them on a file in the EF

[Qemu-devel] [PATCH 0/2 v2] Time resync support by qemu-ga

2013-01-27 Thread Lei Li
This patch series attempts to add time resync support to qemu-ga by introducing qemu-ga commands guest-get-time and guest-set-time. Right now, when a guest is paused or migrated to a file then loaded from that file, the guest OS has no idea that there was a big gap in the time. Depending on how lo

[Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-01-27 Thread Lei Li
Signed-off-by: Lei Li --- include/qapi/qmp/qerror.h |3 +++ qga/commands-posix.c | 30 ++ qga/qapi-schema.json | 38 ++ 3 files changed, 71 insertions(+), 0 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/inc

[Qemu-devel] [PATCH 0/2 v2] Time resync support by qemu-ga

2013-01-27 Thread Lei Li
This patch series attempts to add time resync support to qemu-ga by introducing qemu-ga commands guest-get-time and guest-set-time. Right now, when a guest is paused or migrated to a file then loaded from that file, the guest OS has no idea that there was a big gap in the time. Depending on how lo

[Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-01-27 Thread Lei Li
Signed-off-by: Lei Li --- include/qapi/qmp/qerror.h |3 +++ qga/commands-posix.c | 30 ++ qga/qapi-schema.json | 38 ++ 3 files changed, 71 insertions(+), 0 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/inc

[Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-01-27 Thread Lei Li
Signed-off-by: Lei Li --- qga/commands-posix.c | 76 ++ qga/qapi-schema.json | 42 +++ 2 files changed, 118 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 2fef2b6..5424c50 10

[Qemu-devel] [PATCH qom-cpu for-1.4] target-m68k: Use type_register() instead of type_register_static()

2013-01-27 Thread Andreas Färber
According to its documentation, type_register_static()'s TypeInfo argument should exist for the life type of the type. Therefore use type_register() when registering the list of CPU subtypes. No functional change with the current implementation. Cf. 918fd0839eeafc83bd4984364321a947d29041fe for ar

Re: [Qemu-devel] [PATCH qom-cpu for-1.4 00/14] QOM CPU fixes for 1.4

2013-01-27 Thread Andreas Färber
Am 23.01.2013 13:07, schrieb Andreas Färber: > Andreas Färber (14): > target-openrisc: Don't use type_register_static() > target-unicore32: Don't use type_register_static() Applied these two plus the equally trivial m68k equivalent to qom-cpu (with a more elaborate commit message like on the m

[Qemu-devel] [PATCH qom-cpu for-1.4] target-m68k: Rename CPU types

2013-01-27 Thread Andreas Färber
In the initial conversion of CPU models to QOM types, model names were mapped 1:1 to type names. As a side effect this gained us a type "any", which is now a device. To avoid "-device any" silliness and to pave the way for compiling multiple targets into one executable, adopt a --cpu scheme. No f

Re: [Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-27 Thread Jordan Justen
On Sun, Jan 27, 2013 at 8:38 AM, David Woodhouse wrote: > On Sun, 2013-01-27 at 16:02 +, Blue Swirl wrote: >> On Sun, Jan 27, 2013 at 3:50 PM, David Woodhouse wrote: >> > On Sun, 2013-01-27 at 15:14 +, Blue Swirl wrote: >> >> It looks like this duplicates rom_add_file() and fw_cfg_add_fil

[Qemu-devel] [PATCH qom-cpu for-1.4] target-openrisc: TYPE_OPENRISC_CPU should be abstract

2013-01-27 Thread Andreas Färber
A basic assumption of CPU subtypes is that only specific models get instantiated. A user is not supposed to instantiate an -cpu. Suppress it via abstract = true, which also drops or32-cpu from -cpu ? output. Cc: qemu-sta...@nongnu.org Cc: Jia Liu Signed-off-by: Andreas Färber --- target-openris

[Qemu-devel] [PATCH qom-cpu for-1.4] target-openrisc: Rename CPU subtypes

2013-01-27 Thread Andreas Färber
Model names were mapped 1:1 to type names. As a side effect this registered a type "any", which is now a device. To avoid "-device any" silliness and to pave the way for compiling multiple targets into one executable, adopt a --cpu scheme. No functional changes for -cpu arguments or -cpu ? output

Re: [Qemu-devel] [PATCH qom-cpu for-1.4 08/14] target-unicore32: Detect attempt to instantiate non-CPU type in cpu_init()

2013-01-27 Thread Andreas Färber
Am 23.01.2013 13:07, schrieb Andreas Färber: > diff --git a/target-unicore32/helper.c b/target-unicore32/helper.c > index 5359538..7ace68c 100644 > --- a/target-unicore32/helper.c > +++ b/target-unicore32/helper.c > @@ -29,9 +29,11 @@ CPUUniCore32State *uc32_cpu_init(const char *cpu_model) > { >

[Qemu-devel] [PATCH qom-cpu for-1.4] target-unicore32: Rename CPU subtypes

2013-01-27 Thread Andreas Färber
In the initial conversion of CPU models to QOM types, model names were mapped 1:1 to type names. As a side effect this gained us a type "any", which is now a device. To avoid "-device any" silliness and to pave the way for compiling multiple targets into one executable, adopt a --cpu scheme. No f

[Qemu-devel] [PATCH qom-cpu for-1.4 2/6] target-microblaze: Mark as unmigratable

2013-01-27 Thread Andreas Färber
cpu_{save,load} were no-ops, so de facto it is unmigratable and no backwards compatibility to keep. Therefore mark the MicroBlazeCPU as unmigratable at device level the QOM way and suppress "cpu_common" VMState registration by dropping CPU_SAVE_VERSION. Signed-off-by: Juan Quintela Signed-off-by:

[Qemu-devel] [PATCH qom-cpu for-1.4 0/6] Unmigratable CPUs for 1.4

2013-01-27 Thread Andreas Färber
Hello, Prompted by earlier patches from Juan, this series cleans up some targets that don't implement migration - be it by no-op implementations, by erroring out in the implementation or by lack of implementation. Making targets migratable is preferable over marking devices as migratable is pref

[Qemu-devel] [PATCH qom-cpu for-1.4 1/6] target-unicore32: Mark as unmigratable

2013-01-27 Thread Andreas Färber
CPU_SAVE_VERSION 2 was bogus as both save and load would just throw a hw_error(). Therefore we can without problems suppress registration of "cpu_common" VMState by dropping CPU_SAVE_VERSION define and provide an unmigratable "cpu" VMStateDescription for UniCore32CPU at device level instead, where

[Qemu-devel] [PATCH qom-cpu for-1.4 6/6] target-m68k: Mark as unmigratable

2013-01-27 Thread Andreas Färber
It neither defined CPU_SAVE_VERSION nor implemented cpu_{save,load}(). Mark M68kCPU as unmigratable at device level. Signed-off-by: Andreas Färber --- target-m68k/Makefile.objs |1 - target-m68k/cpu.c |8 2 Dateien geändert, 8 Zeilen hinzugefügt(+), 1 Zeile entfernt(-)

[Qemu-devel] [PATCH qom-cpu for-1.4 3/6] target-xtensa: Mark as unmigratable

2013-01-27 Thread Andreas Färber
There was no CPU_SAVE_VERSION defined, so neither "cpu_common" VMState nor cpu_{save,load}() were registered. Their implementation was no-op. Therefore there is no backwards compatibility to keep, so mark XtensaCPU as unmigratable at device level. Signed-off-by: Andreas Färber --- target-xtensa/

Re: [Qemu-devel] [PATCH qom-cpu for-1.4 0/6] Unmigratable CPUs for 1.4

2013-01-27 Thread Andreas Färber
Am 28.01.2013 01:13, schrieb Andreas Färber: > Hello, > > Prompted by earlier patches from Juan, this series cleans up some targets > that don't implement migration - be it by no-op implementations, by erroring > out in the implementation or by lack of implementation. > > Making targets migratabl

[Qemu-devel] [PATCH qom-cpu for-1.4 5/6] target-s390x: Mark as unmigratable

2013-01-27 Thread Andreas Färber
CPU_SAVE_VERSION was undefined, so "cpu_common" VMState and cpu_{save,load}() were not registered. They were no-ops. Therefore there is no backwards compatibility to keep, so we can mark S390CPU as unmigratable at device level. Signed-off-by: Andreas Färber --- target-s390x/Makefile.objs |1

[Qemu-devel] [PATCH qom-cpu for-1.4 4/6] target-sh4: Mark as unmigratable

2013-01-27 Thread Andreas Färber
It neither defined CPU_SAVE_VERSION nor implemented cpu{save,load}(). Mark it as unmigratable at device level. Signed-off-by: Andreas Färber --- target-sh4/Makefile.objs |1 - target-sh4/cpu.c |9 + 2 Dateien geändert, 9 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) delete

Re: [Qemu-devel] [RFC] Writeable files in fw_cfg

2013-01-27 Thread Anthony Liguori
David Woodhouse writes: > On Sun, 2013-01-27 at 10:29 -0600, Anthony Liguori wrote: >> David Woodhouse writes: >> >> > For OVMF we really want to have a way to store non-volatile variables, >> > other than the dirty hack that currently puts them on a file in the EFI >> > system partition. >> >

Re: [Qemu-devel] [PATCH V5 03/13] block: add bdrv_can_read_snapshot() function

2013-01-27 Thread Wenchao Xia
于 2013-1-26 2:11, Eric Blake 写道: > On 01/23/2013 07:57 PM, Wenchao Xia wrote: >>Compared to bdrv_can_snapshot(), this function return whether >> bs* is ready to read snapshot info from instead of write. If yes, >> caller can then query snapshot information, but taking snapshot >> is not always

Re: [Qemu-devel] [PATCH V15 0/9] libqblock qemu block layer library

2013-01-27 Thread Wenchao Xia
Sorry for that, do you know how to enable these extra checks? I used default configuration by "./configure" and did not check out this errors. > Hi, > > Thank you for submitting your patch series. This patch breaks the build > by causing make to fail. Here's the output: > >GEN i386-so

Re: [Qemu-devel] [PATCH V11 0/4] replace QEMUOptionParameter with QemuOpts parser

2013-01-27 Thread Dong Xu Wang
于 2013-1-25 23:31, Markus Armbruster 写道: > You screwed up your e-mail address: vnet.linux.ibm.com doesn't exist. > My review bounced. Please find it on the list. > > Really sorry for my mistake. I will find them on the list.

Re: [Qemu-devel] [RFC] introduce a general query-config cmd

2013-01-27 Thread Amos Kong
On Wed, Jan 23, 2013 at 06:41:44PM +0800, Amos Kong wrote: > On Tue, Jan 22, 2013 at 12:26:03PM -0600, Anthony Liguori wrote: > > Eric Blake writes: > > > On 01/22/2013 08:52 AM, Amos Kong wrote: > > > > Libvirt will need to expose an attribute that lets the user control > > whether

Re: [Qemu-devel] [PATCH V2 00/20] Multiqueue virtio-net

2013-01-27 Thread Wanlong Gao
On 01/25/2013 06:35 PM, Jason Wang wrote: > Hello all: > > This seires is an update of last version of multiqueue virtio-net support. > > This series tries to brings multiqueue support to virtio-net through a > multiqueue support tap backend and multiple vhost threads. > > To support this, multi

Re: [Qemu-devel] [PATCH V2 00/20] Multiqueue virtio-net

2013-01-27 Thread Jason Wang
On 01/28/2013 11:27 AM, Wanlong Gao wrote: > On 01/25/2013 06:35 PM, Jason Wang wrote: >> Hello all: >> >> This seires is an update of last version of multiqueue virtio-net support. >> >> This series tries to brings multiqueue support to virtio-net through a >> multiqueue support tap backend and mu

[Qemu-devel] [PATCH] qga: cast to int for DWORD type

2013-01-27 Thread Lei Li
This patch fixes a compiler warning when cross-build: qga/service-win32.c: In function 'printf_win_error': qga/service-win32.c:32:5: warning: format '%d' expects argument of type 'int', but argument 3 has type 'DWORD' [-Wformat] Signed-off-by: Lei Li --- qga/service-wi

Re: [Qemu-devel] [PATCH V11 1/4] add def_value_str and use it in qemu_opts_print

2013-01-27 Thread Dong Xu Wang
于 2013-1-25 2:26, Markus Armbruster 写道: > Dong Xu Wang writes: > >> qemu_opts_print has no user now, so can re-write the function safely. >> >> qemu_opts_print will be used while using "qemu-img create", it will >> produce the same output as previous code. >> >> The behavior of this function has

Re: [Qemu-devel] [PATCH v2 19/20] arm: add Faraday FTKBC010 support for A369

2013-01-27 Thread Kuo-Jung Su
Sorry, the description was directly copied from the introduction of its datasheet, it appears to be ambigous in this case. In A369, the FTKBC010 is configured as a keypad controller, not a PS2 keyboard. it acts like some dedicated gpio buttons on the board. In other word: 1. There is no PS2 port

Re: [Qemu-devel] [PATCH v2 20/20] arm: add generic ROM model for Faraday SoC platforms

2013-01-27 Thread Kuo-Jung Su
Thanks for response. The reason why I initialized the QEMU-A36x project a month ago, was to create a embedded ROM code development environment. And there are fews issues at the qemu-1.3.0 which I was working on. 1. The ARM ELF loader failed to correctly handle the image with sparse memory model.

Re: [Qemu-devel] [PATCH v2 03/20] arm: add Faraday FTAPBBRG020 APB DMA support

2013-01-27 Thread Kuo-Jung Su
2013/1/26 Paul Brook > > The FTAPBBRG020 supports the DMA functions for the AHB-to-AHB, > > AHB-to-APB, APB-to-AHB, and APB-to-APB transactions. > > All the timer code in this file looks suspect. As a general rule > everything > should be event driven and complete immediately (or at least schedu

Re: [Qemu-devel] [PATCH v2 19/20] arm: add Faraday FTKBC010 support for A369

2013-01-27 Thread Andreas Färber
Am 28.01.2013 07:05, schrieb Kuo-Jung Su: > Sorry, > the description was directly copied from the introduction of its datasheet, > it appears to be ambigous in this case. I thought so for the "high quality" ethernet adapter. ;) The commit message is supposed to describe the code in technical terms

Re: [Qemu-devel] [PATCH v2 05/20] arm: add Faraday FTGMAC100 1Gbps ethernet support

2013-01-27 Thread Kuo-Jung Su
2013/1/26 Paul Brook > > In order to reduce the processing load of the host CPU, the FTGMAC100 > > implements TCP, UDP, and IP V4 checksum generation and validation, and > > supports VLAN tagging. > > I see no evidence of these features in the code. > > My bad and yes, the VLAN and checksum

Re: [Qemu-devel] [PATCH v2 10/20] arm: add Faraday FTSDC010 MMC/SD controller support

2013-01-27 Thread Kuo-Jung Su
2013/1/26 Paul Brook > > +if (!(s->dcr & DCR_WR) && (s->datacnt > 0)) { > > +ret = sd_read_data(s->card) > > +| sd_read_data(s->card) << 8 > > +| sd_read_data(s->card) << 16 > > +| sd_read_data(s->card) << 24; > > +s-

Re: [Qemu-devel] [PATCH v2 19/20] arm: add Faraday FTKBC010 support for A369

2013-01-27 Thread Kuo-Jung Su
2013/1/28 Andreas Färber > Am 28.01.2013 07:05, schrieb Kuo-Jung Su: > > Sorry, > > the description was directly copied from the introduction of its > datasheet, > > it appears to be ambigous in this case. > > I thought so for the "high quality" ethernet adapter. ;) The commit > message is suppos

Re: [Qemu-devel] [PATCH] hw/m25p80.c: add WRSR(0x01) support

2013-01-27 Thread Kuo-Jung Su
2013/1/26 Peter Crosthwaite > Hi Dante, > > On Fri, Jan 25, 2013 at 5:25 PM, Peter Crosthwaite > wrote: > > Hi Dante, > > > > Sorry about the delay, and thanks for the contribution. Please run the > > patch through the provided checkpatch script (scripts/checkpatch.pl). > > There are a few white

Re: [Qemu-devel] [PATCH v2] target-arm: add Faraday ARMv5TE processors support

2013-01-27 Thread Kuo-Jung Su
2013/1/25 Peter Maydell > On 25 January 2013 07:18, Kuo-Jung Su wrote: > > From: Kuo-Jung Su > > > > Faraday processors are a series of ARMv4/ARMv5TE clone. > > > > * ARMv4 series (FA526, FA626). > > > > All of them are now out-of-date, so I have no plan for them. > > > > * ARMv5TE series (

Re: [Qemu-devel] [PATCH v2 01/20] arm: add Faraday a36x SoC platform support

2013-01-27 Thread Andreas Färber
Am 25.01.2013 10:07, schrieb Andreas Färber: > Am 25.01.2013 09:19, schrieb Kuo-Jung Su: >> hw/a360.c| 271 +++ >> hw/a369.c| 581 >> ++ >> hw/arm/Makefile.objs |6 + >> hw/faraday.h | 21 +

[Qemu-devel] [qemu-devel]The problem of QMP command getfd.

2013-01-27 Thread Li Zhang
Hi all, I am trying to executing qmp command getfd according to qmp-commands.hx. { "execute": "getfd", "arguments": { "fdname": "fd1" } } Every time, it returns the error. { "error": { "class": "GenericError", "desc": "No file descriptor supplied via SCM_RIGHTS" } } Th

Re: [Qemu-devel] [PATCH v2 02/20] arm: add Faraday FUSBH200 EHCI controller

2013-01-27 Thread Andreas Färber
Am 25.01.2013 10:02, schrieb Gerd Hoffmann: >>> +static const MemoryRegionOps ehci_mmio_faraday_ops = { >>> +.read = ehci_faraday_read, >>> +.write = ehci_faraday_write, >>> +.valid.min_access_size = 4, >>> +.valid.max_access_size = 4, >>> +.endianness = DEVICE_LITTLE_ENDIAN, >>

Re: [Qemu-devel] [PATCH v2 00/20] Add Faraday A36x SoC platform support

2013-01-27 Thread Andreas Färber
Am 25.01.2013 09:19, schrieb Kuo-Jung Su: > From: Kuo-Jung Su > > These patches introduce Faraday A36x SoC platform support. > > Faraday provides ARMv4/ARMv5TE compatible solutions, > and focus on ASIC design service. > > Here are some public documents for you reference. > > http://www.farad

Re: [Qemu-devel] [PATCH v2 01/20] arm: add Faraday a36x SoC platform support

2013-01-27 Thread Kuo-Jung Su
sure, no problem. 2013/1/28 Andreas Färber > Am 25.01.2013 10:07, schrieb Andreas Färber: > > Am 25.01.2013 09:19, schrieb Kuo-Jung Su: > >> hw/a360.c| 271 +++ > >> hw/a369.c| 581 > ++ > >> hw/arm/M

Re: [Qemu-devel] [PATCH v2 02/20] arm: add Faraday FUSBH200 EHCI controller

2013-01-27 Thread Kuo-Jung Su
Thanks, I'm working on it, and the new patch is susposed to be sent out later. 2013/1/28 Andreas Färber > Am 25.01.2013 10:02, schrieb Gerd Hoffmann: > >>> +static const MemoryRegionOps ehci_mmio_faraday_ops = { > >>> +.read = ehci_faraday_read, > >>> +.write = ehci_faraday_write, > >>>

Re: [Qemu-devel] [PATCH] [qemu-jeos] Update .gitmodules

2013-01-27 Thread Andreas Färber
Am 02.01.2013 16:53, schrieb Stefan Hajnoczi: > On Wed, Dec 19, 2012 at 12:54:25AM +0100, Andreas Färber wrote: >> sources.redhat.com is timing out, use sourceware.org URL instead. >> >> Signed-off-by: Andreas Färber >> --- >> .gitmodules |2 +- >> 1 Datei geändert, 1 Zeile hinzugefügt(+), 1

Re: [Qemu-devel] hd-geo-test failing on OpenIndiana

2013-01-27 Thread Markus Armbruster
Andreas Färber writes: > Hello Markus, > > On OpenIndiana 151a7 I am seeing assertion failures for ret == 0 in > hd-geo-test.c:35:create_test_img(). It seems it is refusing to blow up > the temporary file. Any suggestion what to do about that? Fine print on ftruncate(): If fildes refers to

Re: [Qemu-devel] [PATCH V11 2/4] Create four opts list related functions

2013-01-27 Thread Dong Xu Wang
于 2013-1-25 2:59, Markus Armbruster 写道: > Dong Xu Wang writes: > >> This patch will create 4 functions, count_opts_list, append_opts_list, >> free_opts_list and print_opts_list, they will used in following commits. >> >> Signed-off-by: Dong Xu Wang >> --- >> v6->v7): >> 1) Fix typo. >> >> v5->v6