sure, no problem.
2013/1/28 Andreas Färber <afaer...@suse.de> > Am 25.01.2013 10:07, schrieb Andreas Färber: > > Am 25.01.2013 09:19, schrieb Kuo-Jung Su: > >> hw/a360.c | 271 +++++++++++++++++++++++ > >> hw/a369.c | 581 > ++++++++++++++++++++++++++++++++++++++++++++++++++ > >> hw/arm/Makefile.objs | 6 + > >> hw/faraday.h | 21 ++ > >> 4 files changed, 879 insertions(+) > >> create mode 100644 hw/a360.c > >> create mode 100644 hw/a369.c > >> create mode 100644 hw/faraday.h > >> > >> diff --git a/hw/a360.c b/hw/a360.c > >> new file mode 100644 > >> index 0000000..cb0a588 > >> --- /dev/null > >> +++ b/hw/a360.c > >> @@ -0,0 +1,271 @@ > >> +/* > >> + * Faraday A360 Evalution Board > >> + * > >> + * Copyright (c) 2012 Faraday Technology > >> + * Written by Dante Su <dant...@faraday-tech.com> > >> + * > >> + * This code is licensed under GNU GPL v2. > > > > Can you please license this and any other files as "v2 or (at your > > option) any later version"? Cf. http://wiki.qemu.org/Relicensing > > > > Also, there is work underway to move target-specific files to the > > subdirectories of hw/, i.e. suggest the new ARM machine should go to > > hw/arm/faraday_a360.c as hw/ is terribly crowded today and a360 is > > pretty generic. > > The same applies to the machine names "a360" and "a369" - I feel they > are too ambiguous, given that there is an AllWinner A20 SoC for > instance. Can you consider renaming to something less ambiguous like > "faraday-a360" or so? > > Andreas > > > For devices it depends on whether they are tightly > > coupled to the ARM SoC or reusable in any target (x86 etc.). > > > > Regards, > > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg > -- Best wishes, Kuo-Jung Su
