Re: [Qemu-devel] [PATCH 3/3] qga: add guest-set-time command

2013-01-11 Thread Lei Li
On 01/08/2013 06:26 AM, Eric Blake wrote: On 01/06/2013 03:07 AM, Lei Li wrote: Signed-off-by: Lei Li --- qga/commands-posix.c | 57 ++ qga/qapi-schema.json | 32 2 files changed, 89 insertions(+), 0 deletions(

[Qemu-devel] [Bug 1036645] Re: /usr/bin/xargs: rm: Argument list too long during make distclean in cross chroot

2013-01-11 Thread Tom Rini
I see this with Ubuntu 12.04 inside of an armhf chroot. Running 'make deb-pkg' also exposes this issue ** Project changed: qemu => qemu-linaro (Ubuntu) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/

Re: [Qemu-devel] [PATCH 3/3] qga: add guest-set-time command

2013-01-11 Thread Lei Li
On 01/09/2013 09:40 PM, Luiz Capitulino wrote: On Sun, 6 Jan 2013 18:07:00 +0800 Lei Li wrote: Signed-off-by: Lei Li --- qga/commands-posix.c | 57 ++ qga/qapi-schema.json | 32 2 files changed, 89 insertion

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-11 Thread Liu Yuan
On 01/11/2013 03:52 PM, MORITA Kazutaka wrote: > At Thu, 10 Jan 2013 13:38:16 +0800, > Liu Yuan wrote: >> >> On 01/09/2013 11:10 PM, Paolo Bonzini wrote: >>> Il 09/01/2013 14:04, Liu Yuan ha scritto: >> 2 The upper layer software which relies on the 'cache=xxx' to choose >> cache mode wil

Re: [Qemu-devel] [Bug 108996 V2] hw/dma.c: Fix converting of ioport_register* to MemoryRegion

2013-01-11 Thread Stefan Hajnoczi
On Thu, Jan 10, 2013 at 06:00:25PM +0100, Andreas Färber wrote: > Am 10.01.2013 17:02, schrieb Stefan Hajnoczi: > > On Wed, Dec 19, 2012 at 12:09:21PM +, Julien Grall wrote: > >> The commit 582299336879504353e60c7937fbc70fea93f3da introduced a 1-shift > >> for > >> some offset in dma emulation

Re: [Qemu-devel] [Bug 108996 V2] hw/dma.c: Fix converting of ioport_register* to MemoryRegion

2013-01-11 Thread Stefan Hajnoczi
On Thu, Jan 10, 2013 at 06:00:25PM +0100, Andreas Färber wrote: > Am 10.01.2013 17:02, schrieb Stefan Hajnoczi: > > On Wed, Dec 19, 2012 at 12:09:21PM +, Julien Grall wrote: > >> The commit 582299336879504353e60c7937fbc70fea93f3da introduced a 1-shift > >> for > >> some offset in dma emulation

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Fix comment (copy+paste bug)

2013-01-11 Thread Stefan Hajnoczi
On Sat, Jan 05, 2013 at 12:17:38PM +0100, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > configure |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan

Re: [Qemu-devel] [PATCH] qga/channel-posix.c: Explicitly include string.h

2013-01-11 Thread Stefan Hajnoczi
On Mon, Jan 07, 2013 at 05:29:55PM +, Peter Maydell wrote: > Explicitly include string.h to avoid warnings under MacOS X/clang > about implicit declarations of strerror() and strlen(). > > Signed-off-by: Peter Maydell > --- > I assume under Linux these are implicitly dragged in via one of the

Re: [Qemu-devel] [Qemu-trivial] [PATCH] savevm: Remove MinGW specific code which is no longer needed

2013-01-11 Thread Stefan Hajnoczi
On Mon, Jan 07, 2013 at 10:20:27PM +0100, Stefan Weil wrote: > QEMU provides a portable function qemu_gettimeofday instead of > gettimeofday and also an implementation of localtime_r for MinGW. > > Signed-off-by: Stefan Weil > --- > savevm.c | 30 ++ > 1 file change

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Replace remaining gmtime, localtime by gmtime_r, localtime_r

2013-01-11 Thread Stefan Hajnoczi
On Mon, Jan 07, 2013 at 11:08:13PM +0100, Stefan Weil wrote: > This allows removing of MinGW specific code and improves > reentrancy for POSIX hosts. > > Signed-off-by: Stefan Weil > --- > block.c | 10 -- > block/vvfat.c |4 > hw/omap1.c|2 +- > vl.c |

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Replace remaining gmtime, localtime by gmtime_r, localtime_r

2013-01-11 Thread Stefan Hajnoczi
On Mon, Jan 07, 2013 at 11:08:13PM +0100, Stefan Weil wrote: > diff --git a/vl.c b/vl.c > index f056c95..21e4a74 100644 > --- a/vl.c > +++ b/vl.c > @@ -454,15 +454,13 @@ void qemu_get_timedate(struct tm *tm, int offset) > ti += offset; > if (rtc_date_offset == -1) { > if (rtc_utc

Re: [Qemu-devel] [PATCH 1/2] VFIO-AER: Vfio-pci driver changes for supporting AER

2013-01-11 Thread Pandarathil, Vijaymohan R
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Wednesday, January 09, 2013 11:05 AM > To: Pandarathil, Vijaymohan R > Cc: Bjorn Helgaas; Gleb Natapov; k...@vger.kernel.org; qemu- > de...@nongnu.org; linux-...@vger.kernel.org; linux-ker...@vger.ker

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: install the "acpi-dsdt.aml" and "q35-acpi-dsdt.aml" blobs too

2013-01-11 Thread Stefan Hajnoczi
On Tue, Jan 08, 2013 at 07:52:20PM +0100, Laszlo Ersek wrote: > The WARNING message from commit f7e4dd6c made me notice. > > Signed-off-by: Laszlo Ersek > --- > Makefile |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/Makefile b/Makefile > index a7ac04b..f6626b5 10

[Qemu-devel] [PULL 0/4] q35: a bunch of little tweaks & fixes.

2013-01-11 Thread Gerd Hoffmann
Hi, The biggest change is the machine type renaming patch. please pull, Gerd The following changes since commit a6308bc2224db238e72c570482717b68246a7ce0: Merge remote-tracking branch 'kraxel/build.1' into staging (2013-01-10 13:26:31 -0600) are available in the git repository at: git

[Qemu-devel] [PATCH 1/4] q35: add ich9 intel hda controller

2013-01-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/intel-hda.c | 41 ++--- 1 files changed, 34 insertions(+), 7 deletions(-) diff --git a/hw/intel-hda.c b/hw/intel-hda.c index 98ff936..eed1d38 100644 --- a/hw/intel-hda.c +++ b/hw/intel-hda.c @@ -1232,7 +1232,7 @@ static Pr

[Qemu-devel] [PATCH 4/4] Makefile: install the "acpi-dsdt.aml" and "q35-acpi-dsdt.aml" blobs too

2013-01-11 Thread Gerd Hoffmann
From: Laszlo Ersek The WARNING message from commit f7e4dd6c made me notice. Signed-off-by: Laszlo Ersek Signed-off-by: Gerd Hoffmann --- Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index ee06448..0200bf3 100644 --- a/Makefile +++ b/Mak

[Qemu-devel] [PATCH 3/4] pc: rename machine types

2013-01-11 Thread Gerd Hoffmann
Starting with release 1.4 we have a fully functional q35 machine type, i.e. "qemu -M q35" JustWorks[tm]. Update machine type names to reflect that: * pc-1.4 becomes pc-i440fx-1.4 * q35-next becomes pc-q35-1.4 The pc-1.3 (+older) names are maintained for compatibility reasons. For the same re

[Qemu-devel] [PATCH 2/4] q35: document chipset devices

2013-01-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- docs/q35-chipset.cfg | 129 ++ 1 files changed, 129 insertions(+), 0 deletions(-) create mode 100644 docs/q35-chipset.cfg diff --git a/docs/q35-chipset.cfg b/docs/q35-chipset.cfg new file mode 100644 index 000

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: install the "acpi-dsdt.aml" and "q35-acpi-dsdt.aml" blobs too

2013-01-11 Thread Gerd Hoffmann
On 01/11/13 09:48, Stefan Hajnoczi wrote: >> > +acpi-dsdt.aml q35-acpi-dsdt.aml \ > I'm not familiar with the ACPI stuff and how we want to ship it. > > Gerd or Anthony: Please review this patch. Patch is correct, just picked it up and stuffed into a q35 poll req. cheers, Gerd

Re: [Qemu-devel] [PATCH 2/2] QEMU-AER: Qemu changes to support AER for VFIO-PCI devices

2013-01-11 Thread Pandarathil, Vijaymohan R
> -Original Message- > From: Blue Swirl [mailto:blauwir...@gmail.com] > Sent: Wednesday, January 09, 2013 1:23 PM > To: Pandarathil, Vijaymohan R > Cc: Alex Williamson; Bjorn Helgaas; Gleb Natapov; linux- > p...@vger.kernel.org; qemu-devel@nongnu.org; k...@vger.kernel.org; linux- > ker...

Re: [Qemu-devel] [PATCH 2/2] QEMU-AER: Qemu changes to support AER for VFIO-PCI devices

2013-01-11 Thread Pandarathil, Vijaymohan R
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Wednesday, January 09, 2013 10:08 AM > To: Pandarathil, Vijaymohan R > Cc: Bjorn Helgaas; Gleb Natapov; k...@vger.kernel.org; qemu- > de...@nongnu.org; linux-...@vger.kernel.org; linux-ker...@vger.ker

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-11 Thread Paolo Bonzini
> bdrv_enable_write_cache() is always > true for now, I guess this need generic change block layer to get the > writethrough/writeback hints. That's not correct. Try hdparm with an IDE disk, or sysfs with a SCSI disk (recent kernels will also support sysfs with an IDE or virtio-blk disk) and you'

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-11 Thread Liu Yuan
On 01/11/2013 05:00 PM, Paolo Bonzini wrote: > That's not correct. Try hdparm with an IDE disk, or sysfs with a SCSI > disk (recent kernels will also support sysfs with an IDE or virtio-blk > disk) and you'll see that it changes. Okay, at least at startup, even with cache=writehtough set, I saw b

Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction

2013-01-11 Thread Stefan Hajnoczi
On Fri, Jan 11, 2013 at 02:22:28PM +0800, Wenchao Xia wrote: > 于 2013-1-10 20:41, Stefan Hajnoczi 写道: > >On Thu, Jan 10, 2013 at 11:21:22AM +0800, Wenchao Xia wrote: > >>于 2013-1-9 20:44, Stefan Hajnoczi 写道: > >>>On Mon, Jan 07, 2013 at 03:28:06PM +0800, Wenchao Xia wrote: > This patch switc

[Qemu-devel] [PATCH V5 0/6] HMP: allow parsing for sub command

2013-01-11 Thread Wenchao Xia
These patches enhance HMP to allow it parse 2nd level of commands, such as info sub command list, which means foldered command with parameter is possible now. V2: Follow the way supposed by Markus, which make the infrastructure knows there is possible a 2nd level of command exist, instead of a

[Qemu-devel] [PATCH V5 1/6] HMP: add QDict to info callback handler

2013-01-11 Thread Wenchao Xia
This patch change all info call back function to take additional QDict * parameter, which allow those command take parameter. Now it is set to NULL at default case. Signed-off-by: Wenchao Xia --- hmp.c | 36 ++-- hmp.h | 3

[Qemu-devel] [PATCH V5 4/6] HMP: filter out space before check of sub-command

2013-01-11 Thread Wenchao Xia
This fix the case when user input "@command ". Original it will return NULL for monitor_parse_command(), now it will return the @command related instance. Signed-off-by: Wenchao Xia --- monitor.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c i

[Qemu-devel] [PATCH 3/6] qga/channel-posix.c: Explicitly include string.h

2013-01-11 Thread Stefan Hajnoczi
From: Peter Maydell Explicitly include string.h to avoid warnings under MacOS X/clang about implicit declarations of strerror() and strlen(). Signed-off-by: Peter Maydell Reviewed-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- qga/channel-posix.c | 1 + 1 file changed, 1 insertion(+) di

[Qemu-devel] [PATCH 5/6] Replace remaining gmtime, localtime by gmtime_r, localtime_r

2013-01-11 Thread Stefan Hajnoczi
From: Stefan Weil This allows removing of MinGW specific code and improves reentrancy for POSIX hosts. [Removed unused ret variable in qemu_get_timedate() to fix warning: vl.c: In function ‘qemu_get_timedate’: vl.c:451:16: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]

[Qemu-devel] [PATCH 6/6] hw/pc.c: Fix converting of ioport_register* to MemoryRegion

2013-01-11 Thread Stefan Hajnoczi
From: Julien Grall The commit 258711 introduced MemoryRegion to replace ioport_region* for ioport 80h and F0h. A MemoryRegion needs to have both read and write callback otherwise a segfault will occur when an access is made. The previous behaviour of this both ioport is to return 0xf

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/pc.c: Fix converting of ioport_register* to MemoryRegion

2013-01-11 Thread Stefan Hajnoczi
On Wed, Jan 09, 2013 at 06:10:22PM +, Julien Grall wrote: > The commit 258711 introduced MemoryRegion to replace ioport_region* > for ioport 80h and F0h. > A MemoryRegion needs to have both read and write callback otherwise a segfault > will occur when an access is made. > > The previous behav

Re: [Qemu-devel] [PATCH v2] sheepdog: implement direct write semantics

2013-01-11 Thread Kevin Wolf
Am 11.01.2013 08:35, schrieb MORITA Kazutaka: > At Thu, 10 Jan 2013 16:03:47 +0800, > Liu Yuan wrote: >> >> From: Liu Yuan >> >> Sheepdog supports both writeback/writethrough write but has not yet supported >> DIRECTIO semantics which bypass the cache completely even if Sheepdog daemon >> is >> s

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

2013-01-11 Thread Stefan Hajnoczi
On Fri, Jan 11, 2013 at 03:27:52PM +0800, 马磊 wrote: > On Fri, Jan 11, 2013 at 2:28 PM, Wanlong Gao wrote: > > > On 01/11/2013 11:39 AM, 马磊 wrote: > > > > > > > > > On Thu, Jan 10, 2013 at 8:20 PM, Daniel P. Berrange > > > > berra...@redhat.com>> wrote: > > > > > > On Wed, Jan 09, 2013 at 09:

Re: [Qemu-devel] [RFC PATCH] PIIX: reset the VM when the Reset Control Register's RCPU bit gets set

2013-01-11 Thread Laszlo Ersek
Hi, On 01/09/13 22:01, Blue Swirl wrote: > On Tue, Jan 8, 2013 at 9:44 PM, Laszlo Ersek wrote: >> +static void i440fx_host_config_write(void *opaque, hwaddr addr, >> + uint64_t val, unsigned len) >> +{ >> +if (addr == 1 && len == 1) { >> +if (val &

Re: [Qemu-devel] [PATCH] e1000: document ICS read behaviour

2013-01-11 Thread Stefan Hajnoczi
On Thu, Jan 10, 2013 at 02:03:39PM +0200, Michael S. Tsirkin wrote: > Add code comment to clarify the reason we set ICS with ICR: > the reason was previously undocumented and git > log (commit b1332393cdd7d023de8f1f8aa136ee7866a18968) > confused rather than clarified the comments. > Digging in the

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-11 Thread Kevin Wolf
Am 11.01.2013 08:52, schrieb MORITA Kazutaka: > At Thu, 10 Jan 2013 13:38:16 +0800, > Liu Yuan wrote: >> >> On 01/09/2013 11:10 PM, Paolo Bonzini wrote: >>> Il 09/01/2013 14:04, Liu Yuan ha scritto: >> 2 The upper layer software which relies on the 'cache=xxx' to choose >> cache mode will

Re: [Qemu-devel] [PATCH] block: do not probe zero-sized disks

2013-01-11 Thread Stefan Hajnoczi
On Thu, Jan 10, 2013 at 03:39:27PM +0100, Paolo Bonzini wrote: > A blank CD or DVD is visible as a zero-sized disks. Probing such > disks will lead to an EIO and a failure to start the VM. Treating > them as raw is a better solution. > > Signed-off-by: Paolo Bonzini > --- > block.c | 2 +- > 1

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-11 Thread Paolo Bonzini
- Messaggio originale - > Da: "Liu Yuan" > A: "Paolo Bonzini" > Cc: "Kevin Wolf" , "Stefan Hajnoczi" , > qemu-devel@nongnu.org, "MORITA Kazutaka" > > Inviato: Venerdì, 11 gennaio 2013 10:04:23 > Oggetto: Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics > > On 01/11

[Qemu-devel] [PATCH V5 2/6] HMP: delete info handler

2013-01-11 Thread Wenchao Xia
Now cmd and info handler have same format, so delete info handler. Signed-off-by: Wenchao Xia --- monitor.c | 91 ++--- 1 files changed, 45 insertions(+), 46 deletions(-) diff --git a/monitor.c b/monitor.c index c7b3014..359f333 100644

[Qemu-devel] [PATCH 2/6] configure: Fix comment (copy+paste bug)

2013-01-11 Thread Stefan Hajnoczi
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index fe18ed2..148d5aa 100755 --- a/configure +++ b/configure @@ -2705,7 +2705,7 @@ if compile_prog "" "" ; then

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-11 Thread Liu Yuan
On 01/11/2013 05:34 PM, Paolo Bonzini wrote: > It is always true for the protocol. It is not always true for the format. > So you mean bdrv_enable_write_cache() always return true for Sheepdog at any time? Thanks, Yuan

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-11 Thread Paolo Bonzini
> On 01/11/2013 05:34 PM, Paolo Bonzini wrote: > > It is always true for the protocol. It is not always true for the > > format. > > So you mean bdrv_enable_write_cache() always return true for Sheepdog > at any time? Yes, at least now. You could in principle have a format that calls bdrv_set_e

[Qemu-devel] [PATCH V5 6/6] HMP: add sub command table to info

2013-01-11 Thread Wenchao Xia
Now info command takes a table of sub info commands, and changed do_info() to do_info_help() to do help funtion only. Note that now "info " returns error instead of list of info topics. Signed-off-by: Wenchao Xia --- hmp-commands.hx |3 ++- monitor.c | 22 +- 2

[Qemu-devel] [PATCH V5 3/6] HMP: add infrastructure for sub command

2013-01-11 Thread Wenchao Xia
This patch make parsing of hmp command aware of that it may have sub command. Also discard simple encapsulation function monitor_find_command(). Signed-off-by: Wenchao Xia --- monitor.c | 48 +--- 1 files changed, 37 insertions(+), 11 deletions(-)

Re: [Qemu-devel] [RFC PATCH] virtio-net: introduce a new macaddr control

2013-01-11 Thread Stefan Hajnoczi
On Thu, Jan 10, 2013 at 10:51:57PM +0800, ak...@redhat.com wrote: > @@ -349,6 +351,13 @@ static int virtio_net_handle_mac(VirtIONet *n, uint8_t > cmd, > { > struct virtio_net_ctrl_mac mac_data; > > +if (cmd == VIRTIO_NET_CTRL_MAC_ADDR_SET && elem->out_num == 2) { > +/* Set MAC

[Qemu-devel] [PATCH 1/6] readline: avoid memcpy() of overlapping regions

2013-01-11 Thread Stefan Hajnoczi
From: Nickolai Zeldovich memcpy() for overlapping regions is undefined behavior; use memmove() instead in readline_hist_add(). [Keep tab characters since surrounding code still uses them -- Stefan] Signed-off-by: Nickolai Zeldovich Reviewed-by: Richard Henderson Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 4/6] savevm: Remove MinGW specific code which is no longer needed

2013-01-11 Thread Stefan Hajnoczi
From: Stefan Weil QEMU provides a portable function qemu_gettimeofday instead of gettimeofday and also an implementation of localtime_r for MinGW. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- savevm.c | 30 ++ 1 file changed, 2 insertions(+), 28 de

[Qemu-devel] [PULL 0/6] Trivial patches for 5 to 11 January 2013

2013-01-11 Thread Stefan Hajnoczi
The following changes since commit 8e4a424b305e29dc0e454f52df3b35577f342975: Revert "virtio-pci: replace byte swap hack" (2013-01-06 18:30:17 +) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes up to c02e1eac887b1b0aee73

Re: [Qemu-devel] [PATCH] Add libcacard/trace/generated-tracers.c to .gitignore

2013-01-11 Thread Stefan Hajnoczi
On Tue, Jan 08, 2013 at 01:28:02AM +0200, Alex Rozenman wrote: > Signed-off-by: Alex Rozenman > --- > .gitignore |1 + > 1 file changed, 1 insertion(+) Thanks, applied and will appear in the trivial patches tree next week: https://github.com/stefanha/qemu/commits/trivial-patches Stefan

[Qemu-devel] [PATCH V5 5/6] HMP: move define of mon_cmds

2013-01-11 Thread Wenchao Xia
Because mon_cmds may use info_cmds, so adjust the declare sequence of them. Signed-off-by: Wenchao Xia --- monitor.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index 7b752a2..f6cb659 100644 --- a/monitor.c +++ b/monitor.c @@ -2425,

Re: [Qemu-devel] [PATCH 0/7 v2] KVM regsync

2013-01-11 Thread Bhushan Bharat-R65777
> -Original Message- > From: Jason J. Herne [mailto:jjhe...@linux.vnet.ibm.com] > Sent: Thursday, January 10, 2013 8:59 PM > To: ag...@suse.de; borntrae...@de.ibm.com; aligu...@us.ibm.com; > mtosa...@redhat.com; qemu-devel@nongnu.org; Bhushan Bharat-R65777; > jan.kis...@siemens.com > Subj

[Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups

2013-01-11 Thread Markus Armbruster
Markus Armbruster (6): qemu-ga: Document intentional fall through in channel_event_cb() qemu-ga: Drop pointless lseek() from ga_open_pidfile() qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path qemu-ga: Plug fd leak on ga_channel_listen_accept() error path qemu-ga: Plug fd

[Qemu-devel] [PATCH 3/6] qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path

2013-01-11 Thread Markus Armbruster
Spotted by Coverity. Also document why we keep it open on success. Signed-off-by: Markus Armbruster --- qga/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qga/main.c b/qga/main.c index 1a22d8d..db47427 100644 --- a/qga/main.c +++ b/qga/main.c @@ -286,10 +286,12 @@ static bool ga_o

[Qemu-devel] [PATCH 5/6] qemu-ga: Plug fd leak on ga_channel_open() error paths

2013-01-11 Thread Markus Armbruster
Spotted by Coverity. Signed-off-by: Markus Armbruster --- qga/channel-posix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qga/channel-posix.c b/qga/channel-posix.c index 5579185..b530808 100644 --- a/qga/channel-posix.c +++ b/qga/channel-posix.c @@ -153,6 +153,7 @@ static gboolean ga_cha

[Qemu-devel] [PATCH 4/6] qemu-ga: Plug fd leak on ga_channel_listen_accept() error path

2013-01-11 Thread Markus Armbruster
Spotted by Coverity. Signed-off-by: Markus Armbruster --- qga/channel-posix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qga/channel-posix.c b/qga/channel-posix.c index d4fd628..5579185 100644 --- a/qga/channel-posix.c +++ b/qga/channel-posix.c @@ -45,6 +45,7 @@ static gboolean ga_chann

[Qemu-devel] [PATCH V2 1/2] oslib-win32: add lock for gmtime_r()

2013-01-11 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- v2: better comments and removed the code change gmtime() to gmtime_r(). --- oslib-win32.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/oslib-win32.c b/oslib-win32.c index e7e283e..9a443da 100644 --- a/oslib-win32.c +++ b/oslib-win

[Qemu-devel] [PATCH V2 2/2] oslib-win32: add lock for localtime_r()

2013-01-11 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- v2: better comments and removed the code change localtime() to localtime_r(). --- oslib-win32.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/oslib-win32.c b/oslib-win32.c index 9a443da..aa1268c 100644 --- a/oslib-win32.c +++ b/osli

Re: [Qemu-devel] [PATCH v2 06/10] chardev: add file chardev support to chardev-add (qmp)

2013-01-11 Thread Gerd Hoffmann
>> ## +# @ChardevFile: > > Should you mention '@in: #optional' and '@out:' in any further > detail? Done. > Hmm; here you document ChardevFile as a separate type, but you > didn't document ChardevDummy in patch 4/10. As the name says it is just a dummy passed when the backend in question doesn'

[Qemu-devel] [PATCH 1/6] qemu-ga: Document intentional fall through in channel_event_cb()

2013-01-11 Thread Markus Armbruster
For clarity, and to hush up Coverity. Signed-off-by: Markus Armbruster --- qga/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qga/main.c b/qga/main.c index a9b968c..47a6bea 100644 --- a/qga/main.c +++ b/qga/main.c @@ -605,6 +605,7 @@ static gboolean channel_event_cb(GIOCondition cond

[Qemu-devel] [PATCH 6/6] qemu-ga: Handle errors uniformely in ga_channel_open()

2013-01-11 Thread Markus Armbruster
We detect errors in seven places. One reports with g_error(), which calls abort(), the others report with g_critical(). Three of them exit(), three return false. Always report with g_critical(), and return false. Signed-off-by: Markus Armbruster --- qga/channel-posix.c | 11 +++ 1 fil

Re: [Qemu-devel] [PATCH v2 07/10] chardev: add serial chardev support to chardev-add (qmp)

2013-01-11 Thread Gerd Hoffmann
On 01/10/13 20:39, Eric Blake wrote: > On 01/10/2013 07:23 AM, Gerd Hoffmann wrote: >> Simliar to file, except that no separate in/out files are >> supported > > s/Simliar/Similar/ Fixed. >> +socket_set_nonblock(fd); > > Can this fail? No. cheers, Gerd

Re: [Qemu-devel] [PATCH v2 08/10] chardev: add parallel chardev support to chardev-add (qmp)

2013-01-11 Thread Gerd Hoffmann
On 01/10/13 20:41, Eric Blake wrote: > On 01/10/2013 07:23 AM, Gerd Hoffmann wrote: >> Also alias the old parport name to parallel for -chardev. >> >> Signed-off-by: Gerd Hoffmann --- >> qapi-schema.json |3 ++- qemu-char.c | 44 >> qemu-opti

Re: [Qemu-devel] [PATCH 3/3 v2] Enable kvm emulated watchdog

2013-01-11 Thread Alexander Graf
Am 11.01.2013 um 07:42 schrieb Bhushan Bharat-R65777 : > > >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Thursday, January 10, 2013 9:07 PM >> To: Bhushan Bharat-R65777 >> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; Bhushan Bharat-R65777 >> Subject:

[Qemu-devel] [PATCH 2/6] qemu-ga: Drop pointless lseek() from ga_open_pidfile()

2013-01-11 Thread Markus Armbruster
After open(), the file offset is already zero, and neither lockf() nor ftruncate() change it. Signed-off-by: Markus Armbruster --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index 47a6bea..1a22d8d 100644 --- a/qga/main.c +++ b/qga/main.

Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-11 Thread Luiz Capitulino
On Fri, 11 Jan 2013 15:19:35 +0800 Lei Li wrote: > >> ## > >> +# @HostTimeInfo > > I'm a bit confused, why do you call it HostTimeInfo if this runs > > in the guest? > > I call it HostTimeInfo because it contains the host time information. qemu-ga runs in the guest, so it's actually the guest

[Qemu-devel] [PATCH v3 05/10] chardev: add hmp hotplug commands

2013-01-11 Thread Gerd Hoffmann
Add chardev-add and chardev-remove commands to the human monitor. chardev-add accepts the same syntax as -chardev, chardev-remove expects a chardev id. Signed-off-by: Gerd Hoffmann --- hmp-commands.hx | 32 hmp.c | 23 +++ hmp.h

[Qemu-devel] [PATCH v3 06/10] chardev: add file chardev support to chardev-add (qmp)

2013-01-11 Thread Gerd Hoffmann
Add support for file chardevs. Output file is mandatory, input file is optional. Signed-off-by: Gerd Hoffmann --- qapi-schema.json | 16 +- qemu-char.c | 61 ++ qmp-commands.hx |8 ++- 3 files changed, 83 insertio

[Qemu-devel] [PATCH v3 00/10] chardev hotplug patch series

2013-01-11 Thread Gerd Hoffmann
Hi, Next chardev hotplug round. Minor API tweak (s/delay/nodelay/ for ChardevSocket). More documentation improvements. Added sanity checks. cheers, Gerd Gerd Hoffmann (10): chardev: add error reporting for qemu_chr_new_from_opts chardev: fix QemuOpts lifecycle chardev: reduce charde

[Qemu-devel] [PATCH v3 09/10] chardev: add socket chardev support to chardev-add (qmp)

2013-01-11 Thread Gerd Hoffmann
qemu_chr_open_socket is splitted into two functions. All initialization after creating the socket file handler is splitted away into the new qemu_chr_open_socket_fd function. chr->filename doesn't get filled from QemuOpts any more. Qemu gathers the information using getsockname and getnameinfo i

[Qemu-devel] [PATCH v3 03/10] chardev: reduce chardev ifdef mess a bit

2013-01-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- qemu-char.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index a29c2bb..c511de3 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -856,6 +856,8 @@ static void cfmakeraw (struct termios *termi

[Qemu-devel] [PATCH v3 04/10] chardev: add qmp hotplug commands, with null chardev support

2013-01-11 Thread Gerd Hoffmann
Add chardev-add and chardev-remove qmp commands. Hotplugging a null chardev is supported for now, more will be added later. Signed-off-by: Gerd Hoffmann --- qapi-schema.json | 49 + qemu-char.c | 52 +++

Re: [Qemu-devel] [PATCH 6/6] hw/pc.c: Fix converting of ioport_register* to MemoryRegion

2013-01-11 Thread Andreas Färber
Am 11.01.2013 10:18, schrieb Stefan Hajnoczi: > From: Julien Grall > > The commit 258711 introduced MemoryRegion to replace ioport_region* > for ioport 80h and F0h. > A MemoryRegion needs to have both read and write callback otherwise a segfault > will occur when an access is made. > > The previ

[Qemu-devel] [PATCH v3 02/10] chardev: fix QemuOpts lifecycle

2013-01-11 Thread Gerd Hoffmann
qemu_chr_new_from_opts handles QemuOpts release now, so callers don't have to worry. It will either be saved in CharDriverState, then released in qemu_chr_delete, or in the error case released instantly. Signed-off-by: Gerd Hoffmann --- include/char/char.h |1 + qemu-char.c | 20 +

[Qemu-devel] [PATCH v3 07/10] chardev: add serial chardev support to chardev-add (qmp)

2013-01-11 Thread Gerd Hoffmann
Similar to file, except that no separate in/out files are supported because it's pointless for direct device access. Also the special tty ioctl hooks (pass through linespeed settings etc) are activated on Unix. Signed-off-by: Gerd Hoffmann --- qapi-schema.json | 17 ++ qemu-char.c

[Qemu-devel] [PATCH v3 08/10] chardev: add parallel chardev support to chardev-add (qmp)

2013-01-11 Thread Gerd Hoffmann
Also alias the old parport name to parallel for -chardev. Signed-off-by: Gerd Hoffmann --- qapi-schema.json |3 ++- qemu-char.c | 44 qemu-options.hx |5 - 3 files changed, 34 insertions(+), 18 deletions(-) diff --git a/qapi-schem

[Qemu-devel] [PATCH v3 10/10] chardev: add pty chardev support to chardev-add (qmp)

2013-01-11 Thread Gerd Hoffmann
The ptsname is returned directly, so there is no need to use query-chardev to figure the pty device path. Signed-off-by: Gerd Hoffmann --- qapi-schema.json |3 ++- qemu-char.c | 13 + qmp-commands.hx |5 + 3 files changed, 20 insertions(+), 1 deletions(-) diff --

Re: [Qemu-devel] [RFC PATCH] PIIX: reset the VM when the Reset Control Register's RCPU bit gets set

2013-01-11 Thread Andreas Färber
Hi, Am 11.01.2013 10:30, schrieb Laszlo Ersek: > On 01/09/13 22:01, Blue Swirl wrote: >> On Tue, Jan 8, 2013 at 9:44 PM, Laszlo Ersek wrote: > >>> +static void i440fx_host_config_write(void *opaque, hwaddr addr, >>> + uint64_t val, unsigned len) >>> +{ >>> +

[Qemu-devel] [PATCH v3 01/10] chardev: add error reporting for qemu_chr_new_from_opts

2013-01-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/char/char.h |3 ++- qemu-char.c | 24 +++- vl.c|9 ++--- 3 files changed, 23 insertions(+), 13 deletions(-) diff --git a/include/char/char.h b/include/char/char.h index baa5d03..1952a10 100644 ---

Re: [Qemu-devel] [RFC PATCH] PIIX: reset the VM when the Reset Control Register's RCPU bit gets set

2013-01-11 Thread Laszlo Ersek
On 01/09/13 22:01, Blue Swirl wrote: > On Tue, Jan 8, 2013 at 9:44 PM, Laszlo Ersek wrote: >> static int i440fx_pcihost_initfn(SysBusDevice *dev) >> { >> PCIHostState *s = PCI_HOST_BRIDGE(dev); >> >> -memory_region_init_io(&s->conf_mem, &pci_host_conf_le_ops, s, >> +i440fx_host_con

Re: [Qemu-devel] [PATCH scsi-ish] raw-posix: fix bdrv_aio_ioctl

2013-01-11 Thread Kevin Wolf
Am 10.01.2013 15:28, schrieb Paolo Bonzini: > When the raw-posix aio=thread code was moved from posix-aio-compat.c > to block/raw-posix.c, there was an unintended change to the ioctl code. > The code used to return the ioctl command, which posix_aio_read() > would later morph into a zero. This hac

[Qemu-devel] [PATCH] block: fix initialization in bdrv_io_limits_enable()

2013-01-11 Thread Peter Lieven
bdrv_io_limits_enable() starts a new slice, but does not set io_base correctly for that slice. Here is how io_base is used: bytes_base = bs->nr_bytes[is_write] - bs->io_base.bytes[is_write]; bytes_res = (unsigned) nb_sectors * BDRV_SECTOR_SIZE; if (bytes_base + bytes_res <= bytes_li

Re: [Qemu-devel] [PATCH 06/17] target-i386: remove vendor_override field from CPUX86State

2013-01-11 Thread Eduardo Habkost
On Fri, Jan 11, 2013 at 03:10:20AM +0100, Igor Mammedov wrote: > commit 8935499831312 makes cpuid return to guest host's vendor value > instead of built-in one by default if kvm_enabled() == true and allows > to override this behavior if 'vendor' is specified on -cpu command line. > > But every ti

Re: [Qemu-devel] [PATCH 06/17] target-i386: remove vendor_override field from CPUX86State

2013-01-11 Thread Eduardo Habkost
On Fri, Jan 11, 2013 at 04:09:45AM +0100, Igor Mammedov wrote: > On Fri, 11 Jan 2013 00:42:13 -0200 > Eduardo Habkost wrote: > > > On Fri, Jan 11, 2013 at 03:10:20AM +0100, Igor Mammedov wrote: > > > commit 8935499831312 makes cpuid return to guest host's vendor value > > > instead of built-in on

[Qemu-devel] [PATCH v2 1/3] block: make qiov_is_aligned() public

2013-01-11 Thread Stefan Hajnoczi
The qiov_is_aligned() function checks whether a QEMUIOVector meets a BlockDriverState's alignment requirements. This is needed by virtio-blk-data-plane so: 1. Move the function from block/raw-posix.c to block/block.c. 2. Make it public in block/block.h. 3. Rename to bdrv_qiov_is_aligned(). 4. Cha

[Qemu-devel] [PATCH v2 0/3] dataplane: misaligned buffers support for Windows guests

2013-01-11 Thread Stefan Hajnoczi
Windows guests do not work with x-data-plane=on because misaligned request support is missing in hw/dataplane/virtio-blk.c. This series adds a bounce buffer when the request is misaligned. Windows guests now work with x-data-plane=on. v2: * Use qemu_iovec_from_buffer() on read completion, not q

Re: [Qemu-devel] [PATCH 3/3] dataplane: handle misaligned virtio-blk requests

2013-01-11 Thread Kevin Wolf
Am 10.01.2013 17:48, schrieb Stefan Hajnoczi: > O_DIRECT on Linux has alignment requirements on I/O buffers and > misaligned requests result in -EINVAL. The Linux virtio_blk guest > driver usually submits aligned requests so I forgot to handle misaligned > requests. > > It turns out that virtio-w

Re: [Qemu-devel] [PATCH 0/3] dataplane: misaligned buffers support for Windows guests

2013-01-11 Thread Kevin Wolf
Am 10.01.2013 17:48, schrieb Stefan Hajnoczi: > Windows guests do not work with x-data-plane=on because misaligned request > support is missing in hw/dataplane/virtio-blk.c. This series adds a bounce > buffer when the request is misaligned. Windows guests now work with > x-data-plane=on. > > Ste

[Qemu-devel] [PATCH v2 3/3] dataplane: handle misaligned virtio-blk requests

2013-01-11 Thread Stefan Hajnoczi
O_DIRECT on Linux has alignment requirements on I/O buffers and misaligned requests result in -EINVAL. The Linux virtio_blk guest driver usually submits aligned requests so I forgot to handle misaligned requests. It turns out that virtio-win guest drivers submit misaligned requests. Handle them u

[Qemu-devel] [PATCH v2 2/3] dataplane: extract virtio-blk read/write processing into do_rdwr_cmd()

2013-01-11 Thread Stefan Hajnoczi
Extract code for read/write command processing into do_rdwr_cmd(). This brings together pieces that are spread across process_request(). The real motivation is to set the stage for handling misaligned requests, which the next patch tackles. Signed-off-by: Stefan Hajnoczi --- hw/dataplane/virti

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: try pkg-config for curses

2013-01-11 Thread Vadim Evard
ping Пнд 31 Дек 2012 20:30:59, Vadim Evard писал: configure: try pkg-config for curses Static linkikng against ncurses may require explicit -ltinfo. In case -lcurses and -lncurses both didn't work give pkg-config a chance. Signed-off-by: Vadim Evard --- configure | 4 +++- 1 file changed, 3 in

Re: [Qemu-devel] [PATCH] block: fix initialization in bdrv_io_limits_enable()

2013-01-11 Thread Paolo Bonzini
Il 11/01/2013 13:29, Peter Lieven ha scritto: > bdrv_io_limits_enable() starts a new slice, but does not set io_base > correctly for that slice. > > Here is how io_base is used: > >bytes_base = bs->nr_bytes[is_write] - bs->io_base.bytes[is_write]; >bytes_res = (unsigned) nb_sectors * B

[Qemu-devel] [Bug 1025244] Re: qcow2 image increasing disk size above the virtual limit

2013-01-11 Thread Andy Menzel
Thanks for your advices. I have no more problems with VM-size since deleting snapshot in shutdown-mode. I reduced the overlarge qcow2-images by converting in qcow2 again (that detects unused sectors and omits this). -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [Qemu-devel] [PATCH 3/3] dataplane: handle misaligned virtio-blk requests

2013-01-11 Thread Paolo Bonzini
Il 11/01/2013 13:39, Kevin Wolf ha scritto: > Am 10.01.2013 17:48, schrieb Stefan Hajnoczi: >> O_DIRECT on Linux has alignment requirements on I/O buffers and >> misaligned requests result in -EINVAL. The Linux virtio_blk guest >> driver usually submits aligned requests so I forgot to handle misal

Re: [Qemu-devel] [PATCH v2 3/3] dataplane: handle misaligned virtio-blk requests

2013-01-11 Thread Paolo Bonzini
Il 11/01/2013 13:34, Stefan Hajnoczi ha scritto: > +iov = &bounce_iov; > +iov_cnt = 1; > + > +if (read) { > +/* Need to copy back from bounce buffer on completion */ > +read_qiov = g_slice_new(QEMUIOVector); > +qemu_iovec_init(read_qiov, i

Re: [Qemu-devel] [PATCH V8 2/5] Adding utility function net_checksum_add_iov() for iovec checksum calculation

2013-01-11 Thread Dmitry Fleytman
Thanks for pointing out, Stefan. I've rebased the code and fixed these issues. On Mon, Jan 7, 2013 at 4:04 PM, Stefan Hajnoczi wrote: > On Fri, Dec 07, 2012 at 01:15:06PM +0200, Dmitry Fleytman wrote: > > Signed-off-by: Dmitry Fleytman > > Signed-off-by: Yan Vugenfirer > > --- > > iov.h

Re: [Qemu-devel] [PATCH V8 3/5] Adding common definitions for VMWARE devices

2013-01-11 Thread Dmitry Fleytman
Stefan, We have vmxnet2 implementation ready for submission as well, so this code is not dead :) Dmitry. On Mon, Jan 7, 2013 at 4:17 PM, Stefan Hajnoczi wrote: > On Fri, Dec 07, 2012 at 01:15:07PM +0200, Dmitry Fleytman wrote: > > diff --git a/hw/vmxnet_debug.h b/hw/vmxnet_debug.h > > new fil

Re: [Qemu-devel] [PATCH V2 00/10] snapshot: take block snapshots in unified way

2013-01-11 Thread Luiz Capitulino
On Thu, 10 Jan 2013 14:01:27 +0800 Wenchao Xia wrote: > 于 2013-1-10 6:34, Eric Blake 写道: > > On 01/07/2013 12:27 AM, Wenchao Xia wrote: > >>These patch added a seperated layer to take internal or external > >> snapshots > >> in a unified way, the granularity is block device, so other functio

Re: [Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-11 Thread Tim Hardeck
On 01/08/2013 01:38 AM, Anthony Liguori wrote: > Better, but I still think it's better to advance the buffer based on the > parsed header sizes that to assume there's no additional data. I have used buffer_advance in the patch set v6. Does anything else need to be changed? Regards Tim -- SUSE L

[Qemu-devel] [PATCH 2/2] qbus: make bus reset overrideable by subclasses

2013-01-11 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/qdev-core.h | 15 +++ hw/qdev.c | 16 +++- 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/hw/qdev-core.h b/hw/qdev-core.h index f40fd15..453a061 100644 --- a/hw/qdev-core.h +++ b/hw/qdev-core.h @@ -100,7 +100,22 @@

[Qemu-devel] [PATCH 0/2] qdev: make reset propagation overrideable by subclasses

2013-01-11 Thread Anthony Liguori
This series allows subclasses to override how reset propagates to child devices and/or busses. This will allow a controller to perform specific actions either before or after reset occurs for a specific device. Since DeviceState::reset should model cold reset, I don't believe that any controller

  1   2   3   >