Stefan,

We have vmxnet2 implementation ready for submission as well,
so this code is not dead :)

Dmitry.


On Mon, Jan 7, 2013 at 4:17 PM, Stefan Hajnoczi <stefa...@gmail.com> wrote:

> On Fri, Dec 07, 2012 at 01:15:07PM +0200, Dmitry Fleytman wrote:
> > diff --git a/hw/vmxnet_debug.h b/hw/vmxnet_debug.h
> > new file mode 100644
> > index 0000000..faa1431
> > --- /dev/null
> > +++ b/hw/vmxnet_debug.h
> > @@ -0,0 +1,121 @@
> > +/*
> > + * QEMU VMWARE VMXNET* paravirtual NICs - debugging facilities
> > + *
> > + * Copyright (c) 2012 Ravello Systems LTD (http://ravellosystems.com)
> > + *
> > + * Developed by Daynix Computing LTD (http://www.daynix.com)
> > + *
> > + * Authors:
> > + * Dmitry Fleytman <dmi...@daynix.com>
> > + * Tamir Shomer <tam...@daynix.com>
> > + * Yan Vugenfirer <y...@daynix.com>
> > + *
> > + * This work is licensed under the terms of the GNU GPL, version 2 or
> later.
> > + * See the COPYING file in the top-level directory.
> > + *
> > + */
> > +
> > +#ifndef _QEMU_VMXNET_DEBUG_H
> > +#define _QEMU_VMXNET_DEBUG_H
> > +
> > +#ifdef VMXNET_VERSION_2
> > +    #define VMXNET_DEVICE_NAME "vmxnet"
> > +#elif defined VMXNET_VERSION_3
> > +    #define VMXNET_DEVICE_NAME "vmxnet3"
> > +#else
> > +    #error "VMXNET version is not defined"
> > +#endif
>
> Please drop the VMXNET_VERSION_* conditional dead code, only version 3
> is used.
>



-- 
Dmitry Fleytman
Technology Expert and Consultant,

Daynix Computing Ltd.

Cell: +972-54-2819481
Skype: dmitry.fleytman

Reply via email to