[Qemu-devel] [PATCH v2] sheepdog: implement direct write semantics

From: Liu Yuan Sheepdog supports both writeback/writethrough write but has not yet supported DIRECTIO semantics which bypass the cache completely even if Sheepdog daemon is set up with cache enabled. Suppose cache is enabled on Sheepdog daemon size, the new cache control is cache=writeback # en

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

On Thu, Jan 10, 2013 at 4:03 PM, 马磊 wrote: > > > On Thu, Jan 10, 2013 at 5:37 AM, Blue Swirl wrote: > >> On Wed, Jan 9, 2013 at 7:31 AM, 马磊 wrote: >> > >> > >> >>> Hi, >> >>> The final effect is as follows: >> >>> >> >>> >> >>> [malei@xentest-4-1 Fri Dec 28 ~/honeypot/xen/xen-4.1.2]$ >> qem

Re: [Qemu-devel] QCOW2 deduplication design

On Wed, Jan 9, 2013 at 5:40 PM, Benoît Canet wrote: >> > I.5) cluster removal >> > When a L2 entry to a cluster become stale the qcow2 code decrement the >> > refcount. >> > When the refcount reach zero the L2 hash block of the stale cluster >> > is written to clear the hash. >> > This happen ofte

Re: [Qemu-devel] [PATCH] pc: rename machine types

Gerd Hoffmann writes: > Starting with release 1.4 we have a fully functional q35 machine type, > i.e. "qemu -M q35" JustWorks[tm]. Update machine type names to reflect > that: > > * pc-1.4 becomes pc-piix-1.4 Actually, it becomes pc-i440fx-1.4 (see first hunk below). > * q35-next becomes p

Re: [Qemu-devel] [PATCH] e1000: document ICS read behaviour

On Thu, Jan 10, 2013 at 12:01:22AM +0200, Michael S. Tsirkin wrote: > Add code comment to clarify the reason we set ICS with ICR: > the reason was previously undocumented and git > log (commit b1332393cdd7d023de8f1f8aa136ee7866a18968) > confused rather than clarified the comments. > Digging in the

Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices

Il 09/01/2013 22:40, Michael S. Tsirkin ha scritto: > > Warm reset (virtio status register reset) of virtio-scsi wasn't > > propagated down to the SCSI bus. I fixed it using qdev_reset_all, but > > now I'll do it manually in the HBA. I'm fine with that as long as all > > buses move away from devi

Re: [Qemu-devel] [PATCH 01/12] tap: multiqueue support

On Wed, Jan 09, 2013 at 11:25:24PM +0800, Jason Wang wrote: > On 01/09/2013 05:56 PM, Stefan Hajnoczi wrote: > > On Fri, Dec 28, 2012 at 06:31:53PM +0800, Jason Wang wrote: > >> diff --git a/qapi-schema.json b/qapi-schema.json > >> index 5dfa052..583eb7c 100644 > >> --- a/qapi-schema.json > >> +++

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

> Do you mean the git of > git://xenbits.xen.org/staging/qemu-upstream-unstable.git > ? > ./configure reports: glib-2.12 required to compile QEMU; but the latest > version > is glib-1.2.10-20.el5.x86_64 for kernel 2.6.18-274.3.1.el5xen. > How to make and use the latest qemu from qemu.git? Ple

[Qemu-devel] [PATCH V4 0/4] HMP: allow parsing for sub command

These patches enhance HMP to allow it parse 2nd level of commands, such as info sub command list, which means foldered command with parameter is possible now. V2: Follow the way supposed by Markus, which make the infrastructure knows there is possible a 2nd level of command exist, instead of a

[Qemu-devel] [PATCH V4 2/4] HMP: add infrastructure for sub command

This patch make parsing of hmp command aware of that it may have sub command. Also discard simple encapsulation function monitor_find_command() and qmp_find_cmd(). Signed-off-by: Wenchao Xia --- monitor.c | 31 +++ 1 files changed, 23 insertions(+), 8 deletions(-)

[Qemu-devel] [PATCH V4 1/4] HMP: add QDict to info callback handler

This patch change all info call back function to take additional QDict * parameter, which allow those command take parameter. Now it is set to NULL at default case. Signed-off-by: Wenchao Xia --- hmp.c | 36 ++-- hmp.h | 3

[Qemu-devel] [PATCH V4 4/4] HMP: add sub command table to info

Now info command takes a table of sub info commands, and changed do_info() to do_info_help() to do help funtion only. Signed-off-by: Wenchao Xia --- hmp-commands.hx |3 ++- monitor.c | 22 +- 2 files changed, 3 insertions(+), 22 deletions(-) diff --git a/hmp-co

[Qemu-devel] [PATCH V4 3/4] HMP: move define of mon_cmds

Because mon_cmds may use info_cmds, so adjust the declare sequence of them. Signed-off-by: Wenchao Xia --- monitor.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/monitor.c b/monitor.c index d49a362..3657224 100644 --- a/monitor.c +++ b/monitor.c @@ -2422,

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

Il 10/01/2013 09:04, 马磊 ha scritto: > > Do you mean the git > of _git://xenbits.xen.org/staging/qemu-upstream-unstable.git > ?_ No, git://git.qemu-project.org/qemu.git > ./configure reports: glib-2.12 required to compile QEMU; but the la

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

On Thu, Jan 10, 2013 at 4:33 PM, 陳韋任 (Wei-Ren Chen) < che...@iis.sinica.edu.tw> wrote: > > Do you mean the git of git:// > xenbits.xen.org/staging/qemu-upstream-unstable.git > > ? > > ./configure reports: glib-2.12 required to compile QEMU; but the latest > version > > is glib-1.2.10-20.el5.x86_64

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

>  I need to be against qemu-xen source tree who will exist in xen source tree > as > ioemu-qemu-xen. > Some packages can't be found by yum at cenos5. Not familiar with qemu-xen, but from this link [1] I think qemu-xen also use the same upstream I mentioned before? If you can install that pack

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

On Thu, Jan 10, 2013 at 4:49 PM, 马磊 wrote: > > > On Thu, Jan 10, 2013 at 4:37 PM, Paolo Bonzini wrote: > >> Il 10/01/2013 09:04, 马磊 ha scritto: >> > >> > Do you mean the git >> > of _git://xenbits.xen.org/staging/qemu-upstream-unstable.git >> >

Re: [Qemu-devel] [PATCH 04/11] chardev: add qmp hotplug commands, with null chardev support

Hi, >> +-> { "execute" : "chardev-add", + "arguments" : { "id" : >> "foo", + FIXME } } +<- { "return": {} } > > Let's get that FIXME dealt with: > > -> { "execute" : "chardev-add", "arguments" : { "id" : "foo", > "backend" : { "type" : "null" } } } <- { "return": {

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

On Thu, Jan 10, 2013 at 4:50 PM, 陳韋任 (Wei-Ren Chen) < che...@iis.sinica.edu.tw> wrote: > > I need to be against qemu-xen source tree who will exist in xen source > tree as > > ioemu-qemu-xen. > > Some packages can't be found by yum at cenos5. > >Not familiar with qemu-xen, but from this link

Re: [Qemu-devel] [PATCH 00/12] Multiqueue virtio-net

On Wed, Jan 09, 2013 at 11:33:25PM +0800, Jason Wang wrote: > On 01/09/2013 11:32 PM, Michael S. Tsirkin wrote: > > On Wed, Jan 09, 2013 at 03:29:24PM +0100, Stefan Hajnoczi wrote: > >> On Fri, Dec 28, 2012 at 06:31:52PM +0800, Jason Wang wrote: > >>> Perf Numbers: > >>> > >>> Two Intel Xeon 5620 w

Re: [Qemu-devel] [PATCH v2] sheepdog: implement direct write semantics

On Thu, Jan 10, 2013 at 04:03:47PM +0800, Liu Yuan wrote: > From: Liu Yuan > > Sheepdog supports both writeback/writethrough write but has not yet supported > DIRECTIO semantics which bypass the cache completely even if Sheepdog daemon > is > set up with cache enabled. > > Suppose cache is enab

Re: [Qemu-devel] [PATCH 10/12] virtio-net: multiqueue support

On 01/10/2013 03:16 PM, Jason Wang wrote: > On Thursday, January 10, 2013 02:49:14 PM Wanlong Gao wrote: >> On 01/10/2013 02:43 PM, Jason Wang wrote: >>> On Wednesday, January 09, 2013 11:26:33 PM Jason Wang wrote: On 01/09/2013 06:01 PM, Wanlong Gao wrote: > On 01/09/2013 05:30 PM, Jason

Re: [Qemu-devel] [PATCH 06/11] chardev: add file chardev support to chardev-add (qmp)

On 01/09/13 19:12, Eric Blake wrote: > On 01/07/2013 06:55 AM, Gerd Hoffmann wrote: >> Add support for file chardevs. Output file is mandatory, input >> file is optional. Both file names and file descriptor passing is >> supported. >> >> Signed-off-by: Gerd Hoffmann --- >> qapi-schema.json |

Re: [Qemu-devel] [PATCH 10/11] chardev: add socket chardev support to chardev-add (qmp)

Hi, >> -static CharDriverState *qemu_chr_open_socket(QemuOpts *opts) >> +static CharDriverState *qemu_chr_open_socket_fd(int fd, int >> do_nodelay, +int >> is_listen, int is_telnet, + >> int is_waitconnect, > > These three parameters sound like t

Re: [Qemu-devel] [PATCH 11/11] chardev: add pty chardev support to chardev-add (qmp)

Hi, > But do we really need it to be that complex? Why not just use a > type with an optional member, instead of going through a union: > > { 'type' : 'ChardevReturn', 'data': { '*pty' : 'str' } } Yes, should do, we don't have to pass back the chardev type here. thanks, Gerd

[Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking

If io_limits are specified during runtime that exceed the number of operations in flight bs->io_base is not initialized in the else statement in bdrv_exceed_io_limits(). The wait time calculated in bdrv_exceed_{bps,iops}_limits is thus totally wrong and the machine locks. Signed-off-by: Peter Li

Re: [Qemu-devel] [PATCH V3 2/4] HMP: add infrastructure for sub command

wenchao xia writes: > 于 2013-1-10 11:30, Wenchao Xia 写道: -static const mon_cmd_t *qmp_find_cmd(const char *cmdname) -{ -return search_dispatch_table(qmp_cmds, cmdname); -} >>> >>> Touching qmp_find_cmd() is unrelated to this series. >>> >>OK. >> - -static con

Re: [Qemu-devel] [PATCH 00/12] Multiqueue virtio-net

On 01/10/2013 04:44 PM, Stefan Hajnoczi wrote: > On Wed, Jan 09, 2013 at 11:33:25PM +0800, Jason Wang wrote: >> On 01/09/2013 11:32 PM, Michael S. Tsirkin wrote: >>> On Wed, Jan 09, 2013 at 03:29:24PM +0100, Stefan Hajnoczi wrote: On Fri, Dec 28, 2012 at 06:31:52PM +0800, Jason Wang wrote: >>>

Re: [Qemu-devel] [PATCH 10/12] virtio-net: multiqueue support

On 01/10/2013 05:06 PM, Wanlong Gao wrote: > On 01/10/2013 03:16 PM, Jason Wang wrote: >> On Thursday, January 10, 2013 02:49:14 PM Wanlong Gao wrote: >>> On 01/10/2013 02:43 PM, Jason Wang wrote: On Wednesday, January 09, 2013 11:26:33 PM Jason Wang wrote: > On 01/09/2013 06:01 PM, Wanlon

Re: [Qemu-devel] [okeanos-dev] Re: KVM versions, machine types and failed migrations

On Wed, Jan 09, 2013 at 03:27:53PM +0200, Vangelis Koukis wrote: > On Wed, Jan 09, 2013 at 01:10:45pm +, Daniel P. Berrange wrote: > > When doing migration, the fundamental requirement is that the guest > > OS visible machine ABI must not change. Thus there are three key > > things to take care

Re: [Qemu-devel] [PATCH] e1000: document ICS read behaviour

On Thu, Jan 10, 2013 at 09:26:47AM +0100, Stefan Hajnoczi wrote: > On Thu, Jan 10, 2013 at 12:01:22AM +0200, Michael S. Tsirkin wrote: > > Add code comment to clarify the reason we set ICS with ICR: > > the reason was previously undocumented and git > > log (commit b1332393cdd7d023de8f1f8aa136ee786

Re: [Qemu-devel] [PATCH V4 2/4] HMP: add infrastructure for sub command

Wenchao Xia writes: > This patch make parsing of hmp command aware of that it may > have sub command. Also discard simple encapsulation function > monitor_find_command() and qmp_find_cmd(). > > Signed-off-by: Wenchao Xia > --- > monitor.c | 31 +++ > 1 files chan

Re: [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking

Il 10/01/2013 10:21, Peter Lieven ha scritto: > If io_limits are specified during runtime that exceed the number of > operations in flight > bs->io_base is not initialized in the else statement in > bdrv_exceed_io_limits(). > The wait time calculated in bdrv_exceed_{bps,iops}_limits is thus > total

Re: [Qemu-devel] [PATCH 01/11] chardev: add error reporting for qemu_chr_new_from_opts

Il 07/01/2013 14:55, Gerd Hoffmann ha scritto: > Signed-off-by: Gerd Hoffmann Reviewed-by: Paolo Bonzini > --- > include/char/char.h |3 ++- > qemu-char.c | 24 +++- > vl.c|9 ++--- > 3 files changed, 23 insertions(+), 13 deletions(-) >

Re: [Qemu-devel] [PATCH V4 4/4] HMP: add sub command table to info

Wenchao Xia writes: > Now info command takes a table of sub info commands, > and changed do_info() to do_info_help() to do help funtion > only. Commit message should document that info no longer lists the topics.

Re: [Qemu-devel] [PATCH 02/11] chardev: fix QemuOpts lifecycle

Il 07/01/2013 14:55, Gerd Hoffmann ha scritto: > qemu_chr_new_from_opts handles QemuOpts release now, so callers don't > have to worry. It will either be saved in CharDriverState, then > released in qemu_chr_delete, or in the error case released instantly. > > Signed-off-by: Gerd Hoffmann Revie

Re: [Qemu-devel] [PATCH 03/11] chardev: reduce chardev ifdef mess a bit

Il 07/01/2013 14:55, Gerd Hoffmann ha scritto: > Signed-off-by: Gerd Hoffmann Reviewed-by: Paolo Bonzini Paolo > --- > qemu-char.c | 22 +++--- > 1 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c > index a29c2bb..c511de3 100644 >

Re: [Qemu-devel] [PATCH 01/12] tap: multiqueue support

On Fri, Dec 28, 2012 at 06:31:53PM +0800, Jason Wang wrote: Mainly suggestions to make the code easier to understand, but see the comment about the 1:1 queue/NetClientState model for a general issue with this approach. > Recently, linux support multiqueue tap which could let userspace call > TUN

Re: [Qemu-devel] [PATCH 05/11] chardev: add hmp hotplug commands

Il 07/01/2013 14:55, Gerd Hoffmann ha scritto: > +void hmp_chardev_add(Monitor *mon, const QDict *qdict) > +{ > +const char *args = qdict_get_str(qdict, "args"); > +Error *err = NULL; > +QemuOpts *opts; > + > +opts = qemu_opts_parse(qemu_find_opts("chardev"), args, 1); > +if (op

Re: [Qemu-devel] [PATCH 12/13] savevm: update return value from qemu_savevm_state

On Wed, 2013-01-09 at 15:39 -0700, Eric Blake wrote: > On 01/09/2013 08:18 AM, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > savevm.c | 7 --- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > > @@ -2189,6 +2189,7 @@ void qmp_vm_snapshot_save(bool has_name, const

[Qemu-devel] QEMU NVMe Query : installation of Fedora18 / ubuntu-12.10 on NVMe storage connected to QEMU+UEFI OVMF platform fails

Hi, Installation of fedora18/ubuntu-12.10 on NVMe storage connected to QEMU+UEFI OVMF platform fails due to reset of the NVMe controller. ( I am getting "Resetting the NVME device to idle state" message on the the Terminal from where I have started installation). I think I am unable to complete i

Re: [Qemu-devel] [PATCH 06/11] chardev: add file chardev support to chardev-add (qmp)

Il 10/01/2013 10:10, Gerd Hoffmann ha scritto: > >> > Do we need the complexity of supporting fd passing explicitly? >> > 'getfd' is less than ideal compared to 'add-fd', and for 'add-fd', >> > we would pass via "path":"/dev/fdset/nnn". That is, why do we need >> > to bend over backwards to suppo

Re: [Qemu-devel] [PATCH] ui/vnc: VA API based H.264 encoding for VNC framebuffer updates

On Thu, 10 Jan 2013, Gerd Hoffmann wrote: > On 01/09/13 23:18, Alexander Graf wrote: > > > > On 09.01.2013, at 21:25, Anthony Liguori wrote: > > > >> > >> Since we really can't guarantee that libva will initialize okay, we > >> need to more gracefully handle falling back to another encoding > >>

Re: [Qemu-devel] [PATCH 08/11] chardev: add serial chardev support to chardev-add (qmp)

Il 07/01/2013 14:55, Gerd Hoffmann ha scritto: > Add support for serial chardevs. Windup qemu_chr_open_win() on > Windows, alias to 'tty' on Linux. > > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json |3 ++- > qemu-char.c | 17 +++-- > 2 files changed, 17 insertions

Re: [Qemu-devel] [PATCH 07/11] chardev: add tty chardev support to chardev-add (qmp)

Il 07/01/2013 14:55, Gerd Hoffmann ha scritto: > Simliar to file, except that no separate in/out files are supported > because it's pointless for direct device access. Also the special > tty ioctl hooks (pass through linespeed settings etc) are activated. > Both file names and file descriptor pass

Re: [Qemu-devel] [PATCH 09/11] chardev: add parport chardev support to chardev-add (qmp)

Il 07/01/2013 14:55, Gerd Hoffmann ha scritto: > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json |3 ++- > qemu-char.c | 43 +++ > 2 files changed, 29 insertions(+), 17 deletions(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > in

Re: [Qemu-devel] [PATCH 11/11] chardev: add pty chardev support to chardev-add (qmp)

Il 09/01/2013 18:37, Eric Blake ha scritto: > It also raises the question of whether unions even work with raw types, > or whether you have to always go through a struct, in which case you > should have used the 'String' wrapper instead of 'str', looking like: > > { 'union': 'ChardevReturn', 'data

Re: [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking

Subject line made me go "huh?" until I realized that you mean "Guest locks up", not "QEMU uses locks to synchronize". Suggest to add the preposition :) Peter Lieven writes: > If io_limits are specified during runtime that exceed the number of > operations in flight > bs->io_base is not initial

Re: [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking

Am 10.01.2013 um 11:19 schrieb Paolo Bonzini : > Il 10/01/2013 10:21, Peter Lieven ha scritto: >> If io_limits are specified during runtime that exceed the number of >> operations in flight >> bs->io_base is not initialized in the else statement in >> bdrv_exceed_io_limits(). >> The wait time cal

Re: [Qemu-devel] [PATCH 05/11] chardev: add hmp hotplug commands

On 01/10/13 11:33, Paolo Bonzini wrote: > Il 07/01/2013 14:55, Gerd Hoffmann ha scritto: >> +void hmp_chardev_add(Monitor *mon, const QDict *qdict) >> +{ >> +const char *args = qdict_get_str(qdict, "args"); >> +Error *err = NULL; >> +QemuOpts *opts; >> + >> +opts = qemu_opts_parse(q

Re: [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking

Il 10/01/2013 11:52, Peter Lieven ha scritto: >> > Also, perhaps you can just call >> > >> >bdrv_exceed_io_limits(bs, 0, 0, NULL); > won`t this segfault if only one of bps or ions limit is set? > in this case it reads wait before returning false in > bdrv_exceed_{bps,iops}_limits(). I didn't

Re: [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking

Il 10/01/2013 11:45, Markus Armbruster ha scritto: > >> > If io_limits are specified during runtime that exceed the number of >> > operations in flight >> > bs->io_base is not initialized in the else statement in >> > bdrv_exceed_io_limits(). > I'm confused. > > if ((bs->slice_start < now)

Re: [Qemu-devel] [PATCH 05/11] chardev: add hmp hotplug commands

Il 10/01/2013 11:53, Gerd Hoffmann ha scritto: >> > >> > This ought to use qmp_chardev_add and a generic opts->ChardevBackend >> > conversion. >> > >> > But IMHO, this kind of intermediate conversion is okay, with the >> > "correct" thing deferred; being able to play with hotplug from HMP is >> >

Re: [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking

Am 10.01.2013 um 11:45 schrieb Markus Armbruster : > Subject line made me go "huh?" until I realized that you mean "Guest > locks up", not "QEMU uses locks to synchronize". Suggest to add the > preposition :) > > Peter Lieven writes: > >> If io_limits are specified during runtime that exceed

Re: [Qemu-devel] [PATCH V4 2/4] HMP: add infrastructure for sub command

Wenchao Xia writes: > This patch make parsing of hmp command aware of that it may > have sub command. Also discard simple encapsulation function > monitor_find_command() and qmp_find_cmd(). > > Signed-off-by: Wenchao Xia > --- > monitor.c | 31 +++ > 1 files chan

Re: [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking

Am 10.01.2013 um 11:55 schrieb Paolo Bonzini : > Il 10/01/2013 11:52, Peter Lieven ha scritto: Also, perhaps you can just call bdrv_exceed_io_limits(bs, 0, 0, NULL); >> won`t this segfault if only one of bps or ions limit is set? >> in this case it reads wait before returning fa

Re: [Qemu-devel] [PATCH 08/11] chardev: add serial chardev support to chardev-add (qmp)

Hi, >> diff --git a/qapi-schema.json b/qapi-schema.json >> index 7e5c8c2..d833385 100644 >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -3036,7 +3036,8 @@ >> { 'type': 'ChardevFile', 'data': { '*in' : 'ChardevFileSource', >> 'out' : 'ChardevFileSou

Re: [Qemu-devel] [PATCH] ui/vnc: VA API based H.264 encoding for VNC framebuffer updates

On 01/10/13 11:37, Stefano Stabellini wrote: > On Thu, 10 Jan 2013, Gerd Hoffmann wrote: >> On 01/09/13 23:18, Alexander Graf wrote: >> Using libavcodec directly is a non-starter as distros don't ship that >> due to the multimedia codec patent mess. > > libavcodec is certainly available on my ubun

Re: [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking

Il 10/01/2013 11:59, Peter Lieven ha scritto: > I hope my fix is correct. Maybe there is sth else wrong, but at least this > fixes the locking of the guest for me. Yes, I also believe youre fix is correct (only aesthetic remarks). Paolo > My intention is not to limit I/O in general, just watch

Re: [Qemu-devel] [PATCH 11/12] qemu-ga: execute hook to quiesce the guest on fsfreeze-freeze/thaw

On Wed, 9 Jan 2013 21:02:37 + Blue Swirl wrote: > On Tue, Jan 8, 2013 at 11:00 PM, Michael Roth > wrote: > > From: Tomoki Sekiyama > > > > To use the online disk snapshot for online-backup, application-level > > consistency of the snapshot image is required. However, currently the > > gues

Re: [Qemu-devel] [PATCH] ui/vnc: VA API based H.264 encoding for VNC framebuffer updates

On 10.01.2013, at 12:10, Gerd Hoffmann wrote: > On 01/10/13 11:37, Stefano Stabellini wrote: >> On Thu, 10 Jan 2013, Gerd Hoffmann wrote: >>> On 01/09/13 23:18, Alexander Graf wrote: >>> Using libavcodec directly is a non-starter as distros don't ship that >>> due to the multimedia codec patent m

Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices

On Thu, Jan 10, 2013 at 09:31:05AM +0100, Paolo Bonzini wrote: > Il 09/01/2013 22:40, Michael S. Tsirkin ha scritto: > > > Warm reset (virtio status register reset) of virtio-scsi wasn't > > > propagated down to the SCSI bus. I fixed it using qdev_reset_all, but > > > now I'll do it manually in th

Re: [Qemu-devel] [RFC 02/12] target-i386: Don't set any KVM flag by default if KVM is disabled

On Wed, Jan 09, 2013 at 04:53:42PM -0200, Eduardo Habkost wrote: > This is a cleanup that tries to solve two small issues: > > - We don't need a separate kvm_pv_eoi_features variable just to keep a >constant calculated at compile-time, and this style would require >adding a separate varia

Re: [Qemu-devel] [PATCH] ui/vnc: VA API based H.264 encoding for VNC framebuffer updates

On 01/10/13 12:19, Alexander Graf wrote: > > On 10.01.2013, at 12:10, Gerd Hoffmann wrote: > >> On 01/10/13 11:37, Stefano Stabellini wrote: >>> On Thu, 10 Jan 2013, Gerd Hoffmann wrote: On 01/09/13 23:18, Alexander Graf wrote: Using libavcodec directly is a non-starter as distros don't

Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices

On 9 January 2013 09:33, Paolo Bonzini wrote: > It's possible. I'll move the SCSI bus away from qdev reset. > Anthony/Michael, can you help doing the same with PCIDevice? And > perhaps Peter and Andreas with sysbus? What does it even mean to reset a sysbus? Do we do it anywhere? (it looks like

Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices

Il 10/01/2013 12:46, Peter Maydell ha scritto: >> > It's possible. I'll move the SCSI bus away from qdev reset. >> > Anthony/Michael, can you help doing the same with PCIDevice? And >> > perhaps Peter and Andreas with sysbus? > What does it even mean to reset a sysbus? Do we do it anywhere? > (it

Re: [Qemu-devel] [PATCH 00/12] Multiqueue virtio-net

On Thu, Jan 10, 2013 at 05:34:14PM +0800, Jason Wang wrote: > On 01/10/2013 04:44 PM, Stefan Hajnoczi wrote: > > On Wed, Jan 09, 2013 at 11:33:25PM +0800, Jason Wang wrote: > >> On 01/09/2013 11:32 PM, Michael S. Tsirkin wrote: > >>> On Wed, Jan 09, 2013 at 03:29:24PM +0100, Stefan Hajnoczi wrote:

Re: [Qemu-devel] [PATCH] e1000: document ICS read behaviour

On Thu, Jan 10, 2013 at 12:17:14PM +0200, Michael S. Tsirkin wrote: > On Thu, Jan 10, 2013 at 09:26:47AM +0100, Stefan Hajnoczi wrote: > > On Thu, Jan 10, 2013 at 12:01:22AM +0200, Michael S. Tsirkin wrote: > > > Add code comment to clarify the reason we set ICS with ICR: > > > the reason was previ

Re: [Qemu-devel] [PATCH v3 2/2] ahci: add migration support

Am 04.01.2013 20:44, schrieb Jason Baron: > From: Jason Baron > > I've tested these patches by migrating Windows 7 and Fedora 17 guests (while > uunder i/o) on both piix with ahci attached and on q35 (which has a built-in > ahci controller). > > Changes from v2: > -migrate all relevant ahci fie

Re: [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking

Paolo Bonzini writes: > Il 10/01/2013 11:45, Markus Armbruster ha scritto: >> >>> > If io_limits are specified during runtime that exceed the number >>> > of operations in flight >>> > bs->io_base is not initialized in the else statement in >>> > bdrv_exceed_io_limits(). >> I'm confused. >> >>

Re: [Qemu-devel] [PATCH 13/13] vm-snapshot-save: add force parameter

On Wed, 2013-01-09 at 15:47 -0700, Eric Blake wrote: > On 01/09/2013 08:18 AM, Pavel Hrdina wrote: > > HMP command "savevm" now takes extra optional force parameter to specifi > > whether > > s/specifi/specify/ > > > replace existing snapshot or not. > > > > QMP command "vm-snapshot-save" has a

Re: [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking

Am 10.01.2013 um 12:52 schrieb Markus Armbruster : > Paolo Bonzini writes: > >> Il 10/01/2013 11:45, Markus Armbruster ha scritto: >>> > If io_limits are specified during runtime that exceed the number > of operations in flight > bs->io_base is not initialized in the else statement

[Qemu-devel] [PATCH] e1000: document ICS read behaviour

Add code comment to clarify the reason we set ICS with ICR: the reason was previously undocumented and git log (commit b1332393cdd7d023de8f1f8aa136ee7866a18968) confused rather than clarified the comments. Digging in the mailing list archives gives the real reason https://lists.gnu.org/archive/html

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

On Wed, Jan 09, 2013 at 03:31:50PM +0800, 马磊 wrote: > Hi, > >> The final effect is as follows: > >> > >> > >> *[malei@xentest-4-1 Fri Dec 28 ~/honeypot/xen/xen-4.1.2]$ qemu-img-xen > >> cat -f /1/boot.ini ~/vm-check.img * > >> *[boot loader]* > >> *timeout=30* > >> *default=multi(0)disk(0)rdisk

Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices

On 10 January 2013 11:47, Paolo Bonzini wrote: > Il 10/01/2013 12:46, Peter Maydell ha scritto: >>> > It's possible. I'll move the SCSI bus away from qdev reset. >>> > Anthony/Michael, can you help doing the same with PCIDevice? And >>> > perhaps Peter and Andreas with sysbus? >> What does it ev

Re: [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking

Il 10/01/2013 12:57, Peter Lieven ha scritto: > Paolo, if you agree I would resubmit the patch (using your description). Using the description is fine. Also at least remove the memset. > I would not directly collapse the code to as its not obvious what > bdrv_exceed_io_limits(bs, 0, 0, NULL);

Re: [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking

Am 10.01.2013 um 13:09 schrieb Paolo Bonzini : > Il 10/01/2013 12:57, Peter Lieven ha scritto: >> Paolo, if you agree I would resubmit the patch (using your description). > > Using the description is fine. Also at least remove the memset. > >> I would not directly collapse the code to as its n

Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices

Il 10/01/2013 12:59, Peter Maydell ha scritto: > >>> > It's possible. I'll move the SCSI bus away from qdev reset. > >>> > Anthony/Michael, can you help doing the same with PCIDevice? And > >>> > perhaps Peter and Andreas with sysbus? >>> >> What does it even mean to reset a sysbus? D

Re: [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking

Il 10/01/2013 13:12, Peter Lieven ha scritto: >> > >> > But perhaps we do not need to start a slice at all when iolimits are >> > set. That is, do >> > >> > bs->slice_start = bs->slice_end = bs->slice_time = 0; >> > >> > or perhaps even nothing at all since bdrv_io_limits_disable should have >

Re: [Qemu-devel] [RFC] updated e1000 mitigation patch

On Thu, Dec 27, 2012 at 11:06:58AM +0100, Luigi Rizzo wrote: > diff -urp qemu-1.3.0-orig/hw/e1000.c qemu-1.3.0/hw/e1000.c > --- qemu-1.3.0-orig/hw/e1000.c2012-12-03 20:37:05.0 +0100 > +++ qemu-1.3.0/hw/e1000.c 2012-12-27 09:47:16.0 +0100 > @@ -35,6 +35,8 @@ > > #inclu

Re: [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking

Am 10.01.2013 um 13:15 schrieb Paolo Bonzini : > Il 10/01/2013 13:12, Peter Lieven ha scritto: But perhaps we do not need to start a slice at all when iolimits are set. That is, do bs->slice_start = bs->slice_end = bs->slice_time = 0; or perhaps even nothing

Re: [Qemu-devel] unbounded qemu NetQue's ?

On Mon, Jan 07, 2013 at 03:27:30PM +0100, Luigi Rizzo wrote: > On Mon, Jan 7, 2013 at 2:49 PM, Stefan Hajnoczi wrote: > > > On Sun, Jan 06, 2013 at 08:23:56PM +0100, Luigi Rizzo wrote: > > diff -urp qemu-1.3.0-orig/net/queue.c qemu-1.3.0/net/queue.c > > > --- qemu-1.3.0-orig/net/queue.c 20

Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices

On 10 January 2013 12:12, Paolo Bonzini wrote: > Il 10/01/2013 12:59, Peter Maydell ha scritto: >> >>> > It's possible. I'll move the SCSI bus away from qdev reset. >> >>> > Anthony/Michael, can you help doing the same with PCIDevice? And >> >>> > perhaps Peter and Andreas with sysbu

Re: [Qemu-devel] [PATCH 05/11] chardev: add hmp hotplug commands

On Thu, 10 Jan 2013 11:33:35 +0100 Paolo Bonzini wrote: > Il 07/01/2013 14:55, Gerd Hoffmann ha scritto: > > +void hmp_chardev_add(Monitor *mon, const QDict *qdict) > > +{ > > +const char *args = qdict_get_str(qdict, "args"); > > +Error *err = NULL; > > +QemuOpts *opts; > > + > > +

Re: [Qemu-devel] [PATCH 08/11] chardev: add serial chardev support to chardev-add (qmp)

Hi, >> Can we just use one name, either tty or serial? Ah, after reading the parport patch comment I think I understand what you suggest: (1) Standardize on 'serial' + 'parallel' on the new qmp interface. (2) Support these names on -chardev too. (3) Alias the old names to the new ones for -

Re: [Qemu-devel] [PATCH] e1000: document ICS read behaviour

On Thu, Jan 10, 2013 at 02:03:39PM +0200, Michael S. Tsirkin wrote: > Add code comment to clarify the reason we set ICS with ICR: > the reason was previously undocumented and git > log (commit b1332393cdd7d023de8f1f8aa136ee7866a18968) > confused rather than clarified the comments. > Digging in the

Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction

On Thu, Jan 10, 2013 at 11:21:22AM +0800, Wenchao Xia wrote: > 于 2013-1-9 20:44, Stefan Hajnoczi 写道: > >On Mon, Jan 07, 2013 at 03:28:06PM +0800, Wenchao Xia wrote: > >> This patch switch to internal common API to take group external > >>snapshots from qmp_transaction interface. qmp layer simply

Re: [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions

On Wed, Jan 09, 2013 at 08:43:51PM +, Blue Swirl wrote: > On Tue, Jan 8, 2013 at 9:03 AM, Stefan Hajnoczi wrote: > > On Mon, Jan 07, 2013 at 03:38:39PM -0500, Nickolai Zeldovich wrote: > >> memcpy() for overlapping regions is undefined behavior; use memmove() > >> instead in readline_hist_add(

Re: [Qemu-devel] buildbot failure in qemu on block_mingw32

On Wed, Jan 09, 2013 at 06:16:01PM +0100, Stefan Weil wrote: > > On Tue, Jan 08, 2013 at 01:06:19AM +0100, q...@buildbot.b1-systems.de > > wrote: > >> The Buildbot has detected a new failure on builder block_mingw32 while > >> building qemu. > >> Full details are available at: > >> http://buildbot

Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices

Il 10/01/2013 13:31, Peter Maydell ha scritto: > On 10 January 2013 12:12, Paolo Bonzini wrote: >> Il 10/01/2013 12:59, Peter Maydell ha scritto: >>> It's possible. I'll move the SCSI bus away from qdev reset. >>> Anthony/Michael, can you help doing the same with PCIDevice? And >

Re: [Qemu-devel] livelock in iolimits

Am 10.01.2013 um 13:45 schrieb Stefan Hajnoczi : > On Tue, Jan 08, 2013 at 04:43:22PM +0100, Peter Lieven wrote: >> i am experimenting with iolimits on a virtio block device and found a lock >> condition. >> My plan was to monitor IOPS and/or bandwidth and kick a limit in if a >> vServer is exh

Re: [Qemu-devel] livelock in iolimits

On Tue, Jan 08, 2013 at 04:43:22PM +0100, Peter Lieven wrote: > i am experimenting with iolimits on a virtio block device and found a lock > condition. > My plan was to monitor IOPS and/or bandwidth and kick a limit in if a vServer > is exhausting > these limits too much. > However, it seems that

Re: [Qemu-devel] [PATCH 08/11] chardev: add serial chardev support to chardev-add (qmp)

Il 10/01/2013 13:37, Gerd Hoffmann ha scritto: >>> >> Can we just use one name, either tty or serial? > Ah, after reading the parport patch comment I think I understand what > you suggest: > > (1) Standardize on 'serial' + 'parallel' on the new qmp interface. Or tty + parallel, as you see more f

Re: [Qemu-devel] [PATCH] block: init bs->io_base correctly to avoid locking

Am 10.01.2013 um 13:15 schrieb Paolo Bonzini : > Il 10/01/2013 13:12, Peter Lieven ha scritto: But perhaps we do not need to start a slice at all when iolimits are set. That is, do bs->slice_start = bs->slice_end = bs->slice_time = 0; or perhaps even nothing

Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices

On 10 January 2013 12:45, Paolo Bonzini wrote: > Il 10/01/2013 13:31, Peter Maydell ha scritto: >> On 10 January 2013 12:12, Paolo Bonzini wrote: >>> It's just an implementation detail. Right now we have a common >>> callback. The idea is to give each bus its own callback. In the case >>> of s

Re: [Qemu-devel] buildbot failure in qemu on block_mingw32

Hi, >> I don't get this error in line 2097 with my native and cross builds, >> nor do I get the warnings. Which version of MinGW is used on the buildbot? >> >> Anyway, it will be fixed with the pending patch >> http://patchwork.ozlabs.org/patch/210240/ > > I've added Gerd on CC if he has time t

[Qemu-devel] [PATCH] monitor: assert monitor_puts()'s loop invariant

Chiefly to hush up Coverity. Signed-off-by: Markus Armbruster --- monitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/monitor.c b/monitor.c index 9cf419b..c6eac60 100644 --- a/monitor.c +++ b/monitor.c @@ -270,6 +270,7 @@ static void monitor_puts(Monitor *mon, const char *str) cha

Re: [Qemu-devel] [PATCH V4 1/4] HMP: add QDict to info callback handler

On Thu, 10 Jan 2013 16:32:31 +0800 Wenchao Xia wrote: > diff --git a/monitor.c b/monitor.c > index 9cf419b..c7b3014 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -123,7 +123,7 @@ typedef struct mon_cmd_t { > const char *help; > void (*user_print)(Monitor *mon, const QObject *data); >

Re: [Qemu-devel] [PATCH V4 2/4] HMP: add infrastructure for sub command

On Thu, 10 Jan 2013 16:32:32 +0800 Wenchao Xia wrote: > This patch make parsing of hmp command aware of that it may > have sub command. Also discard simple encapsulation function > monitor_find_command() and qmp_find_cmd(). You don't qmp_find_cmd() anymore..

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

On Wed, Jan 09, 2013 at 09:37:54PM +, Blue Swirl wrote: > On Wed, Jan 9, 2013 at 7:31 AM, 马磊 wrote: > > > > > >>> Hi, > >>> The final effect is as follows: > >>> > >>> > >>> [malei@xentest-4-1 Fri Dec 28 ~/honeypot/xen/xen-4.1.2]$ qemu-img-xen cat > >>> -f /1/boot.ini ~/vm-check.img > >>>

  1   2   3   4   >