[Qemu-devel] [PATCH V2 04/10] oslib-win32: add lock for time functions

2013-01-07 Thread Wenchao Xia
This patch adding lock for calling gmtime() and localtime() on windows. If no other lib linked into qemu would call those two function itself, then they are thread safe now on windows. Signed-off-by: Wenchao Xia --- oslib-win32.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deleti

[Qemu-devel] [PATCH V2 09/10] snapshot: qmp add blockdev-snapshot-internal-sync interface

2013-01-07 Thread Wenchao Xia
This interface allow user to create internal snapshot on a single block device. Signed-off-by: Wenchao Xia --- blockdev.c | 14 ++ qapi-schema.json | 21 - qmp-commands.hx | 28 3 files changed, 62 insertions(+), 1 delet

[Qemu-devel] [PATCH V2 10/10] snapshot: hmp add internal snapshot support for block device

2013-01-07 Thread Wenchao Xia
Now hmp can take snapshot for a single block device. v2: Removed option -n in internal snapshot case. Better tips. Signed-off-by: Wenchao Xia --- hmp-commands.hx | 28 +--- hmp.c | 25 +++-- 2 files changed, 32 insertions(+), 21 de

[Qemu-devel] [PATCH V2 08/10] snapshot: qmp add internal snapshot transaction interface

2013-01-07 Thread Wenchao Xia
Now qmp_transaction support creating internal snapshot. Signed-off-by: Wenchao Xia --- blockdev.c | 46 ++ qapi-schema.json | 29 + qmp-commands.hx | 24 +--- 3 files changed, 92 insertions

Re: [Qemu-devel] [PATCH] hw/i386: Fix broken build for MinGW

2013-01-07 Thread Gerd Hoffmann
On 01/04/13 22:57, Stefan Weil wrote: > pc-testdev.c cannot be compiled with MinGW: > > CCi386-softmmu/hw/i386/../pc-testdev.o > hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: file not found > hw/i386/../pc-testdev.c: In function ‘test_flush_page’: > hw/i386/../pc-testdev.c:103: warning

[Qemu-devel] [PATCH V2 04/10] oslib-win32: add lock for time functions

2013-01-07 Thread Wenchao Xia
This patch adding lock for calling gmtime() and localtime() on windows. If no other lib linked into qemu would call those two function itself, then they are thread safe now on windows. Signed-off-by: Wenchao Xia --- oslib-win32.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deleti

[Qemu-devel] [Bug 1096712] [NEW] qemu 1.3.0: Windows XP doesn't boot with BSOD STOP 7E in acpi.sys

2013-01-07 Thread Sven
Public bug reported: I'm running qemu-system-i386 -cdrom /path/to/windows_xp_cd.iso and it will yields a BSOD with error code STOP 7E in acpi.sys. This used to work without problems with qemu 1.2.1 and hence is a regression. ** Affects: qemu Importance: Undecided Status: New -- Y

[Qemu-devel] [Bug 1096714] [NEW] qemu 1.3.0: usb devices shouldn't have same vendor/product ID and same serial

2013-01-07 Thread Sven
Public bug reported: Boot Windows XP with ./qemu-system-i386 -device pci-ohci -device usb-tablet and then with ./qemu-system-i386 -device pci-ohci -device usb-kbd and you will notice, that the usb keyboard is not detected. In fact, Windows XP detects the usb tablet and loads the driver for the ta

[Qemu-devel] [Bug 1096713] [NEW] qemu 1.3.0: Windows XP crashes when reconizing the USB keyboard

2013-01-07 Thread Sven
Public bug reported: I'm trying to use the usb tablet and the usb keyboard as follows: ./qemu-system-i386 -device pci-ohci -device usb-tablet -device usb-kbd or ./qemu-system-i386 -device ich9-usb-ehci1 -device ich9-usb-uhci1 -device usb-tablet -device ich9-usb-uhci2 -device usb-kbd While Wind

Re: [Qemu-devel] [PATCH KVM v2 1/4] KVM: fix i8254 IRQ0 to be normally high

2013-01-07 Thread Gleb Natapov
On Wed, Dec 26, 2012 at 10:39:53PM -0700, Matthew Ogilvie wrote: > Reading the spec, it is clear that most modes normally leave the IRQ > output line high, and only pulse it low to generate a leading edge. > Especially the most commonly used mode 2. > > The KVM i8254 model does not try to emulate

Re: [Qemu-devel] [PATCH] QEMU: PPC: set has-idle in guest device tree

2013-01-07 Thread Gerd Hoffmann
On 01/04/13 21:46, Alexander Graf wrote: > > > Am 04.01.2013 um 21:21 schrieb Anthony Liguori : > >> Hi, >> >> This is an automated message generated from the QEMU Patches. >> Thank you for submitting this patch. This patch no longer applies to >> qemu.git. > > Great idea, but not patricularl

Re: [Qemu-devel] [PATCH qom-cpu 01/11] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-07 Thread Eduardo Habkost
On Sun, Jan 06, 2013 at 01:32:34PM +0200, Gleb Natapov wrote: > On Fri, Jan 04, 2013 at 08:01:02PM -0200, Eduardo Habkost wrote: > > This is a cleanup that tries to solve two small issues: > > > > - We don't need a separate kvm_pv_eoi_features variable just to keep a > >constant calculated at

Re: [Qemu-devel] [PATCH qom-cpu 01/11] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-07 Thread Gleb Natapov
On Mon, Jan 07, 2013 at 09:42:36AM -0200, Eduardo Habkost wrote: > On Sun, Jan 06, 2013 at 01:32:34PM +0200, Gleb Natapov wrote: > > On Fri, Jan 04, 2013 at 08:01:02PM -0200, Eduardo Habkost wrote: > > > This is a cleanup that tries to solve two small issues: > > > > > > - We don't need a separat

Re: [Qemu-devel] [PATCH qom-cpu 02/11] target-i386: Disable kvm_mmu_op by default on pc-1.4

2013-01-07 Thread Eduardo Habkost
On Sun, Jan 06, 2013 at 03:38:28PM +0200, Gleb Natapov wrote: > On Fri, Jan 04, 2013 at 08:01:03PM -0200, Eduardo Habkost wrote: > > The kvm_mmu_op feature was removed from the kernel since v3.3 (released > > in March 2012), it was marked for removal since January 2011 and it's > > slower than shad

Re: [Qemu-devel] [PATCH qom-cpu 05/11] target-i386: check/enforce: Fix CPUID leaf numbers on error messages

2013-01-07 Thread Eduardo Habkost
On Sun, Jan 06, 2013 at 04:12:54PM +0200, Gleb Natapov wrote: > On Fri, Jan 04, 2013 at 08:01:06PM -0200, Eduardo Habkost wrote: > > The -cpu check/enforce warnings are printing incorrect information about the > > missing flags. There are no feature flags on CPUID leaves 0 and 0x8000, > > but

Re: [Qemu-devel] [PATCH qom-cpu 10/11] target-i386: Call kvm_check_features_against_host() only if CONFIG_KVM is set

2013-01-07 Thread Eduardo Habkost
On Sun, Jan 06, 2013 at 04:27:19PM +0200, Gleb Natapov wrote: > On Fri, Jan 04, 2013 at 08:01:11PM -0200, Eduardo Habkost wrote: > > This will be necessary once kvm_check_features_against_host() starts > > using KVM-specific definitions (so it won't compile anymore if > > CONFIG_KVM is not set). >

Re: [Qemu-devel] [PATCH KVM v2 2/4] KVM: additional i8254 output fixes

2013-01-07 Thread Gleb Natapov
On Wed, Dec 26, 2012 at 10:39:54PM -0700, Matthew Ogilvie wrote: > Make git_get_out() consistent with spec. Currently pit_get_out() > doesn't affect IRQ0, but it can be read by the guest in other ways. > This makes it consistent with proposed changes in qemu's i8254 model > as well. > > See http:

Re: [Qemu-devel] [PATCH qom-cpu 11/11] target-i386: check/enforce: Check all feature words

2013-01-07 Thread Eduardo Habkost
On Sun, Jan 06, 2013 at 04:35:51PM +0200, Gleb Natapov wrote: > On Fri, Jan 04, 2013 at 08:01:12PM -0200, Eduardo Habkost wrote: > > This adds the following feature words to the list of flags to be checked > > by kvm_check_features_against_host(): > > > > - cpuid_7_0_ebx_features > > - ext4_feat

Re: [Qemu-devel] [PATCH qom-cpu 11/11] target-i386: check/enforce: Check all feature words

2013-01-07 Thread Gleb Natapov
On Mon, Jan 07, 2013 at 10:06:21AM -0200, Eduardo Habkost wrote: > On Sun, Jan 06, 2013 at 04:35:51PM +0200, Gleb Natapov wrote: > > On Fri, Jan 04, 2013 at 08:01:12PM -0200, Eduardo Habkost wrote: > > > This adds the following feature words to the list of flags to be checked > > > by kvm_check_fea

[Qemu-devel] [PATCH 1/1] Added address_space_init2().

2013-01-07 Thread Alexander Barabash
address_space_init2: initializes a named address space. Signed-off-by: Alexander Barabash --- include/exec/memory.h |9 + memory.c |6 ++ 2 files changed, 15 insertions(+) diff --git a/include/exec/memory.h b/include/exec/memory.h index 2322732..8f8a31d 100644 -

Re: [Qemu-devel] [PATCH] fix bits 39:32 of the final physical address when using 4M page

2013-01-07 Thread Markus Armbruster
Wen Congyang writes: > ((pde & 0x1fe000) << 19) is the bits 39:32 of the final physical address, and > we shouldn't use unit32_t to calculate it. Convert the type to hwaddr to fix > this problem. Spotted by Coverity. > Signed-off-by: Wen Congyang > > --- > target-i386/arch_memory_mapping.c |

Re: [Qemu-devel] [PATCH qom-cpu 01/11] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-07 Thread Eduardo Habkost
On Mon, Jan 07, 2013 at 01:42:53PM +0200, Gleb Natapov wrote: > On Mon, Jan 07, 2013 at 09:42:36AM -0200, Eduardo Habkost wrote: > > On Sun, Jan 06, 2013 at 01:32:34PM +0200, Gleb Natapov wrote: > > > On Fri, Jan 04, 2013 at 08:01:02PM -0200, Eduardo Habkost wrote: > > > > This is a cleanup that tr

[Qemu-devel] [PATCH 1/1] Support 2**64 bytes memory regions.

2013-01-07 Thread Alexander Barabash
Memory regions created with size UINT64_MAX are currently treated as regions of size 2**64 bytes. This patch adds full support for such regions. Signed-off-by: Alexander Barabash --- exec.c |4 memory.c | 72 -- 2 files cha

Re: [Qemu-devel] [PATCH qom-cpu 01/11] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-07 Thread Gleb Natapov
On Mon, Jan 07, 2013 at 10:09:24AM -0200, Eduardo Habkost wrote: > On Mon, Jan 07, 2013 at 01:42:53PM +0200, Gleb Natapov wrote: > > On Mon, Jan 07, 2013 at 09:42:36AM -0200, Eduardo Habkost wrote: > > > On Sun, Jan 06, 2013 at 01:32:34PM +0200, Gleb Natapov wrote: > > > > On Fri, Jan 04, 2013 at 0

Re: [Qemu-devel] [PATCH qom-cpu 11/11] target-i386: check/enforce: Check all feature words

2013-01-07 Thread Gleb Natapov
On Mon, Jan 07, 2013 at 10:19:15AM -0200, Eduardo Habkost wrote: > On Mon, Jan 07, 2013 at 02:06:38PM +0200, Gleb Natapov wrote: > > On Mon, Jan 07, 2013 at 10:06:21AM -0200, Eduardo Habkost wrote: > > > On Sun, Jan 06, 2013 at 04:35:51PM +0200, Gleb Natapov wrote: > > > > On Fri, Jan 04, 2013 at 0

Re: [Qemu-devel] [PATCH qom-cpu 01/11] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-07 Thread Eduardo Habkost
On Mon, Jan 07, 2013 at 02:15:59PM +0200, Gleb Natapov wrote: > On Mon, Jan 07, 2013 at 10:09:24AM -0200, Eduardo Habkost wrote: > > On Mon, Jan 07, 2013 at 01:42:53PM +0200, Gleb Natapov wrote: > > > On Mon, Jan 07, 2013 at 09:42:36AM -0200, Eduardo Habkost wrote: > > > > On Sun, Jan 06, 2013 at 0

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-07 Thread Stefan Hajnoczi
On Sat, Jan 05, 2013 at 03:56:11PM +0800, Liu Yuan wrote: > On 01/05/2013 01:29 PM, Liu Yuan wrote: > > On 01/05/2013 12:40 PM, Liu Yuan wrote: > >> On 01/05/2013 12:38 AM, Stefan Hajnoczi wrote: > >>> Hi Yuan, > >>> BDRV_O_NOCACHE means bypass host page cache (O_DIRECT). > >>> > >>> BDRV_O_CACHE_W

[Qemu-devel] [PATCH v4] s390: Add CPU reset handler

2013-01-07 Thread Jens Freimann
Add a CPU reset handler to have all CPUs in a PoP compliant state. Signed-off-by: Jens Freimann --- v3 -> v4: * don't set psw_mask to z/Architecture in cpu_reset as it is done by the ipl device code later on * make sure patch compiles and runs with s390x-linux-user (simple test by running bus

Re: [Qemu-devel] [PATCH qom-cpu 01/11] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-07 Thread Gleb Natapov
On Mon, Jan 07, 2013 at 10:30:40AM -0200, Eduardo Habkost wrote: > On Mon, Jan 07, 2013 at 02:15:59PM +0200, Gleb Natapov wrote: > > On Mon, Jan 07, 2013 at 10:09:24AM -0200, Eduardo Habkost wrote: > > > On Mon, Jan 07, 2013 at 01:42:53PM +0200, Gleb Natapov wrote: > > > > On Mon, Jan 07, 2013 at 0

Re: [Qemu-devel] [PATCH qom-cpu 11/11] target-i386: check/enforce: Check all feature words

2013-01-07 Thread Eduardo Habkost
On Mon, Jan 07, 2013 at 02:06:38PM +0200, Gleb Natapov wrote: > On Mon, Jan 07, 2013 at 10:06:21AM -0200, Eduardo Habkost wrote: > > On Sun, Jan 06, 2013 at 04:35:51PM +0200, Gleb Natapov wrote: > > > On Fri, Jan 04, 2013 at 08:01:12PM -0200, Eduardo Habkost wrote: > > > > This adds the following f

Re: [Qemu-devel] [RFC] lively write vmstate with predictable size

2013-01-07 Thread Stefan Hajnoczi
On Sat, Jan 05, 2013 at 08:28:18PM -0700, Eric Blake wrote: > On 01/05/2013 01:21 AM, Wenchao Xia wrote: > > I guess migration to file makes vm stopped, and lack a step > > to take snapshot in the end of migration, also the usage seems > > strange makes me feel something is lacking. I'd like to >

Re: [Qemu-devel] QEMU CDROM tray-open and locked logic

2013-01-07 Thread Markus Armbruster
Peter Lieven writes: > Hi Paolo, > > Am 04.01.2013 um 19:42 schrieb Paolo Bonzini : > >> Il 04/01/2013 11:26, Peter Lieven ha scritto: >>> Hi, >>> >>> i have observed the following with qemu-kvm-1.2.0 which I think is not >>> right: >>> >>> a) if the CDROM is locked and I sent a eject command

[Qemu-devel] How to perform Win8/Fed18/Ubuntu12.4 installation on target connected to QEMU + OVMF system?

2013-01-07 Thread baban devkate
Hello Experts, Performed following trial and errors for OS installation/boot, but no luck so far 1# windows 8 installation on NVMe Namespace partition with GPT formatting done manually -it’s giving error and unable to complete the installation 2# windows 8 installation on QEMU ATA partition

Re: [Qemu-devel] [PATCH KVM v2 1/4] KVM: fix i8254 IRQ0 to be normally high

2013-01-07 Thread Gleb Natapov
On Mon, Jan 07, 2013 at 11:39:18AM +0200, Gleb Natapov wrote: > On Wed, Dec 26, 2012 at 10:39:53PM -0700, Matthew Ogilvie wrote: > > Reading the spec, it is clear that most modes normally leave the IRQ > > output line high, and only pulse it low to generate a leading edge. > > Especially the most c

Re: [Qemu-devel] [PATCH qom-cpu 01/11] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-07 Thread Eduardo Habkost
On Mon, Jan 07, 2013 at 02:33:25PM +0200, Gleb Natapov wrote: > On Mon, Jan 07, 2013 at 10:30:40AM -0200, Eduardo Habkost wrote: > > On Mon, Jan 07, 2013 at 02:15:59PM +0200, Gleb Natapov wrote: > > > On Mon, Jan 07, 2013 at 10:09:24AM -0200, Eduardo Habkost wrote: > > > > On Mon, Jan 07, 2013 at 0

Re: [Qemu-devel] [PATCH 1/2] e1000: no need auto-negotiation if link was down

2013-01-07 Thread Stefan Hajnoczi
On Sun, Jan 06, 2013 at 01:11:49PM +0800, Amos Kong wrote: > On Sat, Jan 05, 2013 at 04:45:14PM +0800, Jason Wang wrote: > > On 01/03/2013 08:20 PM, Stefan Hajnoczi wrote: > > > On Fri, Dec 28, 2012 at 05:29:10PM +0800, Amos Kong wrote: > > >> Commit b9d03e352cb6b31a66545763f6a1e20c9abf0c2c added l

Re: [Qemu-devel] [PATCH 09/20 v4] target-i386: add x86cpu_vendor_words2str()

2013-01-07 Thread Eduardo Habkost
On Fri, Jan 04, 2013 at 11:49:00PM +0100, Igor Mammedov wrote: > Make for() cycle reusable for the next patch > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost > --- > v3: >-replace e[bcd]x arguments naming with vendor[123] >-fix/swap vendor2 and vendor3 order > S

Re: [Qemu-devel] [PATCH] fix bits 39:32 of the final physical address when using 4M page

2013-01-07 Thread Andreas Färber
Am 07.01.2013 13:06, schrieb Markus Armbruster: > Wen Congyang writes: > >> ((pde & 0x1fe000) << 19) is the bits 39:32 of the final physical address, and >> we shouldn't use unit32_t to calculate it. Convert the type to hwaddr to fix >> this problem. > > Spotted by Coverity. > >> Signed-off-by:

[Qemu-devel] [PATCH 1/1] Support abstract socket namespace in AF_UNIX socket family.

2013-01-07 Thread Alexander Barabash
The abstract socket namespace is a nonportable Linux extension. The sockets' names in this namespace have no connection with file system pathnames. To specify a named AF_UNIX socket in the abstract socket namespace, start the socket's path option with a backslash followed by zero: \0. Signed-off-b

Re: [Qemu-devel] [Bug 1094950] Re: crash at qemu_iohandler_poll (iohandler.c:124) on macos 10.8.2

2013-01-07 Thread Stefan Hajnoczi
On Fri, Jan 04, 2013 at 06:09:30PM -, Christopher Mason wrote: > Using qemu master rev dbd99ae..25bbf61 configured with: > > ./configure --disable-sdl --disable-kvm --enable-cocoa --enable-debug > --extra-cflags=-g --extra-ldflags=-g > > (I'm using clang 4.1 now. Should I be using clang or

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-07 Thread Kevin Wolf
Am 05.01.2013 08:56, schrieb Liu Yuan: > On 01/05/2013 01:29 PM, Liu Yuan wrote: >> On 01/05/2013 12:40 PM, Liu Yuan wrote: >>> On 01/05/2013 12:38 AM, Stefan Hajnoczi wrote: Hi Yuan, BDRV_O_NOCACHE means bypass host page cache (O_DIRECT). BDRV_O_CACHE_WB specifies the cache sem

Re: [Qemu-devel] [PATCH qom-cpu 10/11] target-i386: Call kvm_check_features_against_host() only if CONFIG_KVM is set

2013-01-07 Thread Eduardo Habkost
On Mon, Jan 07, 2013 at 02:15:14PM +0100, Igor Mammedov wrote: > On Mon, 7 Jan 2013 10:00:09 -0200 > Eduardo Habkost wrote: > > > On Sun, Jan 06, 2013 at 04:27:19PM +0200, Gleb Natapov wrote: > > > On Fri, Jan 04, 2013 at 08:01:11PM -0200, Eduardo Habkost wrote: > > > > This will be necessary onc

Re: [Qemu-devel] [PATCH qom-cpu 10/11] target-i386: Call kvm_check_features_against_host() only if CONFIG_KVM is set

2013-01-07 Thread Gleb Natapov
On Mon, Jan 07, 2013 at 02:15:14PM +0100, Igor Mammedov wrote: > On Mon, 7 Jan 2013 10:00:09 -0200 > Eduardo Habkost wrote: > > > On Sun, Jan 06, 2013 at 04:27:19PM +0200, Gleb Natapov wrote: > > > On Fri, Jan 04, 2013 at 08:01:11PM -0200, Eduardo Habkost wrote: > > > > This will be necessary onc

[Qemu-devel] [PATCH 1/1] Support gdbstub qXfer:spaces features.

2013-01-07 Thread Alexander Barabash
Support qXfer:spaces:read and qXfer:spaces:write. These gdbstub features allow GDB to access target's hardware registers. Signed-off-by: Alexander Barabash --- Makefile.target |1 + gdbstub.c | 176 ++- xfer-spaces.c | 419 +++

Re: [Qemu-devel] [PATCH 1/1] Added address_space_init2().

2013-01-07 Thread Andreas Färber
A "memory: " prefix in the subject would've been nice for filtering. Am 07.01.2013 13:07, schrieb Alexander Barabash: > address_space_init2: initializes a named address space. What for? There are no users in this patch that justify its utility over setting the field manually. The name is really

Re: [Qemu-devel] [PATCH v2] qdev: Don't assume existence of parent bus on unparenting

2013-01-07 Thread Igor Mammedov
On Fri, 4 Jan 2013 18:34:40 +0100 Andreas Färber wrote: > Commit 667d22d1ae59da46b4c1fbd094ca61145f19b8c3 (qdev: move bus removal > to object_unparent) made the assumption that at unparenting time > parent_bus is not NULL. This assumption is unjustified since > object_unparent() may well be call

Re: [Qemu-devel] unbounded qemu NetQue's ?

2013-01-07 Thread Stefan Hajnoczi
On Sun, Jan 06, 2013 at 08:23:56PM +0100, Luigi Rizzo wrote: > Hi, > while testing the tx path in qemu without a network backend connected, > i noticed that qemu_net_queue_send() builds up an unbounded > queue, because QTAILQ* have no notion of a queue length. > > As a result, memory usage of a qe

Re: [Qemu-devel] [PATCH v2 2/2] qdev: Prepare "realized" property

2013-01-07 Thread Eduardo Habkost
On Sun, Jan 06, 2013 at 07:48:42PM +0100, Andreas Färber wrote: > Based on earlier patches by Paolo and me, introduce the QOM realizefn at > device level only, as requested by Anthony. > > For now this just wraps the qdev initfn, which it deprecates. > > Signed-off-by: Paolo Bonzini > Signed-off

Re: [Qemu-devel] [PATCH] raw-posix: Support discard on more filesystems

2013-01-07 Thread Stefan Hajnoczi
On Sat, Jan 05, 2013 at 09:05:10PM +0900, Kusanagi Kouichi wrote: > @@ -1098,15 +1101,30 @@ static int xfs_discard(BDRVRawState *s, int64_t > sector_num, int nb_sectors) > static coroutine_fn int raw_co_discard(BlockDriverState *bs, > int64_t sector_num, int nb_sectors) > { > -#ifdef CONFIG

Re: [Qemu-devel] [PATCH qom-cpu 10/11] target-i386: Call kvm_check_features_against_host() only if CONFIG_KVM is set

2013-01-07 Thread Igor Mammedov
On Mon, 7 Jan 2013 10:00:09 -0200 Eduardo Habkost wrote: > On Sun, Jan 06, 2013 at 04:27:19PM +0200, Gleb Natapov wrote: > > On Fri, Jan 04, 2013 at 08:01:11PM -0200, Eduardo Habkost wrote: > > > This will be necessary once kvm_check_features_against_host() starts > > > using KVM-specific definit

[Qemu-devel] [PATCH 07/11] chardev: add tty chardev support to chardev-add (qmp)

2013-01-07 Thread Gerd Hoffmann
Simliar to file, except that no separate in/out files are supported because it's pointless for direct device access. Also the special tty ioctl hooks (pass through linespeed settings etc) are activated. Both file names and file descriptor passing is supported. Signed-off-by: Gerd Hoffmann --- q

[Qemu-devel] [PATCH 06/11] chardev: add file chardev support to chardev-add (qmp)

2013-01-07 Thread Gerd Hoffmann
Add support for file chardevs. Output file is mandatory, input file is optional. Both file names and file descriptor passing is supported. Signed-off-by: Gerd Hoffmann --- qapi-schema.json |9 +- qemu-char.c | 77 +- 2 files ch

Re: [Qemu-devel] [PATCH v2] qdev: Don't assume existence of parent bus on unparenting

2013-01-07 Thread Andreas Färber
Am 07.01.2013 14:47, schrieb Igor Mammedov: > On Fri, 4 Jan 2013 18:34:40 +0100 > Andreas Färber wrote: > >> Commit 667d22d1ae59da46b4c1fbd094ca61145f19b8c3 (qdev: move bus removal >> to object_unparent) made the assumption that at unparenting time >> parent_bus is not NULL. This assumption is u

Re: [Qemu-devel] [PATCH V8 2/5] Adding utility function net_checksum_add_iov() for iovec checksum calculation

2013-01-07 Thread Stefan Hajnoczi
On Fri, Dec 07, 2012 at 01:15:06PM +0200, Dmitry Fleytman wrote: > Signed-off-by: Dmitry Fleytman > Signed-off-by: Yan Vugenfirer > --- > iov.h | 5 + > net/checksum.c | 28 > net/checksum.h | 8 > 3 files changed, 41 insertions(+) > > diff -

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Christian Borntraeger
Ping? On 17/12/12 17:00, Christian Borntraeger wrote: > since > > commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96 > qdev: refactor device creation to allow bus_info to be set only in class > > A user can specify a device that is no_user. > For example on my i386 box, I can add a 2nd kvmvapic de

Re: [Qemu-devel] [PATCH 1/1] Support abstract socket namespace in AF_UNIX socket family.

2013-01-07 Thread Anthony Liguori
Alexander Barabash writes: > The abstract socket namespace is a nonportable Linux extension. > The sockets' names in this namespace have no connection > with file system pathnames. To specify a named AF_UNIX socket > in the abstract socket namespace, start the socket's path option > with a backsl

[Qemu-devel] [PATCH 01/11] chardev: add error reporting for qemu_chr_new_from_opts

2013-01-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/char/char.h |3 ++- qemu-char.c | 24 +++- vl.c|9 ++--- 3 files changed, 23 insertions(+), 13 deletions(-) diff --git a/include/char/char.h b/include/char/char.h index baa5d03..1952a10 100644 ---

[Qemu-devel] [PATCH 08/11] chardev: add serial chardev support to chardev-add (qmp)

2013-01-07 Thread Gerd Hoffmann
Add support for serial chardevs. Windup qemu_chr_open_win() on Windows, alias to 'tty' on Linux. Signed-off-by: Gerd Hoffmann --- qapi-schema.json |3 ++- qemu-char.c | 17 +++-- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/qapi-schema.json b/qapi-schem

[Qemu-devel] [PATCH 1/2] rtc-test: skip year-2038 overflow check in case time_t is 32bit only

2013-01-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/rtc-test.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/tests/rtc-test.c b/tests/rtc-test.c index 02edbf5..e7123ca 100644 --- a/tests/rtc-test.c +++ b/tests/rtc-test.c @@ -201,6 +201,10 @@ static void set_year_20xx(void) g

[Qemu-devel] [PATCH 2/2] m48t59-test: don't touch watchdog

2013-01-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/m48t59-test.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/tests/m48t59-test.c b/tests/m48t59-test.c index 5179681..d79f554 100644 --- a/tests/m48t59-test.c +++ b/tests/m48t59-test.c @@ -233,6 +233,11 @@ static void fuzz_regis

[Qemu-devel] [PATCH 0/2] fix tests

2013-01-07 Thread Gerd Hoffmann
Hi, Two little test case fixes so "make check" passes. cheers, Gerd Gerd Hoffmann (2): rtc-test: skip year-2038 overflow check in case time_t is 32bit only m48t59-test: don't touch watchdog tests/m48t59-test.c |5 + tests/rtc-test.c|4 2 files changed, 9 insertions

Re: [Qemu-devel] [PATCH qom-cpu 10/11] target-i386: Call kvm_check_features_against_host() only if CONFIG_KVM is set

2013-01-07 Thread Igor Mammedov
On Mon, 7 Jan 2013 15:30:26 +0200 Gleb Natapov wrote: > On Mon, Jan 07, 2013 at 02:15:14PM +0100, Igor Mammedov wrote: > > On Mon, 7 Jan 2013 10:00:09 -0200 > > Eduardo Habkost wrote: > > > > > On Sun, Jan 06, 2013 at 04:27:19PM +0200, Gleb Natapov wrote: > > > > On Fri, Jan 04, 2013 at 08:01:1

Re: [Qemu-devel] [PATCH V8 0/5] VMXNET3 paravirtual NIC device implementation

2013-01-07 Thread Stefan Hajnoczi
On Fri, Dec 07, 2012 at 01:15:04PM +0200, Dmitry Fleytman wrote: > > +struct eth_header { > > +uint8_t h_dest[ETH_ALEN]; /* destination eth addr */ > > +uint8_t h_source[ETH_ALEN]; /* source ether addr*/ > > +uint16_t h_proto;/* packet type ID field */ > > +}; > > L

Re: [Qemu-devel] [PATCH] fix bits 39:32 of the final physical address when using 4M page

2013-01-07 Thread Luiz Capitulino
On Mon, 07 Jan 2013 14:10:46 +0100 Andreas Färber wrote: > Am 07.01.2013 13:06, schrieb Markus Armbruster: > > Wen Congyang writes: > > > >> ((pde & 0x1fe000) << 19) is the bits 39:32 of the final physical address, > >> and > >> we shouldn't use unit32_t to calculate it. Convert the type to hw

Re: [Qemu-devel] [PATCH V8 3/5] Adding common definitions for VMWARE devices

2013-01-07 Thread Stefan Hajnoczi
On Fri, Dec 07, 2012 at 01:15:07PM +0200, Dmitry Fleytman wrote: > diff --git a/hw/vmxnet_debug.h b/hw/vmxnet_debug.h > new file mode 100644 > index 000..faa1431 > --- /dev/null > +++ b/hw/vmxnet_debug.h > @@ -0,0 +1,121 @@ > +/* > + * QEMU VMWARE VMXNET* paravirtual NICs - debugging facilities

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Andreas Färber
Am 17.12.2012 17:00, schrieb Christian Borntraeger: > since > > commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96 > qdev: refactor device creation to allow bus_info to be set only in class > > A user can specify a device that is no_user. > For example on my i386 box, I can add a 2nd kvmvapic device

Re: [Qemu-devel] unbounded qemu NetQue's ?

2013-01-07 Thread Luigi Rizzo
On Mon, Jan 7, 2013 at 2:49 PM, Stefan Hajnoczi wrote: > On Sun, Jan 06, 2013 at 08:23:56PM +0100, Luigi Rizzo wrote: > > Hi, > > while testing the tx path in qemu without a network backend connected, > > i noticed that qemu_net_queue_send() builds up an unbounded > > queue, because QTAILQ* have

[Qemu-devel] [PATCH 03/11] chardev: reduce chardev ifdef mess a bit

2013-01-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- qemu-char.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index a29c2bb..c511de3 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -856,6 +856,8 @@ static void cfmakeraw (struct termios *termi

Re: [Qemu-devel] [SeaBIOS] SeaBIOS release for QEMU 1.3 (was Re: [PATCH] esp: enable busmaster)

2013-01-07 Thread Gerd Hoffmann
Hi, >> Kevin, are you okay with tagging SeaBIOS master as 1.7.2 one of these >> days? Other opinions? > > A new release can be produced if desired. Given that there isn't much > new since 1.7.1 I too would prefer to just push forward to 1.7.2. Ping? Meanwhile 1.4 freeze is in sight (soft fr

[Qemu-devel] [PATCH 04/11] chardev: add qmp hotplug commands, with null chardev support

2013-01-07 Thread Gerd Hoffmann
Add chardev-add and chardev-remove qmp commands. Hotplugging a null chardev is supported for now, more will be added later. Signed-off-by: Gerd Hoffmann --- qapi-schema.json | 32 qemu-char.c | 39 +++ qmp-commands.hx

Re: [Qemu-devel] [PATCH V8 4/5] Adding packet abstraction for VMWARE network devices

2013-01-07 Thread Stefan Hajnoczi
On Fri, Dec 07, 2012 at 01:15:08PM +0200, Dmitry Fleytman wrote: > +void vmxnet_tx_pkt_uninit(struct VmxnetTxPkt *pkt) > +{ > +if (pkt) { > +if (pkt->vec) { > +g_free(pkt->vec); > +} > + > +if (pkt->raw) { > +g_free(pkt->raw); > +} g_free

Re: [Qemu-devel] [PATCH 1/2] rtc-test: skip year-2038 overflow check in case time_t is 32bit only

2013-01-07 Thread Andreas Färber
Am 07.01.2013 15:11, schrieb Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann Reviewed-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH V8 5/5] Adding VMXNET3 device implementation

2013-01-07 Thread Stefan Hajnoczi
On Fri, Dec 07, 2012 at 01:15:09PM +0200, Dmitry Fleytman wrote: > +static void vmxnet3_get_ring_from_file(QEMUFile *f, Vmxnet3Ring *r) > +{ > +#if HWADDR_BITS == 64 > +r->pa = qemu_get_be64(f); > +#else > +r->pa = qemu_get_be32(f); > +#endif hw/virtio.c always uses be64 for its hwaddr pa

[Qemu-devel] [PATCH 09/11] chardev: add parport chardev support to chardev-add (qmp)

2013-01-07 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- qapi-schema.json |3 ++- qemu-char.c | 43 +++ 2 files changed, 29 insertions(+), 17 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index d833385..0922823 100644 --- a/qapi-schema.json +++ b/qapi-s

[Qemu-devel] [PATCH] add chardev_hotplug test

2013-01-07 Thread Gerd Hoffmann
--- kvm/tests/chardev_hotplug.py | 124 shared/cfg/subtests.cfg.sample |7 ++ 2 files changed, 131 insertions(+), 0 deletions(-) create mode 100644 kvm/tests/chardev_hotplug.py diff --git a/kvm/tests/chardev_hotplug.py b/kvm/tests/chardev_hotplug.p

[Qemu-devel] [PATCH 11/11] chardev: add pty chardev support to chardev-add (qmp)

2013-01-07 Thread Gerd Hoffmann
The ptsname is returned directly, so there is no need to use query-chardev to figure the pty device path. Signed-off-by: Gerd Hoffmann --- qapi-schema.json |7 ++- qemu-char.c | 24 +--- 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/qapi-schem

[Qemu-devel] [PATCH 02/11] chardev: fix QemuOpts lifecycle

2013-01-07 Thread Gerd Hoffmann
qemu_chr_new_from_opts handles QemuOpts release now, so callers don't have to worry. It will either be saved in CharDriverState, then released in qemu_chr_delete, or in the error case released instantly. Signed-off-by: Gerd Hoffmann --- include/char/char.h |1 + qemu-char.c | 20 +

Re: [Qemu-devel] [PATCH] pci-assign: Enable MSIX on device to match guest

2013-01-07 Thread Michael S. Tsirkin
On Sun, Jan 06, 2013 at 08:57:50AM -0700, Alex Williamson wrote: > On Sun, 2013-01-06 at 15:23 +0200, Michael S. Tsirkin wrote: > > On Wed, Jan 02, 2013 at 08:49:42AM -0700, Alex Williamson wrote: > > > On Fri, 2012-12-21 at 08:46 -0700, Alex Williamson wrote: > > > > On Fri, 2012-12-21 at 14:17 +0

[Qemu-devel] [PATCH 00/11] chardev hotplug patch series

2013-01-07 Thread Gerd Hoffmann
Hi, Next round of the chardev hotplug patch series, with better commit messages, and tested this time. cheers, Gerd Gerd Hoffmann (11): chardev: add error reporting for qemu_chr_new_from_opts chardev: fix QemuOpts lifecycle chardev: reduce chardev ifdef mess a bit chardev: add qmp ho

[Qemu-devel] [PATCH 10/11] chardev: add socket chardev support to chardev-add (qmp)

2013-01-07 Thread Gerd Hoffmann
qemu_chr_open_socket is splitted into two functions. All initialization after creating the socket file handler is splitted away into the new qemu_chr_open_socket_fd function. chr->filename doesn't get filled from QemuOpts any more. Qemu gathers the information using getsockname and getnameinfo i

Re: [Qemu-devel] [PATCH V8 0/5] VMXNET3 paravirtual NIC device implementation

2013-01-07 Thread Stefan Hajnoczi
On Wed, Dec 26, 2012 at 11:26:09AM +0200, Dmitry Fleytman wrote: > Is there any progress with these patches? > Is there a chance they will be committed any time soon? Hi Dmitry, Thanks for posting this version. I have left comments but overall it seems self-contained and ready to merge soon. One

[Qemu-devel] [PATCH 05/11] chardev: add hmp hotplug commands

2013-01-07 Thread Gerd Hoffmann
Add chardev-add and chardev-remove commands to the human monitor. chardev-add accepts the same syntax as -chardev, chardev-remove expects a chardev id. Signed-off-by: Gerd Hoffmann --- hmp-commands.hx | 32 hmp.c | 23 +++ hmp.h

Re: [Qemu-devel] [PATCH] pci-assign: Enable MSIX on device to match guest

2013-01-07 Thread Alex Williamson
On Mon, 2013-01-07 at 17:02 +0200, Michael S. Tsirkin wrote: > On Sun, Jan 06, 2013 at 08:57:50AM -0700, Alex Williamson wrote: > > On Sun, 2013-01-06 at 15:23 +0200, Michael S. Tsirkin wrote: > > > On Wed, Jan 02, 2013 at 08:49:42AM -0700, Alex Williamson wrote: > > > > On Fri, 2012-12-21 at 08:46

Re: [Qemu-devel] [PATCH v4] s390: Add CPU reset handler

2013-01-07 Thread Alexander Graf
On 07.01.2013, at 13:31, Jens Freimann wrote: > Add a CPU reset handler to have all CPUs in a PoP compliant > state. > > Signed-off-by: Jens Freimann > --- > v3 -> v4: > * don't set psw_mask to z/Architecture in cpu_reset as it > is done by the ipl device code later on > * make sure patch comp

[Qemu-devel] [PATCH qom-cpu] qemu-common.h: Make qemu_init_vcpu() stub static inline

2013-01-07 Thread Andreas Färber
Turn the *-user macro into a no-op inline function to avoid unused-variable warnings and band-aiding #ifdef'ery. This allows to drop an #ifdef for alpha and avoids more for unicore32 and other upcoming trivial realizefn implementations. Suggested-by: Lluís Vilanova Signed-off-by: Eduardo Habkost

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Modification to remove a h2g() call and calculate properly instead

2013-01-07 Thread Alexander Graf
On 05.01.2013, at 01:35, Samuel Seay wrote: > Peter Maydell recommended the change to be more proper. The result was tested > and shows coming up with the same proper value. > > Signed-off-by: Samuel Seay Thanks, applied to ppc-next with a modified subject line. Please take a few minutes and

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Luiz Capitulino
On Mon, 07 Jan 2013 15:20:17 +0100 Andreas Färber wrote: > Am 17.12.2012 17:00, schrieb Christian Borntraeger: > > since > > > > commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96 > > qdev: refactor device creation to allow bus_info to be set only in class > > > > A user can specify a device that

[Qemu-devel] [PATCH v4] s390: Add CPU reset handler

2013-01-07 Thread Jens Freimann
Add a CPU reset handler to have all CPUs in a PoP compliant state. Signed-off-by: Jens Freimann --- v3 -> v4: * don't set psw_mask to z/Architecture in cpu_reset as it is done by the ipl device code later on * make sure patch compiles and runs with s390x-linux-user (simple test by running bus

Re: [Qemu-devel] [PATCH ppc-next v2 0/2] PowerPCCPU subclasses

2013-01-07 Thread Alexander Graf
On 06.01.2013, at 19:31, Andreas Färber wrote: > Hi Alex, > > The CPUListState generalization has been merged now. Here's a rebased version > of PowerPCCPU subclasses, intended for v1.4. Thanks, applied to ppc-next. Alex

Re: [Qemu-devel] [PATCH v4] s390: Add CPU reset handler

2013-01-07 Thread Alexander Graf
On 07.01.2013, at 16:27, Jens Freimann wrote: > Add a CPU reset handler to have all CPUs in a PoP compliant > state. > > Signed-off-by: Jens Freimann Thanks, applied to s390-next. Alex > --- > v3 -> v4: > * don't set psw_mask to z/Architecture in cpu_reset as it > is done by the ipl device

[Qemu-devel] [PULL 0/5] s390 patch queue 2013-01-07

2013-01-07 Thread Alexander Graf
Hi Blue / Aurelien, This is my current patch queue for s390. Please pull. Alex The following changes since commit 8e4a424b305e29dc0e454f52df3b35577f342975: Blue Swirl (1): Revert "virtio-pci: replace byte swap hack" are available in the git repository at: git://repo.or.cz/qemu/ag

[Qemu-devel] [PATCH 4/5] s390x: Remove inline function ebcdic_put and related data from cpu.h

2013-01-07 Thread Alexander Graf
From: Stefan Weil The function is only used in misc_helper.c, so move it to that file. This reduces the size of debug executables (compiled without optimization) because they get unused code and data for each compilation which includes cpu.h. Executables with optimization don't change their siz

[Qemu-devel] [PATCH 04/31] openpic: BRR1 is not a CPU-specific register.

2013-01-07 Thread Alexander Graf
From: Scott Wood It's in the address range that normally contains a magic redirection to the CPU-specific region of the curretn CPU, but it isn't actually a per-CPU register. On real hardware BRR1 shows up only at 0x4, not at 0x6 or other non-magic per-CPU areas. Plus, this makes it pos

[Qemu-devel] [PATCH 14/31] openpic: make register names correspond better with hw docs

2013-01-07 Thread Alexander Graf
From: Scott Wood The base openpic specification doesn't provide abbreviated register names, so it's somewhat understandable that the QEMU code made up its own, except that most of the names that QEMU used didn't correspond to the terminology used by any implementation I could find. In some cases

[Qemu-devel] [PATCH 16/31] openpic: make ctpr signed

2013-01-07 Thread Alexander Graf
From: Scott Wood Other priorities are signed, so avoid comparisons between signed and unsigned. Signed-off-by: Scott Wood Signed-off-by: Alexander Graf --- hw/openpic.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/openpic.c b/hw/openpic.c index fe6cf67..824

[Qemu-devel] [PATCH 11/31] openpic: fix debug prints

2013-01-07 Thread Alexander Graf
From: Scott Wood Fix various format errors when debug prints are enabled. Also cause error checking to happen even when debug prints are not enabled, and consistently use 0x for hex output. Signed-off-by: Scott Wood [agraf: adjust for more recent code base, prettify DPRINTF macro] Signed-off-b

[Qemu-devel] [PATCH 30/31] target-ppc: Error out for -cpu host on unknown PVR

2013-01-07 Thread Alexander Graf
From: Andreas Färber Previously we silently exited, with subclasses we got an opcode warning. Instead, explicitly tell the user what's wrong. An indication for this is -cpu ? showing "host" with an all-zero PVR. Signed-off-by: Andreas Färber Signed-off-by: Alexander Graf --- target-ppc/kvm.c

[Qemu-devel] [PATCH 26/31] kvm: Update kernel headers

2013-01-07 Thread Alexander Graf
Corresponding kvm.git hash: 18eb54cf4a Signed-off-by: Alexander Graf --- linux-headers/asm-powerpc/epapr_hcalls.h | 98 ++ linux-headers/asm-powerpc/kvm.h | 86 ++ linux-headers/asm-powerpc/kvm_para.h | 13 ++-- linux-headers

Re: [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue

2013-01-07 Thread Jason J. Herne
On 01/04/2013 11:27 AM, Alexander Graf wrote: On 04.01.2013, at 16:25, Jason J. Herne wrote: If I've followed the conversation correctly this is what needs to be done: 1. Remove the level parameters from kvm_arch_get_registers and kvm_arch_put_registers. 2. Add a new bitmap parameter to kvm

Re: [Qemu-devel] [PATCH v4] s390: Add CPU reset handler

2013-01-07 Thread Alexander Graf
On 07.01.2013, at 16:27, Jens Freimann wrote: > Add a CPU reset handler to have all CPUs in a PoP compliant > state. > > Signed-off-by: Jens Freimann > --- > v3 -> v4: > * don't set psw_mask to z/Architecture in cpu_reset as it > is done by the ipl device code later on > * make sure patch comp

  1   2   3   4   >