Re: [Qemu-devel] [RFC] lively write vmstate with predictable size

2013-01-05 Thread Wenchao Xia
于 2013-1-5 6:42, Juan Quintela 写道: > Stefan Hajnoczi wrote: >> On Fri, Dec 21, 2012 at 10:25:51AM +0800, Wenchao Xia wrote: >>> resent the mail to mail-list. >>> --- >>> >>> Hi, Paolo and Juan >>> Currently savevm needs pause vm, and I am working on that make it >>> lively.

Re: [Qemu-devel] [PATCH 1/6] snapshot: export function in block.c

2013-01-05 Thread Wenchao Xia
Thanks for reviewing carefully, this patch would be split to two patches. On Mon, Dec 17, 2012 at 02:25:04PM +0800, Wenchao Xia wrote: This patch moves bdrv_snapshotfind from savevm.c to block.c and export it, also added bdrv_deappend in block.c. I suggest naming the patch "block: export

Re: [Qemu-devel] [PATCH 2/6] snapshot: add error set function

2013-01-05 Thread Wenchao Xia
于 2013-1-4 22:55, Stefan Hajnoczi 写道: On Mon, Dec 17, 2012 at 02:25:05PM +0800, Wenchao Xia wrote: This patch has nothing to do with snapshots, so "snapshot: add error set function" is not a useful commit message. "error: add error_set_replace()" would be okay. Please use git log on the file

[Qemu-devel] [PATCH v2] hw/i386: Fix broken build for non POSIX hosts

2013-01-05 Thread Stefan Weil
pc-testdev.c cannot be compiled with MinGW (and other non POSIX hosts): CCi386-softmmu/hw/i386/../pc-testdev.o qemu/hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: file not found qemu/hw/i386/../pc-testdev.c: In function ‘test_flush_page’: qemu/hw/i386/../pc-testdev.c:103: warning: impli

Re: [Qemu-devel] [PATCH 6/6] snapshot: human monitor interface

2013-01-05 Thread Wenchao Xia
> On Mon, Dec 17, 2012 at 02:25:09PM +0800, Wenchao Xia wrote: @@ -983,17 +983,22 @@ ETEXI { .name = "snapshot_blkdev", -.args_type = "reuse:-n,device:B,snapshot-file:s?,format:s?", -.params = "[-n] device [new-image-file] [format]", -.help

Re: [Qemu-devel] [PATCH 5/6] snapshot: qmp interface

2013-01-05 Thread Wenchao Xia
于 2013-1-5 0:22, Stefan Hajnoczi 写道: On Mon, Dec 17, 2012 at 02:25:08PM +0800, Wenchao Xia wrote: @@ -1478,16 +1497,39 @@ # # @device: the name of the device to generate the snapshot from. # -# @snapshot-file: the target of the new image. A new file will be created. +# @snapshot-file: the

Re: [Qemu-devel] [PATCH 1/2] e1000: no need auto-negotiation if link was down

2013-01-05 Thread Jason Wang
On 01/03/2013 08:20 PM, Stefan Hajnoczi wrote: > On Fri, Dec 28, 2012 at 05:29:10PM +0800, Amos Kong wrote: >> Commit b9d03e352cb6b31a66545763f6a1e20c9abf0c2c added link >> auto-negotiation emulation, it would always set link up by >> callback function. Problem exists if original link status >> was

[Qemu-devel] [PATCH] configure: Fix comment (copy+paste bug)

2013-01-05 Thread Stefan Weil
Signed-off-by: Stefan Weil --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 837a84a..4bd9e92 100755 --- a/configure +++ b/configure @@ -2697,7 +2697,7 @@ if compile_prog "" "" ; then byteswap_h=yes fi -# Search for bswap_32 fun

[Qemu-devel] [PATCH] raw-posix: Support discard on more filesystems

2013-01-05 Thread Kusanagi Kouichi
Linux 2.6.38 introduced the filesystem independent interface to deallocate part of a file. As of Linux 3.7, btrfs, ext4, ocfs2, tmpfs and xfs support it. Signed-off-by: Kusanagi Kouichi --- block/raw-posix.c | 22 -- configure | 19 +++ 2 files cha

Re: [Qemu-devel] [PATCH v4 0/2] soft-float-fixes for target-s390x

2013-01-05 Thread Blue Swirl
Thanks, applied all. On Mon, Dec 31, 2012 at 6:09 PM, Richard Henderson wrote: > Changes v3-v4: > Rebase after source tree rearrangements. > > Changes v2-v3: > Ignore softfloat "style" completely. Code now formatted per QEMU. > > Changes v1-v2: > Incorporating feedback from Peter Maydell (

Re: [Qemu-devel] [PATCH v2] hw/i386: Fix broken build for non POSIX hosts

2013-01-05 Thread Blue Swirl
Thanks, applied. On Sat, Jan 5, 2013 at 8:33 AM, Stefan Weil wrote: > pc-testdev.c cannot be compiled with MinGW (and other non POSIX hosts): > > CCi386-softmmu/hw/i386/../pc-testdev.o > qemu/hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: file not found > qemu/hw/i386/../pc-testdev.c:

[Qemu-devel] [PATCH v2] linux-user/syscall.c: fix copy_to_user_fdset for fds over 30

2013-01-05 Thread Nickolai Zeldovich
On a 64-bit system (e.g., x86_64), copy_to_user_fdset populates the bitmask returned to the user-space program by left-shifting the value (FD_ISSET(k, fds) != 0), which is of type int, by k bits (0 through 63). According to the C standard, left-shifting an int by 31 bits is undefined behavior beca

Re: [Qemu-devel] [Virt-test-devel] [Autotest PATCH 2/2] virt run: add three logical case filters

2013-01-05 Thread Lucas Meneghel Rodrigues
On Sat, Jan 5, 2013 at 6:52 AM, Qingtang Zhou wrote: > * On 2012-12-31 17:55:24 -0200, Lucas Meneghel Rodrigues (look...@gmail.com) > wrote: >> Hmmm, about this one, I'm worried about making things more complex... >> >> The way I see the problem at hand, I'd say if people want to customize >> thi

Re: [Qemu-devel] [Virt-test-devel] [Autotest PATCH 2/2] virt run: add three logical case filters

2013-01-05 Thread Qingtang Zhou
* On 2012-12-31 17:55:24 -0200, Lucas Meneghel Rodrigues (look...@gmail.com) wrote: > Hmmm, about this one, I'm worried about making things more complex... > > The way I see the problem at hand, I'd say if people want to customize > things, they'd be better of creating their own, specialized conf

Re: [Qemu-devel] QEMU build fails with Clang?

2013-01-05 Thread Blue Swirl
On Sat, Jan 5, 2013 at 1:48 AM, Brad Smith wrote: > Supposedly QEMU is able to build with Clang and yet trying to do so > I am seeing the build fail as follows.. > > Comments? Clang does not support this kind of assembly code yet. The attached patch avoids this by using 'as' and 'cpp' for .S file

Re: [Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-05 Thread Tim Hardeck
Hi, thanks for your suggestions. On Fri, 2013-01-04 at 20:20 +, Blue Swirl wrote: > On Wed, Jan 2, 2013 at 1:29 PM, Tim Hardeck wrote: > > + * We are working around a bug present in GCC < 4.6 which prevented > > + * it from recognizing anonymous structs and unions. > > + * See

[Qemu-devel] [PATCH] slirp: remove unused field tt

2013-01-05 Thread Blue Swirl
Signed-off-by: Blue Swirl --- slirp/slirp.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/slirp/slirp.h b/slirp/slirp.h index dfc3e3a..fe0e65d 100644 --- a/slirp/slirp.h +++ b/slirp/slirp.h @@ -215,7 +215,6 @@ struct Slirp { char client_hostname[33]; int res

[Qemu-devel] [PATCH] savevm: use qemu_gettimeofday

2013-01-05 Thread Blue Swirl
Use qemu_gettimeofday() instead of _ftime() on Win32. This fixes build for mingw32: CCsparc-softmmu/savevm.o /src/qemu/savevm.c: In function 'do_savevm': /src/qemu/savevm.c:2097: error: storage size of 'tb' isn't known /src/qemu/savevm.c:2133: warning: implicit declaration of function '_ftim

[Qemu-devel] [Bug 1091241] Re: NetBSD/i386 6.0 guest suffers interrupt storm since qemu BIOS update

2013-01-05 Thread Andreas Gustafsson
The bug has been fixed; revisoion 5928023cef87847a295035487397b9ec701fdd6b is still broken, but dbd99ae302be8f51b547fb6283c91d0c9859b7d5 works. I haven't determined which of the commits inbetween fixed it, but the BIOS update of 15faf946f7a17a5fab0d05a2312d43249d81af3 seems like a likely candidate

Re: [Qemu-devel] QEMU build fails with Clang?

2013-01-05 Thread Ashley
On 1/5/2013 8:51 AM, Blue Swirl wrote: On Sat, Jan 5, 2013 at 1:48 AM, Brad Smith wrote: Supposedly QEMU is able to build with Clang and yet trying to do so I am seeing the build fail as follows.. Comments? Clang does not support this kind of assembly code yet. The attached patch avoids this

Re: [Qemu-devel] QEMU build fails with Clang?

2013-01-05 Thread Brad Smith
On Sat, Jan 05, 2013 at 07:19:11PM -0800, Ashley wrote: > On 1/5/2013 8:51 AM, Blue Swirl wrote: > >On Sat, Jan 5, 2013 at 1:48 AM, Brad Smith wrote: > >>Supposedly QEMU is able to build with Clang and yet trying to do so > >>I am seeing the build fail as follows.. > >> > >>Comments? > > > >Clang

Re: [Qemu-devel] [RFC] lively write vmstate with predictable size

2013-01-05 Thread Eric Blake
On 01/05/2013 01:21 AM, Wenchao Xia wrote: > I guess migration to file makes vm stopped, and lack a step > to take snapshot in the end of migration, also the usage seems > strange makes me feel something is lacking. I'd like to > have: > 1 take blk snapshot internal/external lively. > 2 take vmst

Re: [Qemu-devel] [PATCH 1/2] e1000: no need auto-negotiation if link was down

2013-01-05 Thread Amos Kong
On Sat, Jan 05, 2013 at 04:45:14PM +0800, Jason Wang wrote: > On 01/03/2013 08:20 PM, Stefan Hajnoczi wrote: > > On Fri, Dec 28, 2012 at 05:29:10PM +0800, Amos Kong wrote: > >> Commit b9d03e352cb6b31a66545763f6a1e20c9abf0c2c added link > >> auto-negotiation emulation, it would always set link up by