Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque

2013-01-03 Thread Gerd Hoffmann
On 01/02/13 16:56, Stefan Hajnoczi wrote: > On Wed, Dec 19, 2012 at 02:07:16PM +0100, Stefan Hajnoczi wrote: >> The spice_server pointer is a global variable and >> vm_change_state_handler() therefore does not use its opaque parameter. >> >> The vm change state handler is added with a pointer to th

Re: [Qemu-devel] [PULL 0/1] update seabios

2013-01-03 Thread Gerd Hoffmann
On 01/02/13 18:09, Luigi Rizzo wrote: > are you going to distribute a 1.3.x snapshot with the updated bios that > lets FreeBSD boot ? Patch is Cc'ed to qemu-stable because of the freebsd boot breakage, so yes, this should get picked up for the 1.3.1 release. cheers, Gerd

Re: [Qemu-devel] pthread_create failed: Resource temporarily unavailable

2013-01-03 Thread Stefan Hajnoczi
On Wed, Jan 2, 2013 at 8:17 PM, Christoffer Dall wrote: > I am seeing some brutal crashes with QEMU running virtio using KVM/ARM. > > The culprit seems to be when the process runs out of virtual address > space on 32-bit systems due to some subsystem (virtio?) creating a > large number of pthreads

Re: [Qemu-devel] [PATCH] hw/mcf5206: Reduce size of lookup table

2013-01-03 Thread Stefan Hajnoczi
On Sat, Dec 22, 2012 at 01:59:22PM +0100, Stefan Weil wrote: > This typically reduces the size from 512 bytes to 128 bytes. > > Signed-off-by: Stefan Weil > --- > hw/mcf5206.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to the trivial patches tree: https://github.

Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user/syscall.c: remove forward declarations

2013-01-03 Thread Stefan Hajnoczi
On Wed, Dec 26, 2012 at 12:49:49AM +0100, John Spencer wrote: > instead use the correct headers that define these functions. > > Requested-by: Stefan Weil > Signed-off-by: John Spencer > --- > linux-user/syscall.c |8 +++- > 1 files changed, 3 insertions(+), 5 deletions(-) Thanks, appl

Re: [Qemu-devel] [PATCH] pseries: Remove unneeded include statement (fixes MinGW builds)

2013-01-03 Thread Stefan Hajnoczi
On Thu, Dec 20, 2012 at 07:50:41AM +0100, Stefan Weil wrote: > sys/mman.h is not needed (tested on Linux) and unavailable for MinGW, > so remove it. > > Signed-off-by: Stefan Weil > --- > hw/spapr_nvram.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I audited the code and cannot s

[Qemu-devel] dataplane build error

2013-01-03 Thread Gerd Hoffmann
CChw/dataplane/vring.o cc1: warnings being treated as errors /home/kraxel/projects/qemu/hw/dataplane/vring.c: In function ‘vring_setup’: /home/kraxel/projects/qemu/hw/dataplane/vring.c:46: error: implicit declaration of function ‘trace_vring_setup’ /home/kraxel/projects/qemu/hw/dataplane/vrin

[Qemu-devel] [PATCH] linux-user/syscall.c: fix select on x86_64

2013-01-03 Thread Nickolai Zeldovich
Use the correct argument passing convention for select on x86_64. Previously, select worked for i386 but was broken for x86_64 (always returning EINVAL). With this change, select works on both i386 and x86_64. (Other targets untested but should be unaffected.) Signed-off-by: Nickolai Zeldovich

Re: [Qemu-devel] dataplane build error

2013-01-03 Thread Stefan Weil
Am 03.01.2013 10:30, schrieb Gerd Hoffmann: CChw/dataplane/vring.o cc1: warnings being treated as errors /home/kraxel/projects/qemu/hw/dataplane/vring.c: In function ‘vring_setup’: /home/kraxel/projects/qemu/hw/dataplane/vring.c:46: error: implicit declaration of function ‘trace_vring_setu

Re: [Qemu-devel] dataplane build error

2013-01-03 Thread Stefan Hajnoczi
On Thu, Jan 03, 2013 at 10:32:43AM +0100, Stefan Weil wrote: > Am 03.01.2013 10:30, schrieb Gerd Hoffmann: > > CChw/dataplane/vring.o > >cc1: warnings being treated as errors > >/home/kraxel/projects/qemu/hw/dataplane/vring.c: In function ‘vring_setup’: > >/home/kraxel/projects/qemu/hw/datapl

Re: [Qemu-devel] [RFC PATCH V8 02/15] virtio-bus : Introduce virtio-bus

2013-01-03 Thread KONRAD Frédéric
On 02/01/2013 15:12, Anthony Liguori wrote: fred.kon...@greensocs.com writes: From: KONRAD Frederic Introduce virtio-bus. Refactored transport device will create a bus which extends virtio-bus. Signed-off-by: KONRAD Frederic --- hw/Makefile.objs | 1 + hw/virtio-bus.c | 169 ++

[Qemu-devel] [PATCH] linux-user/syscall.c: fix copy_to_user_fdset for fds over 30

2013-01-03 Thread Nickolai Zeldovich
On a 64-bit system (e.g., x86_64), copy_to_user_fdset populates the bitmask returned to the user-space program by left-shifting the value (FD_ISSET(k, fds) != 0), which is of type int, by k bits (0 through 63). According to the C standard, left-shifting an int by 31 bits is undefined behavior beca

Re: [Qemu-devel] [PATCH] pseries: Remove unneeded include statement (fixes MinGW builds)

2013-01-03 Thread David Gibson
On Thu, Jan 03, 2013 at 09:59:46AM +0100, Stefan Hajnoczi wrote: > On Thu, Dec 20, 2012 at 07:50:41AM +0100, Stefan Weil wrote: > > sys/mman.h is not needed (tested on Linux) and unavailable for MinGW, > > so remove it. > > > > Signed-off-by: Stefan Weil > > --- > > hw/spapr_nvram.c |2 +- >

[Qemu-devel] [PATCH] dataplane: use linux-headers/ for virtio includes

2013-01-03 Thread Stefan Hajnoczi
The hw/dataplane/vring.c code includes linux/virtio_ring.h. Ensure that we use linux-headers/ instead of the system-wide headers, which may be out-of-date on older distros. This resolves the following build error on Debian 6: CChw/dataplane/vring.o cc1: warnings being treated as errors hw/

Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque

2013-01-03 Thread Stefan Hajnoczi
On Thu, Jan 3, 2013 at 9:20 AM, Gerd Hoffmann wrote: > On 01/02/13 16:56, Stefan Hajnoczi wrote: >> On Wed, Dec 19, 2012 at 02:07:16PM +0100, Stefan Hajnoczi wrote: >>> The spice_server pointer is a global variable and >>> vm_change_state_handler() therefore does not use its opaque parameter. >>>

Re: [Qemu-devel] buildbot failure in qemu on disable_kvm_x86_64_out_of_tree

2013-01-03 Thread Stefan Hajnoczi
On Thu, Jan 3, 2013 at 1:23 AM, Anthony Liguori wrote: > > These are all virtio-blk-dataplane Stefan... The problem seems to be > !CONFIG_KVM related. Thanks for pointing this out. The code is using Linux virtio headers without -I linux-headers/. I sent a fix. Stefan

Re: [Qemu-devel] pthread_create failed: Resource temporarily unavailable

2013-01-03 Thread Andreas Färber
Hi, Am 02.01.2013 20:17, schrieb Christoffer Dall: > I am seeing some brutal crashes with QEMU running virtio using KVM/ARM. > > The culprit seems to be when the process runs out of virtual address > space on 32-bit systems due to some subsystem (virtio?) creating a > large number of pthreads und

Re: [Qemu-devel] [PATCH 1/8] virtio: don't waste irqfds on control vqs

2013-01-03 Thread Stefan Hajnoczi
On Wed, Dec 26, 2012 at 12:52:19PM +0200, Michael S. Tsirkin wrote: > Pass nvqs to set_guest_notifiers. This makes it possible to > save on irqfds by not allocating one for the control vq > for virtio-net. > > Signed-off-by: Michael S. Tsirkin > --- > hw/vhost.c | 10 +++--- > hw/virtio

Re: [Qemu-devel] [PATCH 1/2] e1000: no need auto-negotiation if link was down

2013-01-03 Thread Stefan Hajnoczi
On Fri, Dec 28, 2012 at 05:29:10PM +0800, Amos Kong wrote: > Commit b9d03e352cb6b31a66545763f6a1e20c9abf0c2c added link > auto-negotiation emulation, it would always set link up by > callback function. Problem exists if original link status > was down, link status should not be changed in auto-nego

Re: [Qemu-devel] [PATCH 0/2] fix of preserving link status

2013-01-03 Thread Stefan Hajnoczi
On Fri, Dec 28, 2012 at 05:29:09PM +0800, Amos Kong wrote: > Set link down and reboot guest, e1000 link status will be re-set > to up by auto-negotiation, it's a regression bug. rtl8139 link > status would be reset to up always. > > Problems are fixed by those two patches. > > RHBZ: https://bugzi

Re: [Qemu-devel] [PATCH qom-cpu 4/4] target-ppc: Error out for -cpu host on unknown PVR

2013-01-03 Thread Alexander Graf
On 18.12.2012, at 08:53, Andreas Färber wrote: > Previously we silently exited, with subclasses we got an opcode warning. > Instead explicitly tell the user what's wrong. > > An indication for this is -cpu ? showing "host" with an all-zero PVR. > > Signed-off-by: Andreas Färber > --- > target-

Re: [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication

2013-01-03 Thread Stefan Hajnoczi
On Wed, Jan 02, 2013 at 12:26:37PM -0600, Troy Benjegerdes wrote: > The probability may be 'low' but it is not zero. Just because it's > hard to calculate the hash doesn't mean you can't do it. If your > input data is not random the probability of a hash collision is > going to get scewed. The cos

Re: [Qemu-devel] [PATCH 1/3] s390: Move IPL code into a separate device

2013-01-03 Thread Alexander Graf
On 18.12.2012, at 18:50, Jens Freimann wrote: > From: Christian Borntraeger > > Lets move the code to setup IPL for external kernel > or via the zipl rom into a separate file. This allows to > > - define a reboot handler, setting up the PSW appropriately > - enhance the boot code to IPL disks

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2013-01-03 Thread Alexander Graf
On 18.12.2012, at 18:50, Jens Freimann wrote: > Add a CPU reset handler to have all CPUs in a PoP compliant > state. > > Signed-off-by: Jens Freimann > > --- > v2 -> v3: > * remove FIXME > * separate parent reset from local reset by adding a while line > * use defines for register reset values

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2013-01-03 Thread Alexander Graf
On 18.12.2012, at 18:50, Jens Freimann wrote: > Add a CPU reset handler to have all CPUs in a PoP compliant > state. > > Signed-off-by: Jens Freimann > > --- > v2 -> v3: > * remove FIXME > * separate parent reset from local reset by adding a while line > * use defines for register reset values

Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions

2013-01-03 Thread Alexander Graf
On 18.12.2012, at 18:50, Jens Freimann wrote: > From: Viktor Mihajlovski > > This enables qemu -cpu help to return a list of supported CPU models > on s390 and also to query for cpu definitions in the monitor. > Initially only cpu model = host is returned. This needs to be reworked > into a ful

Re: [Qemu-devel] Using QEMU guest agent to run programs from guest path

2013-01-03 Thread Erlon Cruz
On Wed, Jan 2, 2013 at 9:04 PM, mdroth wrote: > On Mon, Dec 31, 2012 at 06:14:59PM -0200, Erlon Cruz wrote: > > Hi, > > > > > > I needed to run an external program in a guest machine. Once this must be > > triggered by the host, I first thought in qemu-ga. > > Is that possible? In QEMU help page

[Qemu-devel] [PATCH] linux-user: fix mips 32-on-64 prealloc case

2013-01-03 Thread Alexander Graf
MIPS only supports 31 bits of virtual address space for user space, so let's make sure we stay within that limit with our preallocated memory block. This fixes the MIPS user space targets when executed without command line option. Signed-off-by: Alexander Graf --- linux-user/main.c | 5 + 1

[Qemu-devel] [PATCH] pty: unbreak libvirt

2013-01-03 Thread Gerd Hoffmann
Commit 586502189edf9fd0f89a83de96717a2ea826fdb0 breaks libvirt pty support because it tried to figure the pts name from stderr output. Fix this by moving the label to the end of the line, this way the libvirt parser does still recognise the message. libvirt looks for "char device redirected to ${

Re: [Qemu-devel] [PATCH] pty: unbreak libvirt

2013-01-03 Thread Daniel P. Berrange
On Thu, Jan 03, 2013 at 02:23:03PM +0100, Gerd Hoffmann wrote: > Commit 586502189edf9fd0f89a83de96717a2ea826fdb0 breaks libvirt pty > support because it tried to figure the pts name from stderr output. > > Fix this by moving the label to the end of the line, this way the > libvirt parser does stil

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-03 Thread Liu Yuan
On 12/25/2012 04:45 PM, Liu Yuan wrote: > Well, I found setting cache=directsync will contain 'BDRV_O_CACHE_WB'. > Is this a bug for current master? If no, my current scheme will be the > only way to bypass cache of sheepdog. Ping. Can anyone confirm it is a bug that 'cache=directsync' will pass B

Re: [Qemu-devel] [PATCH] dataplane: use linux-headers/ for virtio includes

2013-01-03 Thread Anthony Liguori
Thanks, applied. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue

2013-01-03 Thread Alexander Graf
On 21.12.2012, at 14:56, Jason J. Herne wrote: > From: "Jason J. Herne" > > Modify syncing algorithm in do_kvm_cpu_synchronize_state to avoid > overwriting previously synced register data by calling > do_kvm_cpu_synchronize_state twice. > > The problem occurs if the following sequence of event

Re: [Qemu-devel] [PATCH 0/7] KVM regsync

2013-01-03 Thread Alexander Graf
On 21.12.2012, at 14:55, Jason J. Herne wrote: > Note: This is rework for the patch set previously submitted: > "s390/migration: Provide a cpu save for initial life migration work" > http://lists.nongnu.org/archive/html/qemu-devel/2012-11/msg02203.html > > Rework the method used to synchronize C

Re: [Qemu-devel] [PATCH 3/3] Enable kvm emulated watchdog

2013-01-03 Thread Alexander Graf
On 27.12.2012, at 12:38, Bhushan Bharat-R65777 wrote: > > >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Monday, December 17, 2012 8:09 PM >> To: Bhushan Bharat-R65777 >> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; Bhushan Bharat-R65777 >> Subject: Re:

Re: [Qemu-devel] [RFC PATCH V8 01/15] qdev : add a maximum device allowed field for the bus.

2013-01-03 Thread KONRAD Frédéric
On 02/01/2013 15:08, Anthony Liguori wrote: fred.kon...@greensocs.com writes: From: KONRAD Frederic Add a max_dev field to BusState to specify the maximum amount of devices allowed on the bus ( have no effect if max_dev=0 ) Signed-off-by: KONRAD Frederic --- hw/qdev-core.h| 2 ++ hw

Re: [Qemu-devel] [RFC 0/8] Remove old_portio usage

2013-01-03 Thread Gerd Hoffmann
Hi, > As for finding a solution to the bochs debug ports, can you resubmit > this series with the commit'able patches first, marked PATCH, and append > a proposal merging Gerd's, Lucas' and your QOM'ified debug device? I'll try to get a updated patch series with the debug/test devices out of th

Re: [Qemu-devel] [RFC 3/8] uhci: do not use old_portio-style callbacks

2013-01-03 Thread Gerd Hoffmann
On 12/23/12 16:32, Hervé Poussineau wrote: > -static const MemoryRegionPortio uhci_portio[] = { > -{ 0, 32, 2, .write = uhci_ioport_writew, }, > -{ 0, 32, 2, .read = uhci_ioport_readw, }, > -{ 0, 32, 4, .write = uhci_ioport_writel, }, > -{ 0, 32, 4, .read = uhci_ioport_readl, }, > -

Re: [Qemu-devel] [PATCH 2/3 v2] Reset qemu timers when guest reset

2013-01-03 Thread Alexander Graf
On 28.12.2012, at 06:16, Bharat Bhushan wrote: > This patch install the timer reset handler. This will be called when > the guest is reset. > > Signed-off-by: Bharat Bhushan Thanks, adjusted to the current QOM'ified code and applied this patch. Alex

Re: [Qemu-devel] [Xen-devel] [PATCH RFC 1/3] xen_disk: handle disk files on ramfs/tmpfs

2013-01-03 Thread Ian Campbell
On Mon, 2012-12-31 at 12:16 +, Roger Pau Monne wrote: > Files that reside on ramfs or tmpfs cannot be opened with O_DIRECT, > if first call to bdrv_open fails with errno = EINVAL, try a second > call without BDRV_O_NOCACHE. Doesn't that risk spuriously turning of NOCACHE on other sorts of devi

Re: [Qemu-devel] [PATCH] s390x: Remove inline function ebcdic_put and related data from cpu.h

2013-01-03 Thread Alexander Graf
On 01.01.2013, at 19:24, Stefan Weil wrote: > The function is only used in misc_helper.c, so move it to that file. > > This reduces the size of debug executables (compiled without optimization) > because they get unused code and data for each compilation which includes > cpu.h. > > Executables

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] Modifications to fix PowerPC on 64bit host, bug 1052857

2013-01-03 Thread Alexander Graf
On 02.01.2013, at 21:53, Samuel Seay wrote: > Removed h2g() macro around the ka->_sa_handler due to the _sa_handler being a > guest memory address > Changed the __put_user to put_user as it was attempting to put a value at the > stack address but the new address is a guest memory address, __put

[Qemu-devel] [RFC V9 01/12] qdev : add a maximum device allowed field for the bus.

2013-01-03 Thread fred . konrad
From: KONRAD Frederic Add a max_dev field to BusState to specify the maximum amount of devices allowed on the bus ( have no effect if max_dev=0 ) Signed-off-by: KONRAD Frederic --- hw/qdev-core.h| 2 ++ hw/qdev-monitor.c | 11 +++ 2 files changed, 13 insertions(+) diff --git a/hw

[Qemu-devel] [RFC V9 02/12] virtio-bus : introduce virtio-bus

2013-01-03 Thread fred . konrad
From: KONRAD Frederic Introduce virtio-bus. Refactored transport device will create a bus which extends virtio-bus. Signed-off-by: KONRAD Frederic --- hw/Makefile.objs | 1 + hw/virtio-bus.c | 178 +++ hw/virtio-bus.h | 98 ++

[Qemu-devel] [RFC V9 00/12] Virtio refactoring.

2013-01-03 Thread fred . konrad
From: KONRAD Frederic You can clone that from here : git.greensocs.com/home/greensocs/git/qemu_virtio.git virtio_refactoring_rfc_v9 This new version fix the name issues with the function name (in virtio-bus) and the initialisation of virtio-blk-x. If you're all ok with that, I will send the full

[Qemu-devel] [RFC V9 10/12] virtio-blk-s390 : switch to the new API.

2013-01-03 Thread fred . konrad
From: KONRAD Frederic Here the virtio-blk-s390 is modified for the new API. The device virtio-blk-s390 extends virtio-s390-device as before. It creates and connects a virtio-blk during the init. The properties are not modified. Signed-off-by: KONRAD Frederic --- hw/s390-virtio-bus.c | 17 +

[Qemu-devel] [RFC V9 09/12] virtio-blk-pci : switch to new API.

2013-01-03 Thread fred . konrad
From: KONRAD Frederic Here the virtio-blk-pci is modified for the new API. The device virtio-blk-pci extends virtio-pci. It creates and connects a virtio-blk during the init. The properties are not changed. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 113 +++---

[Qemu-devel] [RFC V9 11/12] virtio-blk : cleanup : use QOM cast.

2013-01-03 Thread fred . konrad
From: KONRAD Frederic As the virtio-blk-pci and virtio-blk-s390 are switched to the new API, we can use QOM casts and remove the separate init/exit for the old API. This shouldn't been applyied before virtio-blk-pci and virtio-blk-s390 refactoring as their VirtIODevice were not a QOM object. Sig

[Qemu-devel] [RFC V9 04/12] virtio-pci : refactor virtio-pci device.

2013-01-03 Thread fred . konrad
From: KONRAD Frederic Create the virtio-pci device. This transport device will create a virtio-pci-bus, so one VirtIODevice can be connected. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 133 hw/virtio-pci.h | 18 2 fil

[Qemu-devel] [RFC V9 08/12] virtio-blk : add the virtio-blk device.

2013-01-03 Thread fred . konrad
From: KONRAD Frederic Create virtio-blk which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 101 +++- hw/virtio-blk.h | 19 +++ hw/virtio-pci.c | 7 ++-- 3 files c

[Qemu-devel] [RFC V9 05/12] virtio-device : refactor virtio-device.

2013-01-03 Thread fred . konrad
From: KONRAD Frederic Create the virtio-device which is abstract. All the virtio-device can extend this class. Signed-off-by: KONRAD Frederic --- hw/virtio.c | 70 ++--- hw/virtio.h | 31 +++ 2 files changed, 89 in

[Qemu-devel] [RFC V9 12/12] virtio-blk : cleanup : remove qdev field.

2013-01-03 Thread fred . konrad
From: KONRAD Frederic The qdev field is no longer needed, just drop it. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 67e58da..0363419 100644 --- a/hw/virtio-blk.c +++ b/hw/virti

[Qemu-devel] [RFC V9 06/12] virtio-s390-bus : add virtio-s390-bus.

2013-01-03 Thread fred . konrad
From: KONRAD Frederic This add the virtio-s390-bus which extends virtio-bus. So one VirtIODevice can be connected on this bus. Signed-off-by: KONRAD Frederic --- hw/s390-virtio-bus.c | 28 hw/s390-virtio-bus.h | 13 + 2 files changed, 41 insertions(+)

[Qemu-devel] [RFC V9 03/12] virtio-pci-bus : introduce virtio-pci-bus.

2013-01-03 Thread fred . konrad
From: KONRAD Frederic Introduce virtio-pci-bus, which extends virtio-bus. It is used with virtio-pci transport device. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 37 + hw/virtio-pci.h | 19 +-- 2 files changed, 54 insertions(+), 2 d

[Qemu-devel] [RFC V9 07/12] virtio-s390-device : create a virtio-s390-bus during init.

2013-01-03 Thread fred . konrad
From: KONRAD Frederic A virtio-s390-bus is created during the init. So one VirtIODevice can be connected on the virtio-s390-device through this bus. Signed-off-by: KONRAD Frederic --- hw/s390-virtio-bus.c | 2 ++ hw/s390-virtio-bus.h | 1 + 2 files changed, 3 insertions(+) diff --git a/hw/s39

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2013-01-03 Thread daniel pecka
same here with: Bus 002 Device 006: ID 16d5:6603 AnyDATA Corporation ^^ it is modem and my qemu-kvm version is: QEMU emulator version 1.2.0 (kvm-1.2.0-178.2) i can also confirm freezing in previous version .. regards, d -- You received this bug notification because you are a member of qemu- de

Re: [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication

2013-01-03 Thread Benoît Canet
Hello, I started to write the deduplication metrics code in order to be able to design asynchronous deduplication. I am looking for a way to create a metric allowing deduplication to be paused or resumed on a given threshold. Does anyone have a sugestion regarding the metric that could be used

Re: [Qemu-devel] [PATCH] linux-user: fix mips 32-on-64 prealloc case

2013-01-03 Thread Peter Maydell
On 3 January 2013 13:17, Alexander Graf wrote: > MIPS only supports 31 bits of virtual address space for user space, so let's > make sure we stay within that limit with our preallocated memory block. > > This fixes the MIPS user space targets when executed without command line > option. This look

Re: [Qemu-devel] [PATCH] linux-user: fix mips 32-on-64 prealloc case

2013-01-03 Thread Alexander Graf
On 03.01.2013, at 18:19, Peter Maydell wrote: > On 3 January 2013 13:17, Alexander Graf wrote: >> MIPS only supports 31 bits of virtual address space for user space, so let's >> make sure we stay within that limit with our preallocated memory block. >> >> This fixes the MIPS user space targets

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] Modifications to fix PowerPC on 64bit host, bug 1052857

2013-01-03 Thread Peter Maydell
On 3 January 2013 14:45, Alexander Graf wrote: > > On 02.01.2013, at 21:53, Samuel Seay wrote: > >> Removed h2g() macro around the ka->_sa_handler due to the _sa_handler being >> a guest memory address >> Changed the __put_user to put_user as it was attempting to put a value at >> the stack addr

Re: [Qemu-devel] [PATCH 01/15] openpic: fix debug prints

2013-01-03 Thread Alexander Graf
On 22.12.2012, at 03:15, Scott Wood wrote: > Fix various format errors when debug prints are enabled. Also > cause error checking to happen even when debug prints are not > enabled, and consistently use 0x for hex output. > > Signed-off-by: Scott Wood > --- > hw/openpic.c | 40 ++

Re: [Qemu-devel] [PATCH 0/8] CPU DeviceState v10

2013-01-03 Thread Andreas Färber
Am 05.12.2012 17:49, schrieb Eduardo Habkost: > Eduardo Habkost (8): [...] > libqemustub: Add qemu_[un]register_reset() stubs > libqemustub: vmstate register/unregister stubs > libqemustub: sysbus_get_default() stub [...] > include qdev code into *-user, too > qom: Make CPU a child of Dev

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] Modifications to fix PowerPC on 64bit host, bug 1052857

2013-01-03 Thread Alexander Graf
On 03.01.2013, at 18:28, Peter Maydell wrote: > On 3 January 2013 14:45, Alexander Graf wrote: >> >> On 02.01.2013, at 21:53, Samuel Seay wrote: >> >>> Removed h2g() macro around the ka->_sa_handler due to the _sa_handler being >>> a guest memory address >>> Changed the __put_user to put_user

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] Modifications to fix PowerPC on 64bit host, bug 1052857

2013-01-03 Thread Peter Maydell
On 3 January 2013 17:37, Alexander Graf wrote: > On 03.01.2013, at 18:28, Peter Maydell wrote: >> Untested, and I haven't looked up the PPC ABI to check that the >> function is overall doing the right thing, but with those caveats: >> Reviewed-by: Peter Maydell > > Considering the state it was in

Re: [Qemu-devel] [PATCH 03/15] openpic: fix sense and priority bits

2013-01-03 Thread Alexander Graf
On 22.12.2012, at 03:15, Scott Wood wrote: > Previously, the sense and priority bits were masked off when writing > to IVPR, and all interrupts were treated as edge-triggered (despite > the existence of code for handling level-triggered interrupts). > > Polarity is implemented only as storage.

Re: [Qemu-devel] [PATCH 02/15] openpic: lower interrupt when reading the MSI register

2013-01-03 Thread Alexander Graf
On 22.12.2012, at 03:15, Scott Wood wrote: > This will stop things from breaking once it's properly treated as a > level-triggered interrupt. Note that it's the MPIC's MSI cascade > interrupts that are level-triggered; the individual MSIs are > edge-triggered. > > Signed-off-by: Scott Wood Th

Re: [Qemu-devel] [PATCH 04/15] ppc/booke: fix crit/mcheck/debug exceptions

2013-01-03 Thread Alexander Graf
On 22.12.2012, at 03:15, Scott Wood wrote: > Book E does not play games with certain bits of xSRR1 being MSR save > bits and others being error status. xSRR1 is the old MSR, period. > This was causing things like MSR[CE] to be lost, even in the saved > version, as soon as you take an exception.

Re: [Qemu-devel] [PATCH 03/11] qemu-img: remove parameter filename in collect_image_info()

2013-01-03 Thread Eric Blake
On 12/29/2012 01:45 AM, Wenchao Xia wrote: > Switch the filename getting from parameter to block function, > now collect_image_info depends only on *bs. > > Signed-off-by: Wenchao Xia > --- > qemu-img.c |8 +--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/qemu-

Re: [Qemu-devel] [PATCH 05/15] openpic: make register names correspond better with hw docs

2013-01-03 Thread Alexander Graf
On 22.12.2012, at 03:15, Scott Wood wrote: > The base openpic specification doesn't provide abbreviated register > names, so it's somewhat understandable that the QEMU code made up > its own, except that most of the names that QEMU used didn't correspond > to the terminology used by any implement

Re: [Qemu-devel] [RFC V4 01/30] qcow2: Add deduplication to the qcow2 specification.

2013-01-03 Thread Eric Blake
On 01/02/2013 09:16 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > docs/specs/qcow2.txt | 100 > +- > 1 file changed, 99 insertions(+), 1 deletion(-) > > diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt > index 36a559d..c9c

Re: [Qemu-devel] [Xen-devel] [PATCH RFC 1/3] xen_disk: handle disk files on ramfs/tmpfs

2013-01-03 Thread Konrad Rzeszutek Wilk
On Mon, Dec 31, 2012 at 01:16:12PM +0100, Roger Pau Monne wrote: > Files that reside on ramfs or tmpfs cannot be opened with O_DIRECT, That is not entirely true. There are patches floating around (LKML) to make tmpfs/ramfs be able to do this. > if first call to bdrv_open fails with errno = EINVAL

Re: [Qemu-devel] [PATCH 06/15] openpic: rework critical interrupt support

2013-01-03 Thread Alexander Graf
On 22.12.2012, at 03:15, Scott Wood wrote: > Critical interrupts on FSL MPIC are not supposed to pay > attention to priority, IACK, EOI, etc. On the currently modeled > version it's not supposed to pay attention to the mask bit either. > > Also reorganize to make it easier to implement newer FS

Re: [Qemu-devel] [PATCH 07/15] openpic: make ctpr signed

2013-01-03 Thread Alexander Graf
On 22.12.2012, at 03:15, Scott Wood wrote: > Other priorities are signed, so avoid comparisons between > signed and unsigned. > > Signed-off-by: Scott Wood Thanks, applied to ppc-next. Alex

Re: [Qemu-devel] [PATCH 08/15] openpic/fsl: critical interrupts ignore mask before v4.1

2013-01-03 Thread Alexander Graf
On 22.12.2012, at 03:15, Scott Wood wrote: > Signed-off-by: Scott Wood > --- > hw/openpic.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/hw/openpic.c b/hw/openpic.c > index 9d22e9c..268f312 100644 > --- a/hw/openpic.c > +++ b/hw/openpic.c > @@ -194,6 +194,7 @@

Re: [Qemu-devel] [PATCH] linux-user: fix mips 32-on-64 prealloc case

2013-01-03 Thread Eric Johnson
On 01/03/2013 09:24 AM, Alexander Graf wrote: On 03.01.2013, at 18:19, Peter Maydell wrote: On 3 January 2013 13:17, Alexander Graf wrote: MIPS only supports 31 bits of virtual address space for user space, so let's make sure we stay within that limit with our preallocated memory block. This

Re: [Qemu-devel] [PATCH 09/15] openpic: always call IRQ_check from IRQ_get_next

2013-01-03 Thread Alexander Graf
On 22.12.2012, at 03:15, Scott Wood wrote: > Previously the code relied on the queue's "next" field getting > set to -1 sometime between an update to the bitmap, and the next > call to IRQ_get_next. Sometimes this happened after the update. > Sometimes it happened before the check. Sometimes it

Re: [Qemu-devel] [PATCH 11/15] openpic: use standard bitmap operations

2013-01-03 Thread Alexander Graf
On 22.12.2012, at 03:15, Scott Wood wrote: > Besides the private implementation being redundant, namespace collisions > prevented the use of other things in bitops.h. > > Serialization does get a bit more awkward, unfortunately, since the > standard bitmap operations are "unsigned long" rather t

Re: [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue

2013-01-03 Thread Jason J. Herne
On 01/03/2013 08:56 AM, Alexander Graf wrote: static void do_kvm_cpu_synchronize_state(void *_args) >{ > struct kvm_cpu_syncstate_args *args = _args; >+CPUArchState *env = args->env; >+int register_level = args->register_level; > This probably becomes more readable if we explicitly r

Re: [Qemu-devel] [PATCH] linux-user: fix mips 32-on-64 prealloc case

2013-01-03 Thread Richard Henderson
On 01/03/2013 10:39 AM, Eric Johnson wrote: > While making this change please keep in mind that newer MIPS32 > processors allow more than 31 bits of user address space (up to 3.5 > GiB) if they have Enhanced Virtual Address support. Interesting. Well, would you be able to help figure out exactly

Re: [Qemu-devel] [PATCH 12/15] openpic: IRQ_check: search the queue a word at a time

2013-01-03 Thread Alexander Graf
On 22.12.2012, at 03:15, Scott Wood wrote: > Search the queue more efficiently by first looking for a non-zero word, > and then using the common bit-searching function to find the bit within > the word. It would be even nicer if bitops_ffsl() could be hooked up > to the compiler intrinsic so tha

Re: [Qemu-devel] pthread_create failed: Resource temporarily unavailable

2013-01-03 Thread Christoffer Dall
On Thu, Jan 3, 2013 at 6:50 AM, Andreas Färber wrote: > >> The culprit seems to be when the process runs out of virtual address >> space on 32-bit systems due to some subsystem (virtio?) creating a >> large number of pthreads under heavy workloads. >> >> Unfortunately my QEMU expertise is too limi

Re: [Qemu-devel] [PATCH 13/15] openpic: add some bounds checking for IRQ numbers

2013-01-03 Thread Alexander Graf
On 22.12.2012, at 03:15, Scott Wood wrote: > The two checks with abort() guard against potential QEMU-internal > problems, but the EOI check stops the guest from causing updates to queue > position -1 and other havoc if it writes EOI with no interrupt in > service. > > Signed-off-by: Scott Wood

Re: [Qemu-devel] [PATCH] pty: unbreak libvirt

2013-01-03 Thread Anthony Liguori
"Daniel P. Berrange" writes: > On Thu, Jan 03, 2013 at 02:23:03PM +0100, Gerd Hoffmann wrote: >> Commit 586502189edf9fd0f89a83de96717a2ea826fdb0 breaks libvirt pty >> support because it tried to figure the pts name from stderr output. >> >> Fix this by moving the label to the end of the line, th

Re: [Qemu-devel] [PATCH 14/15] openpic: move IACK to its own function

2013-01-03 Thread Alexander Graf
On 22.12.2012, at 03:15, Scott Wood wrote: > Besides making the code cleaner, we will need a separate way to access > IACK in order to implement EPR (external proxy) interrupt delivery. > > Signed-off-by: Scott Wood This patch depends on 3/15, so I'll leave it alone for now. It looks sane tho

Re: [Qemu-devel] dataplane build error

2013-01-03 Thread Anthony Liguori
Stefan Hajnoczi writes: > On Thu, Jan 03, 2013 at 10:32:43AM +0100, Stefan Weil wrote: >> Am 03.01.2013 10:30, schrieb Gerd Hoffmann: >> > CChw/dataplane/vring.o >> >cc1: warnings being treated as errors >> >/home/kraxel/projects/qemu/hw/dataplane/vring.c: In function ‘vring_setup’: >> >/ho

Re: [Qemu-devel] [PATCH 15/15] openpic: fix CTPR and de-assertion of interrupts

2013-01-03 Thread Alexander Graf
On 22.12.2012, at 03:15, Scott Wood wrote: > Properly implement level-triggered interrupts by withdrawing an > interrupt from the raised queue if the interrupt source de-asserts. > Also withdraw from the raised queue if the interrupt becomes masked. > > When CTPR is written, check whether we nee

Re: [Qemu-devel] [PATCH] pty: unbreak libvirt

2013-01-03 Thread Anthony Liguori
Thanks, applied. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue

2013-01-03 Thread Alexander Graf
On 03.01.2013, at 19:48, Jason J. Herne wrote: > On 01/03/2013 08:56 AM, Alexander Graf wrote: >>> static void do_kvm_cpu_synchronize_state(void *_args) >>> >{ >>> > struct kvm_cpu_syncstate_args *args = _args; >>> >+CPUArchState *env = args->env; >>> >+int register_level = args->regi

Re: [Qemu-devel] [PATCH] linux-user: fix mips 32-on-64 prealloc case

2013-01-03 Thread Eric Johnson
On 01/03/2013 10:50 AM, Richard Henderson wrote: On 01/03/2013 10:39 AM, Eric Johnson wrote: While making this change please keep in mind that newer MIPS32 processors allow more than 31 bits of user address space (up to 3.5 GiB) if they have Enhanced Virtual Address support. Interesting. Well,

Re: [Qemu-devel] Using QEMU guest agent to run programs from guest path]

2013-01-03 Thread mdroth
On Thu, Jan 03, 2013 at 11:06:02AM -0200, Erlon Cruz wrote: > On Wed, Jan 2, 2013 at 9:04 PM, mdroth wrote: > > > On Mon, Dec 31, 2012 at 06:14:59PM -0200, Erlon Cruz wrote: > > > Hi, > > > > > > > > > I needed to run an external program in a guest machine. Once this must be > > > triggered by th

Re: [Qemu-devel] [PATCH] pty: unbreak libvirt

2013-01-03 Thread Peter Maydell
On 3 January 2013 19:00, Anthony Liguori wrote: > Thanks, applied. So we now say "char device redirected to /dev/pts/5 (compat_monitor0)" rather than "char device compat_monitor0 redirected to /dev/pts/5" ? I think that's a reduction in clarity and it's sad that we have to do it. I also think th

Re: [Qemu-devel] [PATCH 01/15] openpic: fix debug prints

2013-01-03 Thread Scott Wood
On 01/03/2013 11:31:49 AM, Alexander Graf wrote: On 22.12.2012, at 03:15, Scott Wood wrote: > Fix various format errors when debug prints are enabled. Also > cause error checking to happen even when debug prints are not > enabled, and consistently use 0x for hex output. > > Signed-off-by: Scot

Re: [Qemu-devel] [PATCH] pty: unbreak libvirt

2013-01-03 Thread Anthony Liguori
Peter Maydell writes: > On 3 January 2013 19:00, Anthony Liguori wrote: >> Thanks, applied. > > So we now say "char device redirected to /dev/pts/5 (compat_monitor0)" > rather than "char device compat_monitor0 redirected to /dev/pts/5" ? > I think that's a reduction in clarity and it's sad that

Re: [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication

2013-01-03 Thread Troy Benjegerdes
On Thu, Jan 03, 2013 at 01:39:48PM +0100, Stefan Hajnoczi wrote: > On Wed, Jan 02, 2013 at 12:26:37PM -0600, Troy Benjegerdes wrote: > > The probability may be 'low' but it is not zero. Just because it's > > hard to calculate the hash doesn't mean you can't do it. If your > > input data is not rand

Re: [Qemu-devel] [Qemu-ppc] [PATCH 13/15] openpic: add some bounds checking for IRQ numbers

2013-01-03 Thread Scott Wood
On 01/03/2013 12:55:26 PM, Alexander Graf wrote: On 22.12.2012, at 03:15, Scott Wood wrote: > The two checks with abort() guard against potential QEMU-internal > problems, but the EOI check stops the guest from causing updates to queue > position -1 and other havoc if it writes EOI with no i

Re: [Qemu-devel] [PATCH 12/15] openpic: IRQ_check: search the queue a word at a time

2013-01-03 Thread Scott Wood
On 01/03/2013 12:53:13 PM, Alexander Graf wrote: On 22.12.2012, at 03:15, Scott Wood wrote: > Search the queue more efficiently by first looking for a non-zero word, > and then using the common bit-searching function to find the bit within > the word. It would be even nicer if bitops_ffsl(

Re: [Qemu-devel] [PATCH 09/15] openpic: always call IRQ_check from IRQ_get_next

2013-01-03 Thread Scott Wood
On 01/03/2013 12:42:09 PM, Alexander Graf wrote: On 22.12.2012, at 03:15, Scott Wood wrote: > Previously the code relied on the queue's "next" field getting > set to -1 sometime between an update to the bitmap, and the next > call to IRQ_get_next. Sometimes this happened after the update. > So

Re: [Qemu-devel] [PATCH 03/15] openpic: fix sense and priority bits

2013-01-03 Thread Scott Wood
On 01/03/2013 11:51:56 AM, Alexander Graf wrote: On 22.12.2012, at 03:15, Scott Wood wrote: > Previously, the sense and priority bits were masked off when writing > to IVPR, and all interrupts were treated as edge-triggered (despite > the existence of code for handling level-triggered interrupt

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3 v2] Reset qemu timers when guest reset

2013-01-03 Thread Scott Wood
On 12/27/2012 11:16:51 PM, Bharat Bhushan wrote: This patch install the timer reset handler. This will be called when the guest is reset. Signed-off-by: Bharat Bhushan --- v2: same as v1 hw/ppc_booke.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/pp

Re: [Qemu-devel] [PATCH 12/15] openpic: IRQ_check: search the queue a word at a time

2013-01-03 Thread Alexander Graf
Am 03.01.2013 um 21:07 schrieb Scott Wood : > On 01/03/2013 12:53:13 PM, Alexander Graf wrote: >> On 22.12.2012, at 03:15, Scott Wood wrote: >> > Search the queue more efficiently by first looking for a non-zero word, >> > and then using the common bit-searching function to find the bit within >

  1   2   >