Re: [Qemu-devel] [PATCH] qemu-ga: Extend guest-network-get-interfaces

On 21.12.2012 19:43, Eric Blake wrote: > On 12/21/2012 05:59 AM, Michal Privoznik wrote: >> Nowadays only basic information is reported. However, with the >> current implementation much more can be exposed to users. like >> broadcast/destination address (the former in case of standard >> ethernet d

Re: [Qemu-devel] Fwd: Problem booting 32 bit guest on 64 bit host using kvm

On Wed, Jan 02, 2013 at 05:35:44PM +1000, Mark Blakeney wrote: > Ubuntu 12.04 (precise) kernel is 3.2.0.35.40. Too hard to downgrade kermel. > So, as far as I understand, you moved from 3.2.0 32bit kernel to 3.5.0/3.7.0 64bit kernel and things stopped working. It is hard to conclude that this is 3

Re: [Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host

Hello, Am 02.01.2013 05:58, schrieb Samuel Seay: > Attached is a patch for fixing bug #1052857. My local tests show it > working properly on 32 and 64bit. > > Signed-off-by: Samuel Seay > Please submit patches using git-send-email tool so that they arrive text-only

Re: [Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host

On 2 January 2013 04:58, Samuel Seay wrote: > Attached is a patch for fixing bug #1052857. My local tests show it working > properly on 32 and 64bit. --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -4584,7 +4584,7 @@ static void setup_frame(int sig, struct target_sigaction *ka, signa

Re: [Qemu-devel] Fwd: Problem booting 32 bit guest on 64 bit host using kvm

FYI, I just discovered that I can make my Solaris guest boot every time in kvm by specifying an interactive boot at the boot prompt and then just hand stepping through the default prompts. Presumably there is a timing issue in the guest boot sequence which kvm is exposing when running natively on m

Re: [Qemu-devel] [PATCH 3/8] libqemustub: vmstate register/unregister stubs

Am 05.12.2012 17:49, schrieb Eduardo Habkost: > diff --git a/stubs/vmstate.c b/stubs/vmstate.c > new file mode 100644 > index 000..badf79e > --- /dev/null > +++ b/stubs/vmstate.c > @@ -0,0 +1,17 @@ > +#include "qemu-common.h" > +#include "vmstate.h" Needed to update this to "migration/vmstate.

Re: [Qemu-devel] Fwd: Problem booting 32 bit guest on 64 bit host using kvm

On Wed, Jan 02, 2013 at 10:26:55PM +1000, Mark Blakeney wrote: > FYI, I just discovered that I can make my Solaris guest boot every > time in kvm by specifying an interactive boot at the boot prompt and > then just hand stepping through the default prompts. Presumably there > is a timing issue in t

Re: [Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host

The VM I did the work in doesn't have internet access and I was unsure how to do a text only email with gmail. With that said, the line that removed the env->gpr[1] is redudant as a few lines below in the original source it is set with newsp. The removed line would seg fault due to trying to write

[Qemu-devel] [PATCH 3/3] vnc: fix possible uninitialized removals

Some VncState values are not initialized before the Websocket handshake. If it fails QEMU segfaults during the cleanup. To prevent this behavior intialization checks are added. Signed-off-by: Tim Hardeck --- ui/vnc.c | 11 --- ui/vnc.h |1 + 2 files changed, 9 insertions(+), 3 dele

[Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

This patch adds basic Websocket Protocol version 13 - RFC 6455 - support to QEMU VNC. Binary encoding support on the client side is mandatory. Because of the GnuTLS requirement the Websockets implementation is optional (--enable-vnc-ws). To activate Websocket support the VNC option "websocket"is

[Qemu-devel] [PATCH 1/3] vnc: added buffer_advance function

Following Anthony Liguori's Websocket implementation I have added the buffer_advance function to VNC and replaced all related buffer memmove operations with it. Signed-off-by: Tim Hardeck --- ui/vnc.c | 13 + ui/vnc.h |1 + 2 files changed, 10 insertions(+), 4 deletions(-) dif

Re: [Qemu-devel] [PATCH 1/8] Move -I$(SRC_PATH)/include compiler flag to Makefile.objs

Am 14.12.2012 18:21, schrieb Eduardo Habkost: > On Fri, Dec 14, 2012 at 04:34:29PM +0100, Andreas Färber wrote: >> Waiting for ack or nack from Paolo here. I am expecting some overlap >> with his header file reorganization series. >> >> My previous (unanswered?) question was why you are moving vl.o

[Qemu-devel] [PATCH 0/3 v5] vnc: added initial websocket protocol support

This patch set adds basic Websocket Protocol version 13 - RFC 6455 - support to QEMU VNC. Binary encoding support on the client side is mandatory. Because of the GnuTLS requirement the Websockets implementation is optional (--enable-vnc-ws). To activate Websocket support the VNC option "websocket

Re: [Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host

On 2 January 2013 13:01, Samuel Seay wrote: > The VM I did the work in doesn't have internet access and I was unsure how > to do a text only email with gmail. With that said, the line that removed > the env->gpr[1] is redudant as a few lines below in the original source it > is set with newsp. The

Re: [Qemu-devel] [RFC PATCH V8 01/15] qdev : add a maximum device allowed field for the bus.

fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > Add a max_dev field to BusState to specify the maximum amount of devices > allowed > on the bus ( have no effect if max_dev=0 ) > > Signed-off-by: KONRAD Frederic > --- > hw/qdev-core.h| 2 ++ > hw/qdev-monitor.c | 11 +

Re: [Qemu-devel] [RFC PATCH V8 02/15] virtio-bus : Introduce virtio-bus

fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > Introduce virtio-bus. Refactored transport device will create a bus which > extends virtio-bus. > > Signed-off-by: KONRAD Frederic > --- > hw/Makefile.objs | 1 + > hw/virtio-bus.c | 169 >

Re: [Qemu-devel] [RFC PATCH V8 03/15] virtio-pci-bus : Introduce virtio-pci-bus.

fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > Introduce virtio-pci-bus, which extends virtio-bus. It is used with virtio-pci > transport device. > > Signed-off-by: KONRAD Frederic Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > hw/virtio-pci.c | 37 +++

Re: [Qemu-devel] [RFC PATCH V8 04/15] virtio-pci : Refactor virtio-pci device.

fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > Create the virtio-pci device. This transport device will create a > virtio-pci-bus, so one VirtIODevice can be connected. > > Signed-off-by: KONRAD Frederic > --- > hw/virtio-pci.c | 130 > +++

Re: [Qemu-devel] [RFC PATCH V8 05/15] virtio-device : Refactor virtio-device.

fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > Create the virtio-device which is abstract. All the virtio-device can extend > this class. > > Signed-off-by: KONRAD Frederic Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > hw/virtio.c | 70 >

Re: [Qemu-devel] [RFC PATCH V8 04/15] virtio-pci : Refactor virtio-pci device.

On 02/01/2013 15:14, Anthony Liguori wrote: fred.kon...@greensocs.com writes: From: KONRAD Frederic Create the virtio-pci device. This transport device will create a virtio-pci-bus, so one VirtIODevice can be connected. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 130

Re: [Qemu-devel] [RFC PATCH V8 09/15] virtio-blk-pci : Switch to new API.

fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > Here the virtio-blk-pci is modified for the new API. The device virtio-blk-pci > extends virtio-pci. It creates and connects a virtio-blk during the init. > > Signed-off-by: KONRAD Frederic > --- > hw/virtio-pci.c | 106 > ++

Re: [Qemu-devel] [RFC PATCH V8 01/15] qdev : add a maximum device allowed field for the bus.

On 02/01/2013 15:16, Andreas Färber wrote: Am 02.01.2013 15:08, schrieb Anthony Liguori: fred.kon...@greensocs.com writes: From: KONRAD Frederic Add a max_dev field to BusState to specify the maximum amount of devices allowed on the bus ( have no effect if max_dev=0 ) Signed-off-by: KONRAD

Re: [Qemu-devel] [PATCH 1/8] Move -I$(SRC_PATH)/include compiler flag to Makefile.objs

On Wed, Jan 02, 2013 at 02:48:00PM +0100, Andreas Färber wrote: > Am 14.12.2012 18:21, schrieb Eduardo Habkost: > > On Fri, Dec 14, 2012 at 04:34:29PM +0100, Andreas Färber wrote: > >> Waiting for ack or nack from Paolo here. I am expecting some overlap > >> with his header file reorganization seri

Re: [Qemu-devel] [PATCH 1/2] target-i386: kvm: -cpu host: use GET_SUPPORTED_CPUID for SVM features

On Fri, 28 Dec 2012 16:37:33 -0200 Eduardo Habkost wrote: > The existing -cpu host code simply set every bit inside svm_features > (initializing it to -1), and that makes it impossible to make the > enforce/check options work properly when the user asks for SVM features > explicitly in the comman

Re: [Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host

I did not catch that, somehow I managed to invert the logic when looking at it. Maybe a g2h() (such a macro exist? what would be the proper method?) around the newsp value would do it. I'll redo that this evening and attempt to submit a newer patch. Considering I don't have direct internet access i

Re: [Qemu-devel] [RFC PATCH V8 01/15] qdev : add a maximum device allowed field for the bus.

Am 02.01.2013 15:08, schrieb Anthony Liguori: > fred.kon...@greensocs.com writes: > >> From: KONRAD Frederic >> >> Add a max_dev field to BusState to specify the maximum amount of devices >> allowed >> on the bus ( have no effect if max_dev=0 ) >> >> Signed-off-by: KONRAD Frederic >> --- >> hw

Re: [Qemu-devel] [PATCH 1/2] target-i386: kvm: -cpu host: use GET_SUPPORTED_CPUID for SVM features

Am 28.12.2012 19:37, schrieb Eduardo Habkost: > The existing -cpu host code simply set every bit inside svm_features > (initializing it to -1), and that makes it impossible to make the > enforce/check options work properly when the user asks for SVM features > explicitly in the command-line. > > S

Re: [Qemu-devel] [PATCH 0/2] Fixes for -cpu host KVM/SVM feature initialization

Am 28.12.2012 19:37, schrieb Eduardo Habkost: > This series has two very similar fixes for feature initizliation for "-cpu > host". This should allow us to make the check/enforce code check for host > support of KVM and SVM features, later. I am out of my field here to verify whether this is seman

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Change to correct PowerPC on a 64bit host

Please don't top post. Am 02.01.2013 um 15:34 schrieb Samuel Seay : > I did not catch that, somehow I managed to invert the logic when looking at > it. Maybe a g2h() (such a macro exist? what would be the proper method?) > around the newsp value would do it. Sounds reasonable OTOH ;). > I'll

Re: [Qemu-devel] [RFC 00/34] QOM realize, device-only plus ISA conversion

So there are 3-4 different series in here all rolled into one. This makes review a bit tedious. I'd suggest: 1) Pull out all of the QOMification stuff into a separate series. 2) Pull out the style cleanups into another series 3) Pull out the introduction of realize/unrealize into a series 4) Pul

Re: [Qemu-devel] [PATCH 5/6] snapshot: qmp interface

On 12/16/2012 11:25 PM, Wenchao Xia wrote: > This patch changes the implemtion of external block snapshot s/implemtion/implementation/ > to use internal unified interface, now qmp handler just do s/do/does/ > a translation of request and submit. > Also internal block snapshot qmp interface

Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: enable all supported KVM features for -cpu host

On Fri, 28 Dec 2012 16:37:34 -0200 Eduardo Habkost wrote: > When using -cpu host, we don't need to use the kvm_default_features > variable, as the user is explicitly asking QEMU to enable all feature > supported by the host. > > This changes the kvm_cpu_fill_host() code to use GET_SUPPORTED_CPUI

Re: [Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host

On 2 January 2013 14:34, Samuel Seay wrote: > I did not catch that, somehow I managed to invert the logic when looking at > it. Maybe a g2h() (such a macro exist? what would be the proper method?) > around the newsp value would do it. You want to use put_user() (without the __) -- this (a) takes

Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState

Am 05.12.2012 17:49, schrieb Eduardo Habkost: > This finally makes the CPU class a child of DeviceState, allowing us to > start using DeviceState properties on CPU subclasses. To avoid confusion with child<> properties and DeviceState vs. DeviceClass I have reworded this to "subclass of Device" in

[Qemu-devel] [PATCH 02/18] configure: add CONFIG_VIRTIO_BLK_DATA_PLANE

The virtio-blk-data-plane feature only works with Linux AIO. Therefore add a ./configure option and necessary checks to implement this dependency. Signed-off-by: Stefan Hajnoczi --- configure | 21 + 1 file changed, 21 insertions(+) diff --git a/configure b/configure index

[Qemu-devel] [PULL v2 00/18] Block patches

Paolo's include/ reorganization was merged and this pull request had conflicts. Resolved in v2. The following changes since commit 5928023cef87847a295035487397b9ec701fdd6b: pflash_cfi01: Suppress warning when Linux probes for AMD flash (2013-01-01 13:05:57 +0100) are available in the git repo

[Qemu-devel] [PATCH 09/18] iov: add qemu_iovec_concat_iov()

The qemu_iovec_concat() function copies a subset of a QEMUIOVector. The new qemu_iovec_concat_iov() function does the same for a iov/cnt pair. It is easy to define qemu_iovec_concat() in terms of qemu_iovec_concat_iov(). The existing code is mostly unchanged, except for the assertion src->size >

[Qemu-devel] [PATCH 10/18] virtio-blk: restore VirtIOBlkConf->config_wce flag

Two slightly different versions of a patch to conditionally set VIRTIO_BLK_F_CONFIG_WCE through the "config-wce" qdev property have been applied (ea776abca and eec7f96c2). David Gibson noticed that the "config-wce" property is broken as a result and fixed it recently. The fix sets the host_featu

[Qemu-devel] [PATCH 11/18] dataplane: add virtio-blk data plane code

virtio-blk-data-plane is a subset implementation of virtio-blk. It only handles read, write, and flush requests. It does this using a dedicated thread that executes an epoll(2)-based event loop and processes I/O using Linux AIO. This approach performs very well but can be used for raw image file

Re: [Qemu-devel] [PATCH 1/2] target-i386: kvm: -cpu host: use GET_SUPPORTED_CPUID for SVM features

On Wed, Jan 02, 2013 at 03:39:03PM +0100, Andreas Färber wrote: > Am 28.12.2012 19:37, schrieb Eduardo Habkost: > > The existing -cpu host code simply set every bit inside svm_features > > (initializing it to -1), and that makes it impossible to make the > > enforce/check options work properly when

Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: enable all supported KVM features for -cpu host

On Wed, Jan 02, 2013 at 03:52:45PM +0100, Igor Mammedov wrote: > On Fri, 28 Dec 2012 16:37:34 -0200 > Eduardo Habkost wrote: > > > When using -cpu host, we don't need to use the kvm_default_features > > variable, as the user is explicitly asking QEMU to enable all feature > > supported by the hos

[Qemu-devel] [PATCH 08/18] test-iov: add iov_discard_front/back() testcases

Signed-off-by: Stefan Hajnoczi --- tests/test-iov.c | 150 +++ 1 file changed, 150 insertions(+) diff --git a/tests/test-iov.c b/tests/test-iov.c index a480bc8..46e4ddd 100644 --- a/tests/test-iov.c +++ b/tests/test-iov.c @@ -250,11 +250,161 @@

Re: [Qemu-devel] [PATCH] pci-assign: Enable MSIX on device to match guest

On Fri, 2012-12-21 at 08:46 -0700, Alex Williamson wrote: > On Fri, 2012-12-21 at 14:17 +0200, Michael S. Tsirkin wrote: > > On Thu, Dec 20, 2012 at 03:15:38PM -0700, Alex Williamson wrote: > > > On Thu, 2012-12-20 at 18:38 +0200, Michael S. Tsirkin wrote: > > > > On Thu, Dec 20, 2012 at 09:05:50AM

Re: [Qemu-devel] [PATCH] qemu-jeos: Update .gitmodules

On Wed, Dec 19, 2012 at 12:54:25AM +0100, Andreas Färber wrote: > sources.redhat.com is timing out, use sourceware.org URL instead. > > Signed-off-by: Andreas Färber > --- > .gitmodules |2 +- > 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [Bug 1025244] Re: qcow2 image increasing disk size above the virtual limit

On Tue, Dec 18, 2012 at 10:18:20AM -, Andy Menzel wrote: > Any solution right now? I have a similar problem like Todor Andreev; > Our daily backup of some virtual machines (qcow2) looks like that: > > 1. shutdown the VM > 2. create a snapshot via: "qemu-img snapshot -c nameofsnapshot..." > 3.

Re: [Qemu-devel] [PATCH] spice: drop incorrect vm_change_state_handler() opaque

On Wed, Dec 19, 2012 at 02:07:16PM +0100, Stefan Hajnoczi wrote: > The spice_server pointer is a global variable and > vm_change_state_handler() therefore does not use its opaque parameter. > > The vm change state handler is added with a pointer to the spice_server > pointer. This is useless and

[Qemu-devel] [PATCH 16/18] block/raw-win32: Fix compiler warnings (wrong format specifiers)

From: Stefan Weil Commit fbcad04d6bfdff937536eb23088a01a280a1a3af added fprintf statements with wrong format specifiers. GetLastError() returns a DWORD which is unsigned long, so %lu must be used. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- block/raw-win32.c | 4 ++-- 1 fil

Re: [Qemu-devel] How to make TCP/IP applications run on guest OS?

On Wed, Dec 19, 2012 at 09:54:32PM +0800, GaoYi wrote: > Hi all, > >I have bridged the network of the host. There was one br0 and several > taps on it. When I started up a guest using: > > #kvm -hda ubuntu.img -localtime -m 1G -net nic, -net > tap,ifname=tap0,script=no >

[Qemu-devel] [PATCH 13/18] virtio-blk: Return UNSUPP for unknown request types

From: Alexey Zaytsev Currently, all unknown requests are treated as VIRTIO_BLK_T_IN Signed-off-by: Alexey Zaytsev Signed-off-by: Stefan Hajnoczi --- hw/virtio-blk.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 92c745a..df57b3

[Qemu-devel] [PATCH 12/18] virtio-blk: add x-data-plane=on|off performance feature

The virtio-blk-data-plane feature is easy to integrate into hw/virtio-blk.c. The data plane can be started and stopped similar to vhost-net. Users can take advantage of the virtio-blk-data-plane feature using the new -device virtio-blk-pci,x-data-plane=on property. The x-data-plane name was chos

Re: [Qemu-devel] [Bug 1025244] Re: qcow2 image increasing disk size above the virtual limit

On 01/02/2013 08:50 AM, Stefan Hajnoczi wrote: > On Tue, Dec 18, 2012 at 10:18:20AM -, Andy Menzel wrote: >> Any solution right now? I have a similar problem like Todor Andreev; >> Our daily backup of some virtual machines (qcow2) looks like that: >> >> 1. shutdown the VM >> 2. create a snapsho

[Qemu-devel] [PATCH 04/18] dataplane: add virtqueue vring code

The virtio-blk-data-plane cannot access memory using the usual QEMU functions since it executes outside the global mutex and the memory APIs are this time are not thread-safe. This patch introduces a virtqueue module based on the kernel's vhost vring code. The trick is that we map guest memory ah

[Qemu-devel] [PATCH] qga: add missing commas in json docs

* qga/qapi-schema.json: Use valid JSON. Signed-off-by: Eric Blake --- qga/qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index ed0eb69..d91d903 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -3

[Qemu-devel] [RFC V4 00/30] QCOW2 deduplication

This patchset is a cleanup of the previous QCOW2 deduplication rfc. One can compile and install https://github.com/wernerd/Skein3Fish and use the --enable-skein-dedup configure option in order to use the faster skein HASH. Images must be created with "-o dedup=[skein|sha256]" in order to activate

[Qemu-devel] [RFC V4 01/30] qcow2: Add deduplication to the qcow2 specification.

Signed-off-by: Benoit Canet --- docs/specs/qcow2.txt | 100 +- 1 file changed, 99 insertions(+), 1 deletion(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt index 36a559d..c9c0d47 100644 --- a/docs/specs/qcow2.txt +++ b/docs/specs/qcow2

[Qemu-devel] [RFC V4 04/30] qcow2: Make update_refcount public.

Signed-off-by: Benoit Canet --- block/qcow2-refcount.c |6 +- block/qcow2.h |2 ++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 6a95aa6..e014b0e 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refco

[Qemu-devel] [RFC V4 10/30] qcow2: Add qcow2_dedup_grow_table and use it.

Signed-off-by: Benoit Canet --- block/qcow2-dedup.c | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c index 7adaaba..b998a2d 100644 --- a/block/qcow2-dedup.c +++ b/block/qcow2-dedup.c @@ -38

[Qemu-devel] [RFC V4 15/30] qcow2: Add qcow2_dedup_init and qcow2_dedup_close.

Signed-off-by: Benoit Canet --- block/qcow2-dedup.c | 16 block/qcow2.h |2 ++ 2 files changed, 18 insertions(+) diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c index 4c391e5..12a2dad 100644 --- a/block/qcow2-dedup.c +++ b/block/qcow2-dedup.c @@ -986,3 +986,19

[Qemu-devel] [RFC V4 17/30] block: Add qemu-img dedup create option.

Signed-off-by: Benoit Canet --- block/qcow2.c | 113 +++-- block/qcow2.h |2 + include/block/block_int.h |1 + 3 files changed, 103 insertions(+), 13 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index ad399c8..91

[Qemu-devel] [RFC V4 21/30] qcow2: Add verification of dedup table.

Signed-off-by: Benoit Canet --- block/qcow2-refcount.c |8 1 file changed, 8 insertions(+) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index aef280d..7e6d02f 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -1156,6 +1156,14 @@ int qcow2_check_refc

[Qemu-devel] [PATCH 14/18] cutils: change strtosz_suffix_unit function

From: liguang if value to be translated is larger than INT64_MAX, this function will not be convenient for caller to be aware of it, so change a little for this. Signed-off-by: liguang Signed-off-by: Stefan Hajnoczi --- cutils.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) dif

[Qemu-devel] [RFC V4 19/30] qcow2: Integrate deduplication in qcow2_co_writev loop.

Signed-off-by: Benoit Canet --- block/qcow2.c | 85 +++-- 1 file changed, 83 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 9130638..54c8847 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -328,6 +328,7 @@ st

[Qemu-devel] [PATCH 05/18] dataplane: add event loop

Outside the safety of the global mutex we need to poll on file descriptors. I found epoll(2) is a convenient way to do that, although other options could replace this module in the future (such as an AioContext-based loop or glib's GMainLoop). One important feature of this small event loop implem

[Qemu-devel] [RFC V4 25/30] qcow2: Integrate SKEIN hash algorithm in deduplication.

Signed-off-by: Benoit Canet --- block/qcow2-dedup.c | 14 ++ block/qcow2.c |5 + configure | 33 + 3 files changed, 52 insertions(+) diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c index 28001c6..bd8397e 100644 --- a/

[Qemu-devel] [RFC V4 20/30] qcow2: Serialize write requests when deduplication is activated.

This fix the sub cluster sized writes race conditions while waiting for a more faster solution. Signed-off-by: Benoit Canet --- block/qcow2.c |9 + block/qcow2.h |1 + 2 files changed, 10 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index 54c8847..13f6a5c 100644 ---

[Qemu-devel] [RFC V4 29/30] qcow2: init and cleanup deduplication.

Signed-off-by: Benoit Canet --- block/qcow2-dedup.c | 78 +++ block/qcow2.c | 17 --- 2 files changed, 86 insertions(+), 9 deletions(-) diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c index bd8397e..da1a668 100644 --- a/blo

[Qemu-devel] [RFC V4 22/30] qcow2: Adapt checking of QCOW_OFLAG_COPIED for dedup.

Signed-off-by: Benoit Canet --- block/qcow2-refcount.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 7e6d02f..9aef608 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -1001,7 +1001,14 @@ stat

[Qemu-devel] [Bug 1091766] Re: Physical host crash with Mellanox IB PCI passthrough

Just a silly questions, because I don't know the deveploment process in QEMU project -- can be your patches commited into project's VCS so that new stable release contains them and doesn't fail again? Thank you! -- You received this bug notification because you are a member of qemu- devel-ml, wh

[Qemu-devel] [RFC V4 30/30] qemu-iotests: Filter dedup=on/off so existing tests don't break.

Signed-off-by: Benoit Canet --- tests/qemu-iotests/common.rc |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index aef5f52..72e746d 100644 --- a/tests/qemu-iotests/common.rc +++ b/tests/qemu-iotests/common.rc @@

[Qemu-devel] [RFC V4 28/30] qcow: Set dedup cluster block size to 64KB.

Signed-off-by: Benoit Canet --- block/qcow2-refcount.c |4 ++-- block/qcow2.c |1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 092546d..3f3efd8 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount

[Qemu-devel] [RFC V4 14/30] qcow2-cache: Allow to choose table size at creation.

Signed-off-by: Benoit Canet --- block/qcow2-cache.c | 12 +++- block/qcow2.c |5 +++-- block/qcow2.h |3 ++- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c index 2f3114e..83f2814 100644 --- a/block/qcow2-cach

[Qemu-devel] [RFC V4 27/30] qcow2: Use large L2 table for deduplication.

Signed-off-by: Benoit Canet --- block/qcow2-cluster.c |2 +- block/qcow2-refcount.c | 22 +++--- block/qcow2.c |8 ++-- 3 files changed, 22 insertions(+), 10 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 07037a0..d69af17 100

[Qemu-devel] [PATCH 06/18] dataplane: add Linux AIO request queue

The IOQueue has a pool of iocb structs and a function to add new read/write requests. Multiple requests can be added before calling the submit function to actually tell the host kernel to begin I/O. This allows callers to batch requests and submit them in one go. The actual I/O is performed usin

[Qemu-devel] [RFC V4 09/30] qcow2: Extract qcow2_dedup_grow_table

Signed-off-by: Benoit Canet --- block/qcow2-cluster.c | 102 +++-- block/qcow2-dedup.c |3 +- block/qcow2.h |6 +++ 3 files changed, 71 insertions(+), 40 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 6

[Qemu-devel] [Bug 1091766] Re: Physical host crash with Mellanox IB PCI passthrough

I'm currently trying to make that happen, starting with the patches in comments 2 & 3 and moving to something like the patch in comment 8 in the development branch. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpa

[Qemu-devel] [RFC V4 12/30] qcow2: Load and save deduplication table header extension.

Signed-off-by: Benoit Canet --- block/qcow2.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index 410d3c1..9a7177b 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -53,9 +53,16 @@ typedef struct { uint32_t len; }

[Qemu-devel] [RFC V4 05/30] qcow2: Create a way to link to l2 tables when deduplicating.

Signed-off-by: Benoit Canet --- block/qcow2-cluster.c |8 ++-- block/qcow2.h |9 + 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 56fccf9..63a7241 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-

[Qemu-devel] [RFC V4 16/30] qcow2: Extract qcow2_add_feature and qcow2_remove_feature.

Signed-off-by: Benoit Canet --- block/qcow2.c | 49 ++--- block/qcow2.h |4 ++-- 2 files changed, 32 insertions(+), 21 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 499e939..ad399c8 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @

[Qemu-devel] [RFC V4 08/30] qcow2: Implement qcow2_compute_cluster_hash.

Add detection of libgnutls used to compute SHA256 hashes Signed-off-by: Benoit Canet --- block/qcow2-dedup.c | 13 - configure | 22 ++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c index 2a4

Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState

On Wed, 02 Jan 2013 16:08:42 +0100 Andreas Färber wrote: > Am 05.12.2012 17:49, schrieb Eduardo Habkost: > > This finally makes the CPU class a child of DeviceState, allowing us to > > start using DeviceState properties on CPU subclasses. > > To avoid confusion with child<> properties and Device

Re: [Qemu-devel] [RFC V4 30/30] qemu-iotests: Filter dedup=on/off so existing tests don't break.

On 01/02/2013 09:16 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > tests/qemu-iotests/common.rc |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc > index aef5f52..72e746d 100644 > --- a/tests/q

[Qemu-devel] [PATCH 03/18] dataplane: add host memory mapping code

The data plane thread needs to map guest physical addresses to host pointers. Normally this is done with cpu_physical_memory_map() but the function assumes the global mutex is held. The data plane thread does not touch the global mutex and therefore needs a thread-safe memory mapping mechanism.

[Qemu-devel] [RFC V4 06/30] qcow2: Add qcow2_dedup and related functions

Signed-off-by: Benoit Canet --- block/qcow2-dedup.c | 436 +++ block/qcow2.h |5 + 2 files changed, 441 insertions(+) diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c index 4e99eb1..5901749 100644 --- a/block/qcow2-dedup.c +++ b/bl

[Qemu-devel] [RFC V4 03/30] qcow2: Add qcow2_dedup_read_missing_and_concatenate

This function is used to read missing data when unaligned writes are done. This function also concatenate missing data with the given qiov data in order to prepare a buffer used to look for duplicated clusters. Signed-off-by: Benoit Canet --- block/Makefile.objs |1 + block/qcow2-dedup.c |

[Qemu-devel] [RFC V4 07/30] qcow2: Add qcow2_dedup_store_new_hashes.

Signed-off-by: Benoit Canet --- block/qcow2-dedup.c | 315 ++- block/qcow2.h |5 + 2 files changed, 319 insertions(+), 1 deletion(-) diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c index 5901749..2a444f5 100644 --- a/block/qcow2-d

Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState

On Wed, Jan 02, 2013 at 05:40:58PM +0100, Igor Mammedov wrote: > On Wed, 02 Jan 2013 16:08:42 +0100 > Andreas Färber wrote: > > > Am 05.12.2012 17:49, schrieb Eduardo Habkost: > > > This finally makes the CPU class a child of DeviceState, allowing us to > > > start using DeviceState properties on

[Qemu-devel] [RFC V4 24/30] qcow2: Do not overwrite existing entries with QCOW_OFLAG_COPIED.

In the case of a race condition between two writes a l2 entry can be written without QCOW_OFLAG_COPIED before the first write fill it. This patch simply check if the l2 entry has the correct offset without QCOW_OFLAG_COPIED and do nothing. Signed-off-by: Benoit Canet --- block/qcow2-cluster.c |

[Qemu-devel] [RFC V4 26/30] qcow2: Add lazy refcounts to deduplication to prevent qcow2_cache_set_dependency loops

Signed-off-by: Benoit Canet --- block/qcow2.c |1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2.c b/block/qcow2.c index 0154d50..f66e67d 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1606,6 +1606,7 @@ static int qcow2_create(const char *filename, QEMUOptionParameter *option

Re: [Qemu-devel] [RFC V4 30/30] qemu-iotests: Filter dedup=on/off so existing tests don't break.

Ack. There is more than one patch to move. I'll do in for the next RFC. Regards Benoît Le Wednesday 02 Jan 2013 à 09:42:06 (-0700), Eric Blake a écrit : > On 01/02/2013 09:16 AM, Benoît Canet wrote: > > Signed-off-by: Benoit Canet > > --- > > tests/qemu-iotests/common.rc |3 ++- > > 1 fil

[Qemu-devel] [PATCH 15/18] qemu-img: report size overflow error message

From: liguang qemu-img will complain when qcow or qcow2 size overflow for 64 bits, report the right message in this condition. $./qemu-img create -f qcow2 /tmp/foo 0x1 before change: qemu-img: Invalid image size specified! You may use k, M, G or T suffixes for qemu-img: kilobytes

[Qemu-devel] [PATCH 17/18] sheepdog: don't update inode when create_and_write fails

From: Liu Yuan For the error case such as SD_RES_NO_SPACE, we shouldn't update the inode bitmap to avoid the scenario that the object is allocated but wasn't created at the server side. This will result in VM's IO error on the failed object. Cc: MORITA Kazutaka Cc: Kevin Wolf Signed-off-by: Li

Re: [Qemu-devel] [PATCH 6/6] usb-tablet: Allow connecting to ehci

Hi, On 12/30/2012 12:55 PM, Erik Rull wrote: Hi Hans, Hans de Goede wrote: Hi, On 12/26/2012 01:07 PM, Erik Rull wrote: Hi Gerd, hi Hans, is my assumption correct that if I check out and compile this version from GIT master that the usb-tablet device is automatically routed to ehci without

[Qemu-devel] [PATCH 07/18] iov: add iov_discard_front/back() to remove data

The iov_discard_front/back() functions remove data from the front or back of the vector. This is useful when peeling off header/footer structs. Signed-off-by: Stefan Hajnoczi --- include/qemu/iov.h | 13 + iov.c | 51 +++

[Qemu-devel] [RFC V4 18/30] qcow2: Behave correctly when refcount reach 0 or 2^16.

When refcount reach zero we destroy the hash on disk and remove it from GTree. When refcount is at it's maximum value we mark the hash so it won't be loaded at next startup and remove it from GTree. Signed-off-by: Benoit Canet --- block/qcow2-dedup.c| 79 +++

[Qemu-devel] [RFC V4 11/30] qcow2: create function to load deduplication hashes at startup.

Signed-off-by: Benoit Canet --- block/qcow2-dedup.c | 68 +++ block/qcow2.h |1 + 2 files changed, 69 insertions(+) diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c index b998a2d..4c391e5 100644 --- a/block/qcow2-dedup.c +++ b/blo

Re: [Qemu-devel] [PATCH 0/2] [PULL] qemu-kvm.git uq/master queue

Gleb Natapov writes: > The following changes since commit e376a788ae130454ad5e797f60cb70d0308babb6: > > Merge remote-tracking branch 'kwolf/for-anthony' into staging (2012-12-13 > 14:32:28 -0600) > > are available in the git repository at: > > > git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm

Re: [Qemu-devel] [PULL] pci,virtio

"Michael S. Tsirkin" writes: > Included here is v3 virtio typesafety change - no comments > were made to v3 - I made my best to address all comment > and got no response to v3 so I assume it's OK now. > > There are more optimizations in my tree but > they are a bit more scary - I'll let them > st

Re: [Qemu-devel] [PULL 0/1] update seabios

Gerd Hoffmann writes: > Hi, > > One more seabios update, fixing the FreeBSD build failure. > > please pull, > Gerd > Pulled. Thanks. Regards, Anthony Liguori > The following changes since commit 914606d26e654d4c01bd5186f4d05e3fd445e219: > > Merge remote-tracking branch 'stefanha/trivial

[Qemu-devel] [PATCH 01/18] raw-posix: add raw_get_aio_fd() for virtio-blk-data-plane

The raw_get_aio_fd() function allows virtio-blk-data-plane to get the file descriptor of a raw image file with Linux AIO enabled. This interface is really a layering violation that can be resolved once the block layer is able to run outside the global mutex - at that point virtio-blk-data-plane wi

Re: [Qemu-devel] [PULL 0/1] update seabios

are you going to distribute a 1.3.x snapshot with the updated bios that lets FreeBSD boot ? thanks luigi On Wed, Jan 2, 2013 at 5:57 PM, Anthony Liguori wrote: > Gerd Hoffmann writes: > > > Hi, > > > > One more seabios update, fixing the FreeBSD build failure. > > > > please pull, > > Gerd

  1   2   >