On 2 January 2013 14:34, Samuel Seay <lightnin...@gmail.com> wrote: > I did not catch that, somehow I managed to invert the logic when looking at > it. Maybe a g2h() (such a macro exist? what would be the proper method?) > around the newsp value would do it.
You want to use put_user() (without the __) -- this (a) takes a guest address and (b) does the error checking for unwritable address, which __put_user does not. [Don't be fooled by all the err |= __put_user code, this is bogus because __put_user never fails.] > I'll redo that this evening and attempt > to submit a newer patch. Considering I don't have direct internet access in > the VM, any suggestions to make everyone happy on the patch submission? Use git format-patch in the VM to write the patch to file, copy the file out of the VM and use git send-email to actually send it. -- PMM
