[Qemu-devel] [Bug 1091115] [NEW] qemu-1.3.0 crashes when installing windows xp

2012-12-17 Thread LazySid
Public bug reported: These are the commands: $git checkout v1.3.0 $./configure --prefix=/home/user/tmp --target-list=i386-softmmu --enable-sdl --disable-curses --disable-vnc --enable-kvm --disable-docs $make $make install In /home/user/tmp directory: $./bin/qemu-img create imgs/winxp.img 4G $./bi

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-17 Thread Jens Freimann
On Sun, Dec 16, 2012 at 04:30:21PM +0100, Andreas Färber wrote: > Am 14.12.2012 17:46, schrieb Jens Freimann: > > Add a CPU reset handler to have all CPUs in a PoP compliant > > state. > > > > Signed-off-by: Jens Freimann > > The logic looks okay now. Some comments inline. > > > --- > > v2 -> v

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-17 Thread Wenchao Xia
于 2012-12-17 15:52, Dietmar Maurer 写道: 于 2012-12-17 14:36, Dietmar Maurer 写道: This patch is the implemention of transaction based snapshot internal API. What exactly is the advantage of using qmp transactions (as opposed to the pve snapshot patches)? Which pve snapshot patches you re

Re: [Qemu-devel] [PATCH v7 03/12] dataplane: add host memory mapping code

2012-12-17 Thread Stefan Hajnoczi
On Fri, Dec 14, 2012 at 9:34 PM, Blue Swirl wrote: > On Fri, Dec 14, 2012 at 6:00 PM, Stefan Hajnoczi wrote: >> +typedef struct { >> +void *host_addr; >> +hwaddr guest_addr; >> +uint64_t size; >> +bool readonly; >> +} HostmemRegion; > > This should be HostMemRegion. > >> + >> +typ

Re: [Qemu-devel] [PATCH v6 03/12] dataplane: add host memory mapping code

2012-12-17 Thread Stefan Hajnoczi
On Sun, Dec 16, 2012 at 06:11:14PM +0200, Michael S. Tsirkin wrote: > On Fri, Dec 14, 2012 at 12:45:16PM +0100, Stefan Hajnoczi wrote: > > On Wed, Dec 12, 2012 at 4:49 PM, Michael S. Tsirkin wrote: > > > On Wed, Dec 12, 2012 at 04:34:21PM +0100, Stefan Hajnoczi wrote: > > >> On Tue, Dec 11, 2012 a

Re: [Qemu-devel] [PATCH v2] qxl+vnc: register a vm state change handler for dummy spice_server

2012-12-17 Thread Gerd Hoffmann
On 12/12/12 17:30, Uri Lublin wrote: > When qxl + vnc are used, a dummy spice_server is initialized. > The spice_server has to be told when the VM runstate changes, > which is what this patch does. > > Without it, from qxl_send_events(), the following error message is shown: > qxl_send_events: s

Re: [Qemu-devel] [PATCH 0/2] virtio: reset all qbuses too when writing to the status field

2012-12-17 Thread Paolo Bonzini
Il 16/12/2012 22:15, Michael S. Tsirkin ha scritto: >> A PCI bus reset (or FLR) calls pci_device_reset which does this >> >> void pci_device_reset(PCIDevice *dev) >> { >> int r; >> >> qdev_reset_all(&dev->qdev); >> ... >> } >> >> This is exactly how a PCI bus reset clears pending MSIX v

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-17 Thread Dietmar Maurer
> >>> Seems this makes it impossible to use external commands to make > >> snapshots? > >>> > >> what command? can you tip more about the case? > > > > For example, nexenta storage provides an API to create snapshots. We > > want to use that. Another example would be to use lvcreate to create l

[Qemu-devel] [PATCH v8 01/12] raw-posix: add raw_get_aio_fd() for virtio-blk-data-plane

2012-12-17 Thread Stefan Hajnoczi
The raw_get_aio_fd() function allows virtio-blk-data-plane to get the file descriptor of a raw image file with Linux AIO enabled. This interface is really a layering violation that can be resolved once the block layer is able to run outside the global mutex - at that point virtio-blk-data-plane wi

[Qemu-devel] [PATCH v8 07/12] iov: add iov_discard_front/back() to remove data

2012-12-17 Thread Stefan Hajnoczi
The iov_discard_front/back() functions remove data from the front or back of the vector. This is useful when peeling off header/footer structs. Signed-off-by: Stefan Hajnoczi --- iov.c | 51 +++ iov.h | 13 + 2 files changed, 64 insert

[Qemu-devel] [PATCH v8 12/12] virtio-blk: add x-data-plane=on|off performance feature

2012-12-17 Thread Stefan Hajnoczi
The virtio-blk-data-plane feature is easy to integrate into hw/virtio-blk.c. The data plane can be started and stopped similar to vhost-net. Users can take advantage of the virtio-blk-data-plane feature using the new -device virtio-blk-pci,x-data-plane=on property. The x-data-plane name was chos

[Qemu-devel] [PATCH v8 11/12] dataplane: add virtio-blk data plane code

2012-12-17 Thread Stefan Hajnoczi
virtio-blk-data-plane is a subset implementation of virtio-blk. It only handles read, write, and flush requests. It does this using a dedicated thread that executes an epoll(2)-based event loop and processes I/O using Linux AIO. This approach performs very well but can be used for raw image file

[Qemu-devel] [PATCH v8 02/12] configure: add CONFIG_VIRTIO_BLK_DATA_PLANE

2012-12-17 Thread Stefan Hajnoczi
The virtio-blk-data-plane feature only works with Linux AIO. Therefore add a ./configure option and necessary checks to implement this dependency. Signed-off-by: Stefan Hajnoczi --- configure | 21 + 1 file changed, 21 insertions(+) diff --git a/configure b/configure index

[Qemu-devel] [PATCH v8 04/12] dataplane: add virtqueue vring code

2012-12-17 Thread Stefan Hajnoczi
The virtio-blk-data-plane cannot access memory using the usual QEMU functions since it executes outside the global mutex and the memory APIs are this time are not thread-safe. This patch introduces a virtqueue module based on the kernel's vhost vring code. The trick is that we map guest memory ah

[Qemu-devel] [PATCH v8 00/12] virtio: virtio-blk data plane

2012-12-17 Thread Stefan Hajnoczi
Note: v8 is a small change, if you have reviewed v7 then the code is almost totally unchanged. This series adds the -device virtio-blk-pci,x-data-plane=on property that enables a high performance I/O codepath. A dedicated thread is used to process virtio-blk requests outside the global mutex and

[Qemu-devel] [PATCH v8 03/12] dataplane: add host memory mapping code

2012-12-17 Thread Stefan Hajnoczi
The data plane thread needs to map guest physical addresses to host pointers. Normally this is done with cpu_physical_memory_map() but the function assumes the global mutex is held. The data plane thread does not touch the global mutex and therefore needs a thread-safe memory mapping mechanism.

[Qemu-devel] [PATCH v8 09/12] iov: add qemu_iovec_concat_iov()

2012-12-17 Thread Stefan Hajnoczi
The qemu_iovec_concat() function copies a subset of a QEMUIOVector. The new qemu_iovec_concat_iov() function does the same for a iov/cnt pair. It is easy to define qemu_iovec_concat() in terms of qemu_iovec_concat_iov(). The existing code is mostly unchanged, except for the assertion src->size >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 11/13] pseries: Fixes and enhancements to L1 cache properties

2012-12-17 Thread Alexander Graf
On 17.12.2012, at 03:32, David Gibson wrote: > On Thu, Dec 13, 2012 at 01:50:25PM +0100, Alexander Graf wrote: >> >> On 04.12.2012, at 03:42, David Gibson wrote: >> >>> PAPR requires that the device tree's CPU nodes have several properties >>> with information about the L1 cache. We created

Re: [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API

2012-12-17 Thread Dietmar Maurer
> Next commit will re-enable balloon stats with a different interface, but this > old code conflicts with it. Let's drop it. I don't really see any conflicts here? > It's important to note that the QMP and HMP interfaces are also dropped by > this commit. That shouldn't be a problem though, becau

[Qemu-devel] [PATCH v8 10/12] virtio-blk: restore VirtIOBlkConf->config_wce flag

2012-12-17 Thread Stefan Hajnoczi
Two slightly different versions of a patch to conditionally set VIRTIO_BLK_F_CONFIG_WCE through the "config-wce" qdev property have been applied (ea776abca and eec7f96c2). David Gibson noticed that the "config-wce" property is broken as a result and fixed it recently. The fix sets the host_featu

[Qemu-devel] [PATCH v8 05/12] dataplane: add event loop

2012-12-17 Thread Stefan Hajnoczi
Outside the safety of the global mutex we need to poll on file descriptors. I found epoll(2) is a convenient way to do that, although other options could replace this module in the future (such as an AioContext-based loop or glib's GMainLoop). One important feature of this small event loop implem

[Qemu-devel] [PATCH v8 06/12] dataplane: add Linux AIO request queue

2012-12-17 Thread Stefan Hajnoczi
The IOQueue has a pool of iocb structs and a function to add new read/write requests. Multiple requests can be added before calling the submit function to actually tell the host kernel to begin I/O. This allows callers to batch requests and submit them in one go. The actual I/O is performed usin

[Qemu-devel] [PATCH v8 08/12] test-iov: add iov_discard_front/back() testcases

2012-12-17 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- tests/test-iov.c | 150 +++ 1 file changed, 150 insertions(+) diff --git a/tests/test-iov.c b/tests/test-iov.c index cbe7a89..720d95c 100644 --- a/tests/test-iov.c +++ b/tests/test-iov.c @@ -250,11 +250,161 @@

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-17 Thread Dietmar Maurer
> > For example, nexenta storage provides an API to create snapshots. We > > want to use that. Another example would be to use lvcreate to create lvm > snapshots. > > >I am not familar with those tools You do not know LVM?

Re: [Qemu-devel] [PATCH v2 3/4] usb/ehci: Add SysBus EHCI device for Exynos4210

2012-12-17 Thread Igor Mitsyanko
On 12/16/2012 07:49 AM, Andreas Färber wrote: It uses a different capsbase and opregbase than the Xilinx device. Signed-off-by: Liming Wang Signed-off-by: Andreas Färber Cc: Igor Mitsyanko --- hw/usb/hcd-ehci-sysbus.c | 15 +++ hw/usb/hcd-ehci.h|2 ++ 2 Dateien

Re: [Qemu-devel] [PULLv2] pci,net,misc infrastructure

2012-12-17 Thread Michael S. Tsirkin
On Sun, Dec 16, 2012 at 11:11:37PM +0200, Michael S. Tsirkin wrote: > The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: > > Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2012-12-10 > 08:35:15 -0600) > > are available in the git repository at: > > >

Re: [Qemu-devel] [PULL] pci,net,misc infrastructure

2012-12-17 Thread Michael S. Tsirkin
On Mon, Dec 17, 2012 at 11:59:59AM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Fri, Dec 14, 2012 at 09:37:17PM +, Blue Swirl wrote: > >> Perhaps the use of '-' vs. '_' in file names could be unified while > >> renaming. I think most new files use dash. > > Yes, pl

Re: [Qemu-devel] [PULL] pci,net,misc infrastructure

2012-12-17 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Fri, Dec 14, 2012 at 09:37:17PM +, Blue Swirl wrote: >> Perhaps the use of '-' vs. '_' in file names could be unified while >> renaming. I think most new files use dash. Yes, please! > I can do this in a follow up patch but first let's put this rule in > co

Re: [Qemu-devel] [PATCH v2 0/3] re-enable balloon stats

2012-12-17 Thread Luiz Capitulino
On Sat, 15 Dec 2012 07:19:13 + Dietmar Maurer wrote: > > - drop qmp & hmp interface of old stats code > > I think the old interface is not that bad (the new one is clumsy, because > we need 6 qmp call instead of one to get all stats). Can't > we try to make it functional and keep it? No, b

[Qemu-devel] [PULL] Xen fixes and multiple consoles

2012-12-17 Thread Stefano Stabellini
Hi Anthony, please pull the following branch based on a8a826a3c3b8c8a1c4def0e9e22b46e78e6163a0: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-20121217 It contains several fixes and multiple consoles support in the Xen PV console backend. Ian Jackson (2): cpu_ioreq_pio

Re: [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API

2012-12-17 Thread Luiz Capitulino
On Mon, 17 Dec 2012 10:13:40 + Dietmar Maurer wrote: > > Next commit will re-enable balloon stats with a different interface, but > > this > > old code conflicts with it. Let's drop it. > > I don't really see any conflicts here? query-balloon resets all stats to -1. So, if it's issued afte

Re: [Qemu-devel] QMP command implementation help

2012-12-17 Thread Luiz Capitulino
On Mon, 17 Dec 2012 11:21:10 +0530 Shraddha Kamat wrote: > I am implementing couple of QMP commands to Qemu - so trying a > hello-world command first as shown here > https://github.com/qemu/qemu/blob/master/docs/writing-qmp-commands.txt > > Step 1 : > > Added to qapi-schema.json file t

Re: [Qemu-devel] [PATCH v2 0/3] re-enable balloon stats

2012-12-17 Thread Dietmar Maurer
> Let me try once more to explain our options and why I think this is series is > our best choice. > > Basically, we have try options: > > 1. Add stats to query-balloon > > This breaks existing clients, because query-balloon is a synchronous > command that returns immediately. If we add stats to

Re: [Qemu-devel] [PATCH v2 0/3] re-enable balloon stats

2012-12-17 Thread Luiz Capitulino
On Mon, 17 Dec 2012 12:17:28 + Dietmar Maurer wrote: > > Let me try once more to explain our options and why I think this is series > > is > > our best choice. > > > > Basically, we have try options: > > > > 1. Add stats to query-balloon > > > > This breaks existing clients, because query

Re: [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API

2012-12-17 Thread Dietmar Maurer
> > I don't really see any conflicts here? > > query-balloon resets all stats to -1. So, if it's issued after the stats have > been > polled all values are lost. I can't see that in the code. I also tested with my patch, and it does not reset any stats. So I can't see that conflict? There is no

Re: [Qemu-devel] [PATCH v2 0/3] re-enable balloon stats

2012-12-17 Thread Dietmar Maurer
> > No, there is no need to wait (see my patch). > > It has problems, replied to it. Please can you post a test case which show those problems? I simply can't reproduce any problem you mention.

Re: [Qemu-devel] [PULL] pci,net,misc infrastructure

2012-12-17 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Dec 17, 2012 at 11:59:59AM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Fri, Dec 14, 2012 at 09:37:17PM +, Blue Swirl wrote: >> >> Perhaps the use of '-' vs. '_' in file names could be unified while >> >> renaming. I think

Re: [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API

2012-12-17 Thread Luiz Capitulino
On Mon, 17 Dec 2012 12:23:59 + Dietmar Maurer wrote: > > > I don't really see any conflicts here? > > > > query-balloon resets all stats to -1. So, if it's issued after the stats > > have been > > polled all values are lost. > > I can't see that in the code. I also tested with my patch, an

Re: [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API

2012-12-17 Thread Dietmar Maurer
> > There is no code to reset stats inside virtio_balloon_stat() > > static void virtio_balloon_stat(void *opaque, BalloonInfo *info) { > VirtIOBalloon *dev = opaque; > > #if 0 > /* Disable guest-provided stats for now. For more details please check: > * https://bugzilla.redhat.com/s

Re: [Qemu-devel] [PATCH v2 0/3] re-enable balloon stats

2012-12-17 Thread Luiz Capitulino
On Mon, 17 Dec 2012 12:26:34 + Dietmar Maurer wrote: > > > No, there is no need to wait (see my patch). > > > > It has problems, replied to it. > > Please can you post a test case which show those problems? I simply can't > reproduce any problem you mention. Which problems are you referri

Re: [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API

2012-12-17 Thread Luiz Capitulino
On Mon, 17 Dec 2012 12:36:59 + Dietmar Maurer wrote: > > > There is no code to reset stats inside virtio_balloon_stat() > > > > static void virtio_balloon_stat(void *opaque, BalloonInfo *info) { > > VirtIOBalloon *dev = opaque; > > > > #if 0 > > /* Disable guest-provided stats for n

Re: [Qemu-devel] [PATCH v2 0/3] re-enable balloon stats

2012-12-17 Thread Dietmar Maurer
> Since the beginning of this thread I've tried to respond you and provide you > all information I have, but all I heard from you is "show me", "I don't see > it" > and "I want it implemented my way, period". > > That's by far not productive. I event sent you a working patch! Anyways - I also g

Re: [Qemu-devel] [PATCH 00/11] qdev: correct reference counting

2012-12-17 Thread Paolo Bonzini
Il 05/12/2012 21:44, Paolo Bonzini ha scritto: > This series makes the ref_count field of device and bus objects actually > match the number of references that the objects have. Once this is done, > qdev_free and qbus_free are equivalent to simply object_unparent, and > object_delete can go. > >

Re: [Qemu-devel] [PATCH 1/1] virtio-serial-bus: send_control_msg should not deal with cpkts

2012-12-17 Thread Markus Armbruster
Amit Shah writes: > Stuff the cpkt before calling send_control_msg(). it should not be > concerned about contents, just send across the buffer. > > A few code refactorings recently have made mkaing this change easier > than earlier. > > Coverity and clang have flagged this code several times in

Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking

2012-12-17 Thread Gerd Hoffmann
On 12/14/12 14:35, Hans de Goede wrote: > Note that a shadow variable is used instead of changing frindex to > uframe accuracy because we must send a frindex which is a multiple of 8 > during migration for migration compatibility, and rounding it down to > a multiple of 8 pre-migration, can lead to

[Qemu-devel] [Bug 1090837] Re: Error in building Qemu-1.3.0 on Solaris 10

2012-12-17 Thread Dipanjan Das
I did the following and it was a success: 1. Added sh to path to override default /usr/bin/sh: PATH=/usr/xpg4/bin/sh:$PATH 2. From bash: sh ./configure -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1

[Qemu-devel] [PATCH 8/8] docs: add spice-port-fqdn.txt

2012-12-17 Thread Gerd Hoffmann
From: Marc-André Lureau Start a simple org.qemu.* registry of well known name. Signed-off-by: Gerd Hoffmann --- docs/spice-port-fqdn.txt | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) create mode 100644 docs/spice-port-fqdn.txt diff --git a/docs/spice-port-fqdn

[Qemu-devel] [PATCH 7/8] spice-qemu-char: register spicevmc ports during qemu_spice_init()

2012-12-17 Thread Gerd Hoffmann
From: Marc-André Lureau Do the delayed registration of spicevmc ports after Spice server is initialized. Signed-off-by: Gerd Hoffmann --- spice-qemu-char.c | 12 ui/qemu-spice.h |1 + ui/spice-core.c |4 3 files changed, 17 insertions(+), 0 deletions(-) diff --

Re: [Qemu-devel] [PATCH v2 1/4] usb/ehci: Clean up SysBus and PCI EHCI split

2012-12-17 Thread Gerd Hoffmann
On 12/16/12 04:49, Andreas Färber wrote: > SysBus EHCI was introduced in a hurry before 1.3 Soft Freeze. > To use QOM casts in place of DO_UPCAST() / FROM_SYSBUS(), we need an > identifying type. Introduce generic abstract base types for PCI and > SysBus EHCI to allow multiple types to access the s

[Qemu-devel] [PULL 0/8] spice patch queue

2012-12-17 Thread Gerd Hoffmann
Hi, This is the spice patch queue, bringing two bugfixes and chardev redirection over spice. please pull, Gerd The following changes since commit a8a826a3c3b8c8a1c4def0e9e22b46e78e6163a0: exec: refactor cpu_restore_state (2012-12-16 08:35:24 +) are available in the git repository at:

[Qemu-devel] [PATCH 3/8] spice-qemu-char: write to chardev whatever amount it can read

2012-12-17 Thread Gerd Hoffmann
From: Marc-André Lureau The current code waits until the chardev can read MIN(len, VMC_MAX) But some chardev may never reach than amount, in fact some of them will only ever accept write of 1. Fix the min computation and remove the VMC_MAX constant. Signed-off-by: Gerd Hoffmann --- spice-qemu-

[Qemu-devel] [PATCH 1/8] qxl: save qemu_create_displaysurface_from result

2012-12-17 Thread Gerd Hoffmann
Spotted by Coverity. https://bugzilla.redhat.com/show_bug.cgi?id=885644 Cc: qemu-sta...@nongnu.org Reported-by: Markus Armbruster Signed-off-by: Gerd Hoffmann --- hw/qxl-render.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/qxl-render.c b/hw/qxl-render.

[Qemu-devel] [PATCH 6/8] spice-qemu-char: keep a list of spice chardev

2012-12-17 Thread Gerd Hoffmann
From: Marc-André Lureau Signed-off-by: Gerd Hoffmann --- spice-qemu-char.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index 4be75ba..4eb85ae 100644 --- a/spice-qemu-char.c +++ b/spice-qemu-char.c @@ -24,8 +24,12 @@ typede

[Qemu-devel] [PATCH 4/8] spice-qemu-char: factor out CharDriverState creation

2012-12-17 Thread Gerd Hoffmann
From: Marc-André Lureau Make the CharDriverState creation code reusable by spicevmc port. Signed-off-by: Gerd Hoffmann --- spice-qemu-char.c | 37 +++-- 1 files changed, 23 insertions(+), 14 deletions(-) diff --git a/spice-qemu-char.c b/spice-qemu-char.c inde

[Qemu-devel] [PATCH 2/8] qxl+vnc: register a vm state change handler for dummy spice_server

2012-12-17 Thread Gerd Hoffmann
From: Uri Lublin When qxl + vnc are used, a dummy spice_server is initialized. The spice_server has to be told when the VM runstate changes, which is what this patch does. Without it, from qxl_send_events(), the following error message is shown: qxl_send_events: spice-server bug: guest stopped

[Qemu-devel] [PATCH 02/10] ide: Move IDEDevice pointer from IDEBus to IDEState

2012-12-17 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/ide/core.c | 2 +- hw/ide/internal.h | 3 +-- hw/ide/qdev.c | 12 +++- 3 files changed, 5 insertions(+), 12 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 2c0c978..1e94dc4 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@

[Qemu-devel] [PATCH 00/10] Drop code for non-qdevified IDE, and clean up

2012-12-17 Thread Markus Armbruster
*** Important *** This *breaks* all non-qdevified controllers, see PATCH 01/10. Maintainers are cc'ed. If you want still more time to qdevify your controller, please speak up now, and tell us how much. The rest of the series is obvious cleanups enabled by dropping the special case of a non-qdevif

[Qemu-devel] [PATCH 10/10] ide: Drop redundant IDEState member wwn

2012-12-17 Thread Markus Armbruster
It's a copy of dev->wwn. The copy was needed for non-qdevified controllers, which lacked dev. Note that pci_piix3_xen_ide_unplug() did not clear the copy (it only cleared the copy of bs). Begs the question whether stale data could have been used after unplug. As far as I can tell, the copy was

[Qemu-devel] [PATCH 08/10] ide: Drop redundant IDEState member drive_serial_str

2012-12-17 Thread Markus Armbruster
It's a copy of dev->serial. The copy was needed for non-qdevified controllers, which lacked dev. Note that pci_piix3_xen_ide_unplug() did not clear the copy (it only cleared the copy of bs). Begs the question whether stale data could have been used after unplug. As far as I can tell, the copy w

[Qemu-devel] [PATCH 09/10] ide: Drop redundant IDEState member model

2012-12-17 Thread Markus Armbruster
It's a copy of dev->serial. The copy was needed for non-qdevified controllers, which lacked dev. Note that pci_piix3_xen_ide_unplug() did not clear the copy (it only cleared the copy of bs). Begs the question whether stale data could have been used after unplug. As far as I can tell, the copy w

Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-17 Thread Alexander Graf
On 17.12.2012, at 15:05, Markus Armbruster wrote: > They complicate IDE data structures and keep getting in the way. > Also, TRIM support (commit d353fb72) is broken for them, because > ide_identify() accesses IDEDevice member conf, but IDEDevice exists > only with qdevified controllers. > > The

Re: [Qemu-devel] [PATCH] Added uapi directory into linux-header

2012-12-17 Thread Alexander Graf
On 17.12.2012, at 05:08, Bharat Bhushan wrote: > Linux ARCH specific header files are now in uapi/ directory also. > These header files (epapr_hcalls.h on powerpc) are needed in qemu > in linux-headers/uapi/asm/ directory as these are referenced by > other header files in linux-headers/asm/. > >

[Qemu-devel] [PATCH v7 0/4] Add subcommand compare for qemu-img

2012-12-17 Thread mrezanin
From: Miroslav Rezanina This is seventh version of patch adding compare subcommand that compares two images. Compare has following criteria: - only data part is compared - unallocated sectors are not read - in case of different image size, exceeding part of bigger disk has to be zeroed/unall

[Qemu-devel] [PATCH v7 4/4] Add qemu-img compare documentation

2012-12-17 Thread mrezanin
From: Miroslav Rezanina Adding documentation for new qemu-img subcommand compare. Signed-off-by: Miroslav Rezanina --- qemu-img.c| 7 ++- qemu-img.texi | 32 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 8

[Qemu-devel] [PATCH v7 2/4] qemu-img: Add "Quiet mode" option

2012-12-17 Thread mrezanin
From: Miroslav Rezanina There can be need to turn output to stdout off. This patch adds a -q option that enable "Quiet mode". In Quiet mode, only errors are printed out. Signed-off-by: Miroslav Rezanina --- block.c | 11 +++--- block.h | 2 +- blockdev.c | 6 ++--

[Qemu-devel] [PATCH v7 1/4] block: Add synchronous wrapper for bdrv_co_is_allocated_above

2012-12-17 Thread mrezanin
From: Miroslav Rezanina There's no synchronous wrapper for bdrv_co_is_allocated_above function so it's not possible to check for sector allocation in image with backing file. This patch add missing synchronous wrapper. Signed-off-by: Miroslav Rezanina --- block.c | 39

[Qemu-devel] [PATCH 07/10] ide: Drop redundant IDEState member version

2012-12-17 Thread Markus Armbruster
It's a copy of dev->version. The copy was needed for non-qdevified controllers, which lacked dev. Note that pci_piix3_xen_ide_unplug() did not clear the copy (it only cleared the copy of bs). Begs the question whether stale data could have been used after unplug. As far as I can tell, the copy

[Qemu-devel] [PATCH 03/10] ide: Use IDEState member dev for "device connected" test

2012-12-17 Thread Markus Armbruster
Testing dev is more obvious than testing bs, in my opinion. Signed-off-by: Markus Armbruster --- hw/ide/ahci.c | 8 hw/ide/core.c | 56 - hw/ide/microdrive.c | 5 +++-- hw/ide/qdev.c | 2 +- 4 files changed, 38 ins

Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking

2012-12-17 Thread Hans de Goede
Hi, On 12/17/2012 02:16 PM, Gerd Hoffmann wrote: On 12/14/12 14:35, Hans de Goede wrote: Note that a shadow variable is used instead of changing frindex to uframe accuracy because we must send a frindex which is a multiple of 8 during migration for migration compatibility, and rounding it down

Re: [Qemu-devel] [PATCH 2/3] Reset qemu timers when guest reset

2012-12-17 Thread Alexander Graf
On 17.12.2012, at 07:08, Bharat Bhushan wrote: > This patch install the timer reset handler. This will be called when > the guest is reset. > > Signed-off-by: Bharat Bhushan > --- > hw/ppc_booke.c | 12 > 1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/hw/ppc_b

[Qemu-devel] [Bug 1091241] [NEW] NetBSD/i386 6.0 guest suffers interrupt storm since qemu BIOS update

2012-12-17 Thread Andreas Gustafsson
Public bug reported: Since the pc-bios update of qemu commit d7a51dbbaa70677846453f8c961590913052dd86, booting a NetBSD/i386 guest takes a very long time, apparently due to interrupt load. For example, booting the NetBSD/i386 6.0 serial console install CD with wget ftp://ftp.netbsd.org/pub/Ne

[Qemu-devel] [PATCH 06/10] ide: Drop redundant IDEState geometry members

2012-12-17 Thread Markus Armbruster
Members cylinders, heads, sectors, chs_trans are copies of dev->conf.cyls, dev->conf.heads, dev->conf.secs, dev->chs_trans. Copies were needed for non-qdevified controllers, which lacked dev. Note that pci_piix3_xen_ide_unplug() did not clear the copies (it only cleared the copy of bs). Begs the

[Qemu-devel] [PATCH 05/10] ide: Drop redundant IDEState member bs

2012-12-17 Thread Markus Armbruster
It's a copy of dev->conf.bs. The copy was needed for non-qdevified controllers, which lacked dev. Note how pci_piix3_xen_ide_unplug() cleared the copy. We'll get back to that in the next few commits. Signed-off-by: Markus Armbruster --- hw/ide/ahci.c | 11 +- hw/ide/atapi.c| 3

[Qemu-devel] [PATCH 04/10] ide: Don't block-align IDEState member smart_selftest_data

2012-12-17 Thread Markus Armbruster
All uses are simple array subscripts. Signed-off-by: Markus Armbruster --- hw/ide/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 5876862..66e56c2 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2006,8 +2006,7 @@ static void ide

[Qemu-devel] [PATCH v7 3/4] qemu-img: Add compare subcommand

2012-12-17 Thread mrezanin
From: Miroslav Rezanina This patch adds new qemu-img subcommand that compare content of two disk images. Signed-off-by: Miroslav Rezanina --- qemu-img-cmds.hx | 6 ++ qemu-img.c | 268 ++- 2 files changed, 273 insertions(+), 1 deletio

[Qemu-devel] [PATCH 5/8] spice-qemu-char: add spiceport chardev

2012-12-17 Thread Gerd Hoffmann
From: Marc-André Lureau Add a new spice chardev to allow arbitrary communication between the host and the Spice client via the spice server. Examples: This allows the Spice client to have a special port for the qemu monitor: ... -chardev spiceport,name=org.qemu.monitor,id=monitorport -mon

[Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-17 Thread Markus Armbruster
They complicate IDE data structures and keep getting in the way. Also, TRIM support (commit d353fb72) is broken for them, because ide_identify() accesses IDEDevice member conf, but IDEDevice exists only with qdevified controllers. The non-qdevified controllers are still there, but attempting to co

[Qemu-devel] KVM call agenda for 2012-12-18

2012-12-17 Thread Juan Quintela
Hi Please send in any agenda topics that you have. Thanks, Juan.

Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking

2012-12-17 Thread Hans de Goede
Hi, On 12/17/2012 03:39 PM, Gerd Hoffmann wrote: On 12/17/12 15:23, Hans de Goede wrote: Hi, On 12/17/2012 02:16 PM, Gerd Hoffmann wrote: On 12/14/12 14:35, Hans de Goede wrote: Note that a shadow variable is used instead of changing frindex to uframe accuracy because we must send a frindex

Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions

2012-12-17 Thread Alexander Graf
On 14.12.2012, at 17:46, Jens Freimann wrote: > From: Viktor Mihajlovski > > This enables qemu -cpu help to return a list of supported CPU models > on s390 and also to query for cpu definitions in the monitor. > Initially only cpu model = host is returned. This needs to be reworked > into a ful

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-17 Thread Alexander Graf
On 14.12.2012, at 17:46, Jens Freimann wrote: > Add a CPU reset handler to have all CPUs in a PoP compliant > state. > > Signed-off-by: Jens Freimann > > --- > v2 -> v3: > * explain in comment which code sets cpu 0 to running during IPL > > v1 -> v2: > * move setting of control registers and

Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking

2012-12-17 Thread Gerd Hoffmann
On 12/17/12 15:47, Hans de Goede wrote: > Hi, > > On 12/17/2012 03:39 PM, Gerd Hoffmann wrote: >> On 12/17/12 15:23, Hans de Goede wrote: >>> Hi, >>> >>> On 12/17/2012 02:16 PM, Gerd Hoffmann wrote: On 12/14/12 14:35, Hans de Goede wrote: > Note that a shadow variable is used instead of c

Re: [Qemu-devel] [PATCH] Added uapi directory into linux-header

2012-12-17 Thread Bhushan Bharat-R65777
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Monday, December 17, 2012 7:45 PM > To: Bhushan Bharat-R65777 > Cc: qemu-devel qemu-devel; qemu-...@nongnu.org List; Bhushan Bharat-R65777; > Jan > Kiszka; Peter Maydell > Subject: Re: [PATCH] Added uapi directory

Re: [Qemu-devel] [PATCH] Added uapi directory into linux-header

2012-12-17 Thread Alexander Graf
On 17.12.2012, at 15:51, Bhushan Bharat-R65777 wrote: > > >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Monday, December 17, 2012 7:45 PM >> To: Bhushan Bharat-R65777 >> Cc: qemu-devel qemu-devel; qemu-...@nongnu.org List; Bhushan Bharat-R65777; >> Jan >

Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-17 Thread Alexander Graf
On 17.12.2012, at 15:43, Markus Armbruster wrote: > Alexander Graf writes: > >> On 17.12.2012, at 15:05, Markus Armbruster wrote: >> >>> They complicate IDE data structures and keep getting in the way. >>> Also, TRIM support (commit d353fb72) is broken for them, because >>> ide_identify() acce

Re: [Qemu-devel] [PATCH 09/26] ehci: Use uframe precision for interrupt threshold checking

2012-12-17 Thread Gerd Hoffmann
On 12/17/12 15:23, Hans de Goede wrote: > Hi, > > On 12/17/2012 02:16 PM, Gerd Hoffmann wrote: >> On 12/14/12 14:35, Hans de Goede wrote: >>> Note that a shadow variable is used instead of changing frindex to >>> uframe accuracy because we must send a frindex which is a multiple of 8 >>> during mi

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH v7 1/4] use image_file_reset to reload initrd

2012-12-17 Thread Alexander Graf
On 06.12.2012, at 05:11, Yin Olivia-R63875 wrote: > > >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Sunday, December 02, 2012 7:20 PM >> To: Yin Olivia-R63875 >> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org >> Subject: Re: [Qemu-ppc] [RFC PATCH v7 1/4]

Re: [Qemu-devel] [PATCH] Added uapi directory into linux-header

2012-12-17 Thread Bhushan Bharat-R65777
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Monday, December 17, 2012 8:24 PM > To: Bhushan Bharat-R65777 > Cc: qemu-devel qemu-devel; qemu-...@nongnu.org List; Jan Kiszka; Peter Maydell > Subject: Re: [PATCH] Added uapi directory into linux-header > > > O

Re: [Qemu-devel] [PULLv2] pci,net,misc infrastructure

2012-12-17 Thread Paolo Bonzini
Il 17/12/2012 12:12, Michael S. Tsirkin ha scritto: > On Sun, Dec 16, 2012 at 11:11:37PM +0200, Michael S. Tsirkin wrote: >> The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: >> >> Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2012-12-10 >> 08:35:15 -06

Re: [Qemu-devel] [PATCH 2/4] block: Improve error report for wrong format

2012-12-17 Thread Luiz Capitulino
On Sat, 15 Dec 2012 15:09:31 +0100 Stefan Weil wrote: > There is no good system error for this kind of error, > so it needs special handling instead of strerror. > > Signed-off-by: Stefan Weil > --- > blockdev.c |9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --gi

Re: [Qemu-devel] [PATCH] Added uapi directory into linux-header

2012-12-17 Thread Alexander Graf
On 17.12.2012, at 16:02, Bhushan Bharat-R65777 wrote: > > >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Monday, December 17, 2012 8:24 PM >> To: Bhushan Bharat-R65777 >> Cc: qemu-devel qemu-devel; qemu-...@nongnu.org List; Jan Kiszka; Peter >> Maydell >>

Re: [Qemu-devel] [PULLv2] pci,net,misc infrastructure

2012-12-17 Thread Michael S. Tsirkin
On Mon, Dec 17, 2012 at 04:07:39PM +0100, Paolo Bonzini wrote: > Il 17/12/2012 12:12, Michael S. Tsirkin ha scritto: > > On Sun, Dec 16, 2012 at 11:11:37PM +0200, Michael S. Tsirkin wrote: > >> The following changes since commit > >> 1c97e303d4ea80a2691334b0febe87a50660f99d: > >> > >> Merge remo

Re: [Qemu-devel] [PATCH 0/2] virtio: reset all qbuses too when writing to the status field

2012-12-17 Thread Michael S. Tsirkin
On Sun, Dec 16, 2012 at 08:31:16PM +0100, Paolo Bonzini wrote: > Il 16/12/2012 18:04, Michael S. Tsirkin ha scritto: > > On Thu, Dec 13, 2012 at 09:54:23AM +0100, Paolo Bonzini wrote: > >> Il 12/12/2012 22:27, Michael S. Tsirkin ha scritto: > > Maybe it's obvious to you that qdev_reset_all(x) >

Re: [Qemu-devel] [PATCH 2/3] Reset qemu timers when guest reset

2012-12-17 Thread Bhushan Bharat-R65777
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Monday, December 17, 2012 7:53 PM > To: Bhushan Bharat-R65777 > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; Bhushan Bharat-R65777 > Subject: Re: [PATCH 2/3] Reset qemu timers when guest reset > > > On 17.12.2

Re: [Qemu-devel] [PATCH 2/3] Reset qemu timers when guest reset

2012-12-17 Thread Alexander Graf
On 17.12.2012, at 16:09, Bhushan Bharat-R65777 wrote: > > >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Monday, December 17, 2012 7:53 PM >> To: Bhushan Bharat-R65777 >> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; Bhushan Bharat-R65777 >> Subject: Re:

Re: [Qemu-devel] [PATCH 0/2] virtio: reset all qbuses too when writing to the status field

2012-12-17 Thread Paolo Bonzini
Il 17/12/2012 11:40, Michael S. Tsirkin ha scritto: > How about the following? Then we can put reset > in generic code where it belongs. > It's untested - really kind of pseudo code - and > s390 is still to be updated. > > Posting to see what does everyone thinks. I'm not (yet) sure how that help

Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-17 Thread Markus Armbruster
Alexander Graf writes: > On 17.12.2012, at 15:43, Markus Armbruster wrote: > >> Alexander Graf writes: >> >>> On 17.12.2012, at 15:05, Markus Armbruster wrote: >>> They complicate IDE data structures and keep getting in the way. Also, TRIM support (commit d353fb72) is broken for them

Re: [Qemu-devel] [PATCH] Added uapi directory into linux-header

2012-12-17 Thread Bhushan Bharat-R65777
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Monday, December 17, 2012 8:39 PM > To: Bhushan Bharat-R65777 > Cc: qemu-devel qemu-devel; qemu-...@nongnu.org List; Jan Kiszka; Peter Maydell > Subject: Re: [PATCH] Added uapi directory into linux-header > > > O

Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

2012-12-17 Thread Alexander Graf
On 17.12.2012, at 16:15, Markus Armbruster wrote: > Alexander Graf writes: > >> On 17.12.2012, at 15:43, Markus Armbruster wrote: >> >>> Alexander Graf writes: >>> On 17.12.2012, at 15:05, Markus Armbruster wrote: > They complicate IDE data structures and keep getting in the w

Re: [Qemu-devel] [PATCH 0/2] virtio: reset all qbuses too when writing to the status field

2012-12-17 Thread Michael S. Tsirkin
On Mon, Dec 17, 2012 at 04:14:00PM +0100, Paolo Bonzini wrote: > Il 17/12/2012 11:40, Michael S. Tsirkin ha scritto: > > How about the following? Then we can put reset > > in generic code where it belongs. > > It's untested - really kind of pseudo code - and > > s390 is still to be updated. > > >

  1   2   3   >