Re: [Qemu-devel] [ [PATCH 1/2] cutils:change strtosz_suffix_unit function

2012-12-13 Thread Markus Armbruster
Igor Mammedov writes: > On Fri, 7 Dec 2012 11:49:49 +0800 > liguang wrote: > >> if value to be translated is larger than INT64_MAX, >> this function will not be convenient for caller to >> be aware of it, so change a little for this. >> >> Signed-off-by: liguang >> --- >> cutils.c |5 +++-

Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API.

2012-12-13 Thread KONRAD Frédéric
On 12/12/2012 15:25, Peter Maydell wrote: On 10 December 2012 16:45, wrote: -static void virtio_blk_class_init(ObjectClass *klass, void *data) -{ -DeviceClass *dc = DEVICE_CLASS(klass); -PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - -k->init = virtio_blk_init_pci; -k->exit = v

Re: [Qemu-devel] [Bug 1087114] [NEW] assertion "QLIST_EMPTY(&bs->tracked_requests)" failed

2012-12-13 Thread Zhi Yong Wu
On Thu, Dec 6, 2012 at 12:02 PM, Brad Smith <1087...@bugs.launchpad.net> wrote: > Public bug reported: > > QEMU 1.3.0 on OpenBSD now crashes with an error as shown below and the > command line params do not seem to matter. > > assertion "QLIST_EMPTY(&bs->tracked_requests)" failed: file "block.c", >

Re: [Qemu-devel] [PATCH] define qemukvm-1.2 machine type

2012-12-13 Thread Paolo Bonzini
Il 12/12/2012 23:39, Marcelo Tosatti ha scritto: > > To allow migration from qemu-kvm-1.2, where cirrus device has 16 megabytes > of RAM. > > Signed-off-by: Marcelo Tosatti A similar patch would be needed for all machine types though, no? I think distros that used to ship qemu-kvm should just

Re: [Qemu-devel] [PATCH] RTC: enable lost_tick_policy=slew as default (v2)

2012-12-13 Thread Paolo Bonzini
Il 12/12/2012 22:36, Marcelo Tosatti ha scritto: > > RTC interrupt reinjection has no known negative effect. Lack of > RTC interrupt reinjection, though, has negative effects: time drift > for Windows guests which use it as a timer source. > > Based on that, enable lost_tick_policy=slew option as

[Qemu-devel] [PATCH] virtio-blk: Return UNSUPP for unknown request types

2012-12-13 Thread Alexey Zaytsev
Currently, all unknown requests are treated as VIRTIO_BLK_T_IN Signed-off-by: Alexey Zaytsev --- hw/virtio-blk.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index e25cc96..1f59a76 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c

[Qemu-devel] [PATCH] virtio-blk: Return UNSUPP for unknown request types

2012-12-13 Thread Alexey Zaytsev
Currently, all unknown requests are treated as VIRTIO_BLK_T_IN Signed-off-by: Alexey Zaytsev --- Sorry, made a typo when formatting the patch, please consider this one. hw/virtio-blk.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c

Re: [Qemu-devel] [PATCH 0/2] virtio: reset all qbuses too when writing to the status field

2012-12-13 Thread Paolo Bonzini
Il 12/12/2012 22:27, Michael S. Tsirkin ha scritto: >>> Maybe it's obvious to you that qdev_reset_all(x) >>> does a soft reset and what soft reset means >>> for each bus type >> >> We can define soft reset to be *independent* of the bus type. As you >> said, you access it with a device register. >

Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API.

2012-12-13 Thread KONRAD Frédéric
On 11/12/2012 18:50, Peter Maydell wrote: On 10 December 2012 16:45, wrote: From: KONRAD Frederic Here the virtio-blk-pci is modified for the new API. The device virtio-pci-blk extends virtio-pci. It creates and connects a virtio-blk during the init. Did you check whether this maintains bac

Re: [Qemu-devel] [PATCH] build: Use separate makefile for "trace/"

2012-12-13 Thread Paolo Bonzini
Il 12/12/2012 15:53, Lluís Vilanova ha scritto: > Paolo Bonzini writes: > >> Il 11/12/2012 22:44, Lluís Vilanova ha scritto: >>> Signed-off-by: Lluís Vilanova >>> --- >>> .gitignore |6 +-- >>> Makefile|8 ++- >>> Makefile.objs

Re: [Qemu-devel] cpu hotplug roadmap ?

2012-12-13 Thread Alexandre DERUMIER
> Hi, > this wiki talked about cpu hotplug for qemu 1.3. > > http://wiki.qemu.org/Features/CPUHotplug > > Is it planned for qemu 1.4 ? or later release ? >>WiKi is not complete yet and shows only foreseeable steps >>that hopefully will get into 1.4. >>I'll going to update it somewhere in January d

Re: [Qemu-devel] [ [PATCH 1/2] cutils:change strtosz_suffix_unit function

2012-12-13 Thread Igor Mammedov
On Thu, 13 Dec 2012 09:03:50 +0100 Markus Armbruster wrote: > Igor Mammedov writes: > > > On Fri, 7 Dec 2012 11:49:49 +0800 > > liguang wrote: > > > >> if value to be translated is larger than INT64_MAX, > >> this function will not be convenient for caller to > >> be aware of it, so change a l

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-13 Thread Kevin Wolf
Am 13.12.2012 01:13, schrieb Busch, Keith: > On Mon, Dec 10, 2012 at 7:11 AM, Stefan Hajnoczi wrote: >> Quick pointers to get started on Kevin's suggestion: >> >> bdrv_aio_readv(), bdrv_aio_writev(), bdrv_aio_flush(), and >> bdrv_aio_discard() provide the block device operations that emulated >> s

[Qemu-devel] [PATCH v2 0/5] Improve consistency of pci-ids.txt, use symbolic constants for QEMU devices

2012-12-13 Thread Paolo Bonzini
Five small, boring patches. Inspired by Gerd's patch at http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg05229.html which unfortunately is already out of date. Paolo Bonzini (5): docs: move pci-ids.txt to docs/specs/ reorganize pci-ids.txt virtio-9p: use symbolic constant, add to pci

Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API.

2012-12-13 Thread KONRAD Frédéric
On 12/12/2012 18:58, Peter Maydell wrote: On 12 December 2012 17:53, Andreas Färber wrote: Am 12.12.2012 15:25, schrieb Peter Maydell: How will the PCI transport's PCI vendor/device/class IDs be set (a) when a virtio-blk backend is created and separately plugged into a virtio-pci transport (b)

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-13 Thread Paolo Bonzini
Il 13/12/2012 10:12, Kevin Wolf ha scritto: >>> There seems to be an issue with the bdrv_aio_[readv/writev] >>> routines. I added some additional tracing in the block and >>> coroutine code, and well, long story short, the coroutine >>> "bdrv_co_io_em" needs to call "qemu_coroutine_yield" before hi

[Qemu-devel] [PATCH v2 5/5] pci: use constants for devices under the 1B36 device ID, document them

2012-12-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/specs/pci-ids.txt | 15 +++ hw/pci.h | 7 +++ hw/pci_bridge_dev.c| 8 ++-- hw/serial-pci.c| 12 ++-- 4 files changed, 30 insertions(+), 12 deletions(-) diff --git a/docs/specs/pci-ids.txt b/docs/specs/p

Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API.

2012-12-13 Thread Paolo Bonzini
Il 12/12/2012 22:22, Michael S. Tsirkin ha scritto: > > > It should be equally > > > valid to just use the PCI transport plugged into a VirtioDevice, > > > both of which were created by the user with -device [and for > > > new transports, separate transport and backend should be the > > > standard]

[Qemu-devel] [PATCH v2 2/5] reorganize pci-ids.txt

2012-12-13 Thread Paolo Bonzini
Some devices were missing, and we're using two PCI vendor ids. This patch only adds devices that are already documented in hw/pci.h. Signed-off-by: Paolo Bonzini --- docs/specs/pci-ids.txt | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/docs/spec

[Qemu-devel] [PATCH v2 3/5] virtio-9p: use symbolic constant, add to pci-ids.txt

2012-12-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- docs/specs/pci-ids.txt | 1 + hw/9pfs/virtio-9p-device.c | 2 +- hw/pci.h | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/specs/pci-ids.txt b/docs/specs/pci-ids.txt index df2527f..2d5329a 100644 --- a/docs/specs/pci-

[Qemu-devel] [PATCH v2 1/5] docs: move pci-ids.txt to docs/specs/

2012-12-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- pci-ids.txt => docs/specs/pci-ids.txt | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename pci-ids.txt => docs/specs/pci-ids.txt (100%) diff --git a/pci-ids.txt b/docs/specs/pci-ids.txt similarity index 100% rename from pci-ids.txt rename to docs/specs/pc

[Qemu-devel] [PATCH v2 4/5] ivshmem: use symbolic constant for PCI ID, add to pci-ids.txt

2012-12-13 Thread Paolo Bonzini
Due to disagreement on a name that is generic enough for hw/pci.h, the symbolic constants are placed in the .c files. Signed-off-by: Paolo Bonzini --- docs/specs/pci-ids.txt | 2 ++ hw/ivshmem.c | 7 +-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/docs/specs/pci-

Re: [Qemu-devel] [PATCH 1/1] atapi: reset cdrom tray statuses on ide_reset

2012-12-13 Thread Kevin Wolf
Am 11.12.2012 08:55, schrieb Pavel Hrdina: > Tray statuses should be also reseted. Some guests may lock the tray > and after reset before any kernel is loaded the tray should be unlocked. > > Also if you reset the real computer the tray is closed. We should > do the same in qemu. > > Signed-off-b

[Qemu-devel] [Bug 1087114] Re: assertion "QLIST_EMPTY(&bs->tracked_requests)" failed

2012-12-13 Thread Brad Smith
I'm just finishing the bisection and think I have the commit that caused this but I'm now just testing commits +-1 from that commit to make sure and if it is will try reverting just that commit against HEAD as well. Using the sigaltstack coroutine backend did not make any difference. I actually am

Re: [Qemu-devel] new pc-bios/bios.bin breaks freebsd booting

2012-12-13 Thread Brad Smith
On Wed, Dec 12, 2012 at 06:47:58PM +0100, Paolo Bonzini wrote: > Il 12/12/2012 17:04, Luigi Rizzo ha scritto: > > I am not sure if it has been reported already but this commit > > > > http://git.qemu.org/?p=qemu.git;a=commitdiff;h=d7a51dbbaa70677846453f8c961590913052dd86 > > > > (replacing pc-bio

[Qemu-devel] buildbot failure in qemu on default_openbsd_4.9

2012-12-13 Thread qemu
The Buildbot has detected a new failure on builder default_openbsd_4.9 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_openbsd_4.9/builds/464 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_openbsd49 Bu

Re: [Qemu-devel] new pc-bios/bios.bin breaks freebsd booting

2012-12-13 Thread Paolo Bonzini
> Could you please provide a pre-compiled BIOS image so I could test > this out? I believe the issue I have is the same but it doesn't hurt > to have more testing. :) It's attached to my message. Paolo

[Qemu-devel] [PATCH 1/4] virtio-serial: use uint32_t to count ports

2012-12-13 Thread Amit Shah
Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index 155da58..30f450c 100644 --- a/hw/virtio-serial-bus.c +++ b/hw/virtio-serial-bus.c @@ -56,7 +56,7 @@ struct VirtIOSerial

[Qemu-devel] [PATCH 0/4] virtio-serial: Rework, fix post_load code

2012-12-13 Thread Amit Shah
This series reworks the post_load code recently introduced to allocate the structures only when required (i.e. only at load time). This helps keep the VirtIOSerial struct clean, and use less RAM. Also rearrange the code in virtio_serial_load() for easier readability. Patch 4 fixes a race with th

[Qemu-devel] [PATCH 3/4] virtio-serial: allocate post_load only at load-time

2012-12-13 Thread Amit Shah
This saves us a few bytes in the VirtIOSerial struct. Not a big savings, but since the entire structure is used only during a short while after migration, it's helpful to keep the struct cleaner and smaller. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 63 ++

Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4

2012-12-13 Thread Alon Levy
> On 12/06/12 16:41, Alon Levy wrote: > > RHBZ 869981 > > > > Before this patch revision < 4 (4 is the default) would result in a > > wrong > > qxl_rom size of 16384 instead of 8192 when building with > > spice-protocol-0.12, due to the addition of fields in > > the rom for client capabilities and

Re: [Qemu-devel] [PATCH 1/1] atapi: reset cdrom tray statuses on ide_reset

2012-12-13 Thread Pavel Hrdina
On Thu, 2012-12-13 at 11:18 +0100, Kevin Wolf wrote: > Am 11.12.2012 08:55, schrieb Pavel Hrdina: > > Tray statuses should be also reseted. Some guests may lock the tray > > and after reset before any kernel is loaded the tray should be unlocked. > > > > Also if you reset the real computer the tra

Re: [Qemu-devel] [PATCH 0/4] virtio-serial: Rework, fix post_load code

2012-12-13 Thread Alon Levy
All looks good. Reviewed-by: Alon Levy - Original Message - > This series reworks the post_load code recently introduced to > allocate > the structures only when required (i.e. only at load time). This > helps keep the VirtIOSerial struct clean, and use less RAM. > > Also rearrange the

Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed

2012-12-13 Thread Kevin Wolf
Am 12.12.2012 17:37, schrieb Michael S. Tsirkin: > On Wed, Dec 12, 2012 at 04:52:53PM +0100, Paolo Bonzini wrote: >> Il 12/12/2012 16:25, Michael S. Tsirkin ha scritto: >>> On Wed, Dec 12, 2012 at 04:01:27PM +0100, Paolo Bonzini wrote: Il 12/12/2012 15:47, Michael S. Tsirkin ha scritto: >

[Qemu-devel] [Bug 1087114] Re: assertion "QLIST_EMPTY(&bs->tracked_requests)" failed

2012-12-13 Thread Paolo Bonzini
Please attach config.log, also please try (if you're using recent openbsd with rthreads) --with-coroutine=sigaltstack. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1087114 Title: assertion "QLIST_

Re: [Qemu-devel] [PATCH 0/3] chardev/spice: fix missing spice mouse after migration

2012-12-13 Thread Amit Shah
On (Wed) 28 Nov 2012 [11:05:37], Alon Levy wrote: > Adds a new char device backend callback to check connectedness, implemented > for virtio console, and used by spice-char-dev in post migration. > > Is using NULL for DeviceState the intention for non device vmstates? It works > fine in practice.

Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API.

2012-12-13 Thread KONRAD Frédéric
On 13/12/2012 09:24, KONRAD Frédéric wrote: On 12/12/2012 15:25, Peter Maydell wrote: On 10 December 2012 16:45, wrote: -static void virtio_blk_class_init(ObjectClass *klass, void *data) -{ -DeviceClass *dc = DEVICE_CLASS(klass); -PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - -k->

[Qemu-devel] ehci and low/full speed peripherals

2012-12-13 Thread M P
In the i.MX23 emulation, there is a EHCI sysbus device which is supported and seems to work well already (using -usbdevice host:...) However most of the other peripherals (serial, hub, net) fail do to a 'speed mismatch' error. I looked into a bit more details, and it seems the EHCI has to be compl

[Qemu-devel] [PATCH 1/1] virtio-serial-bus: send_control_msg should not deal with cpkts

2012-12-13 Thread Amit Shah
Stuff the cpkt before calling send_control_msg(). it should not be concerned about contents, just send across the buffer. A few code refactorings recently have made mkaing this change easier than earlier. Coverity and clang have flagged this code several times in the past (cpkt->id not set befor

[Qemu-devel] [PATCH 2/4] virtio-serial: move active ports loading to separate function

2012-12-13 Thread Amit Shah
The virtio_serial_load() function became too big, split the code that gets the port info from the source into a separate function. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 96 +- 1 file changed, 55 insertions(+), 41 deletions(-) diff

[Qemu-devel] [PATCH 4/4] virtio-serial: delete timer if active during exit

2012-12-13 Thread Amit Shah
The post_load timer was being freed, but not deleted. This could cause problems when the timer is armed, but the device is hot-unplugged before the callback is executed. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio-serial-bus.

[Qemu-devel] buildbot failure in qemu on default_x86_64_rhel61

2012-12-13 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_rhel61 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/464 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 B

[Qemu-devel] [PATCH 2/2] qxl: change rom so that 4096 < size < 8192

2012-12-13 Thread Alon Levy
This is a simpler solution to 869981, where migration breaks since qxl's rom bar size has changed. Instead of ignoring fields in QXLRom, which is what has actually changed, we remove some of the modes, a mechanism already accounted for by the guest. To reach exactly two pages and not one, we remov

[Qemu-devel] [PATCH 1/2] qxl: stop using non revision 4 rom fields for revision < 4

2012-12-13 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 11 +++ trace-events | 2 ++ 2 files changed, 13 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index 3f835b8..8611ee9 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -981,6 +981,12 @@ static void interface_set_client_capabilities(QXLInstance *sin,

Re: [Qemu-devel] compile tcm_vhost kernel module as built-in

2012-12-13 Thread ching lu
On Tue, Dec 11, 2012 at 9:18 PM, ching wrote: > Hi, > > is there any virtio-scsi developer here? > > I take a look at the tcm_vhost module of kernel 3.7 and want to compile it as > built-in. > > However, CONFIG_TCM_VHOST only allows user to build as module. > > I wonder why this restriction exist

[Qemu-devel] [PATCH 08/21] openpic: combine openpic and mpic reset functions

2012-12-13 Thread Alexander Graf
The openpic and mpic reset handlers are almost identical. Combine them and extract the differences into state variables. Signed-off-by: Alexander Graf --- hw/openpic.c | 103 +++-- 1 files changed, 42 insertions(+), 61 deletions(-) diff --git

[Qemu-devel] [PATCH 14/21] openpic: convert to qdev

2012-12-13 Thread Alexander Graf
This patch converts the OpenPIC device to qdev. Along the way it renames the "openpic" target to "raven" and the "mpic" target to "fsl_mpic_20", to better reflect the actual models they implement. This way we have a generic OpenPIC device now that can handle different flavors of the OpenPIC specif

[Qemu-devel] [PATCH 11/21] openpic: convert simple reg operations to builtin bitops

2012-12-13 Thread Alexander Graf
The openpic code has its own bitmap code to access bits inside of a bitmap. However, that is overkill when we simply want to check for a bit inside of a uint32_t. So instead, let's use normal bit masks and C builtin shifts and ands. Signed-off-by: Alexander Graf --- hw/openpic.c | 67

[Qemu-devel] [PATCH 18/21] PPC: e500: Declare pci bridge as bridge

2012-12-13 Thread Alexander Graf
The new PCI host bridge device needs to identify itself as PCI host bridge. Declare it as such. Signed-off-by: Alexander Graf --- hw/ppce500_pci.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c index 54c72b4..e534341 100644 --- a

[Qemu-devel] [PATCH 17/21] PPC: e500: Add MSI support

2012-12-13 Thread Alexander Graf
Now that our interrupt controller supports MSIs, let's expose that feature to the guest through the device tree! Signed-off-by: Alexander Graf --- hw/ppc/e500.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index fa9

Re: [Qemu-devel] [PATCH 2/2] qxl: change rom so that 4096 < size < 8192

2012-12-13 Thread Gerd Hoffmann
On 12/13/12 12:36, Alon Levy wrote: > This is a simpler solution to 869981, where migration breaks since qxl's > rom bar size has changed. Instead of ignoring fields in QXLRom, which is what > has > actually changed, we remove some of the modes, a mechanism already > accounted for by the guest. To

Re: [Qemu-devel] ehci and low/full speed peripherals

2012-12-13 Thread Gerd Hoffmann
On 12/13/12 11:38, M P wrote: > In the i.MX23 emulation, there is a EHCI sysbus device which is supported > and seems to work well already (using -usbdevice host:...) > > However most of the other peripherals (serial, hub, net) fail do to a > 'speed mismatch' error. I looked into a bit more detail

[Qemu-devel] [PATCH 16/21] openpic: add Shared MSI support

2012-12-13 Thread Alexander Graf
The OpenPIC allows MSI access through shared MSI registers. Implement them for the MPC8544 MPIC, so we can support MSIs. Signed-off-by: Alexander Graf --- hw/openpic.c | 150 ++ 1 files changed, 130 insertions(+), 20 deletions(-) diff --g

[Qemu-devel] [PATCH 02/21] mpic: Unify numbering scheme

2012-12-13 Thread Alexander Graf
MPIC interrupt numbers in Linux (device tree) and in QEMU are different, because QEMU takes the sparseness of the IRQ number space into account. Remove that cleverness and instead assume a flat number space. This makes the code easier to understand, because we are actually aligned with Linux on th

[Qemu-devel] [PATCH 10/21] openpic: remove unused type variable

2012-12-13 Thread Alexander Graf
The openpic source irqs are carrying around a type indicator that is never accessed by anything. Remove it. Signed-off-by: Alexander Graf --- hw/openpic.c | 27 ++- 1 files changed, 2 insertions(+), 25 deletions(-) diff --git a/hw/openpic.c b/hw/openpic.c index 623c807

[Qemu-devel] [PATCH 13/21] openpic: remove irq_out

2012-12-13 Thread Alexander Graf
The current openpic emulation contains half-ready code for bypass mode. Remove it, so that when someone wants to finish it they can start from a clean state. Signed-off-by: Alexander Graf --- hw/openpic.c |8 ++-- hw/openpic.h |4 ++-- hw/ppc/e500.c |2 +- hw/ppc_ne

Re: [Qemu-devel] [PATCH 2/2] qemu-img: add json output option to the check command

2012-12-13 Thread Kevin Wolf
Am 10.12.2012 18:01, schrieb Federico Simoncelli: > This option --output=[human|json] make qemu-img check output an human > or JSON representation at the choice of the user. > > Signed-off-by: Federico Simoncelli > --- > qapi-schema.json | 38 + > qemu-img-cmds.hx |4 +- > qemu-img

Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-13 Thread Luiz Capitulino
On Wed, 12 Dec 2012 13:45:54 + Dietmar Maurer wrote: > > > Btw, do you know a qmp call which returns the memory assigned to the > > > VM (the value qemu is started with (-m megs))? > > > > No, we only have info/query- balloon. I was also thinking about this the > > other day. > > Can we add

[Qemu-devel] [PATCH 15/21] openpic: make brr1 model specific

2012-12-13 Thread Alexander Graf
Now that we can properly distinguish between openpic model differences, let's move brr1 out of the raven code path. Signed-off-by: Alexander Graf --- hw/openpic.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/openpic.c b/hw/openpic.c index 591b291..5bf16ea 10064

[Qemu-devel] [PATCH 21/21] openpic: Accelerate pending irq search

2012-12-13 Thread Alexander Graf
When we're done with one interrupt, we need to search for the next pending interrupt in the queue. This search has grown quite big now that we have more than 256 possible irq lines. So let's memorize how many interrupts we have pending in our bitmaps, so that we can always bail out in the usual ca

[Qemu-devel] [PATCH 06/21] openpic: combine mpic and openpic irq raise functions

2012-12-13 Thread Alexander Graf
The IRQ raise mechanisms of the OpenPIC and MPIC controllers is identical, just that the MPIC one can also raise critical interrupts. Combine those two and check for critical raise capability during runtime. Signed-off-by: Alexander Graf --- hw/openpic.c | 34 -

Re: [Qemu-devel] [PATCH 11/13] pseries: Fixes and enhancements to L1 cache properties

2012-12-13 Thread Alexander Graf
On 04.12.2012, at 03:42, David Gibson wrote: > PAPR requires that the device tree's CPU nodes have several properties > with information about the L1 cache. We created two of these > properties, but with incorrect names - "[id]cache-block-size" instead > of "[id]-cache-block-size" (note the extr

Re: [Qemu-devel] [PATCH 10/13] target-ppc: Don't use hwaddr to represent hardware state

2012-12-13 Thread Alexander Graf
On 04.12.2012, at 03:42, David Gibson wrote: > The hwaddr type is somewhat vaguely defined as being able to contain bus > addresses on the widest possible bus in the system. For that reason it's > discouraged for representing specific pieces of persistent hardware state, > which should instead u

Re: [Qemu-devel] [PATCH 12/13] pseries: Increase default NVRAM size

2012-12-13 Thread Alexander Graf
On 04.12.2012, at 03:42, David Gibson wrote: > If no image file for NVRAM is specified, the pseries machine currently > creates a 16K non-persistent NVRAM by default. This basically works, but > is not large enough for current firmware and guest kernels to create all > the NVRAM partitions they

Re: [Qemu-devel] [PATCH] Fix compile errors when enabling Xen debug logging.

2012-12-13 Thread Stefano Stabellini
On Thu, 13 Dec 2012, Sander Eikelenboom wrote: > Signed-off-by: Sander Eikelenboom please wrap around the lines > 80 characters. > hw/xen_pt.c |4 ++-- > xen-all.c |4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/xen_pt.c b/hw/xen_pt.c > index 7a3846e.

Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified

2012-12-13 Thread Alexander Graf
On 04.12.2012, at 04:11, David Gibson wrote: > On Tue, Dec 04, 2012 at 01:42:17PM +1100, David Gibson wrote: >> From: Mike Qiu > > Oops, messed this one up, build error for user only builds. Fixed > version below. > > From d2cc6bcee4737647c4bbbf65d3c0129d4a119dd3 Mon Sep 17 00:00:00 2001 > Fr

[Qemu-devel] [PATCH 03/21] openpic: update to proper memory api

2012-12-13 Thread Alexander Graf
The openpic code was still using the old mmio memory api. Convert it to be a generic memory api user and clean up some code that becomes redundant that way. Signed-off-by: Alexander Graf --- hw/openpic.c | 138 -- 1 files changed, 48 inser

[Qemu-devel] [PATCH 05/21] openpic: Convert subregions to memory api

2012-12-13 Thread Alexander Graf
The "openpic" controller is currently using one big region and does subregion dispatching manually. Move this to the memory api. Signed-off-by: Alexander Graf --- hw/openpic.c | 106 + 1 files changed, 61 insertions(+), 45 deletions(-) di

[Qemu-devel] [PATCH 12/21] openpic: rename openpic_t to OpenPICState

2012-12-13 Thread Alexander Graf
Rename the openpic_t struct to OpenPICState, so it adheres better to the current coding style rules. Signed-off-by: Alexander Graf --- v2 -> v3: - fix coding style --- hw/openpic.c | 68 +- 1 files changed, 34 insertions(+), 34 delet

Re: [Qemu-devel] [ [PATCH 1/2] cutils:change strtosz_suffix_unit function

2012-12-13 Thread Markus Armbruster
Igor Mammedov writes: > On Thu, 13 Dec 2012 09:03:50 +0100 > Markus Armbruster wrote: > >> Igor Mammedov writes: >> >> > On Fri, 7 Dec 2012 11:49:49 +0800 >> > liguang wrote: >> > >> >> if value to be translated is larger than INT64_MAX, >> >> this function will not be convenient for caller t

[Qemu-devel] [PATCH 07/21] openpic: merge mpic and openpic timer handling

2012-12-13 Thread Alexander Graf
The openpic and mpic timer handling code is basically the same. Merge them. Signed-off-by: Alexander Graf --- hw/openpic.c | 131 ++ 1 files changed, 31 insertions(+), 100 deletions(-) diff --git a/hw/openpic.c b/hw/openpic.c index d709e3

[Qemu-devel] [PATCH 01/21] openpic: Remove unused code

2012-12-13 Thread Alexander Graf
The openpic code had a few WIP bits left that nobody reanimated within the last few years. Remove that code. Signed-off-by: Alexander Graf Acked-by: Hervé Poussineau --- hw/openpic.c | 163 -- 1 files changed, 0 insertions(+), 163 deletio

[Qemu-devel] [PATCH 09/21] openpic: unify memory api subregions

2012-12-13 Thread Alexander Graf
The only difference between the "openpic" and "mpic" memory api subregion descriptors is the endianness. Unify them as openpic accessors with explicit endianness markers in their names. Signed-off-by: Alexander Graf --- hw/openpic.c | 108 ++--

Re: [Qemu-devel] [PATCH 2/3] target-i386/cpu.c: coding style fix

2012-12-13 Thread Eduardo Habkost
On Thu, Dec 13, 2012 at 12:36:02AM +0100, Igor Mammedov wrote: > On Wed, 12 Dec 2012 20:22:25 -0200 > Eduardo Habkost wrote: > > While at it, could you remove the last as well? I didn't even notice it was there. I will do that in case I have to resubmit this series, or send a separate patch to

Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified

2012-12-13 Thread David Gibson
On Thu, Dec 13, 2012 at 01:57:16PM +0100, Alexander Graf wrote: > > On 04.12.2012, at 04:11, David Gibson wrote: > > > On Tue, Dec 04, 2012 at 01:42:17PM +1100, David Gibson wrote: > >> From: Mike Qiu > > > > Oops, messed this one up, build error for user only builds. Fixed > > version below.

[Qemu-devel] [PATCH 19/21] MSI-X: Fix endianness

2012-12-13 Thread Alexander Graf
The MSI-X vector tables are usually stored in little endian in memory, so let's mark the accessors as such. This fixes MSI-X on e500 for me. Signed-off-by: Alexander Graf Acked-by: Michael S. Tsirkin --- hw/msix.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 20/21] openpic: fix minor coding style issues

2012-12-13 Thread Alexander Graf
This patch removes all remaining occurences of spaces before function parameter indicating parenthesis. Signed-off-by: Alexander Graf --- hw/openpic.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/openpic.c b/hw/openpic.c index 4bea1e7..25d5cd7 100644 ---

Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified

2012-12-13 Thread Alexander Graf
On 13.12.2012, at 14:17, David Gibson wrote: > On Thu, Dec 13, 2012 at 01:57:16PM +0100, Alexander Graf wrote: >> >> On 04.12.2012, at 04:11, David Gibson wrote: >> >>> On Tue, Dec 04, 2012 at 01:42:17PM +1100, David Gibson wrote: From: Mike Qiu >>> >>> Oops, messed this one up, build er

[Qemu-devel] [PATCH 04/21] openpic: combine mpic and openpic src handlers

2012-12-13 Thread Alexander Graf
The MPIC source irq handler suddenly became identical to the standard OpenPIC source irq handler. Combine them into the same function. Signed-off-by: Alexander Graf --- hw/openpic.c | 52 +--- 1 files changed, 5 insertions(+), 47 deletions(-) di

[Qemu-devel] [PATCH 00/21] OpenPIC refactoring and MSI support v3

2012-12-13 Thread Alexander Graf
The OpenPIC implemtation has been a sad piece of code in the QEMU tree for a long time now. It's ugly, doesn't stick to the coding style and misses out on a few of the recent infrastructure improvements. This patch set is a first stab at moving the OpenPIC further towards maintainable code. It cle

Re: [Qemu-devel] ehci and low/full speed peripherals

2012-12-13 Thread M P
On Thu, Dec 13, 2012 at 12:25 PM, Gerd Hoffmann wrote: > On 12/13/12 11:38, M P wrote: > > In the i.MX23 emulation, there is a EHCI sysbus device which is supported > > and seems to work well already (using -usbdevice host:...) > > > > However most of the other peripherals (serial, hub, net) fail

Re: [Qemu-devel] [PATCH v2] Fix compile errors when enabling Xen debug logging.

2012-12-13 Thread Stefano Stabellini
On Thu, 13 Dec 2012, Sander Eikelenboom wrote: > v2: > - Wrap around > 80 characters > - Use %"HWADDR_PRIx" format for hwaddr > > Signed-off-by: Sander Eikelenboom Acked-by: Stefano Stabellini > hw/xen_pt.c |5 +++-- > xen-all.c |7 --- > 2 files changed, 7 insertions(+), 5 del

Re: [Qemu-devel] [PATCH v4 0/6] hw/ds1338.c

2012-12-13 Thread Peter Maydell
On 12 December 2012 22:56, Antoine Mathys wrote: > Empty cover letters rather defeat their purpose, by the way. git format-patch's --cover-letter option will generate you a nice cover letter template including a summary of the patches in the series and a diffstat. Anyway, all patches Reviewed-by

Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified

2012-12-13 Thread Peter Maydell
On 13 December 2012 13:19, Alexander Graf wrote: > > On 13.12.2012, at 14:17, David Gibson wrote: > >> On Thu, Dec 13, 2012 at 01:57:16PM +0100, Alexander Graf wrote: >>> What if I am using TCG on PPC? >> >> Then the stub version of kvmppc_smt_threads() returns 1, and since the >> PPC TCG doesn't

Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified

2012-12-13 Thread Peter Maydell
On 13 December 2012 14:17, Peter Maydell wrote: > On 13 December 2012 13:19, Alexander Graf wrote: >> So because we don't call kvm_arch_init, the cap is 0 and thus we return 1? > > No, if we aren't CONFIG_KVM then that source file and version of > the function aren't compiled at all. ...and 5 se

[Qemu-devel] [PATCH 0/2] Add pc-testdev to qemu v4

2012-12-13 Thread Lucas Meneghel Rodrigues
These two patches introduce: 1) A ISA debugexit port device, that when written, causes qemu to exit with the exit code passed as parameter. 2) A port of the existing testdev present on qemu-kvm to qemu I took Gerd's recent patch and modified it to include the access-size property, as well a

[Qemu-devel] [PATCH 1/2] add isa-debug-exit device

2012-12-13 Thread Lucas Meneghel Rodrigues
From: Gerd Hoffmann When present it makes qemu exit on any write. Mapped to port 0x501 by default. Without this patch Anthony doesn't allow me to remove the bochs bios debug ports because his test suite uses this. Changes from v1: Add access_size property to the device, needed for kvm-unit-test

Re: [Qemu-devel] [PATCH 0/3] chardev/spice: fix missing spice mouse after migration

2012-12-13 Thread Anthony Liguori
Amit Shah writes: > On (Wed) 28 Nov 2012 [11:05:37], Alon Levy wrote: >> Adds a new char device backend callback to check connectedness, implemented >> for virtio console, and used by spice-char-dev in post migration. >> >> Is using NULL for DeviceState the intention for non device vmstates? It

Re: [Qemu-devel] ehci and low/full speed peripherals

2012-12-13 Thread Gerd Hoffmann
Hi, > I added the properties (see patch lower down) and I Use the following to > create a companion ohci, however qemu starts, seems to let me attach lower > speed devices, but linux reports: > "hub 1-0:1.0: Cannot enable port 1. Maybe the USB cable is bad" I have to > say I'm not sure where th

[Qemu-devel] [PATCH 1/2] add isa-debug-exit device

2012-12-13 Thread Lucas Meneghel Rodrigues
From: Gerd Hoffmann When present it makes qemu exit on any write. Mapped to port 0x501 by default. Without this patch Anthony doesn't allow me to remove the bochs bios debug ports because his test suite uses this. Changes from v1: Add access_size property to the device, needed for kvm-unit-test

[Qemu-devel] [PATCH] vmmouse_reset(): remove minimal code duplication

2012-12-13 Thread Laszlo Ersek
Commit 069ab0eb added a vmmouse_disable() call to vmmouse_reset(). vmmouse_disable() resets the status already. Signed-off-by: Laszlo Ersek --- hw/vmmouse.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/vmmouse.c b/hw/vmmouse.c index 6338efa..578122c 100644 --- a/hw

Re: [Qemu-devel] [PATCH 1/2] add isa-debug-exit device

2012-12-13 Thread Gerd Hoffmann
Hi, > hw/pc-testdev.c | 167 > + That should have been in patch 2/2 I guess? cheers, Gerd

Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4

2012-12-13 Thread Yonit Halperin
On 12/13/2012 05:40 AM, Alon Levy wrote: On 12/06/12 16:41, Alon Levy wrote: RHBZ 869981 Before this patch revision < 4 (4 is the default) would result in a wrong qxl_rom size of 16384 instead of 8192 when building with spice-protocol-0.12, due to the addition of fields in the rom for client ca

Re: [Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version

2012-12-13 Thread Alexander Graf
On 10.12.2012, at 13:48, Gerd Hoffmann wrote: > Lower the bar a bit. 0.16.4 is known-good, and is shipped by debian. > Fixes build failures on the debian-based buildbot slaves. SLES11 ships 0.16.0 for example. It'd be nice to stay compatible there. What exactly is the compatibility bar? The fa

Re: [Qemu-devel] [PATCH 1/2] add isa-debug-exit device

2012-12-13 Thread Lucas Meneghel
On 12/13/2012 12:28 PM, Gerd Hoffmann wrote: Hi, hw/pc-testdev.c | 167 + That should have been in patch 2/2 I guess? Oops, rebase error :( Will re-spin and re-send. Thanks! cheers, Gerd

[Qemu-devel] [PATCH 0/2] Add pc-testdev to qemu v4

2012-12-13 Thread Lucas Meneghel Rodrigues
These two patches introduce: 1) A ISA debugexit port device, that when written, causes qemu to exit with the exit code passed as parameter. 2) A port of the existing testdev present on qemu-kvm to qemu I took Gerd's recent patch and modified it to include the access-size property, as well a

Re: [Qemu-devel] [PATCH] build: Use separate makefile for "trace/"

2012-12-13 Thread Lluís Vilanova
Paolo Bonzini writes: [...] - -$(trace-obj-y): $(GENERATED_HEADERS) +trace-obj-y += trace/ >> >>> Please just put it into oslib-obj-y. >> >> You mean line "trace-obj-y += trace/"? > Yeah, make it > oslib-obj-y += trace/ > and get rid of trace-obj-y. Mmm, but according to Makefi

[Qemu-devel] [PATCH 2/2] hw: Add test device for unittests execution v5

2012-12-13 Thread Lucas Meneghel Rodrigues
Add a test device which supports the kvmctl ioports, so one can run the KVM unittest suite. Intended Usage: qemu-system-x86_64\ -device pc-testdev -serial stdio \ -device isa-debugexit,iobase=0xf4,access-size=4 \ -kernel /path/to/kvm/unittests/msr.flat Where msr.flat is one of the KVM unittests,

Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4

2012-12-13 Thread Gerd Hoffmann
Hi, >> That is indeed a better solution, but it does change functionality. I >> think it is correct but I'd like to get some other opinions - Uri, >> Arnon, Yonit, Soren - any problems with dropping these? >> > Orientation is used in the Windows Display driver. It is used to set > dmDisplayOrien

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-13 Thread Alexander Graf
On 13.12.2012, at 08:16, Gerd Hoffmann wrote: > On 12/13/12 01:57, Scott Wood wrote: >> On 12/12/2012 01:52:29 AM, Gerd Hoffmann wrote: >>> On 12/12/12 04:18, Scott Wood wrote: QEMU is sometimes used in embedded contexts, where graphical support is unnecessary. The ability to turn off

  1   2   3   >