On 12 December 2012 22:56, Antoine Mathys <barsa...@gmail.com> wrote: >
Empty cover letters rather defeat their purpose, by the way. git format-patch's --cover-letter option will generate you a nice cover letter template including a summary of the patches in the series and a diffstat. Anyway, all patches Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> and I've put them into arm-devs.next. Thanks! A couple of formatting points for future reference, if you want to send further patches to QEMU in the future: Your email client is sending patch emails with the 'format=flowed' attribute, which means that every line in the patch beginning with a space has an extra space added to it. That means that if I save the email or if I go and download the version from patchwork ( http://patchwork.ozlabs.org/patch/205677/ ) it won't apply. It is also wrapping long lines (as can be seen in patch 4/6. I fixed this up this time by running a sed command to fix up the mangled patchfiles, but it's much easier on reviewers if you can just send the patches as plain unmangled text (for example git format-patch and git send-email will send patches without mangling them.) thanks again -- PMM
