Re: [Qemu-devel] [ [PATCH 1/2] cutils:change strtosz_suffix_unit function

2012-12-12 Thread Stefan Hajnoczi
On Wed, Dec 12, 2012 at 08:58:17AM +0800, li guang wrote: > 在 2012-12-11二的 10:52 +0100,Stefan Hajnoczi写道: > > On Fri, Dec 07, 2012 at 11:49:49AM +0800, liguang wrote: > > > if value to be translated is larger than INT64_MAX, > > > this function will not be convenient for caller to > > > be aware of

Re: [Qemu-devel] [RFC PATCH 0/2] live backup vm

2012-12-12 Thread Paolo Bonzini
> So our snapshot implementation uses the following steps: > > 1.) qmp: savevm-start [statefile] > > This save the VM state into [statefile] and then stops the VM. That's migrate exec:cat>statefile (or similar) > 2.) qga freezefs How can freezefs run while the VM is stopped? > 3.) create snap

Re: [Qemu-devel] Performance of usb tablet over ehci

2012-12-12 Thread Gerd Hoffmann
Hi, > In the end the problem stays that usb uses a polling model versus the > async interrupt model ps2 uses. If your guest supports usb 3.0 (aka xhci) you can try that. The hardware design allows to not poll in the emulation, which brings down the cpu load even more, should come pretty close

[Qemu-devel] Audio errors without setting "-soundhw"

2012-12-12 Thread Andrei Dinu
Hello qemu-devel, I've been trying to run an arm image with these parameters : sudo /home/adinu/work/poky4/poky/build/tmp/sysroots/x86_64-linux/usr/bin/qemu-system-arm -kernel /home/adinu/work/poky4/poky/build/tmp/deploy/images/zImage-qemuarm.bin -net nic,vlan=0 -net tap,vlan=0,ifname=tap0,s

Re: [Qemu-devel] [PATCH] build: Use separate makefile for "trace/"

2012-12-12 Thread Paolo Bonzini
Il 11/12/2012 22:44, Lluís Vilanova ha scritto: > Signed-off-by: Lluís Vilanova > --- > .gitignore |6 +-- > Makefile|8 ++- > Makefile.objs | 64 +--- > scripts/tracetool/backend/dtrace.p

Re: [Qemu-devel] [PATCH] RTC: enable lost_tick_policy=slew as default

2012-12-12 Thread Paolo Bonzini
Il 11/12/2012 22:49, Marcelo Tosatti ha scritto: > > RTC interrupt reinjection has no known negative effect. Lack of > RTC interrupt reinjection, though, has negative effects: time drift > for Windows guests which use it as a timer source. > > Based on that, enable lost_tick_policy=slew option

[Qemu-devel] Qemu scrambles eth device order in VM

2012-12-12 Thread john fisher
HV = 12.04 LTS Ubuntu + libvirt 1.0x VM = 12.04 LTS Ubuntu When multiple bridged eth interfaces are created on the VM, they do not appear in predictable order. They appear before virtual function addresses, but eth0-eth7 in this case do not order according to the interfaces file on the HV, nor t

[Qemu-devel] [Bug 1089006] [NEW] Qemu scrambles order of eth devices in vm

2012-12-12 Thread john fisher
Public bug reported: HV = 12.04 LTS plus libvirt 1.0x VM = 12.04 LTS On the HV there are 12 eth interfaces which we make available to the VM. We have 4 10G virtual function interfaces, and 8 1G conventionally bridged interfaces. No matter what order we present the interfaces in the xml file, they

[Qemu-devel] [Bug 1089005] [NEW] Qemu does not shutdown with vnc enabled on OS X

2012-12-12 Thread Leander Sabel
Public bug reported: I am running OS X 10.8.2 and Qemu 1.3.50 from your git repository. Running qemu-system-i386 works fine. I can quit the process using ctrl-c. When I try to use qemu-system-i386 -vnc : ctrl-c does nothing and I have to kill the process trough the activity monito

Re: [Qemu-devel] [RFC PATCH 0/2] live backup vm

2012-12-12 Thread Dietmar Maurer
> > 1.) qmp: savevm-start [statefile] > > > > This save the VM state into [statefile] and then stops the VM. > > That's migrate exec:cat>statefile (or similar) Basic functionality is the same, but we support saving state to block devices. But there are many migration related patches in the last

Re: [Qemu-devel] [RFC PATCH 0/2] live backup vm

2012-12-12 Thread Dietmar Maurer
> > So our snapshot implementation uses the following steps: > > > > 1.) qmp: savevm-start [statefile] > > > > This save the VM state into [statefile] and then stops the VM. > > That's migrate exec:cat>statefile (or similar) We save to block devices, so we need to allocate them in advance with a

[Qemu-devel] [PATCH 2/5] acpi: autoload dsdt

2012-12-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pc.c | 23 +++ hw/pc.h |1 + hw/pc_piix.c |1 + hw/pc_q35.c |1 + 4 files changed, 26 insertions(+), 0 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index b11e7c4..cc4b260 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -886,6

[Qemu-devel] [PATCH 3/5] apci: assign memory regions to piix4 acpi device

2012-12-12 Thread Gerd Hoffmann
Get rid of get_system_io() usage. Signed-off-by: Gerd Hoffmann --- hw/acpi_piix4.c | 20 +--- 1 files changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 0b5b0d3..30bafb6 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -57,6 +57

[Qemu-devel] [PATCH 5/5] pc: remove bochs bios debug ports

2012-12-12 Thread Gerd Hoffmann
Prehistoric leftover, zap it. We poweroff via acpi these days. And having a port (0x501,0x502) where any random guest write will make qemu exit -- with no way to turn it off -- is a bad joke anyway. If anyone has a real use case for this (I can see this being useful for regression testing), then

[Qemu-devel] [PATCH 4/5] apci: assign memory regions to ich9 lpc device

2012-12-12 Thread Gerd Hoffmann
Get rid of get_system_io() usage. Signed-off-by: Gerd Hoffmann --- hw/acpi_ich9.c |6 -- hw/acpi_ich9.h |4 +++- hw/lpc_ich9.c |2 +- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c index c5978d3..b895422 100644 --- a/hw/acpi_ich9.c

Re: [Qemu-devel] [PATCH 0/2] i2c: Add AT24Cxx EEPROM model

2012-12-12 Thread Jan Kiszka
On 2012-11-19 15:24, Jan Kiszka wrote: > See patches for details. > > Jan Kiszka (2): > i2c: Introduce device address mask > Add AT24Cxx I2C EEPROM device model > > hw/Makefile.objs |2 +- > hw/at24.c| 363 > ++ > hw/ds1338.c

[Qemu-devel] [PATCH 0/5] acpi: misc updates

2012-12-12 Thread Gerd Hoffmann
Hi, Small collection of acpi updates: q35 dsdt windup, fix some leftovers from the acpi memory api switch, remove dead code. cheers, Gerd Gerd Hoffmann (5): configure: also symlink *.aml files acpi: autoload dsdt apci: assign memory regions to piix4 acpi device apci: assign memory r

[Qemu-devel] [PATCH 1/5] configure: also symlink *.aml files

2012-12-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 38b1cc6..d35563c 100755 --- a/configure +++ b/configure @@ -4197,6 +4197,7 @@ FILES="$FILES pc-bios/spapr-rtas/Makefile" FILES="$FILES roms/seabios/Make

Re: [Qemu-devel] [RFC PATCH 0/2] live backup vm

2012-12-12 Thread Paolo Bonzini
Il 12/12/2012 10:03, Dietmar Maurer ha scritto: >>> So our snapshot implementation uses the following steps: >>> >>> 1.) qmp: savevm-start [statefile] >>> >>> This save the VM state into [statefile] and then stops the VM. >> >> That's migrate exec:cat>statefile (or similar) > > We save to block de

Re: [Qemu-devel] [PATCH 2/3 v4] vnc: added initial websocket protocol support

2012-12-12 Thread Tim Hardeck
On 12/11/2012 11:04 AM, Stefan Hajnoczi wrote: > On Fri, Dec 07, 2012 at 03:56:34PM +0100, Tim Hardeck wrote: > > Thanks for addressing my review comments. > >> @@ -1328,13 +1358,14 @@ void vnc_client_read(void *opaque) >> >> void vnc_write(VncState *vs, const void *data, size_t len) >> { >>

[Qemu-devel] [Bug 1089006] Re: Qemu scrambles order of eth devices in vm

2012-12-12 Thread Daniel Berrange
There is really no such concept as "NIC order" at the hardware level in QEMU. NIC naming order is something that operating systems invent according to some policy they have. As far as libvirt & QEMU are concerned, you only have control over the PCI device slot numbering. The operating system may ch

[Qemu-devel] [Bug 1089005] Re: Qemu does not shutdown with vnc enabled on OS X

2012-12-12 Thread Peter Maydell
Interesting -- my experience is that control-C doesn't work at all, even if using the cocoa UI frontend. It's a bug of some kind related to signal handling but I haven't been able to track it down. As far as I could tell with a debugger QEMU never received the SIGTERM at all, which makes no sense t

Re: [Qemu-devel] [PATCH 14/19] openpic: convert to qdev

2012-12-12 Thread Alexander Graf
On 12.12.2012, at 02:38, Scott Wood wrote: > On 12/11/2012 06:56:56 PM, Alexander Graf wrote: >> On 11.12.2012, at 18:47, Scott Wood wrote: >> > On 12/11/2012 02:25:31 AM, Alexander Graf wrote: >> >> If we want a pv style generic mpic (for -M e500), let's add such an mpic >> >> to the model list

[Qemu-devel] [PATCH] get_maintainer.pl: update from linix 3.8

2012-12-12 Thread Michael S. Tsirkin
Update get_maintainer.pl to get new features. I use at least --no-multiline --no-roles --no-rolestats, there are more. Signed-off-by: Michael S. Tsirkin --- scripts/get_maintainer.pl | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/scripts/get_mainta

[Qemu-devel] [PATCH] kvm: do not flush after deleting gsi

2012-12-12 Thread Michael S. Tsirkin
Deleting a GSI isn't necessary: it is enough to stop using it. Delay flush until an entry is used. Signed-off-by: Michael S. Tsirkin --- kvm-all.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 3bc3347..fb3180d 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -991,8 +9

[Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed

2012-12-12 Thread Michael S. Tsirkin
Add sanity check to address the following concern: During migration, all we pass the index of the request; the rest can be re-read from the ring. This is not generally enough if any available requests are outstanding. Imagine a ring of size 4. Below A means available U means used. A 1 A 2 U 2 A

Re: [Qemu-devel] [Qemu-ppc] [PATCH 16/19] openpic: add Shared MSI support

2012-12-12 Thread Alexander Graf
On 12.12.2012, at 02:42, Scott Wood wrote: > On 12/11/2012 06:53:44 PM, Alexander Graf wrote: >> On 11.12.2012, at 18:35, Scott Wood wrote: >> > On 12/11/2012 02:10:14 AM, Alexander Graf wrote: >> >> On 11.12.2012, at 01:36, Scott Wood wrote: >> >> > On 12/08/2012 07:44:39 AM, Alexander Graf wro

[Qemu-devel] [PATCH] pixman: fix vnc tight png/jpeg support

2012-12-12 Thread Gerd Hoffmann
This patch adds an x argument to qemu_pixman_linebuf_fill so it can also be used to convert a partial scanline. Then fix tight + png/jpeg encoding by passing in the x+y offset, so the data is read from the correct screen location instead of the upper left corner. Cc: 1087...@bugs.launchpad.net Cc

Re: [Qemu-devel] [PATCH v7 00/10] i8254, i8259 and running Microport UNIX (ca 1987)

2012-12-12 Thread Gleb Natapov
On Wed, Dec 12, 2012 at 12:46:41AM -0700, Matthew Ogilvie wrote: > On Tue, Dec 11, 2012 at 06:19:56PM +0200, Gleb Natapov wrote: > > On Sun, Nov 25, 2012 at 02:51:36PM -0700, Matthew Ogilvie wrote: > > > > > > Still needed: > > > > > > * Corresponding KVM patches. The best appr

Re: [Qemu-devel] [PATCH v7 00/10] i8254, i8259 and running Microport UNIX (ca 1987)

2012-12-12 Thread Jan Kiszka
On 2012-12-12 12:36, Gleb Natapov wrote: >>How about things like pit_get_out(), >> pit_get_next_transition_time(), etc in qemu/hw/i8254_common.c? (If >> not used when KVM is enabled, then why are they "common"?) What >> are the implications if qemu and KVM

Re: [Qemu-devel] [PATCH v7 00/10] i8254, i8259 and running Microport UNIX (ca 1987)

2012-12-12 Thread Gleb Natapov
On Wed, Dec 12, 2012 at 12:38:33PM +0100, Jan Kiszka wrote: > On 2012-12-12 12:36, Gleb Natapov wrote: > >>How about things like pit_get_out(), > >> pit_get_next_transition_time(), etc in qemu/hw/i8254_common.c? (If > >> not used when KVM is enabled, then wh

Re: [Qemu-devel] [PATCH] qxl: use correct rom size for revision < 4

2012-12-12 Thread Gerd Hoffmann
On 12/06/12 16:41, Alon Levy wrote: > RHBZ 869981 > > Before this patch revision < 4 (4 is the default) would result in a wrong > qxl_rom size of 16384 instead of 8192 when building with > spice-protocol-0.12, due to the addition of fields in > the rom for client capabilities and monitors config t

Re: [Qemu-devel] [PATCH v2 4/6] hw/ds1338.c: Ensure state is properly initialized.

2012-12-12 Thread Peter Maydell
On 11 December 2012 22:58, Antoine Mathys wrote: > Signed-off-by: Antoine Mathys > --- > hw/ds1338.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/hw/ds1338.c b/hw/ds1338.c > index 0f88720..b4d5b74 100644 > --- a/hw/ds1338.c > +++ b/hw/ds1338.c > @@ -179,6 +179,15 @@ sta

Re: [Qemu-devel] [PATCH v2 2/6] hw/ds1338.c: Add definitions for various flags in the RTC registers.

2012-12-12 Thread Peter Maydell
On 11 December 2012 22:52, Antoine Mathys wrote: > Signed-off-by: Antoine Mathys Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH v2 3/6] hw/ds1338.c: Fix handling of HOURS register.

2012-12-12 Thread Peter Maydell
On 11 December 2012 22:57, Antoine Mathys wrote: > Per the datasheet, the mapping between 12 and 24 hours modes is: > 0 <-> 12 PM > 1-12 <-> 1-12 AM > 13-23 <-> 1-11 PM > > Signed-off-by: Antoine Mathys Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH v8 2/2] qemu-ga: sample fsfreeze hooks

2012-12-12 Thread Luiz Capitulino
On Wed, 12 Dec 2012 12:55:57 +0900 Tomoki Sekiyama wrote: > Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. > - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ > - fsfreeze-hook.d/mysql-flush.sh.sample : quiesce MySQL before snapshot > > Signed-off-by: Tomoki Sekiyama L

Re: [Qemu-devel] [PATCH 00/10] qemu-ga: revamp error messages (for 1.4)

2012-12-12 Thread Eric Blake
On 11/28/2012 01:04 PM, mdroth wrote: > On Tue, Nov 27, 2012 at 11:01:54AM -0200, Luiz Capitulino wrote: >> This series revamps qemu-ga error messages by: >> >> - Propagating errors down to functions that generate errors >> - Fixing UndefinedErrors >> - Getting rid of sprint() + error_set() >>

Re: [Qemu-devel] [PATCH v2 5/6] hw/ds1338.c: Implement support for the control register.

2012-12-12 Thread Peter Maydell
On 11 December 2012 22:58, Antoine Mathys wrote: > The previous patch has the side effect of clearing the control register. > That's already its proper power-on-reset value. This is true but it reads a bit oddly as a standalone git commit message... > Signed-off-by: Antoine Mathys Reviewed-by:

Re: [Qemu-devel] [PATCH v2 6/6] hw/ds1338.c: Fix handling of DAY (wday) register.

2012-12-12 Thread Peter Maydell
On 11 December 2012 22:59, Antoine Mathys wrote: > Per the datasheet, the DAY (wday) register is user defined. Implement this. > > Signed-off-by: Antoine Mathys Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [RFC qom-cpu v2 2/2] target-i386: Turn Haswell into subclass of SandyBridge

2012-12-12 Thread Eduardo Habkost
On Mon, Dec 10, 2012 at 11:59:32PM +0100, Andreas Färber wrote: > ehabkost: "When adding the Haswell CPU model, I intended to make it > a superset of the features present on the SandyBridge model" > > Inherit from SandyBridge to keep only the delta for Haswell. Most CPUs have a superset of th

Re: [Qemu-devel] [PATCH v2 4/6] hw/ds1338.c: Ensure state is properly initialized.

2012-12-12 Thread Antoine Mathys
On 12/12/2012 01:05 PM, Peter Maydell wrote: I think we need to reset ptr and addr_byte too... The initial value of the register pointer is unspecified. addr_byte is only used when receiving user data. It is written in ds1338_event() then read in ds1338_send(). Setting it in ds1338_reset() is

Re: [Qemu-devel] [PATCH] kvm: do not flush after deleting gsi

2012-12-12 Thread Jan Kiszka
On 2012-12-12 11:48, Michael S. Tsirkin wrote: > Deleting a GSI isn't necessary: it is enough > to stop using it. Delay flush until an entry is used. > > Signed-off-by: Michael S. Tsirkin > --- > kvm-all.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kvm-all.c b/kvm-all.c > index 3

Re: [Qemu-devel] [PATCH v2 1/6] hw/ds1338.c: Correct bug in conversion to BCD.

2012-12-12 Thread Peter Maydell
On 11 December 2012 22:49, Antoine Mathys wrote: > Signed-off-by: Antoine Mathys Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [PATCH 0/3] s390: ipl device, cpu reset handler and cpu model support

2012-12-12 Thread Jens Freimann
Hi Alex, here's a reworked version of the ipl-device patch, the cpu reset handler and a new patch to query cpu definitions via QMP. Patch 1: Creates a new ipl device and moves ipl code from s390_virtio.c Patch 2: Adds a cpu reset handler to Patch 3 Allow to query cpu types via commandline -? ar

[Qemu-devel] [PATCH 1/3] s390: Move IPL code into a separate device

2012-12-12 Thread Jens Freimann
From: Christian Borntraeger Lets move the code to setup IPL for external kernel or via the zipl rom into a separate file. This allows to - define a reboot handler, setting up the PSW appropriately - reuse that code for several machines (e.g. virtio-ccw and virtio-s390) - allow different machines

[Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-12 Thread Jens Freimann
Add a CPU reset handler to have all CPUs in a PoP compliant state. Signed-off-by: Jens Freimann --- v1 -> v2: * move setting of control registers and psa to s390_cpu_reset and call it from the new s390_machine_cpu_reset_cb() This makes it more similar to how it is done on x86 * in s390_cpu_r

[Qemu-devel] [PATCH 0/8] pci core reorg

2012-12-12 Thread Michael S. Tsirkin
This patchset starts some cleanups of the pci core by rearranging the code: pci core is split out from devices into its own directory, pci internals.h is renamed as it's used externally a lot. I'd like to merge this quickly to avoid conflicting with others work. Plan to send pull request tomorrow,

[Qemu-devel] [PATCH 2/8] MAINTAINERS: add hw/pci/ to list of PCI files

2012-12-12 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2ede20d..c1b16c5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -490,6 +490,7 @@ F: hw/omap* PCI M: Michael S. Tsirkin S: Supported +F: hw/pci/* F: hw/pci* F:

[Qemu-devel] [PATCH 7/8] pci: rename pci_internals.h pci_bus.h

2012-12-12 Thread Michael S. Tsirkin
There are lots of external users of pci_internals.h, apparently making it an internal interface only didn't work out. Let's stop pretending it's an internal header. Signed-off-by: Michael S. Tsirkin --- hw/apb_pci.c | 2 +- hw/dec_pci.c | 2 +- hw/ich9.h | 2 +

[Qemu-devel] [PATCH 8/8] pci_bus: update comment

2012-12-12 Thread Michael S. Tsirkin
Don't ask everyone to desist from including this header, simply recommend using accessors. Signed-off-by: Michael S. Tsirkin --- hw/pci/pci_bus.h | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/hw/pci/pci_bus.h b/hw/pci/pci_bus.h index 21d0ce6..8217f61 100644 --- a

[Qemu-devel] [PATCH 4/8] pci: update all users to look in pci/

2012-12-12 Thread Michael S. Tsirkin
update all users so we can remove the makefile hack. Signed-off-by: Michael S. Tsirkin --- arch_init.c | 2 +- hw/ac97.c| 2 +- hw/acpi_ich9.c | 2 +- hw/acpi_piix4.c | 2 +- hw/alpha_sys.h | 4 ++-- hw/apb_pci.c | 8 +++

[Qemu-devel] [PATCH 5/8] pci: make external dependencies explicit

2012-12-12 Thread Michael S. Tsirkin
Include dependencies from pci core using <> and the correct path. Need to check whether they can be minimized, for now, at least make them explicit. Signed-off-by: Michael S. Tsirkin --- hw/pci/msix.c| 4 ++-- hw/pci/pci-hotplug.c | 20 ++-- hw/pci/pci.c | 16 +++

Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-12 Thread Dietmar Maurer
> > > > Why don't we raise the error when we query the values? You already raise an error here, so that works out of the box: if (s->stats[i] == -1) { error_setg(errp, "timer hasn't been enabled or guest doesn't support '%s'", name); > > > > > > Hmm, that's a good idea. >

[Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2012-12-12 Thread Philipp Hahn
Hello Kevin, hello Michael, hello *, we noticed a data corruption bug in qemu-1.1.2, which will be shipped by Debian and our own Debian based distibution. The corruption mostly manifests while installing large Debian package files and seems to be reladed to memory preasure: As long as the file i

Re: [Qemu-devel] [PATCH 2/3 v4] vnc: added initial websocket protocol support

2012-12-12 Thread Stefan Hajnoczi
On Wed, Dec 12, 2012 at 11:04:16AM +0100, Tim Hardeck wrote: > On 12/11/2012 11:04 AM, Stefan Hajnoczi wrote: > > On Fri, Dec 07, 2012 at 03:56:34PM +0100, Tim Hardeck wrote: > > > > Thanks for addressing my review comments. > > > >> @@ -1328,13 +1358,14 @@ void vnc_client_read(void *opaque) > >>

Re: [Qemu-devel] [PATCH 1/3] s390: Move IPL code into a separate device

2012-12-12 Thread Alexander Graf
On 12.12.2012, at 14:08, Jens Freimann wrote: > From: Christian Borntraeger > > Lets move the code to setup IPL for external kernel > or via the zipl rom into a separate file. This allows to > > - define a reboot handler, setting up the PSW appropriately > - reuse that code for several machine

Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-12 Thread Luiz Capitulino
On Wed, 12 Dec 2012 13:17:15 + Dietmar Maurer wrote: > > > > > Why don't we raise the error when we query the values? > > You already raise an error here, so that works out of the box: > > if (s->stats[i] == -1) { > error_setg(errp, > "timer hasn't been enabled or gu

Re: [Qemu-devel] [PATCH v2 4/6] hw/ds1338.c: Ensure state is properly initialized.

2012-12-12 Thread Peter Maydell
On 12 December 2012 13:11, Antoine Mathys wrote: > Would it be ok to reply with a new version of this patch only, instead of > resending the whole series ? We generally prefer the whole series to be resent, it avoids confusion about which versions of which patches are most current. You might like

Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState

2012-12-12 Thread Andreas Färber
Am 05.12.2012 17:49, schrieb Eduardo Habkost: > This finally makes the CPU class a child of DeviceState, allowing us to > start using DeviceState properties on CPU subclasses. > > It has no_user=1, as creating CPUs using -device doesn't work yet. > > (based on a previous patch from Igor Mammedov)

Re: [Qemu-devel] [PATCH v2 4/6] hw/ds1338.c: Ensure state is properly initialized.

2012-12-12 Thread Antoine Mathys
It's true that it probably doesn't make much difference, but both the addr_byte and ptr are part of the migration state listed in the vmstate struct. I think it is cleaner and more straightforward to reason about if resetting the device returns it to an exact known state. The state may be undefi

Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-12 Thread Dietmar Maurer
> > The following patch seems to work for me: > > Yeah, that's what I'll do and the doc has to be updated too. Btw, do you know a qmp call which returns the memory assigned to the VM (the value qemu is started with (-m megs))?

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-12 Thread Alexander Graf
On 12.12.2012, at 14:08, Jens Freimann wrote: > Add a CPU reset handler to have all CPUs in a PoP compliant > state. > > Signed-off-by: Jens Freimann > > --- > v1 -> v2: > * move setting of control registers and psa to s390_cpu_reset > and call it from the new s390_machine_cpu_reset_cb() > T

Re: [Qemu-devel] [PATCH v2] kvm: Detect number of available memory slots from the host kernel

2012-12-12 Thread Gleb Natapov
On Mon, Dec 10, 2012 at 10:10:33AM -0700, Alex Williamson wrote: > The kernel already exposes an interface for this, x86 returns a proper > value and for the rest we can default to the defacto standard of 32. > The primary motivation for this is to support more PCI assigned > devices, both through

[Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions

2012-12-12 Thread Jens Freimann
From: Viktor Mihajlovski This enables qemu -cpu help to return a list of supported CPU models on s390 and also to query for cpu definitions in the monitor. Initially only cpu model = host is returned. This needs to be reworked into a full-fledged CPU model handling later on. This change is needed

Re: [Qemu-devel] Internal documentation

2012-12-12 Thread Stefan Hajnoczi
On Tue, Dec 11, 2012 at 10:40:45AM -0800, Michael Eager wrote: > Is there any internal documentation for QEMU? Nothing up-to-date and complete. > I'm adding support for a new processor. I'm currently > adding semihosting support and a new command line option. > I find that I'm reading a lot of u

Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions

2012-12-12 Thread Alexander Graf
On 12.12.2012, at 14:08, Jens Freimann wrote: > From: Viktor Mihajlovski > > This enables qemu -cpu help to return a list of supported CPU models > on s390 and also to query for cpu definitions in the monitor. > Initially only cpu model = host is returned. This needs to be reworked > into a ful

Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-12 Thread Luiz Capitulino
On Wed, 12 Dec 2012 13:36:20 + Dietmar Maurer wrote: > > > The following patch seems to work for me: > > > > Yeah, that's what I'll do and the doc has to be updated too. > > Btw, do you know a qmp call which returns the memory assigned to the VM > (the value qemu is started with (-m megs))?

Re: [Qemu-devel] [BUG] qemu-1.1.2 [FIXED-BY] qcow2: Fix avail_sectors in cluster allocation code

2012-12-12 Thread Kevin Wolf
Hi Philipp, Am 12.12.2012 14:25, schrieb Philipp Hahn: > Hello Kevin, hello Michael, hello *, > > we noticed a data corruption bug in qemu-1.1.2, which will be shipped by > Debian and our own Debian based distibution. > The corruption mostly manifests while installing large Debian package files

Re: [Qemu-devel] [PATCH 0/3] re-enable balloon stats

2012-12-12 Thread Dietmar Maurer
> > Btw, do you know a qmp call which returns the memory assigned to the > > VM (the value qemu is started with (-m megs))? > > No, we only have info/query- balloon. I was also thinking about this the > other day. Can we add an additional property: "stat-max-memory"? Or add 'max_mem' property to

[Qemu-devel] [PATCH 08/20] mirror: allow customizing the granularity

2012-12-12 Thread Paolo Bonzini
The desired granularity may be very different depending on the kind of operation (e.g. continuous replication vs. collapse-to-raw) and whether the VM is expected to perform lots of I/O while mirroring is in progress. Allow the user to customize it, while providing a sane default so that in general

[Qemu-devel] [PATCH 12/20] mirror: support arbitrarily-sized iterations

2012-12-12 Thread Paolo Bonzini
Yet another optimization is to extend the mirroring iteration to include more adjacent dirty blocks. This limits the number of I/O operations and makes mirroring efficient even with a small granularity. Most of the infrastructure is already in place; we only need to put a loop around the computat

[Qemu-devel] [PATCH 11/20] mirror: support more than one in-flight AIO operation

2012-12-12 Thread Paolo Bonzini
With AIO support in place, we can start copying more than one chunk in parallel. This patch introduces the required infrastructure for this: the buffer is split into multiple granularity-sized chunks, and there is a free list to access them. Because of copy-on-write, a single operation may alread

[Qemu-devel] [PATCH 16/20] block: split bdrv_enable_dirty_tracking and bdrv_disable_dirty_tracking

2012-12-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block-migration.c | 17 +++-- block.c | 22 +++--- block.h | 3 ++- block/mirror.c| 4 ++-- 4 files changed, 18 insertions(+), 28 deletions(-) diff --git a/block-migration.c b/block-migration.c index 1e1d25e..

[Qemu-devel] [PATCH 13/20] oslib: add a wrapper for mmap/munmap

2012-12-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- osdep.h | 10 ++ oslib-posix.c | 47 +++ oslib-win32.c | 59 +++ 3 files changed, 116 insertions(+) diff --git a/osdep.h b/osdep.h index 87d3b9c..fb7

[Qemu-devel] [PATCH 01/20] host-utils: add ffsl

2012-12-12 Thread Paolo Bonzini
We can provide fast versions based on the other functions defined by host-utils.h. Some care is required on glibc, which provides ffsl already. Signed-off-by: Paolo Bonzini --- host-utils.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/host-utils.h b/host-utils

[Qemu-devel] [PATCH 18/20] mirror: add support for persistent dirty bitmap

2012-12-12 Thread Paolo Bonzini
A persistent dirty bitmap lets mirroring proceed with no waste of work after QEMU exits (either offline, or online when the VM restarts). It is also useful in order to communicate to management whether the switch to the destination was completed or not. Signed-off-by: Paolo Bonzini --- block/mir

Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed

2012-12-12 Thread Stefan Hajnoczi
On Wed, Dec 12, 2012 at 12:51:01PM +0200, Michael S. Tsirkin wrote: > Add sanity check to address the following concern: > > During migration, all we pass the index of the request; > the rest can be re-read from the ring. > > This is not generally enough if any available requests are outstanding.

Re: [Qemu-devel] [PATCH 0/8] pci core reorg

2012-12-12 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > This patchset starts some cleanups of the pci core > by rearranging the code: pci core is split out > from devices into its own directory, pci internals.h > is renamed as it's used externally a lot. > > I'd like to merge this quickly to avoid conflicting > with othe

Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions

2012-12-12 Thread Andreas Färber
Am 12.12.2012 14:08, schrieb Jens Freimann: > From: Viktor Mihajlovski > > This enables qemu -cpu help to return a list of supported CPU models > on s390 and also to query for cpu definitions in the monitor. > Initially only cpu model = host is returned. This needs to be reworked > into a full-fl

[Qemu-devel] [PATCH 1/8] pci: prepare makefiles for pci code reorganization

2012-12-12 Thread Michael S. Tsirkin
To make it easier to move code around without breaking build at intermedite steps, tweak makefiles to look in pci/ and hw/ for include files, automatically. This will be reverted at the end of the reorganization. Signed-off-by: Michael S. Tsirkin --- Makefile| 1 + Makefile.target | 1 +

Re: [Qemu-devel] [PATCH] virtfs-proxy-helper: check return code of setfsgid/setfsuid

2012-12-12 Thread Paolo Bonzini
Il 05/12/2012 13:37, Paolo Bonzini ha scritto: >> > I have tested the below patch. Currently i don't have a signed-off-by on >> > the patch. One change noted by mohan which I incorporated in the patch >> > is we need to call setresgid before calling setresuid. If you are ok >> > with this change I

Re: [Qemu-devel] [PATCH 5/5] pc: remove bochs bios debug ports

2012-12-12 Thread Anthony Liguori
Gerd Hoffmann writes: > Prehistoric leftover, zap it. We poweroff via acpi these days. > > And having a port (0x501,0x502) where any random guest write will make > qemu exit -- with no way to turn it off -- is a bad joke anyway. If > anyone has a real use case for this (I can see this being use

Re: [Qemu-devel] [PATCH 0/5] Improve consistency of pci-ids.txt, use symbolic constants for QEMU devices

2012-12-12 Thread Paolo Bonzini
Il 19/11/2012 11:21, Paolo Bonzini ha scritto: > Five small, boring patches. Inspired by Gerd's patch at > http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg05229.html which > unfortunately is already out of date. > > Paolo Bonzini (5): > docs: move pci-ids.txt to docs/specs/ > reorgani

Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState

2012-12-12 Thread Eduardo Habkost
On Wed, Dec 12, 2012 at 02:34:08PM +0100, Andreas Färber wrote: > Am 05.12.2012 17:49, schrieb Eduardo Habkost: [...] > > static TypeInfo cpu_type_info = { > > .name = TYPE_CPU, > > -.parent = TYPE_OBJECT, > > +.parent = TYPE_DEVICE, > > .instance_size = sizeof(CPUState), > >

Re: [Qemu-devel] [PATCH] iscsi: add support for iovectors

2012-12-12 Thread Paolo Bonzini
Il 03/12/2012 20:35, Peter Lieven ha scritto: > This patch adds support for directly passing the iovec > array from QEMUIOVector if libiscsi supports it. Thanks, one question below. > Signed-off-by: Peter Lieven > --- > block/iscsi.c | 31 +++ > 1 file changed, 31

Re: [Qemu-devel] [PATCH 0/8] pci core reorg

2012-12-12 Thread Paolo Bonzini
Il 12/12/2012 14:51, Anthony Liguori ha scritto: > I'd like to see an Ack from Paolo as he's working on a tree-wide file > movement right now.. Don't want to conflict with what he's doing > unnecessarily. > > Otherwise, this looks reasonable to me. My changes are 99% scripted, so no problem from

[Qemu-devel] [PATCH 17/20] block: support a persistent dirty bitmap

2012-12-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block.c | 133 +++- block.h | 5 +++ block_int.h | 5 +++ 3 files changed, 141 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 66e30aa..d993d0b 100644 --- a/block.c +++ b/block

Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed

2012-12-12 Thread Paolo Bonzini
Il 12/12/2012 14:50, Stefan Hajnoczi ha scritto: > VirtIOBlock->rq can trigger the assertion. > > IIUC hw/virtio-blk.c may handle I/O errors by keeping the request > pending and on a list (->rq). This allows the user to restart them > after, for example, adding more space to the host file system

Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions

2012-12-12 Thread Alexander Graf
On 12.12.2012, at 14:51, Andreas Färber wrote: > Am 12.12.2012 14:08, schrieb Jens Freimann: >> From: Viktor Mihajlovski >> >> This enables qemu -cpu help to return a list of supported CPU models >> on s390 and also to query for cpu definitions in the monitor. >> Initially only cpu model = host

[Qemu-devel] [PATCH 1/5] PPC: E500: PCI: Make first slot qdev settable

2012-12-12 Thread Alexander Graf
Today the first slot id in our e500 pci implementation is hardcoded to 0x11. Keep it there as default, but allow users to change the default to a different id. Signed-off-by: Alexander Graf --- hw/ppce500_pci.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/hw/p

[Qemu-devel] [PATCH 0/5] PPC: e500: Enable more PCI slots for -M ppce500

2012-12-12 Thread Alexander Graf
Right now all e500 machines have a limit of 2 PCI devices. This is too little when one virtio device already eats up one PCI slot. While we can't change the -M mpc8544ds target on that respect because it physically only has 2 slots, we can easily loosen that restriction for -M ppce500. So this pa

[Qemu-devel] [PATCH 4/5] PPC: E500: Move PCI slot information into params

2012-12-12 Thread Alexander Graf
We have a params struct that allows us to expose differences between e500 machine models. Include PCI slot information there, so we can have different machines with different PCI slot topology. Signed-off-by: Alexander Graf --- hw/ppc/e500.c |4 +++- hw/ppc/e500.h |2 ++ hw/ppc

[Qemu-devel] [PATCH 2/5] PPC: E500: PCI: Make IRQ calculation more generic

2012-12-12 Thread Alexander Graf
The IRQ line calculation is more or less hardcoded today. Instead, let's write it as an algorithmic function that theoretically allows an arbitrary number of PCI slots. Signed-off-by: Alexander Graf --- hw/ppce500_pci.c | 13 +++-- 1 files changed, 3 insertions(+), 10 deletions(-) dif

[Qemu-devel] [PATCH 5/5] PPC: E500plat: Make a lot of PCI slots available

2012-12-12 Thread Alexander Graf
The ppce500 machine doesn't have to stick to hardware limitations, as it's defined as being fully device tree based. Thus we can change the initial PCI slot ID to 0x1 which gives us a whopping 31 PCI devices we can support with this machine now! Signed-off-by: Alexander Graf --- hw/ppc/e500plat

[Qemu-devel] [PATCH 3/5] PPC: E500: Generate dt pci irq map dynamically

2012-12-12 Thread Alexander Graf
Today we're hardcoding the PCI interrupt map in the e500 machine file. Instead, let's write it dynamically so that different machine types can have different slot properties. Signed-off-by: Alexander Graf --- hw/ppc/e500.c | 51 +++ 1 files chang

[Qemu-devel] [PATCH 18/19] PPC: e500: Declare pci bridge as bridge

2012-12-12 Thread Alexander Graf
The new PCI host bridge device needs to identify itself as PCI host bridge. Declare it as such. Signed-off-by: Alexander Graf --- hw/ppce500_pci.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c index 54c72b4..e534341 100644 --- a

[Qemu-devel] [PATCH 03/19] openpic: update to proper memory api

2012-12-12 Thread Alexander Graf
The openpic code was still using the old mmio memory api. Convert it to be a generic memory api user and clean up some code that becomes redundant that way. Signed-off-by: Alexander Graf --- hw/openpic.c | 138 -- 1 files changed, 48 inser

[Qemu-devel] [PATCH 09/19] openpic: unify memory api subregions

2012-12-12 Thread Alexander Graf
The only difference between the "openpic" and "mpic" memory api subregion descriptors is the endianness. Unify them as openpic accessors with explicit endianness markers in their names. Signed-off-by: Alexander Graf --- hw/openpic.c | 108 ++--

[Qemu-devel] [PATCH 15/19] openpic: make brr1 model specific

2012-12-12 Thread Alexander Graf
Now that we can properly distinguish between openpic model differences, let's move brr1 out of the raven code path. Signed-off-by: Alexander Graf --- hw/openpic.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/openpic.c b/hw/openpic.c index d42b96b..16c8b6b 10064

Re: [Qemu-devel] [PATCH 4/5] ivshmem: use symbolic constant for PCI ID, add to pci-ids.txt

2012-12-12 Thread Michael S. Tsirkin
On Mon, Nov 19, 2012 at 11:21:33AM +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > docs/specs/pci-ids.txt | 2 ++ > hw/ivshmem.c | 2 +- > hw/pci.h | 1 + > 3 file modificati, 4 inserzioni(+). 1 rimozione(-) > > diff --git a/docs/specs/pci-ids.txt b/doc

  1   2   3   4   >