It's true that it probably doesn't make much difference, but
both the addr_byte and ptr are part of the migration state
listed in the vmstate struct. I think it is cleaner and
more straightforward to reason about if resetting the
device returns it to an exact known state. The state may be
undefined according to the specification but that doesn't
mean that our implementation has to leave it undefined.
I don't understand your point about encapsulation -- these
are both fields of the device state, and ds1338_reset()
is a method of the device and has every right to access
them.
You are right. While it is not strictly necessary it is cleaner (and
safer) to set every field to a reasonable value. In addition some guest
code probably incorrectly assumes that the pointer is initially at zero
so that wouldn't hurt.
Would it be ok to reply with a new version of this patch only, instead
of resending the whole series ?
