Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-12-05 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 02:57:05PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 29, 2012 at 02:54:26PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 29, 2012 at 01:45:19PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Nov 29, 2012 at 02:33:11PM +0200, Michael S. Tsirkin wrote: > > > > On Thu, No

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-12-05 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 04:36:08PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 29, 2012 at 03:26:56PM +0100, Stefan Hajnoczi wrote: > > On Thu, Nov 29, 2012 at 03:54:25PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 22, 2012 at 04:16:44PM +0100, Stefan Hajnoczi wrote: > > > > The data plan

Re: [Qemu-devel] [PATCH v1 0/3] Xilinx Microblaze IP updates

2012-12-05 Thread Edgar E. Iglesias
On Wed, Dec 05, 2012 at 04:53:41PM +1000, Peter Crosthwaite wrote: > Minor fixes to xilinx microblaze IP. > > Peter Crosthwaite (3): > xilinx_axienet: Implement R_IS behaviour > xilinx_uartlite: suppress "cannot receive message" > xilinx_uartlite: Accept input after rx FIFO pop > > hw/xili

Re: [Qemu-devel] [PATCH] virtfs-proxy-helper: check return code of setfsgid/setfsuid

2012-12-05 Thread Aneesh Kumar K.V
Hi, I have tested the below patch. Currently i don't have a signed-off-by on the patch. One change noted by mohan which I incorporated in the patch is we need to call setresgid before calling setresuid. If you are ok with this change I can send it upstream. commit d11bb5bb31a68e3eefb4e592161978d

Re: [Qemu-devel] [PATCH][RESEND] iscsi: add support for iSCSI NOPs

2012-12-05 Thread Peter Lieven
All, please ignore this patch. During testing we found a problem in live usage. We will resubmit once this is fixed. Peter Am 04.12.2012 um 06:03 schrieb ronnie sahlberg: > Acked-By: ronniesahlb...@gmail.com (Ronnie Sahlberg) > > > This verified that the service is actually operational and is

Re: [Qemu-devel] [PATCH v3] vnc: added initial websocket protocol support

2012-12-05 Thread Tim Hardeck
Hi Stefan, On 12/03/2012 05:22 PM, Stefan Hajnoczi wrote: > Thanks for the patch, Tim. Some general code review comments below. Thanks for the code review. I am going to incorporate them in my new patch. > I hope someone has time to review the VNC and WebSocket specific stuff. > I didn't check

Re: [Qemu-devel] [PATCH v6 2/2] qemu-ga: sample fsfreeze hooks

2012-12-05 Thread Tomoki Sekiyama
On 2012/12/05 1:51, Luiz Capitulino wrote: > On Fri, 30 Nov 2012 22:33:57 +0900 > Tomoki Sekiyama wrote: > >> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. >> - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ >> - fsfreeze-hook.d.sample/mysql-flush.sh : quiesce MySQL bef

Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: use irqfd to interrupt among VMs

2012-12-05 Thread Jan Kiszka
On 2012-12-05 06:34, Cam Macdonell wrote: >> static void ivshmem_write_config(PCIDevice *pci_dev, uint32_t address, >> uint32_t val, int len) >> { >> +bool is_enabled, was_enabled = msi_enabled(pci_dev); >> + >> pci_default_write_config(pci_dev, address,

Re: [Qemu-devel] [PATCH 2/3] target-i386:make hw_breakpoint_enabled return bool type

2012-12-05 Thread Jan Kiszka
On 2012-12-05 01:51, li guang wrote: > 在 2012-12-04二的 11:26 +,Peter Maydell写道: >> On 4 December 2012 11:11, Jan Kiszka wrote: >>> On 2012-12-04 11:23, Peter Maydell wrote: Doesn't this break the use of this function in target-i386/seg_helper.c: if (hw_breakpoint_enabled(env->d

Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-05 Thread Jan Kiszka
On 2012-12-05 01:56, li guang wrote: >>> @@ -1014,22 +1016,40 @@ void hw_breakpoint_remove(CPUX86State *env, int >>> index) >>> int check_hw_breakpoints(CPUX86State *env, int force_dr6_update) >>> { >>> target_ulong dr6; >>> -int reg, type; >>> +int index; >>> int hit_enabled =

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-12-05 Thread Janne Karhunen
Just out of interest tried how far the timeout hackery can go working around the issue. Well, looks like it goes quite far: having previously reproduced the hang in 4-5 runs and in under a minute, now have had this running without a hang for an hour. I will also test the patch under OBS worker(s) a

Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: use irqfd to interrupt among VMs

2012-12-05 Thread Andrew Jones
- Original Message - > On Tue, Dec 4, 2012 at 4:10 AM, Andrew Jones > wrote: > > > > > > - Original Message - > >> On Thu, Nov 29, 2012 at 1:34 AM, liu ping fan > >> wrote: > >> > On Thu, Nov 29, 2012 at 12:42 PM, Cam Macdonell > >> > wrote: > >> >> On Tue, Nov 27, 2012 at 7:53

[Qemu-devel] [PATCH 3/6] usb: Don't allow USB_RET_ASYNC for interrupt packets

2012-12-05 Thread Gerd Hoffmann
From: Hans de Goede It is tempting to use USB_RET_ASYNC for interrupt packets, rather then the current NAK + polling approach, but this causes issues for migration, as an async completed packet will not getting written back to guest memory until the next poll time, and if a migration happens in b

[Qemu-devel] [PATCH 5/6] ehci: Lower timer freq when the periodic schedule is idle

2012-12-05 Thread Gerd Hoffmann
From: Hans de Goede Lower the timer freq if no iso schedule packets complete for 64 frames in a row. We can safely do this, without adding latency, because: 1) If there is isoc traffic this will never trigger 2) For async handled interrupt packets (only usb-host), the completion handler will

[Qemu-devel] [PATCH 4/6] usb: Allow overriding of usb_desc at the device level

2012-12-05 Thread Gerd Hoffmann
From: Hans de Goede This allows devices to present a different set of descriptors based on device properties. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb.h |1 + hw/usb/bus.c |3 +++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/usb.h b

[Qemu-devel] [PATCH 6/6] usb-tablet: Allow connecting to ehci

2012-12-05 Thread Gerd Hoffmann
From: Hans de Goede Our ehci code has is capable of significantly lowering the wakeup rate for the hcd emulation while the device is idle. It is possible to add similar code ot the uhci emulation, but that simply is not there atm, and there is no reason why a (virtual) usb-tablet can not be a USB

[Qemu-devel] [PATCH 1/6] add pc-1.4

2012-12-05 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pc_piix.c | 15 +-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index aa3e7f4..040cd07 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -281,8 +281,8 @@ static void pc_xen_hvm_init(QEMUMachineInitArgs

[Qemu-devel] [PULL 0/6] usb patch queue

2012-12-05 Thread Gerd Hoffmann
Hi, Flushing the usb patch queue, there are a few bits sent during the freeze I didn't feel like merging that close to the release, so merge them now. Series reduces the ehci emulation cpu overhead and allows to connect the usb tablet to ehci. please pull, Gerd The following changes since c

[Qemu-devel] [PATCH 2/6] usb: Call wakeup when data becomes available for all devices with int eps

2012-12-05 Thread Gerd Hoffmann
From: Hans de Goede This is necessary for proper interaction with the xhci controller, and it will allow other hcds to lower there frame timer while waiting for interrupt data. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hub.c |2 ++ hw/usb/dev-network.c |

Re: [Qemu-devel] [PULL for-1.3 0/3] seabios update

2012-12-05 Thread Brad Campbell
On 30/11/12 23:29, Gerd Hoffmann wrote: Hi, This pull updates seabios to current master. The seabios q35 patches didn't land upstream yet so they miss the boat unfortunaly. As this update brings an important regression fix we can't wait for them and risk to not update seabios for 1.3. So

[Qemu-devel] [PATCH] virtio: verify that all outstanding buffers are flushed (was Re: vmstate conversion for virtio?)

2012-12-05 Thread Michael S. Tsirkin
Add sanity check to address the following concern: On Wed, Dec 05, 2012 at 09:47:22AM +1030, Rusty Russell wrote: > All we need is the index of the request; the rest can be re-read from > the ring. I'd like to point out that this is not generally true if any available requests are outstanding. Im

Re: [Qemu-devel] [PATCH 4/4] exec: refactor cpu_restore_state

2012-12-05 Thread Andreas Färber
Am 04.12.2012 22:20, schrieb Blue Swirl: > Refactor common code around calls to cpu_restore_state(). > > tb_find_pc() has now no external users, make it static. > > Signed-off-by: Blue Swirl Would've been nice to get CC'ed on the refactoring of a cpu_* function... I've reviewed mostly the non-

Re: [Qemu-devel] [PATCH] target-i386: honor CR0_PG_MASK in cpu_get_phys_page_debug

2012-12-05 Thread Andreas Färber
Am 17.11.2012 21:52, schrieb Max Filippov: > cpu_get_phys_page_debug is not in sync with cpu_x86_handle_mmu_fault: > the latter first checks CR0_PG_MASK and only after CR4_PAE_MASK. > > This fixes odd gdb code display with PAE enabled. > > Signed-off-by: Max Filippov You write, they are "not in

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-12-05 Thread Michael S. Tsirkin
On Wed, Dec 05, 2012 at 09:31:56AM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 29, 2012 at 04:36:08PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 29, 2012 at 03:26:56PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Nov 29, 2012 at 03:54:25PM +0200, Michael S. Tsirkin wrote: > > > > On Thu, Nov 2

Re: [Qemu-devel] [PATCH 3/6] target-i386: use define for cpuid vendor string size

2012-12-05 Thread Andreas Färber
Am 04.12.2012 20:38, schrieb Eduardo Habkost: > On Tue, Dec 04, 2012 at 05:34:40PM -0200, Eduardo Habkost wrote: >> From: Igor Mammedov >> >> Signed-off-by: Igor Mammedov > > Reviewed-by: Eduardo Habkost As a reminder, when you submit patches, I need your Sob added. In these particular cases,

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-12-05 Thread Janne Karhunen
Some kind of semi-workaround patch attached. It seems to leave this kind of race window for me (for select which is worse): 0x6004bf98 <+136>: xor%r8d,%r8d 0x6004bf9b <+139>: test %eax,%eax 0x6004bf9d <+141>: jne0x6004c2b7 0x6004bfa3 <+1

Re: [Qemu-devel] [PATCH v6 2/2] qemu-ga: sample fsfreeze hooks

2012-12-05 Thread Luiz Capitulino
On Wed, 05 Dec 2012 17:41:08 +0900 Tomoki Sekiyama wrote: > On 2012/12/05 1:51, Luiz Capitulino wrote: > > On Fri, 30 Nov 2012 22:33:57 +0900 > > Tomoki Sekiyama wrote: > > > >> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. > >> - fsfreeze-hook : execute scripts in fsfreeze-

Re: [Qemu-devel] [PATCH] target-i386: honor CR0_PG_MASK in cpu_get_phys_page_debug

2012-12-05 Thread Max Filippov
On Wed, Dec 5, 2012 at 3:15 PM, Andreas Färber wrote: > Am 17.11.2012 21:52, schrieb Max Filippov: >> cpu_get_phys_page_debug is not in sync with cpu_x86_handle_mmu_fault: >> the latter first checks CR0_PG_MASK and only after CR4_PAE_MASK. >> >> This fixes odd gdb code display with PAE enabled. >>

Re: [Qemu-devel] [PATCH 3/6] target-i386: use define for cpuid vendor string size

2012-12-05 Thread Eduardo Habkost
On Wed, Dec 05, 2012 at 12:29:06PM +0100, Andreas Färber wrote: > Am 04.12.2012 20:38, schrieb Eduardo Habkost: > > On Tue, Dec 04, 2012 at 05:34:40PM -0200, Eduardo Habkost wrote: > >> From: Igor Mammedov > >> > >> Signed-off-by: Igor Mammedov > > > > Reviewed-by: Eduardo Habkost > > As a rem

Re: [Qemu-devel] [PATCH 3/6] target-i386: use define for cpuid vendor string size

2012-12-05 Thread Igor Mammedov
On Wed, 5 Dec 2012 09:51:25 -0200 Eduardo Habkost wrote: > On Wed, Dec 05, 2012 at 12:29:06PM +0100, Andreas Färber wrote: > > Am 04.12.2012 20:38, schrieb Eduardo Habkost: > > > On Tue, Dec 04, 2012 at 05:34:40PM -0200, Eduardo Habkost wrote: > > >> From: Igor Mammedov > > >> > > >> Signed-off-

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-12-05 Thread Ubuntu Foundations Team Bug Bot
The attachment "racy workaround patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patc

[Qemu-devel] [PATCH 1/1] tmp105: Create API for TMP105 temperature sensor.

2012-12-05 Thread Alex Horn
* Define enum for TMP105 registers * Move tmp105_set() from I2C to TMP105 header * Document units and range of temperature as preconditions Signed-off-by: Alex Horn --- hw/i2c.h|3 -- hw/tmp105.c | 17 --- hw/tmp105.h | 67 +

Re: [Qemu-devel] [PATCH] virtfs-proxy-helper: check return code of setfsgid/setfsuid

2012-12-05 Thread Paolo Bonzini
Il 05/12/2012 09:35, Aneesh Kumar K.V ha scritto: > I have tested the below patch. Currently i don't have a signed-off-by on > the patch. One change noted by mohan which I incorporated in the patch > is we need to call setresgid before calling setresuid. If you are ok > with this change I can send

Re: [Qemu-devel] [PATCH 1/1] tmp105: Create API for TMP105 temperature sensor.

2012-12-05 Thread Andreas Färber
Am 05.12.2012 13:34, schrieb Alex Horn: > * Define enum for TMP105 registers > * Move tmp105_set() from I2C to TMP105 header > * Document units and range of temperature as preconditions > > Signed-off-by: Alex Horn Looks great, thanks! Reviewed-by: Andreas Färber Cheers, Andreas -- SUSE LIN

Re: [Qemu-devel] [PULL for-1.3 0/3] seabios update

2012-12-05 Thread Gerd Hoffmann
On 12/05/12 11:49, Brad Campbell wrote: > On 30/11/12 23:29, Gerd Hoffmann wrote: >>Hi, >> >> This pull updates seabios to current master. The seabios q35 patches >> didn't land upstream yet so they miss the boat unfortunaly. As this >> update brings an important regression fix we can't wait

Re: [Qemu-devel] [PATCH v4 04/11] dataplane: add virtqueue vring code

2012-12-05 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 02:50:01PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 22, 2012 at 04:16:45PM +0100, Stefan Hajnoczi wrote: > > The virtio-blk-data-plane cannot access memory using the usual QEMU > > functions since it executes outside the global mutex and the memory APIs > > are this ti

[Qemu-devel] [PATCH v2 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-12-05 Thread Alberto Garcia
Hello again, I'm sending the new version of my TPCI200 and IP-Octal 232 patches, here's the original submission for reference: https://lists.gnu.org/archive/html/qemu-devel/2012-08/msg04173.html It's been a while since I posted the previous patches. I was on holidays for quite some time, plus t

[Qemu-devel] [PATCH v2 2/2] Add GE IP-Octal 232 IndustryPack emulation

2012-12-05 Thread Alberto Garcia
The GE IP-Octal 232 is an IndustryPack module that implements eight RS-232 serial ports, each one of which can be redirected to a character device in the host. Signed-off-by: Alberto Garcia --- hw/Makefile.objs |2 +- hw/ipoctal.c | 613 +

[Qemu-devel] [PATCH v2 1/2] Add TEWS TPCI200 IndustryPack emulation

2012-12-05 Thread Alberto Garcia
The TPCI200 is a PCI board that supports up to 4 IndustryPack modules. A new bus type called 'IndustryPack' has been created so any compatible module can be attached to this board. Signed-off-by: Alberto Garcia --- default-configs/pci.mak |1 + hw/Makefile.objs|3 + hw/ipack.c

[Qemu-devel] [Bug 1086745] [NEW] serial port data THRE comes too early

2012-12-05 Thread Kees Schoenmakers
Public bug reported: When using a serial port with a Linux guest (and host) and the application uses hardware handshake, this fails because the handling of TEMT and/or THRE is not operating properly in such cases. As long as it takes _time_ for the 'real' port to output the data TEMT may not retu

[Qemu-devel] [Bug 1086782] [NEW] HPET time drift windows 7 64bits guest

2012-12-05 Thread Carlos-velasco
Public bug reported: Using latest qemu-kvm (1.2.0), time drift (clock slow in guest) in Windows 7 64 bits guest when HPET is enabled (default). Disabling HPET (-no-hpet) solves the time drift. UsePlatformClock enable/disable doesn't make a difference in the guest. bcdedit /set useplatformclock t

[Qemu-devel] [Bug 1086745] Re: serial port data THRE comes too early

2012-12-05 Thread Lei Li
Could you please give more details, like the steps to reproduce this problems. Thanks. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1086745 Title: serial port data THRE comes too early Status in

Re: [Qemu-devel] [PATCH v2 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-12-05 Thread Andreas Färber
Hello Alberto, Am 05.12.2012 14:16, schrieb Alberto Garcia: > > Hello again, > > I'm sending the new version of my TPCI200 and IP-Octal 232 patches, [snip] You may want to resend v2 as inline patches - Thunderbird for instance doesn't allow to quote / comment on attachments. Andreas -- SUSE

[Qemu-devel] qmp query-balloon return only "actual" value ?

2012-12-05 Thread Alexandre DERUMIER
Hi, I'm trying to use qmp "query-balloon", to get stats, >From Doc, I expect to have -> { "execute": "query-balloon" } <- { "return":{ "actual":1073741824, "mem_swapped_in":0, "mem_swapped_out":0, "major_page_faults":142, "minor_page_faults":239

Re: [Qemu-devel] [PATCH 08/13] pseries: Update SLOF for NVRAM support

2012-12-05 Thread Erlon Cruz
Hi Alex, > Could you please post > > * the exact command line you were using > ./ppc64-softmmu/qemu-system-ppc64 -machine type=pseries,usb=off -m 512 -net nic,vlan=0 -net tap -nographic -cdrom /exports/isos/SLES-11-SP2-DVD-ppc64-GM-DVD1.iso -hda /exports/sles11_sp2.qcow2 -monitor unix:/dev/tt

[Qemu-devel] [PATCH v2 1/2] pc_sysfw: Check for qemu_find_file() failure

2012-12-05 Thread Markus Armbruster
pc_fw_add_pflash_drv() ignores qemu_find_file() failure, and happily creates a drive without a medium. When pc_system_flash_init() asks for its size, bdrv_getlength() fails with -ENOMEDIUM, which isn't checked either. It fails relatively cleanly only because -ENOMEDIUM isn't a multiple of 4096:

Re: [Qemu-devel] [PATCH 08/13] pseries: Update SLOF for NVRAM support

2012-12-05 Thread Alexander Graf
On 05.12.2012, at 15:09, Erlon Cruz wrote: > Hi Alex, > > Could you please post > > * the exact command line you were using > > ./ppc64-softmmu/qemu-system-ppc64 -machine type=pseries,usb=off -m 512 -net > nic,vlan=0 -net tap -nographic -cdrom > /exports/isos/SLES-11-SP2-DVD-ppc64-GM-DVD

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/13] pseries: Update SLOF for NVRAM support

2012-12-05 Thread Alexander Graf
On 05.12.2012, at 15:35, Alexander Graf wrote: > > On 05.12.2012, at 15:09, Erlon Cruz wrote: > >> Hi Alex, >> >> Could you please post >> >> * the exact command line you were using >> >> ./ppc64-softmmu/qemu-system-ppc64 -machine type=pseries,usb=off -m 512 -net >> nic,vlan=0 -net tap

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/13] pseries: Update SLOF for NVRAM support

2012-12-05 Thread Alexander Graf
On 05.12.2012, at 15:37, Alexander Graf wrote: > > On 05.12.2012, at 15:35, Alexander Graf wrote: > >> >> On 05.12.2012, at 15:09, Erlon Cruz wrote: >> >>> Hi Alex, >>> >>> Could you please post >>> >>> * the exact command line you were using >>> >>> ./ppc64-softmmu/qemu-system-ppc64 -

Re: [Qemu-devel] [RFC 8/8] qom: make CPU a child of DeviceState

2012-12-05 Thread Andreas Färber
Am 04.12.2012 14:19, schrieb Eduardo Habkost: > From: Igor Mammedov > > Signed-off-by: Igor Mammedov > [ehabkost: change CPU type declaration to hae TYPE_DEVICE as parent] > Signed-off-by: Eduardo Habkost > --- > Yes, there is "changelog" data before the "---" mark, but I believe that > in this

Re: [Qemu-devel] [PULL for-1.3 0/3] seabios: q35 update

2012-12-05 Thread Gabriel L. Somlo
On Wed, Dec 05, 2012 at 07:50:17AM +0100, Gerd Hoffmann wrote: > Ok, so no IRQ declared for the RTC. We have IRQ 8 for both rtc and > hpet, which most likely is the root cause for the issue. You can try > simply dropping the line for testing. I'll try to come up with > something more clever as t

Re: [Qemu-devel] [RFC 0/8] CPU DeviceState v9

2012-12-05 Thread Andreas Färber
Am 04.12.2012 17:40, schrieb Eduardo Habkost: > On Tue, Dec 04, 2012 at 04:59:38PM +0100, Andreas Färber wrote: >> Am 04.12.2012 14:19, schrieb Eduardo Habkost: >>> Changes on v9: >>> - Instead of moving qemu_[un]register_reset() to reset.c and including >>>it on *-user, create stubs for them

[Qemu-devel] [PATCH 2/6] spice-qemu-char: factor out CharDriverState creation

2012-12-05 Thread Marc-André Lureau
Make the CharDriverState creation code reusable by spicevmc port. --- spice-qemu-char.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index 665efd3..b86e83a 100644 --- a/spice-qemu-char.c +++ b/spic

[Qemu-devel] [PATCH 4/6] spice-qemu-char: keep a list of spice chardev

2012-12-05 Thread Marc-André Lureau
--- spice-qemu-char.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index 4be75ba..4eb85ae 100644 --- a/spice-qemu-char.c +++ b/spice-qemu-char.c @@ -24,8 +24,12 @@ typedef struct SpiceCharDriver { uint8_t *datapos; ssize_t

[Qemu-devel] [PATCH 5/6] spice-qemu-char: register spicevmc ports during qemu_spice_init()

2012-12-05 Thread Marc-André Lureau
Do the delayed registration of spicevmc ports after Spice server is initialized. --- spice-qemu-char.c | 12 ui/qemu-spice.h | 1 + ui/spice-core.c | 4 3 files changed, 17 insertions(+) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index 4eb85ae..b2586c2 100644 --- a

[Qemu-devel] [PATCH 1/6] spice-qemu-char: write to chardev whatever amount it can read

2012-12-05 Thread Marc-André Lureau
The current code waits until the chardev can read MIN(len, VMC_MAX) But some chardev may never reach than amount, in fact some of them will only ever accept write of 1. Fix the min computation and remove the VMC_MAX constant. --- spice-qemu-char.c | 6 ++ 1 file changed, 2 insertions(+), 4 del

Re: [Qemu-devel] [PATCH v2] target-mips: Fix incorrect shift for SHILO and SHILOV

2012-12-05 Thread Richard Henderson
On 2012-12-04 17:29, Petar Jovanovic wrote: > rs5_0 = (int8_t)(rs5_0 << 2) >> 2; This is more portably written as rs5_0 = (rs5_0 ^ 0x20) - 0x20; r~

[Qemu-devel] [PATCH 3/6] spice-qemu-char: add spiceport chardev

2012-12-05 Thread Marc-André Lureau
Add a new spice chardev to allow arbitrary communication between the host and the Spice client via the spice server. Examples: This allows the Spice client to have a special port for the qemu monitor: ... -chardev spiceport,name=org.qemu.monitor,id=monitorport -mon chardev=monitorport v2: -

[Qemu-devel] [PATCH v3 2/2] Add GE IP-Octal 232 IndustryPack emulation

2012-12-05 Thread Alberto Garcia
The GE IP-Octal 232 is an IndustryPack module that implements eight RS-232 serial ports, each one of which can be redirected to a character device in the host. Signed-off-by: Alberto Garcia --- hw/Makefile.objs |2 +- hw/ipoctal.c | 613 ++

Re: [Qemu-devel] [PATCH v2] target-mips: Fix incorrect shift for SHILO and SHILOV

2012-12-05 Thread Peter Maydell
On 5 December 2012 15:36, Richard Henderson wrote: > On 2012-12-04 17:29, Petar Jovanovic wrote: >> rs5_0 = (int8_t)(rs5_0 << 2) >> 2; > > This is more portably written as > > rs5_0 = (rs5_0 ^ 0x20) - 0x20; ...but way more obscurely. If we want to play that kind of game can we have a sign-

Re: [Qemu-devel] [RFC 8/8] qom: make CPU a child of DeviceState

2012-12-05 Thread Eduardo Habkost
On Wed, Dec 05, 2012 at 03:48:10PM +0100, Andreas Färber wrote: > Am 04.12.2012 14:19, schrieb Eduardo Habkost: [...] > > @@ -43,7 +44,7 @@ static void cpu_class_init(ObjectClass *klass, void *data) > > > > static TypeInfo cpu_type_info = { > > .name = TYPE_CPU, > > -.parent = TYPE_OBJE

[Qemu-devel] [PATCH v3 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-12-05 Thread Alberto Garcia
As requested by Andreas, I'm sending them again as inline patches. I also changed the name of the VMStateDescription struct from ipoctal to ipoctal232. Otherwise they're the same. Regards, Alberto Garcia (2): Add TEWS TPCI200 IndustryPack emulation Add GE IP-Octal 232 IndustryPack emulation

Re: [Qemu-devel] [PATCH v2] target-mips: Fix incorrect shift for SHILO and SHILOV

2012-12-05 Thread Richard Henderson
On 2012-12-05 09:49, Peter Maydell wrote: > On 5 December 2012 15:36, Richard Henderson wrote: >> On 2012-12-04 17:29, Petar Jovanovic wrote: >>> rs5_0 = (int8_t)(rs5_0 << 2) >> 2; >> >> This is more portably written as >> >> rs5_0 = (rs5_0 ^ 0x20) - 0x20; > > ...but way more obscurely. If

[Qemu-devel] [PATCH v3 1/2] Add TEWS TPCI200 IndustryPack emulation

2012-12-05 Thread Alberto Garcia
The TPCI200 is a PCI board that supports up to 4 IndustryPack modules. A new bus type called 'IndustryPack' has been created so any compatible module can be attached to this board. Signed-off-by: Alberto Garcia --- default-configs/pci.mak |1 + hw/Makefile.objs|3 + hw/ipack.c

[Qemu-devel] [PATCH 6/6] docs: add spice-port-fqdn.txt

2012-12-05 Thread Marc-André Lureau
Start a simple org.qemu.* registry of well known name. --- docs/spice-port-fqdn.txt | 19 +++ 1 file changed, 19 insertions(+) create mode 100644 docs/spice-port-fqdn.txt diff --git a/docs/spice-port-fqdn.txt b/docs/spice-port-fqdn.txt new file mode 100644 index 000..5077895

Re: [Qemu-devel] [PATCH 2/6] target-i386: cpu: separate feature string parsing from CPU model lookup

2012-12-05 Thread Andreas Färber
Am 04.12.2012 20:34, schrieb Eduardo Habkost: > Instead of using parsing the whole cpu_model string inside Dropped "using". > cpu_x86_find_by_name(), first split it into the CPU model name and the > full feature string, then parse the feature string into pieces. [...] > diff --git a/target-i386/c

Re: [Qemu-devel] [PATCH 24/37] target-i386: use define for cpuid vendor string size

2012-12-05 Thread Andreas Färber
Am 22.10.2012 17:03, schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov Thanks, applied to qom-cpu: https://github.com/afaerber/qemu-cpu/commits/qom-cpu Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG

Re: [Qemu-devel] [PATCH 14/37] target-i386: postpone cpuid_level update to realize time

2012-12-05 Thread Andreas Färber
Am 22.10.2012 17:03, schrieb Igor Mammedov: > delay capping cpuid_level to 7 to realize time so property setters > for cpuid_7_0_ebx_features and "level" could be used in any order/time > between x86_cpu_initfn() and x86_cpu_realize(). > > Signed-off-by: Igor Mammedov Thanks, rebased and applied

Re: [Qemu-devel] [PATCH 0/6] short x86 CPU init cleanup (v3)

2012-12-05 Thread Andreas Färber
Am 04.12.2012 20:34, schrieb Eduardo Habkost: > Igor Mammedov (4): > target-i386: use define for cpuid vendor string size > target-i386: postpone cpuid_level update to realize time Applied Igor's earlier signed off versions of these to qom-cpu, spotting no semantic difference: https://github.c

Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.

2012-12-05 Thread Peter Maydell
On 4 December 2012 14:35, wrote: > From: KONRAD Frederic > > Create virtio-blk which extends virtio-device, so it can be connected on > virtio-bus. > > Signed-off-by: KONRAD Frederic > --- > hw/virtio-blk.c | 170 > > hw/virtio-blk.h |

[Qemu-devel] [PULL] VirtFS update

2012-12-05 Thread Aneesh Kumar K.V
The following changes since commit 16c6c80ac3a772b42a87b77dfdf0fdac7c607b0e: Open up 1.4 development branch (2012-12-03 14:08:40 -0600) are available in the git repository at: git://github.com/kvaneesh/qemu.git for-upstream for you to fetch changes up to 9fd2ecdc8cb2dc1a8a7c57b6c9c60bc9947

Re: [Qemu-devel] [PATCH v2] target-mips: Fix incorrect shift for SHILO and SHILOV

2012-12-05 Thread Peter Maydell
On 5 December 2012 15:51, Richard Henderson wrote: > On 2012-12-05 09:49, Peter Maydell wrote: >> On 5 December 2012 15:36, Richard Henderson wrote: >>> On 2012-12-04 17:29, Petar Jovanovic wrote: rs5_0 = (int8_t)(rs5_0 << 2) >> 2; >>> >>> This is more portably written as >>> >>> rs5_

[Qemu-devel] [PATCH 0/8] CPU DeviceState v10

2012-12-05 Thread Eduardo Habkost
Changes on v10: - Set no_user=1 on CPU class - Coding style fixes - Sending as PATCH instead of RFC, now v9: - Instead of moving qemu_[un]register_reset() to reset.c and including it on *-user, create stubs for them on libqemustub.a - This is based on afaerber's qom-cpu branch, that has so

[Qemu-devel] [PATCH 4/8] libqemustub: sysbus_get_default() stub

2012-12-05 Thread Eduardo Habkost
The stub will be used on cases where sysbus.c is not compiled in (e.g. *-user). Note that code that uses NULL as the bus with qdev{_try,}_create() implicitly uses sysbus_get_default() as the bus, and will still require sysbus.c to be compiled in. Signed-off-by: Eduardo Habkost --- Changes v1 ->

[Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState

2012-12-05 Thread Eduardo Habkost
This finally makes the CPU class a child of DeviceState, allowing us to start using DeviceState properties on CPU subclasses. It has no_user=1, as creating CPUs using -device doesn't work yet. (based on a previous patch from Igor Mammedov) Signed-off-by: Eduardo Habkost --- Changes v1 (imammedo

[Qemu-devel] [PATCH 7/8] include qdev code into *-user, too

2012-12-05 Thread Eduardo Habkost
The code depends on some functions from qemu-option.o, so add qemu-option.o to universal-obj-y to make sure it's included. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: - Keep files on the hw/ directory (it's simply easier to keep them there, as qdev.o depends on irq.o) - Add a $(hw-c

[Qemu-devel] [PATCH 1/8] Move -I$(SRC_PATH)/include compiler flag to Makefile.objs

2012-12-05 Thread Eduardo Habkost
The flag is necessary for code that doesn't use the variables from Makefile (but use Makefile.objs), like libcacard/ and stubs/. This also moves the existing CFLAGS lines from Makefile.objs at the beginning of the file, to keep them all in the same place. Signed-off-by: Eduardo Habkost --- Make

Re: [Qemu-devel] [PULL 00/18] acpi: switch to memory api

2012-12-05 Thread Andreas Färber
Am 04.12.2012 17:05, schrieb Gerd Hoffmann: > On 12/04/12 16:57, Andreas Färber wrote: >> Am 04.12.2012 14:04, schrieb Gerd Hoffmann: >>> Same patches as posted last week. No review comments, 1.4 tree >>> open, so it should be ready to go in now. >> >> That's not quite true - you ignored my review

[Qemu-devel] [PATCH 3/8] libqemustub: vmstate register/unregister stubs

2012-12-05 Thread Eduardo Habkost
Add vmstate stub functions, so that qdev.o can be used without savevm.o when vmstate support is not necessary (i.e. by *-user). Signed-off-by: Eduardo Habkost --- Originally submitted as: Subject: qdev-core: isolate vmstate handling into separate functions Changes v1 -> v2: - Add GCC_WEAK_DEC

[Qemu-devel] [PATCH 6/8] qdev-properties.c: Separate core from the code used only by qemu-system-*

2012-12-05 Thread Eduardo Habkost
This separates the qdev properties code in two parts: - qdev-properties.c, that contains most of the qdev properties code; - qdev-properties-system.c for code specific for qemu-system-*, containing: - Property types: drive, chr, netdev, vlan, that depend on code that won't be included

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] Make default boot order machine specific

2012-12-05 Thread Avik Sil
On 10/26/2012 05:15 PM, Alexander Graf wrote: > > On 25.10.2012, at 22:57, Alexander Graf wrote: > >> >> On 25.10.2012, at 22:50, Peter Maydell wrote: >> >>> On 25 October 2012 21:18, Anthony Liguori wrote: The other approach to this would be: static QEMUMachine pseries_machine =

[Qemu-devel] [PATCH 2/8] libqemustub: Add qemu_[un]register_reset() stubs

2012-12-05 Thread Eduardo Habkost
This will be useful for code that don't call qemu_devices_reset() (e.g. *-user). If qemu_devices_reset() is never called, it means we don't need to keep track of the reset handler list. Signed-off-by: Eduardo Habkost --- stubs/Makefile.objs | 1 + stubs/reset.c | 13 + 2 files

Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.

2012-12-05 Thread Andreas Färber
Am 05.12.2012 17:25, schrieb Peter Maydell: > On 4 December 2012 14:35, wrote: >> From: KONRAD Frederic >> >> Create virtio-blk which extends virtio-device, so it can be connected on >> virtio-bus. >> >> Signed-off-by: KONRAD Frederic >> --- >> hw/virtio-blk.c | 170 >> +++

[Qemu-devel] [PATCH 5/8] qdev: Coding style fixes

2012-12-05 Thread Eduardo Habkost
Add missing braces and break lines larger than 80 chars. Signed-off-by: Eduardo Habkost --- hw/qdev-properties.c | 53 ++-- hw/qdev.c| 3 ++- 2 files changed, 37 insertions(+), 19 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qd

Re: [Qemu-devel] [PATCH 5/6] add visitor for parsing hz[KMG] input string

2012-12-05 Thread mdroth
On Tue, Dec 04, 2012 at 05:34:42PM -0200, Eduardo Habkost wrote: > From: Igor Mammedov > > Signed-off-by: Igor Mammedov > Acked-by: Andreas Färber > --- > qapi/qapi-visit-core.c | 11 +++ > qapi/qapi-visit-core.h | 2 ++ > qapi/string-input-visitor.c | 22 +++

[Qemu-devel] [PATCH] e1000: Discard oversized packets based on SBP|LPE

2012-12-05 Thread Michael Contreras
Discard packets longer than 16384 when !SBP to match the hardware behavior. Signed-off-by: Michael Contreras --- hw/e1000.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index 5537ad2..e772c8e 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -61,6

Re: [Qemu-devel] [Bug 1075252] Re: qemu-img cannot read VMDK4 file

2012-12-05 Thread Robert Hubbard
Hi Stefan, Good exercise, I just pulled the latest branch. The block/vmdk.c has been completely revised and includes the correct code for vmdk4 support now for the vmdk compressed stream optimized. I also "missed" for the git-patch the fact i needed "master" in the command, this worked and thanks

Re: [Qemu-devel] [PULL for-1.3 0/3] seabios update

2012-12-05 Thread Brad Campbell
On 05/12/12 20:47, Gerd Hoffmann wrote: On 12/05/12 11:49, Brad Campbell wrote: On 30/11/12 23:29, Gerd Hoffmann wrote: Hi, This pull updates seabios to current master. The seabios q35 patches didn't land upstream yet so they miss the boat unfortunaly. As this update brings an important

Re: [Qemu-devel] [RFC] 1.4 release schedule

2012-12-05 Thread Blue Swirl
On Tue, Dec 4, 2012 at 10:00 PM, Anthony Liguori wrote: > Peter Maydell writes: > >> On 4 December 2012 18:38, Blue Swirl wrote: >>> The definition of the hard freeze bothers me. A few patches that went >>> in after 1.3-rc0 were not bug fixes but just new features, so the >>> difference between

Re: [Qemu-devel] [PATCH 5/6] add visitor for parsing hz[KMG] input string

2012-12-05 Thread Eduardo Habkost
On Wed, Dec 05, 2012 at 11:52:29AM -0600, mdroth wrote: > On Tue, Dec 04, 2012 at 05:34:42PM -0200, Eduardo Habkost wrote: [...] > > diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c > > index 497eb9a..74fe395 100644 > > --- a/qapi/string-input-visitor.c > > +++ b/qapi/string-i

Re: [Qemu-devel] [RFC] 1.4 release schedule

2012-12-05 Thread Hans de Goede
Hi, On 12/05/2012 08:28 PM, Blue Swirl wrote: On Tue, Dec 4, 2012 at 10:00 PM, Anthony Liguori wrote: Peter Maydell writes: On 4 December 2012 18:38, Blue Swirl wrote: The definition of the hard freeze bothers me. A few patches that went in after 1.3-rc0 were not bug fixes but just new fe

Re: [Qemu-devel] [PATCH 4/4] exec: refactor cpu_restore_state

2012-12-05 Thread Blue Swirl
On Wed, Dec 5, 2012 at 11:10 AM, Andreas Färber wrote: > Am 04.12.2012 22:20, schrieb Blue Swirl: >> Refactor common code around calls to cpu_restore_state(). >> >> tb_find_pc() has now no external users, make it static. >> >> Signed-off-by: Blue Swirl > > Would've been nice to get CC'ed on the r

[Qemu-devel] [Bug 1086745] TEMT comes too early (QEMU/KVM)

2012-12-05 Thread Kees Schoenmakers
Hello, It is a Linux host and a Linux guest. One serial port (/dev/ttyS0) is passed from the host to the guest. The application (on the guest) does Hart (r) communication, This is done with a 1200 baud simplex modem (one side at a time). The application raises RTS so that the modem goes in trans

Re: [Qemu-devel] [PATCH] target-mips: Fix incorrect code and test for INSV

2012-12-05 Thread Johnson, Eric
> -Original Message- > From: qemu-devel-bounces+ericj=mips@nongnu.org [mailto:qemu-devel- > bounces+ericj=mips@nongnu.org] On Behalf Of Petar Jovanovic > Sent: Monday, November 26, 2012 7:13 AM > To: qemu-devel@nongnu.org > Cc: Jovanovic, Petar; aurel...@aurel32.net > Subject: [Qemu

[Qemu-devel] [PATCH 1/1] tmp105: Fix I2C protocol bug

2012-12-05 Thread Alex Horn
The private buffer length field must only be incremented after the I2C frame has been transmitted. To expose this bug, assume the temperature in the TMP105 hardware model is +0.125 C (e.g. snow slush). Note that eleven bit precision is required to read this value; otherwise the reading is equal to

Re: [Qemu-devel] [RFC] 1.4 release schedule

2012-12-05 Thread Blue Swirl
On Wed, Dec 5, 2012 at 7:41 PM, Hans de Goede wrote: > Hi, > > > On 12/05/2012 08:28 PM, Blue Swirl wrote: >> >> On Tue, Dec 4, 2012 at 10:00 PM, Anthony Liguori >> wrote: >>> >>> Peter Maydell writes: >>> On 4 December 2012 18:38, Blue Swirl wrote: > > The definition of the hard f

Re: [Qemu-devel] [BUG] QEMU crashes when 64bit BAR is present

2012-12-05 Thread Alexey Korolev
Hi Gerd, > Hi, > >> And qemu error output is: >> qemu: /home/akorolev/qemu-kvm/exec.c:2255: register_subpage: Assertion >> `existing->mr->subpage || existing->mr == &io_mem_unassigned' failed. >> >> Guest OS is Centos 5.5 and log is pretty boring, as qemu crashes before >> Linux can report an i

Re: [Qemu-devel] [BUG] QEMU crashes when 64bit BAR is present

2012-12-05 Thread Alexey Korolev
On 06/12/12 09:23, Alexey Korolev wrote: > Hi Gerd, >> Hi, >> >>> And qemu error output is: >>> qemu: /home/akorolev/qemu-kvm/exec.c:2255: register_subpage: Assertion >>> `existing->mr->subpage || existing->mr == &io_mem_unassigned' failed. >>> >>> Guest OS is Centos 5.5 and log is pretty boring

Re: [Qemu-devel] [PATCH v2] target-mips: Fix incorrect shift for SHILO and SHILOV

2012-12-05 Thread Johnson, Eric
> -Original Message- > From: qemu-devel-bounces+ericj=mips@nongnu.org [mailto:qemu-devel- > bounces+ericj=mips@nongnu.org] On Behalf Of Petar Jovanovic > Sent: Tuesday, December 04, 2012 3:29 PM > To: qemu-devel@nongnu.org > Cc: blauwir...@gmail.com; Jovanovic, Petar; rth7...@gmail.

[Qemu-devel] [PATCH 01/11] qdev: export and use qbus_init

2012-12-05 Thread Paolo Bonzini
BusState subclasses need to do their own allocation because qbus_create_inplace calls object_initialize (which wipes out the "free" callback). This patch separates the initialization of the object (object_initialize) from its insertion in the qdev tree (qbus_realize); to do so, it moves the remain

  1   2   >