[Qemu-devel] [PATCH 18/18] acpi: drop debug port

2012-12-04 Thread Gerd Hoffmann
I'm pretty sure this isn't needed any more. I think this predates the switch to seabios, and the seabios DSDT table has a DBUG() aml macro which writes stuff to the seabios debug port (0x402). Signed-off-by: Gerd Hoffmann --- hw/acpi_piix4.c |9 - 1 files changed, 0 insertions(+), 9

[Qemu-devel] [PATCH 02/18] apci: switch ich9 to memory api

2012-12-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/acpi_ich9.c | 44 +++- hw/acpi_ich9.h |1 + 2 files changed, 28 insertions(+), 17 deletions(-) diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c index 61034d3..bf361ec 100644 --- a/hw/acpi_ich9.c +++ b/hw/acpi_ich9.c @@

[Qemu-devel] [PATCH 15/18] acpi: remove acpi_gpe_blk

2012-12-04 Thread Gerd Hoffmann
With gpe being switched to memory api this is no longer needed. Signed-off-by: Gerd Hoffmann --- hw/acpi.c |7 --- hw/acpi.h |2 -- hw/acpi_ich9.c |1 - hw/acpi_piix4.c |1 - 4 files changed, 0 insertions(+), 11 deletions(-) diff --git a/hw/acpi.c b/hw/acpi.c in

[Qemu-devel] [PATCH 09/18] apci: switch ich9 gpe to memory api

2012-12-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/acpi_ich9.c | 38 -- hw/acpi_ich9.h |1 + 2 files changed, 29 insertions(+), 10 deletions(-) diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c index 3b5bac6..5fc160a 100644 --- a/hw/acpi_ich9.c +++ b/hw/acpi_ich9.c @@ -73,1

[Qemu-devel] [PULL 00/18] acpi: switch to memory api

2012-12-04 Thread Gerd Hoffmann
Hi, Same patches as posted last week. No review comments, 1.4 tree open, so it should be ready to go in now. cheers, Gerd The following changes since commit 16c6c80ac3a772b42a87b77dfdf0fdac7c607b0e: Open up 1.4 development branch (2012-12-03 14:08:40 -0600) are available in the git repo

[Qemu-devel] [RFC 4/8] libqemustub: vmstate register/unregister stubs

2012-12-04 Thread Eduardo Habkost
Add vmstate stub functions, so that qdev.o can be used without savevm.o when vmstate support is not necessary (i.e. by *-user). Signed-off-by: Eduardo Habkost --- Originally submitted as: Subject: qdev-core: isolate vmstate handling into separate functions Changes v1 -> v2: - Add GCC_WEAK_DEC

[Qemu-devel] [PATCH 01/18] apci: switch piix4 to memory api

2012-12-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/acpi_piix4.c | 41 - 1 files changed, 24 insertions(+), 17 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 519269a..320e045 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -28,6 +28,7 @@ #inclu

[Qemu-devel] [RFC 7/8] include qdev code into *-user, too

2012-12-04 Thread Eduardo Habkost
The code depends on some functions from qemu-option.o, so add qemu-option.o to universal-obj-y to make sure it's included. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: - Keep files on the hw/ directory (it's simply easier to keep them there, as qdev.o depends on irq.o) - Add a $(hw-c

[Qemu-devel] [PATCH 10/18] apci: switch ich9 smi to memory api

2012-12-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/acpi_ich9.c | 46 -- hw/acpi_ich9.h |1 + 2 files changed, 37 insertions(+), 10 deletions(-) diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c index 5fc160a..0ed17da 100644 --- a/hw/acpi_ich9.c +++ b/hw/acpi_ich9.c

[Qemu-devel] [RFC 8/8] qom: make CPU a child of DeviceState

2012-12-04 Thread Eduardo Habkost
From: Igor Mammedov Signed-off-by: Igor Mammedov [ehabkost: change CPU type declaration to hae TYPE_DEVICE as parent] Signed-off-by: Eduardo Habkost --- Yes, there is "changelog" data before the "---" mark, but I believe that in this case they are important to indicate authorship and the scope

[Qemu-devel] [PATCH 08/18] acpi: cleanup vt82c686 memory region

2012-12-04 Thread Gerd Hoffmann
Nothing left to do, everything handled by subregions, we can zap the reaw/write handlers now. Signed-off-by: Gerd Hoffmann --- hw/vt82c686.c | 61 + 1 files changed, 1 insertions(+), 60 deletions(-) diff --git a/hw/vt82c686.c b/hw/vt82c6

[Qemu-devel] [PATCH 03/18] apci: switch vt82c686 to memory api

2012-12-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/vt82c686.c | 37 +++-- 1 files changed, 27 insertions(+), 10 deletions(-) diff --git a/hw/vt82c686.c b/hw/vt82c686.c index 5d7c00c..3fc6063 100644 --- a/hw/vt82c686.c +++ b/hw/vt82c686.c @@ -24,6 +24,7 @@ #include "pm_smbus.h

[Qemu-devel] [PATCH 07/18] acpi: cleanup piix4 memory region

2012-12-04 Thread Gerd Hoffmann
Nothing left to do, everything handled by subregions, we can zap the reaw/write handlers now. Signed-off-by: Gerd Hoffmann --- hw/acpi_piix4.c | 41 + 1 files changed, 1 insertions(+), 40 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index

[Qemu-devel] [RFC 1/8] move -I$(SRC_PATH)/include compiler flag to Makefile.objs

2012-12-04 Thread Eduardo Habkost
The flag is necessary for code that doesn't use the variables from Makefile (but use Makefile.objs), like libcacard/ and stubs/. Signed-off-by: Eduardo Habkost --- Makefile | 1 - Makefile.objs | 15 +-- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/Makefile b/

Re: [Qemu-devel] [PATCH 0/8] qemu-common.h header cleanups

2012-12-04 Thread Andreas Färber
Hi Paolo, Am 04.12.2012 09:50, schrieb Paolo Bonzini: > Il 30/11/2012 21:53, Andreas Färber ha scritto: >> Thanks, applied the remaining patches to qom-cpu: >> https://github.com/afaerber/qemu-cpu/commits/qom-cpu >> >> I had already re-verified that qemu-types.h didn't loose anything but >> didn't

[Qemu-devel] [RFC 6/8] qdev-properties.c: separate core from the code used only by qemu-system-*

2012-12-04 Thread Eduardo Habkost
This separates the qdev properties code in two parts: - qdev-properties.c, that contains most of the qdev properties code; - qdev-properties-system.c for code specific for qemu-system-*, containing: - Property types: drive, chr, netdev, vlan, that depend on code that won't be included

[Qemu-devel] [RFC 0/8] CPU DeviceState v9

2012-12-04 Thread Eduardo Habkost
Changes on v9: - Instead of moving qemu_[un]register_reset() to reset.c and including it on *-user, create stubs for them on libqemustub.a - This is based on afaerber's qom-cpu branch, that has some header cleanup changes. You can get the complete series in a git tree at: https://github.

[Qemu-devel] [PATCH 17/18] q35: update lpc pci config space according to configured devices

2012-12-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/ich9.h |1 + hw/lpc_ich9.c | 29 + hw/smbus_ich9.c | 12 3 files changed, 30 insertions(+), 12 deletions(-) diff --git a/hw/ich9.h b/hw/ich9.h index de49135..34e216f 100644 --- a/hw/ich9.h +++ b/hw/ich9.

[Qemu-devel] [RFC 3/8] libqemustub: add qemu_[un]register_reset() stubs

2012-12-04 Thread Eduardo Habkost
This will be useful for code that don't call qemu_devices_reset() (e.g. *-user). If qemu_devices_reset() is never called, it means we don't need to keep track of the reset handler list. Signed-off-by: Eduardo Habkost --- stubs/Makefile.objs | 1 + stubs/reset.c | 13 + 2 files

[Qemu-devel] [PATCH 12/18] acpi: switch smbus to memory api

2012-12-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/acpi_piix4.c |5 ++--- hw/pm_smbus.c | 17 + hw/pm_smbus.h |3 +-- hw/smbus_ich9.c | 52 +++- hw/vt82c686.c |6 ++ 5 files changed, 33 insertions(+), 50 deletions(-) diff

[Qemu-devel] [PATCH 11/18] acpi: cleanup ich9 memory region

2012-12-04 Thread Gerd Hoffmann
Nothing left to do, everything handled by subregions, we can zap the reaw/write handlers now. Signed-off-by: Gerd Hoffmann --- hw/acpi_ich9.c | 125 +--- 1 files changed, 1 insertions(+), 124 deletions(-) diff --git a/hw/acpi_ich9.c b/hw/acpi

Re: [Qemu-devel] [PATCH v4 11/11] virtio-blk: add x-data-plane=on|off performance feature

2012-12-04 Thread Stefan Hajnoczi
On Tue, Dec 04, 2012 at 01:20:20PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 29, 2012 at 04:55:48PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 29, 2012 at 03:45:55PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Nov 29, 2012 at 03:12:35PM +0200, Michael S. Tsirkin wrote: > > > > On Thu, No

Re: [Qemu-devel] KVM call agenda for 2012-12-04

2012-12-04 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda topics you are interested in. > - migration troubles from 1.2 -> 1.3 due to qemu-kvm integration As there is no topics & 1.3 is out, this would be discussed on the list. Happy hacking, Juan. > > Later, Juan.

[Qemu-devel] [RFC PATCH v5 3/6] virtio-pci-bus : Introduce virtio-pci-bus.

2012-12-04 Thread fred . konrad
From: KONRAD Frederic Introduce virtio-pci-bus, which extends virtio-bus. It is used with virtio-pci transport device. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 37 + hw/virtio-pci.h | 19 +-- 2 files changed, 54 insertions(+), 2 d

Re: [Qemu-devel] [PULL for-1.3 0/3] seabios: q35 update

2012-12-04 Thread Jason Baron
On Tue, Dec 04, 2012 at 08:40:27AM +0100, Gerd Hoffmann wrote: > Hi, > > > 1) legacy ide mode > > > > I can currently create a ide controller on the command-line using > > '-device'. However, on the real h/w there is an IDE compatibility mode > > which essentially advertises an ide controller a

Re: [Qemu-devel] [PULL for-1.3 0/3] seabios: q35 update

2012-12-04 Thread Gabriel L. Somlo
On Tue, 04 Dec 2012 08:40:27 +0100 Gerd Hoffmann wrote: >On Mon, 3 Dec 2012 13:47:04 -0500, Jason Baron wrote: >> 2) HPET ACPI error >> >> This line: 'IRQNoFlags () {2, 8}' in the HPET acpi table is causing the >> folloing ACPI message (removing it makes it go away): > > Hmm. That was added to ma

Re: [Qemu-devel] detecting seccomp sandbox capability via QMP

2012-12-04 Thread Ján Tomko
On 12/04/12 12:46, Luiz Capitulino wrote: > On Mon, 03 Dec 2012 16:55:35 +0100 > Ján Tomko wrote: > >> Hello, >> >> is there a way to check if QEMU was compiled with --enable-seccomp via QMP? > > Not that I'm aware of. Could you describe your use-case? It's for libvirt. The detection is broken

[Qemu-devel] [RFC PATCH v5 1/6] qdev : add a maximum device allowed field for the bus.

2012-12-04 Thread fred . konrad
From: KONRAD Frederic Add a max_dev field to BusState to specify the maximum amount of devices allowed on the bus ( have no effect if max_dev=0 ) Signed-off-by: KONRAD Frederic --- hw/qdev-core.h| 2 ++ hw/qdev-monitor.c | 11 +++ 2 files changed, 13 insertions(+) diff --git a/hw

[Qemu-devel] [PATCH] target-mips: Fix incorrect shift for SHILO and SHILOV

2012-12-04 Thread Petar Jovanovic
From: Petar Jovanovic helper_shilo has not been shifting an accumulator value correctly for negative values in 'shift' field. Minor optimization for shift=0 case. This change also adds tests that will trigger issue and check for regressions. Signed-off-by: Petar Jovanovic --- target-mips/dsp_h

Re: [Qemu-devel] [RFC PATCH v5 4/6] virtio-pci : Refactor virtio-pci device.

2012-12-04 Thread Peter Maydell
On 4 December 2012 14:35, wrote: > From: KONRAD Frederic > > Create the virtio-pci device. This transport device will create a > virtio-pci-bus, so one VirtIODevice can be connected. > > Signed-off-by: KONRAD Frederic > --- > hw/virtio-pci.c | 112 > +++

Re: [Qemu-devel] [RFC PATCH v5 5/6] virtio-device : Refactor virtio-device.

2012-12-04 Thread Peter Maydell
On 4 December 2012 14:35, wrote: > From: KONRAD Frederic > > Create the virtio-device which is abstract. All the virtio-device can extend > this class. > > Signed-off-by: KONRAD Frederic > --- > hw/virtio.c | 56 > hw/virtio.h | 29 +

[Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.

2012-12-04 Thread fred . konrad
From: KONRAD Frederic Create virtio-blk which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 170 hw/virtio-blk.h | 4 ++ 2 files changed, 150 insertions(+), 24 deletio

[Qemu-devel] [RFC PATCH v5 4/6] virtio-pci : Refactor virtio-pci device.

2012-12-04 Thread fred . konrad
From: KONRAD Frederic Create the virtio-pci device. This transport device will create a virtio-pci-bus, so one VirtIODevice can be connected. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 112 hw/virtio-pci.h | 14 +++ 2 file

[Qemu-devel] [RFC 3/3] docs: document virtio-balloon stats

2012-12-04 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- docs/virtio-balloon-stats.txt | 73 +++ 1 file changed, 73 insertions(+) create mode 100644 docs/virtio-balloon-stats.txt diff --git a/docs/virtio-balloon-stats.txt b/docs/virtio-balloon-stats.txt new file mode 100644 in

[Qemu-devel] [RFC 1/3] virtio-balloon: drop old stats code

2012-12-04 Thread Luiz Capitulino
Next commit will re-enable balloon stats with a different interface, but this old code conflicts with it, drop it then. Signed-off-by: Luiz Capitulino --- hw/virtio-balloon.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c inde

[Qemu-devel] [RFC 0/3] re-enable balloon stats

2012-12-04 Thread Luiz Capitulino
This new try to re-enable the virtio-balloon driver stats uses QOM properties via a polling mechanism as suggested by Anthony here: http://lists.gnu.org/archive/html/qemu-devel/2012-02/msg02390.html The second patch contains the implementation, the last patch contains documentation and examples.

Re: [Qemu-devel] [PULL for-1.3 0/3] seabios: q35 update

2012-12-04 Thread jbaron
On Tue, Dec 04, 2012 at 09:42:44AM -0500, Gabriel L. Somlo wrote: > On Tue, 04 Dec 2012 08:40:27 +0100 Gerd Hoffmann wrote: > >On Mon, 3 Dec 2012 13:47:04 -0500, Jason Baron wrote: > >> 2) HPET ACPI error > >> > >> This line: 'IRQNoFlags () {2, 8}' in the HPET acpi table is causing the > >> folloi

[Qemu-devel] [PATCH 0/2] tests: avoid aio_flush() in test cases

2012-12-04 Thread Stefan Hajnoczi
There is a patch to drop aio_flush(). Most callers shouldn't use that interface. It turns out that the aio and thread pool test cases *do* need low-level flush functionality so they can test the aio code. Convert test-aio.c and test-thread-pool.c to use replacements for qemu_aio_flush() and aio_

[Qemu-devel] [PATCH 1/2] tests: use aio_poll() instead of aio_flush() in test-aio.c

2012-12-04 Thread Stefan Hajnoczi
There has been confusion between various aio wait and flush functions. It's time to get rid of qemu_aio_flush() but in the aio test cases we really do want this low-level functionality. Therefore declare a local wait_for_aio() helper for the test cases. Drop the aio_flush() test case. Signed-off-

[Qemu-devel] [PATCH 2/2] tests: avoid qemu_aio_flush() in test-thread-pool.c

2012-12-04 Thread Stefan Hajnoczi
We need to eliminate calls to qemu_aio_flush() since the function is being removed. Most callers will use bdrv_drain_all() instead but test-thread-pool.c is lower level. Since the test uses the global AioContext we can loop on qemu_aio_wait() to wait for aio and bh activity to complete. Signed-o

[Qemu-devel] [RFC 2/3] virtio-balloon: re-enable balloon stats

2012-12-04 Thread Luiz Capitulino
The statistics are now available through device properties via a polling mechanism. First, a client has to enable polling, then it can query the stats. The following control properties are introduced: o stats-polling-interval: a value greater than zero enables polling in the specified interva

Re: [Qemu-devel] detecting seccomp sandbox capability via QMP

2012-12-04 Thread Luiz Capitulino
On Tue, 04 Dec 2012 15:42:32 +0100 Ján Tomko wrote: > On 12/04/12 12:46, Luiz Capitulino wrote: > > On Mon, 03 Dec 2012 16:55:35 +0100 > > Ján Tomko wrote: > > > >> Hello, > >> > >> is there a way to check if QEMU was compiled with --enable-seccomp via QMP? > > > > Not that I'm aware of. Could

[Qemu-devel] [RFC PATCH v5 0/6] Virtio refactoring.

2012-12-04 Thread fred . konrad
From: KONRAD Frederic I think the global structure is good as we discuted in the V4. So, I tried to start device refactoring, and also made some little fix. For the device refactoring, what are you suggesting for replacing VirtIOBindings ? Also, the virtio_pci_init_cb(..) currently use direct a

Re: [Qemu-devel] [PATCH v5] Add compare subcommand for qemu-img

2012-12-04 Thread Stefan Hajnoczi
On Tue, Dec 04, 2012 at 06:06:55AM -0500, Miroslav Rezanina wrote: > +for (;;) { > +c = getopt(argc, argv, "pf:F:sq"); > +if (c == -1) { > +break; > +} > +switch (c) { > +case 'f': > +fmt1 = optarg; > +break; > +

[Qemu-devel] [RFC PATCH v5 2/6] virtio-bus : Introduce virtio-bus

2012-12-04 Thread fred . konrad
From: KONRAD Frederic Introduce virtio-bus. Refactored transport device will create a bus which extends virtio-bus. Signed-off-by: KONRAD Frederic --- hw/Makefile.objs | 1 + hw/virtio-bus.c | 111 +++ hw/virtio-bus.h | 76 ++

Re: [Qemu-devel] detecting seccomp sandbox capability via QMP

2012-12-04 Thread Daniel P. Berrange
On Tue, Dec 04, 2012 at 03:42:32PM +0100, Ján Tomko wrote: > On 12/04/12 12:46, Luiz Capitulino wrote: > > On Mon, 03 Dec 2012 16:55:35 +0100 > > Ján Tomko wrote: > > > >> Hello, > >> > >> is there a way to check if QEMU was compiled with --enable-seccomp via QMP? > > > > Not that I'm aware of.

[Qemu-devel] [RFC PATCH v5 5/6] virtio-device : Refactor virtio-device.

2012-12-04 Thread fred . konrad
From: KONRAD Frederic Create the virtio-device which is abstract. All the virtio-device can extend this class. Signed-off-by: KONRAD Frederic --- hw/virtio.c | 56 hw/virtio.h | 29 + 2 files changed, 85 inser

Re: [Qemu-devel] [PATCH] tests: Add tests for fdsets

2012-12-04 Thread Stefan Hajnoczi
On Wed, Nov 14, 2012 at 05:53:16PM -0500, Corey Bryant wrote: > > Signed-off-by: Corey Bryant > --- > tests/qemu-iotests/044| 129 > ++ > tests/qemu-iotests/044.out| 5 ++ > tests/qemu-iotests/group | 1 + > tests/qemu-iotests/iotests

[Qemu-devel] [PATCH] qemu-io: Implement write -c for compressed clusters

2012-12-04 Thread Kevin Wolf
This makes it easier to create images with both compressed and uncompressed clusters for testing. Signed-off-by: Kevin Wolf --- qemu-io.c | 23 +-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index 5730aeb..1637773 100644 --- a/qemu

Re: [Qemu-devel] [PULL for-1.3 0/3] seabios: q35 update

2012-12-04 Thread Gerd Hoffmann
Hi, >>> '-machine q35,diskmode=ahci,ide,raid'? >> >> I'm wondering whenever we want to deal with that at all? >> >> "If your guest is too old to handle ahci natively, just stick to piix." >> is a sensible policy IMHO. >> > > There was some discussion of trying to make q35 the default for 1.4,

Re: [Qemu-devel] [PULL for-1.3 0/3] seabios: q35 update

2012-12-04 Thread Gabriel L. Somlo
On Tue, Dec 04, 2012 at 10:11:38AM -0500, jba...@redhat.com wrote: > > I don't have an XP install image anymore, but does replacing 2,8 with > > 0,8 help ? > > > > no. > > > On a few of my machines, this is actually coded as > > > > IRQNoFlags () > >

Re: [Qemu-devel] [PATCH] qemu-io: Implement write -c for compressed clusters

2012-12-04 Thread Stefan Hajnoczi
On Tue, Dec 04, 2012 at 04:35:12PM +0100, Kevin Wolf wrote: > This makes it easier to create images with both compressed and > uncompressed clusters for testing. > > Signed-off-by: Kevin Wolf > --- > qemu-io.c | 23 +-- > 1 files changed, 21 insertions(+), 2 deletions(-) T

Re: [Qemu-devel] [RFC PATCH v5 4/6] virtio-pci : Refactor virtio-pci device.

2012-12-04 Thread KONRAD Frédéric
On 04/12/2012 15:49, Peter Maydell wrote: On 4 December 2012 14:35, wrote: From: KONRAD Frederic Create the virtio-pci device. This transport device will create a virtio-pci-bus, so one VirtIODevice can be connected. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 112 ++

Re: [Qemu-devel] [RFC PATCH v5 5/6] virtio-device : Refactor virtio-device.

2012-12-04 Thread KONRAD Frédéric
On 04/12/2012 15:55, Peter Maydell wrote: On 4 December 2012 14:35, wrote: From: KONRAD Frederic Create the virtio-device which is abstract. All the virtio-device can extend this class. Signed-off-by: KONRAD Frederic --- hw/virtio.c | 56 ++

Re: [Qemu-devel] [PULL 00/18] acpi: switch to memory api

2012-12-04 Thread Andreas Färber
Hi Gerd, Am 04.12.2012 14:04, schrieb Gerd Hoffmann: > Hi, > > Same patches as posted last week. No review comments, 1.4 tree > open, so it should be ready to go in now. That's not quite true - you ignored my review comment wrt MemoryRegion placement (and I left it to you to look for further

Re: [Qemu-devel] [PULL for-1.3 0/3] seabios: q35 update

2012-12-04 Thread Gerd Hoffmann
On 12/04/12 16:37, Gerd Hoffmann wrote: >> > I also noticed that on Windows 7, the 'IRQNoFlags' line above makes the RTC >> > clock complain that it does not have resources available. While removing >> > the >> > above line, removes that error. > Hmm. The IRQNoFlags for the RTC isn't new though,

[Qemu-devel] [PATCH] configure: allow disabling pixman if not needed

2012-12-04 Thread Robert Schiele
When we build neither any system emulation targets nor the tools there is actually no need for pixman library. In that case do not enforce presence of that library on the system. Signed-off-by: Robert Schiele --- This allows to reduce dependencies in case you build only user emulation targets.

Re: [Qemu-devel] [RFC 0/8] CPU DeviceState v9

2012-12-04 Thread Andreas Färber
Am 04.12.2012 14:19, schrieb Eduardo Habkost: > Changes on v9: > - Instead of moving qemu_[un]register_reset() to reset.c and including >it on *-user, create stubs for them on libqemustub.a We compile cpu.c twice. Can't we do the same for qdev.c or whatever uses those functions? I feel they h

Re: [Qemu-devel] [RFC 1/8] move -I$(SRC_PATH)/include compiler flag to Makefile.objs

2012-12-04 Thread Andreas Färber
Am 04.12.2012 14:19, schrieb Eduardo Habkost: > The flag is necessary for code that doesn't use the variables from > Makefile (but use Makefile.objs), like libcacard/ and stubs/. > > Signed-off-by: Eduardo Habkost I don't quite understand the rationale of this patch. libcacard/ and stubs/ should

Re: [Qemu-devel] [PULL 00/18] acpi: switch to memory api

2012-12-04 Thread Gerd Hoffmann
On 12/04/12 16:57, Andreas Färber wrote: > Hi Gerd, > > Am 04.12.2012 14:04, schrieb Gerd Hoffmann: >> Hi, >> >> Same patches as posted last week. No review comments, 1.4 tree >> open, so it should be ready to go in now. > > That's not quite true - you ignored my review comment wrt MemoryRegio

Re: [Qemu-devel] [RFC 2/8] qdev: qdev_create(): use error_report() instead of hw_error()

2012-12-04 Thread Andreas Färber
Am 04.12.2012 14:19, schrieb Eduardo Habkost: > hw_error() is specific for fatal hardware emulation errors, not for > internal errors related to the qdev object/class abstraction or object > initialization. > > Replace it with an error_report() call, followed by abort(). > > This will also help r

Re: [Qemu-devel] [PATCH 18/24] qdev: qdev_create(): use error_report() instead of hw_error()

2012-12-04 Thread Andreas Färber
Am 09.11.2012 15:56, schrieb Eduardo Habkost: > hw_error() is specific for fatal hardware emulation errors, not for > internal errors related to the qdev object/class abstraction or object > initialization. > > Replace it with an error_report() call, followed by abort(). > > This will also help r

[Qemu-devel] [PATCH 1/6] isa: Add isa_address_space_io()

2012-12-04 Thread Andreas Färber
From: Julien Grall This function permits to retrieve ISA IO address space. It will be usefull when we need to pass IO address space as argument. Signed-off-by: Julien Grall Acked-by: Avi Kivity Signed-off-by: Andreas Färber --- hw/isa-bus.c |9 + hw/isa.h |1 + 2 Dateien

[Qemu-devel] [PATCH 2/6] hw/apm.c: Replace register_ioport_*

2012-12-04 Thread Andreas Färber
From: Julien Grall Replace all register_ioport_*() with a MemoryRegion. This permits to use the new Memory stuff like listeners. Moreover, the PCI device is added as an argument for apm_init(), so we can register IO inside the PCI IO address space. Signed-off-by: Julien Grall Acked-by: Avi Kiv

[Qemu-devel] [PATCH 3/6] hw/cirrus_vga.c: Replace register_ioport_*

2012-12-04 Thread Andreas Färber
From: Julien Grall Replace all register_ioport_*() with the new Memory API. This permits to use the new Memory stuff like listeners. Signed-off-by: Julien Grall Acked-by: Avi Kivity [AF: Rebased onto hwaddr] Signed-off-by: Andreas Färber --- hw/cirrus_vga.c | 48 +++

[Qemu-devel] [PATCH 6/6] hw/dma.c: Replace register_ioport_*

2012-12-04 Thread Andreas Färber
From: Julien Grall Replace all register_ioport_*() with the new Memory API functions. This permits to use the new Memory stuff like listeners. Signed-off-by: Julien Grall Acked-by: Avi Kivity [AF: Rebased onto hwaddr] Signed-off-by: Andreas Färber --- hw/dma.c | 106

Re: [Qemu-devel] [PATCH v2] HACKING: List areas where we may rely on impdef C behaviour

2012-12-04 Thread Peter Maydell
Ping! now that 1.4 is open. patchwork url http://patchwork.ozlabs.org/patch/195783/ -- PMM On 31 October 2012 09:30, Peter Maydell wrote: > Add a section to HACKING saying which version of the C spec > we use and describing the bits of implementation defined C > compiler behaviour which C code

Re: [Qemu-devel] [PATCH v6 2/2] qemu-ga: sample fsfreeze hooks

2012-12-04 Thread Luiz Capitulino
On Fri, 30 Nov 2012 22:33:57 +0900 Tomoki Sekiyama wrote: > Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. > - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ > - fsfreeze-hook.d.sample/mysql-flush.sh : quiesce MySQL before snapshot > > Signed-off-by: Tomoki Sekiyama >

Re: [Qemu-devel] [PATCH v6 0/2] qemu-ga: add hook to quiesce the guest on fsfreeze-freeze/thaw

2012-12-04 Thread Luiz Capitulino
On Fri, 30 Nov 2012 22:33:49 +0900 Tomoki Sekiyama wrote: > Hi, > > This is version 6 of the qemu-ga fsfreeze hook patchset. Made two small comments, otherwise series looks good to me now.

Re: [Qemu-devel] [PULL for-1.3 0/3] seabios: q35 update

2012-12-04 Thread Gerd Hoffmann
Hi, > The complete definition for the HPET on my MacPro5,1 is below; along > with the 0xFED0 value gleaned from the previous SeaBIOS version of > _CRS, I came up with the above. Hopefully it works for WinXP too... > Device (HPET) { > Name (_HID, EisaId ("PNP0103")) > Name (BUF0, Res

Re: [Qemu-devel] [PATCH 0/2] tests: avoid aio_flush() in test cases

2012-12-04 Thread Paolo Bonzini
Il 04/12/2012 16:12, Stefan Hajnoczi ha scritto: > There is a patch to drop aio_flush(). Most callers shouldn't use that > interface. It turns out that the aio and thread pool test cases *do* need > low-level flush functionality so they can test the aio code. > > Convert test-aio.c and test-thre

Re: [Qemu-devel] [PATCH] configure: allow disabling pixman if not needed

2012-12-04 Thread Peter Maydell
On 4 December 2012 15:58, Robert Schiele wrote: > diff --git a/target-unicore32/helper.c b/target-unicore32/helper.c > index a9e226b..3e0df33 100644 > --- a/target-unicore32/helper.c > +++ b/target-unicore32/helper.c > @@ -13,7 +13,9 @@ > #include "gdbstub.h" > #include "helper.h" > #include "h

[Qemu-devel] [PATCH 5/6] hw/pc.c: Replace register_ioport_*

2012-12-04 Thread Andreas Färber
From: Julien Grall Replace all register_ioport_*() with portio_*() or a MemoryRegion. This permits to use the new Memory stuff like listeners. Signed-off-by: Julien Grall Acked-by: Avi Kivity [AF: Rebased onto hwaddr] Signed-off-by: Andreas Färber --- hw/pc.c | 49 +

Re: [Qemu-devel] [PATCH] xilinx_zynq: Add one variable to avoid overwriting QSPI bus

2012-12-04 Thread Peter Maydell
On 28 November 2012 09:14, Liming Wang wrote: > commit 7b482bcf xilinx_zynq: added QSPI controller > > Adds one QSPI controller, which has two spi buses, one is for > spi0, and another is for spi1. But when initializing the spi1 > bus, "dev" has been overwrited by the ssi_create_slave_no_init() fu

Re: [Qemu-devel] [PULL for-1.3 0/3] seabios: q35 update

2012-12-04 Thread Gabriel L. Somlo
On Tue, Dec 04, 2012 at 05:56:55PM +0100, Gerd Hoffmann wrote: > Ok, and how does the RTC look like on your MacPro? Device (RTC) { Name (_HID, EisaId ("PNP0B00")) Name (_CRS, ResourceTemplate () { IO (Decode16, 0x0070, // Range Minimum 0x0070

[Qemu-devel] [PATCH 4/6] serial: Replace register_ioport_*

2012-12-04 Thread Andreas Färber
From: Julien Grall Replace all register_ioport_*() with a MemoryRegion. This permits to use the new Memory stuff like listeners. For more flexibility, the IO address space is passed as an argument. Signed-off-by: Julien Grall Acked-by: Avi Kivity [AF: Rebased onto serial split] Signed-off-by:

[Qemu-devel] [PULL] Memory API ioport cleanups

2012-12-04 Thread Andreas Färber
Hello, As coordinated with Avi and Gerd, here's some ioport conversions to Memory API. Cc: Avi Kivity Cc: Gerd Hoffmann Cc: Julien Grall Cc: Jason Baron The following changes since commit 16c6c80ac3a772b42a87b77dfdf0fdac7c607b0e: Open up 1.4 development branch (2012-12-03 14:08:40 -0600)

Re: [Qemu-devel] [PATCH v6 1/2] qemu-ga: execute hook to quiesce the guest on fsfreeze-freeze/thaw

2012-12-04 Thread Luiz Capitulino
On Fri, 30 Nov 2012 22:33:54 +0900 Tomoki Sekiyama wrote: > To use the online disk snapshot for online-backup, application-level > consistency of the snapshot image is required. However, currently the > guest agent can provide only filesystem-level consistency, and the > snapshot may contain dirt

Re: [Qemu-devel] [PATCH 1/4] hw/ds1338.c: Fix handling of HOURS register.

2012-12-04 Thread Peter Maydell
On 2 December 2012 17:14, Antoine Mathys wrote: > Per the datasheet, the mapping between 12 and 24 hours modes is: > 0 <-> 12 PM > 1-12 <-> 1-12 AM > 13-23 <-> 1-11 PM > > Signed-off-by: Antoine Mathys This looks good as far as the logic goes, but I think we could use so

Re: [Qemu-devel] [PATCH 2/4] hw/ds1338.c: Minor fixes

2012-12-04 Thread Peter Maydell
On 2 December 2012 17:17, Antoine Mathys wrote: > Minor fixes in the handling of the RTC registers. > > Signed-off-by: Antoine Mathys > --- > hw/ds1338.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/hw/ds1338.c b/hw/ds1338.c > index 1274b22..1fb152e

Re: [Qemu-devel] [PATCH 3/4] hw/ds1338.c: ensure OSF can only be cleared

2012-12-04 Thread Peter Maydell
On 2 December 2012 17:19, Antoine Mathys wrote: > Per the datasheet, the OSF bit in the control register can only be cleared. > Attempts to set it have no effect. Implement this. (As per comments on previous patch, I would suggest making this an "implement the control register" patch.) > Signed-

Re: [Qemu-devel] [PATCH 4/4] hw/ds1338.c: Handle stuck bits and preserve CH

2012-12-04 Thread Peter Maydell
On 2 December 2012 17:22, Antoine Mathys wrote: > Preserve the CH bit when updating the time. > > Per the datasheet, some bits in the first eight registers must always read > back as zero. These registers can be written in two ways: > 1. By ourselves when we update the registers with the current t

Re: [Qemu-devel] [PATCH 5/?] hw/ds1338.c: Fix handling of DATE (wday) register

2012-12-04 Thread Peter Maydell
On 3 December 2012 20:10, Antoine Mathys wrote: > Per the datasheet, the DATE (wday) register is user defined. Implement this. > > Signed-off-by: Antoine Mathys > --- > hw/ds1338.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/hw/ds1338.c b/hw/ds1338.

Re: [Qemu-devel] [PATCH v1 1/4] pflash_cfi01: qemu_log_mask "unimplemented" msg

2012-12-04 Thread Peter Maydell
On 4 December 2012 06:04, Peter Crosthwaite wrote: > This printf is informing the user of unimplemented functionality. It should be > re-directed to qemu_log(LOG_UNIMP, ...) accordingly. > > Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell I'm going to assume this series will go thr

Re: [Qemu-devel] [PATCH v1 2/4] pflash_cfi0x: Send debug messages to stderr

2012-12-04 Thread Peter Maydell
On 4 December 2012 06:04, Peter Crosthwaite wrote: > These debug info messages should go to stderr rather than stdout. > > Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH v1 3/4] zynq_slcr: Compile time warning fixes.

2012-12-04 Thread Peter Maydell
On 4 December 2012 06:04, Peter Crosthwaite wrote: > Few warnings when compiled with debug printfs enabled. Fixed all. > > Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH v1 4/4] arm_gic: Add cpu nr to Raised IRQ message

2012-12-04 Thread Peter Maydell
On 4 December 2012 06:04, Peter Crosthwaite wrote: > Add the relevant CPU nr to this debug message to make IRQ debugging more > informative. > > Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH 1/5] target-i386: cpu: separate feature string parsing from CPU model lookup

2012-12-04 Thread Blue Swirl
On Mon, Dec 3, 2012 at 5:27 PM, Eduardo Habkost wrote: > Instead of using parsing the whole cpu_model string inside > cpu_x86_find_by_name(), first split it into the CPU model name and the > full feature string, then parse the feature string into pieces. > > When using CPU model classes, those two

Re: [Qemu-devel] [Bug 1075252] Re: qemu-img cannot read VMDK4 file

2012-12-04 Thread Stefan Hajnoczi
On Tue, Dec 4, 2012 at 2:56 AM, Robert Hubbard wrote: > I have uploaded a patch - I am failing miserably to get any output from git > patch!! ... :^( . the code is structured to addres the fact that > convert will not work today, needs lots of work to do this. This would be > next effort. Hi

[Qemu-devel] [PATCH] finally kill cpudef config section support

2012-12-04 Thread Eduardo Habkost
The external CPU models were removed on QEMU 1.2, and the support for the "cpudef" config sections was documented as deprecated, but the actual removal of the config section was pending. Now that QEMU 1.3 was released, we can finally kill the support for cpudef config sections, and support only th

Re: [Qemu-devel] [RFC] 1.4 release schedule

2012-12-04 Thread Blue Swirl
On Mon, Dec 3, 2012 at 9:30 PM, Anthony Liguori wrote: > > Hi, > > Based on popular demand, I'd like to continue with a 3-month release > cycle for the foreseeable future. One thing I'd like to "fix" though is > to avoid major holidays during the -rc cycles. > > The best cycle I can figure is: >

Re: [Qemu-devel] [RFC] 1.4 release schedule

2012-12-04 Thread Peter Maydell
On 3 December 2012 21:30, Anthony Liguori wrote: > I've put up a strawman schedule on the wiki: > > http://wiki.qemu.org/Planning/1.4 The definition of 'soft freeze' on this page ("Major features should have initial code committed") and the definition on the page http://wiki.qemu.org/Planning/Sof

Re: [Qemu-devel] [PATCH] finally kill cpudef config section support

2012-12-04 Thread Andreas Färber
Am 04.12.2012 19:32, schrieb Eduardo Habkost: > The external CPU models were removed on QEMU 1.2, and the support for > the "cpudef" config sections was documented as deprecated, but the > actual removal of the config section was pending. > > Now that QEMU 1.3 was released, we can finally kill the

Re: [Qemu-devel] [RFC] 1.4 release schedule

2012-12-04 Thread Peter Maydell
On 4 December 2012 18:38, Blue Swirl wrote: > The definition of the hard freeze bothers me. A few patches that went > in after 1.3-rc0 were not bug fixes but just new features, so the > difference between soft and hard freezes was not clear. My vote for this would be to adhere to our definition a

Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function

2012-12-04 Thread Blue Swirl
On Tue, Dec 4, 2012 at 8:11 AM, liguang wrote: > Signed-off-by: liguang > --- > target-i386/helper.c | 70 > + > target-i386/machine.c |2 +- > target-i386/misc_helper.c |4 +- > target-i386/seg_helper.c |6 ++-- > 4 files chan

Re: [Qemu-devel] [PATCH] finally kill cpudef config section support

2012-12-04 Thread Eduardo Habkost
On Tue, Dec 04, 2012 at 07:41:47PM +0100, Andreas Färber wrote: > Am 04.12.2012 19:32, schrieb Eduardo Habkost: > > The external CPU models were removed on QEMU 1.2, and the support for > > the "cpudef" config sections was documented as deprecated, but the > > actual removal of the config section w

Re: [Qemu-devel] [PATCH 1/4] hw/ds1338.c: Fix handling of HOURS register.

2012-12-04 Thread Andreas Färber
Am 04.12.2012 18:42, schrieb Peter Maydell: > On 2 December 2012 17:14, Antoine Mathys wrote: >> Per the datasheet, the mapping between 12 and 24 hours modes is: >> 0 <-> 12 PM >> 1-12 <-> 1-12 AM >> 13-23 <-> 1-11 PM >> >> Signed-off-by: Antoine Mathys > > This looks go

Re: [Qemu-devel] [RFC 6/8] qdev-properties.c: separate core from the code used only by qemu-system-*

2012-12-04 Thread Blue Swirl
On Tue, Dec 4, 2012 at 1:19 PM, Eduardo Habkost wrote: > This separates the qdev properties code in two parts: > - qdev-properties.c, that contains most of the qdev properties code; > - qdev-properties-system.c for code specific for qemu-system-*, >containing: >- Property types: drive, c

Re: [Qemu-devel] [PATCH] virtfs-proxy-helper: check return code of setfsgid/setfsuid

2012-12-04 Thread Aneesh Kumar K.V
Paolo Bonzini writes: > Il 11/10/2012 09:25, M. Mohan Kumar ha scritto: >> Also as per the man page: >>When glibc determines that the argument is not a valid user ID, >>it will return -1 and set errno to EINVAL >>without attempting the system call. >> >> If it mean a no

[Qemu-devel] [PATCH 4/6] target-i386: postpone cpuid_level update to realize time

2012-12-04 Thread Eduardo Habkost
From: Igor Mammedov delay capping cpuid_level to 7 to realize time so property setters for cpuid_7_0_ebx_features and "level" could be used in any order/time between x86_cpu_initfn() and x86_cpu_realize(). Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 8 +--- 1 file changed, 5 inser

  1   2   3   >