Re: [Qemu-devel] [PATCHv5] rbd block driver fix race between aio completition and aio cancel

2012-11-30 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 10:37 PM, Stefan Priebe wrote: > @@ -568,6 +562,10 @@ static void qemu_rbd_aio_cancel(BlockDriverAIOCB > *blockacb) > { > RBDAIOCB *acb = (RBDAIOCB *) blockacb; > acb->cancelled = 1; > + > +while (acb->status == -EINPROGRESS) { > +qemu_aio_wait(); >

Re: [Qemu-devel] lsi scsi driver is broken

2012-11-30 Thread Gerd Hoffmann
On 11/30/12 08:31, Dietmar Maurer wrote: > The lsi driver simply hangs at startup. Try the following to reproduce: > > # ./x86_64-softmmu/qemu-system-x86_64 -monitor stdio -device lsi > > The monitor is blocked, and VM shows black screen. > > But it works perfectly when I use 'megasas' instead o

Re: [Qemu-devel] Minutes from 2012 QEMU Summit

2012-11-30 Thread Stefan Hajnoczi
On Mon, Nov 26, 2012 at 6:57 PM, Anthony Liguori wrote: > - Pull requests breaking the builds > - Buildbot only submit the first broken build, then go silent > - virtfs-proxy-helper broken on Fedora -> silence & breakage The current status of all builds is available here: http://buildb

[Qemu-devel] [PATCHv6] rbd block driver fix race between aio completition and aio cancel

2012-11-30 Thread Stefan Priebe
This one fixes a race which qemu had also in iscsi block driver between cancellation and io completition. qemu_rbd_aio_cancel was not synchronously waiting for the end of the command. To archieve this it introduces a new status flag which uses -EINPROGRESS. Changes since PATCHv5: - qemu_aio_rele

Re: [Qemu-devel] [PATCHv5] rbd block driver fix race between aio completition and aio cancel

2012-11-30 Thread Stefan Priebe - Profihost AG
fixed in V6 Am 30.11.2012 09:26, schrieb Stefan Hajnoczi: On Thu, Nov 29, 2012 at 10:37 PM, Stefan Priebe wrote: @@ -568,6 +562,10 @@ static void qemu_rbd_aio_cancel(BlockDriverAIOCB *blockacb) { RBDAIOCB *acb = (RBDAIOCB *) blockacb; acb->cancelled = 1; + +while (acb->status

[Qemu-devel] [PATCH v2 1/6] RFC: Efficient VM backup for qemu

2012-11-30 Thread Dietmar Maurer
This series provides a way to efficiently backup VMs. * Backup to a single archive file * Backup contain all data to restore VM (full backup) * Do not depend on storage type or image format * Avoid use of temporary storage * store sparse images efficiently The file docs/backup-rfc.txt contains mo

[Qemu-devel] [PATCH v2 6/6] add vm state to backups

2012-11-30 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- blockdev.c | 196 +- hmp.c|2 +- qapi-schema.json |6 +- 3 files changed, 199 insertions(+), 5 deletions(-) diff --git a/blockdev.c b/blockdev.c index 07db561..2e2050a 100644 --- a/b

[Qemu-devel] [PATCH v2 5/6] add regression tests for backup

2012-11-30 Thread Dietmar Maurer
Also added the ratelimit.h fix here, because it is still not upstream. Signed-off-by: Dietmar Maurer --- include/qemu/ratelimit.h |2 +- tests/Makefile | 11 +- tests/backup-test.c | 511 ++ 3 files changed, 521 insertions(+), 3 d

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2012-11-30 Thread Beastyvoid
Same here as what Uwe is experiencing : my SmartCard reader Omnikey 3121 shows up in the guest but no card can be found. With qemu-kvm 1.2.0. Was working great with previous versions. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. h

[Qemu-devel] [PATCH v2 3/6] add backup related monitor commands

2012-11-30 Thread Dietmar Maurer
We use a generic BackupDriver struct to encaplulated all archive format related function. Another option would be to simply dump to the output fh (pipe), and an external binary saves the data. That way we could move the whole archive format related code out of qemu. Signed-off-by: Dietmar Maurer

Re: [Qemu-devel] lsi scsi driver is broken

2012-11-30 Thread Dietmar Maurer
> > But it works perfectly when I use 'megasas' instead of 'lsi'. > > > > And ideas? > > Try latest seabios. Seems the http://www.seabios.org/ server is offline.

Re: [Qemu-devel] lsi scsi driver is broken

2012-11-30 Thread Gerd Hoffmann
On 11/30/12 10:41, Dietmar Maurer wrote: >>> But it works perfectly when I use 'megasas' instead of 'lsi'. >>> >>> And ideas? >> >> Try latest seabios. > > Seems the http://www.seabios.org/ server is offline. There is a tree @ git://git.kraxel.org/seabios git.qemu.org has one too, not sure how r

[Qemu-devel] [PATCH v2 2/6] add basic backup support to block driver

2012-11-30 Thread Dietmar Maurer
Function backup_job_start() creates a block job to backup a block device. We call backup_do_cow() for each write during backup. That function reads the original data and pass it to backup_dump_cb(). The tracked_request infrastructure is used to serialize access. Currently backup cluster size is

Re: [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper

2012-11-30 Thread Michael Tokarev
Somehow I missed this email initially.. replying now. On 12.10.2012 22:04, Mike Lovell wrote: > On 10/12/2012 02:32 AM, Michael Tokarev wrote: >> On 12.10.2012 10:49, Mike Lovell wrote: >>> /* request a tap device, disable PI, and add vnet header support if >>> - * requested and it's ava

Re: [Qemu-devel] lsi scsi driver is broken

2012-11-30 Thread Dietmar Maurer
> > The lsi driver simply hangs at startup. Try the following to reproduce: > > > > # ./x86_64-softmmu/qemu-system-x86_64 -monitor stdio -device lsi > > > > The monitor is blocked, and VM shows black screen. > > > > But it works perfectly when I use 'megasas' instead of 'lsi'. > > > > And ideas? >

Re: [Qemu-devel] [PATCH v2 0/6] block: bdrv_img_create(): propagate errors

2012-11-30 Thread Kevin Wolf
Am 29.11.2012 17:34, schrieb Luiz Capitulino: > On Fri, 2 Nov 2012 11:42:32 -0200 > Luiz Capitulino wrote: > >> On Fri, 02 Nov 2012 14:40:03 +0100 >> Kevin Wolf wrote: >> >>> Am 02.11.2012 14:25, schrieb Luiz Capitulino: On Fri, 19 Oct 2012 11:27:59 -0300 Luiz Capitulino wrote: >

Re: [Qemu-devel] [PATCH v5 0/3] qemu-ga: add hook to quiesce the guest on fsfreeze-freeze/thaw

2012-11-30 Thread Luiz Capitulino
On Fri, 30 Nov 2012 15:25:57 +0900 Tomoki Sekiyama wrote: > Hi, > > This is version 5 of the qemu-ga fsfreeze hook patchset. This series split is not good. You should squash patches 3/3 and 1/3 and rebase this series on top of: http://lists.gnu.org/archive/html/qemu-devel/2012-11/msg03016.htm

Re: [Qemu-devel] [PATCH v2 0/6] block: bdrv_img_create(): propagate errors

2012-11-30 Thread Luiz Capitulino
On Fri, 30 Nov 2012 12:39:34 +0100 Kevin Wolf wrote: > Am 29.11.2012 17:34, schrieb Luiz Capitulino: > > On Fri, 2 Nov 2012 11:42:32 -0200 > > Luiz Capitulino wrote: > > > >> On Fri, 02 Nov 2012 14:40:03 +0100 > >> Kevin Wolf wrote: > >> > >>> Am 02.11.2012 14:25, schrieb Luiz Capitulino: > >>

[Qemu-devel] [Bug 990364] Re: virtio_ioport_write: unexpected address 0x13 value 0x1

2012-11-30 Thread Vitalis
Hello! ANd again "virtio_ioport_write: unexpected address 0x13 value 0x1". Drvers: from virtio-win-0.1-30.iso config: buh_xp f0e8ac00-4545-eb5d-e8f2-c885063e5ad0 1097152 1097152 1 hvm destroy restart restart /usr/bin/kvm

Re: [Qemu-devel] [PATCH v5 0/3] qemu-ga: add hook to quiesce the guest on fsfreeze-freeze/thaw

2012-11-30 Thread Tomoki Sekiyama
On 2012/11/30 20:42, Luiz Capitulino wrote: > On Fri, 30 Nov 2012 15:25:57 +0900 > Tomoki Sekiyama wrote: > >> Hi, >> >> This is version 5 of the qemu-ga fsfreeze hook patchset. > > This series split is not good. You should squash patches 3/3 and 1/3 and > rebase this series on top of: > > htt

Re: [Qemu-devel] [PATCH v5 0/3] qemu-ga: add hook to quiesce the guest on fsfreeze-freeze/thaw

2012-11-30 Thread Luiz Capitulino
On Fri, 30 Nov 2012 21:40:04 +0900 Tomoki Sekiyama wrote: > On 2012/11/30 20:42, Luiz Capitulino wrote: > > On Fri, 30 Nov 2012 15:25:57 +0900 > > Tomoki Sekiyama wrote: > > > >> Hi, > >> > >> This is version 5 of the qemu-ga fsfreeze hook patchset. > > > > This series split is not good. You s

[Qemu-devel] [PATCH 4/6] qmp: qmp_transaction(): pass Error object to bdrv_img_create()

2012-11-30 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- blockdev.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/blockdev.c index 2ec02ac..cc9692d 100644 --- a/blockdev.c +++ b/blockdev.c @@ -707,6 +707,7 @@ void qmp_transaction(BlockdevActionList *dev_list, Error **e

[Qemu-devel] [PATCH 3/6] qemu-img: img_create(): drop unneeded goto and ret variable

2012-11-30 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qemu-img.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 595b6f5..c4dae88 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -294,7 +294,7 @@ static int add_old_style_options(const char *fmt, QEMUOpti

[Qemu-devel] [PATCH 6/6] block: bdrv_img_create(): drop unused error handling code

2012-11-30 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- block.c | 40 +--- block.h | 6 +++--- 2 files changed, 8 insertions(+), 38 deletions(-) diff --git a/block.c b/block.c index 9ee0036..3ca6126 100644 --- a/block.c +++ b/block.c @@ -4408,9 +4408,9 @@ bdrv_acct_done(BlockDriv

[Qemu-devel] [PATCH 5/6] qmp: qmp_drive_mirror(): pass Error object to bdrv_img_create()

2012-11-30 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- blockdev.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/blockdev.c b/blockdev.c index cc9692d..6b293fe 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1264,8 +1264,8 @@ void qmp_drive_mirror(const char *device, const char *t

[Qemu-devel] [PATCH 1/5] Documentation: Update block cache mode information

2012-11-30 Thread Kevin Wolf
Somehow we forgot to update this when cache=writeback became the default. While changing the information on the default, also make the description of all caches modes a bit more accurate. Signed-off-by: Kevin Wolf Acked-by: Stefan Hajnoczi --- qemu-options.hx | 38 +++-

[Qemu-devel] [PATCH 5/5] coroutine-sigaltstack.c: Use stack_t, not struct sigaltstack

2012-11-30 Thread Kevin Wolf
From: Peter Maydell Use the POSIX-specified stack_t type as the argument to sigaltstack() rather than the legacy struct sigaltstack. This allows us to compile on MacOSX with --with-coroutine=sigaltstack. Signed-off-by: Peter Maydell Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf ---

[Qemu-devel] [PATCH 3/5] atapi: make change media detection for guests easier

2012-11-30 Thread Kevin Wolf
From: Pavel Hrdina If you have a guest with a media in the optical drive and you change it, the windows guest cannot properly recognize this media change. Windows needs to detect sense "NOT_READY with ASC_MEDIUM_NOT_PRESENT" before we send sense "UNIT_ATTENTION with ASC_MEDIUM_MAY_HAVE_CHANGED".

[Qemu-devel] [PULL 0/5] Block patches for 1.3.0-rc2

2012-11-30 Thread Kevin Wolf
The following changes since commit e9bff10f8db94912b1b0e6e2e3394cae02faf614: event notifier: Fix setup for win32 (2012-11-28 13:33:01 -0600) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Dietmar Maurer (1): stream: fix ratelimit_set_speed Kevin W

[Qemu-devel] [PATCH 4/5] stream: fix ratelimit_set_speed

2012-11-30 Thread Kevin Wolf
From: Dietmar Maurer The formula to compute slice_quota was wrong since commit 6ef228fc. Signed-off-by: Dietmar Maurer Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- include/qemu/ratelimit.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/qemu/ratelim

[Qemu-devel] [PATCH v3 0/6] block: bdrv_img_create(): propagate errors

2012-11-30 Thread Luiz Capitulino
By adding error propagation to bdrv_img_create() we improve error reporting in QMP and simplify qemu-img.c:img_create() a bit. o v3 - Update qmp_drive_mirror() o Patches changed: - 1/6 (changed) - 5/6 (new patch) Luiz Capitulino (6): block: bdrv_img_create(): add Error ** argument qemu-

[Qemu-devel] [PATCH 2/6] qemu-img: img_create(): pass Error object to bdrv_img_create()

2012-11-30 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qemu-img.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 3896689..595b6f5 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -301,6 +301,7 @@ static int img_create(int argc, char **argv) const char *f

Re: [Qemu-devel] [PATCH v3 0/6] block: bdrv_img_create(): propagate errors

2012-11-30 Thread Kevin Wolf
Am 30.11.2012 13:52, schrieb Luiz Capitulino: > By adding error propagation to bdrv_img_create() we improve error reporting > in QMP and simplify qemu-img.c:img_create() a bit. > > o v3 > > - Update qmp_drive_mirror() > > o Patches changed: > > - 1/6 (changed) > - 5/6 (new patch) > > Luiz C

[Qemu-devel] [PATCH 0/6] RFC: add "spiceport" chardev

2012-11-30 Thread Marc-André Lureau
Hi, Add a new chardev to allow arbitrary communication between the host and the Spice client (via the spice server). Note: the related Spice protocol and server patches are in review, this patch series serves as a RFC for the reviewers. Except the first 3 patches, the spice dependencies will need

[Qemu-devel] [PATCH 1/6] qemu-char: add qemu_chr_remove_clients()

2012-11-30 Thread Marc-André Lureau
Make it possible for chardev user to disconnect all the clients. The spiceport will remove associated chardev clients when the spice client is disconnected. (since qemu-char could have several clients implementation later, as chr_add_client() name suggests, I chose to have generic name and behavi

[Qemu-devel] [PATCH 2/6] spice-qemu-char: write to chardev whatever amount it can read

2012-11-30 Thread Marc-André Lureau
The current code waits until the chardev can read MIN(len, VMC_MAX) But some chardev may never reach than amount, in fact some of them will only ever accept write of 1. Fix the min computation and remove the VMC_MAX constant. Signed-off-by: Marc-André Lureau --- spice-qemu-char.c | 6 ++ 1 f

[Qemu-devel] [PATCH 3/6] spice-qemu-char: factor out CharDriverState creation

2012-11-30 Thread Marc-André Lureau
Make the CharDriverState creation code reusable by spicevmc port. Signed-off-by: Marc-André Lureau --- spice-qemu-char.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index 665efd3..b86e83a 100644

[Qemu-devel] [PATCH 4/6] spice-qemu-char: add spiceport chardev

2012-11-30 Thread Marc-André Lureau
Add a new spice chardev to allow arbitrary communication between the host and the Spice client (via the spice server). Examples: This allows the Spice client to have a special port for the qemu monitor: ... -chardev spiceport,name=org.qemu.monitor,id=monitorport -mon chardev=monitorport Or

[Qemu-devel] [PATCH 2/5] Documentation: Update image format information

2012-11-30 Thread Kevin Wolf
Document new and yet undocumented options and image formats. The qemu-img man page contains information only for raw and qcow2 now and references the HTML documentation for a more detailed description of other formats. Signed-off-by: Kevin Wolf Acked-by: Stefan Hajnoczi --- qemu-doc.texi | 167

[Qemu-devel] [PATCH 5/6] spice-qemu-char: keep a list of spice chardev

2012-11-30 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- spice-qemu-char.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index 629b500..13de037 100644 --- a/spice-qemu-char.c +++ b/spice-qemu-char.c @@ -25,8 +25,12 @@ typedef struct SpiceCharDriver { ssize_t

[Qemu-devel] [PATCH 6/6] spice-qemu-char: register spicevmc ports during qemu_spice_init()

2012-11-30 Thread Marc-André Lureau
Do the delayed registration of spicevmc ports after Spice server is initialized. Signed-off-by: Marc-André Lureau --- spice-qemu-char.c | 13 + ui/qemu-spice.h | 1 + ui/spice-core.c | 2 ++ 3 files changed, 16 insertions(+) diff --git a/spice-qemu-char.c b/spice-qemu-char.c i

[Qemu-devel] [PATCH v6 0/2] qemu-ga: add hook to quiesce the guest on fsfreeze-freeze/thaw

2012-11-30 Thread Tomoki Sekiyama
Hi, This is version 6 of the qemu-ga fsfreeze hook patchset. *Changes from v5: patch 1/3 and 3/3 are squashed. *Changes from v4: ( http://patchwork.ozlabs.org/patch/200924/ ) 1/2: Improve error messages based on Luiz Capitulino's patchset. Make fsfreeze-hook disabled by default, and enab

Re: [Qemu-devel] [PATCH v6 1/2] qemu-ga: execute hook to quiesce the guest on fsfreeze-freeze/thaw

2012-11-30 Thread Tomoki Sekiyama
To use the online disk snapshot for online-backup, application-level consistency of the snapshot image is required. However, currently the guest agent can provide only filesystem-level consistency, and the snapshot may contain dirty data, for example, incomplete transactions. This patch provides th

Re: [Qemu-devel] [PATCH v6 2/2] qemu-ga: sample fsfreeze hooks

2012-11-30 Thread Tomoki Sekiyama
Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ - fsfreeze-hook.d.sample/mysql-flush.sh : quiesce MySQL before snapshot Signed-off-by: Tomoki Sekiyama --- docs/qemu-guest-agent/fsfreeze-hook| 33 +

[Qemu-devel] [PATCH 1/6] block: bdrv_img_create(): add Error ** argument

2012-11-30 Thread Luiz Capitulino
This commit adds an Error ** argument to bdrv_img_create() and set it appropriately on error. Callers of bdrv_img_create() pass NULL for the new argument and still rely on bdrv_img_create()'s return value. Next commits will change callers to use the Error object instead. Signed-off-by: Luiz Capit

Re: [Qemu-devel] [PATCHv6] rbd block driver fix race between aio completition and aio cancel

2012-11-30 Thread Stefan Hajnoczi
On Fri, Nov 30, 2012 at 9:55 AM, Stefan Priebe wrote: > This one fixes a race which qemu had also in iscsi block driver > between cancellation and io completition. > > qemu_rbd_aio_cancel was not synchronously waiting for the end of > the command. > > To archieve this it introduces a new status fl

Re: [Qemu-devel] [PATCH v4 10/11] dataplane: add virtio-blk data plane code

2012-11-30 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 4:47 PM, Paolo Bonzini wrote: > Stefan, perhaps you could replace the stop_notifier mechanism of > event-poll.c with something similar to aio_notify/qemu_notify_event, > and even remove event_poll_run in favor of event_poll (aka aio_wait...). > And also remove the return va

Re: [Qemu-devel] [PATCH 0/6] RFC: add "spiceport" chardev

2012-11-30 Thread Gerd Hoffmann
Hi, > This allows the Spice client to have a special port for the qemu > monitor: > > ... -chardev spiceport,name=org.qemu.monitor,id=monitorport > -mon chardev=monitorport Nice. I think we should have a registry of names, at least for the org.qemu.* namespace. A simple text file in docs

Re: [Qemu-devel] [PATCH V7 0/6] VMXNET3 paravirtual NIC device implementation

2012-11-30 Thread Paolo Bonzini
> Yes, we tested this device with various guests (both Linux and > Windows) and it also passed WHQL tests for Windows Server 2008 R2 > OS. The issue is Anthony asked us to write a basic test for the device (a > packet transmission test) and we are trying to get some reference > code or documentatio

Re: [Qemu-devel] [PATCH v4] Add compare subcommand for qemu-img

2012-11-30 Thread Stefan Hajnoczi
On Tue, Nov 27, 2012 at 9:03 AM, Miroslav Rezanina wrote: > diff --git a/qemu-img.c b/qemu-img.c > index e29e01b..9cc4365 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -101,7 +101,13 @@ static void help(void) > " '-a' applies a snapshot (revert disk to saved state)\n" >

Re: [Qemu-devel] lsi scsi driver is broken

2012-11-30 Thread Anthony Liguori
Gerd Hoffmann writes: > On 11/30/12 08:31, Dietmar Maurer wrote: >> The lsi driver simply hangs at startup. Try the following to reproduce: >> >> # ./x86_64-softmmu/qemu-system-x86_64 -monitor stdio -device lsi >> >> The monitor is blocked, and VM shows black screen. >> >> But it works perfect

Re: [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper

2012-11-30 Thread Paolo Bonzini
Il 30/11/2012 11:02, Michael Tokarev ha scritto: >> I do like the idea of using a common prefix for the default name >> of tap devices. Something like "qvif%d" instead of "tap%d" in tap >> initialization code. But something tells me this could break >> compatibility with external management softwar

Re: [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper

2012-11-30 Thread Paolo Bonzini
Il 30/11/2012 08:10, Mike Lovell ha scritto: > On 10/12/2012 12:49 AM, Mike Lovell wrote: >> This makes a few changes to allow ifname to be specified when using >> qemu-bridge-helper with both the bridge and tap network interfaces. It >> adds >> the --ifname option to qemu-bridge-helper, removes th

Re: [Qemu-devel] [PATCH V5] target-i386: Enabling IA32_TSC_ADJUST for QEMU KVM guest VMs

2012-11-30 Thread Andreas Färber
Am 27.11.2012 06:32, schrieb Will Auld: > CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is supported > > Basic design is to emulate the MSR by allowing reads and writes to the > hypervisor vcpu specific locations to store the value of the emulated MSRs. > In this way the IA32_TSC_ADJUST va

Re: [Qemu-devel] [PATCH 0/6] RFC: add "spiceport" chardev

2012-11-30 Thread Marc-André Lureau
Hi On Fri, Nov 30, 2012 at 2:58 PM, Gerd Hoffmann wrote: > Also nice to have: > >org.qemu.console.serial.0 > > ... and spice client redirecting that to a vte. You might have to add > some termios control messages to spiceport, so one can turn on/off echo, > send breaks, xon/xoff flow contro

Re: [Qemu-devel] lsi scsi driver is broken

2012-11-30 Thread Mark Cave-Ayland
On 30/11/12 14:26, Anthony Liguori wrote: Try latest seabios. [ yes, /me plans to update seabios for 1.3, just waiting for the q35 patches to find their way into seabios ]. If we're going to update, it's got to be today. Regards, Anthony Liguori Can we also update the openbios.git repo

Re: [Qemu-devel] [PATCH] Modified OpenRisc fpu exception

2012-11-30 Thread Wei-Ren Chen
> -void QEMU_NORETURN raise_exception(OpenRISCCPU *cpu, uint32_t excp) > +void QEMU_NORETURN do_raise_exception_err(OpenRISCCPU *cpu, > + uint32_t exception, > + uintptr_t pc) > { > -cpu->env.exception_index = ex

Re: [Qemu-devel] [PATCH] Modified OpenRisc fpu exception

2012-11-30 Thread Peter Maydell
On 30 November 2012 07:17, Feng Gao wrote: > Add OpenRisc fpu excepiton. > When an exception raised, CPU can save right PC. This commit message is very short and quite hard to understand. It would be nice to see more detail here on what the patch is trying to do. thanks -- PMM

[Qemu-devel] [PULL for-1.3 0/3] seabios update

2012-11-30 Thread Gerd Hoffmann
Hi, This pull updates seabios to current master. The seabios q35 patches didn't land upstream yet so they miss the boat unfortunaly. As this update brings an important regression fix we can't wait for them and risk to not update seabios for 1.3. So here we go with the latest and greatest sea

[Qemu-devel] [PATCH 2/3] roms: also copy the dsdt when updating seabios.

2012-11-30 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- roms/Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/roms/Makefile b/roms/Makefile index feb9c2b..5e645bc 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -12,6 +12,7 @@ bios: config.seabios sh configure-seabios.sh $<

[Qemu-devel] [PATCH 1/3] seabios: update to b1c35f2b28cc0c94ebed8176ff61ac0e0b377798

2012-11-30 Thread Gerd Hoffmann
This patch updates the seabios submodule to commit b1c35f2b28cc0c94ebed8176ff61ac0e0b377798. Most important change is that seabios sets the busmaster bit in the pci config space for the lsi and esp scsi host adapters. Since commit 1c380f9460522f32c8dd2577b2a53d518ec91c6d qemu is strict here and di

Re: [Qemu-devel] [PATCH V7 2/6] Adding utility function iov_net_csum_add() for iovec checksum calculation Adding utility function iov_rebuild() for smart iovec copy

2012-11-30 Thread Stefan Hajnoczi
On Fri, Nov 16, 2012 at 2:55 PM, Dmitry Fleytman wrote: > @@ -252,6 +253,58 @@ unsigned iov_copy(struct iovec *dst_iov, unsigned int > dst_iov_cnt, > return j; > } > > +size_t iov_rebuild(struct iovec *dst, unsigned int dst_cnt, > + const struct iovec *src, const unsigned

Re: [Qemu-devel] slow HD performance in mingw

2012-11-30 Thread Roy Tam
2012/11/30 Roy Tam : > Hello all, > > I noticed that QEMU(both 1.2.1 and git head) acts very slow when > accessing HD. I wonder if it is a fault in my build environment? > and in same environment, I can see the speed decreases when version bumps: http://roy.dnsd.me/qemu-0.15.1.png http://roy.dnsd.

Re: [Qemu-devel] [PATCH 1/3] seabios: update to b1c35f2b28cc0c94ebed8176ff61ac0e0b377798

2012-11-30 Thread Peter Maydell
On 30 November 2012 15:29, Gerd Hoffmann wrote: > This patch updates the seabios submodule to commit > b1c35f2b28cc0c94ebed8176ff61ac0e0b377798. Shouldn't this be in the same git commit as the new binaries, so they're always in sync? -- PMM

Re: [Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-30 Thread Anthony Liguori
I've spent the past week thinking about what to do here. Honestly, I'm tired of this nonsense. Every few months there's another headache to deal with. So I'm going to make it simple. You do *not* commit patches to the git tree without sending them to the list first to review. You do *not* rel

Re: [Qemu-devel] [PATCH 1/3] seabios: update to b1c35f2b28cc0c94ebed8176ff61ac0e0b377798

2012-11-30 Thread Gerd Hoffmann
On 11/30/12 16:41, Peter Maydell wrote: > On 30 November 2012 15:29, Gerd Hoffmann wrote: >> This patch updates the seabios submodule to commit >> b1c35f2b28cc0c94ebed8176ff61ac0e0b377798. > > Shouldn't this be in the same git commit as the new > binaries, so they're always in sync? It's in the

Re: [Qemu-devel] [PATCH 0/6] RFC: add "spiceport" chardev

2012-11-30 Thread Gerd Hoffmann
Hi, >> What is the use case? Any reason why the spice client can not (or >> should not) speak to ovirt directly? > > Ah, in fact, it's the main reason why I worked on this. Currently, the > Spice client has to communicate with ovirt via the browser, which is a pain > to deal with: it's a compl

Re: [Qemu-devel] [PATCH V7 4/6] Adding common code for VMWARE network devices

2012-11-30 Thread Stefan Hajnoczi
On Fri, Nov 16, 2012 at 2:55 PM, Dmitry Fleytman wrote: > Signed-off-by: Dmitry Fleytman > Signed-off-by: Yan Vugenfirer > --- > hw/vmware_utils.h | 24 ++-- > hw/vmxnet_debug.h | 121 +++ > hw/vmxnet_utils.c | 219 +++ > hw/vmxnet_utils.h | 340

Re: [Qemu-devel] lsi scsi driver is broken

2012-11-30 Thread Gerd Hoffmann
Hi, >> [ yes, /me plans to update seabios for 1.3, just waiting for the q35 >> patches to find their way into seabios ]. > > If we're going to update, it's got to be today. Ok, update send without q35. cheers, Gerd

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-11-30 Thread Peter Maydell
That test case seems to have very weak reproducibility -- I think I saw a hang perhaps once in 30+ runs. That's not really usable for debugging, I'm afraid :-( -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net

Re: [Qemu-devel] [PATCHv2] virtio: limit avail bytes lookahead

2012-11-30 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced > a regression in virtio-net performance because it looks > into the ring aggressively while we really only care > about a single packet worth of buffers. > Reported as bugzilla 1066055 in launchpad. > > To

Re: [Qemu-devel] [PATCH 1.3?] multiboot: fix e801 memory map

2012-11-30 Thread Anthony Liguori
Paolo Bonzini writes: > The e801 memory sizes in the multiboot structures hard-code the available > low memory to 640. However, the value should not include the size of the > EBDA. Fill the value in the option ROM, getting the size of low memory > from the BIOS. > > Cc: Alexander Graf > Signed

Re: [Qemu-devel] [PATCHv5 1.3] seccomp: adding new syscalls (bugzilla 855162)

2012-11-30 Thread Anthony Liguori
Eduardo Otubo writes: > According to the bug 855162[0] - there's the need of adding new syscalls > to the whitelist when using Qemu with Libvirt. > > [0] - https://bugzilla.redhat.com/show_bug.cgi?id=855162 > > Reported-by: Paul Moore > Signed-off-by: Eduardo Otubo > Signed-off-by: Corey Bryant

Re: [Qemu-devel] [PATCH for-1.3] qemu-tech.texi: update implemented xtensa features list

2012-11-30 Thread Anthony Liguori
Max Filippov writes: > Debug option is available since QEMU-1.2; FP coprocessor and > coprocessor context is available since QEMU-1.3. > > Signed-off-by: Max Filippov Applied. Thanks. Regards, Anthony Liguori > --- > qemu-tech.texi | 10 +- > 1 files changed, 5 insertions(+), 5 de

Re: [Qemu-devel] [PATCH V7 0/6] VMXNET3 paravirtual NIC device implementation

2012-11-30 Thread Anthony Liguori
Paolo Bonzini writes: >> Yes, we tested this device with various guests (both Linux and >> Windows) and it also passed WHQL tests for Windows Server 2008 R2 >> OS. The issue is Anthony asked us to write a basic test for the device (a >> packet transmission test) and we are trying to get some refe

Re: [Qemu-devel] [PATCH V7 5/6] Adding packet abstraction for VMWARE network devices

2012-11-30 Thread Stefan Hajnoczi
On Fri, Nov 16, 2012 at 2:55 PM, Dmitry Fleytman wrote: > +/*= > + > *= > + * > + *TX CODE > + * > + > *

Re: [Qemu-devel] [PATCH V10 0/8] memory: unify ioport registration

2012-11-30 Thread Julien Grall
On 11/27/2012 01:14 AM, Andreas Färber wrote: > Am 26.11.2012 15:25, schrieb Gerd Hoffmann: >> On 11/25/12 16:01, Andreas Färber wrote: >>> Am 25.11.2012 10:10, schrieb Avi Kivity: On 09/19/2012 02:50 PM, Julien Grall wrote: > This is the tenth version of patch series about ioport registr

Re: [Qemu-devel] [PATCH] Modified OpenRisc fpu exception

2012-11-30 Thread Andreas Färber
Am 30.11.2012 16:03, schrieb Peter Maydell: > On 30 November 2012 07:17, Feng Gao wrote: >> Add OpenRisc fpu excepiton. >> When an exception raised, CPU can save right PC. > > This commit message is very short and quite hard > to understand. It would be nice to see more detail > here on what the

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-11-30 Thread Janne Karhunen
If that is the case for you (for me it reproduces it every 4-5 runs or so), there are two options: 1) put while(true) loop around the rpmbuild and you will hit it always, or 2) I can wrap up a bit bigger cmake usecase that systematically hits it. Warn you though, size will jump to 200M. -- You

Re: [Qemu-devel] [PATCH V7 6/6] Adding VMXNET3 device implementation

2012-11-30 Thread Stefan Hajnoczi
On Fri, Nov 16, 2012 at 2:55 PM, Dmitry Fleytman wrote: > +/* Whether MSI-X support was installed successfully */ > +uint8_t msix_used; > +/* Whether MSI support was installed successfully */ > +uint8_t msi_used; These two fields should be bool. > +/* Whet

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-11-30 Thread Peter Maydell
I'll take the bigger usecase, please. It's pretty hard to debug race conditions that don't manifest often enough to let you do useful logging. >From the time or two I caught it hanging, it looks like qemu is sleeping in >poll, and there's a zombie child process. I wonder if what's happening is th

Re: [Qemu-devel] [PATCH 19/24] qdev: move reset handler list from vl.c to qdev.c

2012-11-30 Thread Igor Mammedov
On Thu, 15 Nov 2012 16:42:41 -0200 Eduardo Habkost wrote: > On Thu, Nov 15, 2012 at 02:54:57AM +0100, Andreas Färber wrote: > > Am 09.11.2012 15:56, schrieb Eduardo Habkost: > > > The core qdev code uses the reset handler list from vl.c, so move > > > qemu_register_reset(), qemu_unregister_reset(

[Qemu-devel] [RFC PATCH V4 1/6] qdev : add a maximum device allowed field for the bus.

2012-11-30 Thread fred . konrad
From: KONRAD Frederic Only one device can be connected to virtio-bus. This patch add a field max_dev which is : * the maximum amount of devices connected on the bus ( when * max_dev!=0 ). * have no effect ( when max_dev=0 ). The function qbus_find_recursive is modified : * to ret

[Qemu-devel] [RFC PATCH V4 0/6] Virtio refactoring.

2012-11-30 Thread fred . konrad
From: KONRAD Frederic I send this RFC, to know if you're all happy with the current structure of the device (QOM). This patch-set is : * Introducing a virtio-bus which extends bus-state. * Implementing a virtio-pci-bus which extends virtio-bus. * Implementing a virtio-pci device whic

[Qemu-devel] [RFC PATCH V4 4/6] virtio-pci : Introduce virtio-pci device.

2012-11-30 Thread fred . konrad
From: KONRAD Frederic Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 48 +++- hw/virtio-pci.h | 15 +++ 2 files changed, 62 insertions(+), 1 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index a73704d..1fb1905 1006

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-11-30 Thread Peter Maydell
Actually I just managed to interact with a hung qemu under a debugger sufficiently to confirm what is happening here. CMake's code for running child processes (in kwsys/ProcessUNIX.c) does this: "On UNIX, a child process is forked to exec the program. Three output pipes are read by the parent pr

[Qemu-devel] [RFC PATCH V4 5/6] virtio-device : Introduce virtio-device.

2012-11-30 Thread fred . konrad
From: KONRAD Frederic Signed-off-by: KONRAD Frederic --- hw/virtio.c | 28 hw/virtio.h | 27 +++ 2 files changed, 55 insertions(+), 0 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index f40a8c5..1c72d17 100644 --- a/hw/virtio.c +++

[Qemu-devel] [RFC PATCH V4 2/6] virtio-bus : Introduce virtio-bus

2012-11-30 Thread fred . konrad
From: KONRAD Frederic Signed-off-by: KONRAD Frederic --- hw/Makefile.objs |1 + hw/virtio-bus.c | 114 ++ hw/virtio-bus.h | 78 + 3 files changed, 193 insertions(+), 0 deletions(-) create mode 1006

[Qemu-devel] [RFC PATCH V4 6/6] virtio-blk : Refactoring virtio-blk.

2012-11-30 Thread fred . konrad
From: KONRAD Frederic Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 61 +++ hw/virtio-blk.h | 16 ++ 2 files changed, 77 insertions(+), 0 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index e25cc96..354788

[Qemu-devel] [RFC PATCH V4 3/6] virtio-pci-bus : Introduce virtio-pci-bus.

2012-11-30 Thread fred . konrad
From: KONRAD Frederic Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 45 + hw/virtio-pci.h | 19 +-- 2 files changed, 62 insertions(+), 2 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index 71f4fb5..a73704d 100

Re: [Qemu-devel] [PATCH 00/10] qemu-ga: revamp error messages (for 1.4)

2012-11-30 Thread mdroth
On Tue, Nov 27, 2012 at 11:01:54AM -0200, Luiz Capitulino wrote: > This series revamps qemu-ga error messages by: > > - Propagating errors down to functions that generate errors > - Fixing UndefinedErrors > - Getting rid of sprint() + error_set() > - Other small fixes > > Only the POSIX port

Re: [Qemu-devel] [RFC PATCH V4 1/6] qdev : add a maximum device allowed field for the bus.

2012-11-30 Thread Peter Maydell
On 30 November 2012 17:12, wrote: > From: KONRAD Frederic > > Only one device can be connected to virtio-bus. > This patch add a field max_dev which is : > * the maximum amount of devices connected on the bus ( when > * max_dev!=0 ). > * have no effect ( when max_dev=0 ). > > The fun

Re: [Qemu-devel] [RFC PATCH V4 2/6] virtio-bus : Introduce virtio-bus

2012-11-30 Thread Peter Maydell
On 30 November 2012 17:12, wrote: > From: KONRAD Frederic > > Signed-off-by: KONRAD Frederic > --- > hw/Makefile.objs |1 + > hw/virtio-bus.c | 114 > ++ > hw/virtio-bus.h | 78 + > 3 files change

Re: [Qemu-devel] [RFC PATCH V4 5/6] virtio-device : Introduce virtio-device.

2012-11-30 Thread Peter Maydell
On 30 November 2012 17:12, wrote: > From: KONRAD Frederic > > Signed-off-by: KONRAD Frederic > --- > hw/virtio.c | 28 > hw/virtio.h | 27 +++ > 2 files changed, 55 insertions(+), 0 deletions(-) > > diff --git a/hw/virtio.c b/hw/virtio.c

Re: [Qemu-devel] [RFC PATCH V4 6/6] virtio-blk : Refactoring virtio-blk.

2012-11-30 Thread Peter Maydell
On 30 November 2012 17:12, wrote: > From: KONRAD Frederic This is a dreadful commit message. > > Signed-off-by: KONRAD Frederic > --- > hw/virtio-blk.c | 61 > +++ > hw/virtio-blk.h | 16 ++ > 2 files changed, 77 insertions

Re: [Qemu-devel] [PULL for-1.3 0/1] QMP queue

2012-11-30 Thread Anthony Liguori
Luiz Capitulino writes: > This is an important fix as it fixes a 32-bit breakage. > > The changes (since e9bff10f8db94912b1b0e6e2e3394cae02faf614) are available > in the following repository: > > git://repo.or.cz/qemu/qmp-unstable.git queue/qmp > > Bruce Rogers (1): > qapi: fix qapi_dealloc

Re: [Qemu-devel] [PULL for-1.3 0/3] usb patch queue

2012-11-30 Thread Anthony Liguori
Gerd Hoffmann writes: > Hi, > > This is the usb patch queue, carrying three little fixes for 1.3. > > please pull, > Gerd Pulled. Thanks. Regards, Anthony Liguori > > The following changes since commit e9bff10f8db94912b1b0e6e2e3394cae02faf614: > > event notifier: Fix setup for win32 (20

Re: [Qemu-devel] [PULL 0/5] Block patches for 1.3.0-rc2

2012-11-30 Thread Anthony Liguori
Kevin Wolf writes: > The following changes since commit e9bff10f8db94912b1b0e6e2e3394cae02faf614: > > event notifier: Fix setup for win32 (2012-11-28 13:33:01 -0600) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git for-anthony > Pulled. Thanks. Regards, Antho

Re: [Qemu-devel] [PULL for-1.3 0/1] spice patch queue.

2012-11-30 Thread Anthony Liguori
Gerd Hoffmann writes: > Hi, > > Pretty short this time, with a single lonely bugfix. > > please pull, > Gerd > Pulled. Thanks. Regards, Anthony Liguori > The following changes since commit e9bff10f8db94912b1b0e6e2e3394cae02faf614: > > event notifier: Fix setup for win32 (2012-11-28 13:3

Re: [Qemu-devel] [RFC PATCH V4 0/6] Virtio refactoring.

2012-11-30 Thread Peter Maydell
On 30 November 2012 17:12, wrote: > From: KONRAD Frederic > > I send this RFC, to know if you're all happy with the current structure of the > device (QOM). The general layout of classes looks OK to me, which is why I've moved on to some more nitpicky stuff. I'll have a closer look next week an

  1   2   >