On Fri, 30 Nov 2012 15:25:57 +0900 Tomoki Sekiyama <tomoki.sekiyama...@hitachi.com> wrote:
> Hi, > > This is version 5 of the qemu-ga fsfreeze hook patchset. This series split is not good. You should squash patches 3/3 and 1/3 and rebase this series on top of: http://lists.gnu.org/archive/html/qemu-devel/2012-11/msg03016.html Also, please look at qmp_shutdown() and bios_supports_mode() for examples of command execution with improved error reporting. > *Changes from v4: ( http://patchwork.ozlabs.org/patch/200924/ ) > 1/3: Improve error messages when fsfreeze hook is not executable. > Make fsfreeze-hook disabled by default, and enabled only if > --fsfreeze-hook option is specified. Let me clarify that there are two ways of doing this. One is the way above, the other way is to enable it by default but allow something like "--fsfreeze-hook no" to disable the hook execution. Both ways are fine with me.
