Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: use irqfd to interrupt among VMs

2012-11-29 Thread liu ping fan
On Thu, Nov 29, 2012 at 12:42 PM, Cam Macdonell wrote: > On Tue, Nov 27, 2012 at 7:53 PM, liu ping fan wrote: >> On Wed, Nov 28, 2012 at 5:48 AM, Cam Macdonell wrote: >>> On Sat, Nov 24, 2012 at 8:51 PM, Liu Ping Fan wrote: From: Liu Ping Fan Using irqfd, so we can avoid switch

Re: [Qemu-devel] [PATCH v7 1/7] qom: apply atomic on object's refcount

2012-11-29 Thread liu ping fan
On Thu, Nov 29, 2012 at 1:16 AM, Richard Henderson wrote: > On 11/24/2012 06:02 PM, Liu Ping Fan wrote: >> -obj->ref--; >> >> /* parent always holds a reference to its children */ >> -if (obj->ref == 0) { >> +if (__sync_fetch_and_sub(&obj->ref, 1) == 1) { > > if (__sync_sub_and_

Re: [Qemu-devel] [PATCH V12 6/7] libqblock API implement

2012-11-29 Thread Paolo Bonzini
Il 29/11/2012 07:25, Wenchao Xia ha scritto: >> >> How can this be called with libqb_global_data.init_flag == 1? >> > OK, I will remove the if, but keep init_flag which can show > library is already initialized. Please remove it if there is no usage elsewhere. For debugging, qemu_aio_context !=

Re: [Qemu-devel] [PATCH v4 00/11] virtio: virtio-blk data plane

2012-11-29 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 4:16 PM, Stefan Hajnoczi wrote: > This series adds the -device virtio-blk-pci,x-data-plane=on property that > enables a high performance I/O codepath. A dedicated thread is used to > process > virtio-blk requests outside the global mutex and without going through the > Q

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-11-29 Thread Janne Karhunen
Ok, test case attached (80M tar). This hugely stripped one is not 100% reproducer, but do few loops and you will hit it. Instructions for using: - extract, chroot - cd /home/abuild/rpmbuild - su abuild - export RPM_BUILD_ROOT=$PWD - rpmbuild -ba SOURCES/libshortcut.spec ** Attachment added: "Tiz

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-11-29 Thread Janne Karhunen
Mind you, when you hit the bug it just hangs and cmake test errors are just to speed up the process of hitting the bug (if cmake just fails you did not hit the bug). Feel free to try with any qemu variant, they all hang similarly when bug is hit. I think that root had some suse 1.2 one inside. --

[Qemu-devel] [PATCHv3] rbd block driver fix race between aio completition and aio cancel

2012-11-29 Thread Stefan Priebe
This one fixes a race which qemu had also in iscsi block driver between cancellation and io completition. qemu_rbd_aio_cancel was not synchronously waiting for the end of the command. To archieve this it introduces a new status flag which uses -EINPROGRESS. Changes since last PATCH: - fixed miss

[Qemu-devel] [PATCH for-1.3] Build system clean generated source files in tests

2012-11-29 Thread Wenchao Xia
Currently .c files generated in ./tests are not deleted in make clean. This introduce trouble that, once we made tests in source root directory, we can't do a succesfully build for tests in another out of tree directory, for that some file may miss the step to be generated. This patch fix it. St

Re: [Qemu-devel] [PATCH 1/3] define name for some fields of dr7

2012-11-29 Thread Peter Maydell
On 29 November 2012 03:32, liguang wrote: Your Subject: line is missing the "target-i386:" prefix. (also, should be "names".) > Signed-off-by: liguang > --- > target-i386/cpu.h | 13 + > 1 files changed, 13 insertions(+), 0 deletions(-) > > diff --git a/target-i386/cpu.h b/target

Re: [Qemu-devel] [PATCH 2/3] use dr7's bit name for breakpoint

2012-11-29 Thread Peter Maydell
On 29 November 2012 03:32, liguang wrote: > Signed-off-by: liguang > --- > target-i386/cpu.h |2 ++ > target-i386/helper.c | 24 +++- > target-i386/misc_helper.c |6 +++--- > target-i386/seg_helper.c |6 +++--- > 4 files changed, 19 insertions(+),

Re: [Qemu-devel] [PATCH 3/3] target-i386:refactor check_hw_breakpoints function

2012-11-29 Thread Peter Maydell
On 29 November 2012 03:32, liguang wrote: > Signed-off-by: liguang > --- > target-i386/helper.c | 28 > 1 files changed, 20 insertions(+), 8 deletions(-) > > diff --git a/target-i386/helper.c b/target-i386/helper.c > index 9ca52a7..a506df0 100644 > --- a/target-i38

Re: [Qemu-devel] [PATCH 03/10] qemu-ga: qmp_guest_file_*: improve error reporting

2012-11-29 Thread Luiz Capitulino
On Wed, 28 Nov 2012 16:17:43 -0600 mdroth wrote: > On Wed, Nov 28, 2012 at 04:26:29PM -0500, Eric Blake wrote: > > > > > > > if (ferror(fh)) { > > > > > +error_setg_errno(err, errno, "failed to read file"); > > > > > slog("guest-file-read failed, handle: %ld", handle); > >

Re: [Qemu-devel] [PATCH v4 00/11] virtio: virtio-blk data plane

2012-11-29 Thread Paolo Bonzini
Il 29/11/2012 10:18, Stefan Hajnoczi ha scritto: > Michael, Paolo: Are you happy with v4? Sure. > Kevin: Do you want to take this series through the block tree? Paolo

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 22, 2012 at 04:16:44PM +0100, Stefan Hajnoczi wrote: > The data plane thread needs to map guest physical addresses to host > pointers. Normally this is done with cpu_physical_memory_map() but the > function assumes the global mutex is held. The data plane thread does > not touch the g

Re: [Qemu-devel] [RFC PATCH v2 1/3] virtio-bus : Introduce VirtioBus.

2012-11-29 Thread Konrad Frederic
On 26/11/2012 17:59, Anthony Liguori wrote: Peter Maydell writes: On 26 November 2012 14:33, Anthony Liguori wrote: VirtioBusInfo is not a great name. This is a proxy class that allows for a device to implement the virtio bus interface. This could be done as an interface but since nothing

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-29 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 02:33:11PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 22, 2012 at 04:16:44PM +0100, Stefan Hajnoczi wrote: > > The data plane thread needs to map guest physical addresses to host > > pointers. Normally this is done with cpu_physical_memory_map() but the > > function ass

Re: [Qemu-devel] [PATCH v4 04/11] dataplane: add virtqueue vring code

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 22, 2012 at 04:16:45PM +0100, Stefan Hajnoczi wrote: > The virtio-blk-data-plane cannot access memory using the usual QEMU > functions since it executes outside the global mutex and the memory APIs > are this time are not thread-safe. > > This patch introduces a virtqueue module based

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2012 at 01:45:19PM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 29, 2012 at 02:33:11PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 22, 2012 at 04:16:44PM +0100, Stefan Hajnoczi wrote: > > > The data plane thread needs to map guest physical addresses to host > > > pointers. Norm

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2012 at 02:54:26PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 29, 2012 at 01:45:19PM +0100, Stefan Hajnoczi wrote: > > On Thu, Nov 29, 2012 at 02:33:11PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 22, 2012 at 04:16:44PM +0100, Stefan Hajnoczi wrote: > > > > The data plan

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-29 Thread Amit Shah
On (Wed) 28 Nov 2012 [23:53:08], Michael S. Tsirkin wrote: > On Tue, Nov 27, 2012 at 06:25:04PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 01, 2012 at 06:07:21PM +0200, Michael S. Tsirkin wrote: > > > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced > > > a regression in virtio-net

Re: [Qemu-devel] [PATCH 3/3] spice-qemu-char: register interface on post load

2012-11-29 Thread Amit Shah
On (Wed) 28 Nov 2012 [12:59:40], Markus Armbruster wrote: > Alon Levy writes: > > >> Alon Levy writes: > >> > >> > The target has not seen the guest_connected event via > >> > spice_chr_guest_open or spice_chr_write, and so spice server > >> > wrongly > >> > assumes there is no agent active, wh

Re: [Qemu-devel] [RFC PATCH v2 1/3] virtio-bus : Introduce VirtioBus.

2012-11-29 Thread Peter Maydell
On 29 November 2012 12:37, Konrad Frederic wrote: > On 26/11/2012 17:59, Anthony Liguori wrote: >> virtio-pci-bus extends virtio-bus >> - is constructed with a pointer to a PCIDevice >> - implements the methods necessary to be a virtio bus > > I still have trouble with that ^^. > The problem

Re: [Qemu-devel] [PATCH v4 11/11] virtio-blk: add x-data-plane=on|off performance feature

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 22, 2012 at 04:16:52PM +0100, Stefan Hajnoczi wrote: > The virtio-blk-data-plane feature is easy to integrate into > hw/virtio-blk.c. The data plane can be started and stopped similar to > vhost-net. > > Users can take advantage of the virtio-blk-data-plane feature using the > new -de

[Qemu-devel] [PULL for-1.3 0/1] QMP queue

2012-11-29 Thread Luiz Capitulino
This is an important fix as it fixes a 32-bit breakage. The changes (since e9bff10f8db94912b1b0e6e2e3394cae02faf614) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Bruce Rogers (1): qapi: fix qapi_dealloc_type_size parameter type qapi/qapi-dea

[Qemu-devel] [PULL] qapi: fix qapi_dealloc_type_size parameter type

2012-11-29 Thread Luiz Capitulino
From: Bruce Rogers The second parameter to qapi_dealloc_type_size should be a uint64_t *, not a size_t *. This was causing our 32 bit x86 build to fail, since warnings are treated as errors. Signed-off-by: Bruce Rogers Reviewed-by: Michael Roth Reviewed-by: Stefan Weil Signed-off-by: Luiz Cap

[Qemu-devel] [PATCH 2/3] usb: fail usbdevice_create() when there is no USB bus

2012-11-29 Thread Gerd Hoffmann
From: Stefan Hajnoczi Report an error instead of segfaulting when attaching a USB device to a machine with no USB busses: $ qemu-system-arm -machine vexpress-a9 \ -sd Fedora-17-armhfp-vexpress-mmcblk0.img \ -kernel vmlinuz-3.4.2-3.fc17.armv7hl \ -initrd initramfs-3.4.2-3.fc17

[Qemu-devel] [PATCH 1/3] usb: tag usb host adapters as not hotpluggable.

2012-11-29 Thread Gerd Hoffmann
Hotplugging them simply doesn't work, so tag them accordingly to avoid users trying and then crashing qemu. For xhci there is nothing fundamental which prevents hotplug from working, we'll "only" need a exit() function which cleans up everything properly. That isn't for 1.3 though. For ehci+uhci

[Qemu-devel] [PATCH 1/1] qxl: reload memslots after migration, when qxl is in UNDEFINED mode

2012-11-29 Thread Gerd Hoffmann
From: Yonit Halperin The devram memslot stays active when qxl enters UNDEFINED mode (i.e, no primary surface). If migration has occurred while the device is in UNDEFINED stae, the memslots have to be reloaded at the destination. Fixes rhbz#874574 Signed-off-by: Yonit Halperin Signed-off-by: Ge

[Qemu-devel] [PULL for-1.3 0/1] spice patch queue.

2012-11-29 Thread Gerd Hoffmann
Hi, Pretty short this time, with a single lonely bugfix. please pull, Gerd The following changes since commit e9bff10f8db94912b1b0e6e2e3394cae02faf614: event notifier: Fix setup for win32 (2012-11-28 13:33:01 -0600) are available in the git repository at: git://anongit.freedesktop.org/

Re: [Qemu-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-11-29 Thread Stefano Stabellini
On Thu, 29 Nov 2012, Xu, Dongxiao wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: Tuesday, September 18, 2012 6:24 PM > > To: Xu, Dongxiao > > Cc: Stefano Stabellini; xen-de...@lists.xensource.com; Ian Jackson; > > qemu-devel@no

Re: [Qemu-devel] [PATCH] qapi: fix qapi_dealloc_type_size parameter type

2012-11-29 Thread Stefan Hajnoczi
On Tue, Nov 27, 2012 at 01:11:25PM -0700, Bruce Rogers wrote: > The second parameter to qapi_dealloc_type_size should be a uint64_t *, > not a size_t *. This was causing our 32 bit x86 build to fail, since > warnings are treated as errors. > > Signed-off-by: Bruce Rogers > --- > qapi/qapi-deallo

Re: [Qemu-devel] [PATCH v4 10/11] dataplane: add virtio-blk data plane code

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 22, 2012 at 04:16:51PM +0100, Stefan Hajnoczi wrote: > virtio-blk-data-plane is a subset implementation of virtio-blk. It only > handles read, write, and flush requests. It does this using a dedicated > thread that executes an epoll(2)-based event loop and processes I/O > using Linux

[Qemu-devel] [PATCH 3/3] ehci-sysbus: Attach DMA context.

2012-11-29 Thread Gerd Hoffmann
From: Peter Crosthwaite This was left as NULL on the initial merge due to debate on the mailing list on how to handle DMA contexts for sysbus devices. Patch 9e11908f12f92e31ea94dc2a4c962c836cba9f2a was later merged to fix OHCI. This is the, equivalent fix for sysbus EHCI. Signed-off-by: Peter C

Re: [Qemu-devel] [PATCH v4 04/11] dataplane: add virtqueue vring code

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 22, 2012 at 04:16:45PM +0100, Stefan Hajnoczi wrote: > The virtio-blk-data-plane cannot access memory using the usual QEMU > functions since it executes outside the global mutex and the memory APIs > are this time are not thread-safe. > > This patch introduces a virtqueue module based

[Qemu-devel] [PULL for-1.3 0/3] usb patch queue

2012-11-29 Thread Gerd Hoffmann
Hi, This is the usb patch queue, carrying three little fixes for 1.3. please pull, Gerd The following changes since commit e9bff10f8db94912b1b0e6e2e3394cae02faf614: event notifier: Fix setup for win32 (2012-11-28 13:33:01 -0600) are available in the git repository at: git://git.kraxel.

Re: [Qemu-devel] [RFC PATCH v2 1/3] virtio-bus : Introduce VirtioBus.

2012-11-29 Thread Konrad Frederic
On 29/11/2012 14:09, Peter Maydell wrote: On 29 November 2012 12:37, Konrad Frederic wrote: On 26/11/2012 17:59, Anthony Liguori wrote: virtio-pci-bus extends virtio-bus - is constructed with a pointer to a PCIDevice - implements the methods necessary to be a virtio bus I still have tro

[Qemu-devel] [PATCH] qdev: relax bus type check in qdev_device_add()

2012-11-29 Thread Anthony Liguori
We are currently checking for an exact type match. Use QOM dynamic_cast to check for a compatible type instead. Cc: Konrad Frederic Signed-off-by: Anthony Liguori --- hw/qdev-monitor.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 22, 2012 at 04:16:44PM +0100, Stefan Hajnoczi wrote: > The data plane thread needs to map guest physical addresses to host > pointers. Normally this is done with cpu_physical_memory_map() but the > function assumes the global mutex is held. The data plane thread does > not touch the g

Re: [Qemu-devel] [RFC PATCH v2 1/3] virtio-bus : Introduce VirtioBus.

2012-11-29 Thread Anthony Liguori
Konrad Frederic writes: > On 26/11/2012 17:59, Anthony Liguori wrote: >> Peter Maydell writes: >> >>> On 26 November 2012 14:33, Anthony Liguori wrote: VirtioBusInfo is not a great name. This is a proxy class that allows for a device to implement the virtio bus interface. T

Re: [Qemu-devel] [RFC PATCH v2 1/3] virtio-bus : Introduce VirtioBus.

2012-11-29 Thread Peter Maydell
On 29 November 2012 13:47, Konrad Frederic wrote: > On 29/11/2012 14:09, Peter Maydell wrote: >> I suspect that qbus_find_recursive should be doing an >> object_class_dynamic_cast() to check that the bus is of a suitable >> type, rather than the >> (strcmp(object_get_typename(OBJECT(bus)), bu

Re: [Qemu-devel] [RFC PATCH v2 1/3] virtio-bus : Introduce VirtioBus.

2012-11-29 Thread Andreas Färber
Am 29.11.2012 14:47, schrieb Konrad Frederic: > On 29/11/2012 14:09, Peter Maydell wrote: >> On 29 November 2012 12:37, Konrad Frederic >> wrote: >>> On 26/11/2012 17:59, Anthony Liguori wrote: virtio-pci-bus extends virtio-bus - is constructed with a pointer to a PCIDevice -

Re: [Qemu-devel] [PATCH] qdev: relax bus type check in qdev_device_add()

2012-11-29 Thread Peter Maydell
On 29 November 2012 13:49, Anthony Liguori wrote: > We are currently checking for an exact type match. Use QOM dynamic_cast to > check for a compatible type instead. I think this only catches the case where a bus was explicitly specified via bus=. For the default case you also need to change the

Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-11-29 Thread Ian Campbell
On Thu, 2012-11-29 at 13:21 +, Stefano Stabellini wrote: > > Also I think 4.2.1 need these patches to enable the basic Xen on Xen > > nested virtualization usage scenario. > > I agree. Nested virt was a tech preview in 4.2.0, is it really worth backporting ? Ian.

Re: [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel

2012-11-29 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 11:00:19AM +0100, Stefan Priebe wrote: > @@ -406,10 +401,11 @@ static void qemu_rbd_complete_aio(RADOSCB *rcb) > acb->ret = r; > } > } > +acb->status = 0; > + I suggest doing this in the BH. The qemu_aio_wait() loop in qemu_rbd_aio_cancel() n

Re: [Qemu-devel] [PATCH v4 10/11] dataplane: add virtio-blk data plane code

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 22, 2012 at 04:16:51PM +0100, Stefan Hajnoczi wrote: > virtio-blk-data-plane is a subset implementation of virtio-blk. It only > handles read, write, and flush requests. It does this using a dedicated > thread that executes an epoll(2)-based event loop and processes I/O > using Linux

Re: [Qemu-devel] [PATCH] qdev: relax bus type check in qdev_device_add()

2012-11-29 Thread Konrad Frederic
On 29/11/2012 14:56, Peter Maydell wrote: On 29 November 2012 13:49, Anthony Liguori wrote: We are currently checking for an exact type match. Use QOM dynamic_cast to check for a compatible type instead. I think this only catches the case where a bus was explicitly specified via bus=. For the

Re: [Qemu-devel] [PATCH v4 00/11] virtio: virtio-blk data plane

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2012 at 10:18:59AM +0100, Stefan Hajnoczi wrote: > Michael, Paolo: Are you happy with v4? Looks pretty clean by itself. I sent some comments but they can be addressed later. What worries me most is the code duplication with regular virtio. I see two ways to reduce the maintainanc

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2012 at 06:34:46PM +0530, Amit Shah wrote: > On (Wed) 28 Nov 2012 [23:53:08], Michael S. Tsirkin wrote: > > On Tue, Nov 27, 2012 at 06:25:04PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 01, 2012 at 06:07:21PM +0200, Michael S. Tsirkin wrote: > > > > Commit 0d8d7690850eb0cf2b

Re: [Qemu-devel] [PATCH 1.3] virtio-rng: do not use g_assert_cmpint

2012-11-29 Thread Stefan Hajnoczi
On Tue, Nov 27, 2012 at 09:16:24AM +0100, Paolo Bonzini wrote: > g_assert_cmpint is not available on glib 2.12, which is the minimum > version required to build QEMU (we only require 2.16 to run tests, > since that is the first version including GTester). Do not use it > in hardware models, use a

Re: [Qemu-devel] main-loop.c: About Select handling

2012-11-29 Thread Stefan Hajnoczi
On Wed, Nov 28, 2012 at 03:08:24AM +, Furukawa, Eiji wrote: > About a source of qemu-1.2.0/main-loop.c > The select handling of os_host_main_loop_wait function > I do not seem to do Exit by interrupts such as SIGUSR1 > Will not it be necessary to make modifications? > > Before > LineNumber:30

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-29 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 03:54:25PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 22, 2012 at 04:16:44PM +0100, Stefan Hajnoczi wrote: > > The data plane thread needs to map guest physical addresses to host > > pointers. Normally this is done with cpu_physical_memory_map() but the > > function ass

Re: [Qemu-devel] [RFC PATCH v2 1/3] virtio-bus : Introduce VirtioBus.

2012-11-29 Thread Konrad Frederic
On 29/11/2012 14:55, Andreas Färber wrote: Am 29.11.2012 14:47, schrieb Konrad Frederic: On 29/11/2012 14:09, Peter Maydell wrote: On 29 November 2012 12:37, Konrad Frederic wrote: On 26/11/2012 17:59, Anthony Liguori wrote: virtio-pci-bus extends virtio-bus - is constructed with a pointe

[Qemu-devel] LiveMigration and TSC

2012-11-29 Thread Peter Lieven
Hi, can someone give me a short status of the topic Live Migration and VMs that use TSC as clocksource? Broken, yes / no? And if yes under what circumstances? I have some TSC VMs that freeze occasionally after LiveMigration. Thank you, Peter

[Qemu-devel] [PATCHv4] rbd block driver fix race between aio completition and aio cancel

2012-11-29 Thread Stefan Priebe
This one fixes a race which qemu had also in iscsi block driver between cancellation and io completition. qemu_rbd_aio_cancel was not synchronously waiting for the end of the command. To archieve this it introduces a new status flag which uses -EINPROGRESS. Changes since PATCHv3: - removed unnec

Re: [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel

2012-11-29 Thread Stefan Priebe - Profihost AG
Hi, i hope i've done everything correctly. I've send a new v4 patch. Am 29.11.2012 14:58, schrieb Stefan Hajnoczi: On Thu, Nov 22, 2012 at 11:00:19AM +0100, Stefan Priebe wrote: @@ -406,10 +401,11 @@ static void qemu_rbd_complete_aio(RADOSCB *rcb) acb->ret = r; }

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2012 at 03:26:56PM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 29, 2012 at 03:54:25PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 22, 2012 at 04:16:44PM +0100, Stefan Hajnoczi wrote: > > > The data plane thread needs to map guest physical addresses to host > > > pointers. Norm

Re: [Qemu-devel] [PATCH v4 11/11] virtio-blk: add x-data-plane=on|off performance feature

2012-11-29 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 03:12:35PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 22, 2012 at 04:16:52PM +0100, Stefan Hajnoczi wrote: > > The virtio-blk-data-plane feature is easy to integrate into > > hw/virtio-blk.c. The data plane can be started and stopped similar to > > vhost-net. > > > > U

Re: [Qemu-devel] [PATCH v4 00/11] virtio: virtio-blk data plane

2012-11-29 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 04:09:28PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 29, 2012 at 10:18:59AM +0100, Stefan Hajnoczi wrote: > > Michael, Paolo: Are you happy with v4? > > Looks pretty clean by itself. I sent some comments but they can be > addressed later. What worries me most is the c

Re: [Qemu-devel] [PATCH v4 11/11] virtio-blk: add x-data-plane=on|off performance feature

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2012 at 03:45:55PM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 29, 2012 at 03:12:35PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 22, 2012 at 04:16:52PM +0100, Stefan Hajnoczi wrote: > > > The virtio-blk-data-plane feature is easy to integrate into > > > hw/virtio-blk.c. The d

Re: [Qemu-devel] [PATCH 15/37] target-i386: set default value of "hypervisor" feature using static property

2012-11-29 Thread Igor Mammedov
On Fri, 9 Nov 2012 16:48:07 +0100 Eduardo Habkost wrote: > > On 22/10/2012, at 17:03, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > --- > > target-i386/cpu.c | 9 +++-- > > 1 file changed, 3 insertions(+), 6 deletions(-) > > > > diff --git a/target-i386/cpu.c b/target-i386/c

[Qemu-devel] [PATCH] qdev: relax bus type check in qdev_device_add() (v2)

2012-11-29 Thread Anthony Liguori
We are currently checking for an exact type match. Use QOM dynamic_cast to check for a compatible type instead. Cc: Konrad Frederic Cc: Peter Maydell Signed-off-by: Anthony Liguori --- v1 -> v2: - also add cast to qbus_find_recursive (Peter) - simplify by doing object_dynamic_cast instead of

Re: [Qemu-devel] [PATCH v4 04/11] dataplane: add virtqueue vring code

2012-11-29 Thread Paolo Bonzini
> > +/* Toggle guest->host notifies */ > > +void vring_set_notification(VirtIODevice *vdev, Vring *vring, bool > > enable) > > +{ > > +if (vdev->guest_features & (1 << VIRTIO_RING_F_EVENT_IDX)) { > > +if (enable) { > > +vring_avail_event(&vring->vr) = vring->vr.avail->idx;

Re: [Qemu-devel] [PATCH] qdev: relax bus type check in qdev_device_add() (v2)

2012-11-29 Thread Konrad Frederic
On 29/11/2012 16:12, Anthony Liguori wrote: We are currently checking for an exact type match. Use QOM dynamic_cast to check for a compatible type instead. Cc: Konrad Frederic Cc: Peter Maydell Signed-off-by: Anthony Liguori --- v1 -> v2: - also add cast to qbus_find_recursive (Peter) - si

Re: [Qemu-devel] [PATCH v4 10/11] dataplane: add virtio-blk data plane code

2012-11-29 Thread Paolo Bonzini
> > +unsigned int num_reqs; > > +QemuMutex num_reqs_lock; > > OK the only reason this lock is needed is because > you want to drain outside the thread. > Won't it be better to queue process the drain request through > the thread? > You won't need any locks then. Draining is processed in

Re: [Qemu-devel] [PATCHv4] rbd block driver fix race between aio completition and aio cancel

2012-11-29 Thread Paolo Bonzini
- Messaggio originale - > Da: "Stefan Priebe" > A: qemu-devel@nongnu.org > Cc: stefa...@gmail.com, "josh durgin" , > ceph-de...@vger.kernel.org, pbonz...@redhat.com, > "Stefan Priebe" > Inviato: Giovedì, 29 novembre 2012 15:28:35 > Oggetto: [PATCHv4] rbd block driver fix race between a

Re: [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel

2012-11-29 Thread Paolo Bonzini
> > @@ -574,6 +570,12 @@ static void > > qemu_rbd_aio_cancel(BlockDriverAIOCB *blockacb) > > { > > RBDAIOCB *acb = (RBDAIOCB *) blockacb; > > acb->cancelled = 1; > > + > > +while (acb->status == -EINPROGRESS) { > > +qemu_aio_wait(); > > +} > > + > > There should be a

Re: [Qemu-devel] [PATCH v4 10/11] dataplane: add virtio-blk data plane code

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2012 at 10:21:31AM -0500, Paolo Bonzini wrote: > > > > +unsigned int num_reqs; > > > +QemuMutex num_reqs_lock; > > > > OK the only reason this lock is needed is because > > you want to drain outside the thread. > > Won't it be better to queue process the drain request thro

Re: [Qemu-devel] [PATCH v4 03/11] dataplane: add host memory mapping code

2012-11-29 Thread Paolo Bonzini
> > I don't understand. If memory in the VGA region returns true from > > memory_region_is_ram(), why would there be a problem? > > If you change this memory but you don't update the display. > Never happens with non buggy guests but we should catch and fail if > it does. Actually it _could_ hap

Re: [Qemu-devel] [PATCH v4 00/11] virtio: virtio-blk data plane

2012-11-29 Thread Michael S. Tsirkin
On Thu, Nov 29, 2012 at 03:48:04PM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 29, 2012 at 04:09:28PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 29, 2012 at 10:18:59AM +0100, Stefan Hajnoczi wrote: > > > Michael, Paolo: Are you happy with v4? > > > > Looks pretty clean by itself. I sent some

Re: [Qemu-devel] [PATCH] qdev: relax bus type check in qdev_device_add() (v2)

2012-11-29 Thread Andreas Färber
Am 29.11.2012 16:12, schrieb Anthony Liguori: > We are currently checking for an exact type match. Use QOM dynamic_cast to > check for a compatible type instead. > > Cc: Konrad Frederic > Cc: Peter Maydell > Signed-off-by: Anthony Liguori Reviewed-by: Andreas Färber Andreas -- SUSE LINUX

Re: [Qemu-devel] [PATCH 15/37] target-i386: set default value of "hypervisor" feature using static property

2012-11-29 Thread Eduardo Habkost
On Thu, Nov 29, 2012 at 03:56:09PM +0100, Igor Mammedov wrote: > On Fri, 9 Nov 2012 16:48:07 +0100 > Eduardo Habkost wrote: > > > > > On 22/10/2012, at 17:03, Igor Mammedov wrote: > > > > > Signed-off-by: Igor Mammedov > > > --- > > > target-i386/cpu.c | 9 +++-- > > > 1 file changed, 3 in

Re: [Qemu-devel] [PATCH v4 10/11] dataplane: add virtio-blk data plane code

2012-11-29 Thread Paolo Bonzini
- Messaggio originale - > Da: "Michael S. Tsirkin" > A: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, "Kevin Wolf" , "Anthony Liguori" > , "Blue Swirl" > , k...@us.ibm.com, "Asias He" , > "Stefan Hajnoczi" > Inviato: Giovedì, 29 novembre 2012 16:27:39 > Oggetto: Re: [PATCH v4 10/11] d

[Qemu-devel] [PATCH for-1.3] qemu-tech.texi: update implemented xtensa features list

2012-11-29 Thread Max Filippov
Debug option is available since QEMU-1.2; FP coprocessor and coprocessor context is available since QEMU-1.3. Signed-off-by: Max Filippov --- qemu-tech.texi | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/qemu-tech.texi b/qemu-tech.texi index d73dda8..8aefa74 10

[Qemu-devel] [PATCHv5 1.3] seccomp: adding new syscalls (bugzilla 855162)

2012-11-29 Thread Eduardo Otubo
According to the bug 855162[0] - there's the need of adding new syscalls to the whitelist when using Qemu with Libvirt. [0] - https://bugzilla.redhat.com/show_bug.cgi?id=855162 Reported-by: Paul Moore Signed-off-by: Eduardo Otubo Signed-off-by: Corey Bryant --- qemu-seccomp.c | 156 +

Re: [Qemu-devel] [PATCHv5 1.3] seccomp: adding new syscalls (bugzilla 855162)

2012-11-29 Thread Paul Moore
On Thursday, November 29, 2012 01:56:41 PM Eduardo Otubo wrote: > According to the bug 855162[0] - there's the need of adding new syscalls > to the whitelist when using Qemu with Libvirt. > > [0] - https://bugzilla.redhat.com/show_bug.cgi?id=855162 > > Reported-by: Paul Moore > Signed-off-by: Ed

Re: [Qemu-devel] [PATCH 1/1] exec: make -mem-path filenames deterministic

2012-11-29 Thread Peter Feiner
Ping? P.S. Please note a typo in the cover letter: when I referred to KSM, I meant "kernel samepage merging", not "kernel shared memory" :-) On Tue, Nov 20, 2012 at 7:10 AM, Peter Feiner wrote: > This patch makes the -mem-path filenames deterministic and allows some > control > over how QEMU m

Re: [Qemu-devel] [PATCH v2 0/6] block: bdrv_img_create(): propagate errors

2012-11-29 Thread Luiz Capitulino
On Fri, 2 Nov 2012 11:42:32 -0200 Luiz Capitulino wrote: > On Fri, 02 Nov 2012 14:40:03 +0100 > Kevin Wolf wrote: > > > Am 02.11.2012 14:25, schrieb Luiz Capitulino: > > > On Fri, 19 Oct 2012 11:27:59 -0300 > > > Luiz Capitulino wrote: > > > > > >> By adding error propagation to bdrv_img_crea

[Qemu-devel] [PATCH 3/3] hw/arm_gic_common: Correct GICC_PMR reset value for newer GICs

2012-11-29 Thread Peter Maydell
The GIC architecture specification for v1 and v2 GICs (as found on the Cortex-A9 and newer) states that the GICC_PMR reset value is zero; this differs from the 0xf0 reset value used on 11MPCore. The NVIC is different again in not having a CPU interface; since we share the GIC code we must force the

[Qemu-devel] [PATCH 1.3?] multiboot: fix e801 memory map

2012-11-29 Thread Paolo Bonzini
The e801 memory sizes in the multiboot structures hard-code the available low memory to 640. However, the value should not include the size of the EBDA. Fill the value in the option ROM, getting the size of low memory from the BIOS. Cc: Alexander Graf Signed-off-by: Paolo Bonzini --- A

[Qemu-devel] [PATCH] multiboot: fix e801 memory map

2012-11-29 Thread Paolo Bonzini
The e801 memory sizes in the multiboot structures hard-code the available low memory to 640. However, the value should not include the size of the EBDA. Fill the value in the option ROM, getting the size of low memory from the BIOS. Cc: Alexander Graf Signed-off-by: Paolo Bonzini --- pc-bios/

[Qemu-devel] [PATCH 0/3] ARM: fix secondary boot GIC init, GIC bugs

2012-11-29 Thread Peter Maydell
The secondary CPU boot code we use on ARM had a couple of places where it was accidentally relying on bugs or implementation dependent behaviour of QEMU's on GIC implementation: * we weren't initialising the GICC_PMR priority mask, which in a correct v1 or v2 GIC is set to mask out all interrup

[Qemu-devel] [PATCH 2/3] hw/arm_gic: Fix comparison with priority mask register

2012-11-29 Thread Peter Maydell
The GIC spec states that only interrupts with higher priority than the value in the GICC_PMR priority mask register are passed through to the processor. We were incorrectly allowing through interrupts with a priority equal to the specified value: correct the comparison operation to match the spec.

[Qemu-devel] [PATCH 1/3] hw/arm_boot, exynos4210, highbank: Fix secondary boot GIC init

2012-11-29 Thread Peter Maydell
Fix the code in the secondary CPU boot stubs so that it correctly initialises the GIC rather than relying on bugs or implementation dependent aspects of the QEMU GIC implementation: * set the GIC_PMR.Priority field to all-ones, so that all interrupts are passed through. The default of all-zeroe

[Qemu-devel] [PATCH v2 05/10] qemu-ga: build_fs_mount_list(): take an Error argument

2012-11-29 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- o v2: use error_setg() in build_fs_mount_list() qga/commands-posix.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index b3a3f26..ff14174 100644 --- a/qga/comman

Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: use irqfd to interrupt among VMs

2012-11-29 Thread Cam Macdonell
On Thu, Nov 29, 2012 at 1:34 AM, liu ping fan wrote: > On Thu, Nov 29, 2012 at 12:42 PM, Cam Macdonell wrote: >> On Tue, Nov 27, 2012 at 7:53 PM, liu ping fan wrote: >>> On Wed, Nov 28, 2012 at 5:48 AM, Cam Macdonell wrote: On Sat, Nov 24, 2012 at 8:51 PM, Liu Ping Fan wrote: > From:

Re: [Qemu-devel] [PATCH V7 0/6] VMXNET3 paravirtual NIC device implementation

2012-11-29 Thread Stefan Hajnoczi
On Fri, Nov 16, 2012 at 2:55 PM, Dmitry Fleytman wrote: > We didn't succeed to find any guide or sample for the > king of tests required (packets transmission). > If someone can provide a pointer to the relevant > information we'll be very grateful. QEMU does not have a NI

Re: [Qemu-devel] [PATCH 15/37] target-i386: set default value of "hypervisor" feature using static property

2012-11-29 Thread Igor Mammedov
On Thu, 29 Nov 2012 13:47:37 -0200 Eduardo Habkost wrote: > On Thu, Nov 29, 2012 at 03:56:09PM +0100, Igor Mammedov wrote: > > On Fri, 9 Nov 2012 16:48:07 +0100 > > Eduardo Habkost wrote: > > > > > > > > On 22/10/2012, at 17:03, Igor Mammedov wrote: > > > > > > > Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH]target-i386:cpu_x86_init():do clean up work

2012-11-29 Thread Eduardo Habkost
On Wed, Nov 28, 2012 at 02:20:23PM +0800, liguang wrote: > 1.remove unused variable env It's not unused. You are removing the line that sets env->cpu_model_str. > 2.remove redundant error handling > > Signed-off-by: liguang > --- > target-i386/helper.c | 17 - > 1 files chang

Re: [Qemu-devel] [PATCH 1.3?] multiboot: fix e801 memory map

2012-11-29 Thread Alexander Graf
On 29.11.2012, at 18:11, Paolo Bonzini wrote: > The e801 memory sizes in the multiboot structures hard-code the available > low memory to 640. However, the value should not include the size of the > EBDA. Fill the value in the option ROM, getting the size of low memory > from the BIOS. > > Cc:

Re: [Qemu-devel] [PATCH 1.3?] multiboot: fix e801 memory map

2012-11-29 Thread Alexander Graf
On 29.11.2012, at 18:11, Paolo Bonzini wrote: > The e801 memory sizes in the multiboot structures hard-code the available > low memory to 640. However, the value should not include the size of the > EBDA. Fill the value in the option ROM, getting the size of low memory > from the BIOS. The des

Re: [Qemu-devel] tap devices not receiving packets from a bridge

2012-11-29 Thread Peter Lieven
Am 23.11.2012 08:02, schrieb Stefan Hajnoczi: > On Thu, Nov 22, 2012 at 03:29:52PM +0100, Peter Lieven wrote: >> is anyone aware of a problem with the linux network bridge that in very rare >> circumstances stops >> a bridge from sending pakets to a tap device? >> >> My problem occurs in conjuncti

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-29 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Thu, Nov 29, 2012 at 06:34:46PM +0530, Amit Shah wrote: >> On (Wed) 28 Nov 2012 [23:53:08], Michael S. Tsirkin wrote: >> > On Tue, Nov 27, 2012 at 06:25:04PM +0200, Michael S. Tsirkin wrote: >> > > On Thu, Nov 01, 2012 at 06:07:21PM +0200, Michael S. Tsirkin wrot

Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-11-29 Thread Pasi Kärkkäinen
On Thu, Nov 29, 2012 at 01:57:11PM +, Ian Campbell wrote: > On Thu, 2012-11-29 at 13:21 +, Stefano Stabellini wrote: > > > Also I think 4.2.1 need these patches to enable the basic Xen on Xen > > > nested virtualization usage scenario. > > > > I agree. > > Nested virt was a tech preview i

Re: [Qemu-devel] [PATCH V7 0/6] VMXNET3 paravirtual NIC device implementation

2012-11-29 Thread Dmitry Fleytman
Hello Stefan Yes, we tested this device with various guests (both Linux and Windows) and it also passed WHQL tests for Windows Server 2008 R2 OS. The issue is Anthony asked us to write a basic test for the device (a packet transmission test) and we are trying to get some reference code or document

Re: [Qemu-devel] [PATCH 15/37] target-i386: set default value of "hypervisor" feature using static property

2012-11-29 Thread Eduardo Habkost
On Thu, Nov 29, 2012 at 07:30:29PM +0100, Igor Mammedov wrote: > On Thu, 29 Nov 2012 13:47:37 -0200 > Eduardo Habkost wrote: > > > On Thu, Nov 29, 2012 at 03:56:09PM +0100, Igor Mammedov wrote: > > > On Fri, 9 Nov 2012 16:48:07 +0100 > > > Eduardo Habkost wrote: > > > > > > > > > > > On 22/10/

Re: [Qemu-devel] [PATCH 1.3?] multiboot: fix e801 memory map

2012-11-29 Thread Paolo Bonzini
- Messaggio originale - > Da: "Alexander Graf" > A: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org > Inviato: Giovedì, 29 novembre 2012 19:51:07 > Oggetto: Re: [PATCH 1.3?] multiboot: fix e801 memory map > > > On 29.11.2012, at 18:11, Paolo Bonzini wrote: > > > The e801 memory sizes in

Re: [Qemu-devel] [PATCH V5 2/2] Enabling IA32_TSC_ADJUST for KVM guest VM support

2012-11-29 Thread Auld, Will
Marcelo, The behavior on reset is to return the TSC_AJUST msr value to 0x0. I am currently initializing this emulated msr in kvm_arch_vcpu_init(). >- Behaviour on reset: what is the behaviour on RESET? I am testing the rebase now. I would like to get any needed changes for this initialization

Re: [Qemu-devel] [PATCH 1.3?] multiboot: fix e801 memory map

2012-11-29 Thread Alexander Graf
On 29.11.2012, at 20:21, Paolo Bonzini wrote: > > > - Messaggio originale - >> Da: "Alexander Graf" >> A: "Paolo Bonzini" >> Cc: qemu-devel@nongnu.org >> Inviato: Giovedì, 29 novembre 2012 19:51:07 >> Oggetto: Re: [PATCH 1.3?] multiboot: fix e801 memory map >> >> >> On 29.11.2012, a

Re: [Qemu-devel] [PATCH 1.3?] multiboot: fix e801 memory map

2012-11-29 Thread Paolo Bonzini
Il 29/11/2012 20:24, Alexander Graf ha scritto: >> > It is in hw/multiboot.c: >> > >> >stl_p(bootinfo + MBI_MEM_LOWER, 640); > You want to remove that one then. I wasn't sure of what happens if the multiboot option ROM is old. Do we support that to any extent? > > Regarding the testcase,

Re: [Qemu-devel] [PATCH V5 2/2] Enabling IA32_TSC_ADJUST for KVM guest VM support

2012-11-29 Thread Marcelo Tosatti
On Thu, Nov 29, 2012 at 07:21:28PM +, Auld, Will wrote: > Marcelo, > > The behavior on reset is to return the TSC_AJUST msr value to 0x0. I am > currently initializing this emulated msr in kvm_arch_vcpu_init(). Will, Reset is handled by QEMU. kvm_arch_vcpu_init is only called during vcpu a

  1   2   >