On Thu, Nov 29, 2012 at 10:18:59AM +0100, Stefan Hajnoczi wrote: > Michael, Paolo: Are you happy with v4?
Looks pretty clean by itself. I sent some comments but they can be addressed later. What worries me most is the code duplication with regular virtio. I see two ways to reduce the maintainance somewhat - split out ring handling code in virtio-blk to a separate file to make it more obvious which part is inactive when data plane runs. - share ring processing code with virtio/virtio-blk (e.g. use callbacks) Was any thought given to implementing one of these two approaches? -- MST
