On 23 November 2012 15:17, Peter Maydell wrote:
> On 23 November 2012 15:15, Paolo Bonzini wrote:
>> You should at least test __i686__ too:
>>
>> $ gcc -m32 -dM -E -x c /dev/null |grep __i
>> #define __i686 1
>> #define __i686__ 1
>> #define __i386 1
>> #define __i386__ 1
>
> Yuck. I had assumed
On 23 November 2012 15:31, Jamie Lokier wrote:
> x86 instruction sets haven't followed a linear progression of features
> for quite a while, especially including non-Intel chips, so it stopped
> making sense for GCC to indicate the instruction set in that way.
If you're going to go down that rout
Hi,
While wading through the qemu acpi and seabios aml code I've figured the
qemu acpi codebase is *way* too messy. So this patch series switches
the apci code to the memory api. That alone cleans up quite a bit and
makes the code in hw/acpi.c more self-contained. As bonus everything
shows up
Signed-off-by: Gerd Hoffmann
---
hw/acpi_ich9.c | 38 --
hw/acpi_ich9.h |1 +
2 files changed, 29 insertions(+), 10 deletions(-)
diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c
index 0f025f8..aa290d6 100644
--- a/hw/acpi_ich9.c
+++ b/hw/acpi_ich9.c
@@ -73,1
Nothing left to do, everything handled by subregions,
we can zap the reaw/write handlers now.
Signed-off-by: Gerd Hoffmann
---
hw/acpi_ich9.c | 125 +---
1 files changed, 1 insertions(+), 124 deletions(-)
diff --git a/hw/acpi_ich9.c b/hw/acpi
Signed-off-by: Gerd Hoffmann
---
hw/acpi_ich9.c |8 +---
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c
index b3022c0..237b577 100644
--- a/hw/acpi_ich9.c
+++ b/hw/acpi_ich9.c
@@ -116,9 +116,6 @@ static void pm_ioport_writew(void *opaque, ui
Nothing left to do, everything handled by subregions,
we can zap the reaw/write handlers now.
Signed-off-by: Gerd Hoffmann
---
hw/acpi_piix4.c | 41 +
1 files changed, 1 insertions(+), 40 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index
Signed-off-by: Gerd Hoffmann
---
hw/ich9.h |1 +
hw/lpc_ich9.c | 29 +
hw/smbus_ich9.c | 12
3 files changed, 30 insertions(+), 12 deletions(-)
diff --git a/hw/ich9.h b/hw/ich9.h
index de49135..34e216f 100644
--- a/hw/ich9.h
+++ b/hw/ich9.
Signed-off-by: Gerd Hoffmann
---
hw/acpi_ich9.c | 18 +-
1 files changed, 1 insertions(+), 17 deletions(-)
diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c
index 237b577..0f025f8 100644
--- a/hw/acpi_ich9.c
+++ b/hw/acpi_ich9.c
@@ -105,17 +105,7 @@ static uint32_t pm_ioport_readb(v
Signed-off-by: Gerd Hoffmann
---
hw/acpi_piix4.c |5 ++---
hw/pm_smbus.c | 17 +
hw/pm_smbus.h |3 +--
hw/smbus_ich9.c | 52 +++-
hw/vt82c686.c |6 ++
5 files changed, 33 insertions(+), 50 deletions(-)
diff
Signed-off-by: Gerd Hoffmann
---
hw/acpi_piix4.c | 37 +
1 files changed, 29 insertions(+), 8 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index d74fff9..93aa319 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
@@ -42,6 +42,9 @@
#define G
Signed-off-by: Gerd Hoffmann
---
hw/acpi.c | 38 ++
hw/acpi.h |5 +++--
hw/acpi_piix4.c |8 +---
hw/vt82c686.c |8 +---
4 files changed, 35 insertions(+), 24 deletions(-)
diff --git a/hw/acpi.c b/hw/acpi.c
index ba25c23..956
>>Can you post more details about your benchmark setup so that this can be
>>reproduced? And does it reproduce with local files as well or only using
>>NFS?
Sure, I have redone tests, here the results:
(note that my netapp san have a nvram journal, so directio are as fast than
buffered io)
pre
On Fri, Nov 23, 2012 at 3:15 PM, Peter Maydell wrote:
> On 23 November 2012 14:11, Stefan Hajnoczi wrote:
>> On Thu, Nov 22, 2012 at 10:07 AM, Stefan Priebe
>> wrote:
>>> diff --git a/block/rbd.c b/block/rbd.c
>>> index 5a0f79f..0384c6c 100644
>>> --- a/block/rbd.c
>>> +++ b/block/rbd.c
>>> @@
Reported by Markus, and a regression from 1.1. Not really SCSI stuff,
just happens to have it in the name, so I'm not sending it through my tree.
Paolo Bonzini (2):
qom: dynamic_cast of NULL is always NULL
hmp: do not crash on invalid SCSI hotplug
hw/pci-hotplug.c | 8 +++-
qom/object.c
Trying to cast a NULL value will cause a crash. Returning
NULL is also sensible, and it is also what the type-unsafe
DO_UPCAST macro does.
Reported-by: Markus Armbruster
Signed-off-by: Paolo Bonzini
---
qom/object.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qom/ob
Commit 0d93692 (qdev: Convert busses to QEMU Object Model, 2012-05-02)
removed a check on the type of the bus where a SCSI disk is hotplugged.
However, hot-plugging to the wrong kind of device now causes a crash
due to either a NULL pointer dereference (avoided by the previous patch)
or a failed QO
Nothing left to do, everything handled by subregions,
we can zap the reaw/write handlers now.
Signed-off-by: Gerd Hoffmann
---
hw/vt82c686.c | 61 +
1 files changed, 1 insertions(+), 60 deletions(-)
diff --git a/hw/vt82c686.c b/hw/vt82c6
Signed-off-by: Gerd Hoffmann
---
hw/acpi_piix4.c | 30 +++---
1 files changed, 19 insertions(+), 11 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index 519269a..086f230 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
@@ -28,6 +28,7 @@
#include "range.h
On 19.10.2012, at 12:17, Julio Guerra wrote:
> This patch fixes bug 1031698 :
> https://bugs.launchpad.net/qemu/+bug/1031698
>
> If we look at the (truncated) translation of the conditional branch
> instruction in the test submitted in the bug post, the call to the
> exception helper is missing
On 20.11.2012, at 19:16, Peter Maydell wrote:
> Pass qemu_sglist_init the global dma_context_memory rather than a NULL
> pointer; this fixes a segfault in dma_memory_map() when the guest
> starts using DMA.
>
> Reported-by: Amadeusz Sławiński
> Signed-off-by: Peter Maydell
Thanks, applied to
Signed-off-by: Gerd Hoffmann
---
hw/acpi_ich9.c | 33 +++--
hw/acpi_ich9.h |1 +
2 files changed, 24 insertions(+), 10 deletions(-)
diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c
index 61034d3..e03b1a6 100644
--- a/hw/acpi_ich9.c
+++ b/hw/acpi_ich9.c
@@ -29,6 +29,
Signed-off-by: Gerd Hoffmann
---
hw/acpi.c | 49 +++--
hw/acpi.h |6 --
hw/acpi_piix4.c | 18 +-
hw/vt82c686.c | 18 +-
4 files changed, 53 insertions(+), 38 deletions(-)
diff --git a/hw/acpi.
On Fri, Nov 23, 2012 at 03:21:30PM +0100, Konrad Frederic wrote:
> On 23/11/2012 13:23, Stefan Hajnoczi wrote:
> >On Thu, Nov 22, 2012 at 03:50:50PM +0100, fred.kon...@greensocs.com wrote:
> >>+struct VirtioBusInfo {
> >This is defining an ad-hoc interface. QOM has support for interfaces so
> >tha
Am 23.11.2012 16:56, schrieb Paolo Bonzini:
> Trying to cast a NULL value will cause a crash. Returning
> NULL is also sensible, and it is also what the type-unsafe
> DO_UPCAST macro does.
>
> Reported-by: Markus Armbruster
> Signed-off-by: Paolo Bonzini
I believe we had a lengthy discussion o
Signed-off-by: Gerd Hoffmann
---
hw/vt82c686.c | 28 +++-
1 files changed, 23 insertions(+), 5 deletions(-)
diff --git a/hw/vt82c686.c b/hw/vt82c686.c
index 5d7c00c..7f9c7a2 100644
--- a/hw/vt82c686.c
+++ b/hw/vt82c686.c
@@ -24,6 +24,7 @@
#include "pm_smbus.h"
#includ
On Fri, Nov 23, 2012 at 03:29:52PM +0100, Konrad Frederic wrote:
> On 23/11/2012 13:38, Stefan Hajnoczi wrote:
> >On Thu, Nov 22, 2012 at 03:50:49PM +0100, fred.kon...@greensocs.com wrote:
> >>From: KONRAD Frederic
> >>I made the changes you suggest in the last RFC.
> >>
> >>There are still two iss
Peter Maydell wrote:
> On 23 November 2012 15:17, Peter Maydell wrote:
> > On 23 November 2012 15:15, Paolo Bonzini wrote:
> >> You should at least test __i686__ too:
> >>
> >> $ gcc -m32 -dM -E -x c /dev/null |grep __i
> >> #define __i686 1
> >> #define __i686__ 1
> >> #define __i386 1
> >> #def
Peter Maydell wrote:
> On 23 November 2012 15:31, Jamie Lokier wrote:
> > x86 instruction sets haven't followed a linear progression of features
> > for quite a while, especially including non-Intel chips, so it stopped
> > making sense for GCC to indicate the instruction set in that way.
>
> If
On Thu, Nov 22, 2012 at 09:02:54PM +0100, Christian Borntraeger wrote:
> here are two followup patches.
>
>
> Christian Borntraeger (2):
> block: simply default_drive
> block: clarify comment about IF_IDE = 0
>
> blockdev.h |6 +-
> vl.c | 20 ++--
> 2 files
Il 23/11/2012 17:16, Andreas Färber ha scritto:
>> > @@ -430,7 +430,7 @@ Object *object_dynamic_cast_assert(Object *obj, const
>> > char *typename)
>> >
>> > inst = object_dynamic_cast(obj, typename);
>> >
>> > -if (!inst) {
>> > +if (!inst && obj) {
>> > fprintf(stderr,
Am 23.11.2012 17:25, schrieb Paolo Bonzini:
> Il 23/11/2012 17:16, Andreas Färber ha scritto:
@@ -430,7 +430,7 @@ Object *object_dynamic_cast_assert(Object *obj, const
char *typename)
inst = object_dynamic_cast(obj, typename);
-if (!inst) {
+if (
Am 23.11.2012 17:06, schrieb Alexander Graf:
>
> On 19.10.2012, at 12:17, Julio Guerra wrote:
>
>> This patch fixes bug 1031698 :
>> https://bugs.launchpad.net/qemu/+bug/1031698
>>
>> If we look at the (truncated) translation of the conditional branch
>> instruction in the test submitted in the b
Am 23.11.2012 13:41, schrieb Marcelo Tosatti:
> From: Bruce Rogers
>
> The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip
> should be marked as having no argument.
>
> Signed-off-by: Bruce Rogers
> Reviewed-by: Jan Kiszka
Missing a
Reviewed-by: Stefan Hajnoczi
from
Am 23.11.2012 09:47, schrieb Paolo Bonzini:
> The reference count for embedded objects is always one too low, because
> object_initialize_with_type returns with zero references to the object.
> This causes premature finalization of the object (or an assertion failure)
> after calling object_ref to
Il 23/11/2012 17:30, Andreas Färber ha scritto:
> If having SCSI_BUS() return NULL was your intent you would not have
> needed to switch to object_dynamic_cast in your second patch. :)
In the second patch I needed object_dynamic_cast in case the bus was not
a SCSI bus at all.
For example:
$ qemu
Am 23.11.2012 09:47, schrieb Paolo Bonzini:
> Add an ObjectClass method that is done at object_unparent time. It
> should remove any backlinks to the object in the composition tree,
> so that object_delete will be able to drop the last reference and
> free the object.
>
> Use it for qdev buses.
>
Signed-off-by: Gerd Hoffmann
---
hw/acpi_piix4.c | 23 ++-
1 files changed, 22 insertions(+), 1 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index cd876c8..a85c2d4 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
@@ -146,12 +146,33 @@ static void pm_io_spac
With gpe being switched to memory api this is no longer needed.
Signed-off-by: Gerd Hoffmann
---
hw/acpi.c |7 ---
hw/acpi.h |2 --
hw/acpi_ich9.c |1 -
hw/acpi_piix4.c |1 -
4 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/hw/acpi.c b/hw/acpi.c
in
On 05.11.2012, at 12:34, Avik Sil wrote:
> On 10/26/2012 05:15 PM, Alexander Graf wrote:
>>
>> On 25.10.2012, at 22:57, Alexander Graf wrote:
>>
>>>
>>> On 25.10.2012, at 22:50, Peter Maydell wrote:
>>>
On 25 October 2012 21:18, Anthony Liguori wrote:
> The other approach to this w
Signed-off-by: Gerd Hoffmann
---
hw/acpi_ich9.c | 46 --
hw/acpi_ich9.h |1 +
2 files changed, 37 insertions(+), 10 deletions(-)
diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c
index aa290d6..cdfa266 100644
--- a/hw/acpi_ich9.c
+++ b/hw/acpi_ich9.c
Signed-off-by: Gerd Hoffmann
---
hw/acpi.c | 19 +--
hw/acpi.h |5 +++--
hw/acpi_piix4.c |5 +
hw/vt82c686.c |6 +-
4 files changed, 22 insertions(+), 13 deletions(-)
diff --git a/hw/acpi.c b/hw/acpi.c
index f4aca49..ba25c23 100644
--- a/hw/acp
Am 23.11.2012 09:47, schrieb Paolo Bonzini:
> Store in the object the freeing function that will be used at deletion
> time. This makes it possible to use object_delete on statically-allocated
> (embedded) objects. Dually, it makes it possible to use object_unparent
> and object_unref without lea
Am 23.11.2012 09:47, schrieb Paolo Bonzini:
> All conditional deallocation can now be done with object_delete.
> Remove the @qom_allocated and @glib_allocated fields; replace the latter
> with a direct assignment of the @free function pointer.
>
> Signed-off-by: Paolo Bonzini
I am grateful for y
Am 23.11.2012 09:47, schrieb Paolo Bonzini:
> It is not used anymore, and there is no need to make it public.
>
> Signed-off-by: Paolo Bonzini
We have not yet started using the in-place mechanism much (i440fx and
prep_pci patches, not in master; also my tegra branch), so I would like
to keep thi
Il 23/11/2012 18:07, Andreas Färber ha scritto:
>> > bus = g_malloc0(sizeof(*bus));
>> > -bus->qbus.glib_allocated = true;
>> > pci_bus_new_inplace(bus, parent, name, address_space_mem,
>> > address_space_io, devfn_min);
>> > +OBJECT(bus)->free = g_free;
>
Signed-off-by: Gerd Hoffmann
---
hw/acpi_ich9.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c
index e03b1a6..b3022c0 100644
--- a/hw/acpi_ich9.c
+++ b/hw/acpi_ich9.c
@@ -170,9 +170,6 @@ static uint32_t pm_ioport_readl(void *opaque, ui
Il 23/11/2012 18:12, Andreas Färber ha scritto:
> We have not yet started using the in-place mechanism much (i440fx and
> prep_pci patches, not in master; also my tegra branch), so I would like
> to keep this for symmetry with "initialize" vs. "new" and their
> distinguished semantics.
But you do
Il 23/11/2012 18:02, Andreas Färber ha scritto:
>> Store in the object the freeing function that will be used at deletion
>> > time. This makes it possible to use object_delete on statically-allocated
>> > (embedded) objects. Dually, it makes it possible to use object_unparent
>> > and object_unr
Signed-off-by: Gerd Hoffmann
---
hw/acpi_piix4.c | 24 ++--
1 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index a85c2d4..b75be72 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
@@ -57,6 +57,7 @@ struct pci_status {
type
Straightforward bug fixes, so they could qualify for 1.3. But since
the bugs are fairly harmless, we might want to postpone to 1.4
regardless. If we do, perhaps qemu-trivial could pick them up.
Markus Armbruster (2):
pc_sysfw: Check for qemu_find_file() failure
pc_sysfw: Plug memory leak on
Harmless, because we the error inevitably leads to another, fatal one
in pc_system_flash_init(): PC system firmware (pflash) not available.
Fix it anyway.
Signed-off-by: Markus Armbruster
---
hw/pc_sysfw.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/pc_sysfw.c b/hw/
pc_fw_add_pflash_drv() ignores qemu_find_file() failure, and happily
creates a drive without a medium.
When pc_system_flash_init() asks for its size, bdrv_getlength() fails
with -ENOMEDIUM, which isn't checked either. It fails relatively
cleanly only because -ENOMEDIUM isn't a multiple of 4096:
This patch adds basic Websocket Protocol version 13 - RFC 6455 - support
to QEMU VNC. Binary encoding support on the client side is mandatory.
Because of the GnuTLS requirement the Websockets implementation is
optional (--enable-vnc-ws).
To activate Websocket support the VNC option "websocket"is
Public bug reported:
I find the bug already reported on qemu-devel mailing-list [1] w/o
replies also on other sources.
Tested on Darwin (Mac OS X 10.7.5) and Scientific Linux 6.3 hosts. Also
using the latest 1.2.X and 1.3.0-rc0 and qemu-linaro. On all host
operating systems and with different ver
Status changed to 'Confirmed' because the bug affects multiple users.
** Changed in: qemu-linaro (Ubuntu)
Status: New => Confirmed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/955379
Title:
This fixes the following assertion caused by local temp reaching the end
of TB in discarded state:
qemu-system-xtensa: tcg/tcg.c:1665: temp_save: Assertion
`s->temps[temp].val_type == 2 || s->temps[temp].fixed_reg' failed.
Aborted
Signed-off-by: Max Filippov
---
target-xtensa/cpu.h |
Something new...
I have started to compile qemu with all the audio drivers --audio-drv-
list="oss alsa ps sdl esd" on 0.14.1 with a patch that was included in
0.15 and it compiles IF I edit ioctls.h and remove 3 lines about sound.
Oddly enough my kernel from CM9\Ubuntu is not compiled with those
Latest upstream qemu.git still reproduces this, so marking it as
affecting QEMU.
** Also affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/107971
ping ?
On Mon, Oct 8, 2012 at 5:53 PM, Julien Grall wrote:
> On 09/19/2012 12:50 PM, Julien Grall wrote:
>
> > This is the tenth version of patch series about ioport registration.
> >
> > Some part of QEMU still use register_ioport* functions to register
> ioport.
> > These functions doesn't all
** Also affects: qemu-linaro
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1082292
Title:
[ARM] pflash_write: Unimplemented flash cmd sequence
Status in
101 - 161 of 161 matches
Mail list logo