Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane

2012-11-20 Thread Asias He
Hello Stefan, On 11/15/2012 11:18 PM, Stefan Hajnoczi wrote: > This series adds the -device virtio-blk-pci,x-data-plane=on property that > enables a high performance I/O codepath. A dedicated thread is used to > process > virtio-blk requests outside the global mutex and without going through the

Re: [Qemu-devel] [BUG] qemu crash when using "lsilogic"

2012-11-20 Thread Wanlong Gao
On 11/19/2012 05:43 PM, Wanlong Gao wrote: > Hi all and Avi, > > I met the upstream qemu crash when using "lsilogic", my first sight is that I > can't access the VNC view, it gave me a black screen, here is my command line, > > /work/git/qemu/x86_64-softmmu/qemu-system-x86_64 -name f17 -m 3096 -M

Re: [Qemu-devel] [Qemu-ppc] [PATCH] kvm: fix incorrect length in a loop over kvm dirty pages map

2012-11-20 Thread Alexander Graf
On 20.11.2012, at 02:40, Alexey Kardashevskiy wrote: > QEMU allocates a map enough for 4k pages. However the system page size > can be 64K (for example on POWER) and the host kernel uses only a small > part of it as one big stores a dirty flag for 16 pages 4K each, > the hpratio variable stores t

Re: [Qemu-devel] [PATCH] vnc: fix option misspelling ("non-adapative" -> "non-adaptive")

2012-11-20 Thread Catalin Patulea
On Fri, Nov 9, 2012 at 7:19 PM, Peter Maydell wrote: > If we're gonna do this I guess it should go into 1.3... > cc'ing Anthony. Friendly ping for trivial patch :)

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Daniel P. Berrange
On Tue, Nov 20, 2012 at 08:50:09AM +0100, Gerd Hoffmann wrote: > On 11/19/12 14:11, Alexander Larsson wrote: > > This way you can easily tell from qemu if the guest is using > > a qxl driver or not. > > Device properties are for configuration, not inspection. Sounds like we need to expose somethi

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Gerd Hoffmann
On 11/20/12 10:07, Daniel P. Berrange wrote: > On Tue, Nov 20, 2012 at 08:50:09AM +0100, Gerd Hoffmann wrote: >> On 11/19/12 14:11, Alexander Larsson wrote: >>> This way you can easily tell from qemu if the guest is using >>> a qxl driver or not. >> >> Device properties are for configuration, not i

[Qemu-devel] [PATCH 2/2] qxl/verify_surface_cmd: check format != 0 (buggy drivers can do that)

2012-11-20 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index af5f68e..91e4fec 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -455,6 +455,12 @@ static int verify_surface_cmd(PCIQXLDevice *qxl, QXLSurfaceCmd *cmd) return 1;

[Qemu-devel] [PATCH 1/2] hw/qxl: extract verify_surface_cmd from qxl_track_command

2012-11-20 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 48 +--- 1 file changed, 29 insertions(+), 19 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 1482389..af5f68e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -430,6 +430,34 @@ static void qxl_ring_set_dirty(PCIQXLDe

[Qemu-devel] [PATCH v2] vnc: added initial websockets support

2012-11-20 Thread Tim Hardeck
This patch adds basic Websockets version 13 - RFC 6455 - support to QEMU VNC. Binary encoding support on the client side is required. Because of the GnuTLS requirement the Websockets implementation is optional (--enable-vnc-ws). To activate Websockets during runtime the VNC option "websocket" is

Re: [Qemu-devel] [Qemu-ppc] [PATCH 03/12] pseries: Move XICS initialization before cpu initialization

2012-11-20 Thread Alexander Graf
On 19.11.2012, at 23:47, David Gibson wrote: > On Tue, Nov 20, 2012 at 06:54:20AM +1100, Benjamin Herrenschmidt wrote: >> On Mon, 2012-11-19 at 17:22 +0100, Alexander Graf wrote: Currently, the pseries machine initializes the cpus, then the XICS interrupt controller. However, to suppor

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-20 Thread Alexander Graf
On 19.11.2012, at 23:51, David Gibson wrote: > On Mon, Nov 19, 2012 at 05:34:12PM +0100, Alexander Graf wrote: >> >> On 13.11.2012, at 03:47, David Gibson wrote: >> >>> From: Alexey Kardashevskiy >>> >>> In future (with VFIO) we will have multiple PCI host bridges on >>> pseries. Each one ne

Re: [Qemu-devel] [PATCH 2/3] s390: Virtual channel subsystem support.

2012-11-20 Thread Cornelia Huck
On Mon, 19 Nov 2012 14:30:00 +0100 Alexander Graf wrote: > > On 31.10.2012, at 17:24, Cornelia Huck wrote: > > > Provide a mechanism for qemu to provide fully virtual subchannels to > > the guest. In the KVM case, this relies on the kernel's css support > > for I/O and machine check interrupt h

[Qemu-devel] [PATCH 1/1] s390: Fix ram_size updating in machine init

2012-11-20 Thread Christian Borntraeger
From: Heinz Graalfs The global variable 'ram_size' is hidden by the local variable declaration in s390_init(). Since we want to update the global ram size in certain cases we must not use a local ram_size variable. - This fixes booting with unusual ram sizes like -m 67001 - This changes behaviour

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN

2012-11-20 Thread Alexander Graf
On 19.11.2012, at 23:48, David Gibson wrote: > On Mon, Nov 19, 2012 at 05:26:45PM +0100, Alexander Graf wrote: >> >> On 13.11.2012, at 03:46, David Gibson wrote: >> >>> Currently the ppcemb_tlb_t struct, used on a number of embedded ppc models >>> to represent a TLB entry contains a hwaddr. Th

Re: [Qemu-devel] [PATCH 1/1] s390: Fix ram_size updating in machine init

2012-11-20 Thread Alexander Graf
On 20.11.2012, at 10:28, Christian Borntraeger wrote: > From: Heinz Graalfs > > The global variable 'ram_size' is hidden by the local variable > declaration in s390_init(). Since we want to update the global > ram size in certain cases we must not use a local ram_size > variable. > - This fixes

Re: [Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-20 Thread Markus Armbruster
malc writes: > On Mon, 19 Nov 2012, Anthony Liguori wrote: > >> >> "Public domain" is not a valid copyright header/license grant. > > Sez who? FSF says CC0 is a public domain dedication from Creative Commons. A work released under CC0 is dedicated to the public domain to the fullest

Re: [Qemu-devel] [PATCH v2] vnc: added initial websockets support

2012-11-20 Thread Daniel P. Berrange
On Tue, Nov 20, 2012 at 10:21:58AM +0100, Tim Hardeck wrote: > This patch adds basic Websockets version 13 - RFC 6455 - support to QEMU > VNC. Binary encoding support on the client side is required. > > Because of the GnuTLS requirement the Websockets implementation is > optional (--enable-vnc-ws)

[Qemu-devel] [PATCH V10 0/7] libqblock qemu block layer library

2012-11-20 Thread Wenchao Xia
These patches introduce libqblock API, make subdir-libqblock and make check-libqblock could build this library. Functionalities: 1 create a new image. 2 sync access of an image. 3 basic image information retrieving such as backing file. 4 detect if a sector is allocated in an image. Supported

[Qemu-devel] [PATCH V10 5/7] libqblock type defines

2012-11-20 Thread Wenchao Xia
This patch contains type and macro defines used in APIs, one file for public usage, one for libqblock internal usage. Signed-off-by: Wenchao Xia --- libqblock/libqblock-internal.h | 75 libqblock/libqblock-types.h| 252 libqblock/lib

[Qemu-devel] [PATCH V10 6/7] libqblock API

2012-11-20 Thread Wenchao Xia
This patch contains the major APIs in the library. For ABI some reserved members were used. Important APIs: 1 QBlockContext. This structure was used to retrieve errors, every thread must create one first. 2 QBlockState. It stands for an block image object. 3 QBlockStaticInfo. It contains st

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Alon Levy
- Original Message - > On 11/20/12 10:07, Daniel P. Berrange wrote: > > On Tue, Nov 20, 2012 at 08:50:09AM +0100, Gerd Hoffmann wrote: > >> On 11/19/12 14:11, Alexander Larsson wrote: > >>> This way you can easily tell from qemu if the guest is using > >>> a qxl driver or not. > >> > >> Dev

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Alexander Larsson
On tis, 2012-11-20 at 10:48 +0100, Markus Armbruster wrote: > [Cc'ing Anthony because this could be of general QOM interest] > > Gerd Hoffmann writes: > > > On 11/19/12 14:11, Alexander Larsson wrote: > >> This way you can easily tell from qemu if the guest is using > >> a qxl driver or not. > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN

2012-11-20 Thread Peter Maydell
On 20 November 2012 09:29, Alexander Graf wrote: > On 19.11.2012, at 23:48, David Gibson wrote: >> On Mon, Nov 19, 2012 at 05:26:45PM +0100, Alexander Graf wrote: >>> On 13.11.2012, at 03:46, David Gibson wrote: This patch therefore changes ppcemb_tlb_t to use a fixed 64-bit integer whic

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN

2012-11-20 Thread Alexander Graf
On 20.11.2012, at 10:53, Peter Maydell wrote: > On 20 November 2012 09:29, Alexander Graf wrote: >> On 19.11.2012, at 23:48, David Gibson wrote: >>> On Mon, Nov 19, 2012 at 05:26:45PM +0100, Alexander Graf wrote: On 13.11.2012, at 03:46, David Gibson wrote: > This patch therefore change

Re: [Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-20 Thread malc
On Tue, 20 Nov 2012, Markus Armbruster wrote: > malc writes: > > > On Mon, 19 Nov 2012, Anthony Liguori wrote: > > > >> > >> "Public domain" is not a valid copyright header/license grant. > > > > Sez who? > Sez who was asked in response to "Is not a valid copyright/license grant." > FSF says

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Alexander Larsson
On tis, 2012-11-20 at 10:15 +0100, Gerd Hoffmann wrote: > On 11/20/12 10:07, Daniel P. Berrange wrote: > > On Tue, Nov 20, 2012 at 08:50:09AM +0100, Gerd Hoffmann wrote: > >> On 11/19/12 14:11, Alexander Larsson wrote: > >>> This way you can easily tell from qemu if the guest is using > >>> a qxl d

[Qemu-devel] [PATCH V10 1/7] Buildsystem fix distclean error for pixman

2012-11-20 Thread Wenchao Xia
Currently Makefile test if pixman have configure log, but the script directly return error if that file do not exist. This patch fix it. v2: print out the command. Signed-off-by: Wenchao Xia --- Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Make

Re: [Qemu-devel] [PATCH v11] kvm: notify host when the guest is panicked

2012-11-20 Thread Hu Tao
Hi Marcelo, On Tue, Nov 13, 2012 at 12:19:08AM -0200, Marcelo Tosatti wrote: > On Fri, Nov 09, 2012 at 03:17:39PM -0500, Sasha Levin wrote: > > On Mon, Nov 5, 2012 at 8:58 PM, Hu Tao wrote: > > > But in the case of panic notification, more dependency means more > > > chances of failure of panic n

Re: [Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-20 Thread Paolo Bonzini
Il 20/11/2012 10:59, malc ha scritto: > >> > >> "Public domain" is not a valid copyright header/license grant. >>> > > >>> > > Sez who? >> > > Sez who was asked in response to "Is not a valid copyright/license grant." > http://en.wikipedia.org/wiki/Wikipedia:Granting_work_into_the_pub

[Qemu-devel] [PATCH V10 2/7] Buildsystem clean tests directory clearly

2012-11-20 Thread Wenchao Xia
Currently root Makefile try clean tests/tcg, hard to extend. This patch added command make check-clean, which clean all generated files used in tests. With this command root Makefile do not care tests clean method any more, it simply calls the command to do it, so any more clean script could be a

[Qemu-devel] [PATCH V10 7/7] libqblock test example

2012-11-20 Thread Wenchao Xia
In this example, first it will create some qcow2 images, then try get information including backing file relationship, then it will do sync IO on the image. Signed-off-by: Wenchao Xia --- tests/check-libqblock-qcow2.c | 389 - 1 files changed, 388 inser

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Gerd Hoffmann
Hi, > I'm working on a kind of "troubleshooting log" option for gnome-boxes > which wants to record all these kinds of data so that a helpdesk or a > developer can help figuring out a problem with a guest. Understood. > Knowing if a qxl > driver is in use is an important piece of information.

[Qemu-devel] [PATCH V10 4/7] libqblock build system

2012-11-20 Thread Wenchao Xia
Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related source code will generate 3 sets of binary, first is old ones used in qemu, second and third are non PIC and PIC ones in ./libqblock. GCC

Re: [Qemu-devel] [PATCH v2] vnc: added initial websockets support

2012-11-20 Thread Tim Hardeck
On 11/20/2012 10:47 AM, Daniel P. Berrange wrote: > On Tue, Nov 20, 2012 at 10:21:58AM +0100, Tim Hardeck wrote: >> This patch adds basic Websockets version 13 - RFC 6455 - support to QEMU >> VNC. Binary encoding support on the client side is required. >> >> Because of the GnuTLS requirement the We

Re: [Qemu-devel] [PATCH v2] vnc: added initial websockets support

2012-11-20 Thread Daniel P. Berrange
On Tue, Nov 20, 2012 at 11:18:55AM +0100, Tim Hardeck wrote: > On 11/20/2012 10:47 AM, Daniel P. Berrange wrote: > > On Tue, Nov 20, 2012 at 10:21:58AM +0100, Tim Hardeck wrote: > >> This patch adds basic Websockets version 13 - RFC 6455 - support to QEMU > >> VNC. Binary encoding support on the cl

Re: [Qemu-devel] [PATCH V10 4/7] libqblock build system

2012-11-20 Thread Paolo Bonzini
Mostly looks good... Il 20/11/2012 10:46, Wenchao Xia ha scritto: > +libqblock="yes" Please make the default the empty string, i.e. "build if and only if libtool is present". > > +## > +# libqblock probe > +if test "$libqblock" != "no" ; then > +# libqblo

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Gerd Hoffmann
On 11/20/12 10:48, Markus Armbruster wrote: > [Cc'ing Anthony because this could be of general QOM interest] > > Gerd Hoffmann writes: > >> On 11/19/12 14:11, Alexander Larsson wrote: >>> This way you can easily tell from qemu if the guest is using >>> a qxl driver or not. >> >> Device propertie

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Markus Armbruster
[Cc'ing Anthony because this could be of general QOM interest] Gerd Hoffmann writes: > On 11/19/12 14:11, Alexander Larsson wrote: >> This way you can easily tell from qemu if the guest is using >> a qxl driver or not. > > Device properties are for configuration, not inspection. Read-only prope

[Qemu-devel] [PATCH V10 3/7] block export function path_has_protocol

2012-11-20 Thread Wenchao Xia
This function is needed in other module, so export it. There is already some patch on mail-list try export it, If that patch was applied, pls ignore this one. Signed-off-by: Wenchao Xia --- block.c |2 +- block.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/blo

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Alexander Larsson
On tis, 2012-11-20 at 11:17 +0100, Gerd Hoffmann wrote: > Hi, > > > I'm working on a kind of "troubleshooting log" option for gnome-boxes > > which wants to record all these kinds of data so that a helpdesk or a > > developer can help figuring out a problem with a guest. > > Understood. > > >

Re: [Qemu-devel] [PATCH V10 5/7] libqblock type defines

2012-11-20 Thread Paolo Bonzini
Il 20/11/2012 10:46, Wenchao Xia ha scritto: > This patch contains type and macro defines used in APIs, one file for public > usage, one for libqblock internal usage. Mostly looks good, just a few questions below. > Signed-off-by: Wenchao Xia > --- > libqblock/libqblock-internal.h | 75

Re: [Qemu-devel] [PATCH 1/2] hw/qxl: extract verify_surface_cmd from qxl_track_command

2012-11-20 Thread Gerd Hoffmann
On 11/20/12 10:19, Alon Levy wrote: > Signed-off-by: Alon Levy Doesn't apply to master. cheers, Gerd

Re: [Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-20 Thread Markus Armbruster
malc writes: > On Tue, 20 Nov 2012, Markus Armbruster wrote: > >> malc writes: >> >> > On Mon, 19 Nov 2012, Anthony Liguori wrote: >> > >> >> >> >> "Public domain" is not a valid copyright header/license grant. >> > >> > Sez who? >> > > Sez who was asked in response to "Is not a valid copyrig

Re: [Qemu-devel] [PATCH] LICENSE: clarify licensing

2012-11-20 Thread Markus Armbruster
malc writes: > On Mon, 19 Nov 2012, Anthony Liguori wrote: > >> malc writes: >> >> > On Mon, 19 Nov 2012, Peter Maydell wrote: >> > >> >> On 19 November 2012 18:21, malc wrote: >> >> > On Mon, 19 Nov 2012, Anthony Liguori wrote: >> >> >> +5) Files without explicit licenses fall under the GPL v

Re: [Qemu-devel] [PATCH V10 6/7] libqblock API

2012-11-20 Thread Paolo Bonzini
Il 20/11/2012 10:46, Wenchao Xia ha scritto: > diff --git a/libqblock/libqblock.h b/libqblock/libqblock.h > index e69de29..8ca7d28 100644 > --- a/libqblock/libqblock.h > +++ b/libqblock/libqblock.h Please move the creation of this file to the previous patch. I dislike QBlockState and would prefer

Re: [Qemu-devel] [BUG] qemu crash when using "lsilogic"

2012-11-20 Thread Avi Kivity
On 11/20/2012 11:01 AM, Wanlong Gao wrote: >> $ git bisect good >> d22b096ef6e0b20810193b68a1d472f3fb8a4f9e is the first bad commit >> commit d22b096ef6e0b20810193b68a1d472f3fb8a4f9e >> Author: Avi Kivity >> Date: Sun Sep 30 22:21:11 2012 +0200 >> >> kvm: use separate MemoryListeners for m

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Gerd Hoffmann
Hi, > I know that, but it would be possible to add code to the driver to > register a version string. Sure. Although it is a bit more complex that just a simple string. With qxl guest drivers moving to kms as we'll have two driver components then. > Might be useful for qxl developers, but not

Re: [Qemu-devel] [PATCH] migration: fix rate limiting

2012-11-20 Thread Juan Quintela
Paolo Bonzini wrote: > buffered_rate_limit is called to prevent the RAM migration callback > from putting too much data in the buffer. So it has to check against > the amount of data currently in the buffer, not against the amount > of data that has been transferred so far. > > s->bytes_xfer is u

Re: [Qemu-devel] [PATCH 1/2] hw/qxl: extract verify_surface_cmd from qxl_track_command

2012-11-20 Thread Alon Levy
> On 11/20/12 10:19, Alon Levy wrote: > > Signed-off-by: Alon Levy > > Doesn't apply to master. Good. It didn't apply because it was missing warn on sync io-usage and validate surface data. The later we agreed should be dropped in favor of spice reporting an error to qxl. > > cheers, > Ger

Re: [Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-20 Thread malc
On Tue, 20 Nov 2012, Paolo Bonzini wrote: > Il 20/11/2012 10:59, malc ha scritto: [..snip..] > > >> FSF says > > > > And what it says about CC0 or whatnot is utterly irrelevent. > > Surely their lawyers are better at copyright law than malc. Surely they are masters of Civil code of RF. > >

Re: [Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-20 Thread malc
On Tue, 20 Nov 2012, Markus Armbruster wrote: > malc writes: > > > On Tue, 20 Nov 2012, Markus Armbruster wrote: > > > >> malc writes: > >> > >> > On Mon, 19 Nov 2012, Anthony Liguori wrote: > >> > > >> >> > >> >> "Public domain" is not a valid copyright header/license grant. > >> > > >> > Se

Re: [Qemu-devel] [PATCH 1/1] Support default block interfaces per QEMUMachine

2012-11-20 Thread Christian Borntraeger
On 19/11/12 15:11, Markus Armbruster wrote: > > Generalizing QEMUMachine member use_scsi to a default BlockInterfaceType > makes plenty of sense to me. Great. > > I'm not sure "no initializer means IDE" is such a hot idea, but since > it's how use_scsi has always worked, I'm okay with making it

Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-20 Thread Alexander Larsson
> But there we are again at the level where going through the guest agent > might be a better way. "rpm -q kernel xorg-x11-drv-qxl" gives you what > you need ... Well, that relies on the agent working, and requires a lot of per-guest-os type of probing for the driver, as well as the fact that th

[Qemu-devel] VFIO VGA passthrough

2012-11-20 Thread ching
My PC is gentoo x64, kernel 3.6.6, intel sandy bridge i7 2600 + asrock Z77 exterme 4 MB I download qemu from git and try to pass through secondary VGA card to Windows 7 x64 SP1 VM: 01:00.0 VGA compatible controller: Advanced Micro Devices [AMD] nee ATI Cayman PRO [Radeon HD 6950] (prog-if 00

Re: [Qemu-devel] [PATCH 0/2] i2c: Add AT24Cxx EEPROM model

2012-11-20 Thread Jan Kiszka
On 2012-11-19 18:43, Stefan Weil wrote: > Am 19.11.2012 15:24, schrieb Jan Kiszka: >> See patches for details. >> >> Jan Kiszka (2): >>i2c: Introduce device address mask >>Add AT24Cxx I2C EEPROM device model >> > > Is AT24Cxx compatible to Microchip 24C02SC or SGS Thomson ST24C02 > (which

Re: [Qemu-devel] [PATCH v2] target-mips: Clean up microMIPS32 major opcode

2012-11-20 Thread Wei-Ren Chen
ping? -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj

Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane

2012-11-20 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 10:02 AM, Asias He wrote: > Hello Stefan, > > On 11/15/2012 11:18 PM, Stefan Hajnoczi wrote: >> This series adds the -device virtio-blk-pci,x-data-plane=on property that >> enables a high performance I/O codepath. A dedicated thread is used to >> process >> virtio-blk req

Re: [Qemu-devel] [PATCH 3/3] xilinx_zynq: added QSPI controller

2012-11-20 Thread walimis
Hi, Peter On Mon, Oct 29, 2012 at 04:45:00PM +1000, Peter Crosthwaite wrote: >Added the QSPI controller to the Zynq. 4 SPI devices are attached to allow >modelling of the different geometries. E.G. Dual parallel and dual stacked >mode can both be tested with this one arrangement. > >Signed-off-by:

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-20 Thread Michael S. Tsirkin
On Tue, Nov 20, 2012 at 10:27:11AM +0100, Alexander Graf wrote: > > On 19.11.2012, at 23:51, David Gibson wrote: > > > On Mon, Nov 19, 2012 at 05:34:12PM +0100, Alexander Graf wrote: > >> > >> On 13.11.2012, at 03:47, David Gibson wrote: > >> > >>> From: Alexey Kardashevskiy > >>> > >>> In fu

Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane

2012-11-20 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 1:21 PM, Stefan Hajnoczi wrote: > On Tue, Nov 20, 2012 at 10:02 AM, Asias He wrote: >> Hello Stefan, >> >> On 11/15/2012 11:18 PM, Stefan Hajnoczi wrote: >>> This series adds the -device virtio-blk-pci,x-data-plane=on property that >>> enables a high performance I/O codepa

[Qemu-devel] [PATCH] exec.c: Use tb1->phys_hash_next directly in tb_remove

2012-11-20 Thread Wei-Ren Chen
When tb_remove was first commited at fd6ce8f6, there were three different calls pass different names to offsetof. In current codebase, the other two calls are replaced with tb_page_remove. There is no need to have a general tb_remove. Omit passing the third parameter and using tb1->phys_hash_next

[Qemu-devel] [PATCH v2 3/8] dataplane: add host memory mapping code

2012-11-20 Thread Stefan Hajnoczi
The data plane thread needs to map guest physical addresses to host pointers. Normally this is done with cpu_physical_memory_map() but the function assumes the global mutex is held. The data plane thread does not touch the global mutex and therefore needs a thread-safe memory mapping mechanism.

[Qemu-devel] [PATCH v2 8/8] virtio-blk: add x-data-plane=on|off performance feature

2012-11-20 Thread Stefan Hajnoczi
The virtio-blk-data-plane feature is easy to integrate into hw/virtio-blk.c. The data plane can be started and stopped similar to vhost-net. Users can take advantage of the virtio-blk-data-plane feature using the new -device virtio-blk-pci,x-data-plane=on property. The x-data-plane name was chos

[Qemu-devel] [PATCH v2 4/8] dataplane: add virtqueue vring code

2012-11-20 Thread Stefan Hajnoczi
The virtio-blk-data-plane cannot access memory using the usual QEMU functions since it executes outside the global mutex and the memory APIs are this time are not thread-safe. This patch introduces a virtqueue module based on the kernel's vhost vring code. The trick is that we map guest memory ah

[Qemu-devel] [PATCH v2 7/8] dataplane: add virtio-blk data plane code

2012-11-20 Thread Stefan Hajnoczi
virtio-blk-data-plane is a subset implementation of virtio-blk. It only handles read, write, and flush requests. It does this using a dedicated thread that executes an epoll(2)-based event loop and processes I/O using Linux AIO. This approach performs very well but can be used for raw image file

Re: [Qemu-devel] [PATCH v2][RFC] Add compare subcommand for qemu-img

2012-11-20 Thread Kevin Wolf
Am 03.08.2012 08:45, schrieb Miroslav Rezanina: > This is second version of patch adding compare subcommand that compares two > images. Compare has following criteria: > - only data part is compared > - unallocated sectors are not read > - in case of different image size, exceeding part of bigg

Re: [Qemu-devel] [PATCH v2 8/8] virtio-blk: add x-data-plane=on|off performance feature

2012-11-20 Thread Daniel P. Berrange
On Tue, Nov 20, 2012 at 01:31:52PM +0100, Stefan Hajnoczi wrote: > The virtio-blk-data-plane feature is easy to integrate into > hw/virtio-blk.c. The data plane can be started and stopped similar to > vhost-net. > > Users can take advantage of the virtio-blk-data-plane feature using the > new -de

Re: [Qemu-devel] [PATCH] exec.c: Use tb1->phys_hash_next directly in tb_remove

2012-11-20 Thread Peter Maydell
On 20 November 2012 12:30, 陳韋任 (Wei-Ren Chen) wrote: > When tb_remove was first commited at fd6ce8f6, there were three different > calls pass different names to offsetof. In current codebase, the other two > calls are replaced with tb_page_remove. There is no need to have a general > tb_remove.

[Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-20 Thread Stefan Priebe
rbd / rados tends to return pretty often length of writes or discarded blocks. These values might be bigger than int. Signed-off-by: Stefan Priebe --- block/rbd.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index f57d0c6..6bf9c2e 100644 --

Re: [Qemu-devel] [PATCH v2 8/8] virtio-blk: add x-data-plane=on|off performance feature

2012-11-20 Thread Kevin Wolf
Am 20.11.2012 13:37, schrieb Daniel P. Berrange: > On Tue, Nov 20, 2012 at 01:31:52PM +0100, Stefan Hajnoczi wrote: >> The virtio-blk-data-plane feature is easy to integrate into >> hw/virtio-blk.c. The data plane can be started and stopped similar to >> vhost-net. >> >> Users can take advantage o

[Qemu-devel] [PATCH v2 1/8] raw-posix: add raw_get_aio_fd() for virtio-blk-data-plane

2012-11-20 Thread Stefan Hajnoczi
The raw_get_aio_fd() function allows virtio-blk-data-plane to get the file descriptor of a raw image file with Linux AIO enabled. This interface is really a layering violation that can be resolved once the block layer is able to run outside the global mutex - at that point virtio-blk-data-plane wi

Re: [Qemu-devel] [PATCH 1/1] Support default block interfaces per QEMUMachine

2012-11-20 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 12:22:59PM +0100, Christian Borntraeger wrote: > On 19/11/12 15:11, Markus Armbruster wrote: > I will try to review each place before re-submitting. Nice. Besides the points that have been mentioned this looks like a nice way to generalize. Looking forward to the next ser

Re: [Qemu-devel] [PATCH v2 7/8] dataplane: add virtio-blk data plane code

2012-11-20 Thread Michael S. Tsirkin
On Tue, Nov 20, 2012 at 01:31:51PM +0100, Stefan Hajnoczi wrote: > virtio-blk-data-plane is a subset implementation of virtio-blk. It only > handles read, write, and flush requests. It does this using a dedicated > thread that executes an epoll(2)-based event loop and processes I/O > using Linux

[Qemu-devel] [PATCH v2 5/8] dataplane: add event loop

2012-11-20 Thread Stefan Hajnoczi
Outside the safety of the global mutex we need to poll on file descriptors. I found epoll(2) is a convenient way to do that, although other options could replace this module in the future (such as an AioContext-based loop or glib's GMainLoop). One important feature of this small event loop implem

Re: [Qemu-devel] [PATCH v2][RFC] Add compare subcommand for qemu-img

2012-11-20 Thread Miroslav Rezanina
- Original Message - > From: "Kevin Wolf" > To: "Miroslav Rezanina" > Cc: qemu-devel@nongnu.org, pbonz...@redhat.com > Sent: Tuesday, November 20, 2012 1:36:37 PM > Subject: Re: [Qemu-devel] [PATCH v2][RFC] Add compare subcommand for qemu-img > > Am 03.08.2012 08:45, schrieb Miroslav Rez

[Qemu-devel] [PATCH v2 2/8] configure: add CONFIG_VIRTIO_BLK_DATA_PLANE

2012-11-20 Thread Stefan Hajnoczi
The virtio-blk-data-plane feature only works with Linux AIO. Therefore add a ./configure option and necessary checks to implement this dependency. Signed-off-by: Stefan Hajnoczi --- configure | 21 + 1 file changed, 21 insertions(+) diff --git a/configure b/configure index

Re: [Qemu-devel] [PATCH] vnc: fix option misspelling ("non-adapative" -> "non-adaptive")

2012-11-20 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 04:06:31AM -0500, Catalin Patulea wrote: > On Fri, Nov 9, 2012 at 7:19 PM, Peter Maydell > wrote: > > If we're gonna do this I guess it should go into 1.3... > > cc'ing Anthony. > Friendly ping for trivial patch :) Hi Catalin, In the future feel free to email qemu-triv...

Re: [Qemu-devel] [PATCH] vnc: fix option misspelling ("non-adapative" -> "non-adaptive")

2012-11-20 Thread Peter Maydell
On 20 November 2012 13:07, Stefan Hajnoczi wrote: > On Tue, Nov 20, 2012 at 04:06:31AM -0500, Catalin Patulea wrote: >> On Fri, Nov 9, 2012 at 7:19 PM, Peter Maydell >> wrote: >> > If we're gonna do this I guess it should go into 1.3... >> > cc'ing Anthony. >> Friendly ping for trivial patch :)

[Qemu-devel] [PATCH v2 0/8] virtio: virtio-blk data plane

2012-11-20 Thread Stefan Hajnoczi
This series adds the -device virtio-blk-pci,x-data-plane=on property that enables a high performance I/O codepath. A dedicated thread is used to process virtio-blk requests outside the global mutex and without going through the QEMU block layer. Khoa Huynh reported an increase from 140,000 IOPS

[Qemu-devel] [PATCH v2 6/8] dataplane: add Linux AIO request queue

2012-11-20 Thread Stefan Hajnoczi
The IOQueue has a pool of iocb structs and a function to add new read/write requests. Multiple requests can be added before calling the submit function to actually tell the host kernel to begin I/O. This allows callers to batch requests and submit them in one go. The actual I/O is performed usin

Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: Fix regression for MinGW (assertion caused by short string)

2012-11-20 Thread Stefan Hajnoczi
On Mon, Nov 19, 2012 at 06:38:16PM +0100, Stefan Weil wrote: > Am 19.11.2012 12:31, schrieb Stefan Hajnoczi: > >On Sun, Nov 18, 2012 at 09:26:15AM +0100, Stefan Weil wrote: > >>The local string tmp_filename is passed to function get_tmp_filename > >>which expects a string with minimum size MAX_PATH

Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: Fix regression for MinGW (assertion caused by short string)

2012-11-20 Thread Stefan Hajnoczi
On Mon, Nov 19, 2012 at 06:38:16PM +0100, Stefan Weil wrote: > If we want a better solution, we should also consider g_mkstemp > and related functions like g_file_open_tmp. We could also modify > bdrv_create to allow a NULL filename which is interpreted as a > temporary filename. IMHO that would be

Re: [Qemu-devel] [PATCH 2/2] Add AT24Cxx I2C EEPROM device model

2012-11-20 Thread Stefan Hajnoczi
On Mon, Nov 19, 2012 at 03:24:39PM +0100, Jan Kiszka wrote: > +static void at24_flush_transfer_buffer(AT24State *s) > +{ > +if (s->cached_sector < 0 || !s->cache_dirty) { > +return; > +} > +bdrv_write(s->bs, s->cached_sector, s->sector_buffer, 1); [...] > +static int at24_cache_

[Qemu-devel] [RFC v4 4/8] hw/arm_gic: Add presave/postload hooks

2012-11-20 Thread Peter Maydell
Add presave/postload hooks to the ARM GIC common base class. These will be used by the KVM in-kernel GIC subclass to sync state between kernel and userspace when migrating. Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber --- hw/arm_gic_common.c | 10 ++ hw/arm_gic_internal.

Re: [Qemu-devel] buildbot failure in qemu on block_mingw32

2012-11-20 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 01:04:49AM +0100, q...@buildbot.b1-systems.de wrote: > The Buildbot has detected a new failure on builder block_mingw32 while > building qemu. > Full details are available at: > http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/390 Known issue: O_NONBLOCK o

Re: [Qemu-devel] [PATCH 2/2] Add AT24Cxx I2C EEPROM device model

2012-11-20 Thread Jan Kiszka
On 2012-11-20 14:27, Stefan Hajnoczi wrote: > On Mon, Nov 19, 2012 at 03:24:39PM +0100, Jan Kiszka wrote: >> +static void at24_flush_transfer_buffer(AT24State *s) >> +{ >> +if (s->cached_sector < 0 || !s->cache_dirty) { >> +return; >> +} >> +bdrv_write(s->bs, s->cached_sector, s

Re: [Qemu-devel] [PATCH 0/4] AER-KVM: Error containment of PCI pass-thru devices assigned to KVM guests

2012-11-20 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 06:31:48AM +, Pandarathil, Vijaymohan R wrote: > Add support for error containment when a PCI pass-thru device assigned to a > KVM > guest encounters an error. This is for PCIe devices/drivers that support AER > functionality. When the OS is notified of an error in a de

Re: [Qemu-devel] buildbot failure in qemu on block_mingw32

2012-11-20 Thread Anthony Liguori
On Nov 20, 2012 7:36 AM, "Stefan Hajnoczi" wrote: > > On Tue, Nov 20, 2012 at 01:04:49AM +0100, qemu@buildbot.b1-systems.dewrote: > > The Buildbot has detected a new failure on builder block_mingw32 while building qemu. > > Full details are available at: > > http://buildbot.b1-systems.de/qemu/bui

Re: [Qemu-devel] [PATCH v2 8/8] virtio-blk: add x-data-plane=on|off performance feature

2012-11-20 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 12:37:08PM +, Daniel P. Berrange wrote: > On Tue, Nov 20, 2012 at 01:31:52PM +0100, Stefan Hajnoczi wrote: > > The virtio-blk-data-plane feature is easy to integrate into > > hw/virtio-blk.c. The data plane can be started and stopped similar to > > vhost-net. > > > > U

Re: [Qemu-devel] [PATCH v2 7/8] dataplane: add virtio-blk data plane code

2012-11-20 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 03:04:53PM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 20, 2012 at 01:31:51PM +0100, Stefan Hajnoczi wrote: > > +static void process_request(IOQueue *ioq, struct iovec iov[], > > +unsigned int out_num, unsigned int in_num, > > +

Re: [Qemu-devel] [kvmarm] [RFC v4 8/8] oslib-posix: Align to permit transparent hugepages on ARM Linux

2012-11-20 Thread Alexander Graf
On 11/20/2012 02:31 PM, Peter Maydell wrote: ARM Linux (like x86-64 Linux) can use transparent hugepages for KVM if memory blocks are 2MiB aligned; set QEMU_VMALLOC_ALIGN accordingly. Signed-off-by: Peter Maydell --- oslib-posix.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [RFC v4 6/8] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC

2012-11-20 Thread Peter Maydell
Implement support for using the KVM in-kernel GIC for ARM. Signed-off-by: Peter Maydell --- hw/a15mpcore.c |8 ++- hw/arm/Makefile.objs |1 + hw/kvm/arm_gic.c | 169 ++ 3 files changed, 177 insertions(+), 1 deletion(-) create mo

[Qemu-devel] [RFC v4 5/8] target-arm: Use MemoryListener to identify GIC base address for KVM

2012-11-20 Thread Peter Maydell
When using an in-kernel GIC with KVM, we need to tell the kernel where the GIC's memory mapped registers live. Do this by registering a MemoryListener which tracks where the board model maps the A15's private peripherals, so we can finish the GIC initialisation when the GIC is actually mapped. Sig

[Qemu-devel] [RFC v4 1/8] linux-headers: Add ARM KVM headers (not for upstream)

2012-11-20 Thread Peter Maydell
This commit adds the ARM KVM headers. This is not to go to QEMU upstream -- the correct path there is that the KVM code will be committed to a mainline upstream kernel, and then upstream QEMU can do a bulk header update from the upstream kernel, which will allow us to drop this temporary commit. T

[Qemu-devel] [RFC v4 2/8] ARM: KVM: Add support for KVM on ARM architecture

2012-11-20 Thread Peter Maydell
From: Christoffer Dall Add basic support for KVM on ARM architecture. Signed-off-by: Christoffer Dall [PMM: Minor tweaks and code cleanup, switch to ONE_REG] Signed-off-by: Peter Maydell --- hw/arm_pic.c | 26 target-arm/Makefile.objs |1 + target-arm/cpu.h |

[Qemu-devel] [RFC v4 3/8] ARM KVM: save and load VFP registers from kernel

2012-11-20 Thread Peter Maydell
Add support for saving and restoring VFP register state from the kernel. This includes a check that the KVM-created CPU has full VFP support (as the TCG Cortex-A15 model always does), since for the moment ARM QEMU doesn't have any way to tweak optional features on created CPUs. Signed-off-by: Pete

Re: [Qemu-devel] [PATCH 2/2] Add AT24Cxx I2C EEPROM device model

2012-11-20 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 02:37:07PM +0100, Jan Kiszka wrote: > On 2012-11-20 14:27, Stefan Hajnoczi wrote: > > On Mon, Nov 19, 2012 at 03:24:39PM +0100, Jan Kiszka wrote: > >> +static void at24_flush_transfer_buffer(AT24State *s) > >> +{ > >> +if (s->cached_sector < 0 || !s->cache_dirty) { > >>

Re: [Qemu-devel] [PATCH 0/4] AER-KVM: Error containment of PCI pass-thru devices assigned to KVM guests

2012-11-20 Thread Pandarathil, Vijaymohan R
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Tuesday, November 20, 2012 5:41 AM > To: Pandarathil, Vijaymohan R > Cc: k...@vger.kernel.org; linux-...@vger.kernel.org; qemu-devel@nongnu.org; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH 0/4] AER-K

Re: [Qemu-devel] [RFC PATCH 1/3] virtio-bus : Introduce VirtioBus.

2012-11-20 Thread Cornelia Huck
On Mon, 19 Nov 2012 17:33:01 + Peter Maydell wrote: > On 16 November 2012 15:35, wrote: > > From: KONRAD Frederic > > You forgot to CC enough people... > > > This patch create a new VirtioBus, which can be added to Virtio transports > > like > > virtio-pci, virtio-mmio,... > > > > One V

Re: [Qemu-devel] [kvmarm] [RFC v4 8/8] oslib-posix: Align to permit transparent hugepages on ARM Linux

2012-11-20 Thread Christoffer Dall
On Tue, Nov 20, 2012 at 8:54 AM, Alexander Graf wrote: > On 11/20/2012 02:31 PM, Peter Maydell wrote: >> >> ARM Linux (like x86-64 Linux) can use transparent hugepages for >> KVM if memory blocks are 2MiB aligned; set QEMU_VMALLOC_ALIGN >> accordingly. >> >> Signed-off-by: Peter Maydell >> --- >>

  1   2   3   >