netdev_del assume that remove host network device.
However, when try to remove a non-host network device
by netdev_del, it will cause a segfault.
The reson is that qmp_netdev_del is not checking for
a NULL return for qemu_find_opts_err in case find_list
did not find the netdev group to delete.
Ca
Hi,
>> -static int usb_ehci_initfn(PCIDevice *dev)
>> +static void usb_ehci_initfn(EHCIState *s, DeviceState *dev)
>> {
>> -EHCIState *s = DO_UPCAST(EHCIState, dev, dev);
>> +static int usb_ehci_pci_initfn(PCIDevice *dev)
>> +{
>> +EHCIPCIState *i = DO_UPCAST(EHCIPCIState, pcidev, dev)
Hi,
> The main drawback of if=ahci is, as pointed out by Markus, that you
> would have to provide both controllers on-board. I think a real ICH9
> has the compatibility IDE controller on a separate PCI address from the
> SATA controller, so creating both of them is not really out of question.
On Wed, Oct 31, 2012 at 01:16:56PM +0200, Avi Kivity wrote:
> On 10/31/2012 12:58 PM, Stefan Hajnoczi wrote:
> > On Fri, Sep 21, 2012 at 1:17 PM, Vasilis Liaskovitis
> > wrote:
> >> This is v3 of the ACPI memory hotplug functionality. Only x86_64 target is
> >> supported
> >> for now.
> >
> > Hi
Patch 1-3 are from Luiz, added Markus's comments, discussion could be found
here:
http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html
Patch 3 was changed according Paolo's comments.
Patch 4-5: because qemu_opts_create can not fail while id is null, so create
function qemu_opts_c
Signed-off-by: Dong Xu Wang
---
v4->v5:
1) Use g_strdup_printf.
qemu-option.c | 22 ++
qemu-option.h |1 +
2 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/qemu-option.c b/qemu-option.c
index 1303188..94557cf 100644
--- a/qemu-option.c
+++ b/qemu-option.c
Use opts_accepts_any() and find_desc_by_name().
Signed-off-by: Luiz Capitulino
Signed-off-by: Dong Xu Wang
---
qemu-option.c | 14 +++---
1 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/qemu-option.c b/qemu-option.c
index 375daaa..74321bb 100644
--- a/qemu-option.c
+++
This patch will use QemuOpts related functions in block layer, add
a member bdrv_create_options to BlockDriver struct, it will return
a QemuOptsList pointer, which includes the image format's create
options.
And create options's primary consumer is block creating related functions,
so modify them
This patch will create 4 functions, count_opts_list, append_opts_list,
free_opts_list and print_opts_list, they will used in following commits.
Signed-off-by: Dong Xu Wang
---
qemu-option.c | 90 +
qemu-option.h |4 ++
2 files changed
Signed-off-by: Dong Xu Wang
---
qemu-option.c | 285 -
qemu-option.h | 32 ---
2 files changed, 0 insertions(+), 317 deletions(-)
diff --git a/qemu-option.c b/qemu-option.c
index 5dfbf35..560e44a 100644
--- a/qemu-option.c
+++ b/qemu
On (Tue) 23 Oct 2012 [14:55:03], Stefan Hajnoczi wrote:
> On Mon, Oct 22, 2012 at 06:50:00AM -0700, Edivaldo de Araujo Pereira wrote:
> > I didn't take enough time to uderstand the code, so unfortunately I fear
> > there is not much I could do to solve the problem, apart from trying your
> > sugg
On 10/31/12 13:53, Alon Levy wrote:
> I cannot find a reason we asserted that injecting interrupts happen only
> when the vm is running. This is right now the cause of spice crashing
> due to the new interface_client_set_capabilities being called when the
> vm is stopped, this happens if a user sto
It will introduce a new file format: add-cow.
The add-cow file format makes it possible to perform copy-on-write on top of
a raw disk image. When we know that no backing file clusters remain visible
(e.g. we have streamed the entire image and copied all data from the backing
file), then it is pos
We will use path_has_protocol outside block.c, so just make it public.
Signed-off-by: Dong Xu Wang
Reviewed-by: Michael Roth
---
block.c |2 +-
block.h |1 +
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/block.c b/block.c
index 8d2e4fc..826a9ba 100644
--- a/block.c
+++
Document for add-cow format, the usage and spec of add-cow are introduced.
Signed-off-by: Dong Xu Wang
---
v14->v15:
1) Fix some typo and make sentences more readable.
docs/specs/add-cow.txt | 154
1 files changed, 154 insertions(+), 0 deletions
This patch will use qemu-iotests to test add-cow file format.
Signed-off-by: Dong Xu Wang
---
tests/qemu-iotests/017 |2 +-
tests/qemu-iotests/020 |2 +-
tests/qemu-iotests/common|6 ++
tests/qemu-iotests/common.rc | 15 ++-
4 files changed, 22 inser
We will re-use qcow2-cache as block layer common cache code,
so change its name and made some changes, define a struct named
BlockTableType, pass BlockTableType and table size parameters to
block cache initialization function.
Signed-off-by: Dong Xu Wang
---
block/Makefile.objs|3 +-
blo
On 10/25/12 14:27, Alon Levy wrote:
> Signed-off-by: Alon Levy
Looks sane at a quick glance.
But: how far we wanna take this? Add checks to qxl for each and every
assert() guests can trigger in spice-server? So we end up
sanity-checking everything twice long-term?
I think instead we'll need a
It will set opt->str in qemu_opt_set_bool, without opt->str, there
will be some potential bugs.
These are uses of opt->str, and what happens when it isn't set:
* qemu_opt_get(): returns NULL, which means "not set". Bug can bite
when value isn't the default value.
* qemu_opt_parse(): passes NU
The current model of loader copy "rom blobs" and kept in memory until a reset
occurs and waste host memory.
This serial of patches uses private reset handlers to load from hard disk on
reset, which could make loader framework more dynamic and reduce the memory
consumption of QEMU process.
Olivia
Signed-off-by: Olivia Yin
---
hw/loader.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/hw/loader.c b/hw/loader.c
index 0581c71..17908cf 100644
--- a/hw/loader.c
+++ b/hw/loader.c
@@ -738,11 +738,8 @@ static void rom_reset(void *unused)
continue;
Signed-off-by: Olivia Yin
---
hw/loader.c | 40
1 files changed, 40 insertions(+), 0 deletions(-)
diff --git a/hw/loader.c b/hw/loader.c
index ba01ca6..a4c095e 100644
--- a/hw/loader.c
+++ b/hw/loader.c
@@ -56,6 +56,13 @@
static int roms_loaded;
+t
The new functions are opts_accepts_any() and find_desc_by_name(), which
are also going to be used by qemu_opts_validate() (see next commit).
This also makes opt_set() slightly more readable.
Signed-off-by: Luiz Capitulino
Signed-off-by: Dong Xu Wang
---
qemu-option.c | 40 +++
Fix the problem that can not delete the udp socket.
It's caused by passing "udp" model to net_socket_udp_init,
but we do not have "udp" model in our model list.
Pass the right model "socket" to init function.
https://bugs.launchpad.net/qemu/+bug/1073585?comments=all
Signed-off-by: Lei Li
---
ne
On Thu, Nov 1, 2012 at 8:48 AM, Lei Li wrote:
> netdev_del assume that remove host network device.
> However, when try to remove a non-host network device
> by netdev_del, it will cause a segfault.
I recently sent a similar fix which forbids deleting non-netdev net
clients from netdev_del:
http:/
> On 10/25/12 14:27, Alon Levy wrote:
> > Signed-off-by: Alon Levy
>
> Looks sane at a quick glance.
>
> But: how far we wanna take this? Add checks to qxl for each and
> every
> assert() guests can trigger in spice-server? So we end up
> sanity-checking everything twice long-term?
>
> I thin
"GTESTER check-qtest-i386
command timed out: 1200 seconds without output, attempting to kill"
The buildslave had a load average of 10 and was having trouble making
progress. I have killed off qemu processes and hopefully things will
work normally again.
I also tested that make check terminates
> On 10/31/12 13:53, Alon Levy wrote:
> > I cannot find a reason we asserted that injecting interrupts happen
> > only
> > when the vm is running. This is right now the cause of spice
> > crashing
> > due to the new interface_client_set_capabilities being called when
> > the
> > vm is stopped, this
add-cow file format core code. It use block-cache.c as cache code.
It lacks of snapshot_blkdev support.
Signed-off-by: Dong Xu Wang
---
block/Makefile.objs |1 +
block/add-cow.c | 687 +++
block/add-cow.h | 83 ++
block/block-cac
On Wed, Oct 31, 2012 at 06:34:07PM +0200, Michael S. Tsirkin wrote:
> On Wed, Oct 31, 2012 at 03:51:08PM +0100, Stefan Hajnoczi wrote:
> > On Wed, Oct 31, 2012 at 10:57:24AM +0200, Michael S. Tsirkin wrote:
> > > On Wed, Oct 31, 2012 at 09:07:27AM +0100, Stefan Hajnoczi wrote:
> > > > On Tue, Oct 3
qemu_opts_print has no user now, so can re-write the function safely.
qemu_opts_print will be used while using "qemu-img create", it will
produce the same output as previous code.
The behavior of this function has changed:
1. Print every possible option, whether a value has been set or not.
2. O
Hi,
>> IMO spice-server must not call interface_client_set_capabilities
>> when the vm is not running. After all we notify spice-server about
>> the vm stop/start events for a reason ...
>
> OK, I agree that should be fixed, we can queue this until the vm
> starts running in spice-server. But
Make qed_read_string function to a common interface, so move it to block.c.
Signed-off-by: Dong Xu Wang
---
block.c | 27 +++
block.h |2 ++
block/qed.c | 34 --
3 files changed, 33 insertions(+), 30 deletions(-)
diff --git
We will use qemu_opts_create_nofail function, it can make code
more readable.
Signed-off-by: Dong Xu Wang
---
blockdev.c |2 +-
hw/watchdog.c |2 +-
qemu-config.c |4 ++--
qemu-img.c |2 +-
qemu-sockets.c | 16
vl.c | 12 +---
6 fi
On Thu, Nov 01, 2012 at 05:39:55PM +0800, Lei Li wrote:
> Fix the problem that can not delete the udp socket.
> It's caused by passing "udp" model to net_socket_udp_init,
> but we do not have "udp" model in our model list.
> Pass the right model "socket" to init function.
>
> https://bugs.launchpa
On Wed, Oct 24, 2012 at 02:34:12PM +0200, Stefan Hajnoczi wrote:
> The netdev_del command crashes when given a -net device, because it
> calls qemu_opts_del(NULL).
>
> Check that this is a -netdev before attempting to delete it and the
> QemuOpts.
>
> Note the subtle change from qemu_find_opts_er
On 10/31/12 13:47, Hans de Goede wrote:
> +/*
> + * If we had leftover packets the hcd driver will have cancelled them
> + * and usb_combined_packet_cancel has already freed combined!
> + */
> +if (state != leftover) {
> +g_free(combined);
> +}
This calls for refere
On 30.10.2012, at 04:24, David Gibson wrote:
> With PAPR guests, hypercalls allow registration of the Virtual Processor
> Area (VPA), SLB shadow and dispatch trace log (DTL), each of which allow
> for certain communication between the guest and hypervisor. Currently, we
> store the addresses of
On 10/31/12 13:47, Hans de Goede wrote:
> +if (p->combined) {
> +iov_to_buf(p->combined->iov.iov, p->combined->iov.niov,
> + 0, buf, size);
> +} else {
> +usb_packet_copy(p, buf, size);
> +}
Should we make usb_packet_copy & frie
While id is NULL, qemu_opts_create can not fail, so ignore
errors is fine.
Signed-off-by: Dong Xu Wang
---
v4->v5:
1) Rewrite qemu_opts_create_nofail.
qemu-option.c |9 +
qemu-option.h |1 +
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/qemu-option.c b/qemu-opt
Signed-off-by: Olivia Yin
---
hw/loader.c | 57 +++--
1 files changed, 43 insertions(+), 14 deletions(-)
diff --git a/hw/loader.c b/hw/loader.c
index a4c095e..0581c71 100644
--- a/hw/loader.c
+++ b/hw/loader.c
@@ -55,6 +55,7 @@
#include
On 30.10.2012, at 04:25, David Gibson wrote:
> From: Ben Herrenschmidt
>
> Currently the lowest "real" irq number for the XICS irq controller (as
> opposed to numbers reserved for IPIs and other special purposes) is
> hard coded as 16 in two places - in xics_system_init() and in spapr.c.
>
> A
On 30.10.2012, at 04:25, David Gibson wrote:
> From: Ben Herrenschmidt
>
> Currently, the pseries machine initializes the cpus, then the XICS
> interrupt controller. However, to support the upcoming in-kernel XICS
> implementation we will need to initialize the irq controller before the
> vcpu
> Hi,
>
> >> IMO spice-server must not call interface_client_set_capabilities
> >> when the vm is not running. After all we notify spice-server
> >> about
> >> the vm stop/start events for a reason ...
> >
> > OK, I agree that should be fixed, we can queue this until the vm
> > starts running in
On 30.10.2012, at 04:24, David Gibson wrote:
> Alex,
>
> Having updated for your latest merge upstream, here's my current
> pending set of pseries related patches. Note that 1/16 is an
> important bugfix reverting a broken patch of yours: old_portio is not
> gone, alas, so we still need the wor
Hi,
> This prevents a known abort on set_client_capabilities, that should be
> fixed in upstream, but it should also be checked against in qxl. Checks
> every other location that qxl_send_events is eventually possibly called
Why check in all callers instead of qxl_send_events direct
From: "Gabriel L. Somlo"
Some guest operating systems' drivers (Mac OS X in particular) fail to
properly initialize the Receive Address registers (probably expecting
them to be pre-initialized by an earlier component, such as a specific
proprietary BIOS). This patch pre-initializes the RA registe
From: Lei Li
Fix the problem that can not delete the udp socket.
It's caused by passing "udp" model to net_socket_udp_init,
but we do not have "udp" model in our model list.
Pass the right model "socket" to init function.
https://bugs.launchpad.net/qemu/+bug/1073585?comments=all
Signed-off-by:
On Thu, Nov 01, 2012 at 10:53:52AM +0100, Stefan Hajnoczi wrote:
> On Wed, Oct 31, 2012 at 06:34:07PM +0200, Michael S. Tsirkin wrote:
> > On Wed, Oct 31, 2012 at 03:51:08PM +0100, Stefan Hajnoczi wrote:
> > > On Wed, Oct 31, 2012 at 10:57:24AM +0200, Michael S. Tsirkin wrote:
> > > > On Wed, Oct 3
On Wed, 2012-10-31 at 17:44 +0100, Kevin Wolf wrote:
> Am 31.10.2012 15:33, schrieb Paolo Bonzini:
> > Il 31/10/2012 15:01, n...@bytemark.co.uk ha scritto:
> >> From: Nick Thomas
> >>
> >> To do this, we start a qemu-nbd process at _make_test_img and kill
> >> it in _cleanup_test_img. $TEST_IMG is
The netdev_del command crashes when given a -net device, because it
calls qemu_opts_del(NULL).
Check that this is a -netdev before attempting to delete it and the
QemuOpts.
Note the subtle change from qemu_find_opts_err("netdev", errp) to
qemu_find_opts_err("netdev", NULL). Since "netdev" is a b
The following changes since commit 286d52ebfc0d0d53c2a878e454292fea14bad41b:
target-mips: don't flush extra TLB on permissions upgrade (2012-10-31
22:20:49 +0100)
are available in the git repository at:
git://github.com/stefanha/qemu.git net
for you to fetch changes up to 372254c6e5c078fb1
On Mon, Oct 15, 2012 at 09:46:06PM -, Edivaldo de Araujo Pereira wrote:
> Hi Stefan,
>
> Thank you, very much for taking the time to help me, and excuse me for
> not seeing your answer early...
>
> I've run the procedure you pointed me out, and the result is:
>
> 0d8d7690850eb0cf2b2b60933cf4
From: Dmitry Fleytman
Real HW always treats RX ring with RDH == RDT as empty.
Emulation is supposed to behave the same.
Reported-by: Chris Webb
Reported-by: Richard Davies
Signed-off-by: Dmitry Fleytman
Signed-off-by: Stefan Hajnoczi
---
hw/e1000.c | 7 ++-
1 file changed, 2 insertions(
> Hi,
>
> > This prevents a known abort on set_client_capabilities, that
> > should be
> > fixed in upstream, but it should also be checked against in
> > qxl. Checks
> > every other location that qxl_send_events is eventually
> > possibly called
>
> Why check in all calle
On Thu, Nov 01, 2012 at 02:49:18PM +0530, Amit Shah wrote:
> On (Tue) 23 Oct 2012 [14:55:03], Stefan Hajnoczi wrote:
> > On Mon, Oct 22, 2012 at 06:50:00AM -0700, Edivaldo de Araujo Pereira wrote:
> > > I didn't take enough time to uderstand the code, so unfortunately I fear
> > > there is not muc
From: David Gibson
This patch adds some extra FPU state to CPUPPCState. Specifically,
fpscr is extended to a target_ulong bits, since some recent (64 bit)
CPUs now have more status bits than fit inside 32 bits. Also, we add
the 32 VSR registers present on CPUs with VSX (these extend the
standar
Hi Blue / Aurelien,
This is my current patch queue for ppc. Please pull.
Alex
The following changes since commit 286d52ebfc0d0d53c2a878e454292fea14bad41b:
Aurelien Jarno (1):
target-mips: don't flush extra TLB on permissions upgrade
are available in the git repository at:
git://r
From: David Gibson
A couple of places in xics.c open-coded the same logic as is already
implemented in ics_valid_irq(). This patch fixes the code duplication.
Signed-off-by: David Gibson
Signed-off-by: Alexander Graf
---
hw/xics.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(
ui/spice-display.c uses ds_mirror to figure which screen areas did
actually change. This is active when the qxl card is in vga mode or a
non-qxl gfx card is used. A display resize invalidates ds_mirror, and
it is handled by simply simply freeing ds_mirror. The next screen
update it will be re-al
From: David Gibson
This reverts commit a178274efabcbbc5d44805b51def874e47051325.
Contrary to that commit's message, the users of old_portio are not all
gone. In particular VGA still uses it via portio_list_add().
Signed-off-by: David Gibson
Signed-off-by: Alexander Graf
---
hw/spapr_pci.c |
On Wed, Oct 31, 2012 at 02:15:39PM -0400, Gabriel L. Somlo wrote:
> Some guest operating systems' drivers (Mac OS X in particular) fail to
> properly initialize the Receive Address registers (probably expecting
> them to be pre-initialized by an earlier component, such as a specific
> proprietary B
From: David Gibson
Throughout xics.c 'nr' is used to refer to a global interrupt number, and
'server' is used to refer to an interrupt server number (i.e. CPU number).
Except in icp_set_mfrr(), where 'nr' is used as a server number. Fix this
confusing inconsistency.
Signed-off-by: David Gibson
On 11/01/12 12:48, Alon Levy wrote:
> +if (!qemu_spice_display_is_running(&d->ssd)) {
> +fprintf(stderr, "%s: guest stopped, ignoring\n", __func__);
> +trace_qxl_send_events_vm_stopped(d->id, events);
> +return;
> +}
Almost perfect. We should add a note here that t
From: David Gibson
We change the storage of the VPA information to explicitly use fixed
size integer types which will make life easier for syncing this data with
KVM, which we will need in future.
Signed-off-by: David Gibson
[agraf: fix commit message]
Signed-off-by: Alexander Graf
---
target
> On 11/01/12 12:48, Alon Levy wrote:
> > +if (!qemu_spice_display_is_running(&d->ssd)) {
> > +fprintf(stderr, "%s: guest stopped, ignoring\n",
> > __func__);
> > +trace_qxl_send_events_vm_stopped(d->id, events);
> > +return;
> > +}
>
> Almost perfect. We should ad
On 11/01/12 13:44, Alon Levy wrote:
>> On 11/01/12 12:48, Alon Levy wrote:
>>> +if (!qemu_spice_display_is_running(&d->ssd)) {
>>> +fprintf(stderr, "%s: guest stopped, ignoring\n",
>>> __func__);
>>> +trace_qxl_send_events_vm_stopped(d->id, events);
>>> +return;
>>> +
On Wed, 31 Oct 2012 17:43:48 +0100
Andreas Färber wrote:
> Am 31.10.2012 17:32, schrieb Igor Mammedov:
> > On Wed, 24 Oct 2012 15:49:54 -0200
> > Eduardo Habkost wrote:
> >
> >> The PC code will need to run additional steps when initializing the CPU
> >> object, before x86_cpu_realize(). So, ma
Added a trace point for easy logging.
RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=870972
Signed-off-by: Alon Levy
---
hw/qxl.c | 8 +++-
trace-events | 1 +
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 7b88a1e..c33dd03 100644
--- a/hw/qxl
Signed-off-by: Michael Roth
---
hw/mc146818rtc.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index 98839f2..8983d26 100644
--- a/hw/mc146818rtc.c
+++ b/hw/mc146818rtc.c
@@ -25,6 +25,7 @@
#include "qemu-timer.h"
#inc
Signed-off-by: Gerd Hoffmann
---
console.c |9 -
console.h | 23 +--
2 files changed, 13 insertions(+), 19 deletions(-)
diff --git a/console.c b/console.c
index d28b75e..048b48e 100644
--- a/console.c
+++ b/console.c
@@ -1297,14 +1297,10 @@ static QemuConsole *n
Stop abusing displaysurface fields for text mode displays.
(bpp = 0, width = cols, height = lines).
Add flags to displaystate indicating whenever text mode display
(curses) or gfx mode displays (sdl, vnc, ...) are present.
Add separate displaychangelistener callbacks for text / gfx mode
resize &
Signed-off-by: Gerd Hoffmann
---
console.c | 48
console.h |2 --
2 files changed, 24 insertions(+), 26 deletions(-)
diff --git a/console.c b/console.c
index 5e1c5f5..48d88e4 100644
--- a/console.c
+++ b/console.c
@@ -1294,30 +1294,8 @@ stat
We'll use this for serializing rtc and elsewhere
Signed-off-by: Michael Roth
---
Makefile |3 ++-
qemu-timer.c | 29 +
qemu-timer.h |4
3 files changed, 35 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index b575361..f2d2e70 100644
Signed-off-by: Michael Roth
---
hw/vga_int.h | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/hw/vga_int.h b/hw/vga_int.h
index 22f1706..074e5d5 100644
--- a/hw/vga_int.h
+++ b/hw/vga_int.h
@@ -25,6 +25,7 @@
#include
#include "error.h"
#includ
> On 11/01/12 13:56, Alon Levy wrote:
> > Added a trace point for easy logging.
>
> Patch added to spice patch queue.
>
> thanks,
> Gerd
>
> PS: There are two pending patches from you
> (see http://www.kraxel.org/cgit/qemu/log/?h=rebase/spice-next),
> is that correct or did I miss some
Hi,
On 11/01/2012 11:08 AM, Gerd Hoffmann wrote:
On 10/31/12 13:47, Hans de Goede wrote:
+/*
+ * If we had leftover packets the hcd driver will have cancelled them
+ * and usb_combined_packet_cancel has already freed combined!
+ */
+if (state != leftover) {
+g_free(c
Hi,
On 11/01/2012 11:10 AM, Gerd Hoffmann wrote:
On 10/31/12 13:47, Hans de Goede wrote:
+if (p->combined) {
+iov_to_buf(p->combined->iov.iov, p->combined->iov.niov,
+ 0, buf, size);
+} else {
+usb_packet_copy(p, buf, size);
+
Signed-off-by: Michael Roth
---
hw/cirrus_vga.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index 220525a..4f00758 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -2903,6 +2903,23 @@ static void cirrus_init_common(CirrusVGA
Hi,
[ sorry for the delay, was busy with other stuff ]
> I'm not sure about that. According to the spec, when the hc is set to
> running mode (p.70)
>
> "At this point, the host controller is up and running and the Root Hub
> ports (5.4.8) will begin reporting device
> connects"
I understand
Signed-off-by: Michael Roth
---
hw/hpet.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/hw/hpet.c b/hw/hpet.c
index 3beb61e..e1b8881 100644
--- a/hw/hpet.c
+++ b/hw/hpet.c
@@ -34,6 +34,8 @@
#include "i8254.h"
#include "qidl.h"
+QIDL_ENABLE()
+
//#define HP
On 10/19/12 13:52, Alon Levy wrote:
> Signed-off-by: Alon Levy
> ---
> Spice package is not yet available, I assumed it will be the next version,
> 0.12.1, for the added API spice_server_set_ws_ports. Patches are on
> spice-devel and git is at http://cgit.freedesktop.org/~alon/spice master
> br
Hi,
On 11/01/2012 02:14 PM, Hans de Goede wrote:
Hi,
On 11/01/2012 11:08 AM, Gerd Hoffmann wrote:
On 10/31/12 13:47, Hans de Goede wrote:
+/*
+ * If we had leftover packets the hcd driver will have cancelled them
+ * and usb_combined_packet_cancel has already freed combined!
+
> On 10/19/12 13:52, Alon Levy wrote:
> > Signed-off-by: Alon Levy
> > ---
> > Spice package is not yet available, I assumed it will be the next
> > version, 0.12.1, for the added API spice_server_set_ws_ports.
> > Patches are on spice-devel and git is at
> > http://cgit.freedesktop.org/~alon/spic
Signed-off-by: Gerd Hoffmann
---
hw/vga.c | 39 +++
1 files changed, 11 insertions(+), 28 deletions(-)
diff --git a/hw/vga.c b/hw/vga.c
index 1188463..023134e 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -2393,13 +2393,12 @@ void vga_init_vbe(VGACommonState *s, M
On 10/19/12 12:35, Vasilis Liaskovitis wrote:
> Hi,
>
> On Thu, Mar 08, 2012 at 11:13:46AM +0100, Gerd Hoffmann wrote:
>> This patchs adds a frame buffer driver for (virtual/emulated) vga cards
>> implementing the bochs dispi interface. Supported hardware are the
>> bochs vga card with vbe extens
Unused code. 'nuff said.
Signed-off-by: Gerd Hoffmann
---
console.h | 13 -
ui/sdl.c |7 ---
2 files changed, 0 insertions(+), 20 deletions(-)
diff --git a/console.h b/console.h
index 7e0ac76..6492e67 100644
--- a/console.h
+++ b/console.h
@@ -161,8 +161,6 @@ struct Disp
Signed-off-by: Gerd Hoffmann
---
console.h | 72 +++
hw/xenfb.c |2 +-
vl.c |9 ++-
3 files changed, 42 insertions(+), 41 deletions(-)
diff --git a/console.h b/console.h
index 6099d8d..4239eb3 100644
--- a/console.h
+++
When adding DisplayChangeListeners the set_mouse and cursor_define
callbacks have been left in DisplayState for some reason. Fix it.
Signed-off-by: Gerd Hoffmann
---
console.c |2 +-
console.h | 39 +++
hw/jazz_led.c |2 +-
hw
Signed-off-by: Michael Roth
---
hw/ide/pci.c |9 +++--
hw/ide/pci.h |3 +++
hw/ide/piix.c | 39 +++
3 files changed, 49 insertions(+), 2 deletions(-)
diff --git a/hw/ide/pci.c b/hw/ide/pci.c
index bcdd70e..6629b3a 100644
--- a/hw/ide/pci.c
+++
On 10/31/2012 08:59 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2012-10-31 at 12:32 +0200, Avi Kivity wrote:
>> This has nothing to do with device endianness; we're translating from a
>> byte buffer (address_space_rw()) to a uint64_t
>> (MemoryRegionOps::read/write()) so we need to take host endian
On 11/01/2012 03:44 PM, Avi Kivity wrote:
>
> However we do have a problem with non-1/2/4/8 byte writes. Right now
> any mismatched access ends up as an 8 byte write, we need an extra
> accessor for arbitrary writes, or rather better use of the .impl members
> of MemoryRegionOps.
Sorry, it's con
Hi,
Sitting on these too long already. Series has been on the list a while
back, only splitted into two parts (separate "console cleanups" series
carrying patches 1-8). Patch 11 was updated according to Paolos
suggestion, otherwise the patches are unmodified.
please pull,
Gerd
The followin
Also change the way the gui_timer is initialized: each time a
displaychangelistener is registered or unregistered we'll check
whether we need a timer (due to dpy_refresh callback being present)
and if so setup a timer, otherwise zap it. This way the gui timer
works correctly with displaychangelist
The vnc code uses *three* DisplaySurfaces:
First is the surface of the actual QemuConsole, usually the guest
screen, but could also be a text console (monitor/serial reachable via
Ctrl-Alt- keys). This is left as-is.
Second is the current server's view of the screen content. The vnc code
uses t
Signed-off-by: Michael Roth
---
hw/piix_pci.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index 9af5847..a4c32aa 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -30,6 +30,7 @@
#include "sysbus.h"
#include "range.h"
#include "
On 11/01/12 13:56, Alon Levy wrote:
> Added a trace point for easy logging.
Patch added to spice patch queue.
thanks,
Gerd
PS: There are two pending patches from you
(see http://www.kraxel.org/cgit/qemu/log/?h=rebase/spice-next),
is that correct or did I miss something?
Hi,
On 11/01/2012 11:08 AM, Gerd Hoffmann wrote:
On 10/31/12 13:47, Hans de Goede wrote:
+/*
+ * If we had leftover packets the hcd driver will have cancelled them
+ * and usb_combined_packet_cancel has already freed combined!
+ */
+if (state != leftover) {
+g_free(c
Currently it is inconstent, PixelFormat->amask is left unset whereas
abits and amax and ashift are filled. As an alpha channel doesn't make
sense for the vga framebuffer leave all alpha fields clear.
Signed-off-by: Gerd Hoffmann
---
console.c |3 ---
1 files changed, 0 insertions(+), 3 dele
Signed-off-by: Michael Roth
---
hw/pci.c|1 +
hw/pci.h|3 ++-
hw/pci_bridge_dev.c | 29 +
3 files changed, 32 insertions(+), 1 deletion(-)
diff --git a/hw/pci.c b/hw/pci.c
index e0b3f4f..d27659c 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@
1 - 100 of 292 matches
Mail list logo
