Hi,
> This prevents a known abort on set_client_capabilities, that should be
> fixed in upstream, but it should also be checked against in qxl. Checks
> every other location that qxl_send_events is eventually possibly called
Why check in all callers instead of qxl_send_events directly?
Just print the warning about the spice server bug & possibly lost events
and go on. With luck the event arrives nevertheless. And if not we at
least sayed before it can happen ;)
> +static void spice_server_bug(PCIQXLDevice *qxl, const char *msg, ...)
> +{
> + va_list ap;
> + va_start(ap, msg);
> + fprintf(stderr, "qxl-%d: spice-server bug: ", qxl->id);
> + vfprintf(stderr, msg, ap);
> + fprintf(stderr, "\n");
> + va_end(ap);
> +}
> +
> +#define SPICE_SERVER_BUG_ONCE(qxl, msg, ...) { \
> + static int called; \
> + if (!called) { \
> + called = 1; \
> + spice_server_bug(qxl, msg, __VA_ARGS__); \
> + } \
> +}
That feels a bit like overkill too.
cheers,
Gerd
