On 10/24/12 18:13, Hans de Goede wrote:
> This is the final version of the input pipelining patchset, please
> add these patches to your tree for Anthony.
>
> Changes since the v2 rfc:
> - Move the settnig of the int_req flag for xhci, as you requested
> - Add "ehci: Retry to fill the queue while
On 10/24/12 18:31, Hans de Goede wrote:
> Here is a patchset with assorted uhci cleanups / fixes / improvments,
> please add these to your tree for Anthony.
>
> Regards,
>
> Hans
Patch added to usb patch queue.
thanks,
Gerd
On 2012년 10월 20일 16:05, Yeongkyoon Lee wrote:
Let me resend this patch, because it looks ignored except for the comment from
Richard Henderson for which I've replied.
Here is the 6th version of the series optimizing TCG qemu_ld/st code generation.
v6:
- Remove an extra argument of return a
Hello,
I'm looking to use qemu-img convert to write to iscsi block device (iscsi://..)
As iscsi doesn't have .bdrv_create, qemu-img convert hang on
/* Create the new image */
ret = bdrv_create(drv, out_filename, param);
if (ret < 0) {
if (ret == -ENOTSUP) {
err
Il 24/10/2012 19:30, Corey Bryant ha scritto:
>
>
> On 10/24/2012 11:45 AM, Paolo Bonzini wrote:
>> Il 24/10/2012 17:39, Corey Bryant ha scritto:
>>>
>>>
>>> On 10/24/2012 11:21 AM, Paolo Bonzini wrote:
Il 24/10/2012 16:18, Corey Bryant ha scritto:
>
>
> On 10/18/2012 11:15 AM, P
Il 25/10/2012 09:25, Alexandre DERUMIER ha scritto:
> What is the best way to get it working ?
>
> 1)add a .bdrv_create in block/iscsi.c ?
>
> (like host_device block driver, only open/close the device and check if size
> if big enough)
>
> if (fstat(fd, &stat_buf) < 0)
> ret = -er
Am 25.10.2012 09:25, schrieb Alexandre DERUMIER:
> Hello,
>
> I'm looking to use qemu-img convert to write to iscsi block device
> (iscsi://..)
>
> As iscsi doesn't have .bdrv_create, qemu-img convert hang on [...]
>
>
> What is the best way to get it working ?
>
>
> 1)add a .bdrv_create in
On Wed, Oct 24, 2012 at 02:58:45PM +0200, Paolo Bonzini wrote:
> +struct virtio_net_hdr
> +{
> +#define VIRTIO_NET_HDR_F_NEEDS_CSUM 1 // Use csum_start,
> csum_offset
> +#define VIRTIO_NET_HDR_F_DATA_VALID2 // Csum is valid
> +uint8_t flags;
> +#define VIRTIO_NET_HDR_GSO_NO
Il 25/10/2012 09:46, Kevin Wolf ha scritto:
>> > 1)add a .bdrv_create in block/iscsi.c ?
>> >
>> > (like host_device block driver, only open/close the device and check if
>> > size if big enough)
> Yes, this is the right way.
Could it be a default implementation of .bdrv_create (i.e. something
On Thu, Oct 25, 2012 at 1:16 AM, Vasilis Liaskovitis
wrote:
> Hi,
>
> On Wed, Oct 24, 2012 at 12:15:17PM +0200, Stefan Hajnoczi wrote:
>> On Wed, Oct 24, 2012 at 10:06 AM, liu ping fan wrote:
>> > On Tue, Oct 23, 2012 at 8:25 PM, Stefan Hajnoczi
>> > wrote:
>> >> On Fri, Sep 21, 2012 at 01:17:2
Am 25.10.2012 09:52, schrieb Paolo Bonzini:
> Il 25/10/2012 09:46, Kevin Wolf ha scritto:
1)add a .bdrv_create in block/iscsi.c ?
(like host_device block driver, only open/close the device and check if
size if big enough)
>> Yes, this is the right way.
>
> Could it be a defau
Hello list,
i'm using 1.2 stable and wanted to use xbzrle but xbzrle is extremely slow.
While trying to transfer a simple VM with 4GB memory through a 10GBe nic
while running a MySQL (with NO LOAD) it takes up to 10 - 15 minutes.
Remaining is often jumping or just lowering pretty slow.
Is th
That's why in gen_bitops() does later:
case OPC_DINSM:
if (lsb > msb)
goto fail;
mask = ((msb - lsb + 1 + 32 < 64) ? ((1ULL << (msb - lsb + 1 + 32)) -
1) : ~0ULL) << lsb;
...
case OPC_DINSU:
if (lsb > msb)
goto fail;
mask = ((1ULL
Don't explode QEMUMachineInitArgs before passing it to lx_init.
Signed-off-by: Max Filippov
---
hw/xtensa_lx60.c | 25 ++---
1 files changed, 6 insertions(+), 19 deletions(-)
diff --git a/hw/xtensa_lx60.c b/hw/xtensa_lx60.c
index 5dd2e08..b4d3b8e 100644
--- a/hw/xtensa_lx6
Max Filippov (2):
hw/xtensa_lx60: don't prematurely explode QEMUMachineInitArgs
hw/xtensa_sim: get rid of intermediate xtensa_sim_init
hw/xtensa_lx60.c | 25 ++---
hw/xtensa_sim.c | 27 ---
2 files changed, 14 insertions(+), 38 deletions(-)
--
Remove xtensa_sim_init that only explodes machine init args, rename
sim_init to xtensa_sim_init.
Signed-off-by: Max Filippov
---
hw/xtensa_sim.c | 27 ---
1 files changed, 8 insertions(+), 19 deletions(-)
diff --git a/hw/xtensa_sim.c b/hw/xtensa_sim.c
index 2e846d8..0d
On 10/24/2012 08:36 AM, liu ping fan wrote:
> On Tue, Oct 23, 2012 at 5:37 PM, Avi Kivity wrote:
>> On 10/23/2012 11:32 AM, liu ping fan wrote:
>>> On Tue, Oct 23, 2012 at 5:07 PM, Jan Kiszka wrote:
On 2012-10-23 07:52, liu ping fan wrote:
> On Mon, Oct 22, 2012 at 6:40 PM, Avi Kivity w
On 10/24/2012 08:56 AM, liu ping fan wrote:
>>>
>> Oh, here is a bug, need unref. As to unbalanced refcount, it will be
>> adopted for virtio-blk listener (not implement in this patchset)
>>
> It is like cpu_physical_memory_map/unmap, the map will hold the
> unbalanced ref, and unmap release it.
On 23 October 2012 10:37, Avi Kivity wrote:
> On 10/23/2012 11:32 AM, liu ping fan wrote:
>> On Tue, Oct 23, 2012 at 5:07 PM, Jan Kiszka wrote:
>>> On 2012-10-23 07:52, liu ping fan wrote:
On Mon, Oct 22, 2012 at 6:40 PM, Avi Kivity wrote:
> On 10/22/2012 11:23 AM, Liu Ping Fan wrote:
>
On 10/24/2012 09:17 AM, Jan Kiszka wrote:
>>>
>>> This is ugly for many reasons. First of all, it is racy as the register
>>> content may change while dropping the device lock, no? Then you would
>>> raise or clear an IRQ spuriously.
>>>
>> Device state's intact is protected by busy flag, and will
On 10/25/2012 11:00 AM, Peter Maydell wrote:
> On 23 October 2012 10:37, Avi Kivity wrote:
>> On 10/23/2012 11:32 AM, liu ping fan wrote:
>>> On Tue, Oct 23, 2012 at 5:07 PM, Jan Kiszka wrote:
On 2012-10-23 07:52, liu ping fan wrote:
> On Mon, Oct 22, 2012 at 6:40 PM, Avi Kivity wrote:
This patch set make the readonly memory in qemu really readonly by using
readonly memory slots feature in kvm to make qemu-kvm safer. Memory
regions with readonly property would be plug into kvm as readonly memory
slots.
Below module can test this feature:
static int rom_tester_probe(struct pci_d
let it not depend on __KVM_HAVE_READONLY_MEM to make it friendly
to userspace
Signed-off-by: Xiao Guangrong
---
arch/x86/kvm/x86.c |2 ++
include/linux/kvm.h |2 --
virt/kvm/kvm_main.c |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x8
As readonly memory is support in kvm, this patch supports this feature
in qemu, mainly pluging the memory region with KVM_MEM_READONLY flag
to kvm
Signed-off-by: Xiao Guangrong
---
kvm-all.c | 24 +---
1 files changed, 17 insertions(+), 7 deletions(-)
diff --git a/kvm-all.
In isapc, no i440x device exists in guest that means seabios can not
make 0xc to 0x100 writable
It works fine in current code since the guest can happily write readonly
memory. In order to support readonly slot in Qemu, we do not make the bios
readonly anymore
Signed-off-by: Xiao Guangron
Since it is ROM which is really readonly in the system
Signed-off-by: Xiao Guangrong
---
hw/pci.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 2ca6ff6..2a287bb 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -1803,6 +1803,7 @@ static int pci_add_opti
On 2012-10-25 11:01, Avi Kivity wrote:
> On 10/24/2012 09:17 AM, Jan Kiszka wrote:
This is ugly for many reasons. First of all, it is racy as the register
content may change while dropping the device lock, no? Then you would
raise or clear an IRQ spuriously.
>>> Device stat
On 10/25/2012 10:12 AM, Stefan Priebe - Profihost AG wrote:
> Hello list,
>
> i'm using 1.2 stable and wanted to use xbzrle but xbzrle is extremely slow.
>
> While trying to transfer a simple VM with 4GB memory through a 10GBe nic
> while running a MySQL (with NO LOAD) it takes up to 10 - 15 min
On 25 October 2012 10:47, Peter Crosthwaite
wrote:
> +static int usb_ehci_sysbus_initfn(SysBusDevice *dev)
> +{
> +EHCIItfState *i = FROM_SYSBUS(EHCIItfState, dev);
> +EHCIState *s = &i->ehci;
> +
> +s->dma = g_new(DMAContext, 1);
> +dma_context_init(s->dma, &address_space_memory,
Just put RAM regions in the unimplemented spaces in the MMIO region. These
regions have undefined behaviour, but this at least stops QEMU from segfaulting
when the guest bangs on these registers (and sucessfully fakes reading and
writing the registers with no side effects).
Signed-off-by: Peter Cr
A few debug messages in EHCI must have missed out on updates during incremental
developments. Fixed.
Signed-off-by: Peter Crosthwaite
---
hw/usb/hcd-ehci.c | 21 ++---
1 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index
On 25 October 2012 09:47, Max Filippov wrote:
> @@ -272,37 +273,23 @@ static void lx_init(const LxBoardDesc *board,
> static void xtensa_lx60_init(QEMUMachineInitArgs *args)
> {
> ram_addr_t ram_size = args->ram_size;
> -const char *cpu_model = args->cpu_model;
> -const char *kernel
Indeed the (lsb > msb) case is wrong and should be removed. I'll post a
patch about that later this week.
** Changed in: qemu
Status: Invalid => Confirmed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad
Add QOM device definition for sysbus attached EHCI.
Signed-off-by: Peter Crosthwaite
---
hw/usb/hcd-ehci.c | 53 -
1 files changed, 52 insertions(+), 1 deletions(-)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 862564c..17482f7 1
Pull the DMAContext for the PCI DMA out at device init time and put it into
the device state. Use dma_memory_read/write() instead of pci specific versions.
Signed-off-by: Peter Crosthwaite
---
hw/usb/hcd-ehci.c | 13 -
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a
Guard against re-definition of EHCI_DEBUG. Allows for turning on of debug info
from configure (using --qemu-extra-cflags="-DEHCI_DEBUG=1") rather than source
code hacking.
Signed-off-by: Peter Crosthwaite
---
hw/usb/hcd-ehci.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --
Add the two usb controllers in Zynq.
Signed-off-by: Peter Crosthwaite
---
hw/xilinx_zynq.c | 16
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c
index c55dafb..ed6934f 100644
--- a/hw/xilinx_zynq.c
+++ b/hw/xilinx_zynq.c
@@
Seperate the PCI stuff from the EHCI components. Extracted the PCIDevice
out into a new wrapper struct to make EHCIState non-PCI-specific. Seperated
tho non PCI init component out into a seperate "common" init function.
Signed-off-by: Peter Crosthwaite
---
hw/usb/hcd-ehci.c | 132 +
The capabilities register and operational register offsets can vary from one
EHCI implementation to the next. Parameterise accordingly.
Signed-off-by: Peter Crosthwaite
---
hw/usb/hcd-ehci.c | 68 -
1 files changed, 36 insertions(+), 32 dele
Added Sysbus variant of EHCI and attached it to Xilinx Zynq. Apparently the
EHCI stuff is going to useful for Tegra too. (Andreas?)
See http://lists.gnu.org/archive/html/qemu-devel/2012-06/msg04100.html thread
for the inital RFC discussion on this development.
Regession tested using i386 Debian
On Oct 24, 2012 3:27 AM, "Peter Maydell" wrote:
>
> Define a new global dma_context_memory which is a DMAContext corresponding
> to the global address_space_memory AddressSpace. This can be used by
> sysbus peripherals like sysbus-ohci which need to do DMA.
>
> In particular, use it in the sysbus-
Am 25.10.2012 11:44, schrieb Orit Wasserman:
Is this known or is something wrong?
My guess this workload migrates fine without XBZRLE so it is not the speed or
downtime :).
it could be that the cache size is too small resulting with a lot of cache
misses which means
XBZRLE makes things worse a
Calling memory_region_destroy() in a transaction is illegal (and aborts),
as until the transaction is committed, the region remains live.
Fix by moving destruction until after the transaction commits. This requires
having an extra set of regions, so the new and old regions can coexist.
Signed-of
Sync the header files by using scripts/update-linux-headers.sh
Signed-off-by: Xiao Guangrong
---
linux-headers/asm-powerpc/kvm.h | 59 ++
linux-headers/asm-powerpc/kvm_para.h |7 ++--
linux-headers/asm-x86/kvm.h | 17 ++
linux-headers
On 25 October 2012 10:21, Xiao Guangrong
wrote:
> Sync the header files by using scripts/update-linux-headers.sh
I think it would be good if this kind of patch included in the commit
message the kernel tree/branch and commit hash that the sync was with.
thanks
-- PMM
On Thu, Oct 25, 2012 at 2:04 PM, Peter Maydell wrote:
> On 25 October 2012 09:47, Max Filippov wrote:
>> @@ -272,37 +273,23 @@ static void lx_init(const LxBoardDesc *board,
>> static void xtensa_lx60_init(QEMUMachineInitArgs *args)
>> {
>> ram_addr_t ram_size = args->ram_size;
>> -cons
Remove xtensa_sim_init that only explodes machine init args, rename
sim_init to xtensa_sim_init.
Signed-off-by: Max Filippov
---
hw/xtensa_sim.c | 27 ---
1 files changed, 8 insertions(+), 19 deletions(-)
diff --git a/hw/xtensa_sim.c b/hw/xtensa_sim.c
index 2e846d8..0d
Don't explode QEMUMachineInitArgs before passing it to lx_init.
Signed-off-by: Max Filippov
---
hw/xtensa_lx60.c | 30 +++---
1 files changed, 7 insertions(+), 23 deletions(-)
diff --git a/hw/xtensa_lx60.c b/hw/xtensa_lx60.c
index 5dd2e08..4c42edc 100644
--- a/hw/xtens
Changes v1 -> v2:
- remove ram_size in xtensa_lx60 as well
Max Filippov (2):
hw/xtensa_lx60: don't prematurely explode QEMUMachineInitArgs
hw/xtensa_sim: get rid of intermediate xtensa_sim_init
hw/xtensa_lx60.c | 30 +++---
hw/xtensa_sim.c | 27 --
On 10/25/2012 12:35 PM, Stefan Priebe - Profihost AG wrote:
> Am 25.10.2012 11:44, schrieb Orit Wasserman:
>>> Is this known or is something wrong?
>> My guess this workload migrates fine without XBZRLE so it is not the speed
>> or downtime :).
>> it could be that the cache size is too small resul
On 10/25/12 11:47, Peter Crosthwaite wrote:
> The capabilities register and operational register offsets can vary from one
> EHCI implementation to the next. Parameterise accordingly.
> static Property ehci_properties[] = {
> DEFINE_PROP_UINT32("maxframes", EHCIState, maxframes, 128),
> +
> +typedef struct EHCIItfState {
> +PCIDevice pcidev;
> +struct EHCIState ehci;
> +} EHCIItfState;
EHCIPCIState ?
> static const VMStateDescription vmstate_ehci = {
> .name= "ehci",
> -.version_id = 2,
> -.minimum_version_id = 1,
> +.version_id = 3,
> +.mi
> typedef struct EHCIItfState {
> -PCIDevice pcidev;
> +/* FIXME: Figure out a better way to share one Property[] array between
> two
> + * QOM types with different parents
> + */
> +union {
> +PCIDevice pcidev;
> +SysBusDevice busdev;
> +};
Ah, I see wher
> +static inline void zynq_init_usb(uint32_t base_addr, qemu_irq irq)
> +{
> +DeviceState *dev = qdev_create(NULL, "ehci-sysbus");
I'd suggest to have a "ehci-sysbus-zynq" device instead which sets
capsbase & opregbase in ->init() ...
> +qdev_prop_set_uint16(dev, "capabase", 0x100);
> +
On 2012-10-25 11:21, Xiao Guangrong wrote:
> let it not depend on __KVM_HAVE_READONLY_MEM to make it friendly
> to userspace
>
> Signed-off-by: Xiao Guangrong
> ---
> arch/x86/kvm/x86.c |2 ++
> include/linux/kvm.h |2 --
> virt/kvm/kvm_main.c |2 +-
> 3 files changed, 3 insertions(
On 25 October 2012 13:12, Gerd Hoffmann wrote:
>> +static inline void zynq_init_usb(uint32_t base_addr, qemu_irq irq)
>> +{
>> +DeviceState *dev = qdev_create(NULL, "ehci-sysbus");
>
> I'd suggest to have a "ehci-sysbus-zynq" device instead which sets
> capsbase & opregbase in ->init() ...
>
>
Am 25.10.2012 13:39, schrieb Orit Wasserman:
On 10/25/2012 12:35 PM, Stefan Priebe - Profihost AG wrote:
Am 25.10.2012 11:44, schrieb Orit Wasserman:
Is this known or is something wrong?
My guess this workload migrates fine without XBZRLE so it is not the speed or
downtime :).
it could be tha
On 10/25/12 11:47, Peter Crosthwaite wrote:
> Just put RAM regions in the unimplemented spaces in the MMIO region. These
> regions have undefined behaviour, but this at least stops QEMU from
> segfaulting
> when the guest bangs on these registers (and sucessfully fakes reading and
> writing the re
Signed-off-by: Alon Levy
---
hw/qxl.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/hw/qxl.c b/hw/qxl.c
index 1b47ed3..620b476 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -453,6 +453,16 @@ static int qxl_track_command(PCIQXLDevice *qxl, struct
QXLCommandExt *ext)
On Thu, Oct 25, 2012 at 10:10 PM, Gerd Hoffmann wrote:
>> typedef struct EHCIItfState {
>> -PCIDevice pcidev;
>> +/* FIXME: Figure out a better way to share one Property[] array between
>> two
>> + * QOM types with different parents
>> + */
>> +union {
>> +PCIDevice p
On Thu, Oct 25, 2012 at 10:08 PM, Gerd Hoffmann wrote:
>> +typedef struct EHCIItfState {
>> +PCIDevice pcidev;
>> +struct EHCIState ehci;
>> +} EHCIItfState;
>
> EHCIPCIState ?
>
>> static const VMStateDescription vmstate_ehci = {
>> .name= "ehci",
>> -.version_id = 2,
>
From: Hans de Goede
No devices ever return async for isoc endpoints and the core
already enforces this.
Signed-off-by: Hans de Goede
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-uhci.c | 29 +++--
1 files changed, 3 insertions(+), 26 deletions(-)
diff --git a/hw/usb/
From: Hans de Goede
All callers of uhci_async_cancel() call uhci_async_unlink() first, so
lets move the unlink call to uhci_async_cancel()
Signed-off-by: Hans de Goede
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-uhci.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git
From: Hans de Goede
This can be used by usb-device code which wishes to process an entire endpoint
queue at once, to do this the usb-device code returns USB_RET_ADD_TO_QUEUE
from its handle_data class method and defines a flush_ep_queue class method
to call when the hcd is done queuing up packets
From: Hans de Goede
hcds which queue up more then one packet at once (uhci, ehci and xhci),
must clear the queue after an error which has caused the queue to halt.
Currently this is handled as a special case inside the hcd code, this
patch instead adds an USB_RET_REMOVE_FROM_QUEUE packet result
From: Hans de Goede
We use the name td both to refer to a UHCI_TD read from guest memory as
well as to refer to the guest address where a td is stored, switch over
to always use td_addr in the second case for consistency.
Signed-off-by: Hans de Goede
Signed-off-by: Gerd Hoffmann
---
hw/usb/hc
From: Hans de Goede
According to the spec a guest can unlink a qh, and then as soon as frindex
has changed by 1 since the unlink, assume it is idle and re-use it. However
for various reasons, we cannot simply consider a qh as unlinked if we've not
seen it for 1 frame. This means that it is possib
From: Hans de Goede
Signed-off-by: Hans de Goede
Signed-off-by: Gerd Hoffmann
---
hw/usb.h |3 ++-
hw/usb/core.c |3 ++-
hw/usb/hcd-ehci.c |6 --
hw/usb/hcd-musb.c |2 +-
hw/usb/hcd-ohci.c |7 +--
hw/usb/hcd-uhci.c |3 ++-
hw/usb/hcd-xhci.c | 16 +
From: Hans de Goede
Signed-off-by: Hans de Goede
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-uhci.c | 21 +++--
1 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c
index 7589a5b..6d2db7f 100644
--- a/hw/usb/hcd-uhci.c
+++ b/h
From: Hans de Goede
If the guest is using multiple transfers to try and keep the usb bus busy /
used at maximum efficiency, currently we would see / do the following:
1) submit transfer 1 to the device
2) submit transfer 2 to the device
3) report transfer 1 completion to guest
4) report transfer
On Thu, Oct 25, 2012 at 10:16 PM, Peter Maydell
wrote:
> On 25 October 2012 13:12, Gerd Hoffmann wrote:
>>> +static inline void zynq_init_usb(uint32_t base_addr, qemu_irq irq)
>>> +{
>>> +DeviceState *dev = qdev_create(NULL, "ehci-sysbus");
>>
>> I'd suggest to have a "ehci-sysbus-zynq" devic
Use LOG_GUEST_ERROR and LOG_UNIMP in preference to hw_error().
Signed-off-by: Peter Maydell
---
hw/pl080.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/pl080.c b/hw/pl080.c
index 6abe528..26150af 100644
--- a/hw/pl080.c
+++ b/hw/pl080.c
@@ -281,7 +281,8 @@
Use LOG_GUEST_ERROR to report guest accesses to bad register
offsets, and LOG_UNIMP for access to the unimplemented
test registers.
Signed-off-by: Peter Maydell
---
hw/arm_timer.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/hw/arm_timer.c b/hw/arm_t
It will set opt->str in qemu_opt_set_bool, without opt->str, there
will be some potential bugs.
These are uses of opt->str, and what happens when it isn't set:
* qemu_opt_get(): returns NULL, which means "not set". Bug can bite
when value isn't the default value.
* qemu_opt_parse(): passes NU
Hi,
>> ... then you don't need to fiddle with the versions as the vmstate wire
>> format doesn't change then.
>>
>
> Does that work considering you have turned one layer of VMSD into two?
> Can it equivocate machines saved with the old all-in-one vmsd with
> this new one that is structured in t
qemu_opts_print has no user now, so I re-write it and use it in
qemu-img.c.
qemu_opts_print will be used while using "qemu-img create", it will
produce the same output as previous code.
Signed-off-by: Dong Xu Wang
---
qemu-option.c | 41 -
qemu-option.h
On Thu, Oct 25, 2012 at 10:19 PM, Gerd Hoffmann wrote:
> On 10/25/12 11:47, Peter Crosthwaite wrote:
>> Just put RAM regions in the unimplemented spaces in the MMIO region. These
>> regions have undefined behaviour, but this at least stops QEMU from
>> segfaulting
>> when the guest bangs on these
On 25 October 2012 13:57, Dong Xu Wang wrote:
> While id is NULL, qemu_opts_create can not fail, so ignore
> errors is fine.
>
> Signed-off-by: Dong Xu Wang
> ---
> qemu-option.c |5 +
> qemu-option.h |1 +
> 2 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-opti
From: Hans de Goede
Signed-off-by: Hans de Goede
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-xhci.c | 49 ++---
1 files changed, 30 insertions(+), 19 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 37b3dbb..47d5702 100644
---
On 25 October 2012 14:03, Peter Crosthwaite
wrote:
> On Thu, Oct 25, 2012 at 10:19 PM, Gerd Hoffmann wrote:
>> On 10/25/12 11:47, Peter Crosthwaite wrote:
>>> Just put RAM regions in the unimplemented spaces in the MMIO region. These
>>> regions have undefined behaviour, but this at least stops Q
On 10/25/12 14:56, Peter Crosthwaite wrote:
> On Thu, Oct 25, 2012 at 10:16 PM, Peter Maydell
> wrote:
>> On 25 October 2012 13:12, Gerd Hoffmann wrote:
+static inline void zynq_init_usb(uint32_t base_addr, qemu_irq irq)
+{
+DeviceState *dev = qdev_create(NULL, "ehci-sysbus");
On 10/25/2012 02:18 PM, Stefan Priebe - Profihost AG wrote:
> Am 25.10.2012 13:39, schrieb Orit Wasserman:
>> On 10/25/2012 12:35 PM, Stefan Priebe - Profihost AG wrote:
>>> Am 25.10.2012 11:44, schrieb Orit Wasserman:
> Is this known or is something wrong?
My guess this workload migrates
On 10/25/2012 11:55 AM, Peter Maydell wrote:
> On 25 October 2012 10:47, Peter Crosthwaite
> wrote:
>> +static int usb_ehci_sysbus_initfn(SysBusDevice *dev)
>> +{
>> +EHCIItfState *i = FROM_SYSBUS(EHCIItfState, dev);
>> +EHCIState *s = &i->ehci;
>> +
>> +s->dma = g_new(DMAContext, 1);
Use opts_accepts_any() and find_desc_by_name().
Signed-off-by: Luiz Capitulino
Signed-off-by: Dong Xu Wang
---
qemu-option.c | 14 +++---
1 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/qemu-option.c b/qemu-option.c
index 375daaa..74321bb 100644
--- a/qemu-option.c
+++
On Thu, Oct 25, 2012 at 10:57 PM, Gerd Hoffmann wrote:
> Hi,
>
>>> ... then you don't need to fiddle with the versions as the vmstate wire
>>> format doesn't change then.
>>>
>>
>> Does that work considering you have turned one layer of VMSD into two?
>> Can it equivocate machines saved with the
On Thu, 25 Oct 2012, Peter Maydell wrote:
> Use LOG_GUEST_ERROR and LOG_UNIMP in preference to hw_error().
It's weird that printing something + abort is replaced by just printing
a message and the commit message doesn't really reflect the fact.
[..snip..]
--
mailto:av1...@comtv.ru
On 10/25/2012 03:03 PM, Peter Crosthwaite wrote:
> On Thu, Oct 25, 2012 at 10:19 PM, Gerd Hoffmann wrote:
>> On 10/25/12 11:47, Peter Crosthwaite wrote:
>>> Just put RAM regions in the unimplemented spaces in the MMIO region. These
>>> regions have undefined behaviour, but this at least stops QEMU
On 10/25/2012 03:12 PM, Peter Maydell wrote:
> (2) what should the memory system do for accesses where there is
> no memory region? This is really system specific as it depends
> what the bus fabric does. For ARM the usual thing would be to
> generate a decode error response which will result i
On Wed, Oct 24, 2012 at 08:12:36PM +0200, Michael S. Tsirkin wrote:
> On Wed, Oct 24, 2012 at 03:50:00PM -0200, Eduardo Habkost wrote:
> > This:
> > - Renames the init function for pc-1.2 and lower to pc_init_pci_v1_2;
> > - Creates a pc_init_pci_v1_3 function for pc-1.3.
> >
> > Right now both
On 25 October 2012 14:19, malc wrote:
> On Thu, 25 Oct 2012, Peter Maydell wrote:
>
>> Use LOG_GUEST_ERROR and LOG_UNIMP in preference to hw_error().
>
> It's weird that printing something + abort is replaced by just printing
> a message and the commit message doesn't really reflect the fact.
I a
On Thu, Oct 25, 2012 at 11:14 PM, Gerd Hoffmann wrote:
> On 10/25/12 14:56, Peter Crosthwaite wrote:
>> On Thu, Oct 25, 2012 at 10:16 PM, Peter Maydell
>> wrote:
>>> On 25 October 2012 13:12, Gerd Hoffmann wrote:
> +static inline void zynq_init_usb(uint32_t base_addr, qemu_irq irq)
> +{
From: Hans de Goede
While doing various performance tests of reading from USB mass storage devices
I noticed the following::
1) When an async handled packet completes, we don't immediately report an
interrupt to the guest, instead we wait for the frame-timer to run and
report it from there
On 25 October 2012 14:21, Avi Kivity wrote:
> On 10/25/2012 03:12 PM, Peter Maydell wrote:
>> (2) what should the memory system do for accesses where there is
>> no memory region? This is really system specific as it depends
>> what the bus fabric does. For ARM the usual thing would be to
>> g
On 2012-10-24 09:29, liu ping fan wrote:
> On Tue, Oct 23, 2012 at 5:04 PM, Jan Kiszka wrote:
>> On 2012-10-22 11:23, Liu Ping Fan wrote:
>>> Use local lock to protect e1000. When calling the system function,
>>> dropping the fine lock before acquiring the big lock. This will
>>> introduce broken
It will introduce a new file format: add-cow.
The add-cow file format makes it possible to perform copy-on-write on top of
a raw disk image. When we know that no backing file clusters remain visible
(e.g. we have streamed the entire image and copied all data from the backing
file), then it is pos
Document for add-cow format, the usage and spec of add-cow are introduced.
Signed-off-by: Dong Xu Wang
---
docs/specs/add-cow.txt | 151
1 files changed, 151 insertions(+), 0 deletions(-)
create mode 100644 docs/specs/add-cow.txt
diff --git a/d
We will use path_has_protocol outside block.c, so just make it public.
Signed-off-by: Dong Xu Wang
Reviewed-by: Michael Roth
---
block.c |2 +-
block.h |1 +
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/block.c b/block.c
index f639655..03ba485 100644
--- a/block.c
+++
add-cow file format core code. It use block-cache.c as cache code.
It lacks of snapshot_blkdev support.
Signed-off-by: Dong Xu Wang
---
block/Makefile.objs |1 +
block/add-cow.c | 692 +++
block/add-cow.h | 83 ++
block/block-cac
This patch will use qemu-iotests to test add-cow file format.
Signed-off-by: Dong Xu Wang
---
tests/qemu-iotests/017 |2 +-
tests/qemu-iotests/020 |2 +-
tests/qemu-iotests/common|6 ++
tests/qemu-iotests/common.rc | 15 ++-
4 files changed, 22 inser
On 10/25/2012 03:28 PM, Peter Maydell wrote:
> On 25 October 2012 14:21, Avi Kivity wrote:
>> On 10/25/2012 03:12 PM, Peter Maydell wrote:
>>> (2) what should the memory system do for accesses where there is
>>> no memory region? This is really system specific as it depends
>>> what the bus fab
1 - 100 of 256 matches
Mail list logo
