Re: [Qemu-devel] [PATCH v1 7/7] nand: Reset addressing after READSTATUS.

2012-10-22 Thread Peter Crosthwaite
On Fri, Oct 19, 2012 at 10:18 PM, Edgar E. Iglesias wrote: > On Fri, Oct 19, 2012 at 12:59:49PM +0100, Peter Maydell wrote: >> On 19 October 2012 07:40, Peter Crosthwaite >> wrote: >> > From: Edgar E. Iglesias >> > >> > Signed-off-by: Edgar E. Iglesias >> > --- >> > >> > hw/nand.c |6 +

[Qemu-devel] [PATCH v2 0/6] QOMify pflash_cfi0x + PL353 for Xilinx Zynq

2012-10-22 Thread Peter Crosthwaite
This series adds the PL353 to Xilinx Zynq with both NAND and pflashes attached. Had to QOMify the pflash_cfi0x devices to get them working with PL35x in the least hackish way. Regression tested pflash_cfi_01 using petalogix-ml605 and pflash_cfi_02 tested using zynq. Further testing by clients of

[Qemu-devel] [PATCH v2 1/6] pflash_cfi0x: remove unused base field

2012-10-22 Thread Peter Crosthwaite
This field is completely unused. The base address should also be abstracted away from the device anyway. Removed. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- hw/pflash_cfi01.c |2 -- hw/pflash_cfi02.c |4 +--- 2 files changed, 1 insertions(+), 5 deletions(-) diff -

[Qemu-devel] [PATCH v2 3/6] pflash_cfi0x: QOMified

2012-10-22 Thread Peter Crosthwaite
QOMified the pflash_cfi0x so machine models can connect them up in custom ways. Kept the pflash_cfi0x_register functions as is. They can still be used to create a flash straight onto system memory. Signed-off-by: Peter Crosthwaite --- changed from v1: Removed union usages (PMM review) Changed ta

[Qemu-devel] [PATCH v2 5/6] xilinx_zynq: add pl353

2012-10-22 Thread Peter Crosthwaite
Add the pl353 memory controller with both NAND and parallel flashes attached. Signed-off-by: Peter Crosthwaite --- changed from v1: fixed property names (see patch 3) hw/xilinx_zynq.c | 50 ++ 1 files changed, 42 insertions(+), 8 deletions(-) d

[Qemu-devel] [PATCH v2 6/6] pflash_cfi01: Fix debug mode printfery

2012-10-22 Thread Peter Crosthwaite
This DPRINTF was throwing a warning due to a missing cast. Signed-off-by: Peter Crosthwaite --- hw/pflash_cfi01.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c index 6164a97..90c111d 100644 --- a/hw/pflash_cfi01.c +++ b/hw/pflas

[Qemu-devel] [PATCH v2 2/6] pflash_cfi01: remove unused total_len field

2012-10-22 Thread Peter Crosthwaite
This field is completely unused. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- hw/pflash_cfi01.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c index 4f3f5f0..ebc8a57 100644 --- a/hw/pflash_cfi01.c +++ b/hw/pfla

[Qemu-devel] [PATCH v2 4/6] hw: Model of Primecell pl35x mem controller

2012-10-22 Thread Peter Crosthwaite
Initial device model for the pl35x series of memory controllers. The SRAM interface is just implemented as a passthrough using memory regions. NAND interfaces are modelled. Signed-off-by: Peter Crosthwaite --- changed since v1: use sysbus_mmio_get_region() for SRAM mappings (PMM Review) fixed hea

Re: [Qemu-devel] [PATCH V13 4/6] rename qcow2-cache.c to block-cache.c

2012-10-22 Thread Stefan Hajnoczi
On Thu, Oct 18, 2012 at 05:51:33PM +0800, Dong Xu Wang wrote: > diff --git a/block/qcow2.h b/block/qcow2.h > index b4eb654..cb6fd7a 100644 > --- a/block/qcow2.h > +++ b/block/qcow2.h > @@ -27,6 +27,7 @@ > > #include "aes.h" > #include "qemu-coroutine.h" > +#include "block-cache.h" > Since bl

Re: [Qemu-devel] [PATCH V13 4/6] rename qcow2-cache.c to block-cache.c

2012-10-22 Thread Dong Xu Wang
On Mon, Oct 22, 2012 at 4:22 PM, Stefan Hajnoczi wrote: > On Thu, Oct 18, 2012 at 05:51:33PM +0800, Dong Xu Wang wrote: >> diff --git a/block/qcow2.h b/block/qcow2.h >> index b4eb654..cb6fd7a 100644 >> --- a/block/qcow2.h >> +++ b/block/qcow2.h >> @@ -27,6 +27,7 @@ >> >> #include "aes.h" >> #inc

Re: [Qemu-devel] [RFC PATCH v3 06/19] Implement "-dimm" command line option

2012-10-22 Thread Vasilis Liaskovitis
Hi, On Thu, Oct 18, 2012 at 02:33:02PM +0200, Avi Kivity wrote: > On 10/18/2012 11:27 AM, Vasilis Liaskovitis wrote: > > On Wed, Oct 17, 2012 at 12:03:51PM +0200, Avi Kivity wrote: > >> On 10/17/2012 11:19 AM, Vasilis Liaskovitis wrote: > >> >> > >> >> I don't think so, but probably there's a limi

Re: [Qemu-devel] [PATCH v3 12/16] qemu-iotests: add mirroring test case

2012-10-22 Thread Kevin Wolf
Am 20.10.2012 15:47, schrieb Paolo Bonzini: > Il 19/10/2012 18:19, Kevin Wolf ha scritto: >> Am 18.10.2012 16:49, schrieb Paolo Bonzini: >>> Signed-off-by: Paolo Bonzini >>> --- >>> v2->v3: new testcases test_cancel_after_ready and >>> test_medium_not_found, removed obsolete workar

Re: [Qemu-devel] [PATCH v3 00/26] q35 qemu support

2012-10-22 Thread Michael S. Tsirkin
On Mon, Oct 22, 2012 at 07:58:32AM +0200, Gerd Hoffmann wrote: > Hi, > > > Would it make sense to temporarily rename the machine type e.g. > > pc-q35-experimental to stress it's not fully supported? > > I don't think this is needed as piix will continue to be the default. Well q35 is not yet 1

Re: [Qemu-devel] [PATCH V13 5/6] add-cow file format core code.

2012-10-22 Thread Stefan Hajnoczi
On Thu, Oct 18, 2012 at 05:51:34PM +0800, Dong Xu Wang wrote: > +static void add_cow_header_cpu_to_le(const AddCowHeader *cpu, AddCowHeader > *le) > +{ > +le->magic = cpu_to_le64(cpu->magic); > +le->version = cpu_to_le32(cpu->version); > + > +l

Re: [Qemu-devel] [patch v4 08/16] QemuThread: make QemuThread as tls to store extra info

2012-10-22 Thread Jan Kiszka
On 2012-10-22 11:23, Liu Ping Fan wrote: > If mmio dispatch out of big lock, some function's calling context (ie, > holding big lock or not) are different. We need to trace these info in > runtime, and use tls to store them. > By this method, we can avoid to require big lock recursive. > > Signed-

Re: [Qemu-devel] [PULL v3 00/23] Integrate DMA into the memory API

2012-10-22 Thread Avi Kivity
On 10/15/2012 03:16 PM, Avi Kivity wrote: > On 10/11/2012 11:01 PM, Anthony Liguori wrote: >> This conflicts with a recent pull from Stefano in xen-all.c. The >> difference doesn't look that awful but since I don't have a xen test >> setup, I'm not confident in resolving it myself. >> >> Can you

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2012-10-22 Thread Justin Shafer
Interesting stuff. With 0.14 and 1.2 wineserver will run if you say wineserver -d2 -f -p for example. I believe it is forking when you run plain old wineserver because it really is getting an invalid argument. I am running Wine 1.1.14 and Qemu 0.14 and I can run many apps. I cannot run a NeoB

Re: [Qemu-devel] [patch v4 05/16] memory: introduce ref, unref interface for MemoryRegionOps

2012-10-22 Thread Avi Kivity
On 10/22/2012 11:23 AM, Liu Ping Fan wrote: > This pair of interface help to decide when dispatching, whether > we can pin mr without big lock or not. > > Signed-off-by: Liu Ping Fan > --- > memory.h |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/memory.h b/memo

Re: [Qemu-devel] [PATCHv5] Align PCI capabilities in pci_find_space

2012-10-22 Thread Michael S. Tsirkin
On Sat, Oct 20, 2012 at 04:01:12PM -0500, Matt Renzelmann wrote: > The current implementation of pci_find_space does not correctly align > PCI capabilities in the PCI configuration space. It also does not > support PCI-Express devices. This patch fixes these issues. > > Thanks to Alex Williamson

Re: [Qemu-devel] [PATCH v3 01/26] blockdev: Introduce a default machine blockdev interface field, QEMUMachine->mach_if

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:26PM -0400, Jason Baron wrote: > From: Jason Baron > > The current QEMUMachine definition has a 'use_scsi' field to indicate if a > machine type should use scsi by default. However, Q35 wants to use ahci by > default. Thus, introdue a new field in the QEMUMachine def

Re: [Qemu-devel] [PATCH v3 02/26] blockdev: Introduce IF_AHCI

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:27PM -0400, Jason Baron wrote: > From: Jason Baron > > Introduce IF_AHCI so that q35 can differentiate between ide and ahci disks. > This allows q35 to specify its default disk type. It also allows q35 to > differentiate between ahci and ide disks, such that -drive i

Re: [Qemu-devel] [PATCH v3 03/26] pci: pci capability must be in PCI space

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:28PM -0400, Jason Baron wrote: > From: Isaku Yamahata > > pci capability must be in PCI space. > It can't lay in PCIe extended config space. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Isaku Yamahata > Signed-off-by: Jason Baron Applied, thanks! > --- > hw

Re: [Qemu-devel] [PATCH v3 08/26] pci_ids: add intel 82801BA pci-to-pci bridge id

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:31PM -0400, Jason Baron wrote: > From: Isaku Yamahata > > Adds pci id constants which will be used by q35. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Isaku Yamahata > Signed-off-by: Jason Baron Applied, thanks > --- > hw/pci_ids.h |1 + > 1 files chan

Re: [Qemu-devel] [PATCH v3 04/26] pci: introduce pci_swizzle_map_irq_fn() for standardized interrupt pin swizzle

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:28PM -0400, Jason Baron wrote: > From: Isaku Yamahata > > Introduce pci_swizzle_map_irq_fn() for interrupt pin swizzle which is > standardized. PCI bridge swizzle is common logic, by introducing > this function duplicated swizzle logic will be avoided later. > > [jb

Re: [Qemu-devel] [PATCH v3 09/26] pci: Add class 0xc05 as 'SMBus'

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:31PM -0400, Jason Baron wrote: > From: Jan Kiszka > > [jba...@redhat.com: add PCI_CLASS_SERIAL_SMBUS definition] > Reviewed-by: Paolo Bonzini > Signed-off-by: Jan Kiszka > Signed-off-by: Jason Baron Applied, thanks. > --- > hw/pci.c |1 + > hw/pci_ids.h

Re: [Qemu-devel] [PATCH v3 10/26] pcie: pass pcie window size to pcie_host_mmcfg_update()

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:32PM -0400, Jason Baron wrote: > From: Jason Baron > > This allows q35 to pass/set the size of the pcie window in its update routine. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Jason Baron Applied, thanks. > --- > hw/pcie_host.c | 21

Re: [Qemu-devel] [PATCH v3 11/26] pcie: Convert PCIExpressHost to use the QOM.

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:33PM -0400, Jason Baron wrote: > From: Jason Baron > > Let's use PCIExpressHost with QOM. > > Reviewed-by: Paolo Bonzini > Acked-by: Andreas Färber > Signed-off-by: Jason Baron Applied, thanks. > --- > hw/pcie_host.c | 14 ++ > hw/pcie_host.h |

Re: [Qemu-devel] [PATCH v3 07/26] pc/piix_pci: factor out smram/pam logic

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:30PM -0400, Jason Baron wrote: > From: Isaku Yamahata > > Factor out smram/pam logic for later use. > Which will be used by q35 too. > > Reviewed-by: Paolo Bonzini > [jba...@redhat.com: changes for updated memory API] > Signed-off-by: Isaku Yamahata > Signed-off-b

Re: [Qemu-devel] [PATCH v3 12/26] ich9: Add acpi support and definitions

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:33PM -0400, Jason Baron wrote: > From: Jason Baron > > Lay the groundwork for subsequent ich9 support. > > Signed-off-by: Isaku Yamahata > Signed-off-by: Jason Baron Applied with one exception, see below. > --- > hw/acpi_ich9.c| 315 >

Re: [Qemu-devel] [PATCHv3] qemu: enable PV EOI for qemu 1.3

2012-10-22 Thread Andreas Färber
Am 18.10.2012 17:01, schrieb Michael S. Tsirkin: > Enable KVM PV EOI by default. You can still disable it with > -kvm_pv_eoi cpu flag. To avoid breaking cross-version migration, > enable only for qemu 1.3 (or in the future, newer) machine type. > > Signed-off-by: Michael S. Tsirkin Thanks for up

Re: [Qemu-devel] [PATCH v3 13/26] ich9: Add the lpc chip

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:34PM -0400, Jason Baron wrote: > From: Jason Baron > > Add support for the ich9 LPC chip. > > Signed-off-by: Isaku Yamahata > Signed-off-by: Jason Baron Applied, thanks. > --- > hw/i386/Makefile.objs |2 +- > hw/lpc_ich9.c | 523 >

Re: [Qemu-devel] [PATCH v3 14/26] ich9: Add smbus

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:35PM -0400, Jason Baron wrote: > From: Jason Baron > > Add support for the ich9 smbus chip. > > Signed-off-by: Isaku Yamahata > Signed-off-by: Jason Baron Applied, thanks. > --- > hw/i386/Makefile.objs |2 +- > hw/smbus_ich9.c | 159 > +++

[Qemu-devel] [PULL] Memory core fixes

2012-10-22 Thread Avi Kivity
Please pull a few memory core fixes from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/urgent Fixing ioeventfds on big endian systems, and potential use-after-free (not really exploitable with the current code, but still). --

Re: [Qemu-devel] [PATCH v3 12/26] ich9: Add acpi support and definitions

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:33PM -0400, Jason Baron wrote: > From: Jason Baron > > Lay the groundwork for subsequent ich9 support. > > Signed-off-by: Isaku Yamahata > Signed-off-by: Jason Baron > --- > hw/acpi_ich9.c| 315 > + > hw/a

Re: [Qemu-devel] [PATCH v3 13/26] ich9: Add the lpc chip

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:34PM -0400, Jason Baron wrote: > From: Jason Baron > > Add support for the ich9 LPC chip. > > Signed-off-by: Isaku Yamahata > Signed-off-by: Jason Baron > --- > hw/i386/Makefile.objs |2 +- > hw/lpc_ich9.c | 523 > +++

Re: [Qemu-devel] [patch v4 09/16] memory: introduce mmio request pending to anti nested DMA

2012-10-22 Thread Avi Kivity
On 10/22/2012 11:23 AM, Liu Ping Fan wrote: > Rejecting the nested mmio request which does not aim at RAM, so we > can avoid the potential deadlock caused by the random lock sequence > of two device's local lock. I can't say I like this but it's better than anything else we have. > } > > +int

Re: [Qemu-devel] [patch v4 10/16] memory: introduce lock ops for MemoryRegionOps

2012-10-22 Thread Avi Kivity
On 10/22/2012 11:23 AM, Liu Ping Fan wrote: > This can help memory core to use mr's fine lock to mmio dispatch. > > diff --git a/memory.c b/memory.c > index d528d1f..86d5623 100644 > --- a/memory.c > +++ b/memory.c > @@ -1505,13 +1505,27 @@ void set_system_io_map(MemoryRegion *mr) > > uint64_t

Re: [Qemu-devel] [patch v4 11/16] vcpu: push mmio dispatcher out of big lock

2012-10-22 Thread Avi Kivity
On 10/22/2012 11:23 AM, Liu Ping Fan wrote: > Signed-off-by: Liu Ping Fan > --- > kvm-all.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/kvm-all.c b/kvm-all.c > index b3fa597..3d7ae18 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -1562,12 +1562,15 @@ int kvm_

Re: [Qemu-devel] [patch v4 11/16] vcpu: push mmio dispatcher out of big lock

2012-10-22 Thread Jan Kiszka
On 2012-10-22 12:31, Avi Kivity wrote: > On 10/22/2012 11:23 AM, Liu Ping Fan wrote: >> Signed-off-by: Liu Ping Fan >> --- >> kvm-all.c |3 +++ >> 1 files changed, 3 insertions(+), 0 deletions(-) >> >> diff --git a/kvm-all.c b/kvm-all.c >> index b3fa597..3d7ae18 100644 >> --- a/kvm-all.c >> +

Re: [Qemu-devel] [PATCH v3 00/26] q35 qemu support

2012-10-22 Thread Gerd Hoffmann
On 10/22/12 12:08, Michael S. Tsirkin wrote: > On Mon, Oct 22, 2012 at 07:58:32AM +0200, Gerd Hoffmann wrote: >> Hi, >> >>> Would it make sense to temporarily rename the machine type e.g. >>> pc-q35-experimental to stress it's not fully supported? >> >> I don't think this is needed as piix will c

Re: [Qemu-devel] [patch v4 12/16] e1000: apply fine lock on e1000

2012-10-22 Thread Avi Kivity
On 10/22/2012 11:23 AM, Liu Ping Fan wrote: > Use local lock to protect e1000. When calling the system function, > dropping the fine lock before acquiring the big lock. This will > introduce broken device state, which need extra effort to fix. > > Signed-off-by: Liu Ping Fan > --- > hw/e1000.c |

Re: [Qemu-devel] [PATCH v2 1/1] atapi: make change media detection for guests easier

2012-10-22 Thread Pavel Hrdina
Ping, still not reviewed or applied On Thu, 2012-10-04 at 16:16 +0200, Pavel Hrdina wrote: > If you have a guest with a media in the cdrom and you change it, > the windows and the linux guests cannot properly recognize this > media change. > For this purpose we have to pretend for some time (2s),

Re: [Qemu-devel] [patch v4 13/16] e1000: add busy flag to anti broken device state

2012-10-22 Thread Avi Kivity
On 10/22/2012 11:23 AM, Liu Ping Fan wrote: > The broken device state is caused by releasing local lock before acquiring > big lock. To fix this issue, we have two choice: > 1.use busy flag to protect the state > The drawback is that we will introduce independent busy flag for each > inde

Re: [Qemu-devel] [PATCH 1/6] qdev: rework device properties.

2012-10-22 Thread Amit Shah
On (Wed) 17 Oct 2012 [17:14:14], Eduardo Habkost wrote: > On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote: > [...] > > diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c > > new file mode 100644 > > index 000..8b0d0ff > > --- /dev/null > > +++ b/hw/qdev-properties.c > > @@ -

Re: [Qemu-devel] [RFC PATCH v3 06/19] Implement "-dimm" command line option

2012-10-22 Thread Avi Kivity
On 10/19/2012 07:48 PM, Blue Swirl wrote: >>> >>> DIMMs would be allowed to be hotplugged in the generic mem-controller >>> scheme only >>> (unless it makes sense to allow hotplug in the remaining pmc DRBs and >>> start using the generic scheme once we run out of emulated DRBs) >>> >> >> 440fx see

Re: [Qemu-devel] [Bug 1066055] Re: Network performance regression with vde_switch

2012-10-22 Thread Amit Shah
On (Tue) 16 Oct 2012 [09:48:09], Stefan Hajnoczi wrote: > On Mon, Oct 15, 2012 at 09:46:06PM -, Edivaldo de Araujo Pereira wrote: > > Hi Stefan, > > > > Thank you, very much for taking the time to help me, and excuse me for > > not seeing your answer early... > > > > I've run the procedure yo

Re: [Qemu-devel] 1.1.1 -> 1.1.2 migrate /managedsave issue

2012-10-22 Thread Avi Kivity
On 10/22/2012 09:04 AM, Philipp Hahn wrote: > Hello Doug, > > On Saturday 20 October 2012 00:46:43 Doug Goldstein wrote: >> I'm using libvirt 0.10.2 and I had qemu-kvm 1.1.1 running all my VMs. > ... >> I had upgraded to qemu-kvm 1.1.2 > ... >> qemu: warning: error while loading state for instanc

Re: [Qemu-devel] [PATCH v3 01/26] blockdev: Introduce a default machine blockdev interface field, QEMUMachine->mach_if

2012-10-22 Thread Kevin Wolf
Am 22.10.2012 12:47, schrieb Michael S. Tsirkin: > On Fri, Oct 19, 2012 at 04:43:26PM -0400, Jason Baron wrote: >> From: Jason Baron >> >> The current QEMUMachine definition has a 'use_scsi' field to indicate if a >> machine type should use scsi by default. However, Q35 wants to use ahci by >> def

Re: [Qemu-devel] [PATCH v3 02/26] blockdev: Introduce IF_AHCI

2012-10-22 Thread Kevin Wolf
Am 22.10.2012 12:48, schrieb Michael S. Tsirkin: > On Fri, Oct 19, 2012 at 04:43:27PM -0400, Jason Baron wrote: >> From: Jason Baron >> >> Introduce IF_AHCI so that q35 can differentiate between ide and ahci disks. >> This allows q35 to specify its default disk type. It also allows q35 to >> diffe

[Qemu-devel] [PATCH] update-linux-headers.sh: Handle new kernel uapi/ directories

2012-10-22 Thread Peter Maydell
Recent kernels have moved to keeping the userspace headers in uapi/ subdirectories. This breaks the detection of whether an architecture has KVM support in the kernel because kvm.h has moved in the kernel source tree. Update the check to support both the old and new locations. Signed-off-by: Peter

Re: [Qemu-devel] [PATCH v2 1/1] atapi: make change media detection for guests easier

2012-10-22 Thread Kevin Wolf
Am 04.10.2012 16:16, schrieb Pavel Hrdina: > If you have a guest with a media in the cdrom and you change it, > the windows and the linux guests cannot properly recognize this > media change. > For this purpose we have to pretend for some time (2s), that we > don't have any media inserted. This us

Re: [Qemu-devel] [PATCHv3] qemu: enable PV EOI for qemu 1.3

2012-10-22 Thread Michael S. Tsirkin
On Mon, Oct 22, 2012 at 12:06:42PM +0200, Andreas Färber wrote: > Am 18.10.2012 17:01, schrieb Michael S. Tsirkin: > > Enable KVM PV EOI by default. You can still disable it with > > -kvm_pv_eoi cpu flag. To avoid breaking cross-version migration, > > enable only for qemu 1.3 (or in the future, new

Re: [Qemu-devel] [PATCH v3 00/26] q35 qemu support

2012-10-22 Thread Michael S. Tsirkin
On Mon, Oct 22, 2012 at 12:37:39PM +0200, Gerd Hoffmann wrote: > On 10/22/12 12:08, Michael S. Tsirkin wrote: > > On Mon, Oct 22, 2012 at 07:58:32AM +0200, Gerd Hoffmann wrote: > >> Hi, > >> > >>> Would it make sense to temporarily rename the machine type e.g. > >>> pc-q35-experimental to stress

Re: [Qemu-devel] [PATCHv3] qemu: enable PV EOI for qemu 1.3

2012-10-22 Thread Eduardo Habkost
On Mon, Oct 22, 2012 at 03:12:00PM +0200, Michael S. Tsirkin wrote: > On Mon, Oct 22, 2012 at 12:06:42PM +0200, Andreas Färber wrote: > > Am 18.10.2012 17:01, schrieb Michael S. Tsirkin: > > > Enable KVM PV EOI by default. You can still disable it with > > > -kvm_pv_eoi cpu flag. To avoid breaking

Re: [Qemu-devel] [PATCHv3] qemu: enable PV EOI for qemu 1.3

2012-10-22 Thread Eduardo Habkost
On Thu, Oct 18, 2012 at 05:01:27PM +0200, Michael S. Tsirkin wrote: > Enable KVM PV EOI by default. You can still disable it with > -kvm_pv_eoi cpu flag. To avoid breaking cross-version migration, > enable only for qemu 1.3 (or in the future, newer) machine type. > > Signed-off-by: Michael S. Tsir

Re: [Qemu-devel] [PATCH v3 05/26] pc, pc_piix: split out pc nic initialization

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:29PM -0400, Jason Baron wrote: > From: Isaku Yamahata > > Factor out pc nic initialization. > This simplifies the pc initialization and will reduce the code > duplication of q35 pc initialization. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Isaku Yamahata > Si

Re: [Qemu-devel] [PATCH v3 06/26] pc: Move ioapic_init() from pc_piix.c to pc.c

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:29PM -0400, Jason Baron wrote: > From: Jason Baron > > Move ioapic_init from pc_piix.c to pc.c, to make it a common function. > Rename ioapic_init -> ioapic_init_gsi. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Jason Baron Anthony, could you pls review/ack th

Re: [Qemu-devel] buildbot failure in qemu on block_mingw32

2012-10-22 Thread Kevin Wolf
Am 20.10.2012 03:04, schrieb q...@buildbot.b1-systems.de: > The Buildbot has detected a new failure on builder block_mingw32 while > building qemu. > Full details are available at: > http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/359 > > Buildbot URL: http://buildbot.b1-systems

Re: [Qemu-devel] [PATCH v3 00/26] q35 qemu support

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:25PM -0400, Jason Baron wrote: > Hi, > > Qemu bits for q35 support, I'm posting the seabios changes separately. The > patches require '-M pc_q35' and -L 'seabios dir with q35 changes' on the > qemu command line. Hopefully, we can make it the default for x86 at some >

Re: [Qemu-devel] [PATCH 11/12] include core qdev code into *-user, too

2012-10-22 Thread Igor Mammedov
On Tue, 16 Oct 2012 16:08:42 -0300 Eduardo Habkost wrote: [...] > diff --git a/qom/qdev-properties.c b/qom/qdev-properties.c > new file mode 100644 > index 000..2e82cb9 > --- /dev/null > +++ b/qom/qdev-properties.c [...] > +void qdev_prop_set_globals(DeviceState *dev) > +{ > +ObjectClass *

Re: [Qemu-devel] [PULL v3 00/23] Integrate DMA into the memory API

2012-10-22 Thread Peter Maydell
On 22 October 2012 10:35, Avi Kivity wrote: > On 10/15/2012 03:16 PM, Avi Kivity wrote: >> Rebased tree in the same place: >> >> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/dma >> > > Anthony, or Blue, can you pull please? The neighbours are starting to > complain about the smell.

Re: [Qemu-devel] [PATCH 11/12] include core qdev code into *-user, too

2012-10-22 Thread Eduardo Habkost
On Mon, Oct 22, 2012 at 02:36:01PM +0200, Igor Mammedov wrote: > On Tue, 16 Oct 2012 16:08:42 -0300 > Eduardo Habkost wrote: > [...] > > diff --git a/qom/qdev-properties.c b/qom/qdev-properties.c > > new file mode 100644 > > index 000..2e82cb9 > > --- /dev/null > > +++ b/qom/qdev-properties.c

Re: [Qemu-devel] [PATCH v3 16/26] ich9: Add i82801b11 dmi-to-pci bridge

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:36PM -0400, Jason Baron wrote: > From: Jason Baron > > Add the dmi-to-pci i82801b11 bridge chip. This is the pci bridge chip > that q35 uses on its host bus for PCI bus arbitration. > > Signed-off-by: Isaku Yamahata > Signed-off-by: Jason Baron Applied, after rem

Re: [Qemu-devel] [PATCH v3 14/23] memory: manage coalesced mmio via a MemoryListener

2012-10-22 Thread Peter Maydell
On 9 October 2012 17:32, Avi Kivity wrote: > Instead of calling a global function on coalesced mmio changes, which > routes the call to kvm if enabled, add coalesced mmio hooks to > MemoryListener and make kvm use that instead. > -int kvm_coalesce_mmio_region(target_phys_addr_t start, ram_addr_t

Re: [Qemu-devel] [PATCH v3 14/23] memory: manage coalesced mmio via a MemoryListener

2012-10-22 Thread Avi Kivity
On 10/22/2012 02:57 PM, Peter Maydell wrote: > On 9 October 2012 17:32, Avi Kivity wrote: >> Instead of calling a global function on coalesced mmio changes, which >> routes the call to kvm if enabled, add coalesced mmio hooks to >> MemoryListener and make kvm use that instead. > >> -int kvm_coale

Re: [Qemu-devel] [PATCH v3 17/26] Add i21154 bridge chip.

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:37PM -0400, Jason Baron wrote: > From: Jason Baron > > This adds support for the DECchip 21154 PCI bridge. > > Signed-off-by: Isaku Yamahata > Signed-off-by: Jason Baron > --- > hw/Makefile.objs |2 +- > hw/i21154.c | 113 >

Re: [Qemu-devel] [PATCH v3 00/26] q35 qemu support

2012-10-22 Thread Eric Blake
On 10/22/2012 07:16 AM, Michael S. Tsirkin wrote: > I worry about need to maintain bug for bug compatibility on the > unlikely chance that the work to complete it gets delayed and we release > it in an unready state. > >> But in any case this needs >> discussion with the libvirt folks to make su

Re: [Qemu-devel] [PATCH v3 19/26] q35: Fix non-PCI IRQ processing in ich9_lpc_update_apic

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:38PM -0400, Jason Baron wrote: > From: Jan Kiszka > > Avoid passing a non-PCI IRQ to ich9_gsi_to_pirq. It's wrong and triggers > an assertion. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Jan Kiszka > Signed-off-by: Jason Baron Thanks, applied. > --- > hw/l

Re: [Qemu-devel] [PATCH v3 24/26] q35: add acpi-based pci hotplug.

2012-10-22 Thread Michael S. Tsirkin
On Fri, Oct 19, 2012 at 04:43:41PM -0400, Jason Baron wrote: > From: Jason Baron > > Add piix style acpi hotplug to q35. piix style is an understatement. This is exactly the same interface probably to enable the same bios code to run on both piix and q35. If true let's not duplicate code: pleas

Re: [Qemu-devel] [PATCH v3 00/26] q35 qemu support

2012-10-22 Thread Michael S. Tsirkin
On Mon, Oct 22, 2012 at 07:00:56AM -0600, Eric Blake wrote: > On 10/22/2012 07:16 AM, Michael S. Tsirkin wrote: > > > I worry about need to maintain bug for bug compatibility on the > > unlikely chance that the work to complete it gets delayed and we release > > it in an unready state. > > > >>

Re: [Qemu-devel] [PATCH v3 17/26] Add i21154 bridge chip.

2012-10-22 Thread Andreas Färber
Am 19.10.2012 22:43, schrieb Jason Baron: > From: Jason Baron > > This adds support for the DECchip 21154 PCI bridge. > > Signed-off-by: Isaku Yamahata > Signed-off-by: Jason Baron > --- > hw/Makefile.objs |2 +- > hw/i21154.c | 113 > +++

[Qemu-devel] qemu <-> libvirt interaction broken

2012-10-22 Thread Gerd Hoffmann
Hi, Commit 585f60368f23e6603cf86cfdaeceb89d1169f4b8 appearently breaks the libvirt feature detection, my guests fail to start with this message: error: Failed to start domain fedora-org-virtio error: internal error qemu does not support SGA Running libvirt-0.10.2-2.el6.x86_64 cheers, Gerd

[Qemu-devel] KVM call agenda for 2012-10-23

2012-10-22 Thread Juan Quintela
Hi Please send in any agenda topics you are interested in. Later, Juan.

Re: [Qemu-devel] [Bug 1066055] Re: Network performance regression with vde_switch

2012-10-22 Thread Edivaldo de Araujo Pereira
Dear Amit, On a suggestion of Stefan, I've already tested the modification in you patch, and it didn't work; but for confirmation I tested it once again, on the latest snapshot; same result, that is, it didn't work; the problem is still there. I didn't take enough time to uderstand the code, so

Re: [Qemu-devel] qemu <-> libvirt interaction broken

2012-10-22 Thread Peter Maydell
On 22 October 2012 14:28, Gerd Hoffmann wrote: > Commit 585f60368f23e6603cf86cfdaeceb89d1169f4b8 appearently breaks the > libvirt feature detection, my guests fail to start with this message: > > error: Failed to start domain fedora-org-virtio > error: internal error qemu does not support SGA > >

[Qemu-devel] [PATCH] main: Hide F_GETFD and FD_CLOEXEC use for _WIN32

2012-10-22 Thread Corey Bryant
Signed-off-by: Corey Bryant --- vl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/vl.c b/vl.c index 200d849..94c667d 100644 --- a/vl.c +++ b/vl.c @@ -812,11 +812,13 @@ static int parse_add_fd(QemuOpts *opts, void *opaque) return -1; } +#ifndef _WIN32 if (fcntl(fd, F

Re: [Qemu-devel] buildbot failure in qemu on block_mingw32

2012-10-22 Thread Corey Bryant
On 10/22/2012 08:30 AM, Kevin Wolf wrote: Am 20.10.2012 03:04, schrieb q...@buildbot.b1-systems.de: The Buildbot has detected a new failure on builder block_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/359 Build

Re: [Qemu-devel] [PATCH v3 00/26] q35 qemu support

2012-10-22 Thread Eric Blake
On 10/22/2012 08:23 AM, Michael S. Tsirkin wrote: > On Mon, Oct 22, 2012 at 07:00:56AM -0600, Eric Blake wrote: >> On 10/22/2012 07:16 AM, Michael S. Tsirkin wrote: >> >>> I worry about need to maintain bug for bug compatibility on the >>> unlikely chance that the work to complete it gets delayed

Re: [Qemu-devel] [PATCH 1/5] qemu-char: Add new char backend CircularMemCharDriver

2012-10-22 Thread Eric Blake
On 10/21/2012 10:47 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > qemu-char.c | 72 > +++ > 1 files changed, 72 insertions(+), 0 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c > index b082bae..b174da1 100644 > --- a/qemu-cha

[Qemu-devel] [PATCH] cadence_uart: enable tx/rx on reset

2012-10-22 Thread Josh Cartwright
Change the cadence_uart such that tx/rx is enabled on reset. Assuming both are enabled makes debugging early Linux kernel bootup a little bit easier. Signed-off-by: Josh Cartwright --- I've used this patch mostly for my own testing, but it may be of general use. On a real system, I would expec

Re: [Qemu-devel] [PATCH v2 3/6] pflash_cfi0x: QOMified

2012-10-22 Thread Peter Maydell
On 22 October 2012 08:19, Peter Crosthwaite wrote: > QOMified the pflash_cfi0x so machine models can connect them up in custom > ways. > > Kept the pflash_cfi0x_register functions as is. They can still be used to > create a flash straight onto system memory. > > Signed-off-by: Peter Crosthwaite

[Qemu-devel] [PATCH v5] qemu-config: Add new -add-fd command line option

2012-10-22 Thread Kevin Wolf
From: Corey Bryant This option can be used for passing file descriptors on the command line. It mirrors the existing add-fd QMP command which allows an fd to be passed to QEMU via SCM_RIGHTS and added to an fd set. This can be combined with commands such as -drive to link file descriptors in an

Re: [Qemu-devel] [PATCH v3 00/26] q35 qemu support

2012-10-22 Thread Alexander Graf
On 22.10.2012, at 16:03, Eric Blake wrote: > On 10/22/2012 08:23 AM, Michael S. Tsirkin wrote: >> On Mon, Oct 22, 2012 at 07:00:56AM -0600, Eric Blake wrote: >>> On 10/22/2012 07:16 AM, Michael S. Tsirkin wrote: >>> I worry about need to maintain bug for bug compatibility on the unlik

Re: [Qemu-devel] [PATCH] Call MADV_HUGEPAGE for guest RAM allocations

2012-10-22 Thread Luiz Capitulino
On Sun, 21 Oct 2012 05:46:25 +0200 Aurelien Jarno wrote: > On Mon, Oct 15, 2012 at 03:57:54PM -0300, Luiz Capitulino wrote: > > On Fri, 5 Oct 2012 16:47:57 -0300 > > Luiz Capitulino wrote: > > > > > This makes it possible for QEMU to use transparent huge pages (THP) > > > when transparent_hugep

[Qemu-devel] [PATCH 04/37] target-i386: filter out not TCG features if running without kvm at realize time

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 2d01705..53b58c0 100644 --- a/target-i386/cp

[Qemu-devel] [PATCH 00/37 v5] target-i386: convert CPU features into properties

2012-10-22 Thread Igor Mammedov
v5: - Use static properties instead of dynamic ones - Compile in KVM CPUID features only if CONFIG_KVM is defined - Add "f-kvm_steal_tm" and "f-kvmclock_stable" CPUID feature names - Some qdev hacking to: - allow iterate over Property[] before object instance exists - find a static

[Qemu-devel] [PATCH 06/37] add visitor for parsing hz[KMG] input string

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Acked-by: Andreas Färber --- v2: * replaced _hz suffix for frequency visitor by _freq suffix suggested-by: Andreas Färber * fixed typo & extra space spotted-by: Andreas Färber * initialize val, due to a silly CentOS6 compiler warning, that breakes build

[Qemu-devel] [PATCH 13/37] target-i386: convert "level" to static property

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index c9d8dbc..951d12b 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -220,6 +220,7 @@ static Property cpu_x

[Qemu-devel] [PATCH 08/37] target-i386: define static properties for cpuid features

2012-10-22 Thread Igor Mammedov
- static properties names of CPUID features are changed to have "f-" prefix, so that it would be easy to distinguish them from other properties. - use X86CPU as a type to count of offset correctly, because env field isn't starting at CPUstate begining, but located after it. Signed-off-by:

[Qemu-devel] [PATCH 25/37] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

2012-10-22 Thread Igor Mammedov
Vendor property setter takes string as vendor value but cpudefs use uint32_t vendor[123] fields to define vendor value. It makes it difficult to unify and use property setter for values from cpudefs. Simplify code by using vendor property setter, vendor[123] fields are converted into vendor[13] ar

[Qemu-devel] [PATCH 24/37] target-i386: use define for cpuid vendor string size

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 6 +++--- target-i386/cpu.h | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 061ee01..ec128c6 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1265,13 +1265,13 @@ stati

Re: [Qemu-devel] [PATCH v5] qemu-config: Add new -add-fd command line option

2012-10-22 Thread Corey Bryant
On 10/22/2012 10:36 AM, Kevin Wolf wrote: From: Corey Bryant This option can be used for passing file descriptors on the command line. It mirrors the existing add-fd QMP command which allows an fd to be passed to QEMU via SCM_RIGHTS and added to an fd set. This can be combined with commands

[Qemu-devel] [PATCH 09/37] qdev: export qdev_prop_find() and allow it to be used with DeviceClass instead of Object

2012-10-22 Thread Igor Mammedov
Operating on DeviceClass instead of DEVICE will allow to find static properties before DEVICE instance is created. It will be used later in compat_normalize_cpu_model() to convert legacy CPUID features into corresponding static properties. Signed-off-by: Igor Mammedov --- hw/qdev-properties.h

[Qemu-devel] [PATCH 27/37] target-i386: convert "tsc-frequency" to static property

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- * in addition use error_setg() instead of error_set() --- target-i386/cpu.c | 75 ++- 1 file changed, 41 insertions(+), 34 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index a1790aa..8d3f4cc

Re: [Qemu-devel] [PATCH v2] hmp: fix info cpus for sparc targets

2012-10-22 Thread Luiz Capitulino
On Fri, 19 Oct 2012 23:19:19 +0200 Aurelien Jarno wrote: > On sparc targets, info cpus returns this kind of output: > > | info cpus > | * CPU #0: pc=0x00424d18pc=0x00424d18npc=0x00424d1c > thread_id=19460 > > pc is printed twice, there is no space between pc, pc and npc

[Qemu-devel] [PATCH 23/37] target-i386: convert 'check' and 'enforce' to static properties

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: * restore original behavior, check features against host before they might be filtered out by TCG masks. spotted-by: Eduardo Habkost v3: * use static properties instead of feature name arrays * since "check" is becoming regular boolean property it wou

[Qemu-devel] [patch v4 03/16] hotplug: introduce qdev_unplug_complete() to remove device from views

2012-10-22 Thread Liu Ping Fan
When device unplug has been ack by guest, we first remove it from memory to prevent incoming access from dispatcher. Then we isolate it from device composition tree Signed-off-by: Liu Ping Fan --- hw/qdev.c | 26 ++ hw/qdev.h |3 ++- 2 files changed, 28 insertions(+

[Qemu-devel] [patch v4 08/16] QemuThread: make QemuThread as tls to store extra info

2012-10-22 Thread Liu Ping Fan
If mmio dispatch out of big lock, some function's calling context (ie, holding big lock or not) are different. We need to trace these info in runtime, and use tls to store them. By this method, we can avoid to require big lock recursive. Signed-off-by: Liu Ping Fan --- cpus.c |1

[Qemu-devel] [patch v4 09/16] memory: introduce mmio request pending to anti nested DMA

2012-10-22 Thread Liu Ping Fan
Rejecting the nested mmio request which does not aim at RAM, so we can avoid the potential deadlock caused by the random lock sequence of two device's local lock. Signed-off-by: Liu Ping Fan --- cpus.c | 14 ++ exec.c | 50 +++

[Qemu-devel] [patch v4 10/16] memory: introduce lock ops for MemoryRegionOps

2012-10-22 Thread Liu Ping Fan
This can help memory core to use mr's fine lock to mmio dispatch. Signed-off-by: Liu Ping Fan --- memory.c | 16 +++- memory.h |2 ++ 2 files changed, 17 insertions(+), 1 deletions(-) diff --git a/memory.c b/memory.c index d528d1f..86d5623 100644 --- a/memory.c +++ b/memory.c

  1   2   3   >