Re: [Qemu-devel] [PATCH 2/2] Adding BAR0 for e500 PCI controller

2012-10-05 Thread Bhushan Bharat-R65777
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Thursday, October 04, 2012 9:37 PM > To: Bhushan Bharat-R65777 > Cc: Avi Kivity; qemu-devel@nongnu.org; qemu-...@nongnu.org > Subject: Re: [Qemu-devel] [PATCH 2/2] Adding BAR0 for e500 PCI controller > > > On 04.

Re: [Qemu-devel] [PATCH] qxl: Default to PCI revision 4 when spice-server is new enough

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:31, Søren Sandmann ha scritto: >> > >> > No, that's not possible. The revision must be the same for all machines >> > started with the same "-M" argument. So your only choice is to make >> > 0.12 a requirement for QEMU 1.3. Then you can use compatibility >> > properties (see the

Re: [Qemu-devel] [PATCH] Require spice-server 0.12.0 and spice-protocol 0.12.2

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:37, Søren Sandmann ha scritto: > From: Søren Sandmann Pedersen > > Set the default PCI revision to QXL_REVISION_STABLE_V12, and remove > the various #ifs on various subversions of spice-server 0.11.x. > > Also set the revision to 3 for the PC 1.2 machine for compatibility. > >

Re: [Qemu-devel] [Bug 1060928] [NEW] Error in launch virtual server port

2012-10-05 Thread Stefan Hajnoczi
On Wed, Oct 03, 2012 at 12:57:32PM -, javier navarro altimira wrote: > --- > > .- script bash launcher > > #!/bin/bash > > qemu-system-i386 -m 128 -display sdl -cpu pentium \ > -k es \ > -net nic,vlan=0,macaddr=52:54:00:12:02:04,model=pcnet \ > -net vde,vlan=0

Re: [Qemu-devel] [PATCH v3 09/22] qapi: QmpOutputVisitor, implement array handling

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:33, Michael Roth ha scritto: > } > > +static void qmp_output_start_carray(Visitor *v, void **obj, const char *name, > +size_t elem_count, size_t elem_size, > +Error **errp) > +{ > +qmp_output_start_list(

Re: [Qemu-devel] Qcow2 allocate and free cluster

2012-10-05 Thread Stefan Hajnoczi
On Fri, Sep 21, 2012 at 11:15:42AM +0530, Gaurab Basu wrote: > My question is how the clusters are allocated. What I have understood, it > maintains a free_cluster_index to manage which host clusters are free. > In the function update_refcount(), if a cluster is freed it makes the > free_cluster_in

Re: [Qemu-devel] [PATCH v3 07/22] qapi: qapi_visit.py, support for visiting non-pointer/embedded structs

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:33, Michael Roth ha scritto: > +elif argentry.has_key(''): Just perhaps? Paolo > +tmp_ptr_name = "%s_%s_ptr" % > (c_var(field_prefix).replace(".", ""), c_var(argname)) > +ret += mcgen(''' > +%(type)s *%(tmp_ptr)s = &(*obj

Re: [Qemu-devel] [PATCH v3 05/22] qapi: qapi_visit.py, support arrays and complex qapi definitions

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:33, Michael Roth ha scritto: > Add support for arrays in the code generators. > > Complex field descriptions can now be used to provide additional > information to the visitor generators, such as the max size of an array, > or the field within a struct to use to determine how many

Re: [Qemu-devel] [PATCH v2] virtio-blk: add default serial id

2012-10-05 Thread Stefan Hajnoczi
On Sun, Sep 23, 2012 at 10:37:09AM +0800, Dave Young wrote: > For the serial number decreasing issue, I think there's only these two ways to > select, there's no ideal way to resolve this issue. > My use case for this is for the kdump kernel to find proper disks, > after 1st kernel crashing 2nd ker

Re: [Qemu-devel] [PATCH] kvm: Set default accelerator to "kvm" if the host supports it

2012-10-05 Thread Peter Maydell
On 5 October 2012 03:24, Alexander Graf wrote: > On 05.10.2012, at 04:17, Anthony Liguori wrote: >> Alexander Graf writes: >>> We get similar problems on PPC. Take the following example: >>> >>> $ qemu-system-ppc -M mpc8544ds -kernel uImage -nographic >> >> But do you really expect people to do

Re: [Qemu-devel] [PATCH v3 21/22] qidl: qidl.h, definitions for qidl annotations

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:33, Michael Roth ha scritto: > +#define QIDL_SCHEMA_ADD_LINK(name, obj, path, errp) \ > +g_assert(qidl_data_##name.schema_obj); \ > +object_property_add_link(obj, path, "container", \ Why "container" as the type? Paolo > + &qidl_data_##name.sc

Re: [Qemu-devel] [PATCH v3 22/22] qidl: unit tests and build infrastructure

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:33, Michael Roth ha scritto: > + > +%.qidl.c: %.c $(SRC_PATH)/qidl.h $(addprefix $(SRC_PATH)/scripts/,lexer.py > qidl.py qidl_parser.py qapi.py qapi_visit.py) > + $(call rm -f $(*D)/qidl-generated/$(*F).qidl.c) > + $(if $(strip $(shell grep "QIDL_ENABLE()" $< 1>/dev/null &

Re: [Qemu-devel] [PATCH v3] Add infrastructure for QIDL-based device serialization

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:33, Michael Roth ha scritto: > These patches are based are origin/master, and can also be obtained from: > > git://github.com/mdroth/qemu.git qidl-base-v3 > > Changes since v2: > > - Documentations fix-ups and clarifications (Eric) > - Moved annotations in front of variable na

[Qemu-devel] [PATCH] fsdev: Don't ignore setfsuid/setfsgid return values

2012-10-05 Thread M. Mohan Kumar
From: "M. Mohan Kumar" In current implementation of setfsuid/setfsgid there is no way to know if it failed by checking the return value. This patch assumes setfsuid/setfsgid returns -1 in case of error. Eventually kernel code needs to be fixed. Signed-off-by: M. Mohan Kumar --- fsdev/virtfs-pr

Re: [Qemu-devel] List of Virtualized IO devices - QEMU

2012-10-05 Thread Stefan Hajnoczi
On Sun, Sep 30, 2012 at 08:52:02PM -0500, Krishna Kumaar Natarajan wrote: > Where can I find the list of IO devices virtualized for QEMU ? Your question is very general. In the source tree you'll find *emulated* devices in hw/. On the command-line you can do: $ qemu-system-x86_64 -device \?

Re: [Qemu-devel] [PATCH 04/14] qdev: allow multiple qdev_init_gpio_in() calls

2012-10-05 Thread Peter Maydell
On 5 October 2012 01:08, Peter Crosthwaite wrote: > From: Peter A. G. Crosthwaite > > Allow multiple qdev_init_gpio_in() calls for the one device. The first call > will > define GPIOs 0-N-1, the next GPIOs N- ... . Allows different GPIOs to be > handled > with different handlers. Needed when tw

Re: [Qemu-devel] [PATCH 04/18] qemu-sockets: add nonblocking connect for Unix sockets

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:38, Luiz Capitulino ha scritto: > On Wed, 3 Oct 2012 16:36:51 +0200 > Paolo Bonzini wrote: > > This looks like a bug fix, because if is_waitconnect==false > unix_connect_opts() > shouldn't block. Am I right? It could be a start, but it doesn't fix it yet. qemu-char always cal

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-10-05 Thread Benjamin Herrenschmidt
On Fri, 2012-10-05 at 02:43 +0200, Alexander Graf wrote: > > We should also be able to get the raw bootindex values for a qdev, > > yes? I was thinking we could instead copy those values into the > > device tree when we populate it. The trouble is that we don't > > actually generate (in qemu) nod

[Qemu-devel] [RFC] Starting a (secondary) CPU when it is halted or reset

2012-10-05 Thread Ronald Hecht
Hello all, I have a question regarding LEON SPARC SMP. In a LEON SPARC SMP system secondary CPUs (others that CPU#0) can be started by setting certain bits in the interrupt controller. At startup (reset) all CPUs are halted except CPU#0. In QEMU version 0.12 it was possible to simply set CPUS

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: KVM: Fix BAT put

2012-10-05 Thread Alexander Graf
On 05.10.2012, at 05:29, David Gibson wrote: > On Fri, Oct 05, 2012 at 04:36:46AM +0200, Alexander Graf wrote: >> In the sregs API, upper and lower 32bit segments of the BAT registers >> are swapped when doing a set. Since we need to support old kernels out >> there, don't bother to fix it in t

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-10-05 Thread Alexander Graf
On 05.10.2012, at 11:12, Benjamin Herrenschmidt wrote: > On Fri, 2012-10-05 at 02:43 +0200, Alexander Graf wrote: >>> We should also be able to get the raw bootindex values for a qdev, >>> yes? I was thinking we could instead copy those values into the >>> device tree when we populate it. The

Re: [Qemu-devel] [RFC] Starting a (secondary) CPU when it is halted or reset

2012-10-05 Thread Jan Kiszka
On 2012-10-05 11:28, Ronald Hecht wrote: > Hello all, > > I have a question regarding LEON SPARC SMP. In a LEON SPARC SMP system > secondary CPUs (others that CPU#0) can be started by setting certain > bits in the interrupt controller. At startup (reset) all CPUs are halted > except CPU#0. In QEMU

Re: [Qemu-devel] [PATCH V5 5/5] libqblock test example

2012-10-05 Thread wenchao xia
于 2012-10-3 20:21, Paolo Bonzini 写道: > Il 03/10/2012 13:31, wenchao xia ha scritto: +const uint64_t *qb_get_virt_size(const QBlockStaticInfo *info) +{ +return info->member_addr->virt_size; >>> >>> Please change this to: >>> >>> QBlockStaticInfoAddr addrs; >>> qb_setup_i

Re: [Qemu-devel] [PATCH V5 5/5] libqblock test example

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 13:20, wenchao xia ha scritto: > > >Hi, QBlockStaticInfoAddr was declared as a pointer, user can't see > > > what it really is. It is actually defined in internal header files. > > > > Yes, but even the type should be hidden. It should be purely an > > implementation detail, at

Re: [Qemu-devel] [PATCH] fsdev: Don't ignore setfsuid/setfsgid return values

2012-10-05 Thread Eric Blake
On 10/05/2012 02:36 AM, M. Mohan Kumar wrote: > From: "M. Mohan Kumar" > > In current implementation of setfsuid/setfsgid there is no way to know > if it failed by checking the return value. This patch assumes > setfsuid/setfsgid returns -1 in case of error. Eventually kernel code > needs to be f

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw: Disable code after return statement

2012-10-05 Thread Stefan Hajnoczi
On Sun, Sep 23, 2012 at 08:41:32AM +0200, Stefan Weil wrote: > Report from smatch: > microdrive.c:212 md_common_read(34) info: ignoring unreachable code. > microdrive.c:273 md_common_write(33) info: ignoring unreachable code. > sd.c:343 sd_req_crc_validate(9) info: ignoring unreachable code. > > S

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw: Fix return value check for bdrv_read, bdrv_write

2012-10-05 Thread Stefan Hajnoczi
On Sun, Sep 23, 2012 at 08:51:01AM +0200, Stefan Weil wrote: > Those functions return -errno in case of an error. > The old code would typically only detect EPERM (1) errors. > > Signed-off-by: Stefan Weil > --- > hw/nand.c| 34 ++ > hw/onenand.c |2 +- >

Re: [Qemu-devel] [PATCH 2/2] Adding BAR0 for e500 PCI controller

2012-10-05 Thread Alexander Graf
On 05.10.2012, at 09:11, Bhushan Bharat-R65777 wrote: > > >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Thursday, October 04, 2012 9:37 PM >> To: Bhushan Bharat-R65777 >> Cc: Avi Kivity; qemu-devel@nongnu.org; qemu-...@nongnu.org >> Subject: Re: [Qemu-dev

Re: [Qemu-devel] [PATCH] configure: Support empty target list (--target-list=)

2012-10-05 Thread Stefan Hajnoczi
On Wed, Sep 26, 2012 at 10:04:38PM +0200, Stefan Weil wrote: > Specifying an empty target list with --target-list= is shorter > than specifying --disable-user --disable-system. > > Both variants should give the same result: no targets at all. > > This modification implements that feature. > > It

Re: [Qemu-devel] [Qemu-trivial] [PATCH] cpu: Add missing 'static' attribute to qemu_global_mutex

2012-10-05 Thread Stefan Hajnoczi
On Thu, Sep 27, 2012 at 07:41:42AM +0200, Stefan Weil wrote: > Contrary to its name, 'qemu_global_mutex' is only used locally > in cpus.c. > > Signed-off-by: Stefan Weil > --- > cpus.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to the trivial patches tree: https:

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code

2012-10-05 Thread Stefan Hajnoczi
On Thu, Sep 27, 2012 at 02:55:43PM +0100, Peter Maydell wrote: > Use the recently introduced tcg_out_mov_reg() function rather than > the equivalent inline code. > > Signed-off-by: Peter Maydell > --- > This is a minor follow-on cleanup patch after commit 9716ef3b1. > > tcg/arm/tcg-target.c |

Re: [Qemu-devel] [PATCH 08/14] m25p80: Initial implementation of SPI flash device

2012-10-05 Thread Peter Maydell
On 5 October 2012 01:08, Peter Crosthwaite wrote: > From: Peter A. G. Crosthwaite > > Added device model for m25p80 style SPI flash family. > > Signed-off-by: Peter A. G. Crosthwaite > --- > default-configs/arm-softmmu.mak |1 + > default-configs/microblaze-softmmu.mak |2 + >

Re: [Qemu-devel] [PATCH] slirp: Fix spelling in comment (enought -> enough, insure -> ensure)

2012-10-05 Thread Stefan Hajnoczi
On Thu, Sep 27, 2012 at 08:57:38PM +0200, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > > As a non native speaker, I feel that 'ensure' is better here than 'insure'. > Could a native speaker please confirm that? > > Thanks, > > Stefan > > slirp/ip_icmp.h |4 ++-- > 1 file change

Re: [Qemu-devel] [PATCH] vnc: Fix spelling (hellmen -> hellman) in comment

2012-10-05 Thread Stefan Hajnoczi
On Fri, Sep 28, 2012 at 06:11:49PM +0200, Stefan Weil wrote: > The algorithm was named after Martin E. Hellman. > > Signed-off-by: Stefan Weil > --- > ui/vnc-tls.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha

Re: [Qemu-devel] [PATCH 05/14] hw/stellaris: Removed gpio_out init array.

2012-10-05 Thread Peter Maydell
On 5 October 2012 01:08, Peter Crosthwaite wrote: > From: Peter A. G. Crosthwaite > > stellaris_init() defines arrays of qemu_irq to decides what each of the GPIO > pins are connected to. This is ok for inputs (as an input can only have one > source) but is flawed for outputs as an output can con

Re: [Qemu-devel] [PATCH 06/14] stellaris: Removed SSI mux

2012-10-05 Thread Peter Maydell
On 5 October 2012 01:08, Peter Crosthwaite wrote: > From: Peter A. G. Crosthwaite > > Removed the explicit SSI mux and wired the CS line directly up to the SSI > devices. > > Signed-off-by: Peter A. G. Crosthwaite > --- > hw/ssd0323.c |1 + > hw/ssi-sd.c|1 + > hw/stellaris.c |

Re: [Qemu-devel] [PATCH 08/18] migration (outgoing): add error propagation for fd and exec protocols

2012-10-05 Thread Luiz Capitulino
On Fri, 05 Oct 2012 08:25:46 +0200 Paolo Bonzini wrote: > Il 04/10/2012 20:24, Luiz Capitulino ha scritto: > > That DPRINTF() usage is really bizarre, it seems its purpose is to report > > an error to the user, but that's a debugging call. > > > > I'd let it there and replace it later with prope

Re: [Qemu-devel] [PATCH 11/18] nbd: ask and print error information from qemu-sockets

2012-10-05 Thread Luiz Capitulino
On Fri, 05 Oct 2012 08:27:25 +0200 Paolo Bonzini wrote: > Il 04/10/2012 22:08, Luiz Capitulino ha scritto: > > On Wed, 3 Oct 2012 16:36:58 +0200 > > Paolo Bonzini wrote: > > > >> Before: > >> > >> $ qemu-system-x86_64 nbd:localhost:12345 > >> inet_connect_opts: > >> connect(ipv4,yakj.

Re: [Qemu-devel] [PATCH 09/14] xilinx_spi: Initial impl. of Xilinx SPI controller

2012-10-05 Thread Peter Maydell
On 5 October 2012 01:08, Peter Crosthwaite wrote: > From: Peter A. G. Crosthwaite > > Device model for xilinx XPS SPI controller (v2.0) > > Signed-off-by: Peter A. G. Crosthwaite > --- > hw/microblaze/Makefile.objs |1 + > hw/xilinx_spi.c | 390 > ++

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Jan Kiszka
[was a private thread due to typo in qemu list address] On 2012-10-05 14:40, Anthony Liguori wrote: > Paolo Bonzini writes: > >> Il 05/10/2012 00:06, Lucas Meneghel Rodrigues ha scritto: >>> +static void debugexit_ioport_write(void *opaque, uint32_t addr, uint32_t >>> val) >>> +{ >>> +exit(

Re: [Qemu-devel] [PATCH 08/18] migration (outgoing): add error propagation for fd and exec protocols

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 14:41, Luiz Capitulino ha scritto: >>> > > That DPRINTF() usage is really bizarre, it seems its purpose is to >>> > > report >>> > > an error to the user, but that's a debugging call. >>> > > >>> > > I'd let it there and replace it later with proper tracing code, but >>> > > that's

Re: [Qemu-devel] [PATCH 07/14] hw: Added generic FIFO API.

2012-10-05 Thread Peter Maydell
On 5 October 2012 01:08, Peter Crosthwaite wrote: > From: Peter A. G. Crosthwaite > > Added a FIFO API that can be used to create and operate byte FIFOs. > > Signed-off-by: Peter A. G. Crosthwaite > --- > hw/Makefile.objs |1 + > hw/fifo.c| 78 > ++

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 14:43, Jan Kiszka ha scritto: >>> >> This "| 1" might be the problem. Anthony, are you relying on it in >>> >> qemu-test and/or can you work out the changes if we use just >>> >> "exit(val)"? >> > >> > The reason for ' | 1' was to make sure that the guest couldn't trigger >> > an ex

Re: [Qemu-devel] [PATCH 09/14] xilinx_spi: Initial impl. of Xilinx SPI controller

2012-10-05 Thread Peter Crosthwaite
On Fri, Oct 5, 2012 at 10:42 PM, Peter Maydell wrote: > On 5 October 2012 01:08, Peter Crosthwaite > wrote: >> From: Peter A. G. Crosthwaite >> >> Device model for xilinx XPS SPI controller (v2.0) >> >> Signed-off-by: Peter A. G. Crosthwaite >> --- >> hw/microblaze/Makefile.objs |1 + >> h

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-sockets: Fix compiler warning (regression for MinGW)

2012-10-05 Thread Stefan Hajnoczi
On Fri, Sep 28, 2012 at 07:07:39PM +0200, Stefan Weil wrote: > setsockopt needs a type cast for MinGW. That type cast is missing in > a recent commit which results in a compiler warning. > > Like for other socket related functions which have the same problem, > we add a 'qemu_setsockopt' macro whi

Re: [Qemu-devel] [PATCH 09/14] xilinx_spi: Initial impl. of Xilinx SPI controller

2012-10-05 Thread Peter Maydell
On 5 October 2012 13:49, Peter Crosthwaite wrote: > On Fri, Oct 5, 2012 at 10:42 PM, Peter Maydell > wrote: >> You need also an entry for irqline. > > Shouldnt need it as irqline is just a cached copy of the IRQ state to > save on qemu_set_irq() spamming. It is not true device state. Init > will

Re: [Qemu-devel] [PULL 0/14] Ehnahced SSI bus support + M25P80 SPI flash + Xilinx SPI controller

2012-10-05 Thread Peter Maydell
On 5 October 2012 01:08, Peter Crosthwaite wrote: > The following changes since commit e744c06fca438dc08271e626034e632a270c91c8: > Peter Maydell (1): > fpu/softfloat.c: Return correctly signed values from uint64_to_float32 > > are available in the git repository at: > > git://developer

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Jan Kiszka
On 2012-10-05 14:46, Paolo Bonzini wrote: > Il 05/10/2012 14:43, Jan Kiszka ha scritto: >> This "| 1" might be the problem. Anthony, are you relying on it in >> qemu-test and/or can you work out the changes if we use just >> "exit(val)"? The reason for ' | 1' was to make sure

Re: [Qemu-devel] [PATCH] cleanup useless return sentence

2012-10-05 Thread Stefan Hajnoczi
On Sat, Sep 29, 2012 at 01:36:21PM +0800, Amos Kong wrote: > This patch cleans up return sentences in the end of void functions. > > Reported-by: Paolo Bonzini > Signed-off-by: Amos Kong > --- > block/qed-table.c|1 - > blockdev.c |1 - > hw/9pfs/virtio-9p.

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-05 Thread Alberto Garcia
On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote: > > Ping > > We are currently in Hard Freeze, new devices will not get accepted > before the release, and our review may focus on bug fixes. > > http://wiki.qemu.org/Planning/1.2 > > I remember having had a brief look through your

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw: Add missing 'static' attribute for QEMUMachine

2012-10-05 Thread Stefan Hajnoczi
On Wed, Oct 03, 2012 at 11:19:39AM +0200, Stefan Weil wrote: > It was missing for leon3 and mips_fulong2e. > > Signed-off-by: Stefan Weil > --- > hw/leon3.c |2 +- > hw/mips/mips_fulong2e.c |2 +- This file doesn't exist in my tree (based on qemu.git/master a14c74928ba1fdaad

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-barrier: Fix compiler version check for future gcc versions

2012-10-05 Thread Stefan Hajnoczi
On Wed, Oct 03, 2012 at 11:11:02PM +0200, Stefan Weil wrote: > The current check will give a wrong result for gcc-5.x with x < 4. > Using QEMU_GNUC_PREREQ is simpler and fixes that issue. > > Signed-off-by: Stefan Weil > --- > > With current gcc versions (gcc-4.x) there is no problem. > Neverthe

Re: [Qemu-devel] [Qemu-trivial] [RFC 01/13] qdev: kill bogus comment

2012-10-05 Thread Stefan Hajnoczi
On Thu, Oct 04, 2012 at 04:15:21PM -0300, Eduardo Habkost wrote: > When the DeviceInfo code was removed, the comment describing > qdev_subclass_init() was left in the code by mistake. Remove it. > > Cc: qemu-triv...@nongnu.org > Signed-off-by: Eduardo Habkost > --- > hw/qdev.c | 1 - > 1 file ch

Re: [Qemu-devel] [Qemu-trivial] [PATCH] versatilepb: Use symbolic indices for ARM PIC

2012-10-05 Thread Stefan Hajnoczi
On Thu, Oct 04, 2012 at 10:49:43PM +0200, Stefan Weil wrote: > It is more readable, and all other code does it like that, too. > > Signed-off-by: Stefan Weil > --- > hw/versatilepb.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Thanks, applied to the trivial patches tree: https:

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Anthony Liguori
Paolo Bonzini writes: > Il 05/10/2012 14:43, Jan Kiszka ha scritto: >> This "| 1" might be the problem. Anthony, are you relying on it in >> qemu-test and/or can you work out the changes if we use just >> "exit(val)"? >>> > >>> > The reason for ' | 1' was to make sure that the gu

[Qemu-devel] [PULL 00/12] Trivial patches for 24 September to 5 October 2012

2012-10-05 Thread Stefan Hajnoczi
The following changes since commit a14c74928ba1fdaada515717f4d3c3fa3275d6f7: Merge remote-tracking branch 'sstabellini/xen-2012-10-03' into staging (2012-10-04 19:56:26 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch chang

[Qemu-devel] [PATCH 03/12] cpu: Add missing 'static' attribute to qemu_global_mutex

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil Contrary to its name, 'qemu_global_mutex' is only used locally in cpus.c. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- cpus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpus.c b/cpus.c index 4b726ef..1d5d490 100644 --- a/cpus.c +++ b

[Qemu-devel] [PATCH 08/12] cleanup useless return sentence

2012-10-05 Thread Stefan Hajnoczi
From: Amos Kong This patch cleans up return sentences in the end of void functions. Reported-by: Paolo Bonzini Signed-off-by: Amos Kong Signed-off-by: Stefan Hajnoczi --- block/qed-table.c| 1 - blockdev.c | 1 - hw/9pfs/virtio-9p.c | 5 - hw/blizza

[Qemu-devel] [PATCH 04/12] tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code

2012-10-05 Thread Stefan Hajnoczi
From: Peter Maydell Use the recently introduced tcg_out_mov_reg() function rather than the equivalent inline code. Signed-off-by: Peter Maydell Reviewed-by: Aurelien Jarno Signed-off-by: Stefan Hajnoczi --- tcg/arm/tcg-target.c | 15 +++ 1 file changed, 3 insertions(+), 12 deleti

[Qemu-devel] [PATCH 12/12] versatilepb: Use symbolic indices for ARM PIC

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil It is more readable, and all other code does it like that, too. Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- hw/versatilepb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/versatilepb.c b/hw/versatilepb.

[Qemu-devel] [PATCH 10/12] qemu-barrier: Fix compiler version check for future gcc versions

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil The current check will give a wrong result for gcc-5.x with x < 4. Using QEMU_GNUC_PREREQ is simpler and fixes that issue. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- qemu-barrier.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-ba

[Qemu-devel] [PATCH 11/12] qdev: kill bogus comment

2012-10-05 Thread Stefan Hajnoczi
From: Eduardo Habkost When the DeviceInfo code was removed, the comment describing qdev_subclass_init() was left in the code by mistake. Remove it. Cc: qemu-triv...@nongnu.org Signed-off-by: Eduardo Habkost Signed-off-by: Stefan Hajnoczi --- hw/qdev.c | 1 - 1 file changed, 1 deletion(-) dif

[Qemu-devel] [PATCH 09/12] hw: Add missing 'static' attribute for QEMUMachine

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil It was missing for leon3 and mips_fulong2e. Signed-off-by: Stefan Weil Reviewed-by: Andreas Färber Signed-off-by: Stefan Hajnoczi --- hw/leon3.c | 2 +- hw/mips_fulong2e.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/leon3.c b/hw/leon3.c

[Qemu-devel] [PATCH 07/12] qemu-sockets: Fix compiler warning (regression for MinGW)

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil setsockopt needs a type cast for MinGW. That type cast is missing in a recent commit which results in a compiler warning. Like for other socket related functions which have the same problem, we add a 'qemu_setsockopt' macro which provides that type cast where needed and use the

[Qemu-devel] [PATCH 06/12] vnc: Fix spelling (hellmen -> hellman) in comment

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil The algorithm was named after Martin E. Hellman. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- ui/vnc-tls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c index 3aaa939..a7f7d07 100644 --- a/ui/vnc-tls.c +++ b/

Re: [Qemu-devel] Enablig DLPAR capacity on QEMU pSeries

2012-10-05 Thread Erlon Cruz
Hi all, Just retaking the discussion of some days ago. After some discussions here and considering the suggestions in this thread, we got 3 main ideas for the DLPAR on QEMU/KVM. 1 - introduce a new device/driver that will be used to communicate changes in the DT to the guest + make thinks clea

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Workaround to bypass default qemu boot devices passed to SLOF

2012-10-05 Thread Alexander Graf
On 05.10.2012, at 16:00, Avik Sil wrote: > On 10/05/2012 05:39 PM, Alexander Graf wrote: >> >> On 05.10.2012, at 13:41, Nikunj A Dadhania wrote: >> >>> On Fri, 5 Oct 2012 12:24:47 +0200, Alexander Graf wrote: On 05.10.2012, at 10:29, Avik Sil wrote: > Hi David, >>

Re: [Qemu-devel] [PATCH 06/14] stellaris: Removed SSI mux

2012-10-05 Thread Peter Crosthwaite
On Fri, Oct 5, 2012 at 10:34 PM, Peter Maydell wrote: > On 5 October 2012 01:08, Peter Crosthwaite > wrote: >> From: Peter A. G. Crosthwaite >> >> Removed the explicit SSI mux and wired the CS line directly up to the SSI >> devices. >> >> Signed-off-by: Peter A. G. Crosthwaite >> +d

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 15:58, Anthony Liguori ha scritto: > Paolo Bonzini writes: > >> Il 05/10/2012 14:43, Jan Kiszka ha scritto: >>> This "| 1" might be the problem. Anthony, are you relying on it in >>> qemu-test and/or can you work out the changes if we use just >>> "exit(val)"? > >>>

Re: [Qemu-devel] [PATCH 05/14] hw/stellaris: Removed gpio_out init array.

2012-10-05 Thread Peter Crosthwaite
On Fri, Oct 5, 2012 at 10:31 PM, Peter Maydell wrote: > On 5 October 2012 01:08, Peter Crosthwaite > wrote: >> From: Peter A. G. Crosthwaite >> >> stellaris_init() defines arrays of qemu_irq to decides what each of the GPIO >> pins are connected to. This is ok for inputs (as an input can only ha

Re: [Qemu-devel] [PATCH v2] target-mips: Use TCG registers for the FPU.

2012-10-05 Thread Richard Henderson
Ping. You gave it your Reviewed-by. r~ On 09/18/2012 11:04 PM, Richard Henderson wrote: > With normal FP, this doesn't have much affect on the generated code, > because most of the FP operations are not CONST/PURE, and so we spill > registers in about the same frequency as the explicit load/stor

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Anthony Liguori
Paolo Bonzini writes: > Il 05/10/2012 15:58, Anthony Liguori ha scritto: >> Paolo Bonzini writes: >> >>> Il 05/10/2012 14:43, Jan Kiszka ha scritto: This "| 1" might be the problem. Anthony, are you relying on it in qemu-test and/or can you work out the changes if we use just

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Workaround to bypass default qemu boot devices passed to SLOF

2012-10-05 Thread Anthony Liguori
Alexander Graf writes: > On 05.10.2012, at 16:00, Avik Sil wrote: > >> On 10/05/2012 05:39 PM, Alexander Graf wrote: >>> >>> On 05.10.2012, at 13:41, Nikunj A Dadhania wrote: >>> On Fri, 5 Oct 2012 12:24:47 +0200, Alexander Graf wrote: > > > On 05.10.2012, at 10:29, Avik Si

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 15:20, Alberto Garcia ha scritto: > On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote: > >>> Ping >> >> We are currently in Hard Freeze, new devices will not get accepted >> before the release, and our review may focus on bug fixes. >> >> http://wiki.qemu.org/Planning/1.

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 16:23, Anthony Liguori ha scritto: >> > Understood. The right solution is of course to fix hw/*.c. > I don't think it's an awful thing for test harnesses to just use a > reserved range of exit reasons. But that's not what exit((val << 1) | 1) does, since it allows you to do exit(1).

[Qemu-devel] [PATCH 7/8] target-arm: use deposit instead of hardcoded version

2012-10-05 Thread Peter Maydell
From: Aurelien Jarno Use the deposit op instead of and hardcoded bit field insertion. It allows the host to emit the corresponding instruction if available. Signed-off-by: Aurelien Jarno Signed-off-by: Peter Maydell --- target-arm/translate.c | 20 ++-- 1 file changed, 6 ins

[Qemu-devel] [PATCH 4/8] target-arm: convert add_cc and sub_cc helpers to TCG

2012-10-05 Thread Peter Maydell
From: Aurelien Jarno Now that the setcond TCG op is available, it's possible to replace add_cc and sub_cc helpers by TCG code. The code generated by TCG is actually very close to the one generated by GCC for the helper, and this avoid all the consequences of using an helper: globals saved back to

[Qemu-devel] [PATCH 01/12] hw: Fix return value check for bdrv_read, bdrv_write

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil Those functions return -errno in case of an error. The old code would typically only detect EPERM (1) errors. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- hw/nand.c| 34 ++ hw/onenand.c | 2 +- hw/sd.c | 16 +

[Qemu-devel] [PATCH 05/12] slirp: Fix spelling in comment (enought -> enough, insure -> ensure)

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- slirp/ip_icmp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/slirp/ip_icmp.h b/slirp/ip_icmp.h index 1a1af91..be4426b 100644 --- a/slirp/ip_icmp.h +++ b/slirp/ip_icmp.h @@ -92,8 +92,8 @@

[Qemu-devel] [PATCH 02/12] configure: Support empty target list (--target-list=)

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil Specifying an empty target list with --target-list= is shorter than specifying --disable-user --disable-system. Both variants should give the same result: no targets at all. This modification implements that feature. It uses a trick which works with POSIX compliant shells to

Re: [Qemu-devel] Enablig DLPAR capacity on QEMU pSeries

2012-10-05 Thread Anthony Liguori
Benjamin Herrenschmidt writes: > On Wed, 2012-09-12 at 17:53 +0200, Alexander Graf wrote: >> On 09/12/2012 04:54 PM, Erlon Cruz wrote: >> > Hi all, >> > >> > We are planning to implement DLPAR capacity on QEMU pSeries. As we >> >> What is DLPAR? Hotplug support? > > Yes. > >> > lack of experienc

Re: [Qemu-devel] [PATCH v3 21/22] qidl: qidl.h, definitions for qidl annotations

2012-10-05 Thread Michael Roth
On Fri, Oct 05, 2012 at 10:14:09AM +0200, Paolo Bonzini wrote: > Il 04/10/2012 19:33, Michael Roth ha scritto: > > +#define QIDL_SCHEMA_ADD_LINK(name, obj, path, errp) \ > > +g_assert(qidl_data_##name.schema_obj); \ > > +object_property_add_link(obj, path, "container", \ > > Why "container

Re: [Qemu-devel] [PATCH v3] Add infrastructure for QIDL-based device serialization

2012-10-05 Thread Michael Roth
On Fri, Oct 05, 2012 at 10:26:29AM +0200, Paolo Bonzini wrote: > Il 04/10/2012 19:33, Michael Roth ha scritto: > > These patches are based are origin/master, and can also be obtained from: > > > > git://github.com/mdroth/qemu.git qidl-base-v3 > > > > Changes since v2: > > > > - Documentations f

Re: [Qemu-devel] [PATCH] Require spice-server 0.12.0 and spice-protocol 0.12.2

2012-10-05 Thread Søren Sandmann
Paolo Bonzini writes: > Nice cleanup, thanks! > > As a followup, there is some confusion between values of the revision > property (1-4) and PCI device revisions (QXL_REVISION_STABLE_Vxy). They > are the same right now, but this means that you can do one of the following: > > 1) if they are alwa

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-05 Thread Anthony Liguori
Paolo Bonzini writes: > Il 05/10/2012 15:20, Alberto Garcia ha scritto: >> On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote: >> Ping >>> >>> We are currently in Hard Freeze, new devices will not get accepted >>> before the release, and our review may focus on bug fixes. >>> >>

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-05 Thread Andreas Färber
Am 05.10.2012 15:20, schrieb Alberto Garcia: > On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote: > >>> Ping >> >> We are currently in Hard Freeze, new devices will not get accepted >> before the release, and our review may focus on bug fixes. >> >> http://wiki.qemu.org/Planning/1.2 >

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Workaround to bypass default qemu boot devices passed to SLOF

2012-10-05 Thread Alexander Graf
On 05.10.2012, at 16:25, Anthony Liguori wrote: > Alexander Graf writes: > >> On 05.10.2012, at 16:00, Avik Sil wrote: >> >>> On 10/05/2012 05:39 PM, Alexander Graf wrote: On 05.10.2012, at 13:41, Nikunj A Dadhania wrote: > On Fri, 5 Oct 2012 12:24:47 +0200, Alexander G

[Qemu-devel] [PATCH 1/8] cpu_dump_state: move DUMP_FPU and DUMP_CCOP flags from x86-only to generic

2012-10-05 Thread Peter Maydell
Move the DUMP_FPU and DUMP_CCOP flags for cpu_dump_state() from being x86-specific flags to being generic ones. This allows us to drop some TARGET_I386 ifdefs in various places, and means that we can (potentially) be more consistent across architectures about which monitor commands or debug abort p

[Qemu-devel] [PATCH 3/8] target-arm: use globals for CC flags

2012-10-05 Thread Peter Maydell
From: Aurelien Jarno Use globals for CC flags instead of loading/storing them each they are accessed. This allows some optimizations to be performed by the TCG optimization passes. Signed-off-by: Aurelien Jarno Signed-off-by: Peter Maydell --- target-arm/translate.c | 127 ++-

Re: [Qemu-devel] MIPS DSP for Qemu

2012-10-05 Thread Peter Maydell
On 3 October 2012 22:37, reed kotler wrote: > A year and half ago, I did a complete implementation for Mips DSP in Qemu. > My port has passed all the MIPS AVPs (Architectural Verification Programs) > for DSP, which is something not available to the public but is what all > architectural licenses

Re: [Qemu-devel] [PATCH v3 21/22] qidl: qidl.h, definitions for qidl annotations

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:33, Michael Roth ha scritto: > Signed-off-by: Michael Roth > --- > qidl.h | 113 > > 1 file changed, 113 insertions(+) > create mode 100644 qidl.h > > diff --git a/qidl.h b/qidl.h > new file mode 100644 > index

[Qemu-devel] [PATCH 6/8] target-arm: mark a few integer helpers const and pure

2012-10-05 Thread Peter Maydell
From: Aurelien Jarno Signed-off-by: Aurelien Jarno Signed-off-by: Peter Maydell --- target-arm/helper.h | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/target-arm/helper.h b/target-arm/helper.h index 794e2b1..8b9adf1 100644 --- a/target-arm/helper.h +

[Qemu-devel] [PATCH 5/8] target-arm: convert sar, shl and shr helpers to TCG

2012-10-05 Thread Peter Maydell
From: Aurelien Jarno Now that the movcond TCG op is available, it's possible to replace shl and shr helpers by TCG code. The code generated by TCG is slightly longer than the code generated by GCC for the helper but is still worth it as this avoid all the consequences of using an helper: globals

[Qemu-devel] [PULL 0/8] target-arm queue

2012-10-05 Thread Peter Maydell
Usual target-arm pullreq; mostly Aurelien's performance improvement patches. The 'drop macro' patch has only been on the list a few days but it's completely trivial so I threw it in too. Please pull. thanks -- PMM The following changes since commit a14c74928ba1fdaada515717f4d3c3fa3275d6f7: Mer

[Qemu-devel] [PATCH 8/8] target-arm: Drop unused DECODE_CPREG_CRN macro

2012-10-05 Thread Peter Maydell
This macro snuck through code review despite being unused; drop it. Signed-off-by: Peter Maydell --- target-arm/cpu.h |2 -- 1 file changed, 2 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 7fac94f..ff4de10 100644 --- a/target-arm/cpu.h +++ b/target-arm/cpu.h @@ -423,8

[Qemu-devel] [PATCH 2/8] target-arm: Reinstate display of VFP registers in cpu_dump_state

2012-10-05 Thread Peter Maydell
Reinstate the display of VFP registers in cpu_dump_state(), if the CPU has them (this code had been #if 0'd out a for a long time). We drop the attempt ot display the values as floating point, since this makes assumptions about the host 'float' and 'double' formats and is not done by eg the i386 cp

Re: [Qemu-devel] [PATCH] target-i386: initialize APIC at CPU level

2012-10-05 Thread Igor Mammedov
On Thu, 04 Oct 2012 18:15:48 +0200 Andreas Färber wrote: > > +env->apic_state = qdev_create(NULL, apic_type); > > + > > +if (env->apic_state == NULL) { > > +error_set(errp, QERR_DEVICE_INIT_FAILED, apic_type); > > +return; > > +} > > + > > +object_property_add_child

Re: [Qemu-devel] [PATCH v3 21/22] qidl: qidl.h, definitions for qidl annotations

2012-10-05 Thread Michael Roth
On Fri, Oct 05, 2012 at 05:07:46PM +0200, Paolo Bonzini wrote: > Il 04/10/2012 19:33, Michael Roth ha scritto: > > Signed-off-by: Michael Roth > > --- > > qidl.h | 113 > > > > 1 file changed, 113 insertions(+) > > create mode 10

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-05 Thread Blue Swirl
On Fri, Oct 5, 2012 at 5:39 AM, Stefan Weil wrote: > Am 05.10.2012 04:10, schrieb Anthony Liguori: > >> Avi Kivity writes: >> >>> The hassle and compile time overhead of maintaining both 32-bit and >>> 64-bit >>> capable source isn't worth the tiny performance advantage which is seen >>> on >>> a

Re: [Qemu-devel] [PATCH v3 21/22] qidl: qidl.h, definitions for qidl annotations

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 17:41, Michael Roth ha scritto: > On Fri, Oct 05, 2012 at 05:07:46PM +0200, Paolo Bonzini wrote: >> Il 04/10/2012 19:33, Michael Roth ha scritto: >>> Signed-off-by: Michael Roth >>> --- >>> qidl.h | 113 >>> >>> 1 fi

  1   2   3   >