Re: [Qemu-devel] [PATCH] fix warnings from printf target addresses

2012-09-16 Thread Blue Swirl
On Sun, Sep 16, 2012 at 12:05 AM, Mike Frysinger wrote: > Current code triggers: > memory.c: In function 'invalid_read': > memory.c:1001: warning: format '%#x' expects type 'unsigned int', > but argument 4 has type 'target_phys_addr_t' > memory.c: In function 'invalid_write': > memory.c:10

Re: [Qemu-devel] [PATCH v2 00/14] AREG0 patches, final round

2012-09-16 Thread Blue Swirl
On Sat, Sep 8, 2012 at 11:49 AM, Blue Swirl wrote: > Convert remaining targets to AREG0 free mode. > > Avoid also cpu_single_env in translation code. > > If there are no objections and the s390x queue gets pulled in, > I'll apply the series next weekend. Applied all, please report any problems.

Re: [Qemu-devel] [PATCH] fix warnings from printf target addresses

2012-09-16 Thread Jan Kiszka
On 2012-09-16 02:05, Mike Frysinger wrote: > Current code triggers: > memory.c: In function 'invalid_read': > memory.c:1001: warning: format '%#x' expects type 'unsigned int', > but argument 4 has type 'target_phys_addr_t' > memory.c: In function 'invalid_write': > memory.c:1013: warning: for

[Qemu-devel] [PULL] slirp: enhancements of TFTP and small fixes

2012-09-16 Thread Jan Kiszka
The following changes since commit e0a1e32dbc41e6b2aabb436a9417dfd32177a3dc: Merge branch 'usb.64' of git://git.kraxel.org/qemu (2012-09-11 18:06:56 +0200) are available in the git repository at: git://git.kiszka.org/qemu.git queues/slirp Hervé Poussineau (3): slirp: improve TFTP perf

Re: [Qemu-devel] [PATCH] allow make {dist, }clean work w/out configure

2012-09-16 Thread Paolo Bonzini
Il 16/09/2012 02:30, Mike Frysinger ha scritto: > There's no reason to require configure to run before running a clean > target, so check MAKECMDGOALS before. > > Signed-off-by: Mike Frysinger > --- > Makefile |4 > 1 file changed, 4 insertions(+) > > diff --git a/Makefile b/Makefile >

Re: [Qemu-devel] [PATCH] fix gcc warnings when RESERVED_VA is 0

2012-09-16 Thread Peter Maydell
On 16 September 2012 01:05, Mike Frysinger wrote: > The current code, while correct, triggers a bunch of gcc warnings when > RESERVED_VA is 0 like so: > linux-user/syscall.c: In function 'do_shmat': > linux-user/syscall.c:3058: warning: comparison of unsigned expression < 0 is > always false > li

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-16 Thread Avi Kivity
On 09/13/2012 09:27 PM, Anthony Liguori wrote: >>> >>> Plus, there's a whole variety of other features enabled once we can >>> assume qemu-ga is available. It's worth solving that problem. >> >> We can't assume it. Too many OSes exist, too many guests are already >> exist and ain't broken, too m

[Qemu-devel] Block Migration Assertion in qemu-kvm 1.2.0

2012-09-16 Thread Peter Lieven
Hi, when trying to block migrate a VM from one node to another, the source VM crashed with the following assertion: block.c:3829: bdrv_set_in_use: Assertion `bs->in_use != in_use' failed. Is this sth already addresses/known? Thanks, Peter

Re: [Qemu-devel] [PATCH] fix gcc warnings when RESERVED_VA is 0

2012-09-16 Thread Blue Swirl
On Sun, Sep 16, 2012 at 9:58 AM, Peter Maydell wrote: > On 16 September 2012 01:05, Mike Frysinger wrote: >> The current code, while correct, triggers a bunch of gcc warnings when >> RESERVED_VA is 0 like so: >> linux-user/syscall.c: In function 'do_shmat': >> linux-user/syscall.c:3058: warning:

[Qemu-devel] qemu-kvm and XenServer missing MSRs

2012-09-16 Thread Peter Lieven
Hi, i have seen some recent threads about running Xen as guest. For me it is still not working, but I have read that Avi is working on some fixes. I have seen in the logs that the following MSRs are missing. Maybe this is related: cpu0 unhandled rdmsr: 0xce cpu0 disabled perfctr wrmsr: 0xc1

[Qemu-devel] Block Migration and xbzrle

2012-09-16 Thread Peter Lieven
Hi, I remember that this was broken some time ago and currently with qemu-kvm 1.2.0 I am still not able to use block migration plus xbzrle. The migration fails if both are used together. XBZRLE without block migration works. Can someone please advise what is the current expected behaviour? T

Re: [Qemu-devel] qemu and transparent huge pages

2012-09-16 Thread Michael Tokarev
So, is the patch okay? Thanks, /mjt On 15.08.2012 19:03, Michael Tokarev wrote: > On 15.08.2012 18:26, Avi Kivity wrote: >> On 08/15/2012 05:22 PM, Michael Tokarev wrote: >> Please provide extra info, like the setting of /sys/kernel/mm/transparent_hugepage/enabled. >>> >>> That wa

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2012-09-16 Thread Michael Tokarev
FWIW, Gerd -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1033727 Title: USB passthrough doesn't work anymore with qemu-kvm 1.1.1 Status in QEMU: New Status in “qemu-kvm” package in Debian: Con

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2012-09-16 Thread Michael Tokarev
FWIW, Gerd Hoffmann suggested to enable all usb_host_* tracepoints & send log. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1033727 Title: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2012-09-16 Thread Michael Tokarev
I guess he is referring to --enable-trace-backend configure option. See docs/tracing.txt in the qemu source for more details (http://git.qemu.org/?p=qemu.git;a=blob;f=docs/tracing.txt) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH trivial] mention -b backing_file in qemu-img create subcommand

2012-09-16 Thread Michael Tokarev
The text describing `create' qemu-img subcommand refers to backing_file, but it is not mentioned anywhere in the syntax for this subcommand. Signed-off-by: Michael Tokarev diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index 39419a0..82c6e38 100644 --- a/qemu-img-cmds.hx +++ b/qemu-img-cmds.hx

Re: [Qemu-devel] [PATCH 4/6] alpha-linux-user: Fix sigaction

2012-09-16 Thread Andreas Färber
Am 15.09.2012 22:24, schrieb Richard Henderson: > Unconditional bswap replaced by __get_user/__put_user. > > Signed-off-by: Richard Henderson Does that still take care of swapping with the correct size? The issue for mips was that some oddballs are 32-bit, others long. Please make sure that mip

Re: [Qemu-devel] [PATCH 5/6] target-alpha: Fix cpu_alpha_init

2012-09-16 Thread Andreas Färber
Am 15.09.2012 22:24, schrieb Richard Henderson: > Signed-off-by: Richard Henderson This is lacking a proper description. I'd be very ashamed if we lost something so obvious during the QOM conversion. So what's the symptoms here? Andreas > --- > target-alpha/translate.c | 7 ++- > 1 file ch

Re: [Qemu-devel] [PATCH 6/6] linux-user: Fix siginfo handling

2012-09-16 Thread Andreas Färber
Am 15.09.2012 22:24, schrieb Richard Henderson: > Compare signal numbers in the proper domain. > Convert all of the fields for SIGIO and SIGCHLD. > > Signed-off-by: Richard Henderson > --- > linux-user/qemu.h| 3 +++ > linux-user/signal.c | 59 > +++

Re: [Qemu-devel] [PATCH 4/6] alpha-linux-user: Fix sigaction

2012-09-16 Thread Peter Maydell
On 16 September 2012 13:58, Andreas Färber wrote: > Am 15.09.2012 22:24, schrieb Richard Henderson: >> Unconditional bswap replaced by __get_user/__put_user. >> >> Signed-off-by: Richard Henderson > > Does that still take care of swapping with the correct size? Yes; they do target-swapping based

Re: [Qemu-devel] Rethinking missed tick catchup

2012-09-16 Thread Anthony Liguori
Avi Kivity writes: > On 09/13/2012 09:27 PM, Anthony Liguori wrote: >> If there was a better/equivalent solution that didn't depend on qemu-ga, >> I'd be all for it. But there isn't AFAICT. > > Perhaps there is. We fixed the problem for Linux by adding kvmclock and > backporting it to distros t

Re: [Qemu-devel] directory hierarchy

2012-09-16 Thread Anthony Liguori
Paolo Bonzini writes: > Il 14/09/2012 15:36, Peter Maydell ha scritto: >> On 14 September 2012 14:17, Paolo Bonzini wrote: >>> here is a proposal for moving around 150 C files currently in the >>> toplevel directory to separate, well-delimited subdirectories. >> >> No general objection (though

Re: [Qemu-devel] directory hierarchy

2012-09-16 Thread Anthony Liguori
Paolo Bonzini writes: > Hi all, > > here is a proposal for moving around 150 C files currently in the > toplevel directory to separate, well-delimited subdirectories. Header > files would be moved for now in include/, preparing for subsequent > reorganization of headers. > > Usually the files wo

Re: [Qemu-devel] [PATCH 11/25] q35: Introduce q35 pc based chipset emulator

2012-09-16 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Thu, Sep 13, 2012 at 04:12:42PM -0400, Jason Baron wrote: >> diff --git a/hw/pc_q35.c b/hw/pc_q35.c >> new file mode 100644 >> index 000..4f75d97 >> --- /dev/null >> +++ b/hw/pc_q35.c >> @@ -0,0 +1,378 @@ >> +/* >> + * QEMU PC System Emulator >> + * >> + * Co

Re: [Qemu-devel] [PATCH 11/25] q35: Introduce q35 pc based chipset emulator

2012-09-16 Thread Michael S. Tsirkin
On Sun, Sep 16, 2012 at 09:48:25AM -0500, Anthony Liguori wrote: > > I wonder if it's possible for q35 to have no devices > > at all in the default machine and have it > > fully qualified by -device switches? > > > > I envision -M qemu-1.3 switch that does exactly that, > > so that machine type onl

[Qemu-devel] Compile error

2012-09-16 Thread Gerhard Wiesinger
Hello, qemu is currently not compile clean on Fedora 17: CC fsdev/virtfs-proxy-helper.o fsdev/virtfs-proxy-helper.c: In function ‘setfsugid’: fsdev/virtfs-proxy-helper.c:293:13: error: ignoring return value of ‘setfsgid’, declared with attribute warn_unused_result [-Werror=unused-result] fsdev

Re: [Qemu-devel] [PATCH 4/6] alpha-linux-user: Fix sigaction

2012-09-16 Thread Richard Henderson
On 2012-09-16 05:58, Andreas Färber wrote: > Am 15.09.2012 22:24, schrieb Richard Henderson: >> Unconditional bswap replaced by __get_user/__put_user. >> >> Signed-off-by: Richard Henderson > > Does that still take care of swapping with the correct size? Yes, and automatically too. > The issue

Re: [Qemu-devel] [PATCH 5/6] target-alpha: Fix cpu_alpha_init

2012-09-16 Thread Richard Henderson
On 2012-09-16 06:01, Andreas Färber wrote: > This is lacking a proper description. I'd be very ashamed if we lost > something so obvious during the QOM conversion. So what's the symptoms here? The most important thing here is saving cpu_model_str. The symptom being a SEGV on clone, when cpu_model_

Re: [Qemu-devel] [PATCH 5/6] target-alpha: Fix cpu_alpha_init

2012-09-16 Thread Andreas Färber
Am 16.09.2012 18:56, schrieb Richard Henderson: > On 2012-09-16 06:01, Andreas Färber wrote: >> This is lacking a proper description. I'd be very ashamed if we lost >> something so obvious during the QOM conversion. So what's the symptoms here? > > The most important thing here is saving cpu_model

Re: [Qemu-devel] [PATCH 5/6] target-alpha: Fix cpu_alpha_init

2012-09-16 Thread Richard Henderson
On 2012-09-16 11:00, Andreas Färber wrote: > As for the reentrancy of the translation initialization, I would prefer > that being handled in initfn, but we can first introduce it here and > move it later. Sure. I was monkey copying the arm cpu_init for that. > So, if you suggest a wording for th

Re: [Qemu-devel] [PATCH -v2 2/2] make the compaction "skip ahead" logic robust

2012-09-16 Thread Richard Davies
Richard Davies wrote: > Thank you for your latest patches. I attach my latest perf report for a slow > boot with all of these applied. For avoidance of any doubt, there is the combined diff versus 3.6.0-rc5 which I tested: diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c index 38b42e7..090405d

Re: [Qemu-devel] [PATCH] fix warnings from printf target addresses

2012-09-16 Thread Mike Frysinger
On Sunday 16 September 2012 03:24:22 Blue Swirl wrote: > On Sun, Sep 16, 2012 at 12:05 AM, Mike Frysinger wrote: > > Current code triggers: > > memory.c: In function 'invalid_read': > > memory.c:1001: warning: format '%#x' expects type 'unsigned int', > > but argument 4 has type 'target_phy

[Qemu-devel] [PATCH] include address in invalid memory region accesses

2012-09-16 Thread Mike Frysinger
The current code to display invalid memory accesses isn't terribly useful as it doesn't tell you what address is actually being accessed. Include it in the error message. Signed-off-by: Mike Frysinger --- memory.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/me

Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

2012-09-16 Thread Mike Frysinger
On Sunday 15 July 2012 15:54:51 Stefan Weil wrote: > Am 15.07.2012 22:26, schrieb Mike Frysinger: > > We should not quote the PKG_CONFIG setting as this deviates from the > > canonical upstream behavior that gets integrated with all other build > > systems, and deviates from how we treat all other

Re: [Qemu-devel] [PATCH] allow make {dist, }clean work w/out configure

2012-09-16 Thread Mike Frysinger
On Sunday 16 September 2012 05:52:47 Paolo Bonzini wrote: > Il 16/09/2012 02:30, Mike Frysinger ha scritto: > > There's no reason to require configure to run before running a clean > > target, so check MAKECMDGOALS before. > > > > --- a/Makefile > > +++ b/Makefile > > @@ -14,9 +14,11 @@ config-hos

[Qemu-devel] [PATCH v2] allow make {dist, }clean work w/out configure

2012-09-16 Thread Mike Frysinger
There's no reason to require configure to run before running a clean target, so check MAKECMDGOALS before. Signed-off-by: Mike Frysinger --- v2 - handle edge cases Makefile |4 1 file changed, 4 insertions(+) diff --git a/Makefile b/Makefile index 1cd5bc8..0a37369 100644 --- a

[Qemu-devel] [PATCH] ignore more generated files

2012-09-16 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- .gitignore |8 1 file changed, 8 insertions(+) diff --git a/.gitignore b/.gitignore index 824c0d2..25c134e 100644 --- a/.gitignore +++ b/.gitignore @@ -11,6 +11,7 @@ trace-dtrace.dtrace *-darwin-user *-linux-user *-bsd-user +libcacard/vscclient

Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

2012-09-16 Thread Stefan Weil
Am 16.09.2012 21:52, schrieb Mike Frysinger: On Sunday 15 July 2012 15:54:51 Stefan Weil wrote: Am 15.07.2012 22:26, schrieb Mike Frysinger: We should not quote the PKG_CONFIG setting as this deviates from the canonical upstream behavior that gets integrated with all other build systems, and de

Re: [Qemu-devel] [PATCH] ignore more generated files

2012-09-16 Thread Stefan Weil
Am 16.09.2012 22:11, schrieb Mike Frysinger: Signed-off-by: Mike Frysinger --- .gitignore |8 1 file changed, 8 insertions(+) diff --git a/.gitignore b/.gitignore index 824c0d2..25c134e 100644 --- a/.gitignore +++ b/.gitignore @@ -11,6 +11,7 @@ trace-dtrace.dtrace *-darwin-use

Re: [Qemu-devel] [PATCH] vmware_vga: Redraw only visible area

2012-09-16 Thread Marek Vasut
> Dear Michael Tokarev, Bump? Did this lead anywhere? Do you need updated patch? > > On 17.08.2012 06:55, Marek Vasut wrote: > > > Disallow negative value boundaries of the redraw rectangle. > > > This fixes a segfault when using -vga vmware. > > > > > > Signed-off-by: Marek Vasut > > > --- > >

Re: [Qemu-devel] [PATCH] ignore more generated files

2012-09-16 Thread Mike Frysinger
On Sunday 16 September 2012 16:33:15 Stefan Weil wrote: > Am 16.09.2012 22:11, schrieb Mike Frysinger: > > +libcacard/vscclient > > +a.out* > > +.gdb_history > > +core > > +gmon.out > > +*.diff > > +*.patch > > +*.rej > > IMHO .gitignore should only contain files which are generated > by a normal

Re: [Qemu-devel] [PATCH v3 0/1] virtio-rng: hardware random number generator

2012-09-16 Thread H. Peter Anvin
On 06/19/2012 11:59 PM, Amit Shah wrote: Hello, Here's the 3rd iteration of the virtio-rng device. This update just rebases the patch on top of current master. Details on the patch in the commit message. Hi everyone... I just stumbled on this patchset after realizing that the virtio-rng s

[Qemu-devel] [PATCH 0/5] target-arm: misc optimizations

2012-09-16 Thread Aurelien Jarno
This patch series optimizes the ARM target by: - using globals instead of ld/st function - using TCG code instead of helpers - marking some helpers const and pure Aurelien Jarno (5): target-arm: use globals for CC flags target-arm: convert add_cc and sub_cc helpers to TCG target-arm: conv

[Qemu-devel] [PATCH 3/5] target-arm: convert shl and shr helpers to TCG

2012-09-16 Thread Aurelien Jarno
Now that the setcond TCG op is available, it's possible to replace shl and shr helpers by TCG code. The code generated by TCG is slightly longer than the code generated by GCC for the helper but is still worth it as this avoid all the consequences of using an helper: globals saved back to memory, n

[Qemu-devel] [PATCH 5/5] target-arm: mark a few integer helpers const and pure

2012-09-16 Thread Aurelien Jarno
Cc: Peter Maydell Signed-off-by: Aurelien Jarno --- target-arm/helper.h | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/target-arm/helper.h b/target-arm/helper.h index b2d2670..e2d181b 100644 --- a/target-arm/helper.h +++ b/target-arm/helper.h @@ -1,8 +

[Qemu-devel] [PATCH 02/11] target-sh4: use float32_muladd() to implement fmac

2012-09-16 Thread Aurelien Jarno
There is no need to add a SH4 specific pickNaNMulAdd() to softfloat as SH4 is always returning a default NaN. Signed-off-by: Aurelien Jarno --- target-sh4/op_helper.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target-sh4/op_helper.c b/target-sh4/op_helper.c index 9b

[Qemu-devel] [PATCH 06/11] target-sh4: optimize swap.w

2012-09-16 Thread Aurelien Jarno
It's possible swap the two 16-bit words of a 32-bit register using a rotation. If the TCG target doesn't implement rotation, the replacement code is similar to the previously implemented code. Signed-off-by: Aurelien Jarno --- target-sh4/translate.c | 12 +--- 1 file changed, 1 inserti

[Qemu-devel] [PATCH 07/11] target-sh4: remove gen_clr_t() and gen_set_t()

2012-09-16 Thread Aurelien Jarno
gen_clr_t() and gen_set_t() have very few callers and can be remplaced by a single line. Remove them. Signed-off-by: Aurelien Jarno --- target-sh4/translate.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/target-sh4/translate.c b/target-sh4/translate.c i

[Qemu-devel] [PATCH 00/11] target-sh4: misc optimizations and cleanup

2012-09-16 Thread Aurelien Jarno
This patch series does some optimization and cleanup in the SH4 emulation. Aurelien Jarno (11): target-sh4: mark a few helpers const and pure target-sh4: use float32_muladd() to implement fmac target-sh4: implement addc and subc using TCG target-sh4: implement addv and subv using TCG tar

[Qemu-devel] [PATCH 4/5] target-arm: optimize helper_sar

2012-09-16 Thread Aurelien Jarno
helper_sar doesn't need env. It can also be marked const and pure. Signed-off-by: Aurelien Jarno --- target-arm/helper.h|2 +- target-arm/op_helper.c |2 +- target-arm/translate.c |6 -- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/target-arm/helper.h b/targ

[Qemu-devel] [PATCH 05/11] target-sh4: optimize xtrct

2012-09-16 Thread Aurelien Jarno
The register being 32 bit long, after a shift to the right by 16 bits, the upper 16 bit are already cleared. There is no need to call ext16u to clear them. Signed-off-by: Aurelien Jarno --- target-sh4/translate.c |1 - 1 file changed, 1 deletion(-) diff --git a/target-sh4/translate.c b/targ

Re: [Qemu-devel] [PATCH v3 0/1] virtio-rng: hardware random number generator

2012-09-16 Thread Anthony Liguori
"H. Peter Anvin" writes: > On 06/19/2012 11:59 PM, Amit Shah wrote: >> Hello, >> >> Here's the 3rd iteration of the virtio-rng device. This update just >> rebases the patch on top of current master. >> >> Details on the patch in the commit message. >> > > Hi everyone... > > I just stumbled on th

[Qemu-devel] [PATCH 2/5] target-arm: convert add_cc and sub_cc helpers to TCG

2012-09-16 Thread Aurelien Jarno
Now that the setcond TCG op is available, it's possible to replace add_cc and sub_cc helpers by TCG code. The code generated by TCG is actually very close to the one generated by GCC for the helper, and this avoid all the consequences of using an helper: globals saved back to memory, no possible op

[Qemu-devel] [PATCH 1/5] target-arm: use globals for CC flags

2012-09-16 Thread Aurelien Jarno
Use globals for CC flags instead of loading/storing them each they are accessed. This allows some optimizations to be performed by the TCG optimization passes. Cc: Peter Maydell Signed-off-by: Aurelien Jarno --- target-arm/translate.c | 127 ++-- 1 f

Re: [Qemu-devel] [PATCH v3 0/1] virtio-rng: hardware random number generator

2012-09-16 Thread H. Peter Anvin
On 09/16/2012 04:23 PM, Anthony Liguori wrote: This is *exactly* what the problem is. If using /dev/urandom is pointless--and so far, many people have made compelling arguments that it is--then using /dev/random is seemingly impossible to do fairly. It is not merely pointless, it is a security

[Qemu-devel] [PATCH 04/11] target-sh4: implement addv and subv using TCG

2012-09-16 Thread Aurelien Jarno
addv and subv helpers implementation is directly copied from the SH4 manual and looks quite complex. It is however possible to explain it without branches, and is therefore possible to implement it with TCG. Signed-off-by: Aurelien Jarno --- target-sh4/helper.h|2 -- target-sh4/op_helper

[Qemu-devel] [PATCH 08/11] target-sh4: rework exceptions handling

2012-09-16 Thread Aurelien Jarno
Since commit fd4bab102 PC is restored in case of exception through code retranslation. While it is clearly the thing to do in case it is not not known if an helper is going to trigger an exception or not (e.g. for load/store, FPU, etc.), it just make things slower when the exception is already know

[Qemu-devel] [PATCH 09/11] target-sh4: cleanup DisasContext

2012-09-16 Thread Aurelien Jarno
We should avoid accessing env at translation stage, except of course for static values like the supported features. Remove variables copied from env in DisasContext and use the TB flags instead. Signed-off-by: Aurelien Jarno --- target-sh4/translate.c | 56 ++--

[Qemu-devel] [PATCH 03/11] target-sh4: implement addc and subc using TCG

2012-09-16 Thread Aurelien Jarno
Now that setcond is available, the addc and subc can easily be implemented using TCG. Signed-off-by: Aurelien Jarno --- target-sh4/helper.h|2 -- target-sh4/op_helper.c | 32 target-sh4/translate.c | 38 -- 3 files

[Qemu-devel] [PATCH 10/11] target-sh4: remove useless code

2012-09-16 Thread Aurelien Jarno
Almost dead code. Signed-off-by: Aurelien Jarno --- target-sh4/translate.c |4 1 file changed, 4 deletions(-) diff --git a/target-sh4/translate.c b/target-sh4/translate.c index e5478cb..0fa83ca 100644 --- a/target-sh4/translate.c +++ b/target-sh4/translate.c @@ -18,7 +18,6 @@ */ #

[Qemu-devel] [PATCH 01/11] target-sh4: mark a few helpers const and pure

2012-09-16 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- target-sh4/helper.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target-sh4/helper.h b/target-sh4/helper.h index 6e4f108..d498719 100644 --- a/target-sh4/helper.h +++ b/target-sh4/helper.h @@ -23,8 +23,8 @@ DEF_HELPER_3(macw, void,

[Qemu-devel] [PATCH 11/11] gdbstub/sh4: fix build with USE_SOFTFLOAT_STRUCT_TYPES

2012-09-16 Thread Aurelien Jarno
We have to use different type to access float values when USE_SOFTFLOAT_STRUCT_TYPES is defined. Rework SH4 version of cpu_gdb_{read,write}_register() using a single case, and fixing the coding style. Use ldll_p() and stfl_p() to access float values. Signed-off-by: Aurelien Jarno --- gdbstub.c

Re: [Qemu-devel] [PATCH] ehci: switch to new-style memory ops

2012-09-16 Thread David Gibson
On Thu, Sep 06, 2012 at 11:53:51AM +0200, Gerd Hoffmann wrote: > Also register different memory regions for capabilities, > operational registers and port status registers. Create > separate tracepoints for operational regs and port status > regs. Ditch a bunch of sanity checks because the memory

Re: [Qemu-devel] [PATCH V2 2/6] libqblock type and structure defines

2012-09-16 Thread Wenchao Xia
于 2012-9-15 2:11, Blue Swirl 写道: On Thu, Sep 13, 2012 at 3:49 AM, Eric Blake wrote: On 09/12/2012 09:33 PM, Eric Blake wrote: OK ,then I think #if __GNUC__ >= 4 #else [warn name space pollution may happen] #endif would be better. It may be shorter, but it is definitely not better,

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-16 Thread liu ping fan
On Thu, Sep 13, 2012 at 4:19 PM, Avi Kivity wrote: > On 09/13/2012 09:55 AM, liu ping fan wrote: >> On Tue, Sep 11, 2012 at 8:41 PM, Avi Kivity wrote: >>> On 09/11/2012 03:24 PM, Avi Kivity wrote: On 09/11/2012 12:57 PM, Jan Kiszka wrote: > On 2012-09-11 11:44, liu ping fan wrote: >>

[Qemu-devel] [PATCH v4 0/3] net: fix link status

2012-09-16 Thread Amos Kong
First patch implemeted link status setting of rtl8139, the rest patches updated nc.link_down in post_load() of migration to keep it coincident with real link status. Amos Kong (2): e1000: update nc.link_down in e1000_post_load() update nc.link_down in virtio_net_load() Jason Wang (1): rtl81

[Qemu-devel] [PATCH v4 1/3] rtl8139: implement 8139cp link status

2012-09-16 Thread Amos Kong
From: Jason Wang Add a link status chang callback and change the link status bit in BMSR & MSR accordingly. Tested in Linux/Windows guests. The link status bit of MediaStatus is infered from BasicModeStatus, they are inverse. nc.link_down could not be migrated, this patch updates link_down in r

[Qemu-devel] [PATCH v4 2/3] e1000: update nc.link_down in e1000_post_load()

2012-09-16 Thread Amos Kong
This patch introduced e1000_post_load(), it will be called in the end of migration. nc.link_down could not be migrated, this patch updates link_down in e1000_post_load() to keep it coincident with real link status. Signed-off-by: Amos Kong --- hw/e1000.c | 11 +++ 1 files changed, 11 i

[Qemu-devel] [PATCH v4 3/3] update nc.link_down in virtio_net_load()

2012-09-16 Thread Amos Kong
nc.link_down could not be migrated, this patch updates link_down in virtio_post_load() to keep it coincident with real link status. Signed-off-by: Amos Kong --- hw/virtio-net.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index b19

Re: [Qemu-devel] [PATCH v4 0/3] net: fix link status

2012-09-16 Thread Jason Wang
On 09/17/2012 10:25 AM, Amos Kong wrote: First patch implemeted link status setting of rtl8139, the rest patches updated nc.link_down in post_load() of migration to keep it coincident with real link status. Amos Kong (2): e1000: update nc.link_down in e1000_post_load() update nc.link_down

Re: [Qemu-devel] [PATCH v3 0/1] virtio-rng: hardware random number generator

2012-09-16 Thread Amit Shah
On (Sun) 16 Sep 2012 [13:42:46], H. Peter Anvin wrote: > On 06/19/2012 11:59 PM, Amit Shah wrote: > >Hello, > > > >Here's the 3rd iteration of the virtio-rng device. This update just > >rebases the patch on top of current master. > > > >Details on the patch in the commit message. > > > > Hi every

Re: [Qemu-devel] [PATCH v3 0/1] virtio-rng: hardware random number generator

2012-09-16 Thread H. Peter Anvin
Right, obviously. However, under no circumstances should /dev/urandom be used! Amit Shah wrote: >On (Sun) 16 Sep 2012 [13:42:46], H. Peter Anvin wrote: >> On 06/19/2012 11:59 PM, Amit Shah wrote: >> >Hello, >> > >> >Here's the 3rd iteration of the virtio-rng device. This update just >> >rebase

Re: [Qemu-devel] [PATCH] vmware_vga: Redraw only visible area

2012-09-16 Thread Michael Tokarev
On 17.09.2012 00:36, Marek Vasut wrote: >> Dear Michael Tokarev, > > Bump? Did this lead anywhere? Do you need updated patch? This didn't lead to anywhere. I just pointed out that we have similar issue and somewhat similar change, and it weren't sufficient. I don't know this code, and have no

Re: [Qemu-devel] [PATCH] ehci: switch to new-style memory ops

2012-09-16 Thread Gerd Hoffmann
On 09/17/12 02:53, David Gibson wrote: > On Thu, Sep 06, 2012 at 11:53:51AM +0200, Gerd Hoffmann wrote: >> Also register different memory regions for capabilities, >> operational registers and port status registers. Create >> separate tracepoints for operational regs and port status >> regs. Ditc

Re: [Qemu-devel] [PATCH] ignore more generated files

2012-09-16 Thread Stefan Weil
Am 16.09.2012 22:55, schrieb Mike Frysinger: On Sunday 16 September 2012 16:33:15 Stefan Weil wrote: Am 16.09.2012 22:11, schrieb Mike Frysinger: +libcacard/vscclient +a.out* +.gdb_history +core +gmon.out +*.diff +*.patch +*.rej IMHO .gitignore should only contain files which are generated by

Re: [Qemu-devel] [Qemu-ppc][PATCH v10 1/1] Add USB option in machine options

2012-09-16 Thread Li Zhang
Hi all, What should I do to improve this patch? Can anyone give more suggestions? Thanks. -:) On Mon, Sep 3, 2012 at 1:25 PM, Li Zhang wrote: > When -usb option is used, global varible usb_enabled is set. > And all the plaform will create one USB controller according > to this variable. In fact

Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

2012-09-16 Thread Sergei Trofimovich
On Sun, 16 Sep 2012 22:21:31 +0200 Stefan Weil wrote: > Am 16.09.2012 21:52, schrieb Mike Frysinger: > > On Sunday 15 July 2012 15:54:51 Stefan Weil wrote: > >> Am 15.07.2012 22:26, schrieb Mike Frysinger: > >>> We should not quote the PKG_CONFIG setting as this deviates from the > >>> canonical