Re: [Qemu-devel] VM Communications inner a network bridge

2012-09-05 Thread Stefan Hajnoczi
On Tue, Sep 4, 2012 at 1:50 PM, GaoYi wrote: > When 2 VMs are started on the same network bridge, will the TCP/IP > packets between them still go through the router (actually these 2 VMs share > the same physical network card)? If so, is it possible to just pass the > packets inner the network

Re: [Qemu-devel] [PATCH v2 2/7] s390/kvm: Add support for machine checks.

2012-09-05 Thread Heiko Carstens
On Tue, Sep 04, 2012 at 05:13:25PM +0200, Cornelia Huck wrote: Just some quick comments: [...] > int kvm_s390_inject_program_int(struct kvm_vcpu *vcpu, u16 code) > { > struct kvm_s390_local_interrupt *li = &vcpu->arch.local_int; > @@ -648,6 +747,12 @@ int kvm_s390_inject_vm(struct kvm *k

Re: [Qemu-devel] [PATCH v2 1/7] s390/kvm: Support for I/O interrupts.

2012-09-05 Thread Avi Kivity
On 09/04/2012 06:13 PM, Cornelia Huck wrote: > Add support for handling I/O interrupts (standard, subchannel-related > ones and rudimentary adapter interrupts). > > The subchannel-identifying parameters are encoded into the interrupt > type. > > I/O interrupts are floating, so they can't be injec

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-05 Thread Bharata B Rao
On Thu, Aug 09, 2012 at 06:32:16PM +0530, Bharata B Rao wrote: > +static void qemu_gluster_complete_aio(GlusterAIOCB *acb) > +{ > +int ret; > + > +if (acb->canceled) { > +qemu_aio_release(acb); > +return; > +} > + > +if (acb->ret == acb->size) { > +ret = 0; /

Re: [Qemu-devel] [RFC PATCH v2 0/7] s390: virtual css host support.

2012-09-05 Thread Avi Kivity
On 09/04/2012 06:13 PM, Cornelia Huck wrote: > Hi, > > here's the second revision of the virtual channel subsystem support for > s390. > > I changed the representation of the channel subsystem, introducing channel > subsystem images, which brings it closer to the actual implementation. A > new io

Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-09-05 Thread liu ping fan
[...] >> > We could externalize the refcounting and push it into device code. This > means: > >memory_region_init_io(&s->mem, dev) > >... > >object_ref(dev) >memory_region_add_subregion(..., &dev->mr) > >... > >memory_regi

Re: [Qemu-devel] [PATCH v2 1/7] s390/kvm: Support for I/O interrupts.

2012-09-05 Thread Cornelia Huck
On Wed, 05 Sep 2012 10:28:53 +0300 Avi Kivity wrote: > On 09/04/2012 06:13 PM, Cornelia Huck wrote: > > Add support for handling I/O interrupts (standard, subchannel-related > > ones and rudimentary adapter interrupts). > > > > The subchannel-identifying parameters are encoded into the interrupt

[Qemu-devel] [PATCH] block: output more error messages if failed to create temporary snapshot

2012-09-05 Thread riegamaths
From: Dunrong Huang If we failed to create temporary snapshot, the error message did not match with the error, for example: $ TMPDIR=/tmp/bad_path qemu-system-x86_64 -enable-kvm debian.qcow2 -snapshot qemu-system-x86_64: -enable-kvm: could not open disk image /home/mathslinux/Images/debian.qcow

Re: [Qemu-devel] [PATCH v2 2/7] s390/kvm: Add support for machine checks.

2012-09-05 Thread Cornelia Huck
On Wed, 5 Sep 2012 09:22:32 +0200 Heiko Carstens wrote: > On Tue, Sep 04, 2012 at 05:13:25PM +0200, Cornelia Huck wrote: > > Just some quick comments: > > [...] > > > int kvm_s390_inject_program_int(struct kvm_vcpu *vcpu, u16 code) > > { > > struct kvm_s390_local_interrupt *li = &vcpu->a

Re: [Qemu-devel] [RFC 1/6] x86_cpudef_setup: coding style change

2012-09-05 Thread Igor Mammedov
On Fri, 17 Aug 2012 14:53:37 -0300 Eduardo Habkost wrote: > Make source code lines shorter. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 96ec9

Re: [Qemu-devel] [PATCH] Versatile Express: add modelling of NOR flash

2012-09-05 Thread Peter Maydell
On 5 September 2012 06:16, Stefan Weil wrote: > Am 04.09.2012 19:08, schrieb Francesco Lavra: >> /* VE_NORFLASH0ALIAS: not modelled */ > > > What about that alias? It's not difficult to add it, too. > Just look for memory_region_init_alias in the code to > see how it is done (hw/mips_malta.c

Re: [Qemu-devel] [RFC 3/6] i386: kvm: bit 10 of CPUID[8000_0001].EDX is reserved

2012-09-05 Thread Igor Mammedov
On Fri, 17 Aug 2012 14:53:39 -0300 Eduardo Habkost wrote: > Bit 10 of CPUID[8000_0001].EDX is not defined as an alias of > CPUID[1].EDX[10], so do not duplicate it on > kvm_arch_get_supported_cpuid(). > > Signed-off-by: Eduardo Habkost > --- > target-i386/kvm.c | 2 +- > 1 file changed, 1 inse

Re: [Qemu-devel] [RFC 4/6] i386: kvm: use a #define for the set of alias feature bits

2012-09-05 Thread Igor Mammedov
On Fri, 17 Aug 2012 14:53:40 -0300 Eduardo Habkost wrote: > Instea of using a hardcoded hex constant, define CPUID_EXT2_AMD_ALIASES > as the set of CPUID[8000_0001].EDX bits that on AMD are the same as the > bits of CPUID[1].EDX. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.h | 1

[Qemu-devel] [PATCH] arch_init.c: add missing '%' symbols before PRIu64 in debug printfs

2012-09-05 Thread Igor Mitsyanko
'%' symbols were missing in front of PRIu64 macros in DPRINTF() messages in arch_init.c, this caused compilation warnings when compiled with DEBUG_ARCH_INIT defined. Signed-off-by: Igor Mitsyanko --- arch_init.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arc

Re: [Qemu-devel] [RFC 2/6] i386: kill cpudef config section support

2012-09-05 Thread Igor Mammedov
On Fri, 17 Aug 2012 14:53:38 -0300 Eduardo Habkost wrote: > It's nice to have a flexible system to maintain CPU models as data, but > this is holding us from making improvements in the CPU code because it's > not using the common infra-structure, and because the machine-type data > is still insid

[Qemu-devel] [PATCH] fix entry pointer for ELF kernels loaded with -kernel option

2012-09-05 Thread Henning Schild
This patch fixes a bug in qemu which prevents Multiboot ELF kernels from being loaded with the -kernel option. Find a full description of the problem here https://bugs.launchpad.net/qemu/+bug/1044727 . --- hw/elf_ops.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff

Re: [Qemu-devel] [PATCH 0/3] fdc: Fix FD_SR0_SEEK flag

2012-09-05 Thread Pavel Hrdina
On 09/04/2012 11:46 AM, Kevin Wolf wrote: Pavel, does this make sense to you? It seems to fix the NT 3.1 floppy driver. Kevin Wolf (3): fdc: Remove status0 parameter from fdctrl_set_fifo() fdc: Fix false FD_SR0_SEEK fdc-test: Check READ ID hw/fdc.c | 38 ++--

Re: [Qemu-devel] [PATCH 0/2 v3] Fix static linking for cURL and SDL

2012-09-05 Thread Stefan Hajnoczi
On Sun, Sep 02, 2012 at 03:09:44PM +0200, Yann E. MORIN wrote: > Hello All! > > Currently, configure checks for cURL and SDL with either pkg-config (the > default), or with {curl,sdl}-config (as a fallback). > > But pkg-config and {curl,sdl}-config do not have the same set of options: > - to ch

Re: [Qemu-devel] [Qemu-trivial] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-05 Thread Stefan Hajnoczi
On Mon, Sep 03, 2012 at 10:23:23PM +0200, Stefan Weil wrote: > Report from smatch: > sparc-dis.c:2664 build_hash_table(14) info: > redundant null check on hash_buf calling free() > > Signed-off-by: Stefan Weil > --- > > Coding style was not fixed. > > - sw > > sparc-dis.c |3 +-- > 1 fil

Re: [Qemu-devel] [PATCH] fix entry pointer for ELF kernels loaded with -kernel option

2012-09-05 Thread Dunrong Huang
2012/9/5 Henning Schild : > This patch fixes a bug in qemu which prevents Multiboot ELF kernels from > being loaded with the -kernel option. Find a full description of the problem > here https://bugs.launchpad.net/qemu/+bug/1044727 . > > --- > hw/elf_ops.h | 10 ++ > 1 files changed, 10

Re: [Qemu-devel] [PATCH] kvm: Fix warning from static code analysis

2012-09-05 Thread Stefan Hajnoczi
On Mon, Sep 03, 2012 at 10:40:40PM +0200, Stefan Weil wrote: > Report from smatch: > > kvm-all.c:1373 kvm_init(135) warn: > variable dereferenced before check 's' (see line 1360) > > 's' cannot by NULL (it was alloced using g_malloc0), so there is no need > to check it here. > > Signed-off-by:

Re: [Qemu-devel] [RFC 2/6] i386: kill cpudef config section support

2012-09-05 Thread Igor Mammedov
On Wed, 5 Sep 2012 11:09:16 +0200 Igor Mammedov wrote: > On Fri, 17 Aug 2012 14:53:38 -0300 > Eduardo Habkost wrote: > > > It's nice to have a flexible system to maintain CPU models as data, but > > this is holding us from making improvements in the CPU code because it's > > not using the commo

Re: [Qemu-devel] [PATCH V7 2/2] qemu-img: Add json output option to the info command.

2012-09-05 Thread Kevin Wolf
Am 05.09.2012 11:25, schrieb Benoît Canet: > This option --output=[human|json] make qemu-img info output on > human or JSON representation at the choice of the user. > > example: > { > "snapshots": [ > { > "vm-clock-nsec": 637102488, > "name": "vm-20120821145509

[Qemu-devel] [PATCH 2/4] spice: split qemu_spice_create_update

2012-09-05 Thread Gerd Hoffmann
Creating one function which creates a single update for a given rectangle. And one (for now) pretty simple wrapper around it to queue up screen updates for the dirty region. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 29 + 1 files changed, 17 insertions(

[Qemu-devel] [PATCH 3/4] spice: add screen mirror

2012-09-05 Thread Gerd Hoffmann
Create a screen mirror, keep there a copy of the most recent update passed on to spice-server. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 32 ++-- ui/spice-display.h |1 + 2 files changed, 23 insertions(+), 10 deletions(-) diff --git a/ui/spice-displ

Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: output more error messages if failed to create temporary snapshot

2012-09-05 Thread Stefan Hajnoczi
On Wed, Sep 05, 2012 at 04:26:14PM +0800, riegama...@gmail.com wrote: > From: Dunrong Huang > > If we failed to create temporary snapshot, the error message did not match > with the error, for example: > > $ TMPDIR=/tmp/bad_path qemu-system-x86_64 -enable-kvm debian.qcow2 -snapshot > qemu-system

[Qemu-devel] [PATCH 4/4] spice: send updates only for changed screen content

2012-09-05 Thread Gerd Hoffmann
when creating screen updates go compare the current guest screen against the mirror (which holds the most recent update sent), then only create updates for the screen areas which did actually change. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 55 +

Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-09-05 Thread Avi Kivity
On 09/05/2012 11:19 AM, liu ping fan wrote: > [...] >>> >> We could externalize the refcounting and push it into device code. This >> means: >> >>memory_region_init_io(&s->mem, dev) >> >>... >> >>object_ref(dev) >>memory_region_add_subregion(...,

[Qemu-devel] [PATCH v2] block: output more error messages if failed to create temporary snapshot

2012-09-05 Thread riegamaths
From: Dunrong Huang If we failed to create temporary snapshot, the error message did not match with the error, for example: $ TMPDIR=/tmp/bad_path qemu-system-x86_64 -enable-kvm debian.qcow2 -snapshot qemu-system-x86_64: -enable-kvm: could not open disk image /home/mathslinux/Images/debian.qcow

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-05 Thread Bharata B Rao
On Wed, Sep 05, 2012 at 01:11:06PM +0530, Bharata B Rao wrote: > On Thu, Aug 09, 2012 at 06:32:16PM +0530, Bharata B Rao wrote: > > +static void qemu_gluster_complete_aio(GlusterAIOCB *acb) > > +{ > > +int ret; > > + > > +if (acb->canceled) { > > +qemu_aio_release(acb); > > +

Re: [Qemu-devel] [PATCH] arch_init.c: add missing '%' symbols before PRIu64 in debug printfs

2012-09-05 Thread Stefan Hajnoczi
On Wed, Sep 05, 2012 at 01:04:56PM +0400, Igor Mitsyanko wrote: > '%' symbols were missing in front of PRIu64 macros in DPRINTF() messages in > arch_init.c, this caused compilation warnings when compiled with > DEBUG_ARCH_INIT defined. > > Signed-off-by: Igor Mitsyanko > --- > arch_init.c |

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-05 Thread Kevin Wolf
Am 05.09.2012 09:41, schrieb Bharata B Rao: > On Thu, Aug 09, 2012 at 06:32:16PM +0530, Bharata B Rao wrote: >> +static void qemu_gluster_complete_aio(GlusterAIOCB *acb) >> +{ >> +int ret; >> + >> +if (acb->canceled) { >> +qemu_aio_release(acb); >> +return; >> +} >> + >>

[Qemu-devel] [PATCH 0/4] spice: improve vga mode performance

2012-09-05 Thread Gerd Hoffmann
Hi, This patch series makes spice be more clever on screen updates when in vga mode (i.e. without qxl guest driver loaded or when using a non-qxl vga card). qemu keeps a copy of the screen with the content forwarded to spice-server, then on updates it goes compare the guest screen with the copy

[Qemu-devel] [PATCH 1/4] spice: switch to queue for vga mode updates

2012-09-05 Thread Gerd Hoffmann
--- hw/qxl.c |6 +++--- ui/spice-display.c | 25 ++--- ui/spice-display.h |3 ++- 3 files changed, 19 insertions(+), 15 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index b726c19..833cd77 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -597,9 +597,9 @@ static int

Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: output more error messages if failed to create temporary snapshot

2012-09-05 Thread Kevin Wolf
Am 05.09.2012 11:40, schrieb Stefan Hajnoczi: > On Wed, Sep 05, 2012 at 04:26:14PM +0800, riegama...@gmail.com wrote: >> From: Dunrong Huang >> >> If we failed to create temporary snapshot, the error message did not match >> with the error, for example: >> >> $ TMPDIR=/tmp/bad_path qemu-system-x86

Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-09-05 Thread Jan Kiszka
On 2012-09-05 11:52, Avi Kivity wrote: > On 09/05/2012 11:19 AM, liu ping fan wrote: >> [...] >>> We could externalize the refcounting and push it into device code. This >>> means: >>> >>>memory_region_init_io(&s->mem, dev) >>> >>>... >>> >>>object_

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-05 Thread Bharata B Rao
On Wed, Sep 05, 2012 at 12:01:58PM +0200, Kevin Wolf wrote: > Am 05.09.2012 09:41, schrieb Bharata B Rao: > > On Thu, Aug 09, 2012 at 06:32:16PM +0530, Bharata B Rao wrote: > >> +static void qemu_gluster_complete_aio(GlusterAIOCB *acb) > >> +{ > >> +int ret; > >> + > >> +if (acb->canceled)

Re: [Qemu-devel] [PATCH 0/2] slirp fixes

2012-09-05 Thread Jan Kiszka
On 2012-09-04 23:20, Stefan Weil wrote: > These patches replace http://patchwork.ozlabs.org/patch/181411/. > > I modified the code as suggested by Jan Kiska and separated > the original patch in two patches. > > [PATCH 1/2] slirp: Remove wrong type casts ins debug statements > [PATCH 2/2] slirp:

Re: [Qemu-devel] [PATCH 2/2] slirp: Fix error reported by static code analysis

2012-09-05 Thread Jan Kiszka
On 2012-09-04 23:20, Stefan Weil wrote: > Report from smatch: > > slirp/tcp_subr.c:127 tcp_respond(17) error: > we previously assumed 'tp' could be null (see line 124) > > Return if 'tp' is NULL. > > Signed-off-by: Stefan Weil > --- > slirp/tcp_subr.c |2 +- > 1 file changed, 1 insertion(

Re: [Qemu-devel] [PATCH] fix entry pointer for ELF kernels loaded with -kernel option

2012-09-05 Thread Kevin Wolf
Am 05.09.2012 11:05, schrieb Henning Schild: > This patch fixes a bug in qemu which prevents Multiboot ELF kernels > from being loaded with the -kernel option. Find a full description of > the problem here https://bugs.launchpad.net/qemu/+bug/1044727 . The logic looks good to me, but there ar

Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-09-05 Thread Avi Kivity
On 09/05/2012 01:36 PM, Jan Kiszka wrote: >> >> My current preference is MemoryRegionOps::ref(MemoryRegion *mr) (and a >> corresponding unref), which has the following requirements: >> >> - if the refcount is nonzero, MemoryRegion::opaque is safe to use >> - if the refcount is nonzero, the Memory

Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-09-05 Thread Jan Kiszka
On 2012-09-05 12:53, Avi Kivity wrote: > On 09/05/2012 01:36 PM, Jan Kiszka wrote: >>> >>> My current preference is MemoryRegionOps::ref(MemoryRegion *mr) (and a >>> corresponding unref), which has the following requirements: >>> >>> - if the refcount is nonzero, MemoryRegion::opaque is safe to use

Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-09-05 Thread Avi Kivity
On 09/05/2012 02:11 PM, Jan Kiszka wrote: > On 2012-09-05 12:53, Avi Kivity wrote: >> On 09/05/2012 01:36 PM, Jan Kiszka wrote: My current preference is MemoryRegionOps::ref(MemoryRegion *mr) (and a corresponding unref), which has the following requirements: - if the refcou

Re: [Qemu-devel] boot device order has no effect for virtio-scsi devices

2012-09-05 Thread ching
On 09/05/2012 02:55 PM, Paolo Bonzini wrote: > Il 05/09/2012 00:13, ching ha scritto: Ah, ok. libvirt for now supports only booting from LUN 0. You can use > ^^^ > > Oops, should have been SeaBIOS. > multiple targets instead of multiple units.

Re: [Qemu-devel] [RFC 6/6] i386: -cpu help: remove reference to specific CPUID leaves/registers

2012-09-05 Thread Igor Mammedov
On Fri, 17 Aug 2012 14:53:42 -0300 Eduardo Habkost wrote: > The -cpu configuration interface is based on a list of feature names or > properties, on a single namespace, so there's no need to mention on > which CPUID leaf/register each flag is located. > > Signed-off-by: Eduardo Habkost > --- >

Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-09-05 Thread Jan Kiszka
On 2012-09-05 13:25, Avi Kivity wrote: > On 09/05/2012 02:11 PM, Jan Kiszka wrote: >> On 2012-09-05 12:53, Avi Kivity wrote: >>> On 09/05/2012 01:36 PM, Jan Kiszka wrote: > > My current preference is MemoryRegionOps::ref(MemoryRegion *mr) (and a > corresponding unref), which has the fol

Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-09-05 Thread Avi Kivity
On 09/05/2012 03:02 PM, Jan Kiszka wrote: > On 2012-09-05 13:25, Avi Kivity wrote: >> On 09/05/2012 02:11 PM, Jan Kiszka wrote: >>> On 2012-09-05 12:53, Avi Kivity wrote: On 09/05/2012 01:36 PM, Jan Kiszka wrote: >> >> My current preference is MemoryRegionOps::ref(MemoryRegion *mr) (an

Re: [Qemu-devel] [PATCH 1/7] block: correctly set the keep_read_only flag

2012-09-05 Thread Kevin Wolf
Am 30.08.2012 20:47, schrieb Jeff Cody: > I believe the bs->keep_read_only flag is supposed to reflect > the initial open state of the device. If the device is initially > opened R/O, then commit operations, or reopen operations changing > to R/W, are prohibited. > > Currently, the keep_read_only

Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: output more error messages if failed to create temporary snapshot

2012-09-05 Thread Dunrong Huang
2012/9/5 Kevin Wolf : > Am 05.09.2012 11:40, schrieb Stefan Hajnoczi: >> On Wed, Sep 05, 2012 at 04:26:14PM +0800, riegama...@gmail.com wrote: >>> From: Dunrong Huang >>> >>> If we failed to create temporary snapshot, the error message did not match >>> with the error, for example: >>> >>> $ TMPDI

Re: [Qemu-devel] [PATCH] fix entry pointer for ELF kernels loaded with -kernel option

2012-09-05 Thread Henning Schild
Find a hopefully proper patch attached. Take it or leave it. Signed-off-by: Henning Schild --- hw/elf_ops.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/hw/elf_ops.h b/hw/elf_ops.h index fa65ce2..731a983 100644 --- a/hw/elf_ops.h +++ b/hw/elf_ops.h @@ -269

Re: [Qemu-devel] [PATCH 1/7] block: correctly set the keep_read_only flag

2012-09-05 Thread Jeff Cody
On 09/05/2012 08:47 AM, Kevin Wolf wrote: > Am 30.08.2012 20:47, schrieb Jeff Cody: >> I believe the bs->keep_read_only flag is supposed to reflect >> the initial open state of the device. If the device is initially >> opened R/O, then commit operations, or reopen operations changing >> to R/W, are

Re: [Qemu-devel] [PATCH] fix entry pointer for ELF kernels loaded with -kernel option

2012-09-05 Thread Kevin Wolf
Am 05.09.2012 14:56, schrieb Henning Schild: > Find a hopefully proper patch attached. Take it or leave it. > > Signed-off-by: Henning Schild Reviewed-by: Kevin Wolf Aurelien, I think in the past you committed some changes in this area. Does this look good to you and can you get it committed

Re: [Qemu-devel] [PATCH 1/7] block: correctly set the keep_read_only flag

2012-09-05 Thread Kevin Wolf
Am 05.09.2012 15:08, schrieb Jeff Cody: > On 09/05/2012 08:47 AM, Kevin Wolf wrote: >> Am 30.08.2012 20:47, schrieb Jeff Cody: >>> I believe the bs->keep_read_only flag is supposed to reflect >>> the initial open state of the device. If the device is initially >>> opened R/O, then commit operations

[Qemu-devel] [PATCH v3] block: output more error messages if failed to create temporary snapshot

2012-09-05 Thread riegamaths
From: Dunrong Huang If we failed to create temporary snapshot, the error message did not match with the error, for example: $ TMPDIR=/tmp/bad_path qemu-system-x86_64 -enable-kvm debian.qcow2 -snapshot qemu-system-x86_64: -enable-kvm: could not open disk image /home/mathslinux/Images/debian.qcow

[Qemu-devel] [PATCH] block: Don't forget to delete temporary file

2012-09-05 Thread riegamaths
From: Dunrong Huang The caller would not delete temporary file after failed get_tmp_filename(). Signed-off-by: Dunrong Huang --- block.c | 6 +- 1 个文件被修改,插入 5 行(+),删除 1 行(-) diff --git a/block.c b/block.c index 074987e..2bc9f75 100644 --- a/block.c +++ b/block.c @@ -433,7 +433,11 @@ int g

[Qemu-devel] [PATCH V7 0/2] Add JSON output to qemu-img info

2012-09-05 Thread Benoît Canet
This patchset add a JSON output mode to the qemu-img info command. It's a rewrite from scratch of the original patchset by Wenchao Xia following Anthony Liguori advices on JSON formating. the --output=(json|human) option is now mandatory on the command line. Benoît Canet (3): qapi: Add Snapshot

[Qemu-devel] [PATCH V7 2/2] qemu-img: Add json output option to the info command.

2012-09-05 Thread Benoît Canet
This option --output=[human|json] make qemu-img info output on human or JSON representation at the choice of the user. example: { "snapshots": [ { "vm-clock-nsec": 637102488, "name": "vm-20120821145509", "date-sec": 1345553709, "date-nsec

[Qemu-devel] [Bug 1028908] Re: qemu-img fails to convert VMDK image

2012-09-05 Thread Kevin Wolf
This should be fixed as of commit 65bd155c (included in 1.2.0-rc1). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1028908 Title: qemu-img fails to convert VMDK image Status in QEMU: New Bug des

[Qemu-devel] [PATCH V8 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-09-05 Thread Benoît Canet
Signed-off-by: Benoit Canet --- qapi-schema.json | 64 ++ 1 file changed, 64 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index bd8ad74..8723795 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -156,6 +156,70 @@

[Qemu-devel] [PATCH V8 2/2] qemu-img: Add json output option to the info command.

2012-09-05 Thread Benoît Canet
This option --output=[human|json] make qemu-img info output on human or JSON representation at the choice of the user. example: { "snapshots": [ { "vm-clock-nsec": 637102488, "name": "vm-20120821145509", "date-sec": 1345553709, "date-nsec

[Qemu-devel] [Bug 1028908] Re: qemu-img fails to convert VMDK image

2012-09-05 Thread Cristian Ciupitu
It works fine for me with git version de188751da8db3c77a681bf903035a0e5218c463 (it's post 1.2.0-rc1). ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/b

[Qemu-devel] [PATCH V7 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-09-05 Thread Benoît Canet
Signed-off-by: Benoit Canet --- qapi-schema.json | 64 ++ 1 file changed, 64 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index bd8ad74..8723795 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -156,6 +156,70 @@

[Qemu-devel] [PATCH V8 0/2] Add JSON output to qemu-img info

2012-09-05 Thread Benoît Canet
This patchset add a JSON output mode to the qemu-img info command. It's a rewrite from scratch of the original patchset by Wenchao Xia following Anthony Liguori advices on JSON formating. the --output=(json|human) option is now mandatory on the command line. Benoît Canet (3): qapi: Add Snapshot

Re: [Qemu-devel] [Bug 893956] Re: qemu-img bug with dynamic vhd

2012-09-05 Thread Serge Hallyn
Quoting Stefan Hajnoczi (893...@bugs.launchpad.net): > On Tue, Sep 4, 2012 at 4:00 PM, Serge Hallyn <893...@bugs.launchpad.net> > wrote: > > Though that commit and the comments were about 127G images. HIs is only > > 27G. > > The 127 GB limit applies to the virtual disk size, not to the size of

Re: [Qemu-devel] [PATCH 2/7] block: Framework for reopening files safely

2012-09-05 Thread Kevin Wolf
Am 30.08.2012 20:47, schrieb Jeff Cody: > This is based heavily on Supriya Kannery's bdrv_reopen() > patch series. > > This provides a transactional method to reopen multiple > images files safely. > > Image files are queue for reopen via bdrv_reopen_queue(), and the > reopen occurs when bdrv_reo

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Avi Kivity
On 09/05/2012 12:00 AM, Anthony Liguori wrote: >> >> Why? The way this is being submitted I don't see why we should treat >> Jan's patch any different from a patch by IBM or Samsung where we've >> asked folks to fix the license to comply with what I thought was our new >> policy (it does not even c

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Michael S. Tsirkin
On Wed, Sep 05, 2012 at 06:26:54PM +0300, Avi Kivity wrote: > On 09/05/2012 12:00 AM, Anthony Liguori wrote: > >> > >> Why? The way this is being submitted I don't see why we should treat > >> Jan's patch any different from a patch by IBM or Samsung where we've > >> asked folks to fix the license t

Re: [Qemu-devel] [PATCH 3/7] block: raw-posix image file reopen

2012-09-05 Thread Kevin Wolf
Am 30.08.2012 20:47, schrieb Jeff Cody: > This is derived from the Supriya Kannery's reopen patches. > > This contains the raw-posix driver changes for the bdrv_reopen_* > functions. All changes are staged into a temporary scratch buffer > during the prepare() stage, and copied over to the live s

Re: [Qemu-devel] [PATCH 02/21] target-s390x: split FPU ops

2012-09-05 Thread Richard Henderson
On 09/04/2012 08:46 PM, Alexander Graf wrote: > So that means your rewrite is based on this series and just fixes it up? Does > that mean if I apply this patch, you will be all happy? It is not (yet) based on this series. But I will be happy if you apply it, since it's easier for me to rebase o

Re: [Qemu-devel] [PATCH] block: Don't forget to delete temporary file

2012-09-05 Thread Paolo Bonzini
Il 05/09/2012 15:26, riegama...@gmail.com ha scritto: > From: Dunrong Huang > > The caller would not delete temporary file after failed get_tmp_filename(). > > Signed-off-by: Dunrong Huang > --- > block.c | 6 +- > 1 个文件被修改,插入 5 行(+),删除 1 行(-) > > diff --git a/block.c b/block.c > index 07

Re: [Qemu-devel] [PATCH v3] block: output more error messages if failed to create temporary snapshot

2012-09-05 Thread Paolo Bonzini
Il 05/09/2012 15:24, riegama...@gmail.com ha scritto: > From: Dunrong Huang > > If we failed to create temporary snapshot, the error message did not match > with the error, for example: > > $ TMPDIR=/tmp/bad_path qemu-system-x86_64 -enable-kvm debian.qcow2 -snapshot > qemu-system-x86_64: -enable

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Anthony Liguori
Avi Kivity writes: > On 09/05/2012 12:00 AM, Anthony Liguori wrote: >>> >>> Why? The way this is being submitted I don't see why we should treat >>> Jan's patch any different from a patch by IBM or Samsung where we've >>> asked folks to fix the license to comply with what I thought was our new >>

Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register

2012-09-05 Thread Jan Kiszka
On 2012-09-05 06:33, Matthew Ogilvie wrote: > According to later discussion, the main issue is actually the input > IRQ behavior on a high to low transition; hence the following fixes > both the test program and the Microport UNIX problem: > > diff --git a/hw/i8259.c b/hw/i8259.c > index 6587666..

Re: [Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-05 Thread Andreas Färber
Am 03.09.2012 22:23, schrieb Stefan Weil: > Report from smatch: > sparc-dis.c:2664 build_hash_table(14) info: > redundant null check on hash_buf calling free() > > Signed-off-by: Stefan Weil > --- > > Coding style was not fixed. > > - sw > > sparc-dis.c |3 +-- > 1 file changed, 1 insert

Re: [Qemu-devel] [PATCH] block: Don't forget to delete temporary file

2012-09-05 Thread Dunrong Huang
Hi, thanks for you reply. 2012/9/5 Paolo Bonzini : > Il 05/09/2012 15:26, riegama...@gmail.com ha scritto: >> From: Dunrong Huang >> >> The caller would not delete temporary file after failed get_tmp_filename(). >> >> Signed-off-by: Dunrong Huang >> --- >> block.c | 6 +- >> 1 个文件被修改,插入 5 行(

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Avi Kivity
On 09/05/2012 06:41 PM, Anthony Liguori wrote: > Avi Kivity writes: > >> On 09/05/2012 12:00 AM, Anthony Liguori wrote: Why? The way this is being submitted I don't see why we should treat Jan's patch any different from a patch by IBM or Samsung where we've asked folks to fix

Re: [Qemu-devel] [PATCH] block: Don't forget to delete temporary file

2012-09-05 Thread Markus Armbruster
Paolo Bonzini writes: > Il 05/09/2012 15:26, riegama...@gmail.com ha scritto: >> From: Dunrong Huang >> >> The caller would not delete temporary file after failed get_tmp_filename(). >> >> Signed-off-by: Dunrong Huang >> --- >> block.c | 6 +- >> 1 个文件被修改,插入 5 行(+),删除 1 行(-) >> >> diff

Re: [Qemu-devel] [PATCH] block: Don't forget to delete temporary file

2012-09-05 Thread Paolo Bonzini
Il 05/09/2012 18:02, Markus Armbruster ha scritto: > Paolo Bonzini writes: > >> Il 05/09/2012 15:26, riegama...@gmail.com ha scritto: >>> From: Dunrong Huang >>> >>> The caller would not delete temporary file after failed get_tmp_filename(). >>> >>> Signed-off-by: Dunrong Huang >>> --- >>> blo

Re: [Qemu-devel] [PATCH] block: Don't forget to delete temporary file

2012-09-05 Thread Eric Blake
On 09/05/2012 10:23 AM, Paolo Bonzini wrote: > And finally, the whole get_tmp_filename is unsafe because there is a > race window between closing and reopening the file, if the directory is > writable and does not have the sticky bit. > > So the patch is an improvement, but there is still somethin

Re: [Qemu-devel] [PATCH 2/7] block: Framework for reopening files safely

2012-09-05 Thread Jeff Cody
On 09/05/2012 11:09 AM, Kevin Wolf wrote: > Am 30.08.2012 20:47, schrieb Jeff Cody: >> This is based heavily on Supriya Kannery's bdrv_reopen() >> patch series. >> >> This provides a transactional method to reopen multiple >> images files safely. >> >> Image files are queue for reopen via bdrv_reop

[Qemu-devel] [ANNOUNCE] QEMU 1.2.0 release

2012-09-05 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the QEMU 1.2 release! http://wiki.qemu.org/download/qemu-1.2.0.tar.bz2 Even though this was the shortest release cycle in QEMU's history, it contains an impressive 1400 changesets from 180 unique authors. See the ChangeLo

Re: [Qemu-devel] [PATCH 3/7] block: raw-posix image file reopen

2012-09-05 Thread Jeff Cody
On 09/05/2012 11:30 AM, Kevin Wolf wrote: > Am 30.08.2012 20:47, schrieb Jeff Cody: >> This is derived from the Supriya Kannery's reopen patches. >> >> This contains the raw-posix driver changes for the bdrv_reopen_* >> functions. All changes are staged into a temporary scratch buffer >> during th

[Qemu-devel] [ANNOUNCE] 1.3 development is now open!

2012-09-05 Thread anthony
I've updated the release plan on the wiki: http://wiki.qemu.org/Planning/1.3 No surprises, same format/timeline as 1.2. Happy hacking! Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-05 Thread Stefan Hajnoczi
On Wed, Sep 5, 2012 at 4:51 PM, Andreas Färber wrote: > Am 03.09.2012 22:23, schrieb Stefan Weil: >> Report from smatch: >> sparc-dis.c:2664 build_hash_table(14) info: >> redundant null check on hash_buf calling free() >> >> Signed-off-by: Stefan Weil >> --- >> >> Coding style was not fixed. >>

[Qemu-devel] Virtual Machine Extension Instructions In QEMU

2012-09-05 Thread Xin Tong
I would like to know how well is the Intel VMX and AMD SVM supported in QEMU ? Xin

Re: [Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-05 Thread Stefan Weil
Am 05.09.2012 18:55, schrieb Stefan Hajnoczi: On Wed, Sep 5, 2012 at 4:51 PM, Andreas Färber wrote: Am 03.09.2012 22:23, schrieb Stefan Weil: Report from smatch: sparc-dis.c:2664 build_hash_table(14) info: redundant null check on hash_buf calling free() Signed-off-by: Stefan Weil --- Codin

Re: [Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-05 Thread Stefan Weil
Am 05.09.2012 19:15, schrieb Stefan Weil: AFAIK, binutils moved to GPL 3. Therefore I don't expect that QEMU will update to upstream in the next years. We'll have to maintain the code which we have. Try "git log *-dis.c" or "gitk *-dis.c": there are already lots of more trivial changes which g

Re: [Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-05 Thread Stefan Weil
Am 05.09.2012 17:51, schrieb Andreas Färber: Am 03.09.2012 22:23, schrieb Stefan Weil: Report from smatch: sparc-dis.c:2664 build_hash_table(14) info: redundant null check on hash_buf calling free() Signed-off-by: Stefan Weil --- Coding style was not fixed. - sw sparc-dis.c |3 +-

Re: [Qemu-devel] Help needed to run Exynos 4210 linux kernel on qemu?

2012-09-05 Thread Jean-Christophe DUBOIS
Hello Igor, Thanks for you reply and your time. JC On 09/05/2012 02:38 PM, Igor Mitsyanko wrote: On 09/04/2012 02:13 AM, Jean-Christophe DUBOIS wrote: Hello, Jean! I've just tried to do the same thing you're trying to do, it works for me if I remove earlyprintk from append. Yes, I found o

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-09-05 Thread Luiz Capitulino
On Wed, 5 Sep 2012 10:19:22 +0800 Amos Kong wrote: > On Thu, Aug 30, 2012 at 12:04 AM, Amos Kong wrote: > > > On Wed, Aug 29, 2012 at 11:15 PM, Amos Kong wrote: > > > On Thu, Feb 23, 2012 at 4:15 PM, Markus Armbruster > > wrote: > > >> > > >> Anthony Liguori writes: > > >> > > >> > On 02/15/

[Qemu-devel] [PULL 00/19]: QMP queue

2012-09-05 Thread Luiz Capitulino
Let's get the ball rolling for QMP in 1.3 :) This pull request contains the send-key command conversion, screendump qapi conversion and a few fixes. The changes (since f45ddd14209a4d1b95a4096d50a561b7f6270118) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git

Re: [Qemu-devel] [PATCH] target-i386: Allow changing of Hypervisor CPUIDs.

2012-09-05 Thread Marcelo Tosatti
On Thu, Aug 30, 2012 at 03:20:35PM -0400, Don Slutz wrote: > This is primarily done so that the guest will think it is running > under vmware when hypervisor=vmware is specified as a property of a > cpu. > > Also allow this to work in accel=tcg mode. > > The new cpu properties hyper_level, hyper_

[Qemu-devel] [PATCH] socket: don't attempt to reconnect a TCP socket in server mode

2012-09-05 Thread Anthony Liguori
Commit c3767ed0eb5d0bb25fe409ae5dec06e3411ff1b6 introduced a possible SEGV when using a socket chardev with server=on because it assumes that all TCP sockets are in client mode. This patch adds a check to only reconnect when in client mode. Cc: Lei Li Reported-by: Michael Roth Signed-off-by: An

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Blue Swirl
On Wed, Sep 5, 2012 at 3:41 PM, Anthony Liguori wrote: > Avi Kivity writes: > >> On 09/05/2012 12:00 AM, Anthony Liguori wrote: Why? The way this is being submitted I don't see why we should treat Jan's patch any different from a patch by IBM or Samsung where we've asked folks

Re: [Qemu-devel] [PATCH] Versatile Express: add modelling of NOR flash

2012-09-05 Thread Francesco Lavra
Hi, On 09/05/2012 10:47 AM, Peter Maydell wrote: > On 5 September 2012 06:16, Stefan Weil wrote: >> Am 04.09.2012 19:08, schrieb Francesco Lavra: >>> /* VE_NORFLASH0ALIAS: not modelled */ >> >> >> What about that alias? It's not difficult to add it, too. >> Just look for memory_region_init_

[Qemu-devel] [PATCH 14/19] vga: ppm_save(): add error handling

2012-09-05 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- hw/blizzard.c | 2 +- hw/qxl.c| 2 +- hw/vga.c| 32 +--- hw/vga_int.h| 3 ++- hw/vmware_vga.c | 2 +- 5 files changed, 30 insertions(+), 11 deletions(-) diff --git a/hw/blizzard.c b/hw/blizzard.c index a2b90

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Blue Swirl
On Tue, Sep 4, 2012 at 9:28 PM, Michael S. Tsirkin wrote: > On Tue, Sep 04, 2012 at 07:27:32PM +, Blue Swirl wrote: >> On Tue, Sep 4, 2012 at 8:32 AM, Avi Kivity wrote: >> > On 09/03/2012 10:32 PM, Blue Swirl wrote: >> >> On Mon, Sep 3, 2012 at 4:14 PM, Avi Kivity wrote: >> >>> On 08/29/2012

[Qemu-devel] [PATCH 11/19] error: add error_setg()

2012-09-05 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- error.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/error.h b/error.h index 96fc203..da7fed3 100644 --- a/error.h +++ b/error.h @@ -30,6 +30,12 @@ typedef struct Error Error; void error_set(Error **err, ErrorClass err_class, const char *fmt, ...)

[Qemu-devel] [PATCH 0/7] Add GTK UI to enable basic accessibility (v3)

2012-09-05 Thread Anthony Liguori
I realize UIs are the third rail of QEMU development, but over the years I've gotten a lot of feedback from users about our UI. I think everyone struggles with the SDL interface and its lack of discoverability but it's worse than I think most people realize for users that rely on accessibility too

[Qemu-devel] [PATCH 5/7] gtk: add support for screen scaling and full screen (v3)

2012-09-05 Thread Anthony Liguori
Basic menu items to enter full screen mode and zoom in/out. Unlike SDL, we don't allow arbitrary scaling based on window resizing. The current behavior with SDL causes a lot of problems for me. Sometimes I accidentally resize the window a tiny bit while trying to move it (Ubuntu's 1-pixel window

  1   2   >