Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-08-27 Thread Paolo Bonzini
Il 25/08/2012 09:42, liu ping fan ha scritto: >> > >> > I don't see why MMIO dispatch should hold the IDEBus ref rather than the >> > PCIIDEState. >> > > When transfer memory_region_init_io() 3rd para from void* opaque to > Object* obj, the obj : opaque is not neccessary 1:1 map. For such > situa

[Qemu-devel] [PATCH V6 0/2] Add JSON output to qemu-img info

2012-08-27 Thread Benoît Canet
This patchset add a JSON output mode to the qemu-img info command. It's a rewrite from scratch of the original patchset by Wenchao Xia following Anthony Liguori advices on JSON formating. the --output=(json|human) option is now mandatory on the command line. Benoît Canet (3): qapi: Add Snapshot

[Qemu-devel] [PATCH V6 2/2] qemu-img: Add json output option to the info command.

2012-08-27 Thread Benoît Canet
This option --output=[human|json] make qemu-img info output on human or JSON representation at the choice of the user. example: { "snapshots": [ { "vm-clock-nsec": 637102488, "name": "vm-20120821145509", "date-sec": 1345553709, "date-nsec

[Qemu-devel] [PATCH V6 1/2] qapi: Add SnapshotInfo and ImageInfo.

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- qapi-schema.json | 64 ++ 1 file changed, 64 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index a92adb1..ffe3a0a 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -126,6 +126,70 @@

Re: [Qemu-devel] [PATCH 8/9] qdev: make qdev_set_parent_bus() just set a link property

2012-08-27 Thread liu ping fan
On Sun, Aug 26, 2012 at 11:51 PM, Anthony Liguori wrote: > Also make setting the link to NULL break the bus link > > Signed-off-by: Anthony Liguori > --- > hw/qdev.c | 48 ++-- > 1 files changed, 42 insertions(+), 6 deletions(-) > > diff --git a/hw/q

Re: [Qemu-devel] [RFC PATCH 0/9] qom: improve reference counting and hotplug

2012-08-27 Thread liu ping fan
On Sun, Aug 26, 2012 at 11:51 PM, Anthony Liguori wrote: > Right now, you need to pair up object_new with object_delete. This is > impractical when using reference counting because we would like to ensure that > object_unref() also frees memory when needed. > > The first few patches fix this prob

Re: [Qemu-devel] [RFC][PATCH v4 3/3] tcg: Optimize qemu_ld/st by generating slow paths at the end of a block

2012-08-27 Thread Yeongkyoon Lee
On 2012년 07월 29일 00:39, Yeongkyoon Lee wrote: On 2012년 07월 25일 23:00, Richard Henderson wrote: On 07/25/2012 12:35 AM, Yeongkyoon Lee wrote: +#if defined(CONFIG_QEMU_LDST_OPTIMIZATION) && defined(CONFIG_SOFTMMU) +/* Macros/structures for qemu_ld/st IR code optimization: + TCG_MAX_HELPER_LABEL

Re: [Qemu-devel] [PATCH 9/9] hotplug: refactor hotplug to leverage new QOM functions

2012-08-27 Thread liu ping fan
On Sun, Aug 26, 2012 at 11:51 PM, Anthony Liguori wrote: > 1) DeviceState::unplug requests for an eject to happen >- the default implementation is a forced eject > > 2) A bus can eject a device by setting the parent_bus to NULL >- this detaches the device from the bus >- this does *not

Re: [Qemu-devel] [PATCH v7 0/6] convert sendkey to qapi

2012-08-27 Thread Amos Kong
On 20/08/12 23:08, Luiz Capitulino wrote: On Mon, 20 Aug 2012 07:25:13 -0600 Eric Blake wrote: On 08/19/2012 10:39 PM, Amos Kong wrote: This series converted 'sendkey' command to qapi. The raw value in hexadecimal format is not supported by 'send-key' of qmp. Are we still trying to get this

[Qemu-devel] [RFC V5 08/11] quorum: Add quorum mechanism.

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 222 +++- 1 file changed, 221 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 791ef4a..3fa9d53 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -14,6 +14,20 @@

Re: [Qemu-devel] [PATCH 1/2] migration: Allow the migrate command to work on file: urls

2012-08-27 Thread Benoît Canet
Adding Luiz to the thread since he is concerned by migration. Luiz do you have any hints on doing this properly ? Benoît > Le Thursday 23 Aug 2012 à 13:34:01 (+0100), Daniel P. Berrange a écrit : > On Thu, Aug 23, 2012 at 02:28:07PM +0200, Benoît Canet wrote: > > Usage: > > (qemu) migrate file:/

[Qemu-devel] [RFC V5 10/11] quorum: Add quorum_invalidate_cache().

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 09eed84..c9dcd9c 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -571,6 +571,16 @@ static int64_t quorum_getlength(BlockDriverState *bs)

[Qemu-devel] [RFC V5 04/11] quorum: Add quorum_aio_writev and its dependencies.

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 112 1 file changed, 112 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index b9fb2b9..cd11cfb 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -172,6 +172,116 @@ static void

Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-08-27 Thread Jan Kiszka
On 2012-08-27 09:01, Paolo Bonzini wrote: > Il 25/08/2012 09:42, liu ping fan ha scritto: I don't see why MMIO dispatch should hold the IDEBus ref rather than the PCIIDEState. >> When transfer memory_region_init_io() 3rd para from void* opaque to >> Object* obj, the obj : opaq

[Qemu-devel] [RFC V5 02/11] quorum: Create BDRVQuorumState and BlkDriver and do init.

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 65a6b55..19a9a44 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -15,6 +15,13 @@ #include "block_int.h" +typedef struct { +

[Qemu-devel] [RFC V5 09/11] quorum: Add quorum_getlength().

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 24 1 file changed, 24 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 3fa9d53..09eed84 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -549,12 +549,36 @@ static coroutine_fn int quorum_co_flush(Bloc

[Qemu-devel] [RFC V5 11/11] quorum: Add quorum_co_is_allocated.

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 32 1 file changed, 32 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index c9dcd9c..5a9f598 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -581,6 +581,37 @@ static void quorum_invalidate_cache(B

[Qemu-devel] [RFC V5 07/11] quorum: Add quorum_aio_readv.

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index f83b4cf..791ef4a 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -193,15 +193,24 @@ static void quo

[Qemu-devel] [RFC V5 06/11] quorum: Add quorum_co_flush().

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 13 + 1 file changed, 13 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index cd11cfb..f83b4cf 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -282,6 +282,18 @@ static BlockDriverAIOCB *quorum_aio_writev(BlockDriverS

[Qemu-devel] [RFC V5 00/11] Quorum disk image corruption resiliency

2012-08-27 Thread Benoît Canet
This patchset create a block driver implementing a quorum using total qemu disk images. Writes are mirrored on the $total files. For the reading part the $total files are read at the same time and a vote is done to determine if a qiov version is present $threshold or more times. It then return thi

[Qemu-devel] [RFC V5 05/11] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/blkverify.c | 108 + cutils.c | 103 ++ qemu-common.h |2 + 3 files changed, 107 insertions(+), 106 deletions(-) diff --git a/block/blkveri

[Qemu-devel] [RFC V5 03/11] quorum: Add quorum_open() and quorum_close().

2012-08-27 Thread Benoît Canet
Valid quorum resources look like quorum:threshold/total:path/to/image_1, ... ,path/to/image_total ',' is used as a separator to allow to use networked path '\' is the escaping character for filename containing ',' '\' escape itself On the command line for quorum files "img,test.raw", "img2.raw" a

Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-08-27 Thread liu ping fan
On Mon, Aug 27, 2012 at 3:47 PM, Jan Kiszka wrote: > On 2012-08-27 09:01, Paolo Bonzini wrote: >> Il 25/08/2012 09:42, liu ping fan ha scritto: > > I don't see why MMIO dispatch should hold the IDEBus ref rather than the > PCIIDEState. > >>> When transfer memory_region_init_io() 3

[Qemu-devel] [RFC V5 01/11] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2012-08-27 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/Makefile.objs |1 + block/quorum.c | 45 + 2 files changed, 46 insertions(+) create mode 100644 block/quorum.c diff --git a/block/Makefile.objs b/block/Makefile.objs index b5754d3..66af6dc 100644 --- a/

Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-08-27 Thread Jan Kiszka
On 2012-08-27 10:17, liu ping fan wrote: > On Mon, Aug 27, 2012 at 3:47 PM, Jan Kiszka wrote: >> On 2012-08-27 09:01, Paolo Bonzini wrote: >>> Il 25/08/2012 09:42, liu ping fan ha scritto: >> >> I don't see why MMIO dispatch should hold the IDEBus ref rather than the >> PCIIDEState. >>

[Qemu-devel] [PATCH] [MIPS] Fix operands of RECIP2.S and RECIP2.PS

2012-08-27 Thread Richard Sandiford
Read the second input operand of RECIP2.S and RECIP2.PS from FT rather than FD. RECIP2.D is already correct. Signed-off-by: Richard Sandiford --- target-mips/translate.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c

[Qemu-devel] [PATCH] [MIPS] Fix order of CVT.PS.S operands

2012-08-27 Thread Richard Sandiford
The FS input to CVT.PS.S is the high half and FT is the low half. tcg_gen_concat_i32_i64 takes the low half first, so the operands were in the wrong order. Signed-off-by: Richard Sandiford --- target-mips/translate.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/targe

Re: [Qemu-devel] qcow2: online snasphots : internal vs external ?

2012-08-27 Thread Stefan Hajnoczi
On Sun, Aug 26, 2012 at 10:56 AM, Alexandre DERUMIER wrote: > It is possible to achieve the same behaviour with external snapshot ? (I > would like to do it online) > I don't see how I can rollback to the point of time of the snapshot. The snapshot only captures the contents of the disk. Rollba

Re: [Qemu-devel] [PATCH] [MIPS] Fix order of CVT.PS.S operands

2012-08-27 Thread Stefan Hajnoczi
On Mon, Aug 27, 2012 at 9:53 AM, Richard Sandiford wrote: > The FS input to CVT.PS.S is the high half and FT is the low half. > tcg_gen_concat_i32_i64 takes the low half first, so the operands > were in the wrong order. > > Signed-off-by: Richard Sandiford > --- > target-mips/translate.c |2

Re: [Qemu-devel] [PATCH] [MIPS] Fix operands of RECIP2.S and RECIP2.PS

2012-08-27 Thread Stefan Hajnoczi
On Mon, Aug 27, 2012 at 9:50 AM, Richard Sandiford wrote: > Read the second input operand of RECIP2.S and RECIP2.PS from FT rather > than FD. RECIP2.D is already correct. > > Signed-off-by: Richard Sandiford > --- > target-mips/translate.c |4 ++-- > 1 files changed, 2 insertions(+), 2 dele

Re: [Qemu-devel] [PATCH] hw/pl110: Fix spelling of 'palette'

2012-08-27 Thread Peter Maydell
On 27 August 2012 06:19, Stefan Weil wrote: > Am 26.08.2012 23:30, schrieb Peter Maydell: > >> Fix the spelling of 'palette' used in various local variables >> and structure members. >> if (offset >= 0x200 && offset < 0x400) { >> /* Pallette. */ > > > What about this one? For V2 o

Re: [Qemu-devel] qcow2: online snasphots : internal vs external ?

2012-08-27 Thread Alexandre DERUMIER
Thanks again Stefan >>The snapshot only captures the contents of the disk. Rollback does >>not make sense without shutting down the guest. The OS/file system >>would be very confused if the disk contents changed underneath it. >>Existing hotplug can be used. For example, if we have an external >>

Re: [Qemu-devel] qcow2: online snasphots : internal vs external ?

2012-08-27 Thread Paolo Bonzini
Il 27/08/2012 11:26, Alexandre DERUMIER ha scritto: > how can I rollback to the point of the snapshot. > > exemple : > image1.qcow2 > file : /beforesnap1 > take a snaphot (snap1), so qemu switch to snap1.qcow2 > write some file: > file: > /aftersnap1. > /beforesnap1 > > Now, how can I ro

Re: [Qemu-devel] qcow2: online snasphots : internal vs external ?

2012-08-27 Thread Paolo Bonzini
Il 27/08/2012 11:04, Stefan Hajnoczi ha scritto: >> > Also I see that snapshot_blkdev qmp command give in his description: >> > "Otherwise the snapshot will be internal! (currently unsupported)." >> > >> > is Live internal snapshots on the roadmap ? > I'm not aware of anyone working on adding inter

Re: [Qemu-devel] [PATCH 2/2] mips-linux-user: Always support rdhwr.

2012-08-27 Thread Aurelien Jarno
On Fri, Mar 30, 2012 at 01:16:37PM -0400, Richard Henderson wrote: > The kernel will emulate this instruction if it's not supported > natively. This insn is used for TLS, among other things, and > so is required by modern glibc. > > Signed-off-by: Richard Henderson > Cc: Riku Voipio > --- > ta

Re: [Qemu-devel] [PATCH] [MIPS] Fix operands of RECIP2.S and RECIP2.PS

2012-08-27 Thread Aurelien Jarno
On Mon, Aug 27, 2012 at 09:50:38AM +0100, Richard Sandiford wrote: > Read the second input operand of RECIP2.S and RECIP2.PS from FT rather > than FD. RECIP2.D is already correct. > > Signed-off-by: Richard Sandiford > --- > target-mips/translate.c |4 ++-- > 1 files changed, 2 insertions(+

Re: [Qemu-devel] [PATCH] ATAPI: Add support for ASCQ in sense codes

2012-08-27 Thread Kevin Wolf
Am 31.07.2012 09:14, schrieb Paolo Bonzini: > Il 31/07/2012 04:07, Ronnie Sahlberg ha scritto: >> Add support for setting the ASCQ for SCSI sense codes in the ATAPI driver. >> Use this to set ASCQ==2 for the medium removal prevention that is >> recommended in MMC for this condition. >> >> asc:0x53

Re: [Qemu-devel] [PATCH] [MIPS] Fix order of CVT.PS.S operands

2012-08-27 Thread Aurelien Jarno
On Mon, Aug 27, 2012 at 09:53:29AM +0100, Richard Sandiford wrote: > The FS input to CVT.PS.S is the high half and FT is the low half. > tcg_gen_concat_i32_i64 takes the low half first, so the operands > were in the wrong order. > > Signed-off-by: Richard Sandiford > --- > target-mips/translate.

Re: [Qemu-devel] [PATCH 1/2] target-mips: Streamline indexed cp1 memory addressing.

2012-08-27 Thread Aurelien Jarno
On Fri, Mar 30, 2012 at 01:16:36PM -0400, Richard Henderson wrote: > We've already eliminated both base and index being zero. > --- > target-mips/translate.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/target-mips/translate.c b/target-mips/translate.c > index a

Re: [Qemu-devel] [PATCH] ATAPI: STARTSTOPUNIT only eject/load media if powercondition is 0

2012-08-27 Thread Kevin Wolf
Am 31.07.2012 03:28, schrieb Ronnie Sahlberg: > The START STOP UNIT command will only eject/load media if > power condition is zero. > > If power condition is !0 then LOEJ and START will be ignored. > > From MMC (sbc contains similar wordings too) > The Power Conditions field requests the block

[Qemu-devel] [PATCH] audio: previous audio buffer should be flushed

2012-08-27 Thread munkyu.im
*** BLURB HERE *** munkyu.im (1): audio: previous audio buffer should be flushed audio/winwaveaudio.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- 1.7.4.1

[Qemu-devel] [PATCH] audio: previous audio buffer should be flushed

2012-08-27 Thread munkyu.im
Buffer must be flushed when audio out is paused, but Winwave audio backend has problem with this unlike other backends. As a result, when user stop and restart audio files or something, the previous audio data are played in front of user expected sound. So changes it to waveOutReset() --- audio/

[Qemu-devel] [PATCH v2] hw/pl110: Fix spelling of 'palette'

2012-08-27 Thread Peter Maydell
Fix the spelling of 'palette' used in various local variables, structure members and comments. Signed-off-by: Peter Maydell Reviewed-by: Stefan Weil --- v1->v2 changes: fix a comment which I'd missed before because it wasn't all-lowercase (thanks Stefan). hw/pl110.c | 30 +

Re: [Qemu-devel] [PATCH] Add privilege level check to several Cop0 instructions.

2012-08-27 Thread Aurelien Jarno
On Sat, Sep 17, 2011 at 05:05:32PM -0700, Eric Johnson wrote: > The MIPS Architecture Verification Programs (AVPs) check privileged > instructions for the required privilege level. These changes are needed > to pass the AVP suite. > > Signed-off-by: Eric Johnson > --- > target-mips/translate.c

Re: [Qemu-devel] [PATCH] Allow microMIPS SWP and SDP to have RD equal to BASE.

2012-08-27 Thread Aurelien Jarno
On Sat, Sep 17, 2011 at 05:28:16PM -0700, Eric Johnson wrote: > The microMIPS SWP and SDP instructions do not modify GPRs. So their > behavior is well defined when RD equals BASE. The MIPS Architecture > Verification Programs (AVPs) check that they work as expected. This > is required for AVPs t

Re: [Qemu-devel] [RFC PATCH 0/9] qom: improve reference counting and hotplug

2012-08-27 Thread Andreas Färber
Am 27.08.2012 09:22, schrieb liu ping fan: > On Sun, Aug 26, 2012 at 11:51 PM, Anthony Liguori wrote: >> Right now, you need to pair up object_new with object_delete. This is >> impractical when using reference counting because we would like to ensure >> that >> object_unref() also frees memory

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-27 Thread Andreas Färber
Hi, Am 27.08.2012 08:28, schrieb Jan Kiszka: > From: Jan Kiszka > > This adds PCI device assignment for i386 targets using the classic KVM > interfaces. This version is 100% identical to what is being maintained > in qemu-kvm for several years and is supported by libvirt as well. It is > expecte

Re: [Qemu-devel] [RFC PATCH 0/9] qom: improve reference counting and hotplug

2012-08-27 Thread Paolo Bonzini
Il 27/08/2012 13:46, Andreas Färber ha scritto: >>> >> >>> >> Since link and child properties all hold references, in order to >>> >> actually free >>> >> an object, we need to break those links. User created devices end up as >>> >> children of a container. But child properties cannot be remove

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-27 Thread Jan Kiszka
On 2012-08-27 14:07, Andreas Färber wrote: > Hi, > > Am 27.08.2012 08:28, schrieb Jan Kiszka: >> From: Jan Kiszka >> >> This adds PCI device assignment for i386 targets using the classic KVM >> interfaces. This version is 100% identical to what is being maintained >> in qemu-kvm for several years

[Qemu-devel] [PATCHv2 0/4] migrate PV EOI MSR

2012-08-27 Thread Michael S. Tsirkin
It turns out PV EOI gets disabled after migration - until next guest reset. This is because we are missing code to actually migrate it. This patch fixes it up: it applies cleanly to qemu.git as well as qemu-kvm.git, so I think it's cleaner to apply it in qemu.git to keep diff to minimum. Note: the

[Qemu-devel] [PATCHv2 1/4] linux-headers: update to 3.6-rc3

2012-08-27 Thread Michael S. Tsirkin
Update linux-headers to version present in Linux 3.6-rc3. Header asm-x96_64/kvm_para.h update is needed for the new PV EOI feature. Signed-off-by: Michael S. Tsirkin --- linux-headers/asm-s390/kvm.h | 2 +- linux-headers/asm-s390/kvm_para.h | 2 +- linux-headers/asm-x86/kvm.h | 1 + l

[Qemu-devel] [PATCHv2 2/4] pc: refactor compat code

2012-08-27 Thread Michael S. Tsirkin
In preparation to adding PV EOI migration for 1.2, trivially refactor some some compat code to make it easier to add version specific cpuid tweaks. Signed-off-by: Michael S. Tsirkin --- hw/pc_piix.c | 44 1 file changed, 36 insertions(+), 8 deletions(

[Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-27 Thread Michael S. Tsirkin
In preparation for adding PV EOI support, disable PV EOI by default for 1.1 and older machine types, to avoid CPUID changing during migration. PV EOI can still be enabled/disabled by specifying it explicitly. Enable for 1.1 -M pc-1.1 -cpu kvm64,+kvm_pv_eoi Disable for 1.2 -M pc-1.2

[Qemu-devel] [PATCHv2 4/4] kvm: get/set PV EOI MSR

2012-08-27 Thread Michael S. Tsirkin
Support get/set of new PV EOI MSR, for migration. Add an optional section for MSR value - send it out in case MSR was changed from the default value (0). Signed-off-by: Michael S. Tsirkin --- target-i386/cpu.h | 1 + target-i386/kvm.c | 13 + target-i386/machine.c | 21 +

[Qemu-devel] [PATCH] Save/load PC speaker internal state

2012-08-27 Thread Pavel Dovgaluk
Save PC speaker state to remove differences between system states after saving the snapshot and after loading it again. This patch is needed for deterministic replay of the execution. Signed-off-by: Pavel Dovgalyuk --- hw/pcspk.c | 18 ++ 1 files changed, 18 insertions(+), 0 del

Re: [Qemu-devel] [PATCHv2 1/4] linux-headers: update to 3.6-rc3

2012-08-27 Thread Peter Maydell
On 27 August 2012 13:20, Michael S. Tsirkin wrote: > Update linux-headers to version present in Linux 3.6-rc3. > Header asm-x96_64/kvm_para.h update is needed for the new PV EOI > feature. > > Signed-off-by: Michael S. Tsirkin > --- > linux-headers/asm-s390/kvm.h | 2 +- > linux-headers/asm

Re: [Qemu-devel] [PATCHv2 1/4] linux-headers: update to 3.6-rc3

2012-08-27 Thread Jan Kiszka
On 2012-08-27 14:42, Peter Maydell wrote: > On 27 August 2012 13:20, Michael S. Tsirkin wrote: >> Update linux-headers to version present in Linux 3.6-rc3. >> Header asm-x96_64/kvm_para.h update is needed for the new PV EOI >> feature. >> >> Signed-off-by: Michael S. Tsirkin >> --- >> linux-head

Re: [Qemu-devel] [PATCH] Save/load PC speaker internal state

2012-08-27 Thread Peter Maydell
On 27 August 2012 13:21, Pavel Dovgaluk wrote: > Save PC speaker state to remove differences between system > states after saving the snapshot and after loading it again. > This patch is needed for deterministic replay of the execution. > > Signed-off-by: Pavel Dovgalyuk Hi Pavel; thanks for this

Re: [Qemu-devel] [PATCH 8/9] qdev: make qdev_set_parent_bus() just set a link property

2012-08-27 Thread Anthony Liguori
liu ping fan writes: > On Sun, Aug 26, 2012 at 11:51 PM, Anthony Liguori wrote: >> Also make setting the link to NULL break the bus link >> >> Signed-off-by: Anthony Liguori >> --- >> hw/qdev.c | 48 ++-- >> 1 files changed, 42 insertions(+), 6 del

Re: [Qemu-devel] qcow2: online snasphots : internal vs external ?

2012-08-27 Thread Alexandre DERUMIER
Ok, got it, Thanks Paolo ! - Mail original - De: "Paolo Bonzini" À: qemu-devel@nongnu.org Envoyé: Lundi 27 Août 2012 12:10:34 Objet: Re: [Qemu-devel] qcow2: online snasphots : internal vs external ? Il 27/08/2012 11:26, Alexandre DERUMIER ha scritto: > how can I rollback to the point o

Re: [Qemu-devel] [RFC PATCH 0/9] qom: improve reference counting and hotplug

2012-08-27 Thread Anthony Liguori
Paolo Bonzini writes: > Il 27/08/2012 13:46, Andreas Färber ha scritto: >> >> Since link and child properties all hold references, in order to >> actually free >> an object, we need to break those links. User created devices end up as >> children of a container. But ch

Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-08-27 Thread Anthony Liguori
Liu Ping Fan writes: > From: Liu Ping Fan > > Scene: > obja lies in objA, when objA's ref->0, it will be freed, > but at that time obja can still be in use. > > The real example is: > typedef struct PCIIDEState { > PCIDevice dev; > IDEBus bus[2]; --> create in place > . > } > >

Re: [Qemu-devel] [PATCH v7 0/6] convert sendkey to qapi

2012-08-27 Thread Luiz Capitulino
On Mon, 27 Aug 2012 15:23:31 +0800 Amos Kong wrote: > On 20/08/12 23:08, Luiz Capitulino wrote: > > On Mon, 20 Aug 2012 07:25:13 -0600 > > Eric Blake wrote: > > > >> On 08/19/2012 10:39 PM, Amos Kong wrote: > >>> This series converted 'sendkey' command to qapi. The raw value > >>> in hexadecimal

Re: [Qemu-devel] [PATCH 2/9] object: automatically free objects based on a release function

2012-08-27 Thread Andreas Färber
Am 26.08.2012 17:51, schrieb Anthony Liguori: > Now object_delete() simply has the semantics of unref'ing an object and > unparenting it. > > Signed-off-by: Anthony Liguori Acked-by: Andreas Färber /-F -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennife

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-27 Thread Anthony Liguori
malc writes: > On Thu, 23 Aug 2012, Matthew Ogilvie wrote: > >> After applying this version 2 of this patch series, I can >> successfully run "Micoport UNIX System V/386, v 2.1" (ca 1987) >> under qemu. (although not if I try to enable KVM) >> >> Version 1 of this series was posted about 4 week

Re: [Qemu-devel] [PATCH v2 6/6] i8259: add -no-spurious-interrupt-hack option

2012-08-27 Thread Anthony Liguori
Matthew Ogilvie writes: > This patch provides a way to optionally suppress spurious interrupts, > as a workaround for systems described below: > > Some old operating systems do not handle spurious interrupts well, > and qemu tends to generate them significantly more often than > real hardware. T

[Qemu-devel] [Bug 1042084] [NEW] Windows 7 guest cannot boot after seabios updated

2012-08-27 Thread Vic
Public bug reported: Hi, I can no longer boot my Windows 7 guest after this commit (update seabios to latest master) http://git.qemu.org/?p=qemu.git;a=commitdiff;h=01afdadc92e71e29700e64f3a5f42c1c543e3cf9 When I tried to boot Windows, it BSOD and said "The BIOS in this system is not fully ACPI

[Qemu-devel] [Bug 1036363] Re: Major network performance problems on AMD hardware

2012-08-27 Thread Ziemowit Pierzycki
Thank Stefan, I compiled both 0.15 and 1.0 and they do not have that problem... but Fedora package does. Perhaps the way Fedora package was compiled? I'm going to grab a source package and attempt to compile from that. -- You received this bug notification because you are a member of qemu- dev

Re: [Qemu-devel] [PATCH 3/9] qbus: remove glib_allocated/qom_allocated and use release hook to free memory

2012-08-27 Thread Andreas Färber
Am 26.08.2012 17:51, schrieb Anthony Liguori: > Signed-off-by: Anthony Liguori That's a really nice solution for cleaning this up, thanks! Acked-by: Andreas Färber However one conceptional detail... > --- > hw/pci.c|7 ++- > hw/qdev.c | 15 --- > hw/qdev.h |

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-27 Thread malc
On Mon, 27 Aug 2012, Anthony Liguori wrote: > malc writes: > > > On Thu, 23 Aug 2012, Matthew Ogilvie wrote: > > > >> After applying this version 2 of this patch series, I can > >> successfully run "Micoport UNIX System V/386, v 2.1" (ca 1987) > >> under qemu. (although not if I try to enable K

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-27 Thread Anthony Liguori
malc writes: > On Mon, 27 Aug 2012, Anthony Liguori wrote: > >> malc writes: >> >> > On Thu, 23 Aug 2012, Matthew Ogilvie wrote: >> > >> >> After applying this version 2 of this patch series, I can >> >> successfully run "Micoport UNIX System V/386, v 2.1" (ca 1987) >> >> under qemu. (although

Re: [Qemu-devel] [PATCH 3/9] qbus: remove glib_allocated/qom_allocated and use release hook to free memory

2012-08-27 Thread Anthony Liguori
Andreas Färber writes: > Am 26.08.2012 17:51, schrieb Anthony Liguori: >> Signed-off-by: Anthony Liguori > > That's a really nice solution for cleaning this up, thanks! > > Acked-by: Andreas Färber > > However one conceptional detail... > >> --- >> hw/pci.c|7 ++- >> hw/qdev.c |

Re: [Qemu-devel] [PATCH v2 6/6] i8259: add -no-spurious-interrupt-hack option

2012-08-27 Thread Paolo Bonzini
Il 27/08/2012 15:55, Anthony Liguori ha scritto: >> > This patch provides a way to optionally suppress spurious interrupts, >> > as a workaround for systems described below: >> > >> > Some old operating systems do not handle spurious interrupts well, >> > and qemu tends to generate them significant

Re: [Qemu-devel] [RFC 1/8] move qemu_irq typedef out of cpu-common.h

2012-08-27 Thread Igor Mammedov
- Original Message - > From: "Peter Maydell" ... > > I'm not objecting to this patch if it helps us move forwards, > but adding the #include to sysemu.h is effectively just adding > the definition to another grabbag header (183 files include > sysemu.h). It would be nicer long-term to sep

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-27 Thread malc
On Mon, 27 Aug 2012, Anthony Liguori wrote: > malc writes: > [..snip..] > > > > Number 2 was, and should stay, as the emulation wasn't correct before it, > > don't really care about the rest. > > Okay, please revert the rest then. > Done. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH 3/9] qbus: remove glib_allocated/qom_allocated and use release hook to free memory

2012-08-27 Thread Andreas Färber
Am 27.08.2012 16:22, schrieb Anthony Liguori: > Andreas Färber writes: > >> I wonder how this is gonna work: The device used to be in charge of >> tearing down its bus children ... now it neither deletes nor finalizes >> nor unrefs? Is the while loop even still needed? >> >> Wouldn't the busses s

Re: [Qemu-devel] [PATCHv2 1/4] linux-headers: update to 3.6-rc3

2012-08-27 Thread Michael S. Tsirkin
On Mon, Aug 27, 2012 at 01:42:03PM +0100, Peter Maydell wrote: > On 27 August 2012 13:20, Michael S. Tsirkin wrote: > > Update linux-headers to version present in Linux 3.6-rc3. > > Header asm-x96_64/kvm_para.h update is needed for the new PV EOI > > feature. > > > > Signed-off-by: Michael S. Tsir

Re: [Qemu-devel] [PATCHv2 1/4] linux-headers: update to 3.6-rc3

2012-08-27 Thread Michael S. Tsirkin
On Mon, Aug 27, 2012 at 02:48:57PM +0200, Jan Kiszka wrote: > On 2012-08-27 14:42, Peter Maydell wrote: > > On 27 August 2012 13:20, Michael S. Tsirkin wrote: > >> Update linux-headers to version present in Linux 3.6-rc3. > >> Header asm-x96_64/kvm_para.h update is needed for the new PV EOI > >> f

Re: [Qemu-devel] [PATCH] spice: increase the verbosity of spice section in "qemu --help"

2012-08-27 Thread Eric Blake
On 08/26/2012 12:38 AM, Yonit Halperin wrote: > On 08/21/2012 03:31 PM, Eric Blake wrote: >> On 08/21/2012 04:54 AM, Yonit Halperin wrote: >>> Added all spice options to the help string. This can be used by libvirt >>> to determine which spice related features are supported by qemu. >> >> For older

Re: [Qemu-devel] [PATCHv2 1/4] linux-headers: update to 3.6-rc3

2012-08-27 Thread Jan Kiszka
On 2012-08-27 16:53, Michael S. Tsirkin wrote: > On Mon, Aug 27, 2012 at 02:48:57PM +0200, Jan Kiszka wrote: >> On 2012-08-27 14:42, Peter Maydell wrote: >>> On 27 August 2012 13:20, Michael S. Tsirkin wrote: Update linux-headers to version present in Linux 3.6-rc3. Header asm-x96_64/kvm

[Qemu-devel] [RFC PATCH 01/13] nbd: add more constants

2012-08-27 Thread Paolo Bonzini
Avoid magic numbers and magic size computations; hide them behind #defines. Signed-off-by: Paolo Bonzini --- nbd.c | 17 ++--- 1 file modificato, 10 inserzioni(+), 7 rimozioni(-) diff --git a/nbd.c b/nbd.c index 0dd60c5..8201b7a 100644 --- a/nbd.c +++ b/nbd.c @@ -57,9 +57,12 @@ /

[Qemu-devel] [RFC PATCH 06/13] nbd: negotiate with named exports

2012-08-27 Thread Paolo Bonzini
Allow negotiation to receive the name of the requested export from the client. Passing a NULL export to nbd_client_new will cause the server to send the extended negotiation header. The exp field is then filled during negotiation. Signed-off-by: Paolo Bonzini --- nbd.c | 155 ++

[Qemu-devel] [RFC PATCH 09/13] qmp: add NBD server commands

2012-08-27 Thread Paolo Bonzini
Adding an NBD server inside QEMU is trivial, since all the logic is in nbd.c and can be shared easily between qemu-nbd and QEMU itself. The main difference is that qemu-nbd serves a single unnamed export, while QEMU serves named exports. Signed-off-by: Paolo Bonzini --- Makefile.objs| 2 +-

[Qemu-devel] [RFC PATCH 11/13] hmp: add NBD server commands

2012-08-27 Thread Paolo Bonzini
At the HMP level there is no nbd_server_add command. nbd_server_start automatically exposes all of the VM's block devices, and an option -w makes them writable. Signed-off-by: Paolo Bonzini --- hmp-commands.hx | 29 + hmp.c | 66

Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-08-27 Thread Jan Kiszka
On 2012-08-27 15:19, Anthony Liguori wrote: > Liu Ping Fan writes: > >> From: Liu Ping Fan >> >> Scene: >> obja lies in objA, when objA's ref->0, it will be freed, >> but at that time obja can still be in use. >> >> The real example is: >> typedef struct PCIIDEState { >> PCIDevice dev; >>

[Qemu-devel] [RFC PATCH 07/13] nbd: do not close BlockDriverState in nbd_export_close

2012-08-27 Thread Paolo Bonzini
This is not desirable when embedding the NBD server inside QEMU. Move the bdrv_close to qemu-nbd. Signed-off-by: Paolo Bonzini --- nbd.c | 1 - qemu-nbd.c | 1 + 2 file modificati, 1 inserzione(+). 1 rimozione(-) diff --git a/nbd.c b/nbd.c index fe7551d..1f65b1f 100644 --- a/nbd.c +++ b/nb

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-27 Thread Anthony Liguori
malc writes: > On Mon, 27 Aug 2012, Anthony Liguori wrote: > >> malc writes: >> > > [..snip..] > >> > >> > Number 2 was, and should stay, as the emulation wasn't correct before it, >> > don't really care about the rest. >> >> Okay, please revert the rest then. >> > > Done. Thank you! Regard

Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-08-27 Thread Anthony Liguori
Jan Kiszka writes: > On 2012-08-27 15:19, Anthony Liguori wrote: >> Liu Ping Fan writes: >> >>> From: Liu Ping Fan >>> >>> Scene: >>> obja lies in objA, when objA's ref->0, it will be freed, >>> but at that time obja can still be in use. >>> >>> The real example is: >>> typedef struct PCIIDE

Re: [Qemu-devel] [PATCH 4/9] object: remove object_finalize

2012-08-27 Thread Andreas Färber
Am 26.08.2012 17:51, schrieb Anthony Liguori: > Callers should just use object_unref > > Signed-off-by: Anthony Liguori > --- > hw/qdev.c |4 > include/qemu/object.h |9 - > qom/object.c |2 +- > 3 files changed, 1 insertions(+), 14 deletions(-) > >

Re: [Qemu-devel] [PATCH 10/10] qdev: fix create in place obj's life cycle problem

2012-08-27 Thread Jan Kiszka
On 2012-08-27 17:14, Anthony Liguori wrote: > Jan Kiszka writes: > >> On 2012-08-27 15:19, Anthony Liguori wrote: >>> Liu Ping Fan writes: >>> From: Liu Ping Fan Scene: obja lies in objA, when objA's ref->0, it will be freed, but at that time obja can still be in use.

[Qemu-devel] [RFC PATCH 13/13] nbd: add notifier to close exports when the image is closed

2012-08-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- blockdev-nbd.c | 38 ++ qapi/opts-visitor.c | 48 2 file modificati, 58 inserzioni(+), 28 rimozioni(-) diff --git a/blockdev-nbd.c b/blockdev-nbd.c index 5a415be..c190caa 10

[Qemu-devel] [RFC PATCH 04/13] nbd: close all clients on deleting export

2012-08-27 Thread Paolo Bonzini
Clients have a pointer to the NBDExport that they serve. Do not let a dangling pointer escape. Also flush all pending I/O so that coroutines are forced to exit. Signed-off-by: Paolo Bonzini --- nbd.c | 14 ++ 1 file modificato, 14 inserzioni(+) diff --git a/nbd.c b/nbd.c index cb4

[Qemu-devel] [RFC PATCH 02/13] nbd: pass NBDClient to nbd_send_negotiate

2012-08-27 Thread Paolo Bonzini
We will need the NBDClient in nbd_send_negotiate to store the export requested by the client. Signed-off-by: Paolo Bonzini --- nbd.c | 76 --- 1 file modificato, 41 inserzioni(+), 35 rimozioni(-) diff --git a/nbd.c b/nbd.c index 82

[Qemu-devel] [RFC PATCH 05/13] nbd: register named exports

2012-08-27 Thread Paolo Bonzini
Add an API to register and find named exports. Signed-off-by: Paolo Bonzini --- nbd.c | 38 ++ nbd.h | 3 +++ 2 file modificati, 41 inserzioni(+) diff --git a/nbd.c b/nbd.c index f6eaea3..1249548 100644 --- a/nbd.c +++ b/nbd.c @@ -90,13 +90,17 @@ struct NBDR

[Qemu-devel] [RFC PATCH 12/13] block: add close notifiers

2012-08-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Makefile.objs | 3 ++- block.c | 19 ++- block.h | 1 + block_int.h | 2 ++ 4 file modificati, 19 inserzioni(+), 6 rimozioni(-) diff --git a/Makefile.objs b/Makefile.objs index c42affc..8321f81 100644 --- a/Makefile.objs +++ b/Mak

[Qemu-devel] [RFC PATCH 03/13] nbd: do not leak nbd_trip coroutines when a connection is torn down

2012-08-27 Thread Paolo Bonzini
Because nbd_client_close removes the I/O handlers for the client socket, there is no way that any suspended coroutines are restarted. This will be a problem with the QEMU embedded NBD server, because we will have a QMP command to forcibly close all connections with the clients. Instead, we can exp

Re: [Qemu-devel] [PATCH for-1.2] linux-user: Clarify "Unable to reserve guest address space" error

2012-08-27 Thread Peter Maydell
Ping^2 since rc2 is just around the corner. thanks -- PMM On 23 August 2012 17:15, Peter Maydell wrote: > Ping! This didn't get into rc1. > > thanks > -- PMM > > On 20 August 2012 11:36, Peter Maydell wrote: >> Now that we default to reserving nearly 4GB of RAM for the guest >> address space wh

[Qemu-devel] [RFC PATCH 10/13] qemu-sockets: make inet_parse public

2012-08-27 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qemu-sockets.c | 2 +- qemu_socket.h | 1 + 2 file modificati, 2 inserzioni(+). 1 rimozione(-) diff --git a/qemu-sockets.c b/qemu-sockets.c index b292311..7a28715 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -407,7 +407,7 @@ err: } /* compatibility wr

[Qemu-devel] [Bug 1036363] Re: Major network performance problems on AMD hardware

2012-08-27 Thread Ziemowit Pierzycki
Okay, looks like the performance issue started with introduction of pc-0.15 machine profile in version 1.0.1. I'll narrow the problem down further. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/10363

[Qemu-devel] [RFC PATCH 08/13] qemu-sockets: publish dummy_opts

2012-08-27 Thread Paolo Bonzini
This is needed so that we can set up a QemuOpts instance from QMP parameters. The way to go here is to and move qemu-sockets.c away from QemuOpts and use Laszlo's QemuOptsVisitor whenever *_opts functions are called now. This can be done later, however. Signed-off-by: Paolo Bonzini --- qemu-so

  1   2   >