[Qemu-devel] buildbot failure in qemu on ppc-next_x86_64_debian_6_0

2012-08-16 Thread qemu
The Buildbot has detected a new failure on builder ppc-next_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/ppc-next_x86_64_debian_6_0/builds/361 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuk

[Qemu-devel] qemu log function to print out the registers of the guest

2012-08-16 Thread Steven
Hi, I would like to is there any function that could log the register content of the guest machine, like "info registers" in the qemu monitor mode. Thanks. steven

[Qemu-devel] Proper usage of qemu_get_clock_*

2012-08-16 Thread Марк Коренберг
Hello! I'm looking at some places in qemu and saw that some code calculate next timer alarm (for qemu_mod_timer) use qemu_get_clock_* and specify specific timer, like vm_timer. I think, that it's more clean is to use timer's clock instead of hardcoded clock. For example, instead of qemu_mod_time

[Qemu-devel] Timers speedup

2012-08-16 Thread Марк Коренберг
Hello. Please advice me how I can speed up all timers inside VM. I mean patch for qemu that will tick all timers, say, twice as faster. So I expect, that time in VM will go twice as fast, "sleep 1" command will last 0.5 real seconds, real time clocks will be twice as faster, TCP timeouts will be p

Re: [Qemu-devel] Does Qemu simulate the softmmu for memory data access?

2012-08-16 Thread Wei-Ren Chen
Hi, > I tried to trace the quest memory access for the load instructions. > However, it seems that the softmmu of qemu only works when qemu > fetches the guest code, like ldub_code? > Is there any place that will call the softmmu for quest memory access, > like ldub_data? Thanks. You can take a

[Qemu-devel] buildbot failure in qemu on s390-next_x86_64_debian_6_0

2012-08-16 Thread qemu
The Buildbot has detected a new failure on builder s390-next_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/s390-next_x86_64_debian_6_0/builds/362 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuz

Re: [Qemu-devel] [PATCH] block-migration: deprecate block migration for the 1.2 release

2012-08-16 Thread Ruben Kerkhof
Hi Stefan, Thanks for your explanation. On Wed, Aug 15, 2012 at 2:38 PM, Stefan Hajnoczi wrote: > I think when classic block migration is removed for good it should be > just as easy to use through libvirt using TCP because that's still a > valid use case and probably the simplest one to get sta

[Qemu-devel] Apparent USB assignment issue on 1.1+

2012-08-16 Thread Michael Tokarev
Hello. This issue has been reported several times already, but I can't reproduce it locally. Gerd, can you please take a look, maybe you may ask better question to the OP(s) about what to try. https://bugs.launchpad.net/qemu/+bug/1033727 http://bugs.debian.org/683983 Gerd, I tried to catch you

[Qemu-devel] buildbot failure in qemu on s390-next_i386_debian_6_0

2012-08-16 Thread qemu
The Buildbot has detected a new failure on builder s390-next_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/s390-next_i386_debian_6_0/builds/362 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

Re: [Qemu-devel] [Qemu-trivial] [PATCH] srp: Don't use QEMU_PACKED for single elements of a structured type

2012-08-16 Thread Stefan Hajnoczi
On Wed, Aug 15, 2012 at 05:59:26PM +0200, Stefan Weil wrote: > Am 15.08.2012 16:16, schrieb Stefan Hajnoczi: > >On Fri, Aug 10, 2012 at 10:03:27PM +0200, Stefan Weil wrote: > >>QEMU_PACKED results in a MinGW compiler warning when it is > >>used for single structure elements: > >> > >>warning: 'gcc_

Re: [Qemu-devel] qemu log function to print out the registers of the guest

2012-08-16 Thread Wei-Ren Chen
> I would like to is there any function that could log the register > content of the guest machine, like "info registers" in the qemu > monitor mode. Why not check how "info registes" be implemented in QEMU? ;) I guess you just have to log env->regs or something like that. Regards, chenwj --

Re: [Qemu-devel] Apparent USB assignment issue on 1.1+

2012-08-16 Thread Gerd Hoffmann
On 08/16/12 09:45, Michael Tokarev wrote: > Hello. > > This issue has been reported several times already, > but I can't reproduce it locally. Gerd, can you > please take a look, maybe you may ask better > question to the OP(s) about what to try. > > https://bugs.launchpad.net/qemu/+bug/1033727

[Qemu-devel] [PATCH 0/4] add support for spice migration

2012-08-16 Thread Yonit Halperin
The following series introduces support for keeping the spice session active after migration. For more details about spice seamless migration, see http://lists.freedesktop.org/archives/spice-devel/2012-August/010412.html Spice branches with seamless migration support can be found at: spice-protoc

[Qemu-devel] [PATCH 1/4] spice: notify spice server on vm start/stop

2012-08-16 Thread Yonit Halperin
Spice server needs to know about the vm state in order to prevent attempts to write to devices when they are stopped, mainly during the non-live stage of migration. Instead, spice will take care of restoring this writes, on the migration target side, after migration completes. Signed-off-by: Yonit

[Qemu-devel] [PATCH 4/4] spice: adding seamless-migration option to the command line

2012-08-16 Thread Yonit Halperin
The seamless-migration flag is required in order to identify whether libvirt supports the new QEVENT_SPICE_MIGRATE_COMPLETED or not (by default the flag is off). New libvirt versions that wait for QEVENT_SPICE_MIGRATE_COMPLETED should turn on this flag. When this flag is off, spice fallbacks to it

Re: [Qemu-devel] Apparent USB assignment issue on 1.1+

2012-08-16 Thread Peter Maydell
On 16 August 2012 09:14, Gerd Hoffmann wrote: > On 08/16/12 09:45, Michael Tokarev wrote: >> This issue has been reported several times already, >> but I can't reproduce it locally. Gerd, can you >> please take a look, maybe you may ask better >> question to the OP(s) about what to try. >> >> htt

[Qemu-devel] [PATCH 3/4] spice: add 'migrated' flag to spice info

2012-08-16 Thread Yonit Halperin
The flag is 'true' when spice migration has completed on the src side. It is needed for a case where libvirt dies before migration completes and it misses the event QEVENT_SPICE_MIGRATE_COMPLETED. When libvirt is restored and queries the migration status, it also needs to query spice and check if i

Re: [Qemu-devel] Apparent USB assignment issue on 1.1+

2012-08-16 Thread Michael Tokarev
On 16.08.2012 12:14, Gerd Hoffmann wrote: > On 08/16/12 09:45, Michael Tokarev wrote: >> Hello. >> >> This issue has been reported several times already, >> but I can't reproduce it locally. Gerd, can you >> please take a look, maybe you may ask better >> question to the OP(s) about what to try. >

[Qemu-devel] [PATCH 2/4] spice migration: add QEVENT_SPICE_MIGRATE_COMPLETED

2012-08-16 Thread Yonit Halperin
When migrating, libvirt queries the migration status, and upon migration completions, it closes the migration src. On the other hand, when migration is completed, spice transfers data from the src to destination via the client. This data is required for keeping the spice session after migration, wi

Re: [Qemu-devel] Apparent USB assignment issue on 1.1+

2012-08-16 Thread Michael Tokarev
On 16.08.2012 12:23, Peter Maydell wrote: > On 16 August 2012 09:14, Gerd Hoffmann wrote: [] >>> http://bugs.debian.org/683983 >> >> No idea, must be some QOM thingy. This was http://bugs.debian.org/684282, unrelated to usb. > The "crash on usb_del" problem has been discussed on the list > befor

[Qemu-devel] [PATCH 0/2] vmdk: Fix streamOptimized images

2012-08-16 Thread Kevin Wolf
The other day someone turned up in IRC with a VMDK image [1] that can't be converted (or even read). We found the problem, discussed the fix and the reporter promised to send a fix. Well, he didn't in almost a month, so here's my fix. This was reported as https://bugs.launchpad.net/qemu/+bug/10289

[Qemu-devel] [PATCH 2/2] vmdk: Read footer for streamOptimized images

2012-08-16 Thread Kevin Wolf
The footer takes precedence over the header when it exists. It contains the real grain directory offset that is missing in the header. Without this patch, streamOptimized images with a footer cannot be read. Signed-off-by: Kevin Wolf --- block/vmdk.c | 16 1 files changed, 16

[Qemu-devel] [PATCH 1/2] vmdk: Fix header structure

2012-08-16 Thread Kevin Wolf
Commit bb45ded9 swapped gd_offset and rgd_offset. This is wrong. Signed-off-by: Kevin Wolf --- block/vmdk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index daee426..9648398 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -57,8 +57,8 @@

[Qemu-devel] [PATCH for-1.2] virtio-blk: hide VIRTIO_BLK_F_CONFIG_WCE from old machine types

2012-08-16 Thread Stefan Hajnoczi
QEMU has a policy of keeping a stable guest device ABI. When new guest device features are introduced they must not change hardware info seen by existing guests. This is important because operating systems or applications may "fingerprint" the hardware and refuse to run when the hardware changes.

[Qemu-devel] [PATCH] Documentation: Warn against qemu-img on active image

2012-08-16 Thread Kevin Wolf
People have repeatedly expected that you can do things like snapshotting an image with qemu-img while a qemu instance is running. Maybe we need to consider locking the files while they are in use, but having a warning in the qemu-img manpage is doable for 1.2 and can't hurt anyway. Signed-off-by:

[Qemu-devel] [RESEND][PATCH for 1.2] audio: Make pcspk card selectable again

2012-08-16 Thread Jan Kiszka
Since we moved pcspk into hwlib, CONFIG_PCSPK is no longer defined per target. Therefore, statically built soundhw array in arch_init.c stopped including this card. Work around this by re-adding this define to config-target.mak. Long-term, a dynamic creation of this soundhw list will be necessary.

Re: [Qemu-devel] [PATCH for-1.2] virtio-blk: hide VIRTIO_BLK_F_CONFIG_WCE from old machine types

2012-08-16 Thread Kevin Wolf
Am 16.08.2012 10:57, schrieb Stefan Hajnoczi: > QEMU has a policy of keeping a stable guest device ABI. When new guest device > features are introduced they must not change hardware info seen by existing > guests. This is important because operating systems or applications may > "fingerprint" the

Re: [Qemu-devel] [PATCH for-1.2] virtio-blk: hide VIRTIO_BLK_F_CONFIG_WCE from old machine types

2012-08-16 Thread Stefan Hajnoczi
On Thu, Aug 16, 2012 at 10:07 AM, Kevin Wolf wrote: > Am 16.08.2012 10:57, schrieb Stefan Hajnoczi: >> QEMU has a policy of keeping a stable guest device ABI. When new guest >> device >> features are introduced they must not change hardware info seen by existing >> guests. This is important bec

Re: [Qemu-devel] [PATCH 2/2] vmdk: Read footer for streamOptimized images

2012-08-16 Thread Stefan Hajnoczi
On Thu, Aug 16, 2012 at 9:54 AM, Kevin Wolf wrote: > The footer takes precedence over the header when it exists. It contains > the real grain directory offset that is missing in the header. Without > this patch, streamOptimized images with a footer cannot be read. > > Signed-off-by: Kevin Wolf >

[Qemu-devel] Slow inbound traffic on macvtap interfaces

2012-08-16 Thread Chris Webb
I'm experiencing a problem with qemu + macvtap which I can reproduce on a variety of hardware, with kernels varying from 3.0.4 (the oldest I tried) to 3.5.1 and with qemu[-kvm] versions 0.14.1, 1.0, and 1.1. Large data transfers over TCP into a guest from another machine on the network are very sl

Re: [Qemu-devel] memory: could we add extra input param for memory_region_init_io()?

2012-08-16 Thread Avi Kivity
On 08/16/2012 06:22 AM, liu ping fan wrote: > On Tue, Aug 14, 2012 at 6:49 PM, Avi Kivity wrote: >> On 08/14/2012 11:30 AM, liu ping fan wrote: >>> To make memoryRegion survive without the protection of qemu big lock, >>> we need to pin its based Object. >>> In current code, the type of mr->opaque

Re: [Qemu-devel] QEMU 1.2 Test Day - August 16 2012

2012-08-16 Thread Stefan Hajnoczi
On Tue, Aug 14, 2012 at 2:37 PM, Stefan Hajnoczi wrote: > On Thu, Aug 2, 2012 at 1:22 PM, Stefan Hajnoczi wrote: >> I have set up the QEMU 1.2 Testing wiki page and suggest August 16 as >> the Test Day: >> >> http://wiki.qemu.org/Planning/1.2/Testing > > QEMU 1.2 Test Day is only 2 days away! > >

[Qemu-devel] What is the cause of -net socket, mcast bad performance?

2012-08-16 Thread Марк Коренберг
Hello. On my PC, tap <--> bridge <--> tap networking gives 600 megbit. Exactly the same, but -net socket,mcast gives about 1 megbit (!) I do not understand why. In my mind, -net socket,mcast is the same as tap, but ethernet frames are going in much simplier way: instead of qemu1 -> /dev/tun ->

Re: [Qemu-devel] [PATCH 1/4] spice: notify spice server on vm start/stop

2012-08-16 Thread Gerd Hoffmann
On 08/16/12 10:23, Yonit Halperin wrote: > Spice server needs to know about the vm state in order to prevent > attempts to write to devices when they are stopped, mainly during > the non-live stage of migration. Why this new hook? qemu already notifies spice-server using QXLWorker start/stop call

[Qemu-devel] [PATCH v2 2/2] vmdk: Read footer for streamOptimized images

2012-08-16 Thread Kevin Wolf
The footer takes precedence over the header when it exists. It contains the real grain directory offset that is missing in the header. Without this patch, streamOptimized images with a footer cannot be read. Signed-off-by: Kevin Wolf --- v2: - Enough footer sanity checks, I hope? :-) block/vmdk

Re: [Qemu-devel] [PATCH] Documentation: Warn against qemu-img on active image

2012-08-16 Thread Peter Maydell
On 16 August 2012 10:00, Kevin Wolf wrote: > People have repeatedly expected that you can do things like snapshotting > an image with qemu-img while a qemu instance is running. Maybe we need > to consider locking the files while they are in use, but having a > warning in the qemu-img manpage is do

Re: [Qemu-devel] [PATCH v2 2/2] vmdk: Read footer for streamOptimized images

2012-08-16 Thread Stefan Hajnoczi
On Thu, Aug 16, 2012 at 10:50 AM, Kevin Wolf wrote: > The footer takes precedence over the header when it exists. It contains > the real grain directory offset that is missing in the header. Without > this patch, streamOptimized images with a footer cannot be read. > > Signed-off-by: Kevin Wolf >

Re: [Qemu-devel] [PATCH 13/18] qapi: Convert savevm

2012-08-16 Thread Pavel Hrdina
On 08/15/2012 09:49 PM, Eric Blake wrote: On 08/15/2012 01:41 AM, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina --- I'm focusing my review more on the public interface (since that's what affects libvirt), and therefore glanced through 1 through 12 but did not pay close attention to them.

Re: [Qemu-devel] [PATCH 16/18] qapi: Convert info snapshots

2012-08-16 Thread Pavel Hrdina
On 08/16/2012 06:36 AM, Eric Blake wrote: On 08/15/2012 01:41 AM, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina --- hmp.c| 33 + hmp.h| 1 + monitor.c| 2 +- qapi-schema.json | 34 ++ qmp-co

Re: [Qemu-devel] What is the cause of -net socket, mcast bad performance?

2012-08-16 Thread Stefan Hajnoczi
On Thu, Aug 16, 2012 at 10:38 AM, Марк Коренберг wrote: > On my PC, tap <--> bridge <--> tap networking gives 600 megbit. > > Exactly the same, but -net socket,mcast gives about 1 megbit (!) I do not > understand why. > > In my mind, -net socket,mcast is the same as tap, but ethernet frames are >

Re: [Qemu-devel] [PATCH 18/18] vm-snapshot-save: add force parameter

2012-08-16 Thread Pavel Hrdina
On 08/16/2012 07:00 AM, Eric Blake wrote: On 08/15/2012 01:41 AM, Pavel Hrdina wrote: HMP command "savevm" now takes extra optional force parameter to specifi whether s/specifi/specify/ replace existing snapshot or not. QMP command "vm-snapshot-save" has also extra optional force parameter a

Re: [Qemu-devel] [PATCH] pseries: Instantiate USB interface when required

2012-08-16 Thread Alexander Graf
On 16.08.2012, at 04:03, David Gibson wrote: > The pseries machine already supports the -vga std option, creating a > graphics adapter. However, this is not very useful without being able to > add a keyboard and mouse as well. This patch addresses this by adding > a USB interface when requested

[Qemu-devel] Windows slow boot: contractor wanted

2012-08-16 Thread Richard Davies
Hi, We run a cloud hosting provider using qemu-kvm 1.1, and are keen to find a contractor to track down and fix problems we have with large memory Windows guests booting very slowly - they can take several hours. We previously reported these problems in July (copied below) and they are still pres

[Qemu-devel] [PATCH for-1.2 3/4] ehci: fix Interrupt Threshold Control implementation

2012-08-16 Thread Gerd Hoffmann
First, not all interrupts are subject to Interrupt Threshold Control, some of them must be delivered without delay. Second, Interrupt Threshold Control state must be part of vmstate, otherwise we might loose IRQs on migration. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 12 ++

[Qemu-devel] [PATCH for-1.2 2/4] usb: update uas product id

2012-08-16 Thread Gerd Hoffmann
Pick other product id to fix clash with audio. Current usage list (after applying this patch): 46f4:0001 -- usb-storage 46f4:0002 -- usb-audio 46f4:0003 -- usb-uas Signed-off-by: Gerd Hoffmann --- hw/usb/dev-uas.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb

[Qemu-devel] [PATCH for-1.2] osdep: Fix compilation failure on BSD systems

2012-08-16 Thread Peter Maydell
Fix compilation failure on BSD systems (which don't have O_DIRECT or O_NOATIME: osdep.c:116: error: ‘O_DIRECT’ undeclared (first use in this function) osdep.c:116: error: (Each undeclared identifier is reported only once osdep.c:116: error: for each function it appears in.) osdep.c:116: error: ‘O_N

[Qemu-devel] [PULL for-1.2 0/4] usb bugfix patch queue

2012-08-16 Thread Gerd Hoffmann
Hi, USB patch queue, carrying some bugfixes for qemu 1.2. please pull, Gerd Gerd Hoffmann (3): usb: async control xfer fixup usb: update uas product id ehci: fix Interrupt Threshold Control implementation Hans de Goede (1): ehci: Fix setting of halt bit from usbcmd register updates

[Qemu-devel] Trouble with pc_system_firmware_init()

2012-08-16 Thread Markus Armbruster
I noticed a few things I'd like to discuss. 0. pc_fw_add_pflash_drv() lacks error checking, patch coming. 1. Watch this: $ qemu-system-x86_64 -nodefaults -S -vnc :0 -bios /dev/null Bad ram offset 800 Aborted (core dumped) Backtrace: #0 0x003b0de35925 in raise () fro

[Qemu-devel] [PATCH for-1.2 1/4] usb: async control xfer fixup

2012-08-16 Thread Gerd Hoffmann
Need to clear p->result after copying setup data using usb_packet_copy() because we'll reuse the USBPacket for the data transfer. Signed-off-by: Gerd Hoffmann --- hw/usb/core.c |1 + hw/usb/host-linux.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/usb/cor

Re: [Qemu-devel] [PATCH 1/2] extract file_load() function from rom_add_file() for reusing

2012-08-16 Thread Avi Kivity
On 08/16/2012 02:13 PM, Yin Olivia-R63875 wrote: > Hi Avi & Ben, > > I've got feedback from qemu-ppc list and revised this patch according to > Blue's comments. > Could you please give any comments? I don't really have any comments, those files are outside my area of expertise. They look okay

[Qemu-devel] [PATCH for-1.2 4/4] ehci: Fix setting of halt bit from usbcmd register updates

2012-08-16 Thread Gerd Hoffmann
From: Hans de Goede This fixes linux guests started without any USB devices not seeing newly plugged devices until "lsusb" is done inside the guest. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 15 --- 1 files changed, 8 insertions(+), 7 dele

Re: [Qemu-devel] [PATCH 1/2] extract file_load() function from rom_add_file() for reusing

2012-08-16 Thread Peter Maydell
On 14 August 2012 08:49, Olivia Yin wrote: > Sanity check in rom_add_file() could be reused by other image loaders. > > Signed-off-by: Olivia Yin > --- > This patch is based on branch 'ppc-next' of Alex's upstream QEMU repo: > http://repo.or.cz/r/qemu/agraf.git > > hw/loader.c | 61 +++

Re: [Qemu-devel] Windows slow boot: contractor wanted

2012-08-16 Thread Avi Kivity
On 08/16/2012 01:47 PM, Richard Davies wrote: > Hi, > > We run a cloud hosting provider using qemu-kvm 1.1, and are keen to find a > contractor to track down and fix problems we have with large memory Windows > guests booting very slowly - they can take several hours. > > We previously reported t

[Qemu-devel] [PATCH 0/2] Fix two buggy pc_sysfw error paths

2012-08-16 Thread Markus Armbruster
Markus Armbruster (2): pc_sysfw: Check for qemu_find_file() failure pc_sysfw: Plug memory leak on pc_fw_add_pflash_drv() error path hw/pc_sysfw.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) -- 1.7.11.2

[Qemu-devel] [PATCH 1/2] pc_sysfw: Check for qemu_find_file() failure

2012-08-16 Thread Markus Armbruster
pc_fw_add_pflash_drv() ignores qemu_find_file() failure, and happily creates a drive without a medium. When pc_system_flash_init() asks for its size, bdrv_getlength() fails with -ENOMEDIUM, which isn't checked either. It fails relatively cleanly only because -ENOMEDIUM isn't a multiple of 4096:

Re: [Qemu-devel] Slow inbound traffic on macvtap interfaces

2012-08-16 Thread Michael S. Tsirkin
On Thu, Aug 16, 2012 at 10:20:05AM +0100, Chris Webb wrote: > I'm experiencing a problem with qemu + macvtap which I can reproduce on a > variety of hardware, with kernels varying from 3.0.4 (the oldest I tried) to > 3.5.1 and with qemu[-kvm] versions 0.14.1, 1.0, and 1.1. > > Large data transfers

[Qemu-devel] [PATCH 2/2] pc_sysfw: Plug memory leak on pc_fw_add_pflash_drv() error path

2012-08-16 Thread Markus Armbruster
Harmless, because we the error inevitably leads to another, fatal one in pc_system_flash_init(): PC system firmware (pflash) not available. Fix it anyway. Signed-off-by: Markus Armbruster --- hw/pc_sysfw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/pc_sysfw.c b/hw/

Re: [Qemu-devel] [PATCH 17/23] mips_malta mips_r4k: Suppress unused default drives

2012-08-16 Thread Stefan Weil
Am 09.08.2012 15:31, schrieb Markus Armbruster: Cc: Aurelien Jarno Suppress default SD card drive for machines malta, mips. Suppress default floppy drive for machine mips. Signed-off-by: Markus Armbruster --- hw/mips_malta.c | 1 + hw/mips_r4k.c | 2 ++ 2 files changed, 3 insertions(+)

Re: [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need (v2)

2012-08-16 Thread Stefan Weil
Am 15.08.2012 18:53, schrieb Luiz Capitulino: On Wed, 15 Aug 2012 08:07:57 +0200 Stefan Weil wrote: Am 13.08.2012 19:16, schrieb Luiz Capitulino: On Fri, 10 Aug 2012 11:04:08 -0500 Anthony Liguori wrote: This series implements the necessary commands to implements danpb's idea to remove -he

Re: [Qemu-devel] [PATCH v2 for-1.2 00/27] Suppress unused default drives

2012-08-16 Thread Peter Maydell
On 15 August 2012 20:36, Peter Maydell wrote: > I also think we should follow up Paul Brook's suggestion > that we don't need to have any kind of "default sd card" flag > at all. Floppy is weird because we don't properly separate out > the drive and the controller, right? Not sure about cdrom...

Re: [Qemu-devel] [PATCH for-1.2] osdep: Fix compilation failure on BSD systems

2012-08-16 Thread Stefan Weil
Am 16.08.2012 13:15, schrieb Peter Maydell: Fix compilation failure on BSD systems (which don't have O_DIRECT or O_NOATIME: osdep.c:116: error: ‘O_DIRECT’ undeclared (first use in this function) osdep.c:116: error: (Each undeclared identifier is reported only once osdep.c:116: error: for each fun

Re: [Qemu-devel] [PATCH] Fix spelling (licenced -> licensed) in GPL

2012-08-16 Thread Stefan Weil
Ping? Am 10.08.2012 22:03, schrieb Stefan Weil: The patch also fixes the case of "written". Signed-off-by: Stefan Weil --- hw/imx_avic.c |4 ++-- hw/imx_timer.c |4 ++-- hw/kzm.c |2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/imx_avic.c b/hw/im

Re: [Qemu-devel] [PATCH] Spelling fixes in comments and documentation

2012-08-16 Thread Stefan Weil
Ping? Am 10.08.2012 22:03, schrieb Stefan Weil: These wrong spellings were detected by codespell: * successully -> successfully * alot -> a lot * wanna -> want to * infomation -> information * occured -> occurred Signed-off-by: Stefan Weil --- docs/specs/ppc-spapr-hcalls.txt |2 +-

Re: [Qemu-devel] [PATCH for-1.2] osdep: Fix compilation failure on BSD systems

2012-08-16 Thread Peter Maydell
On 16 August 2012 13:27, Stefan Weil wrote: > Am 16.08.2012 13:15, schrieb Peter Maydell: > >> Fix compilation failure on BSD systems (which don't have >> O_DIRECT or O_NOATIME: >> osdep.c:116: error: ‘O_DIRECT’ undeclared (first use in this function) >> osdep.c:116: error: (Each undeclared identi

Re: [Qemu-devel] [PATCH] Spelling fixes in comments and documentation

2012-08-16 Thread Peter Maydell
On 10 August 2012 21:03, Stefan Weil wrote: > diff --git a/docs/usb2.txt b/docs/usb2.txt > index d17e3c0..21f6d14 100644 > --- a/docs/usb2.txt > +++ b/docs/usb2.txt > @@ -58,11 +58,11 @@ try ... > xhci controller support > --- > > -There also is xhci host controller support a

Re: [Qemu-devel] [PATCH] Documentation: Warn against qemu-img on active image

2012-08-16 Thread Eric Blake
On 08/16/2012 04:00 AM, Peter Maydell wrote: > On 16 August 2012 10:00, Kevin Wolf wrote: >> People have repeatedly expected that you can do things like snapshotting >> an image with qemu-img while a qemu instance is running. Maybe we need >> to consider locking the files while they are in use, S

Re: [Qemu-devel] [RFC 0/7] Migration stats

2012-08-16 Thread Qunfang Zhang
Hi, Juan I have a brief test with these patches applied and it's very useful. It's more precise and time-saving than calculate it with some other method for the downtime,etc. Thank you, Qunfang On 08/13/2012 06:50 PM, Juan Quintela wrote: Hi This modifies the output of info migrate/qmp_que

Re: [Qemu-devel] [PATCH 1/2] extract file_load() function from rom_add_file() for reusing

2012-08-16 Thread Yin Olivia-R63875
Hi Avi & Ben, I've got feedback from qemu-ppc list and revised this patch according to Blue's comments. Could you please give any comments? Best Regards, Olivia > -Original Message- > From: Yin Olivia-R63875 > Sent: Tuesday, August 14, 2012 3:50 PM > To: qemu-...@nongnu.org; qemu-devel

Re: [Qemu-devel] [PATCH 1/4] spice: notify spice server on vm start/stop

2012-08-16 Thread Yonit Halperin
On 08/16/2012 12:42 PM, Gerd Hoffmann wrote: On 08/16/12 10:23, Yonit Halperin wrote: Spice server needs to know about the vm state in order to prevent attempts to write to devices when they are stopped, mainly during the non-live stage of migration. Why this new hook? qemu already notifies s

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Spelling fixes in comments and documentation

2012-08-16 Thread Stefan Hajnoczi
On Fri, Aug 10, 2012 at 10:03:25PM +0200, Stefan Weil wrote: > These wrong spellings were detected by codespell: > > * successully -> successfully > > * alot -> a lot > > * wanna -> want to > > * infomation -> information > > * occured -> occurred > > Signed-off-by: Stefan Weil > --- > docs

Re: [Qemu-devel] [PATCH] Fix spelling (licenced -> licensed) in GPL

2012-08-16 Thread Stefan Hajnoczi
On Fri, Aug 10, 2012 at 10:03:26PM +0200, Stefan Weil wrote: > The patch also fixes the case of "written". > > Signed-off-by: Stefan Weil > --- > hw/imx_avic.c |4 ++-- > hw/imx_timer.c |4 ++-- > hw/kzm.c |2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) Thanks, appl

Re: [Qemu-devel] [PATCH for-1.2] osdep: Fix compilation failure on BSD systems

2012-08-16 Thread Corey Bryant
On 08/16/2012 07:15 AM, Peter Maydell wrote: Fix compilation failure on BSD systems (which don't have O_DIRECT or O_NOATIME: osdep.c:116: error: ‘O_DIRECT’ undeclared (first use in this function) osdep.c:116: error: (Each undeclared identifier is reported only once osdep.c:116: error: for each

[Qemu-devel] [PATCH] Spelling fixes in comments and macro names (ressource -> resource)

2012-08-16 Thread Stefan Weil
Macro XEN_HOST_PCI_RESOURCE_BUFFER_SIZE is only used locally, so the change should be safe. Signed-off-by: Stefan Weil --- hw/xen-host-pci-device.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/xen-host-pci-device.c b/hw/xen-host-pci-device.c index e7ff680..743b

Re: [Qemu-devel] [RFC V3 4/9] quorum: Add quorum_getlength().

2012-08-16 Thread Benoît Canet
Le Tuesday 14 Aug 2012 à 10:08:24 (-0600), Eric Blake a écrit : > On 08/14/2012 08:14 AM, Benoît Canet wrote: > > Signed-off-by: Benoit Canet > > --- > > block/quorum.c |9 + > > 1 file changed, 9 insertions(+) > > > > diff --git a/block/quorum.c b/block/quorum.c > > index f228428..a

[Qemu-devel] [PATCH v2] configure: properly check if -lrt and -lm is needed

2012-08-16 Thread Natanael Copa
Fixes build against uClibc. uClibc provides 2 versions of clock_gettime(), one with realtime support and one without (this is so you can avoid linking in -lrt unless actually needed). This means that the clock_gettime() don't need -lrt. We still need it for timer_create() so we check for this func

Re: [Qemu-devel] [PATCH for-1.2] osdep: Fix compilation failure on BSD systems

2012-08-16 Thread Peter Maydell
On 16 August 2012 14:11, Corey Bryant wrote: > > > On 08/16/2012 07:15 AM, Peter Maydell wrote: >> >> Fix compilation failure on BSD systems (which don't have >> O_DIRECT or O_NOATIME: >> osdep.c:116: error: ‘O_DIRECT’ undeclared (first use in this function) >> osdep.c:116: error: (Each undeclared

Re: [Qemu-devel] [PATCH 1/2] pc_sysfw: Check for qemu_find_file() failure

2012-08-16 Thread Luiz Capitulino
On Thu, 16 Aug 2012 13:41:12 +0200 Markus Armbruster wrote: > pc_fw_add_pflash_drv() ignores qemu_find_file() failure, and happily > creates a drive without a medium. > > When pc_system_flash_init() asks for its size, bdrv_getlength() fails > with -ENOMEDIUM, which isn't checked either. It fail

Re: [Qemu-devel] [PATCH] Spelling fixes in comments and macro names (ressource -> resource)

2012-08-16 Thread Stefan Hajnoczi
On Thu, Aug 16, 2012 at 03:12:21PM +0200, Stefan Weil wrote: > Macro XEN_HOST_PCI_RESOURCE_BUFFER_SIZE is only used locally, > so the change should be safe. > > Signed-off-by: Stefan Weil > --- > hw/xen-host-pci-device.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Thanks, a

Re: [Qemu-devel] [PATCH] Documentation: Warn against qemu-img on active image

2012-08-16 Thread Kevin Wolf
Am 16.08.2012 14:56, schrieb Eric Blake: > On 08/16/2012 04:00 AM, Peter Maydell wrote: >> On 16 August 2012 10:00, Kevin Wolf wrote: >>> People have repeatedly expected that you can do things like snapshotting >>> an image with qemu-img while a qemu instance is running. Maybe we need >>> to consi

Re: [Qemu-devel] [PATCH for-1.2 v3 1/3] qlist: add qlist_size()

2012-08-16 Thread Luiz Capitulino
On Wed, 15 Aug 2012 13:45:42 -0500 Michael Roth wrote: > > Signed-off-by: Michael Roth I've applied this series to the qmp branch for 1.2. I'll run some tests and if all goes alright will send a pull request shortly. > --- > qlist.c | 13 + > qlist.h |1 + > 2 files changed

Re: [Qemu-devel] 2 issues with qemu-master / 1.2 ehci code

2012-08-16 Thread Hans de Goede
Hi, On 08/14/2012 06:12 PM, Hans de Goede wrote: Hi, 2) I'm hitting: qemu-system-x86_64: /home/hans/projects/qemu/hw/usb/hcd-ehci.c:2075: ehci_state_executing: Assertion `p->qtdaddr == q->qtdaddr' failed. When trying to redirect a microsoft lifecam, since this is a device with multiple i

[Qemu-devel] [PATCH 2/3] pxa2xx: Get BlockDriverState* in mmc controller init, not board init

2012-08-16 Thread Peter Maydell
Instead of getting the BlockDriverState* in the pxa2xx board init and passing it to the mmc controller's init function, have the mmc controller get the next IF_SD device and use it if present. This brings us into line with other SD controller models and means that we correctly emulate an SD control

[Qemu-devel] [PATCH] ehci: Remove unnecessary ehci_flush_qh call

2012-08-16 Thread Hans de Goede
ehci_qh_do_overlay() already calls ehci_flush_qh() before it returns, calling it twice is useless. Signed-off-by: Hans de Goede --- hw/usb/hcd-ehci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 8b94b17..41d663d 100644 --- a/hw/usb/hcd-ehci.c +++

Re: [Qemu-devel] [PATCH] Documentation: Warn against qemu-img on active image

2012-08-16 Thread Eric Blake
On 08/16/2012 07:35 AM, Kevin Wolf wrote: > Am 16.08.2012 14:56, schrieb Eric Blake: >> On 08/16/2012 04:00 AM, Peter Maydell wrote: >>> On 16 August 2012 10:00, Kevin Wolf wrote: People have repeatedly expected that you can do things like snapshotting an image with qemu-img while a qemu

Re: [Qemu-devel] [PATCH 1/2] pc_sysfw: Check for qemu_find_file() failure

2012-08-16 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 16 Aug 2012 13:41:12 +0200 > Markus Armbruster wrote: > >> pc_fw_add_pflash_drv() ignores qemu_find_file() failure, and happily >> creates a drive without a medium. >> >> When pc_system_flash_init() asks for its size, bdrv_getlength() fails >> with -ENOMEDIUM,

[Qemu-devel] [PATCH 3/3] Drop default SD card creation

2012-08-16 Thread Peter Maydell
Now that all users of IF_SD drives can cope with there being no drive present (ie "controller exists but there is no card in it") we can drop the creation of the default IF_SD card in vl.c and the no_sdcard field in the QEMUMachine struct. Signed-off-by: Peter Maydell --- hw/boards.h |3

[Qemu-devel] [PATCH 0/3] Drop default SD card creation

2012-08-16 Thread Peter Maydell
As suggested in the recent discussion on Marcks' patchset to suppress unused default drives, this patchset cleans up the omap and pxa2xx SD card controllers to behave like the other controllers: * the init function looks for the next IF_SD drive * if there isn't one, we start up as a controller w

[Qemu-devel] [PATCH 1/3] omap: Get BlockDriverState* in mmc controller init, not board init

2012-08-16 Thread Peter Maydell
Instead of getting the BlockDriverState* in the omap board init and passing it to the mmc controller's init function, have the mmc controller get the next IF_SD device and use it if present. This brings us into line with other SD controller models and means that we correctly emulate an SD controlle

Re: [Qemu-devel] [PATCH 1/2] pc_sysfw: Check for qemu_find_file() failure

2012-08-16 Thread Kevin Wolf
Am 16.08.2012 15:50, schrieb Markus Armbruster: >> Although I'm not sure it qualifies for hard-freeze... > > I didn't tag my series "for-1.2". I understand that fixes to > not-so-important stuff aren't welcome at this time even when they're > really simple. It's a clear bug fix, easy to understa

Re: [Qemu-devel] [PATCH 1/2] pc_sysfw: Check for qemu_find_file() failure

2012-08-16 Thread Luiz Capitulino
On Thu, 16 Aug 2012 15:50:51 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 16 Aug 2012 13:41:12 +0200 > > Markus Armbruster wrote: > > > >> pc_fw_add_pflash_drv() ignores qemu_find_file() failure, and happily > >> creates a drive without a medium. > >> > >> When pc_sy

Re: [Qemu-devel] [PATCH] Spelling fixes in comments and macro names (ressource -> resource)

2012-08-16 Thread Andreas Färber
Am 16.08.2012 15:32, schrieb Stefan Hajnoczi: > On Thu, Aug 16, 2012 at 03:12:21PM +0200, Stefan Weil wrote: >> Macro XEN_HOST_PCI_RESOURCE_BUFFER_SIZE is only used locally, >> so the change should be safe. >> >> Signed-off-by: Stefan Weil >> --- >> hw/xen-host-pci-device.c |6 +++--- >> 1 fi

Re: [Qemu-devel] [PATCH for-1.2 v3 2/3] json-parser: don't replicate tokens at each level of recursion

2012-08-16 Thread Luiz Capitulino
On Wed, 15 Aug 2012 13:45:43 -0500 Michael Roth wrote: > Currently, when parsing a stream of tokens we make a copy of the token > list at the beginning of each level of recursion so that we do not > modify the original list in cases where we need to fall back to an > earlier state. > > In the wo

Re: [Qemu-devel] Windows slow boot: contractor wanted

2012-08-16 Thread Benoît Canet
Le Thursday 16 Aug 2012 à 11:47:27 (+0100), Richard Davies a écrit : > Hi, > > We run a cloud hosting provider using qemu-kvm 1.1, and are keen to find a > contractor to track down and fix problems we have with large memory Windows > guests booting very slowly - they can take several hours. > > W

Re: [Qemu-devel] [PATCH 0/3] Drop default SD card creation

2012-08-16 Thread Markus Armbruster
Peter Maydell writes: > As suggested in the recent discussion on Marcks' patchset to suppress > unused default drives, this patchset cleans up the omap and pxa2xx > SD card controllers to behave like the other controllers: > * the init function looks for the next IF_SD drive > * if there isn't

Re: [Qemu-devel] [PATCH 0/3] Drop default SD card creation

2012-08-16 Thread Peter Maydell
On 16 August 2012 15:11, Markus Armbruster wrote: > Peter Maydell writes: >> As suggested in the recent discussion on Markus' patchset to suppress >> unused default drives, this patchset cleans up the omap and pxa2xx >> SD card controllers to behave like the other controllers: >> * the init func

Re: [Qemu-devel] Slow inbound traffic on macvtap interfaces

2012-08-16 Thread Chris Webb
"Michael S. Tsirkin" writes: > On Thu, Aug 16, 2012 at 10:20:05AM +0100, Chris Webb wrote: > > > For example, I can run > > > > ip addr add 192.168.1.2/24 dev eth0 > > ip link set eth0 up > > ip link add link eth0 name tap0 address 02:02:02:02:02:02 type macvtap > > mode bridge > > ip l

Re: [Qemu-devel] [PATCH 1/2] pc_sysfw: Check for qemu_find_file() failure

2012-08-16 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 16 Aug 2012 15:50:51 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Thu, 16 Aug 2012 13:41:12 +0200 >> > Markus Armbruster wrote: >> > >> >> pc_fw_add_pflash_drv() ignores qemu_find_file() failure, and happily >> >> creates a drive w

Re: [Qemu-devel] [PATCH 0/4] Add -sandbox option to enable seccomp mode 2

2012-08-16 Thread Eduardo Otubo
On Wed, Aug 15, 2012 at 05:44:38PM -0500, Anthony Liguori wrote: > Hi, > > I attempted to apply Eduardo's seccomp patches and ran into a number of > problems. In the interest of time, I thought it would be easier for me to fix > them and just respin the series myself. > > I've tested this as bes

Re: [Qemu-devel] [PATCH] use --libexecdir instead of ignoring it first and reinventing it later

2012-08-16 Thread Andreas Färber
Am 06.06.2012 23:11, schrieb Michael Tokarev: > Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 "Add basic version > of bridge helper" put the bridge helper executable into a fixed > ${prefix}/libexec/ location, instead of using ${libexecdir} for > this. At the same time, --libexecdir is being hap

Re: [Qemu-devel] [PATCH 1/2] pc_sysfw: Check for qemu_find_file() failure

2012-08-16 Thread Luiz Capitulino
On Thu, 16 Aug 2012 16:32:12 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 16 Aug 2012 15:50:51 +0200 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >> > On Thu, 16 Aug 2012 13:41:12 +0200 > >> > Markus Armbruster wrote: > >> > > >> >> pc_fw_ad

  1   2   >