[Qemu-devel] [PATCHv2 01/19] unicore32-softmmu: Add unicore32-softmmu build support

2012-08-10 Thread gxt
From: Guan Xuetao This patch adds unicore32-softmmu build support, include configure, makefile, arch_init, and all missing functions needed by softmmu. Although all missing functions are empty, unicore32-softmmu could be build successfully. By 20120804: change QEMU_ARCH_UNICORE32 to 0x4000 Signe

[Qemu-devel] [PATCHv2 02/19] unicore32-softmmu: Add coprocessor 0(sysctrl) and 1(ocd) instruction support

2012-08-10 Thread gxt
From: Guan Xuetao Coprocessor 0 is system control coprocessor, and we need get/set its contents. Also, all cache/tlb ops shoule be implemented here, but just ignored with no harm. Coprocessor 1 is OCD (on-chip-debugger), which is used for faked console, so we could output chars to this console

[Qemu-devel] [PATCHv2 14/19] unicore32-softmmu: Add maintainer information for UniCore32 machine

2012-08-10 Thread gxt
From: Guan Xuetao Signed-off-by: Guan Xuetao --- MAINTAINERS |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2d219d2..708ad54 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -405,6 +405,14 @@ M: Alexander Graf S: Maintained F: hw/

Re: [Qemu-devel] [PATCH 0/4]: qmp: WAKEUP event related fixes

2012-08-10 Thread Gerd Hoffmann
On 08/09/12 19:28, Luiz Capitulino wrote: > Fixes the RESET event being emitted on wakeup from S3. Changes when > the WAKEUP event is emitted and a few doc fixes. series looks good to me. Acked-by: Gerd Hoffmann cheers, Gerd

[Qemu-devel] [PATCHv2 05/19] unicore32-softmmu: Implement softmmu specific functions

2012-08-10 Thread gxt
From: Guan Xuetao This patch implements softmmu specific functions, include tlb_fill, switch_mode, do_interrupt and uc32_cpu_handle_mmu_fault. So the full exception handlers and page table walking could work now. Signed-off-by: Guan Xuetao --- target-unicore32/op_helper.c | 22 - target-

[Qemu-devel] [PATCHv2 06/19] unicore32-softmmu: Make sure that kernel can access user space

2012-08-10 Thread gxt
From: Guan Xuetao As a matter of course, we need to access user space in kernel code, so we need to correct load/store decoders to indicate correct memory region. Signed-off-by: Guan Xuetao --- target-unicore32/translate.c | 36 ++-- 1 files changed, 26 insert

[Qemu-devel] [PATCHv2 10/19] unicore32-softmmu: Add puv3 gpio support

2012-08-10 Thread gxt
From: Guan Xuetao This patch adds puv3 gpio (General Purpose Input/Output) support, include gpio device simulation and its interrupt support. v1->v2: Add initialization to ret in puv3_gpio_read. Signed-off-by: Guan Xuetao --- hw/Makefile.objs |1 + hw/puv3.c|6 ++ hw/puv3_gpio

[Qemu-devel] [PATCHv2 09/19] unicore32-softmmu: Add puv3 ostimer support

2012-08-10 Thread gxt
From: Guan Xuetao This patch adds puv3 ostimer support, include os timer device simulation and ptimer support in puv3 machine. Signed-off-by: Guan Xuetao --- default-configs/unicore32-softmmu.mak |1 + hw/Makefile.objs |1 + hw/puv3.c |

[Qemu-devel] [PATCHv2 11/19] unicore32-softmmu: Add puv3 pm support

2012-08-10 Thread gxt
From: Guan Xuetao This patch adds puv3 pm (power management) support, include pm device simulation for kernel booting. Thank Blue Swirl for pointing out the missing "break". v1->v2: Add initialization to ret in puv3_pm_read. Signed-off-by: Guan Xuetao --- hw/Makefile.objs |1 + hw/puv3.c

[Qemu-devel] [PATCHv2 13/19] unicore32-softmmu: Add ps2 support

2012-08-10 Thread gxt
From: Guan Xuetao This patch adds ps2/keyboard support, and enables CONFIG_PCKBD. Signed-off-by: Guan Xuetao --- default-configs/unicore32-softmmu.mak |1 + hw/puv3.c |5 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/default-configs/un

Re: [Qemu-devel] Running KVM guest on X86

2012-08-10 Thread Gleb Natapov
On Thu, Aug 09, 2012 at 05:39:36PM +, Bhushan Bharat-R65777 wrote: > > > > -Original Message- > > From: Stuart Yoder [mailto:b08...@gmail.com] > > Sent: Thursday, August 09, 2012 8:28 PM > > To: Bhushan Bharat-R65777 > > Cc: Alex Williamson; qemu-devel@nongnu.org; Avi Kivity > > Subje

[Qemu-devel] [PATCHv2 00/19] unicore32: Add unicore32-softmmu support

2012-08-10 Thread gxt
From: Guan Xuetao These patches implement softmmu support on unicore32 architecture. v1->v2: Correct maybe-uninitialized warning in gpio/pm/dma handlers. UniCore32 CPU is embedded in PKUnity-3 SoC, so we add necessary puv3 devices simulation codes together. Only minimal system control modules a

Re: [Qemu-devel] TSC in qem[-kvm] 1.1+ and in-kernel irqchip

2012-08-10 Thread Gleb Natapov
On Thu, Aug 09, 2012 at 10:27:43PM +0400, Michael Tokarev wrote: > As a follow-up to the patch "tsc: use kvmclock for > calibration". > > There's another problem reported by several users. > The sympthom is that grub does not show boot menu, > it boots default entry right away without any pause. >

Re: [Qemu-devel] Is it possible to detect guest OS modifying pte inside QEMU?

2012-08-10 Thread Wei-Ren Chen
Hi Peter, On Wed, Aug 08, 2012 at 09:05:18AM +0100, Peter Maydell wrote: > On 8 August 2012 08:38, 陳韋任 (Wei-Ren Chen) wrote: > > Just for research, we are studying if we can leave the guest page > > table walk to underlying hardware rather than using software emulation > > (like current approac

Re: [Qemu-devel] [PATCH 1/4] s390/kvm: Handle hosts not supporting s390-virtio.

2012-08-10 Thread Cornelia Huck
On Fri, 10 Aug 2012 01:09:15 +0200 Alexander Graf wrote: > > On 07.08.2012, at 16:52, Cornelia Huck wrote: > > > Running under a kvm host does not necessarily imply the presence of > > a page mapped above the main memory with the virtio information; > > however, the code includes a hard coded a

Re: [Qemu-devel] [qemu-devel] [PATCH V2 0/3] [RFC] libqblock draft code v2

2012-08-10 Thread Wenchao Xia
Thanks for your review, sorry I have forgot some fixing you mentioned before, will correct them this time. 于 2012-8-10 1:12, Blue Swirl 写道: On Thu, Aug 9, 2012 at 10:10 AM, Wenchao Xia wrote: This patch intrudce libqblock API, libqblock-test is used as a test case. V2: Using struct_s

Re: [Qemu-devel] [PATCH v8 2/7] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-10 Thread Stefan Hajnoczi
On Thu, Aug 09, 2012 at 10:10:44PM -0400, Corey Bryant wrote: > +void qmp_remove_fd(int64_t fdset_id, bool has_fd, int64_t fd, Error **errp) > +{ > +MonFdset *mon_fdset; > +MonFdsetFd *mon_fdset_fd; > +char fd_str[20]; > + > +QLIST_FOREACH(mon_fdset, &mon_fdsets, next) { > +

Re: [Qemu-devel] [PATCH 1/3] net: notify iothread after flushing queue

2012-08-10 Thread Stefan Hajnoczi
On Thu, Aug 09, 2012 at 05:55:50PM +, Blue Swirl wrote: > On Thu, Aug 9, 2012 at 2:45 PM, Paolo Bonzini wrote: > > @@ -244,7 +244,7 @@ void qemu_net_queue_flush(NetQueue *queue) > > packet->size); > > if (ret == 0) { > > QTAILQ_INSERT

Re: [Qemu-devel] Running KVM guest on X86

2012-08-10 Thread Bhushan Bharat-R65777
> > > >> On Mon, 2012-08-06 at 15:40 +, Bhushan Bharat-R65777 wrote: > > > >> > Hi Avi/All, > > > >> > > > > >> > I am facing issue to boot KVM guest on x86 (I used to work on > > > >> > PowerPC platform > > > >> and do not have enough knowledge of x86). I am working on making > > > >> VFIO wor

Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field

2012-08-10 Thread Markus Armbruster
Revisited this one on review of v2, replying here for context. Luiz Capitulino writes: > On Thu, 02 Aug 2012 13:35:54 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > Signed-off-by: Luiz Capitulino >> > --- >> > block.c | 1 + >> > qapi-schema.json | 7 +--

Re: [Qemu-devel] [qemu-devel] [PATCH V2 2/3] [RFC] libqblock-API design

2012-08-10 Thread Wenchao Xia
于 2012-8-10 1:36, Blue Swirl 写道: On Thu, Aug 9, 2012 at 10:12 AM, Wenchao Xia wrote: This patch is the API design. Signed-off-by: Wenchao Xia --- libqblock.c | 670 +++ libqblock.h | 447 +++

Re: [Qemu-devel] [qemu-devel] [PATCH V2 3/3] [RFC] libqblock-test case.

2012-08-10 Thread Wenchao Xia
于 2012-8-10 1:49, Blue Swirl 写道: On Thu, Aug 9, 2012 at 10:12 AM, Wenchao Xia wrote: This file simulate the caller to test the library. Signed-off-by: Wenchao Xia --- libqblock-test.c | 197 ++ Please move this to test/ and build with

Re: [Qemu-devel] [PATCH 12/34] hmp: hmp_cont(): don't rely on QERR_DEVICE_ENCRYPTED

2012-08-10 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 02 Aug 2012 13:53:08 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > This commit changes hmp_cont() to loop through all block devices >> > and proactively set an encryption key for any encrypted device >> > without a valid one. >> > >> >

Re: [Qemu-devel] [PATCH 12/35] hmp: hmp_cont(): don't rely on QERR_DEVICE_ENCRYPTED

2012-08-10 Thread Markus Armbruster
Luiz Capitulino writes: > This commit changes hmp_cont() to loop through all block devices > and proactively set an encryption key for any encrypted device > without a valid one. > > This change is needed because QERR_DEVICE_ENCRYPTED is going to be > dropped by a future commit. I'm afraid this

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-10 Thread Andreas Färber
Am 09.08.2012 22:36, schrieb Peter Maydell: > On 9 August 2012 21:01, Phil Staub wrote: >> On 08/09/2012 12:57 PM, Blue Swirl wrote: >>> On Tue, Aug 7, 2012 at 12:10 PM, Peter Maydell >>> wrote: For this purpose the usual approach is to follow up to the patch mail saying "Ping" and givi

Re: [Qemu-devel] [PATCH] armv7m: Guard against no -kernel argument

2012-08-10 Thread Andreas Färber
Am 10.08.2012 03:27, schrieb Peter A. G. Crosthwaite: > A -kernel argument must be specified for this machine. Gaurd against no > -kernel "Guard" > argument. Previously gave an unhelpful "bad address" error message. > > Signed-off-by: Peter A. G. Crosthwaite Otherwise looks good - PMM, can yo

Re: [Qemu-devel] [PATCH 1/4] s390/kvm: Handle hosts not supporting s390-virtio.

2012-08-10 Thread Heiko Carstens
On Thu, Aug 09, 2012 at 12:41:57PM +0200, Cornelia Huck wrote: > On Thu, 09 Aug 2012 13:03:57 +0300 > Avi Kivity wrote: > > > On 08/07/2012 05:52 PM, Cornelia Huck wrote: > > > Running under a kvm host does not necessarily imply the presence of > > > a page mapped above the main memory with the v

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-10 Thread Peter Maydell
On 10 August 2012 09:48, Andreas Färber wrote: > Am 09.08.2012 22:36, schrieb Peter Maydell: >> Maciej submitted some other MIPS patches at about the same time: >> http://patchwork.ozlabs.org/project/qemu-devel/list/?submitter=4977 >> at least some of which got reviewed by Richard Henderson and ar

Re: [Qemu-devel] [PATCH 13/35] hmp_change(): don't access DeviceEncrypted's data

2012-08-10 Thread Markus Armbruster
Luiz Capitulino writes: > It's not needed. The device name is already known and > monitor_read_block_device_key() knows how to do the rest. This overly > simplifies hmp_change(). "overly"? My usual complaint about commit messages is that they fail to explain the change's purpose. Yours explain

Re: [Qemu-devel] [PATCH 14/35] net: inet_connect(), inet_connect_opts(): add in_progress argument

2012-08-10 Thread Markus Armbruster
Luiz Capitulino writes: > It's used to indicate the special case where a valid file-descriptor > is returned (ie. success) but the connection can't be completed > w/o blocking. Why callers need that isn't obvious from this patch. It's used in PATCH 16. Either squash the two to make it obvious,

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-10 Thread Andreas Färber
Am 10.08.2012 11:00, schrieb Peter Maydell: > On 10 August 2012 09:48, Andreas Färber wrote: >> Actually there were better patches for the same bug by Meador, including >> git-style rather than SVN patches and adding a helper to initialize it >> consistently at all call sites. >> >> There's also D

Re: [Qemu-devel] [PATCH 15/35] migration: don't rely on any QERR_SOCKET_*

2012-08-10 Thread Markus Armbruster
Luiz Capitulino writes: > Use the in_progress argument for QERR_SOCKET_CONNECT_IN_PROGRESS. The > other errors are handled the same by checking if the error is set and > then calling migrate_fd_error() if it's. > > It's also necessary to change inet_connect_opts() not to set > QERR_SOCKET_CONNECT

Re: [Qemu-devel] [PATCH 1/2] qom: Reimplement Interfaces

2012-08-10 Thread Andreas Färber
Am 10.08.2012 05:16, schrieb Peter A. G. Crosthwaite: > From: Anthony Liguori > > The current implementation of Interfaces is poorly designed. Each interface > that an object implements ends up being an object that's tracked by the > implementing object. There's all sorts of gymnastics to deal

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread Stefan Priebe - Profihost AG
virtio-scsi is now working fine. Could you please help me to get discard / trim running? I can't find any information what is needed to get discard / trim working. Thanks, Stefan Am 09.08.2012 12:17, schrieb Stefan Priebe - Profihost AG: That looks better - thanks for the hint. But now network

Re: [Qemu-devel] TSC in qem[-kvm] 1.1+ and in-kernel irqchip

2012-08-10 Thread Michael Tokarev
On 10.08.2012 11:33, Gleb Natapov wrote: > On Thu, Aug 09, 2012 at 10:27:43PM +0400, Michael Tokarev wrote: >> As a follow-up to the patch "tsc: use kvmclock for >> calibration". >> >> There's another problem reported by several users. >> The sympthom is that grub does not show boot menu, >> it boo

Re: [Qemu-devel] [PATCH] armv7m: Guard against no -kernel argument

2012-08-10 Thread Peter Maydell
On 10 August 2012 09:53, Andreas Färber wrote: > Am 10.08.2012 03:27, schrieb Peter A. G. Crosthwaite: >> A -kernel argument must be specified for this machine. Gaurd against no >> -kernel > > "Guard" > >> argument. Previously gave an unhelpful "bad address" error message. >> >> Signed-off-by: Pe

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread Paolo Bonzini
Il 10/08/2012 11:22, Stefan Priebe - Profihost AG ha scritto: > virtio-scsi is now working fine. Could you please help me to get discard > / trim running? I can't find any information what is needed to get > discard / trim working. You need to add discard_granularity=NNN, where NNN is usually 512

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread Stefan Priebe - Profihost AG
I'm using iscsi. So no raw or qcow2. XFS as FS. Thanks, Stefan Am 10.08.2012 12:20, schrieb Paolo Bonzini: Il 10/08/2012 11:22, Stefan Priebe - Profihost AG ha scritto: virtio-scsi is now working fine. Could you please help me to get discard / trim running? I can't find any information what i

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread Paolo Bonzini
Il 10/08/2012 12:28, Stefan Priebe - Profihost AG ha scritto: > I'm using iscsi. So no raw or qcow2. Ok, then you need to use scsi-block as your device instead of scsi-disk or scsi-hd. This will disable the QEMU SCSI emulation and let your VM talk directly to the NAS. CCing Ronnie who may be int

Re: [Qemu-devel] [PATCH 1/2] qom: Reimplement Interfaces

2012-08-10 Thread Peter Crosthwaite
On Fri, Aug 10, 2012 at 7:15 PM, Andreas Färber wrote: > Am 10.08.2012 05:16, schrieb Peter A. G. Crosthwaite: >> From: Anthony Liguori >> >> The current implementation of Interfaces is poorly designed. Each interface >> that an object implements ends up being an object that's tracked by the >>

Re: [Qemu-devel] [qemu-devel] [PATCH V2 2/3] [RFC] libqblock-API design

2012-08-10 Thread Paolo Bonzini
Il 09/08/2012 12:12, Wenchao Xia ha scritto: > +/* copy information and take care the member difference in differect version. > + Assuming all new member are added in the tail, struct size is the first > + member, this is old to new version, src have its struct_size set. */ > +static void qboc_

Re: [Qemu-devel] Running KVM guest on X86

2012-08-10 Thread Gleb Natapov
On Fri, Aug 10, 2012 at 08:19:49AM +, Bhushan Bharat-R65777 wrote: > > > > >> On Mon, 2012-08-06 at 15:40 +, Bhushan Bharat-R65777 wrote: > > > > >> > Hi Avi/All, > > > > >> > > > > > >> > I am facing issue to boot KVM guest on x86 (I used to work on > > > > >> > PowerPC platform > > > > >>

Re: [Qemu-devel] [qemu-devel] [PATCH V2 2/3] [RFC] libqblock-API design

2012-08-10 Thread Kevin Wolf
Am 09.08.2012 12:12, schrieb Wenchao Xia: > This patch is the API design. > > Signed-off-by: Wenchao Xia > --- > libqblock.c | 670 > +++ > libqblock.h | 447 +++ > 2 files changed, 1117 insertions(+

Re: [Qemu-devel] [PATCH 1/4] s390/kvm: Handle hosts not supporting s390-virtio.

2012-08-10 Thread Cornelia Huck
On Fri, 10 Aug 2012 10:42:48 +0200 Heiko Carstens wrote: > On Thu, Aug 09, 2012 at 12:41:57PM +0200, Cornelia Huck wrote: > > On Thu, 09 Aug 2012 13:03:57 +0300 > > Avi Kivity wrote: > > > > > On 08/07/2012 05:52 PM, Cornelia Huck wrote: > > > > Running under a kvm host does not necessarily imp

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread ronnie sahlberg
You want discard to work? That should not be a problem with iscsi. You are using qemu 1.0 ? So you dont have the qemu support for scsi-generic passthrough to iscsi devices. This should though work without too much trouble First you need an iscsi target that supports SBC UNMAP command. STGT

Re: [Qemu-devel] [PATCH 2/2] usb-storage: fix SYNCHRONIZE_CACHE

2012-08-10 Thread Michael Tokarev
On 07.08.2012 12:59, Gerd Hoffmann wrote: > Commit 59310659073d85745854f2f10c4292555c5a1c51 is incomplete, > we'll arrive in the scsi command complete callback in CSW state > and must handle that case correctly. It appears to be 1.1-stable material, rigt? What's the outcome of the issue -- guest-t

[Qemu-devel] [Bug 1033494] Re: qemu-system-x86_64 segfaults with kernel 3.5.0

2012-08-10 Thread Michael Tokarev
this thread and this fix http://thread.gmane.org/gmane.comp.emulators.kvm.devel/95314/focus=1338226 are about the same issue, apparently. Please try it and see if it fixes you issue too. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread ronnie sahlberg
On Fri, Aug 10, 2012 at 8:30 PM, Paolo Bonzini wrote: > Il 10/08/2012 12:28, Stefan Priebe - Profihost AG ha scritto: >> I'm using iscsi. So no raw or qcow2. > > Ok, then you need to use scsi-block as your device instead of scsi-disk > or scsi-hd. This will disable the QEMU SCSI emulation and let

[Qemu-devel] [RFC 00/20] target-i386: convert CPU features into properties

2012-08-10 Thread Igor Mammedov
build and run tested in FC17 host with x86_64-linux-user, x86_64-softmmu targets Igor Mammedov (20): target-i386: return Error from cpu_x86_find_by_name() target-i386: cpu_x86_register(): report error from property setter target-i386: if x86_cpu_realize() failed report error and do cleanup

[Qemu-devel] [RFC 01/20] target-i386: return Error from cpu_x86_find_by_name()

2012-08-10 Thread Igor Mammedov
it will allow to use property setters there later. Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 880cfea..ee25309 100644 --- a/target-i386/cpu.c +++ b/target-i

[Qemu-devel] [RFC 16/20] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

2012-08-10 Thread Igor Mammedov
Vendor property setter takes string as vendor value but cpudefs use uint32_t vendor[123] fields to define vendor value. It makes it difficult to unify and use property setter for values from cpudefs. To allow simplify code by using vendor property setter, vendor[123] fields are converted into vend

[Qemu-devel] [RFC 11/20] target-i386: convert 'check' and 'enforce' features into properties

2012-08-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 68 ++- 1 file changed, 57 insertions(+), 11 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 7734613..a154e89 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -

[Qemu-devel] [RFC 20/20] target-i386: move default init of cpuid_kvm_features bitmap into CPU initializer from cpudef

2012-08-10 Thread Igor Mammedov
Moving it inside CPU initializer from cpudef will help to split cpu_x86_find_by_name() into default init and user settable properties. PS: Is kvm_features field necessary in cpudef, what the point if it's almost imediately overwritten to ~0? Could it be removed from cpudef? Signed-off-by: I

[Qemu-devel] [RFC 07/20] target-i386: convert cpuid features into properties

2012-08-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 103 ++ 1 file changed, 103 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index a47cc12..4b22598 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -605,6 +605,103 @

Re: [Qemu-devel] [RFC 00/20] target-i386: convert CPU features into properties

2012-08-10 Thread Igor Mammedov
PS: forgot to add git tree for testing: https://github.com/imammedo/qemu/tree/x86-cpu-properties_RFC - Original Message - > From: "Igor Mammedov" > To: qemu-devel@nongnu.org > Cc: aligu...@us.ibm.com, stefa...@linux.vnet.ibm.com, g...@redhat.com, "jan > kiszka" , > mtosa...@redhat.com, m

Re: [Qemu-devel] [RFC 03/20] target-i386: if x86_cpu_realize() failed report error and do cleanup

2012-08-10 Thread Andreas Färber
Am 10.08.2012 13:22, schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov Acked-by: Andreas Färber /-F -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

[Qemu-devel] [RFC 12/20] add visitor for parsing hz[KMG] input string

2012-08-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- qapi/qapi-visit-core.c | 11 +++ qapi/qapi-visit-core.h | 2 ++ qapi/string-input-visitor.c | 22 ++ 3 files changed, 35 insertions(+) diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c index 7a82b63..322cfa6 10064

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread Stefan Priebe - Profihost AG
Hi, i tried that but i then get: kvm: -device scsi-block,bus=scsihw0.0,channel=0,scsi-id=0,lun=0,drive=drive-scsi0,id=scsi0: scsi-block: INQUIRY failed kvm: -device scsi-block,bus=scsihw0.0,channel=0,scsi-id=0,lun=0,drive=drive-scsi0,id=scsi0: Device 'scsi-block' could not be initialized VM

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread Stefan Priebe - Profihost AG
http://www.nexenta.com/corp/products/what-is-openstorage/nexentastor tells me: "SCSI UNMAP as a client-side feature frees up storage in the back end, in the context of thin provisioning (a 100-to-one reduction in space for VDI when using NexentaStor)." So i would say nexenta supports it. But

[Qemu-devel] [RFC 19/20] target-i386: move init of "hypervisor" feature into CPU initializer from cpudef

2012-08-10 Thread Igor Mammedov
"hypervisor" CPU feature is unconditionally enabled/overridden even if it's cleared in cpudef. Moving it inside CPU initializer from cpudef will help to split cpu_x86_find_by_name() into default init and user settable properties. Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 4 ++-- 1 fi

Re: [Qemu-devel] [PATCH v6 1/4] hw: introduce standard SD host controller

2012-08-10 Thread Peter Crosthwaite
Ping! Any further thoughts here? There seem to be a few minor correction for PPM, but the sore-thumb issue is the long/infinite ADMA. Is there an (easy) AIO based solution to be had or do we need to do some sort of ptimer hack? Regards, Peter On Tue, Aug 7, 2012 at 4:31 PM, Peter Crosthwaite w

Re: [Qemu-devel] [RFC 12/20] add visitor for parsing hz[KMG] input string

2012-08-10 Thread Andreas Färber
Am 10.08.2012 13:22, schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov > --- > qapi/qapi-visit-core.c | 11 +++ > qapi/qapi-visit-core.h | 2 ++ > qapi/string-input-visitor.c | 22 ++ > 3 files changed, 35 insertions(+) > > diff --git a/qapi/qapi-visit-

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread Stefan Priebe - Profihost AG
Am 10.08.2012 13:12, schrieb ronnie sahlberg: You want discard to work? Yes You are using qemu 1.0 ? actual qemu-kvm git So you dont have the qemu support for scsi-generic passthrough to iscsi devices. Why? I think you need to run the target on linux 3.2 or later kernels using ext4/xfs f

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread ronnie sahlberg
You can easily verify if your target supports thin-provisioning via the UNMAP command. Download the sg3-utils package and either mount the LUN locally via the kernel open-iscsi or apply the libiscsi patch to sg3-utils to make it iscsi-aware then use the commands"sg_unmap" to try to unmap re

[Qemu-devel] [RFC 17/20] target-i386: parse cpu_model string into set of stringified properties

2012-08-10 Thread Igor Mammedov
cpu_model string does represent features in following format: ([+-]feat)|(feat=foo)|(feat) which makes it impossible directly use property infrastructure to set features on CPU. This patch introduces parser that splits CPU name from cpu_model and converts legacy features string into canonized set

[Qemu-devel] [RFC 13/20] target-i386: use visit_type_hz to parse tsc_freq property value

2012-08-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index a154e89..c935c04 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -952,7 +952,7 @@ static void x86_cpuid_set_tsc_freq(Object

Re: [Qemu-devel] [RFC 12/20] add visitor for parsing hz[KMG] input string

2012-08-10 Thread Igor Mammedov
- Original Message - > From: "Andreas Färber" > To: "Igor Mammedov" > Cc: qemu-devel@nongnu.org, g...@redhat.com, ler...@redhat.com, > pbonz...@redhat.com, stefa...@linux.vnet.ibm.com, > mdr...@linux.vnet.ibm.com, ak...@redhat.com, ehabk...@redhat.com, > aligu...@us.ibm.com, mtosa...@re

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread ronnie sahlberg
On Fri, Aug 10, 2012 at 9:57 PM, Stefan Priebe - Profihost AG wrote: > Am 10.08.2012 13:12, schrieb ronnie sahlberg: > >> You want discard to work? > > Yes > > >> You are using qemu 1.0 ? > > actual qemu-kvm git > > >> So you dont have the qemu support for scsi-generic passthrough to iscsi >> devi

[Qemu-devel] [RFC 06/20] target-i386: xlevel should be more than 0x80000000, move fixup into setter

2012-08-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 783c6f4..a47cc12 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -745,8 +745,17 @@ static void x86_cpuid_set

[Qemu-devel] [RFC 02/20] target-i386: cpu_x86_register(): report error from property setter

2012-08-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index ee25309..17e98e1 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1186,6 +1186,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)

[Qemu-devel] [RFC 14/20] target-i386: introduce vendor-override property

2012-08-10 Thread Igor Mammedov
currently 'cpuid_vendor_override' can be set only via cmd line cpu_model string. But setting it in 'vendor' property prevents using 'vendor' property on its own without setting cpuid_vendor_override. So fix/remove enabling cpuid_vendor_override from "vendor" property setter. It's up-to cpu_model s

[Qemu-devel] [RFC 05/20] target-i386: move out CPU features initialization in separate func

2012-08-10 Thread Igor Mammedov
later it could be used in cpu_x86_find_by_name() to init CPU from found cpu_def Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 62 ++- 1 file changed, 34 insertions(+), 28 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c i

[Qemu-devel] [RFC 08/20] target-i386: convert 'hv_spinlocks' feature into property

2012-08-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 4b22598..fb98bbd 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -964,6 +964,32 @@ static void x86_cpuid_se

[Qemu-devel] [RFC 03/20] target-i386: if x86_cpu_realize() failed report error and do cleanup

2012-08-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/helper.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index 8a5da3d..a0e4c89 100644 --- a/target-i386/helper.c +++ b/target-i386/helper.c @@ -1151,6 +1151,7 @@ X86CPU *cpu_x86_

[Qemu-devel] [RFC 18/20] target-i386: use properties to set/unset user specified features on CPU

2012-08-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 167 +++--- 1 file changed, 20 insertions(+), 147 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 7555b08..0174c4d 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@

[Qemu-devel] [RFC 15/20] target-i386: use define for cpuid vendor string size

2012-08-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 6 +++--- target-i386/cpu.h | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index d3ce849..368360f 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -863,13 +863,13 @@ static

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread Stefan Priebe - Profihost AG
Am 10.08.2012 14:04, schrieb ronnie sahlberg: On Fri, Aug 10, 2012 at 9:57 PM, Stefan Priebe - Profihost AG wrote: Am 10.08.2012 13:12, schrieb ronnie sahlberg: You want discard to work? Yes You are using qemu 1.0 ? actual qemu-kvm git So you dont have the qemu support for scsi-gene

[Qemu-devel] [RFC 09/20] target-i386: convert 'hv_relaxed' feature into property

2012-08-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index fb98bbd..f73309e 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -988,6 +988,26 @@ static void x86_set_hv_spinlocks

[Qemu-devel] [RFC 04/20] target-i386: filter out not TCG features if running without kvm at realize time

2012-08-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 17e98e1..d0dec63 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1171,17 +1171,6 @@ int cpu_x86_

[Qemu-devel] [RFC 10/20] target-i386: convert 'hv_vapic' feature into property

2012-08-10 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f73309e..7734613 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1008,6 +1008,26 @@ static void x86_set_hv_relaxed

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread ronnie sahlberg
On Fri, Aug 10, 2012 at 10:14 PM, Stefan Priebe - Profihost AG wrote: > Am 10.08.2012 14:04, schrieb ronnie sahlberg: > >> On Fri, Aug 10, 2012 at 9:57 PM, Stefan Priebe - Profihost AG >> wrote: >>> >>> Am 10.08.2012 13:12, schrieb ronnie sahlberg: >>> You want discard to work? >>> >>> >>> Y

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread Stefan Priebe - Profihost AG
Am 10.08.2012 14:24, schrieb ronnie sahlberg: On Fri, Aug 10, 2012 at 10:14 PM, Stefan Priebe - Profihost AG wrote: I dont know the kvm version numbers. They're the same as qemu. But you can check the file block/iscsi.c for the version you use for this : .bdrv_aio_discard = iscsi_aio_dis

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread Stefan Priebe - Profihost AG
never used this tool. Output is: This looks like this: # sg_unmap --lba=0x1000 --num=1 /dev/sde # sg_get_lba_status --lba=0x1000 /dev/sde get LBA status: transport: Host_status=0x10 is invalid Driver_status=0x08 [DRIVER_SENSE, SUGGEST_OK] Get LBA Status command failed try '-v' option for mo

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread Paolo Bonzini
Il 10/08/2012 14:35, Stefan Priebe - Profihost AG ha scritto: >> >> One way to activate passthough is via scsi-generic: >> Example: >> -device lsi -device scsi-generic,drive=MyISCSI \ >> -drive file=iscsi://10.1.1.125/iqn.ronnie.test/1,if=none,id=MyI > > When i do this the g

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-10 Thread Stefan Priebe - Profihost AG
Hi Paolo, Am 10.08.2012 14:39, schrieb Paolo Bonzini: Il 10/08/2012 14:35, Stefan Priebe - Profihost AG ha scritto: One way to activate passthough is via scsi-generic: Example: -device lsi -device scsi-generic,drive=MyISCSI \ -drive file=iscsi://10.1.1.125/iqn.ronnie.

Re: [Qemu-devel] [PATCH v8 2/7] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-10 Thread Corey Bryant
On 08/10/2012 01:57 AM, Eric Blake wrote: On 08/09/2012 08:10 PM, Corey Bryant wrote: This patch adds support that enables passing of file descriptors to the QEMU monitor where they will be stored in specified file descriptor sets. A file descriptor set can be used by a client like libvirt to

[Qemu-devel] [RFC/PATCH] qemu: Use valgrind annotations to mark kvm guest memory as defined

2012-08-10 Thread Christian Borntraeger
valgrind with kvm produces a big amount of false positives regarding "Conditional jump or move depends on uninitialised value(s)". This happens because the guest memory is allocated with qemu_vmalloc which boils down posix_memalign etc. This function is (correctly) considered by valgrind as returni

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-10 Thread Maciej W. Rozycki
Andreas, > >> Actually there were better patches for the same bug by Meador, including > >> git-style rather than SVN patches and adding a helper to initialize it > >> consistently at all call sites. I find quilt patches easier to manage when I need to reorder them, revert, manually edit the di

[Qemu-devel] [PATCH] Makefile: add qapi.py dependencies

2012-08-10 Thread Stefan Hajnoczi
Commit 427a1a2cb1d35b83b6302886f46289f6d617134d ("qapi: avoid reserved keywords") modifies qapi.py, which is used by qapi-types.py and other Python scripts. Because Makefile has no dependencies for qapi.py the qapi code generator will not be rerun and the following build error is produced: net/

[Qemu-devel] [PATCH 2/2] scsi: fix warning

2012-08-10 Thread Gerd Hoffmann
hw/scsi-bus.c:758: warning: ‘xfer’ may be used uninitialized in this function Isn't true, but older gcc versions (for example 4.1 as shipped in rhel5) are not clever enougth to figure, so sprinkle in a default: line to make them happy. Signed-off-by: Gerd Hoffmann --- hw/scsi-bus.c |2 ++ 1

[Qemu-devel] [PATCH 0/2] two little build fixes

2012-08-10 Thread Gerd Hoffmann
Hi, $subject says all. cheers, Gerd Gerd Hoffmann (2): avoid asprintf (not available on mingw) scsi: fix warning hw/msix.c |5 ++--- hw/scsi-bus.c |2 ++ 2 files changed, 4 insertions(+), 3 deletions(-)

Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field

2012-08-10 Thread Luiz Capitulino
On Fri, 10 Aug 2012 09:56:11 +0200 Markus Armbruster wrote: > Revisited this one on review of v2, replying here for context. > > Luiz Capitulino writes: > > > On Thu, 02 Aug 2012 13:35:54 +0200 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >> > Signed-off-by: Luiz Cap

Re: [Qemu-devel] [Qemu-trivial] [PATCH] arm: translate: comment typo - s/middel/middle/

2012-08-10 Thread Stefan Hajnoczi
On Mon, Aug 06, 2012 at 05:05:56PM +1000, Peter A. G. Crosthwaite wrote: > Signed-off-by: Peter A. G. Crosthwaite > --- > target-arm/translate.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/tri

[Qemu-devel] [PULL 0/3] Net patches

2012-08-10 Thread Stefan Hajnoczi
Paolo's fixes to resume rx when buffers have been replenished on e1000 and xen_nic. virtio-net does not have this bug. The following changes since commit 3d1d9652978ac5a32a0beb4bdf6065ca39440d89: handle device help before accelerator set up (2012-08-09 19:53:01 +) are available in the git

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] target-arm: Fix typos in comments

2012-08-10 Thread Stefan Hajnoczi
On Mon, Aug 06, 2012 at 05:42:18PM +0100, Peter Maydell wrote: > Fix a variety of typos in comments in target-arm files. > > Signed-off-by: Peter Maydell > --- > Changes v1->v2: s/inputs values/input values/ > > target-arm/arm-semi.c|2 +- > target-arm/cpu.h |2 +- > target-

[Qemu-devel] [PATCH 1/3] net: notify iothread after flushing queue

2012-08-10 Thread Stefan Hajnoczi
From: Paolo Bonzini virtio-net has code to flush the queue and notify the iothread whenever new receive buffers are added by the guest. That is fine, and indeed we need to do the same in all other drivers. However, notifying the iothread should be work for the network subsystem. And since we ar

Re: [Qemu-devel] [SeaBIOS] [PULL 0/1] update qemu seabios / seabios release?

2012-08-10 Thread Anthony Liguori
Gerd Hoffmann writes: > Hi, > > This pull updates seabios in qemu to the latest bits from seabios > master, so the upcoming 1.2 qemu release gets all the new shiny > stuff added recently. I'd like to have a new seabios release for > inclusion into qemu 1.2 which is planned for September 1st. >

Re: [Qemu-devel] [PATCH] device_tree: load_device_tree(): Allow NULL sizep

2012-08-10 Thread Stefan Hajnoczi
On Fri, Aug 10, 2012 at 01:54:26PM +1000, Peter A. G. Crosthwaite wrote: > The sizep arg is populated with the size of the loaded device tree. Since this > is one of those informational "please populate" type arguments it should be > optional. Guarded writes to *sizep against NULL accordingly. > >

[Qemu-devel] [PATCH 1/2] avoid asprintf (not available on mingw64)

2012-08-10 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/msix.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 800fc32..04345f2 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -307,9 +307,8 @@ int msix_init_exclusive_bar(PCIDevice *dev, unsigned short nentries,

Re: [Qemu-devel] [v2 Patch 2/9]block: raw-posix image file reopen

2012-08-10 Thread Corey Bryant
On 07/30/2012 05:34 PM, Supriya Kannery wrote: raw-posix driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Supriya Kannery --- Index: qemu/block/raw.c ===

  1   2   3   >