Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread Paolo Bonzini
Il 09/08/2012 08:13, Stefan Priebe ha scritto: > i really would like to test with actual git. But my VMs run awfully SLOW > with actual git version. Boot process prints one line every two seconds. > So i can't test. Is there a patch or backport for this problem? Hmm, no, I haven't seen it reported

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread Stefan Priebe
Yes should be possible. guest is Debian or Ubuntu. I couldn't find a tag for V1.1.1 which I ran from source. So where to start bisect? Stefan Am 09.08.2012 um 09:01 schrieb Paolo Bonzini : > Il 09/08/2012 08:13, Stefan Priebe ha scritto: >> i really would like to test with actual git. But my VM

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread Paolo Bonzini
Il 09/08/2012 09:07, Stefan Priebe ha scritto: > Yes should be possible. guest is Debian or Ubuntu. I couldn't find a > tag for V1.1.1 which I ran from source. So where to start bisect? You can start from the v1.1.0 tag. Can you give the command line, perhaps it is enough to reproduce? Paolo >

Re: [Qemu-devel] [PATCH 2/5] s390: Virtual channel subsystem support.

2012-08-09 Thread Cornelia Huck
On Wed, 8 Aug 2012 19:39:33 + Blue Swirl wrote: > On Wed, Aug 8, 2012 at 7:34 PM, Peter Maydell > wrote: > > On 8 August 2012 20:16, Blue Swirl wrote: > >> On Wed, Aug 8, 2012 at 8:17 AM, Cornelia Huck > >> wrote: > >>> On Tue, 7 Aug 2012 21:00:59 + > >>> Blue Swirl wrote: > Pl

Re: [Qemu-devel] [PATCH 3/5] s390: Add new channel I/O based virtio transport.

2012-08-09 Thread Cornelia Huck
On Wed, 8 Aug 2012 19:03:14 + Blue Swirl wrote: > >> > +struct vq_info_block { > >> > +uint64_t queue; > >> > +uint16_t num; > >> > +} QEMU_PACKED; > >> > + > >> > +struct vq_config_block { > >> > +uint16_t index; > >> > +uint16_t num; > >> > +} QEMU_PACKED; > >> > >> Aren't

Re: [Qemu-devel] [PATCH 06/15] memory: use refcnt to manage MemoryRegion

2012-08-09 Thread liu ping fan
On Wed, Aug 8, 2012 at 5:20 PM, Avi Kivity wrote: > On 08/08/2012 09:25 AM, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> Using refcnt for mr, so we can separate mr's life cycle management >> from refered object. >> When mr->ref 0->1, inc the refered object. >> When mr->ref 1->0, dec the re

Re: [Qemu-devel] [PATCH 11/15] lock: introduce global lock for device tree

2012-08-09 Thread liu ping fan
On Wed, Aug 8, 2012 at 5:42 PM, Avi Kivity wrote: > On 08/08/2012 09:25 AM, Liu Ping Fan wrote: >> From: Liu Ping Fan >> > > Please explain the motivation. AFAICT, the big qemu lock is sufficient. > Oh, this is one of the series locks for the removal of big qemu lock. The degradation of big lock

Re: [Qemu-devel] [PATCH 11/15] lock: introduce global lock for device tree

2012-08-09 Thread liu ping fan
On Wed, Aug 8, 2012 at 5:41 PM, Paolo Bonzini wrote: > Il 08/08/2012 08:25, Liu Ping Fan ha scritto: >> From: Liu Ping Fan >> >> Signed-off-by: Liu Ping Fan >> --- >> cpus.c | 12 >> main-loop.h |3 +++ >> 2 files changed, 15 insertions(+), 0 deletions(-) >> >> diff --gi

Re: [Qemu-devel] [PATCH 15/15] e1000: using new interface--unmap to unplug

2012-08-09 Thread liu ping fan
On Wed, Aug 8, 2012 at 5:56 PM, Paolo Bonzini wrote: > Il 08/08/2012 08:25, Liu Ping Fan ha scritto: >> >> +static void >> +pci_e1000_unmap(PCIDevice *p) >> +{ >> +/* DO NOT FREE anything!until refcnt=0 */ >> +/* isolate from memory view */ >> +} > > At least you need to call the superclas

Re: [Qemu-devel] [PATCH 13/15] hotplug: introduce qdev_unplug_complete() to remove device from views

2012-08-09 Thread liu ping fan
On Wed, Aug 8, 2012 at 5:52 PM, Paolo Bonzini wrote: > Il 08/08/2012 08:25, Liu Ping Fan ha scritto: >> +void qdev_unplug_complete(DeviceState *dev, Error **errp) >> +{ >> +/* isolate from mem view */ >> +qdev_unmap(dev); >> +qemu_lock_devtree(); >> +/* isolate from device tree */

Re: [Qemu-devel] [PATCH 04/15] memory: MemoryRegion topology must be stable when updating

2012-08-09 Thread liu ping fan
On Thu, Aug 9, 2012 at 3:17 AM, Blue Swirl wrote: > On Wed, Aug 8, 2012 at 6:25 AM, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> Using mem_map_lock to protect among updaters. So we can get the intact >> snapshot of mem topology -- FlatView & radix-tree. >> >> Signed-off-by: Liu Ping Fan >> -

Re: [Qemu-devel] [PATCH 08/15] memory: introduce PhysMap to present snapshot of toploygy

2012-08-09 Thread liu ping fan
On Thu, Aug 9, 2012 at 3:18 AM, Blue Swirl wrote: > On Wed, Aug 8, 2012 at 6:25 AM, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> PhysMap contain the flatview and radix-tree view, they are snapshot >> of system topology and should be consistent. With PhysMap, we can >> swap the pointer when up

Re: [Qemu-devel] [PATCH 03/15] qom: introduce reclaimer to release obj

2012-08-09 Thread liu ping fan
On Wed, Aug 8, 2012 at 5:15 PM, Avi Kivity wrote: > On 08/08/2012 12:07 PM, Paolo Bonzini wrote: >> Il 08/08/2012 11:05, Avi Kivity ha scritto: > From: Liu Ping Fan > > Collect unused object and release them at caller demand. > >>> Please explain the motivation for this patch.

Re: [Qemu-devel] [PATCH 03/15] qom: introduce reclaimer to release obj

2012-08-09 Thread liu ping fan
On Wed, Aug 8, 2012 at 5:35 PM, Paolo Bonzini wrote: > Il 08/08/2012 08:25, Liu Ping Fan ha scritto: >> From: Liu Ping Fan >> >> Collect unused object and release them at caller demand. >> >> Signed-off-by: Liu Ping Fan >> --- >> include/qemu/reclaimer.h | 28 ++ >> main-l

Re: [Qemu-devel] [PATCH 15/15] e1000: using new interface--unmap to unplug

2012-08-09 Thread Paolo Bonzini
Il 09/08/2012 09:28, liu ping fan ha scritto: >>> >> +static void >>> >> +pci_e1000_unmap(PCIDevice *p) >>> >> +{ >>> >> +/* DO NOT FREE anything!until refcnt=0 */ >>> >> +/* isolate from memory view */ >>> >> +} >> > >> > At least you need to call the superclass method. >> > > Refer to 00

Re: [Qemu-devel] [PATCH 11/15] lock: introduce global lock for device tree

2012-08-09 Thread Paolo Bonzini
Il 09/08/2012 09:28, liu ping fan ha scritto: > On Wed, Aug 8, 2012 at 5:41 PM, Paolo Bonzini wrote: >> Il 08/08/2012 08:25, Liu Ping Fan ha scritto: >>> From: Liu Ping Fan >>> >>> Signed-off-by: Liu Ping Fan >>> --- >>> cpus.c | 12 >>> main-loop.h |3 +++ >>> 2 files c

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread Stefan Priebe
starting line: /usr/bin/qemu-x86_64 -chardev socket,id=qmp,path=/var/run/qemu-server/103.qmp,server,nowait -mon chardev=qmp,mode=control -pidfile /var/run/qemu-server/103.pid -daemonize -usbdevice tablet -name kvmcrash -smp sockets=1,cores=8 -nodefaults -boot menu=on -vga cirrus -k de -device

Re: [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine

2012-08-09 Thread Markus Armbruster
Max Filippov writes: > This fixes the following error: > > $ qemu-system-xtensa -cpu help > Segmentation fault main() attempts to cope with "no machine found", it just screws it up: if (machine->hw_version) { qemu_set_version(machine->hw_version); } [...] if (machine

Re: [Qemu-devel] [PATCH 03/15] qom: introduce reclaimer to release obj

2012-08-09 Thread Paolo Bonzini
Il 09/08/2012 09:33, liu ping fan ha scritto: > Yes, it is to defer destructors. > See 0009-memory-prepare-flatview-and-radix-tree-for-rcu-style.patch > When MemoryRegion is _del_subregion from mem in updater, it may be > still in use by reader -- radix or flatview, so defer its destructors > to th

Re: [Qemu-devel] [PATCH 04/15] memory: MemoryRegion topology must be stable when updating

2012-08-09 Thread liu ping fan
On Wed, Aug 8, 2012 at 5:13 PM, Avi Kivity wrote: > On 08/08/2012 09:25 AM, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> Using mem_map_lock to protect among updaters. So we can get the intact >> snapshot of mem topology -- FlatView & radix-tree. >> >> Signed-off-by: Liu Ping Fan >> --- >> ex

Re: [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine

2012-08-09 Thread Dunrong Huang
2012/8/9 Markus Armbruster : > Max Filippov writes: > >> This fixes the following error: >> >> $ qemu-system-xtensa -cpu help >> Segmentation fault > > main() attempts to cope with "no machine found", it just screws it up: > > if (machine->hw_version) { > qemu_set_version(machi

Re: [Qemu-devel] [PATCH 09/15] memory: prepare flatview and radix-tree for rcu style access

2012-08-09 Thread liu ping fan
On Thu, Aug 9, 2012 at 3:23 AM, Blue Swirl wrote: > On Wed, Aug 8, 2012 at 6:25 AM, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> Flatview and radix view are all under the protection of pointer. >> And this make sure the change of them seem to be atomic! >> >> The mr accessed by radix-tree lea

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread Paolo Bonzini
Il 09/08/2012 09:41, Stefan Priebe ha scritto: > -drive > file=iscsi://10.0.255.100/iqn.1986-03.com.sun:02:8a9019a4-4aa3-cd8a-f723-f05db9085ef9/0,if=none,id=drive-scsi1,cache=writethrough,aio=native Are you sure you want cache=writethrough here? Also, please try either updating libiscsi to the l

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-08-09 Thread Igor Mitsyanko
On 08/08/2012 08:25 PM, Andreas Färber wrote: Am 31.01.2012 15:01, schrieb Mitsyanko Igor: On 01/31/2012 05:15 PM, Andreas Färber wrote: Am 31.01.2012 00:53, schrieb Anthony Liguori: On 01/30/2012 05:41 PM, Andreas Färber wrote: Am 30.01.2012 19:55, schrieb Juan Quintela: Please send in any

Re: [Qemu-devel] [PATCH 13/15] hotplug: introduce qdev_unplug_complete() to remove device from views

2012-08-09 Thread Paolo Bonzini
Il 09/08/2012 09:28, liu ping fan ha scritto: >> > VCPU threadI/O thread >> > = >> > get MMIO request >> > rcu_read_lock() >> > walk memory map >> >qdev_unmap(

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread Stefan Priebe
@writethrough: why not? @libiscsi Same speed problem with cache=none and with just local lvm disks. Stefan Am 09.08.2012 um 09:53 schrieb Paolo Bonzini : > Il 09/08/2012 09:41, Stefan Priebe ha scritto: >> -drive >> file=iscsi://10.0.255.100/iqn.1986-03.com.sun:02:8a9019a4-4aa3-cd8a-f723-f05d

Re: [Qemu-devel] [PATCH] vl.c: Exit QEMU early if no machine is found

2012-08-09 Thread Markus Armbruster
riegama...@gmail.com writes: > From: Dunrong Huang > > We check whether the variable machine is NULL or not before accessing > it. If machine is NULL, exit QEMU with an error, this can avoids a > segfault error. > > Signed-off-by: Dunrong Huang Commit message lacks detail on how to reproduce th

Re: [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine

2012-08-09 Thread Markus Armbruster
Dunrong Huang writes: > 2012/8/9 Markus Armbruster : >> Max Filippov writes: >> >>> This fixes the following error: >>> >>> $ qemu-system-xtensa -cpu help >>> Segmentation fault >> >> main() attempts to cope with "no machine found", it just screws it up: >> >> if (machine->hw_version

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread Paolo Bonzini
Il 09/08/2012 10:00, Stefan Priebe ha scritto: > @writethrough: why not? Because it's slow, and unnecessary if you're running kernel >= 2.6.32 or recent RHEL/CentOS. > @libiscsi Same speed problem with cache=none and with just local lvm disks. Cool, please use these settings while bisecting. P

Re: [Qemu-devel] [PATCH 03/15] qom: introduce reclaimer to release obj

2012-08-09 Thread Avi Kivity
On 08/09/2012 10:49 AM, Paolo Bonzini wrote: > Il 09/08/2012 09:33, liu ping fan ha scritto: >> Yes, it is to defer destructors. >> See 0009-memory-prepare-flatview-and-radix-tree-for-rcu-style.patch >> When MemoryRegion is _del_subregion from mem in updater, it may be >> still in use by reader --

Re: [Qemu-devel] [PATCH] vl.c: Exit QEMU early if no machine is found

2012-08-09 Thread Stefan Hajnoczi
On Tue, Jul 24, 2012 at 12:42:20AM +0800, riegama...@gmail.com wrote: > From: Dunrong Huang > > We check whether the variable machine is NULL or not before accessing > it. If machine is NULL, exit QEMU with an error, this can avoids a > segfault error. > > Signed-off-by: Dunrong Huang > --- >

Re: [Qemu-devel] [PATCH 04/15] memory: MemoryRegion topology must be stable when updating

2012-08-09 Thread Avi Kivity
On 08/09/2012 10:28 AM, liu ping fan wrote: >> >> Seems to me that nothing in memory.c can susceptible to races. It must >> already be called under the big qemu lock, and with the exception of >> mutators (memory_region_set_*), changes aren't directly visible. >> > Yes, what I want to do is "prepa

Re: [Qemu-devel] [PATCH 11/15] lock: introduce global lock for device tree

2012-08-09 Thread Avi Kivity
On 08/09/2012 10:27 AM, liu ping fan wrote: > On Wed, Aug 8, 2012 at 5:42 PM, Avi Kivity wrote: >> On 08/08/2012 09:25 AM, Liu Ping Fan wrote: >>> From: Liu Ping Fan >>> >> >> Please explain the motivation. AFAICT, the big qemu lock is sufficient. >> > Oh, this is one of the series locks for the

Re: [Qemu-devel] [PATCH 06/15] memory: use refcnt to manage MemoryRegion

2012-08-09 Thread Avi Kivity
On 08/09/2012 10:27 AM, liu ping fan wrote: > On Wed, Aug 8, 2012 at 5:20 PM, Avi Kivity wrote: >> On 08/08/2012 09:25 AM, Liu Ping Fan wrote: >>> From: Liu Ping Fan >>> >>> Using refcnt for mr, so we can separate mr's life cycle management >>> from refered object. >>> When mr->ref 0->1, inc th

Re: [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-09 Thread Kevin Wolf
Am 07.08.2012 10:47, schrieb Markus Armbruster: > Kevin Wolf writes: > >> Am 02.08.2012 09:20, schrieb Kevin Shanahan: >>> On Thu, Aug 02, 2012 at 02:49:52PM +0930, Kevin Shanahan wrote: On Thu, Aug 02, 2012 at 11:46:13AM +0930, Kevin Shanahan wrote: > On Thu, Aug 02, 2012 at 11:02:42AM

Re: [Qemu-devel] [PATCH v7 0/6] file descriptor passing using fd sets

2012-08-09 Thread Stefan Hajnoczi
On Wed, Aug 8, 2012 at 7:51 PM, Corey Bryant wrote: > > > On 08/08/2012 11:58 AM, Stefan Hajnoczi wrote: >> >> On Wed, Aug 8, 2012 at 3:54 PM, Corey Bryant >> wrote: >>> >>> >>> >>> On 08/08/2012 09:04 AM, Stefan Hajnoczi wrote: On Tue, Aug 7, 2012 at 4:58 PM, Corey Bryant wr

Re: [Qemu-devel] [PATCH] usb: selective endpoint initialization

2012-08-09 Thread Gerd Hoffmann
> Hi Gerd, > > sorry for the delays, I tested the latest pulled patch queue and it's > now fine on my Intel board, too. The dongle gets detected again without > assertions. Thanks for your work. > > Still remaining are the multiple usb resets on host side before the > dongle gets finally detected

Re: [Qemu-devel] [RFC PATCH 1/6] virtio/console: Add splice_write support

2012-08-09 Thread Amit Shah
On (Tue) 24 Jul 2012 [11:37:07], Yoshihiro YUNOMAE wrote: > From: Masami Hiramatsu > > Enable to use splice_write from pipe to virtio-console port. > This steals pages from pipe and directly send it to host. > > Note that this may accelerate only the guest to host path. > > Signed-off-by: Masam

Re: [Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-08-09 Thread Amit Shah
On (Tue) 24 Jul 2012 [11:37:18], Yoshihiro YUNOMAE wrote: > From: Masami Hiramatsu > > Add a failback memcpy path for unstealable pipe buffer. > If buf->ops->steal() fails, virtio-serial tries to > copy the page contents to an allocated page, instead > of just failing splice(). > > Signed-off-by

Re: [Qemu-devel] [libvirt] [PATCH v7 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-09 Thread Stefan Hajnoczi
On Tue, Aug 7, 2012 at 4:58 PM, Corey Bryant wrote: > +## > +# @FdsetFdInfo: > +# > +# Information about a file descriptor that belongs to an fd set. > +# > +# @fd: The file descriptor value. > +# > +# @removed: If true, the remove-fd command has been issued for this fd. > +# > +# Since: 1.2.0 > +

Re: [Qemu-devel] [RFC V2 05/10] quorum: Add quorum_getlength().

2012-08-09 Thread Benoît Canet
> > +static int64_t quorum_getlength(BlockDriverState *bs) > > +{ > > +BDRVQuorumState *s = bs->opaque; > > +int i; > > +int64_t ret; > > + > > +/* return the length of the first available quorum file */ > > +for (i = 0, ret = bdrv_getlength(s->bs[i]); > > + ret == -ENOM

Re: [Qemu-devel] [RFC PATCH 1/6] virtio/console: Add splice_write support

2012-08-09 Thread Masami Hiramatsu
(2012/08/09 18:00), Amit Shah wrote: > On (Tue) 24 Jul 2012 [11:37:07], Yoshihiro YUNOMAE wrote: >> From: Masami Hiramatsu >> >> Enable to use splice_write from pipe to virtio-console port. >> This steals pages from pipe and directly send it to host. >> >> Note that this may accelerate only the gu

Re: [Qemu-devel] [RFC V2 05/10] quorum: Add quorum_getlength().

2012-08-09 Thread Stefan Hajnoczi
On Thu, Aug 9, 2012 at 10:07 AM, Benoît Canet wrote: >> > +static int64_t quorum_getlength(BlockDriverState *bs) >> > +{ >> > +BDRVQuorumState *s = bs->opaque; >> > +int i; >> > +int64_t ret; >> > + >> > +/* return the length of the first available quorum file */ >> > +for (i =

Re: [Qemu-devel] [v2 Patch 1/9]block: Framework for reopening image files safely

2012-08-09 Thread Kevin Wolf
Am 09.08.2012 06:26, schrieb Jeff Cody: > On 07/30/2012 05:34 PM, Supriya Kannery wrote: >> Struct BDRVReopenState along with three reopen related functions >> introduced for handling reopening of images safely. This can be >> extended by each of the block drivers to reopen respective >> image file

Re: [Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-08-09 Thread Borislav Petkov
On Thu, Aug 09, 2012 at 02:33:12PM +0530, Amit Shah wrote: > > @@ -807,9 +807,31 @@ static int pipe_to_sg(struct pipe_inode_info *pipe, > > struct pipe_buffer *buf, > > > > len = min(buf->len, sd->len); > > sg_set_page(&(sgl->sg[sgl->n]), buf->page, len, buf->offset); > >

Re: [Qemu-devel] [Qemu-trivial] [RESEND PATCH] vl.c: Exit QEMU early if no machine is found

2012-08-09 Thread Stefan Hajnoczi
On Thu, Aug 9, 2012 at 7:57 AM, wrote: > From: Dunrong Huang > > We check whether the variable machine is NULL or not before accessing > it. If machine is NULL, exit QEMU with an error, this can avoids a > segfault error. > > Signed-off-by: Dunrong Huang > --- > vl.c | 10 +- > 1 fil

Re: [Qemu-devel] [RFC V2 06/10] quorum: Add quorum_aio_writev and its dependencies.

2012-08-09 Thread Benoît Canet
Le Wednesday 08 Aug 2012 à 16:37:13 (+0100), Stefan Hajnoczi a écrit : > On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote: > > +static int quorum_check_ret(QuorumAIOCB *acb) > > +{ > > +int i, j; > > + > > +for (i = 0, j = 0; i <= 2; i++) { > > +if (acb->aios[0].ret) { > > +

Re: [Qemu-devel] [RFC V2 06/10] quorum: Add quorum_aio_writev and its dependencies.

2012-08-09 Thread Stefan Hajnoczi
On Thu, Aug 9, 2012 at 10:24 AM, Benoît Canet wrote: > Le Wednesday 08 Aug 2012 ŕ 16:37:13 (+0100), Stefan Hajnoczi a écrit : >> On Tue, Aug 7, 2012 at 2:44 PM, Benoît Canet wrote: >> > +static int quorum_check_ret(QuorumAIOCB *acb) >> > +{ >> > +int i, j; >> > + >> > +for (i = 0, j = 0;

Re: [Qemu-devel] [v2 Patch 5/9]block: qcow2 image file reopen

2012-08-09 Thread Kevin Wolf
Am 09.08.2012 06:26, schrieb Jeff Cody: > On 07/30/2012 05:35 PM, Supriya Kannery wrote: >> qcow2 driver changes for bdrv_reopen_xx functions to >> safely reopen image files. Reopening of image files while >> changing hostcache dynamically is handled here. >> >> Signed-off-by: Supriya Kannery >> >

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread Stefan Hajnoczi
On Thu, Aug 9, 2012 at 8:41 AM, Stefan Priebe wrote: > starting line: > /usr/bin/qemu-x86_64 -chardev > socket,id=qmp,path=/var/run/qemu-server/103.qmp,server,nowait -mon > chardev=qmp,mode=control -pidfile /var/run/qemu-server/103.pid -daemonize > -usbdevice tablet -name kvmcrash -smp sockets=1,c

Re: [Qemu-devel] ahci live migration

2012-08-09 Thread Kevin Wolf
Am 07.08.2012 18:13, schrieb Andreas Färber: > Hi Jason, > > Am 07.08.2012 18:01, schrieb Jason Baron: >> Hi, >> >> vmstate_ahci has its 'unmigratable' bit set. Gerd suggested that there was >> work >> in this area. Anybody know the status on it? > > That was me working on it. I have a branch co

Re: [Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-08-09 Thread Masami Hiramatsu
(2012/08/09 18:03), Amit Shah wrote: > On (Tue) 24 Jul 2012 [11:37:18], Yoshihiro YUNOMAE wrote: >> From: Masami Hiramatsu >> >> Add a failback memcpy path for unstealable pipe buffer. >> If buf->ops->steal() fails, virtio-serial tries to >> copy the page contents to an allocated page, instead >>

Re: [Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-08-09 Thread Amit Shah
On (Thu) 09 Aug 2012 [18:24:58], Masami Hiramatsu wrote: > (2012/08/09 18:03), Amit Shah wrote: > > On (Tue) 24 Jul 2012 [11:37:18], Yoshihiro YUNOMAE wrote: > >> From: Masami Hiramatsu > >> > >> Add a failback memcpy path for unstealable pipe buffer. > >> If buf->ops->steal() fails, virtio-serial

Re: [Qemu-devel] [PATCH v5 1/2] qemu: Add a config option for GlusterFS as block backend

2012-08-09 Thread Anand Avati
On 08/07/2012 01:00 AM, Bharata B Rao wrote: qemu: Add a config option for GlusterFS as block backend From: Bharata B Rao GlusterFS support in QEMU depends on libgfapi, libgfrpc and libgfxdr provided by GlusterFS. Signed-off-by: Bharata B Rao --- configure | 34 +

Re: [Qemu-devel] [PATCH v5 2/2] block: Support GlusterFS as a QEMU block backend

2012-08-09 Thread Bharata B Rao
On Wed, Aug 08, 2012 at 03:37:31PM +0100, Stefan Hajnoczi wrote: > > I have left a few small comments. Perhaps you can resend with your > fixes to Patch 1? Sure, Will send v6 with fixes to patch 1 and incorporating your suggestions. > > + */ > > +#include "block_int.h" > > +#include > > Syste

[Qemu-devel] [Bug 1034423] [NEW] Guests running OpenIndiana (and relatives) fail to boot on AMD hardware

2012-08-09 Thread Owen Tuz
Public bug reported: First observed with OpenSolaris 2009.06, and also applies to the latest OpenIndiana release. Version: qemu-kvm 1.1.1 Hardware: 2 x AMD Opteron 6128 8-core processors, 64GB RAM. These guests boot on equivalent Intel hardware. To reproduce: qemu-kvm -nodefaults -m 512 -cpu

Re: [Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-08-09 Thread Avi Kivity
On 08/09/2012 12:55 PM, Amit Shah wrote: > On (Thu) 09 Aug 2012 [18:24:58], Masami Hiramatsu wrote: >> (2012/08/09 18:03), Amit Shah wrote: >> > On (Tue) 24 Jul 2012 [11:37:18], Yoshihiro YUNOMAE wrote: >> >> From: Masami Hiramatsu >> >> >> >> Add a failback memcpy path for unstealable pipe buffer

Re: [Qemu-devel] [PATCH v2] ahci: fix cdrom read corruption

2012-08-09 Thread Kevin Wolf
Am 03.08.2012 21:57, schrieb Jason Baron: > Hi, > > While testing q35 I found data corruption on reads from the cdrom on the ahci > controller. The first patch addresses this issue. I also noticed that there is > a memory leak in the ahci code, which is addressed in the second patch. > > Thanks,

Re: [Qemu-devel] [PATCH 1/4] s390/kvm: Handle hosts not supporting s390-virtio.

2012-08-09 Thread Avi Kivity
On 08/07/2012 05:52 PM, Cornelia Huck wrote: > Running under a kvm host does not necessarily imply the presence of > a page mapped above the main memory with the virtio information; > however, the code includes a hard coded access to that page. > > Instead, check for the presence of the page and e

Re: [Qemu-devel] [PATCH v7 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets

2012-08-09 Thread Kevin Wolf
Am 07.08.2012 18:49, schrieb Eric Blake: > On 08/07/2012 09:58 AM, Corey Bryant wrote: >> This patch adds support that enables passing of file descriptors >> to the QEMU monitor where they will be stored in specified file >> descriptor sets. >> >> A file descriptor set can be used by a client like

[Qemu-devel] [qemu-devel] [PATCH V2 0/3] [RFC] libqblock draft code v2

2012-08-09 Thread Wenchao Xia
This patch intrudce libqblock API, libqblock-test is used as a test case. V2: Using struct_size and [xxx]_new [xxx]_free to keep ABI. Using embbed structure to class format options in image creating. Format specific options were brought to surface. Image format was changed to enum interg

[Qemu-devel] [qemu-devel] [PATCH V2 1/3] [RFC] libqblock-adding libqblock-test

2012-08-09 Thread Wenchao Xia
This patch modify Makefile and expose a API in block.c that libqblock need. Signed-off-by: Wenchao Xia --- Makefile |3 +++ block.c |2 +- block.h |1 + 3 files changed, 5 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 621cb86..a5691ee 100644 --- a/Makefile

[Qemu-devel] [qemu-devel] [PATCH V2 2/3] [RFC] libqblock-API design

2012-08-09 Thread Wenchao Xia
This patch is the API design. Signed-off-by: Wenchao Xia --- libqblock.c | 670 +++ libqblock.h | 447 +++ 2 files changed, 1117 insertions(+), 0 deletions(-) create mode 100644 libqblock.c create m

[Qemu-devel] [qemu-devel] [PATCH V2 3/3] [RFC] libqblock-test case.

2012-08-09 Thread Wenchao Xia
This file simulate the caller to test the library. Signed-off-by: Wenchao Xia --- libqblock-test.c | 197 ++ 1 files changed, 197 insertions(+), 0 deletions(-) create mode 100644 libqblock-test.c diff --git a/libqblock-test.c b/libqblock-t

Re: [Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-08-09 Thread Amit Shah
On (Thu) 09 Aug 2012 [12:58:13], Avi Kivity wrote: > On 08/09/2012 12:55 PM, Amit Shah wrote: > > On (Thu) 09 Aug 2012 [18:24:58], Masami Hiramatsu wrote: > >> (2012/08/09 18:03), Amit Shah wrote: > >> > On (Tue) 24 Jul 2012 [11:37:18], Yoshihiro YUNOMAE wrote: > >> >> From: Masami Hiramatsu > >>

Re: [Qemu-devel] [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-08-09 Thread Amit Shah
Hi, On (Tue) 24 Jul 2012 [11:36:57], Yoshihiro YUNOMAE wrote: > Hi All, > > The following patch set provides a low-overhead system for collecting kernel > tracing data of guests by a host in a virtualization environment. So I just have one minor comment, please post a non-RFC version of the patc

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread Stefan Priebe - Profihost AG
That looks better - thanks for the hint. But now network isn't working at all ;-( Stefan Am 09.08.2012 11:18, schrieb Stefan Hajnoczi: On Thu, Aug 9, 2012 at 8:41 AM, Stefan Priebe wrote: starting line: /usr/bin/qemu-x86_64 -chardev socket,id=qmp,path=/var/run/qemu-server/103.qmp,server,nowai

Re: [Qemu-devel] [PATCH] target-xtensa: make 'sim' to be the default machine

2012-08-09 Thread Max Filippov
On Thu, Aug 9, 2012 at 11:43 AM, Markus Armbruster wrote: > Max Filippov writes: > >> This fixes the following error: >> >> $ qemu-system-xtensa -cpu help >> Segmentation fault > > main() attempts to cope with "no machine found", it just screws it up: > > if (machine->hw_version) { >

Re: [Qemu-devel] [PATCH 1/4] s390/kvm: Handle hosts not supporting s390-virtio.

2012-08-09 Thread Cornelia Huck
On Thu, 09 Aug 2012 13:03:57 +0300 Avi Kivity wrote: > On 08/07/2012 05:52 PM, Cornelia Huck wrote: > > Running under a kvm host does not necessarily imply the presence of > > a page mapped above the main memory with the virtio information; > > however, the code includes a hard coded access to th

[Qemu-devel] [PATCH 1/1] block: fix block tray status

2012-08-09 Thread Pavel Hrdina
The tray status should change also if you eject empty block device. Signed-off-by: Pavel Hrdina --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 24323c1..3d23507 100644 --- a/block.c +++ b/block.c @@ -897,10 +897,10 @@ void bdrv_close(Bl

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread Stefan Hajnoczi
On Thu, Aug 9, 2012 at 11:17 AM, Stefan Priebe - Profihost AG wrote: > That looks better - thanks for the hint. But now network isn't working at > all ;-( You need to have commit 26b9b5fe17cc1b6be2e8bf8b9d16094f420bb8ad ("virtio: fix vhost handling"). Pull the latest qemu.git/master changes if y

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread Paolo Bonzini
Il 09/08/2012 13:04, Stefan Hajnoczi ha scritto: >> > That looks better - thanks for the hint. But now network isn't working at >> > all ;-( > You need to have commit 26b9b5fe17cc1b6be2e8bf8b9d16094f420bb8ad > ("virtio: fix vhost handling"). Pull the latest qemu.git/master > changes if you don't h

Re: [Qemu-devel] [PATCH 11/12] qemu-iotests: Be more flexible with image creation options

2012-08-09 Thread Kevin Wolf
Am 06.08.2012 23:57, schrieb Eric Blake: > On 08/06/2012 03:54 PM, Eric Blake wrote: >> On 08/06/2012 02:44 PM, Kevin Wolf wrote: >>> qemu-iotests already filters out image creation options that may be >>> present or not in order to get the same output in both cases. However, >>> often it only cons

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread Stefan Priebe - Profihost AG
Am 09.08.2012 13:04, schrieb Stefan Hajnoczi: On Thu, Aug 9, 2012 at 11:17 AM, Stefan Priebe - Profihost AG wrote: That looks better - thanks for the hint. But now network isn't working at all ;-( You need to have commit 26b9b5fe17cc1b6be2e8bf8b9d16094f420bb8ad ("virtio: fix vhost handling")

Re: [Qemu-devel] [PATCH 3/5] s390: Add new channel I/O based virtio transport.

2012-08-09 Thread Stefan Hajnoczi
On Tue, Aug 7, 2012 at 3:52 PM, Cornelia Huck wrote: > Add a new virtio transport that uses channel commands to perform > virtio operations. > > Add a new machine type s390-ccw that uses this virtio-ccw transport > and make it the default machine for s390. > > Signed-off-by: Cornelia Huck > --- >

[Qemu-devel] [PATCH] vmstate: Add support for saving/loading bitmaps

2012-08-09 Thread Peter Maydell
Add support for saving/loading bitmap.h bitmaps in vmstate. Signed-off-by: Peter Maydell --- This will be needed for saving/restoring the bitmap in sd.c which is introduced by Igor's latest patchset; the relevant VMSTATE line is: VMSTATE_BITMAP(wp_groups, SDState, 1, wpgrps_size), (and yo

Re: [Qemu-devel] [PULL 0/1] update qemu seabios / seabios release?

2012-08-09 Thread Kevin O'Connor
On Tue, Aug 07, 2012 at 05:45:07PM +0200, Gerd Hoffmann wrote: > Hi, > > This pull updates seabios in qemu to the latest bits from seabios > master, so the upcoming 1.2 qemu release gets all the new shiny > stuff added recently. I'd like to have a new seabios release for > inclusion into qemu 1

[Qemu-devel] [PATCH v2 4/4] qemu-iotests: skip 039 with ./check -nocache

2012-08-09 Thread Stefan Hajnoczi
When the qemu-io --nocache option is used the 039 test case cannot abort QEMU at a point where the image is dirty. Skip the test case. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/039 |1 + tests/qemu-iotests/common.rc | 14 ++ 2 files changed, 15 insertions(+)

[Qemu-devel] [PATCH v2 1/4] qed: mark image clean after repair succeeds

2012-08-09 Thread Stefan Hajnoczi
The dirty bit is cleared after image repair succeeds in qed_open(). Move this into qed_check() so that all callers benefit from this behavior when fix=true. This is necessary so qemu-img check can call .bdrv_check() and mark the image clean. Signed-off-by: Stefan Hajnoczi --- block/qed-check.c

[Qemu-devel] [PATCH v2 0/4] qcow2: clean-ups around lazy refcounts

2012-08-09 Thread Stefan Hajnoczi
The qcow2 lazy refcount feature was merged with two pending clean-ups suggested by Kevin: 1. Ensure that qemu-iotests/check -nocache 039 does not fail. 2. Fix qemu-img check output when a dirty image file is opened. It currently omits the error summary because automatic repair cleans the imag

[Qemu-devel] [PATCH v2 3/4] block: add BLOCK_O_CHECK for qemu-img check

2012-08-09 Thread Stefan Hajnoczi
Image formats with a dirty bit, like qed and qcow2, repair dirty image files upon open with BDRV_O_RDWR. Performing automatic repair when qemu-img check runs is not ideal because the bdrv_open() call repairs the image before the actual bdrv_check() call from qemu-img.c. Fix this "double repair" s

[Qemu-devel] [PATCH v2 2/4] qcow2: mark image clean after repair succeeds

2012-08-09 Thread Stefan Hajnoczi
The dirty bit is cleared after image repair succeeds in qcow2_open(). Move this into qcow2_check() so that all callers benefit from this behavior when fix mode is enabled. This is necessary so qemu-img check can call .bdrv_check() and mark the image clean. Signed-off-by: Stefan Hajnoczi --- blo

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread Stefan Priebe - Profihost AG
sorry guys i mixed qemu vs. qemu-kvm. Network is now working fine. but still virtio-scsi vs. virtio-blk: virtio-scsi: rand 4k: write: io=822448KB, bw=82228KB/s, iops=20557, runt= 10002msec read : io=950920KB, bw=94694KB/s, iops=23673, runt= 10042msec seq: write: io=2436MB, bw=231312KB/s, i

Re: [Qemu-devel] [PATCH 3/5] s390: Add new channel I/O based virtio transport.

2012-08-09 Thread Cornelia Huck
On Thu, 9 Aug 2012 12:34:04 +0100 Stefan Hajnoczi wrote: > On Tue, Aug 7, 2012 at 3:52 PM, Cornelia Huck > wrote: > > Add a new virtio transport that uses channel commands to perform > > virtio operations. > > > > Add a new machine type s390-ccw that uses this virtio-ccw transport > > and make

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread Paolo Bonzini
Il 09/08/2012 14:08, Stefan Priebe - Profihost AG ha scritto: > > virtio-scsi: > rand 4k: > write: io=822448KB, bw=82228KB/s, iops=20557, runt= 10002msec > read : io=950920KB, bw=94694KB/s, iops=23673, runt= 10042msec > seq: > write: io=2436MB, bw=231312KB/s, iops=56, runt= 10784msec > rea

Re: [Qemu-devel] [PATCH 3/5] s390: Add new channel I/O based virtio transport.

2012-08-09 Thread Stefan Hajnoczi
On Thu, Aug 9, 2012 at 1:12 PM, Cornelia Huck wrote: > On Thu, 9 Aug 2012 12:34:04 +0100 > Stefan Hajnoczi wrote: > >> On Tue, Aug 7, 2012 at 3:52 PM, Cornelia Huck >> wrote: >> > Add a new virtio transport that uses channel commands to perform >> > virtio operations. >> > >> > Add a new machin

[Qemu-devel] [PATCH V2 0/6] virtio-trace: Support virtio-trace

2012-08-09 Thread Yoshihiro YUNOMAE
Hi All, The following patch set provides a low-overhead system for collecting kernel tracing data of guests by a host in a virtualization environment. A guest OS generally shares some devices with other guests or a host, so reasons of any problems occurring in a guest may be from other guests or

[Qemu-devel] [PATCH V2 1/6] virtio/console: Add splice_write support

2012-08-09 Thread Yoshihiro YUNOMAE
From: Masami Hiramatsu Enable to use splice_write from pipe to virtio-console port. This steals pages from pipe and directly send it to host. Note that this may accelerate only the guest to host path. Changes in v2: - Use GFP_KERNEL instead of GFP_ATOMIC in syscall context function. Signed-of

[Qemu-devel] [PATCH V2 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-08-09 Thread Yoshihiro YUNOMAE
From: Masami Hiramatsu Add a failback memcpy path for unstealable pipe buffer. If buf->ops->steal() fails, virtio-serial tries to copy the page contents to an allocated page, instead of just failing splice(). Signed-off-by: Masami Hiramatsu --- drivers/char/virtio_console.c | 28 +++

[Qemu-devel] [PATCH V2 3/6] virtio/console: Wait until the port is ready on splice

2012-08-09 Thread Yoshihiro YUNOMAE
From: Masami Hiramatsu Wait if the port is not connected or full on splice like as write is doing. Signed-off-by: Masami Hiramatsu --- drivers/char/virtio_console.c | 39 +++ 1 files changed, 27 insertions(+), 12 deletions(-) diff --git a/drivers/char/vi

[Qemu-devel] [PATCH V2 5/6] virtio/console: Allocate scatterlist according to the current pipe size

2012-08-09 Thread Yoshihiro YUNOMAE
From: Masami Hiramatsu Allocate scatterlist according to the current pipe size. This allows splicing bigger buffer if the pipe size has been changed by fcntl. Changes in v2: - Just a minor fix for avoiding a confliction with previous patch. Signed-off-by: Masami Hiramatsu --- drivers/char/v

[Qemu-devel] [PATCH V2 4/6] ftrace: Allow stealing pages from pipe buffer

2012-08-09 Thread Yoshihiro YUNOMAE
From: Masami Hiramatsu Use generic steal operation on pipe buffer to allow stealing ring buffer's read page from pipe buffer. Note that this could reduce the performance of splice on the splice_write side operation without affinity setting. Since the ring buffer's read pages are allocated on the

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread Stefan Priebe - Profihost AG
Am 09.08.2012 14:19, schrieb Paolo Bonzini: Il 09/08/2012 14:08, Stefan Priebe - Profihost AG ha scritto: virtio-scsi: rand 4k: write: io=822448KB, bw=82228KB/s, iops=20557, runt= 10002msec read : io=950920KB, bw=94694KB/s, iops=23673, runt= 10042msec seq: write: io=2436MB, bw=231312KB

Re: [Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-08-09 Thread Steven Rostedt
On Thu, 2012-08-09 at 18:24 +0900, Masami Hiramatsu wrote: > Yeah, it is really easy to fix that. > But out of curiosity, would that be really a problem? > I guess that host can access any guest page if need. If that > is right, is that really insecure to leak randomly allocated > unused page to t

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread Paolo Bonzini
Il 09/08/2012 14:31, Stefan Priebe - Profihost AG ha scritto: > Am 09.08.2012 14:19, schrieb Paolo Bonzini: >> Il 09/08/2012 14:08, Stefan Priebe - Profihost AG ha scritto: >>> >>> virtio-scsi: >>> rand 4k: >>>write: io=822448KB, bw=82228KB/s, iops=20557, runt= 10002msec >>>read : io=950920

Re: [Qemu-devel] virtio-scsi vs. virtio-blk

2012-08-09 Thread ronnie sahlberg
On Thu, Aug 9, 2012 at 10:31 PM, Stefan Priebe - Profihost AG wrote: > Am 09.08.2012 14:19, schrieb Paolo Bonzini: > >> Il 09/08/2012 14:08, Stefan Priebe - Profihost AG ha scritto: >>> >>> >>> virtio-scsi: >>> rand 4k: >>>write: io=822448KB, bw=82228KB/s, iops=20557, runt= 10002msec >>>re

[Qemu-devel] [PATCH V2 6/6] tools: Add guest trace agent as a user tool

2012-08-09 Thread Yoshihiro YUNOMAE
This patch adds a user tool, "trace agent" for sending trace data of a guest to a Host in low overhead. This agent has the following functions: - splice a page of ring-buffer to read_pipe without memory copying - splice the page from write_pipe to virtio-console without memory copying - write tr

Re: [Qemu-devel] [PULL 0/1] update qemu seabios / seabios release?

2012-08-09 Thread Gerd Hoffmann
On 08/09/12 13:57, Kevin O'Connor wrote: > On Tue, Aug 07, 2012 at 05:45:07PM +0200, Gerd Hoffmann wrote: >> Hi, >> >> This pull updates seabios in qemu to the latest bits from seabios >> master, so the upcoming 1.2 qemu release gets all the new shiny >> stuff added recently. I'd like to have a

[Qemu-devel] [PATCH v6 0/2] GlusterFS support in QEMU - v6

2012-08-09 Thread Bharata B Rao
Hi, This is the v6 of the patchset to support GlusterFS backend from QEMU. The changes include defining a default value for glusterfs feature in the configure script and a few minor cleanups suggested by Stefan. As I mentioned during a previous release, I have tested gluster backend with differen

[Qemu-devel] [PATCH v6 1/2] qemu: Add a config option for GlusterFS as block backend

2012-08-09 Thread Bharata B Rao
qemu: Add a config option for GlusterFS as block backend From: Bharata B Rao GlusterFS support in QEMU depends on libgfapi, libgfrpc and libgfxdr provided by GlusterFS. Signed-off-by: Bharata B Rao --- configure | 35 +++ 1 files changed, 35 insertions(+), 0

  1   2   3   4   >