Re: [Qemu-devel] [PATCH 1/6 v11] docs: spec for add-cow file format

2012-08-02 Thread Dong Xu Wang
On Wed, Aug 1, 2012 at 9:51 PM, Eric Blake wrote: > On 07/31/2012 10:51 AM, Dong Xu Wang wrote: >> Introduce a new file format:add-cow. The usage can be found at this patch. >> >> Signed-off-by: Dong Xu Wang >> --- >> Now add-cow is still using QEMUOptionParameter, not QemuOpts, I will send a >>

Re: [Qemu-devel] [PATCH 1/6 v11] docs: spec for add-cow file format

2012-08-02 Thread Dong Xu Wang
On Wed, Aug 1, 2012 at 9:55 PM, Stefan Hajnoczi wrote: > On Tue, Jul 31, 2012 at 5:51 PM, Dong Xu Wang > wrote: >> Introduce a new file format:add-cow. The usage can be found at this patch. >> >> Signed-off-by: Dong Xu Wang >> --- >> Now add-cow is still using QEMUOptionParameter, not QemuOpts,

Re: [Qemu-devel] [PATCH 2/6 v11 v11] block: make some functions public

2012-08-02 Thread Dong Xu Wang
On Wed, Aug 1, 2012 at 9:53 PM, Eric Blake wrote: > On 07/31/2012 10:51 AM, Dong Xu Wang wrote: >> In add-cow file format, we will use path_has_protocol and we will read >> a NUL-terminated string from image , qed_read_string has done the samething, > > s/image ,/image,/ > s/samething/same thing/

Re: [Qemu-devel] [PATCH 2/6 v11 v11] block: make some functions public

2012-08-02 Thread Dong Xu Wang
On Wed, Aug 1, 2012 at 10:01 PM, Stefan Hajnoczi wrote: > On Tue, Jul 31, 2012 at 5:51 PM, Dong Xu Wang > wrote: >> diff --git a/block.h b/block.h >> index c89590d..b523076 100644 >> --- a/block.h >> +++ b/block.h >> @@ -152,6 +152,8 @@ int bdrv_pwrite(BlockDriverState *bs, int64_t offset, >>

Re: [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-08-02 Thread Kevin Shanahan
On Thu, Aug 02, 2012 at 02:49:52PM +0930, Kevin Shanahan wrote: > On Thu, Aug 02, 2012 at 11:46:13AM +0930, Kevin Shanahan wrote: > > On Thu, Aug 02, 2012 at 11:02:42AM +0930, Kevin Shanahan wrote: > > > Set the block driver read_only flag for cdrom devices so that > > > qmp_change_blockdev does no

Re: [Qemu-devel] [PATCH 3/6] add-cow file format

2012-08-02 Thread Dong Xu Wang
On Wed, Aug 1, 2012 at 9:57 PM, Eric Blake wrote: > On 07/31/2012 10:51 AM, Dong Xu Wang wrote: >> This is the implementation code for add-cow file format. Because image_file >> might be very huge, then we can't read entire bitmap into memory, we must use >> a cache. Since qcow-cache.c has implemt

Re: [Qemu-devel] [PATCH 3/6] add-cow file format

2012-08-02 Thread Dong Xu Wang
On Wed, Aug 1, 2012 at 11:31 PM, Stefan Hajnoczi wrote: > On Tue, Jul 31, 2012 at 5:51 PM, Dong Xu Wang > wrote: >> +if (backing_filename) { >> +header.features |= ADD_COW_F_BACKING_FILE; >> +header.backing_filename_offset = sizeof(header) + 16 * 2; > > It's not obvious what 1

Re: [Qemu-devel] [PATCH] esp: add Tekram DC-390 emulation (PC SCSI adapter)

2012-08-02 Thread Hervé Poussineau
Paolo Bonzini a écrit : Il 01/08/2012 18:59, Hervé Poussineau ha scritto: + +static void dc390_class_init(ObjectClass *klass, void *data) +{ +DeviceClass *dc = DEVICE_CLASS(klass); +PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); + +k->init = dc390_scsi_init; +k->romfile = "INT13.BI

Re: [Qemu-devel] [PATCH 4/6 v11] add-cow: support snapshot_blkde

2012-08-02 Thread Dong Xu Wang
On Wed, Aug 1, 2012 at 11:37 PM, Stefan Hajnoczi wrote: > On Tue, Jul 31, 2012 at 5:51 PM, Dong Xu Wang > wrote: >> add-cow will let raw file support snapshot_blkdev indirectly. >> >> Signed-off-by: Dong Xu Wang >> --- >> blockdev.c | 45 +-

Re: [Qemu-devel] [PATCH] esp: add Tekram DC-390 emulation (PC SCSI adapter)

2012-08-02 Thread Paolo Bonzini
Il 02/08/2012 09:25, Hervé Poussineau ha scritto: >>> >>> +static void dc390_class_init(ObjectClass *klass, void *data) >>> +{ >>> +DeviceClass *dc = DEVICE_CLASS(klass); >>> +PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); >>> + >>> +k->init = dc390_scsi_init; >>> +k->romfile = "INT13

Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-02 Thread Wenchao Xia
于 2012-8-1 18:44, Paolo Bonzini 写道: Il 01/08/2012 11:09, Wenchao Xia ha scritto: This patch encapsulate qemu general block layer to provide block services. API are declared in libqblock.h. libqblock-test.c simulate library consumer's behaviors. Make libqblock-test could build the code. For

Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-02 Thread Wenchao Xia
于 2012-8-1 20:49, Stefan Hajnoczi 写道: On Wed, Aug 1, 2012 at 10:09 AM, Wenchao Xia wrote: This patch encapsulate qemu general block layer to provide block services. API are declared in libqblock.h. libqblock-test.c simulate library consumer's behaviors. Make libqblock-test could build the co

[Qemu-devel] [PATCH V6 0/3] Show backing file depth in HMP and QMP

2012-08-02 Thread Benoît Canet
In some setups many backing files and snapshot are chained. This lead to the formation of huge trees of snapshots all depending on a common ancestor. Hence if something bad happen to this common ancestor all the snapshot of the tree will be broken. This patch add an easy way for the user to monit

[Qemu-devel] [PATCH V6 1/3] block: create bdrv_get_backing_file_depth()

2012-08-02 Thread Benoît Canet
Create bdrv_get_backing_file_depth() in order to be able to show in QMP and HMP how many ancestors backing an image a block device have. Signed-off-by: Benoit Canet --- block.c | 13 + block.h |1 + 2 files changed, 14 insertions(+) diff --git a/block.c b/block.c index ce7eb8f

[Qemu-devel] [PATCH V6 3/3] hmp: show the backing file depth

2012-08-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- hmp.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hmp.c b/hmp.c index 6b72a64..25688ab 100644 --- a/hmp.c +++ b/hmp.c @@ -227,6 +227,8 @@ void hmp_info_block(Monitor *mon) if (info->value->inserted->has_backing_file) { mon

[Qemu-devel] [PATCH V6 2/3] block: Use bdrv_get_backing_file_depth()

2012-08-02 Thread Benoît Canet
Use the dedicated counting function in qmp_query_block in order to propagate the backing file depth to HMP and add backing_file_depth to qmp-commands.hx Signed-off-by: Benoit Canet --- block.c |3 +++ qapi-schema.json |9 ++--- qmp-commands.hx |2 ++ 3 files changed, 11

Re: [Qemu-devel] [PATCH for-1.2 v5 14/14] pci: Tidy up PCI host bridges

2012-08-02 Thread Michael S. Tsirkin
On Thu, Aug 02, 2012 at 03:47:06AM +0200, Andreas Färber wrote: > Uglify the parent field to enforce QOM-style access via casts. > Don't just typedef PCIHostState, either use it directly or embed it. > > Signed-off-by: Andreas Färber NAK I'd prefer to drop this one for now. > --- > hw/alpha_ty

Re: [Qemu-devel] [PATCH for-1.2 v5 00/14] pci_host: Convert to QOM

2012-08-02 Thread Michael S. Tsirkin
On Thu, Aug 02, 2012 at 03:46:52AM +0200, Andreas Färber wrote: > Hello Anthony and Michael, > > Here's a fixed version of the series making pci_host a first-class QOM type. > > MAINTAINERS entries for the ppc devices touched herein are stripped from the > series but being used for sending. They

Re: [Qemu-devel] [PATCH v2 6/6] scsi-bus: remove overlapping entry

2012-08-02 Thread Markus Armbruster
[cc: SCSI maintainer] Blue Swirl writes: > LOAD_UNLOAD and START_STOP have same value, so the table > entry is initialized twice. Spotted by Clang compiler. > > Remove LOAD_UNLOAD entry since START_STOP entry already > represents both. > > Signed-off-by: Blue Swirl > --- > hw/scsi-bus.c |1

Re: [Qemu-devel] [PATCH v2 3/6] qapi: avoid reserved keywords

2012-08-02 Thread Markus Armbruster
Blue Swirl writes: > Clang compiler complained about use of reserved word 'restrict' in SLIRP > and QAPI. > > Prefix C keywords with "q_", adjust SLIRP accordingly. > > Signed-off-by: Blue Swirl I like this solution. Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-02 Thread Wenchao Xia
于 2012-8-2 2:04, Blue Swirl 写道: On Wed, Aug 1, 2012 at 9:09 AM, Wenchao Xia wrote: This patch encapsulate qemu general block layer to provide block services. API are declared in libqblock.h. libqblock-test.c simulate library consumer's behaviors. Make libqblock-test could build the code.

[Qemu-devel] [PATCH v2] esp: add Tekram DC-390 emulation (PC SCSI adapter)

2012-08-02 Thread Hervé Poussineau
Difference with AMD PCscsi is that DC-390 contains a EEPROM, and that a romfile is available to add INT13 support. This has been successfully tested on: - MS DOS 6.22 (using DC390 ASPI driver) - MS Windows 98 SE (using DC390 driver) - MS Windows NT 3.1 (using DC390 driver) - MS Windows NT 4.0 (usi

[Qemu-devel] [PATCH 1/2] qom: add missing 'const' in documentation sample

2012-08-02 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- include/qemu/object.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/object.h b/include/qemu/object.h index 8b17776..e0d326f 100644 --- a/include/qemu/object.h +++ b/include/qemu/object.h @@ -65,7 +65,7 @@ typedef struct In

[Qemu-devel] [PATCH 2/2] esp: add missing const on TypeInfo structures

2012-08-02 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/esp.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index c6422ad..4b00889 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -816,7 +816,7 @@ static void sysbus_esp_class_init(ObjectClass *klass, void *data) dc->

Re: [Qemu-devel] [PATCH 06/10] vmstate: add VMSTATE_TIMER_V

2012-08-02 Thread Juan Quintela
Paolo Bonzini wrote: > Also, for consistency with other occurrences, implement VMSTATE_TIMER > as a special case of VMSTATE_TIMER_V rather than VMSTATE_TIMER_TEST. > > Signed-off-by: Paolo Bonzini > --- > vmstate.h |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/v

Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-02 Thread Paolo Bonzini
Il 02/08/2012 09:57, Wenchao Xia ha scritto: >>> +/* try string dup and check if it succeed, dest would be freed >>> before dup */ >>> +#define SAFE_STRDUP(dest, src, ret, err_v) { \ >>> +if ((ret) != (err_v)) { \ >>> +if ((dest) != NULL) { \ >>> +FUNC_FREE(dest); \ >>> +

Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-02 Thread Paolo Bonzini
Il 02/08/2012 10:32, Wenchao Xia ha scritto: >> >> ssize_t qb_read(struct QBlockState *qbs, void *buf, size_t len, off_t >> offset) >> > OK. > >>> +{ >>> +int ret; >>> +BlockDriverState *bs; >>> + >>> +bs = (BlockDriverState *)qbs->bdrvs; >>> + >>> +ret = bdrv_read(bs, start / 5

Re: [Qemu-devel] [PATCH v2 0/7] split out uses of kvm_irqchip_in_kernel()

2012-08-02 Thread Jan Kiszka
On 2012-08-01 16:39, Peter Maydell wrote: > ping? Sorry, head is full with other stuff. Will try to have a final look today. Jan > > thanks > -- PMM > > On 26 July 2012 15:35, Peter Maydell wrote: >> This patch series removes all uses of kvm_irqchip_in_kernel() >> from architecture-independen

Re: [Qemu-devel] [PATCH 06/10] vmstate: add VMSTATE_TIMER_V

2012-08-02 Thread Paolo Bonzini
Il 02/08/2012 10:56, Juan Quintela ha scritto: >> > @@ -503,8 +503,11 @@ extern const VMStateInfo vmstate_info_unused_buffer; >> > #define VMSTATE_TIMER_TEST(_f, _s, _test) \ >> > VMSTATE_POINTER_TEST(_f, _s, _test, vmstate_info_timer, QEMUTimer *) >> > >> > +#de

Re: [Qemu-devel] [PATCH 1/3] vfio: Import vfio kernel header

2012-08-02 Thread Jan Kiszka
On 2012-08-01 20:09, Alex Williamson wrote: > On Wed, 2012-08-01 at 09:13 +0200, Jan Kiszka wrote: >> On 2012-08-01 07:18, Alex Williamson wrote: > >>> +#define VFIO_IOMMU_UNMAP_DMA _IO(VFIO_TYPE, VFIO_BASE + 14) >>> + >>> +#endif /* VFIO_H */ >>> >> >> Please patch update-linux-headers.sh and let

Re: [Qemu-devel] [PATCH v2] Support 'help' as a synonym for '?' in command line options

2012-08-02 Thread Markus Armbruster
Peter Maydell writes: > For command line options which permit '?' meaning 'please list the > permitted values', add support for 'help' as a synonym, by abstracting > the check out into a helper function. > > Update the documentation to use 'help' rather than '?', since '?' > is a shell metacharac

Re: [Qemu-devel] [PATCH 3/3] vfio: Enable vfio-pci and mark supported

2012-08-02 Thread Jan Kiszka
On 2012-08-01 21:40, Alex Williamson wrote: > On Wed, 2012-08-01 at 12:14 -0600, Alex Williamson wrote: >> On Wed, 2012-08-01 at 09:15 +0200, Jan Kiszka wrote: >>> On 2012-08-01 07:18, Alex Williamson wrote: Signed-off-by: Alex Williamson --- MAINTAINERS |5 +

Re: [Qemu-devel] [PATCH 05/10] RTC: Update the RTC clock only when reading it

2012-08-02 Thread Juan Quintela
Paolo Bonzini wrote: > From: Yang Zhang > > Calculate guest RTC based on the time of the last update, instead of > using timers. The formula is > > (base_rtc + guest_time_now - guest_time_last_update + offset) > > Base_rtc is the RTC value when the RTC was last updated. > Guest_time_now is t

Re: [Qemu-devel] [PATCH v2] Support 'help' as a synonym for '?' in command line options

2012-08-02 Thread Peter Maydell
On 2 August 2012 10:03, Markus Armbruster wrote: >> -if (*optarg == '?') { >> +if (is_help_option(optarg)) { >> show_valid_cards: > > "-soundhw ?junk" now goes through the "bad card name" path instead of > the "help" path. Fine with me. Yeah, I assumed that treating '?junk' like '?'

Re: [Qemu-devel] [PATCH 05/10] RTC: Update the RTC clock only when reading it

2012-08-02 Thread Paolo Bonzini
Il 02/08/2012 11:09, Juan Quintela ha scritto: > Why did you remove all the migration from previous versions? > You can't migrate now from version{1,2}, and we used to be able to do > it? > > Why did you remove it? Because it won't work; we removed three fields. You need to add rtc_load_old whic

Re: [Qemu-devel] [PATCH v2 0/7] split out uses of kvm_irqchip_in_kernel()

2012-08-02 Thread Jan Kiszka
On 2012-07-26 16:35, Peter Maydell wrote: > This patch series removes all uses of kvm_irqchip_in_kernel() > from architecture-independent code, by creating a set of more > specific functions instead to test for the particular aspects > of behaviour that the calling code is actually interested in. >

[Qemu-devel] [ANNOUNCE] kvm-kmod-3.5

2012-08-02 Thread Jan Kiszka
Here comes the kvm-kmod that corresponds to kernel 3.5. The package is available from http://sourceforge.net/projects/kvm/files/kvm-kmod/3.5/kvm-kmod-3.5.tar.bz2/download See [1] for further details on kvm-kmod. Major KVM changes since kvm-kmod-3.4: - additional instruction emulation - page-cr

Re: [Qemu-devel] [PATCH 05/10] RTC: Update the RTC clock only when reading it

2012-08-02 Thread Juan Quintela
Paolo Bonzini wrote: > Il 02/08/2012 11:09, Juan Quintela ha scritto: >> Why did you remove all the migration from previous versions? >> You can't migrate now from version{1,2}, and we used to be able to do >> it? >> >> Why did you remove it? > > Because it won't work; we removed three fields. Y

[Qemu-devel] [Bug 1032048] [NEW] qemu-kvm 1.1.x can't 'make', guest: 'arm', host: x86_64

2012-08-02 Thread edsfocci
Public bug reported: Problem compiling qemu-kvm-1.1.0 and qemu-kvm-1.1.1. This bug is reproducible, but due to my lack of skill, the solution eludes me. CPU: AMD Athlon(tm) II X2 255 Processor Host OS's tried: Ubuntu 12.04 64-bit, Puppy Linux 5.2.8-005 32-bit What I typed: ./configure --target

[Qemu-devel] [Bug 1032048] Re: qemu-kvm 1.1.x can't 'make', guest: 'arm', host: x86_64

2012-08-02 Thread edsfocci
Here's the output from qemu-kvm-1.1.1: ... CCarm-softmmu/vexpress.o CCarm-softmmu/strongarm.o CCarm-softmmu/collie.o CCarm-softmmu/pl041.o CCarm-softmmu/lm4549.o LINK arm-softmmu/qemu-system-arm ../libhw32/virtio-pci.o: In function `virtio_pci_set_guest_notifiers':

Re: [Qemu-devel] [PATCH][RFC] Add compare subcommand for qemu-img

2012-08-02 Thread Miroslav Rezanina
- Original Message - > From: "Paolo Bonzini" > To: "Miroslav Rezanina" > Cc: qemu-devel@nongnu.org > Sent: Wednesday, August 1, 2012 12:22:50 PM > Subject: Re: [PATCH][RFC] Add compare subcommand for qemu-img > > > + goto out; > > + } > > +}

Re: [Qemu-devel] [PATCH 3/3] eliminate cpus-x86_64.conf file

2012-08-02 Thread Lluís Vilanova
Eduardo Habkost writes: > On Wed, Aug 01, 2012 at 10:37:04PM +0300, Lluís Vilanova wrote: >> Eduardo Habkost writes: >> >> > This file is not needed anymore, as QEMU won't ship any config-based >> > cpudefs out of the box, relying only on the builtin CPU models. >> >> > Signed-off-by: Eduardo Ha

Re: [Qemu-devel] [PATCH 1/2] target-i386: move cpu halted decision into x86_cpu_reset

2012-08-02 Thread Igor Mammedov
On 08/01/2012 04:00 PM, Andreas Färber wrote: Am 23.07.2012 15:22, schrieb Igor Mammedov: MP initialization protocol differs between cpu families, and for P6 and onward models it is up to CPU to decide if it will be BSP using this protocol, so try to model this. However there is no point in impl

[Qemu-devel] [RFC 00/12] Qorum disk image corruption resiliency

2012-08-02 Thread Benoît Canet
This patchset create a block driver implementing a qorum using three qemu disk images. Writes are mirrored on the three files. For the reading part the three files are read at the same time and a vote is done to determine which is the majoritary qiov version. It then return this majoritary version

[Qemu-devel] [RFC 10/12] qorum: Add qorum_aio_readv.

2012-08-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qorum.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/block/qorum.c b/block/qorum.c index eeffac2..772d138 100644 --- a/block/qorum.c +++ b/block/qorum.c @@ -175,6 +175,14 @@ static int qorum_check_ret(QorumAIOCB *

[Qemu-devel] [RFC 12/12] qorum: build feature into QEMU.

2012-08-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/Makefile.objs |1 + 1 file changed, 1 insertion(+) diff --git a/block/Makefile.objs b/block/Makefile.objs index b5754d3..6ff9ba7 100644 --- a/block/Makefile.objs +++ b/block/Makefile.objs @@ -4,6 +4,7 @@ block-obj-y += qed.o qed-gencb.o qed-l2-cache.o qe

[Qemu-devel] [RFC 09/12] qorum: Add qorum_co_flush().

2012-08-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qorum.c | 20 1 file changed, 20 insertions(+) diff --git a/block/qorum.c b/block/qorum.c index 3dae8e4..eeffac2 100644 --- a/block/qorum.c +++ b/block/qorum.c @@ -15,6 +15,10 @@ #include "block_int.h" +ssize_t blkverify_iovec_com

Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-02 Thread Stefan Hajnoczi
On Thu, Aug 02, 2012 at 04:18:55PM +0800, Wenchao Xia wrote: > 于 2012-8-1 20:49, Stefan Hajnoczi 写道: > >On Wed, Aug 1, 2012 at 10:09 AM, Wenchao Xia > >wrote: > >> This patch encapsulate qemu general block layer to provide block > >>services. API are declared in libqblock.h. libqblock-test.c >

Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-02 Thread Stefan Hajnoczi
On Wed, Aug 01, 2012 at 07:25:54AM -0600, Eric Blake wrote: > On 08/01/2012 06:49 AM, Stefan Hajnoczi wrote: > > On Wed, Aug 1, 2012 at 10:09 AM, Wenchao Xia > > wrote: > >> This patch encapsulate qemu general block layer to provide block > >> services. API are declared in libqblock.h. libqbloc

Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-02 Thread Stefan Hajnoczi
On Thu, Aug 02, 2012 at 10:59:20AM +0200, Paolo Bonzini wrote: > Il 02/08/2012 09:57, Wenchao Xia ha scritto: > >>> +int qbi_init(struct QBlockInfo *info) > >> > >> Should return void. > >> > > yes, it is useless now, but maybe in future it may fail. Returning > > int for every API results in onl

Re: [Qemu-devel] [PATCH v4 0/2] GlusterFS support in QEMU - v4

2012-08-02 Thread Stefan Hajnoczi
On Wed, Aug 01, 2012 at 07:44:14PM +0530, Bharata B Rao wrote: > Hi, > > This is the v4 of the patchset to support GlusterFS backend from QEMU. > > Due to difficulties in supporting ipv6 address format in the ealier > specification, I switched over to the URI based specification which looks > lik

[Qemu-devel] [RFC 04/12] qorum: Add qorum_open().

2012-08-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qorum.c | 62 + 1 file changed, 62 insertions(+) diff --git a/block/qorum.c b/block/qorum.c index ea2a720..bdf1530 100644 --- a/block/qorum.c +++ b/block/qorum.c @@ -48,11 +48,73 @@ struct QorumAIOCB

Re: [Qemu-devel] [PATCH 4/6 v11] add-cow: support snapshot_blkde

2012-08-02 Thread Stefan Hajnoczi
On Thu, Aug 2, 2012 at 8:28 AM, Dong Xu Wang wrote: > On Wed, Aug 1, 2012 at 11:37 PM, Stefan Hajnoczi wrote: >> On Tue, Jul 31, 2012 at 5:51 PM, Dong Xu Wang >> wrote: >>> add-cow will let raw file support snapshot_blkdev indirectly. >>> >>> Signed-off-by: Dong Xu Wang >>> --- >>> blockdev.c

[Qemu-devel] [RFC 06/12] qorum: Add qorum_getlength().

2012-08-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qorum.c | 17 + 1 file changed, 17 insertions(+) diff --git a/block/qorum.c b/block/qorum.c index 006ab8c..37f6514 100644 --- a/block/qorum.c +++ b/block/qorum.c @@ -119,12 +119,29 @@ static void qorum_close(BlockDriverState *bs) } }

Re: [Qemu-devel] [PATCH 1/6 v11] docs: spec for add-cow file format

2012-08-02 Thread Stefan Hajnoczi
On Thu, Aug 2, 2012 at 8:09 AM, Dong Xu Wang wrote: > On Wed, Aug 1, 2012 at 9:55 PM, Stefan Hajnoczi wrote: >> On Tue, Jul 31, 2012 at 5:51 PM, Dong Xu Wang >> wrote: >>> +test.raw may be larger than ubuntu.img, in that case, the size of >>> test.add-cow >>> +will be calculated by the size of

[Qemu-devel] [RFC 03/12] qorum: Create BDRVQorumState and BlkDriver and do init.

2012-08-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qorum.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block/qorum.c b/block/qorum.c index 5b4f031..ea2a720 100644 --- a/block/qorum.c +++ b/block/qorum.c @@ -15,6 +15,10 @@ #include "block_int.h" +typedef struct { +BlockDr

[Qemu-devel] [RFC 05/12] qorum: Add qorum_close().

2012-08-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qorum.c | 12 1 file changed, 12 insertions(+) diff --git a/block/qorum.c b/block/qorum.c index bdf1530..006ab8c 100644 --- a/block/qorum.c +++ b/block/qorum.c @@ -108,6 +108,17 @@ clean_exit: return ret; } +static void qorum_close(Blo

Re: [Qemu-devel] [PATCH] qemu-img: use QemuOpts instead of QEMUOptionParameter in resize function

2012-08-02 Thread Stefan Hajnoczi
On Thu, Aug 2, 2012 at 4:42 AM, Dong Xu Wang wrote: > @@ -1624,14 +1629,14 @@ static int img_resize(int argc, char **argv) > } > > /* Parse size */ > -param = parse_option_parameters("", resize_options, NULL); > -if (set_option_parameter(param, BLOCK_OPT_SIZE, size)) { > +par

[Qemu-devel] [RFC 01/12] qorum: Add GPL v2+ header file.

2012-08-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qorum.c | 15 +++ 1 file changed, 15 insertions(+) create mode 100644 block/qorum.c diff --git a/block/qorum.c b/block/qorum.c new file mode 100644 index 000..3341021 --- /dev/null +++ b/block/qorum.c @@ -0,0 +1,15 @@ +/* + * Qorum Block f

[Qemu-devel] [RFC 02/12] qorum: Add QorumSingleAIOCB and QorumAIOCB.

2012-08-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qorum.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/block/qorum.c b/block/qorum.c index 3341021..5b4f031 100644 --- a/block/qorum.c +++ b/block/qorum.c @@ -13,3 +13,33 @@ * See the COPYING file in the top-level dire

[Qemu-devel] [RFC 08/12] blkverify: Make blkverify_iovec_clone() and blkverify_iovec_compare() public

2012-08-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/blkverify.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/block/blkverify.c b/block/blkverify.c index 9d5f1ec..9e15081 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -11,6 +11,10 @@ #include "qemu_socket.h" /* for

Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-02 Thread Paolo Bonzini
Il 02/08/2012 12:17, Stefan Hajnoczi ha scritto: >> > Main purpose of it is to set ret to err_v when memory is not enough, >> > I am not sure how to make this happens for every strdup. > Eric pointed out that we cannot use g_strdup() because it aborts on > memory allocation failure, so please ign

[Qemu-devel] [RFC 07/12] qorum: Add qorum_aio_writev and its dependencies.

2012-08-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qorum.c | 112 + 1 file changed, 112 insertions(+) diff --git a/block/qorum.c b/block/qorum.c index 37f6514..3dae8e4 100644 --- a/block/qorum.c +++ b/block/qorum.c @@ -134,6 +134,116 @@ static int64_t

[Qemu-devel] [RFC 11/12] qorum: Add qorum mechanism.

2012-08-02 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/qorum.c | 84 - 1 file changed, 78 insertions(+), 6 deletions(-) diff --git a/block/qorum.c b/block/qorum.c index 772d138..1f307b6 100644 --- a/block/qorum.c +++ b/block/qorum.c @@ -175,7 +175,7 @@ st

Re: [Qemu-devel] [PATCH][RFC] Add compare subcommand for qemu-img

2012-08-02 Thread Paolo Bonzini
Il 02/08/2012 12:06, Miroslav Rezanina ha scritto: >>> > > +qemu_progress_print(((float) nb_sectors / >>> > > progress_base)*100, 100); >> > >> > qemu_progress_print(nb_sectors, over_sectors); >> > >> > >> > Paolo >> > > This won't work. qemu_progress_print takes either (current_pro

Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-02 Thread Daniel P. Berrange
On Wed, Aug 01, 2012 at 07:25:54AM -0600, Eric Blake wrote: > On 08/01/2012 06:49 AM, Stefan Hajnoczi wrote: > > On Wed, Aug 1, 2012 at 10:09 AM, Wenchao Xia > > wrote: > >> This patch encapsulate qemu general block layer to provide block > >> services. API are declared in libqblock.h. libqbloc

Re: [Qemu-devel] [PATCH] [RFC] libqblock draft code v1

2012-08-02 Thread Paolo Bonzini
Il 02/08/2012 13:11, Daniel P. Berrange ha scritto: >>> > > Please include GPLv2+ license headers in new source files you create. >>> > > See existing code like include/qemu/object.h for the license header >>> > > text. >> > >> > Actually, LGPLv2+ (or compatible, like BSD), if you plan on making t

Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c

2012-08-02 Thread Igor Mammedov
On 08/01/2012 11:43 PM, Peter Maydell wrote: On 1 August 2012 22:25, Andreas Färber wrote: Am 01.08.2012 22:47, schrieb Anthony Liguori: Relying on the CPU list for this isn't very QOM-like. A better approach would be to make all CPUs appear in a container and then have the reset propagate

Re: [Qemu-devel] [PATCH 06/34] qerror: avoid passing qerr pointer

2012-08-02 Thread Markus Armbruster
Luiz Capitulino writes: > Helps dropping/modifying qerror functions. > > Signed-off-by: Luiz Capitulino > --- > qerror.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/qerror.c b/qerror.c > index 5efccec..59025ea 100644 > --- a/qerror.c > +++

Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

2012-08-02 Thread Orit Wasserman
On 08/01/2012 10:08 PM, Eric Blake wrote: > On 08/01/2012 12:01 PM, Juan Quintela wrote: >> From: Orit Wasserman >> >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Petter Svard >> Signed-off-by: Aidan Shribman >> Signed-off-by: Orit Wasserman >> Signed-off-by: Juan Quintela >> --- >> arch_

Re: [Qemu-devel] [PATCH 11/34] qmp: query-block: add 'valid_encryption_key' field

2012-08-02 Thread Markus Armbruster
Luiz Capitulino writes: > Signed-off-by: Luiz Capitulino > --- > block.c | 1 + > qapi-schema.json | 7 +-- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/block.c b/block.c > index b38940b..9c113b8 100644 > --- a/block.c > +++ b/block.c > @@ -2445,6 +2445,7 @@

Re: [Qemu-devel] [PATCH 0/3] Move CPU model definitions to C

2012-08-02 Thread Igor Mammedov
On 08/01/2012 11:53 PM, Andreas Färber wrote: Am 01.08.2012 22:27, schrieb Eduardo Habkost: On Wed, Aug 01, 2012 at 10:04:50PM +0200, Andreas Färber wrote: Am 01.08.2012 20:45, schrieb Eduardo Habkost: This makes the change we discussed on the latest KVM conf call[1], moving the existing cpude

Re: [Qemu-devel] [PATCH 12/34] hmp: hmp_cont(): don't rely on QERR_DEVICE_ENCRYPTED

2012-08-02 Thread Markus Armbruster
Luiz Capitulino writes: > This commit changes hmp_cont() to loop through all block devices > and proactively set an encryption key for any encrypted device > without a valid one. > > This change is needed because QERR_DEVICE_ENCRYPTED is going to be > dropped by a future commit. > > Signed-off-by

Re: [Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization inside CPU object

2012-08-02 Thread Igor Mammedov
Anthony, ping Is something wrong with this series? PS: Jan, may I ask for an explicit Acked-By, pls? On 06/25/2012 03:55 PM, Igor Mammedov wrote: v2: - drop usage of prev_debug_excp_handler consistently in all users - split from reset patches to avoid confusion of inter-dependency Co

Re: [Qemu-devel] [PATCH 0/3] Move CPU model definitions to C

2012-08-02 Thread Eduardo Habkost
On Wed, Aug 01, 2012 at 03:41:56PM -0500, Anthony Liguori wrote: > Eduardo Habkost writes: > > > On Wed, Aug 01, 2012 at 10:04:50PM +0200, Andreas Färber wrote: > >> Am 01.08.2012 20:45, schrieb Eduardo Habkost: > >> > This makes the change we discussed on the latest KVM conf call[1], > >> > mov

Re: [Qemu-devel] [RFC 00/27] Migration thread (WIP)

2012-08-02 Thread Juan Quintela
Michael Roth wrote: > On Tue, Jul 24, 2012 at 08:36:25PM +0200, Juan Quintela wrote: >> Hi >> >> This series are on top of the migration-next-v5 series just posted. >> >> First of all, this is an RFC/Work in progress. Just a lot of people >> asked for it, and I would like review of the design.

Re: [Qemu-devel] [PATCH 0/3] Move CPU model definitions to C

2012-08-02 Thread Eduardo Habkost
On Wed, Aug 01, 2012 at 11:53:51PM +0200, Andreas Färber wrote: > Am 01.08.2012 22:27, schrieb Eduardo Habkost: > > On Wed, Aug 01, 2012 at 10:04:50PM +0200, Andreas Färber wrote: > >> Am 01.08.2012 20:45, schrieb Eduardo Habkost: > >>> This makes the change we discussed on the latest KVM conf call

Re: [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly add an entry

2012-08-02 Thread Corey Minyard
On 08/01/2012 09:40 PM, Anthony Liguori wrote: Corey Minyard writes: On 08/01/2012 08:15 PM, Kevin O'Connor wrote: Well, I should also probably add the ACPI name space definition for this information, too, and the SMBIOS information is not capable of passing all the information required for th

[Qemu-devel] QEMU 1.2 Test Day - August 16 2012

2012-08-02 Thread Stefan Hajnoczi
I have set up the QEMU 1.2 Testing wiki page and suggest August 16 as the Test Day: http://wiki.qemu.org/Planning/1.2/Testing Test Day is an event for QEMU contributors and users to try out the release candidate. QEMU has a large feature matrix that is hard to test by a single entity. On Test D

Re: [Qemu-devel] [PATCH for-1.2] cpus: Register reset callback centrally

2012-08-02 Thread Igor Mammedov
I'm ok with this patch. It's reduces ugly ifdefs in wonderful realize function. :) Hence, Reviewed-By: Igor Mammedov On 08/01/2012 11:13 PM, Andreas Färber wrote: Despite repeated protest commit 65dee38052597b6285eb208125369f01b29ba6c1 (target-i386: move cpu_reset and reset callback to cpu.c)

Re: [Qemu-devel] [PATCH for-1.2] cpus: Register reset callback centrally

2012-08-02 Thread Igor Mammedov
On 08/02/2012 12:44 AM, Andreas Färber wrote: Am 01.08.2012 23:13, schrieb Andreas Färber: Despite repeated protest commit 65dee38052597b6285eb208125369f01b29ba6c1 (target-i386: move cpu_reset and reset callback to cpu.c) moved registration of a reset callback from hw/pc.c to target-i386/cpu.c w

[Qemu-devel] [PATCH 00/11] Migration next v9

2012-08-02 Thread Orit Wasserman
Changes from v8: remove xbzrle from xbzrle-cache fields name. fix other review comments by Eric Changes from v7: rename migrate-set-parameter to migrate-set-capabilities rename query-migrate-parameters to query-migrate-capabilities renamse query-migration-capabilities to query-migration-supported-

[Qemu-devel] [PATCH 01/11] Add migration capabilities

2012-08-02 Thread Orit Wasserman
Add migration capabilities that can be queried by the management using query-migration-supported-capabilities command. The management can query the source QEMU and the destination QEMU in order to verify both support some migration capability (currently only XBZRLE). Signed-off-by: Orit Wasserman

[Qemu-devel] [PATCH 09/11] Add migration accounting for normal and duplicate pages

2012-08-02 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- arch_init.c | 38 ++ hmp.c|6 ++ migration.c |6 ++ migration.h

[Qemu-devel] [PATCH 06/11] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-08-02 Thread Orit Wasserman
For performance we are encoding long word at a time. For nzrun we use long-word-at-a-time NULL-detection tricks from strcmp(): using ((lword - 0x0101010101010101) & (~lword) & 0x8080808080808080) test to find out if any byte in the long word is zero. Signed-off-by: Benoit Hudzia Signed-off-by: Pe

[Qemu-devel] [PATCH 11/11] Restart optimization on stage3 update version

2012-08-02 Thread Orit Wasserman
From: Juan Quintela Signed-off-by: Juan Quintela --- arch_init.c | 24 +++- 1 files changed, 15 insertions(+), 9 deletions(-) diff --git a/arch_init.c b/arch_init.c index 9833d54..21031d1 100644 --- a/arch_init.c +++ b/arch_init.c @@ -273,14 +273,16 @@ static void save_bl

[Qemu-devel] [PATCH 04/11] Add cache handling functions

2012-08-02 Thread Orit Wasserman
Add MRU page cache mechanism. The page are accessed by their address. Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- Makefile.objs |1 + cutils.c |9 ++ include/qemu/page_cache.h |

[Qemu-devel] [PATCH 07/11] Add XBZRLE to ram_save_block and ram_save_live

2012-08-02 Thread Orit Wasserman
In the outgoing migration check to see if the page is cached and changed, then send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_SAVE_FLAG_XBZRLE is set and decompress the page (by using load_xbrle function). Signed-off-by: Benoit Hudzia Signed-

[Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

2012-08-02 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- arch_init.c | 28 hmp.c| 13 + migration.c | 17 + migrati

[Qemu-devel] [PATCH v3] Support 'help' as a synonym for '?' in command line options

2012-08-02 Thread Peter Maydell
For command line options which permit '?' meaning 'please list the permitted values', add support for 'help' as a synonym, by abstracting the check out into a helper function. This change means that in some cases where we were being lazy in our string parsing, "?junk" will now be rejected as an in

[Qemu-devel] [PATCH 02/11] Add migrate-set-capabilities and query-migrate-capabilities

2012-08-02 Thread Orit Wasserman
The management can enable/disable a capability for the next migration by using migrate-set-apabilities QMP command. The management can query the current migration capabilities using query-migrate-capabilities QMP command. The user can use migrate_set_capability and 'info migrate_capabilities' HMP c

[Qemu-devel] [PATCH 08/11] Add migrate_set_cachesize command

2012-08-02 Thread Orit Wasserman
Change XBZRLE cache size in bytes (the size should be a power of 2, it will be rounded down to the nearest power of 2). If XBZRLE cache size is too small there will be many cache miss. New query-migrate-cache-size QMP command and 'info migrate-cache-size' HMP command to query cache value. Signed-

Re: [Qemu-devel] [RFC 00/12] Qorum disk image corruption resiliency

2012-08-02 Thread Eric Blake
On 08/02/2012 04:16 AM, Benoît Canet wrote: > This patchset create a block driver implementing a qorum using three qemu disk s/qorum/quorum/g throughout the series, including subject line > images. Writes are mirrored on the three files. > For the reading part the three files are read at the same

[Qemu-devel] [PATCH 05/11] Add uleb encoding/decoding functions

2012-08-02 Thread Orit Wasserman
Implement Unsigned Little Endian Base 128. Signed-off-by: Orit Wasserman --- cutils.c | 33 + qemu-common.h |8 2 files changed, 41 insertions(+), 0 deletions(-) diff --git a/cutils.c b/cutils.c index b0bdd4b..700f943 100644 --- a/cutils.c +++

Re: [Qemu-devel] [PATCH 13/34] hmp: hmp_change(): don't rely on QERR_DEVICE_ENCRYPTED

2012-08-02 Thread Markus Armbruster
Luiz Capitulino writes: > This commit changes the way hmp_change() checks if an encryption key > is required for the device to be inserted. > > Instead of checking for QERR_DEVICE_ENCRYPTED, hmp_change() now checks > if the device was successfully inserted, is encrypted and is missing > an encryp

Re: [Qemu-devel] [RFC 00/12] Qorum disk image corruption resiliency

2012-08-02 Thread Benoît Canet
Le Thursday 02 Aug 2012 à 07:17:35 (-0600), Eric Blake a écrit : > How does this fit with snapshots? Does a snapshot of a quorum require > passing in three filenames, one for each of the three sources? For now quorum lives on top of qcow*/qed it doesn't fit well with snapshot: it a step before tu

Re: [Qemu-devel] [RFC 00/27]: add new error format

2012-08-02 Thread Luiz Capitulino
On Thu, 02 Aug 2012 10:31:28 +0800 Amos Kong wrote: > On 01/08/12 21:29, Luiz Capitulino wrote: > > On Wed, 01 Aug 2012 19:33:27 +0800 > > Amos Kong wrote: > > > >> On 31/07/12 22:44, Luiz Capitulino wrote: > >>> On Fri, 27 Jul 2012 18:31:41 -0300 > >>> Luiz Capitulino wrote: > >>> > [Ple

[Qemu-devel] [PATCH 03/11] Add XBZRLE documentation

2012-08-02 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- docs/xbzrle.txt | 136 +++ 1 files changed, 136 insertions(+), 0 deletions(-) create mode 100644 docs/xbzrle.txt diff --git a/docs/xbzrle.txt b/docs/xbzrle.txt new file mode 100644 index 000..1463c0a ---

Re: [Qemu-devel] [PATCH v1 00/34]: add new error format

2012-08-02 Thread Luiz Capitulino
On Wed, 1 Aug 2012 22:02:20 -0300 Luiz Capitulino wrote: > Quick summary first, long introduction afterwards. > > From the rfc: > > o rebased on top of master > o dropped patch "qapi: qapi.py: allow the "'" character be escaped" > o split patch "qerror: drop qerror_abort()" into two patches

Re: [Qemu-devel] [PATCH 15/34] net: inet_connect(), inet_connect_opts(): return -errno

2012-08-02 Thread Luiz Capitulino
On Wed, 1 Aug 2012 22:02:35 -0300 Luiz Capitulino wrote: > Next commit wants to use this. > > Signed-off-by: Luiz Capitulino > --- > > This patch is an interesting case, because one of the goal of the error > format that's being replaced was that callers could use it to know the > error cause

  1   2   3   >