On Wed, Aug 01, 2012 at 07:25:54AM -0600, Eric Blake wrote: > On 08/01/2012 06:49 AM, Stefan Hajnoczi wrote: > > On Wed, Aug 1, 2012 at 10:09 AM, Wenchao Xia <xiaw...@linux.vnet.ibm.com> > > wrote: > >> This patch encapsulate qemu general block layer to provide block > >> services. API are declared in libqblock.h. libqblock-test.c > >> simulate library consumer's behaviors. Make libqblock-test could > >> build the code. > >> For easy this patch does not form a dynamic libarary yet. > >> > >> +++ b/libqblock-test.c > >> @@ -0,0 +1,56 @@ > >> +#include "libqblock.h" > > > > Please include GPLv2+ license headers in new source files you create. > > See existing code like include/qemu/object.h for the license header > > text. > > Actually, LGPLv2+ (or compatible, like BSD), if you plan on making this > a reusable library. GPLv2+ is too strict for libvirt to use directly.
NB, i don't see libvirt being able to use this library regardless of license, due to its reliance on glib + abort-on-OOM behaviour Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
