Re: [Qemu-devel] [PATCH] Use siginfo_t instead of struct siginfo.

On Monday, July 30, 2012 22:38:32 Peter Maydell wrote: > On 30 July 2012 22:33, Andreas Färber wrote: > > Am 30.07.2012 23:30, schrieb Alexander Graf: > >> On 30.07.2012, at 09:21, Andreas Jaeger wrote: > >>> glibc 2.16 does not export the undocumented struct siginfo > >>> anymore. > >>> qemu uses

Re: [Qemu-devel] [PATCH] ATAPI: Add support for ASCQ in sense codes

Il 31/07/2012 04:07, Ronnie Sahlberg ha scritto: > Add support for setting the ASCQ for SCSI sense codes in the ATAPI driver. > Use this to set ASCQ==2 for the medium removal prevention that is recommended > in MMC for this condition. > > asc:0x53 ascq:0x02 is the recommended error for MEDIUM_REM

Re: [Qemu-devel] 9p broken?

Avi Kivity writes: > Having an annoying bug on i386 kvm I decided to debug it buy running an > i386 guest on my x86_64 host, use 9p to access a guest image, and run it > using nested kvm. > > However, 9p appears to be broken: first, the configure test fails (patch > sent). Second, while mount wo

[Qemu-devel] buildbot failure in qemu on xen40

The Buildbot has detected a new failure on builder xen40 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/xen40/builds/80 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: anthony_xen Build Reason: The Nightly scheduler n

[Qemu-devel] [PATCH] hw/9pfs: Fix assert when disabling migration

From: "Aneesh Kumar K.V" For 9p we can get the attach request multiple times for the same export. So don't adding migration blocker for every attach request. Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff -

Re: [Qemu-devel] [PATCH 3/5] qapi: avoid reserved word restrict

Il 30/07/2012 18:04, blauwir...@gmail.com ha scritto: > From: Blue Swirl > > Clang compiler complained about use of reserved word 'restrict' in SLIRP > and QAPI. > > Rename 'restrict' to 'restricted' which also matches other SLIRP code. Can't do it, this changes the command-line option. Luiz,

Re: [Qemu-devel] [PATCH 2/5] pseries: Instantiate USB if requested

On Tue, 2012-07-31 at 16:09 +1000, David Gibson wrote: > The pseries machine currently ignores the -usb command line option. > This patch corrects the problem by having it instantiate a PCI OHCI > USB host controller when -usb is specified. > > Signed-off-by: David Gibson Same comment as the -vg

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

On 07/30/2012 08:41 PM, Luiz Capitulino wrote: > On Sun, 29 Jul 2012 12:42:54 +0300 > Orit Wasserman wrote: > >> The management can enable/disable a capability for the next migration by >> using >> migrate_set_parameter command. >> The management can query the current migration capabilities usin

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

On 07/30/2012 08:41 PM, Luiz Capitulino wrote: > On Sun, 29 Jul 2012 12:42:54 +0300 > Orit Wasserman wrote: > >> The management can enable/disable a capability for the next migration by >> using >> migrate_set_parameter command. >> The management can query the current migration capabilities usin

Re: [Qemu-devel] [GIT PULL (PATCH 0/4)] VFIO driver for v3.6

On Mon, Jul 30, 2012 at 4:17 PM, Alex Williamson wrote: > > I'm pretty anxious to find out as well. Linus, ping, any thoughts on > including this in 3.6? Thanks, I just pulled it, but then I unpulled again when I realized it's not a signed tag and it's on github. Please, people. Do tagged rele

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

On Tue, Jul 31, 2012 at 08:24:23AM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2012-07-30 at 18:24 +0200, Alon Levy wrote: > > On Mon, Jul 30, 2012 at 10:08:07PM +1000, Benjamin Herrenschmidt wrote: > > > On Mon, 2012-07-30 at 14:58 +0300, Avi Kivity wrote: > > > > Let's balkanize some more then

Re: [Qemu-devel] [PATCH v3 0/2] GlusterFS support in QEMU - v3

On Wed, Jul 25, 2012 at 6:58 AM, Bharata B Rao wrote: > Apart from cleanups, the major change in this version is to expose all > the gluster configuration options to QEMU user. With this, the gluster > specification looks like this: > > -drive file=gluster:server:[port]:[transport]:volname:image >

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

On Mon, Jul 30, 2012 at 09:29:01AM -0500, Anthony Liguori wrote: > Avi Kivity writes: > > >>> Virtio makes sense for qxl, but for now we have the original pci model > >>> which I don't see a reason why it can't work for ppc. > >> > >> I'm sure it can work for PPC given enough effort. But I thin

Re: [Qemu-devel] [PATCH 2/5] pseries: Instantiate USB if requested

On Tue, 2012-07-31 at 16:09 +1000, David Gibson wrote: > The pseries machine currently ignores the -usb command line option. > This patch corrects the problem by having it instantiate a PCI OHCI > USB host controller when -usb is specified. > > Signed-off-by: David Gibson Li Zhang has been owni

Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

On 07/30/2012 10:37 PM, Luiz Capitulino wrote: > On Sun, 29 Jul 2012 12:43:02 +0300 > Orit Wasserman wrote: > >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Petter Svard >> Signed-off-by: Aidan Shribman >> Signed-off-by: Orit Wasserman >> Signed-off-by: Juan Quintela >> --- >> arch_init.

Re: [Qemu-devel] [PATCH 09/11] Add migration accounting for normal and duplicate pages

On 07/30/2012 10:30 PM, Luiz Capitulino wrote: > On Sun, 29 Jul 2012 12:43:01 +0300 > Orit Wasserman wrote: > >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Petter Svard >> Signed-off-by: Aidan Shribman >> Signed-off-by: Orit Wasserman >> Signed-off-by: Juan Quintela >> --- >> arch_init.

[Qemu-devel] Tracing drivers commands to an emulated device

Hello to all, I would trace the commands issued by the driver to an emulated device. I've read in docs/tracing that it is possible but it is not completely clear how doing that. Is it possible to place hooks inside the emulated device code? Or is better tracing the in/out operations and the acce

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

On Mon, Jul 30, 2012 at 4:24 PM, Benjamin Herrenschmidt wrote: > So I got cirrus working on ppc with cirrusdrmfb... > > The fun part is that it works :-) > > Basically, the issue is that normally, for it to work, one would have to > access the framebuffer using the appropriate aperture for byteswa

Re: [Qemu-devel] [PATCH 04/47] block: add block_job_query

Am 30.07.2012 17:05, schrieb Paolo Bonzini: > Il 30/07/2012 16:47, Kevin Wolf ha scritto: +BlockJobInfo *block_job_query(BlockJob *job) +{ +BlockJobInfo *info = g_new(BlockJobInfo, 1); +info->type = g_strdup(job->job_type->job_type); +info->device = g_strdup(b

Re: [Qemu-devel] [PATCH v3 0/2] GlusterFS support in QEMU - v3

On Mon, Jul 30, 2012 at 5:46 AM, Bharata B Rao wrote: > On Wed, Jul 25, 2012 at 11:28:06AM +0530, Bharata B Rao wrote: >> Hi, >> >> This is the v3 of the patchset to support GlusterFS backend from QEMU. > > I am planning a v4 post to address a few minor cleanups suggested by > Blue Swirl. I would

Re: [Qemu-devel] [PATCH 04/47] block: add block_job_query

Il 31/07/2012 10:47, Kevin Wolf ha scritto: >>> >> Why did you convert the initialisation to separate statement? If you >>> >> really want to do this, I think using g_new0 would be safer now, but I >>> >> actually like compound literals better. >> > >> > Later on I will have some more initializati

Re: [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c

On Tue, Jul 31, 2012 at 10:22:37AM +0800, Zhi Yong Wu wrote: > On Mon, Jul 30, 2012 at 11:49 PM, Stefan Hajnoczi wrote: > > On Tue, Jul 24, 2012 at 4:35 PM, Stefan Hajnoczi > > wrote: > >> [These patches are based on the net tree at git://github.com/stefanha/net] > >> > >> The QEMU net subsystem

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

Am 24.07.2012 13:04, schrieb Paolo Bonzini: > This adds the monitor commands that start the mirroring job. > > Signed-off-by: Paolo Bonzini [ Moving the discussion upstream ] > Why make all of it inaccessible? Everything except target device access > does have a stable API. The target device

Re: [Qemu-devel] [PATCH V4 04/12] hw/sd.c: favour SD card type (SDSC or SDHC) when performing erase

Igor Mitsyanko writes: > Standard capacity cards SDSC use byte unit address while SDHC and SDXC Cards > use > block unit address (512 bytes) when setting ERASE_START and ERASE_END with > CMD32 > and CMD33, we have to account for this. > > Signed-off-by: Igor Mitsyanko > --- > hw/sd.c |6 +

Re: [Qemu-devel] [PATCH V4 08/12] hw/sd.c: add SD card save/load support

Igor Mitsyanko writes: > This patch updates SD card model to support save/load of card's state. > > Signed-off-by: Igor Mitsyanko > --- > hw/sd.c | 88 +- > 1 files changed, 64 insertions(+), 24 deletions(-) > > diff --git a/hw/sd.c

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

Il 31/07/2012 11:26, Kevin Wolf ha scritto: > Am 24.07.2012 13:04, schrieb Paolo Bonzini: >> This adds the monitor commands that start the mirroring job. >> >> Signed-off-by: Paolo Bonzini > > [ Moving the discussion upstream ] > >> Why make all of it inaccessible? Everything except target devi

Re: [Qemu-devel] [PATCH V4 09/12] hw/sd.c: convert SD state to QOM object

Igor Mitsyanko writes: > A straightforward conversion of SD card implementation to a proper QEMU > object. > Wrapper functions were introduced for SDClass methods in order to avoid SD > card > users modification. Because of this, name change for several functions in > hw/sd.c > was required. >

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

Am 31.07.2012 11:33, schrieb Paolo Bonzini: > Il 31/07/2012 11:26, Kevin Wolf ha scritto: >> Am 24.07.2012 13:04, schrieb Paolo Bonzini: >>> This adds the monitor commands that start the mirroring job. >>> >>> Signed-off-by: Paolo Bonzini >> >> [ Moving the discussion upstream ] >> >>> Why make al

Re: [Qemu-devel] [PATCH] kvm: Check if smp_cpus exceeds max cpus supported by kvm

On Mon, Jul 30, 2012 at 7:22 PM, wrote: > From: Dunrong Huang > > Add a helper function for fetching max cpus supported by kvm. > > Make QEMU exit with an error message if smp_cpus exceeds limit > of VCPU count retrieved by invoking this helper function. > > Signed-off-by: Dunrong Huang > --- >

[Qemu-devel] [PATCH] Fix ALSA configure check

Recent gcc notice that the ASLA configure check uses an uninitialized variable, causing spurious failures. Adjust the testcase to avoid this. Signed-off-by: Paul Brook --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index c65b5f6..91527

Re: [Qemu-devel] [PATCH V4 11/12] SD card: introduce "spi" property for SD card objects

Igor Mitsyanko writes: > And drop passing is_spi argument to SDCardClass::init function. > "spi" property could be set only while SD card object is not > attached to any BlockDriverState. > It defaults to "false". > > Signed-off-by: Igor Mitsyanko > Cc: Paul Brook > --- > hw/sd.c | 33 ++

Re: [Qemu-devel] [PATCH] Fix ALSA configure check

On Tue, 31 Jul 2012, Paul Brook wrote: > Recent gcc notice that the ASLA configure check uses an uninitialized > variable, causing spurious failures. Adjust the testcase to avoid this. http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02704.html > > Signed-off-by: Paul Brook > --- >

Re: [Qemu-devel] [PATCH V4 09/12] hw/sd.c: convert SD state to QOM object

On 31 July 2012 10:45, Markus Armbruster wrote: > Igor Mitsyanko writes: >> @@ -1510,7 +1508,7 @@ void sd_write_data(SDState *sd, uint8_t value) >> return; >> >> if (sd->state != sd_receivingdata_state) { >> -fprintf(stderr, "sd_write_data: not in Receiving-Data state\n"); >

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

Il 31/07/2012 11:46, Kevin Wolf ha scritto: >>> I'm not even sure about the QMP mirror command itself. >>> >>> I don't really like it, it does too many things at once: It can create >>> the target image file, it opens the target and it actually starts the >>> mirroring. It's rather bad at the first

Re: [Qemu-devel] [PATCH] kvm: Check if smp_cpus exceeds max cpus supported by kvm

On 30 July 2012 19:22, wrote: > +static int kvm_max_vcpus(KVMState *s) > +{ > +int max_vcpus = 4; > +int ret; > +ret = kvm_check_extension(s, KVM_CAP_MAX_VCPUS); > +if (ret) { > +max_vcpus = ret; > +} else { > + ret = kvm_check_extension(s, KVM_CAP_NR_VCPUS); > +

[Qemu-devel] [PATCH v2] kvm: Check if smp_cpus exceeds max cpus supported by kvm

From: Dunrong Huang Add a helper function for fetching max cpus supported by kvm. Make QEMU exit with an error message if smp_cpus exceeds limit of VCPU count retrieved by invoking this helper function. Signed-off-by: Dunrong Huang --- v1 -> v2: * Fix indentation kvm-all.c | 25 +

Re: [Qemu-devel] [PATCH V4 04/12] hw/sd.c: favour SD card type (SDSC or SDHC) when performing erase

On 07/31/2012 01:29 PM, Markus Armbruster wrote: Igor Mitsyanko writes: Standard capacity cards SDSC use byte unit address while SDHC and SDXC Cards use block unit address (512 bytes) when setting ERASE_START and ERASE_END with CMD32 and CMD33, we have to account for this. Signed-off-by: Igor

[Qemu-devel] [RFC] Factor out fifos / circular buffers

Hi All, A lot of devices have little internal fifos that are often implemented as circular buffers in the device state. Any reason to not factor that out into a helper module? Was thinkin just a struct defintion containing the key elements (the uint8_t *data buffer, head/tail pointers, capacity).

Re: [Qemu-devel] [PATCH v2] kvm: Check if smp_cpus exceeds max cpus supported by kvm

On 31 July 2012 11:14, wrote: > > @@ -1256,6 +1274,13 @@ int kvm_init(void) > goto err; > } > > +max_vcpus = kvm_max_vcpus(s); > +if (smp_cpus > max_vcpus) { > +fprintf(stderr, "Number of SMP cpus requested (%d) exceeds max cpus " > +"supported by KVM

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

Am 31.07.2012 12:02, schrieb Paolo Bonzini: > Il 31/07/2012 11:46, Kevin Wolf ha scritto: I'm not even sure about the QMP mirror command itself. I don't really like it, it does too many things at once: It can create the target image file, it opens the target and it actually star

Re: [Qemu-devel] [PATCH V4 08/12] hw/sd.c: add SD card save/load support

On 07/31/2012 01:33 PM, Markus Armbruster wrote: Igor Mitsyanko writes: This patch updates SD card model to support save/load of card's state. Signed-off-by: Igor Mitsyanko --- hw/sd.c | 88 +- 1 files changed, 64 insertions(+)

Re: [Qemu-devel] Tracing drivers commands to an emulated device

On Tue, Jul 31, 2012 at 9:43 AM, wrote: > I would trace the commands issued by the driver to an emulated device. I've > read in docs/tracing that it is possible but it is not completely clear how > doing that. Is it possible to place hooks inside the emulated device code? Or > is better tracin

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

On Tue, 2012-07-31 at 18:44 +1000, ronnie sahlberg wrote: > > I use lots of guests that will never ever get virtio drivers. > So for those guests, any work on making sure bog standard vga keeps > working or even improving it > gets two thumbs up from me! So I've been essentially restarting my wor

Re: [Qemu-devel] [PATCH v2] kvm: Check if smp_cpus exceeds max cpus supported by kvm

2012/7/31 Peter Maydell : > On 31 July 2012 11:14, wrote: >> >> @@ -1256,6 +1274,13 @@ int kvm_init(void) >> goto err; >> } >> >> +max_vcpus = kvm_max_vcpus(s); >> +if (smp_cpus > max_vcpus) { >> +fprintf(stderr, "Number of SMP cpus requested (%d) exceeds max cpus >

Re: [Qemu-devel] [PATCH] Makefile: Remove generated hw/usb files in 'clean' target

On Mon, Jul 30, 2012 at 5:46 PM, Peter Maydell wrote: > On 30 July 2012 17:42, Stefan Hajnoczi wrote: >> On Sun, Jul 29, 2012 at 03:48:49PM +0200, Stefan Weil wrote: >>> Commit f1ae32a1ecda8aaff7a355c9030c0d8c363f3a70 moved the >>> usb directory to hw, so the files which should be removed >>> are

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

Il 31/07/2012 12:25, Kevin Wolf ha scritto: >> Yeah, but do you really care about for example io=threads vs. io=native? >> The only interesting one is cache=unsafe; the mirror should enable >> writeback caching on the target (bdrv_swap will disable it if needed; >> I'll change this in the next sub

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

Am 31.07.2012 12:51, schrieb Paolo Bonzini: > Il 31/07/2012 12:25, Kevin Wolf ha scritto: >>> Yeah, but do you really care about for example io=threads vs. io=native? >>> The only interesting one is cache=unsafe; the mirror should enable >>> writeback caching on the target (bdrv_swap will disable

[Qemu-devel] [PATCH v3] kvm: Check if smp_cpus exceeds max cpus supported by kvm

From: Dunrong Huang Add a helper function for fetching max cpus supported by kvm. Make QEMU exit with an error message if smp_cpus exceeds limit of VCPU count retrieved by invoking this helper function. Signed-off-by: Dunrong Huang --- v1 -> v2: * Fix indentation(thanks to Stefan Hajnoczi f

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

Il 31/07/2012 13:13, Kevin Wolf ha scritto: > Am 31.07.2012 12:51, schrieb Paolo Bonzini: >> Il 31/07/2012 12:25, Kevin Wolf ha scritto: Yeah, but do you really care about for example io=threads vs. io=native? The only interesting one is cache=unsafe; the mirror should enable writeb

Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work

(in reply to -- In-Reply-To set, but that may not be enough for the web archive) Looks good to me. A minor nit: 2/2 keeps the close(s->fd) call (instead of calling closesocket(s->fd), like in eoc handling) in net_socket_cleanup()

Re: [Qemu-devel] 9p broken?

On 07/31/2012 09:51 AM, Aneesh Kumar K.V wrote: > Avi Kivity writes: > >> Having an annoying bug on i386 kvm I decided to debug it buy running an >> i386 guest on my x86_64 host, use 9p to access a guest image, and run it >> using nested kvm. >> >> However, 9p appears to be broken: first, the con

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

Am 31.07.2012 13:25, schrieb Paolo Bonzini: > Il 31/07/2012 13:13, Kevin Wolf ha scritto: >> Am 31.07.2012 12:51, schrieb Paolo Bonzini: >>> Il 31/07/2012 12:25, Kevin Wolf ha scritto: Another interesting thing is I/O throttling. The mirror currently implements rate limiting itself, but i

Re: [Qemu-devel] [PATCH V4 11/12] SD card: introduce "spi" property for SD card objects

Am 31.07.2012 11:54, schrieb Markus Armbruster: > Igor Mitsyanko writes: > >> And drop passing is_spi argument to SDCardClass::init function. >> "spi" property could be set only while SD card object is not >> attached to any BlockDriverState. >> It defaults to "false". >> >> Signed-off-by: Igor M

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu

On 07/31/2012 01:29 AM, Alex Williamson wrote: >> >> If the region size is zero, then both memory_region_del_subregion() >> (assuming the region is parented) and munmap() do nothing. So you could >> call this unconditionally. > > I suppose parenting them is the key. I'm counting on memory_regio

Re: [Qemu-devel] [PATCH v3 0/2] GlusterFS support in QEMU - v3

On Tue, Jul 31, 2012 at 09:12:53AM +0100, Stefan Hajnoczi wrote: > On Wed, Jul 25, 2012 at 6:58 AM, Bharata B Rao > wrote: > > Apart from cleanups, the major change in this version is to expose all > > the gluster configuration options to QEMU user. With this, the gluster > > specification looks l

[Qemu-devel] R: Re: Tracing drivers commands to an emulated device

Hi Stefan, thanks for the support i think that the better way for me is to combine the two approaches. At this time i want start profiling the disk and network driver activity. I will submit patches in the case that the trace events that i add can be useful for others. Francesco --Messaggi

Re: [Qemu-devel] [PATCH v4 07/07] s390: make sclp ascii console the default

On 30/07/12 16:05, Alexander Graf wrote: > > On 26.07.2012, at 10:59, Christian Borntraeger wrote: > >> This patch makes the sclp ascii default for S390. It requires a guest >> kernel that autodetects the console and which not blindly assumes >> that kvm means virtio console. >> (commit cd1834591

Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command

Il 31/07/2012 14:17, Kevin Wolf ha scritto: >> No, that should be ok. Though I'm not sure if it's so useful to apply >> throttling on the target. It's more useful to throttle the source >> (making writes slower than reads will help the job's convergence) and >> copy at full steam to the target. >

Re: [Qemu-devel] [PATCH v4 07/07] s390: make sclp ascii console the default

On 07/31/2012 02:44 PM, Christian Borntraeger wrote: On 30/07/12 16:05, Alexander Graf wrote: On 26.07.2012, at 10:59, Christian Borntraeger wrote: This patch makes the sclp ascii default for S390. It requires a guest kernel that autodetects the console and which not blindly assumes that kvm m

Re: [Qemu-devel] [PATCH V4 11/12] SD card: introduce "spi" property for SD card objects

Il 31/07/2012 14:19, Andreas Färber ha scritto: >>> >> +sd->spi = false; >>> >> +object_property_add(obj, "spi", "boolean", sd_is_spi, >>> >> sd_set_spimode, >>> >> +NULL, NULL, NULL); >>> >> +} >>> >> + >>> >> static const TypeInfo sd_type_info = { >>> >> .name = TYPE_SD

Re: [Qemu-devel] [PATCH v3 0/2] GlusterFS support in QEMU - v3

On Tue, Jul 31, 2012 at 1:38 PM, Bharata B Rao wrote: > On Tue, Jul 31, 2012 at 09:12:53AM +0100, Stefan Hajnoczi wrote: >> On Wed, Jul 25, 2012 at 6:58 AM, Bharata B Rao >> wrote: >> > Apart from cleanups, the major change in this version is to expose all >> > the gluster configuration options t

Re: [Qemu-devel] [PATCH 3/5] qapi: avoid reserved word restrict

On Tue, 31 Jul 2012 09:28:43 +0200 Paolo Bonzini wrote: > Il 30/07/2012 18:04, blauwir...@gmail.com ha scritto: > > From: Blue Swirl > > > > Clang compiler complained about use of reserved word 'restrict' in SLIRP > > and QAPI. > > > > Rename 'restrict' to 'restricted' which also matches other

Re: [Qemu-devel] [PATCH 4/7] s390: sclp event support

Am 24.07.2012 09:37, schrieb Christian Borntraeger: > From: Heinz Graalfs > > Several SCLP features are considered to be events. Those events don't > provide SCLP commands on their own, instead they are all based on > Read Event Data, Write Event Data, Write Event Mask and the service > interrupt

[Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

Avoid having an explicit list of directories in the 'clean' target by using 'find' to remove all .o and .d files instead. Signed-off-by: Peter Maydell --- I figured that (unlike Makefile.target) we should probably take the xargs route here since otherwise the rm command line is huge... There's a

Re: [Qemu-devel] KVM call agenda for Tuesday, July 31

On Mon, Jul 30, 2012 at 8:34 AM, Juan Quintela wrote: > Please send in any agenda items you are interested in covering. QEMU 1.2 Test Day * Let's find -rc bugs and ensure the release is stable * We've done this in the past and have a wiki template but can discuss suggestions on the call Stefan

Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work

On Tue, Jul 31, 2012 at 12:41 PM, Laszlo Ersek wrote: > (in reply to > -- > In-Reply-To set, but that may not be enough for the web archive) > > Looks good to me. A minor nit: 2/2 keeps the close(s->fd) call (instead > of calling

Re: [Qemu-devel] [PATCH v4 06/07] s390: sclp ascii console support

On 30/07/12 16:02, Alexander Graf wrote: >> +qemu_irq sclp_read_vt220; > > I'm sure this one wants a name that indicates it's an irq line ;) ok. > >> +} SCLPConsole; >> + >> +/* character layer call-back functions */ >> + >> +/* Return number of bytes that fit into iov buffer */ >> +static

Re: [Qemu-devel] [PATCH 02/11] Add migrate_set_parameter and query-migrate-parameters

On Tue, 31 Jul 2012 10:46:02 +0300 Orit Wasserman wrote: > On 07/30/2012 08:41 PM, Luiz Capitulino wrote: > > On Sun, 29 Jul 2012 12:42:54 +0300 > > Orit Wasserman wrote: > > > >> The management can enable/disable a capability for the next migration by > >> using > >> migrate_set_parameter com

Re: [Qemu-devel] [PATCH v3 0/2] GlusterFS support in QEMU - v3

On Tue, Jul 31, 2012 at 01:56:29PM +0100, Stefan Hajnoczi wrote: > On Tue, Jul 31, 2012 at 1:38 PM, Bharata B Rao > wrote: > > On Tue, Jul 31, 2012 at 09:12:53AM +0100, Stefan Hajnoczi wrote: > >> On Wed, Jul 25, 2012 at 6:58 AM, Bharata B Rao > >> wrote: > >> > Apart from cleanups, the major cha

Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

On Tue, 31 Jul 2012 11:31:09 +0300 Orit Wasserman wrote: > On 07/30/2012 10:37 PM, Luiz Capitulino wrote: > > On Sun, 29 Jul 2012 12:43:02 +0300 > > Orit Wasserman wrote: > > > >> Signed-off-by: Benoit Hudzia > >> Signed-off-by: Petter Svard > >> Signed-off-by: Aidan Shribman > >> Signed-off

Re: [Qemu-devel] [PATCH 09/11] Add migration accounting for normal and duplicate pages

On Tue, 31 Jul 2012 11:36:03 +0300 Orit Wasserman wrote: > On 07/30/2012 10:30 PM, Luiz Capitulino wrote: > > On Sun, 29 Jul 2012 12:43:01 +0300 > > Orit Wasserman wrote: > > > >> Signed-off-by: Benoit Hudzia > >> Signed-off-by: Petter Svard > >> Signed-off-by: Aidan Shribman > >> Signed-off

Re: [Qemu-devel] Adding a parameter to a helper

On Mon, Jul 30, 2012 at 6:40 PM, Jose Cano Reyes wrote: > I am trying to add a new integer parameter to an existing helper and call > this helper in "targeti386/translate.c". I have several problems: > > 1) I cannot add an integer parameter to the helper, the compiler says that > it must be "TCGv_

Re: [Qemu-devel] [QEMU PATCH 3/3] x86: pc: versioned CPU model names & compatibility aliases

On Thu, Jul 26, 2012 at 10:48:45AM -0400, Eduardo Habkost wrote: ... > > [1] There are multiple changes I want to make the cpudef config format: > > - Make it based on boolean per-feature flags, not low-level > feature_ bits I'm trying to convert features to properties before looking at global

Re: [Qemu-devel] KVM call agenda for Tuesday, July 31

On Mon, Jul 30, 2012 at 09:34:05AM +0200, Juan Quintela wrote: > > Hi > > Please send in any agenda items you are interested in covering. - 1.2 plans for CPU model versioning/compatibility (global properties vs QOM vs qdev) -- Eduardo

Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

On Tue, Jul 31, 2012 at 02:01:35PM +0100, Peter Maydell wrote: > Avoid having an explicit list of directories in the 'clean' > target by using 'find' to remove all .o and .d files instead. > > Signed-off-by: Peter Maydell > --- > I figured that (unlike Makefile.target) we should probably take > t

Re: [Qemu-devel] [PATCH v4] Fixes related to processing of qemu's -numa option

Ping? Can anybody help Vinod, here? How can we get the attention of some maintainer, to get this pulled in? On Wed, Jul 18, 2012 at 06:26:52PM +, Vinod, Chegu wrote: > Thanks Eduardo ! > > Hi Anthony, If you are ok with this patch...could you pl pull these changes > into upstream (or) > s

Re: [Qemu-devel] 9p broken?

Avi Kivity writes: > On 07/31/2012 09:51 AM, Aneesh Kumar K.V wrote: >> Avi Kivity writes: >> >>> Having an annoying bug on i386 kvm I decided to debug it buy running an >>> i386 guest on my x86_64 host, use 9p to access a guest image, and run it >>> using nested kvm. >>> >>> However, 9p appear

Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work

On Fri, Jul 20, 2012 at 2:25 PM, Stefan Hajnoczi wrote: > The socket backend does not support the listen= option with -netdev. The > problem is how the socket NetClientState lifecycle is implemented: the socket > backend waits for an incoming client connection before creating a > NetClientState.

Re: [Qemu-devel] [libvirt-users] Using virsh to load scripts for the guest machine

On 07/30/2012 12:00 PM, Mauricio Tavares wrote: > On Mon, Jul 30, 2012 at 1:50 PM, Eric Blake wrote: >> On 07/15/2012 07:52 PM, Mauricio Tavares wrote: >>> Right on the top of >>> http://www.centos.org/docs/5/html/5.2/Virtualization/chap-Virtualization-Managing_guests_with_virsh.html, >>> it s

Re: [Qemu-devel] [QEMU PATCH 3/3] x86: pc: versioned CPU model names & compatibility aliases

On Tue, Jul 31, 2012 at 03:22:59PM +0200, Igor Mammedov wrote: > On Thu, Jul 26, 2012 at 10:48:45AM -0400, Eduardo Habkost wrote: > ... > > > > [1] There are multiple changes I want to make the cpudef config format: > > > > - Make it based on boolean per-feature flags, not low-level > > featur

Re: [Qemu-devel] 9p broken?

On 07/31/2012 04:30 PM, Aneesh Kumar K.V wrote: > > Did this help ? > > http://mid.gmane.org/1343719453-26768-1-git-send-email-aneesh.ku...@linux.vnet.ibm.com > It did: thanks. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] Compile errors on latest checkout

Il 31/07/2012 08:04, Gerhard Wiesinger ha scritto: > Hello, > > I'm getting the following compile errors: > > /root/download/qemu/git/qemu/hw/megasas.c: In function > ‘megasas_class_init’: > /root/download/qemu/git/qemu/hw/megasas.c:2155:14: error: assignment > from incompatible pointer type [-We

Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

On 07/31/2012 04:16 PM, Luiz Capitulino wrote: > On Tue, 31 Jul 2012 11:31:09 +0300 > Orit Wasserman wrote: > >> On 07/30/2012 10:37 PM, Luiz Capitulino wrote: >>> On Sun, 29 Jul 2012 12:43:02 +0300 >>> Orit Wasserman wrote: >>> Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

Il 31/07/2012 07:54, Stefan Weil ha scritto: > Commit f90c2bcdbc69e41e575f868b984c3e2de8f51bac changed > PCIUnregisterFunc, therefore the function prototype > needs an update. > > megasas.o is currently not linked, so this bug was not > detected by the buildbots. > > Signed-off-by: Stefan Weil >

Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

Peter Maydell writes: > Avoid having an explicit list of directories in the 'clean' > target by using 'find' to remove all .o and .d files instead. > > Signed-off-by: Peter Maydell > --- > I figured that (unlike Makefile.target) we should probably take > the xargs route here since otherwise the

Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work

Il 31/07/2012 15:04, Stefan Hajnoczi ha scritto: >> > Looks good to me. A minor nit: 2/2 keeps the close(s->fd) call (instead >> > of calling closesocket(s->fd), like in eoc handling) in >> > net_socket_cleanup(). > The reason I didn't change close(2) to closesocket() is because > -netdev socket,fd

Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

On 31 July 2012 15:19, Markus Armbruster wrote: > Peter Maydell writes: >> + find . -name '*.[od]' | xargs rm -f >> + rm -f *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ >> */*~ > > Shit happens if you somehow manage to create a "mean" file name in the > build tree. Sure

Re: [Qemu-devel] [PATCH V4 01/12] hw/sd.c: convert wp_groups in SDState to bitfield

On 27 July 2012 20:29, Igor Mitsyanko wrote: > Representing each group write protection flag with only one bit instead of int > variable significantly reduces memory consumption. ...and it looks much nicer too. Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

On 07/31/2012 08:19 AM, Markus Armbruster wrote: > Peter Maydell writes: > >> Avoid having an explicit list of directories in the 'clean' >> target by using 'find' to remove all .o and .d files instead. >> >> rm -f qemu-options.def >> -rm -f *.o *.d *.a *.lo $(TOOLS) $(HELPERS-y) qemu-g

Re: [Qemu-devel] [PATCH V4 02/12] hw/sd.c: make sd_wp_addr() accept 64 bit address argument

On 27 July 2012 20:29, Igor Mitsyanko wrote: > Currently sd_wp_addr() accepts 32 bit address arguments therefore implicitly > restricting SD card address range. Change address argument type to uint64_t. > > Signed-off-by: Igor Mitsyanko Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH V4 03/12] hw/sd.c: introduce wrapper for conversion address to wp group

On 27 July 2012 20:29, Igor Mitsyanko wrote: > Add wrapper function sd_addr_to_wpnum() to replace long address-->wg_group > conversion line. > > Signed-off-by: Igor Mitsyanko Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] KVM call minutes July 31th

Hi Today minutes: - Avi fixed and got 9p working - QEMU 1.2 Test Day (stefan) * Let's find -rc bugs and ensure the release is stable * We've done this in the past and have a wiki template but can discuss suggestions on the call * A date? - 1.2 plans for CPU model versioning/compatibil

Re: [Qemu-devel] [PATCH V4 04/12] hw/sd.c: favour SD card type (SDSC or SDHC) when performing erase

On 27 July 2012 20:29, Igor Mitsyanko wrote: > Standard capacity cards SDSC use byte unit address while SDHC and SDXC Cards > use > block unit address (512 bytes) when setting ERASE_START and ERASE_END with > CMD32 > and CMD33, we have to account for this. > > Signed-off-by: Igor Mitsyanko > --

Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

Peter Maydell writes: > On 31 July 2012 15:19, Markus Armbruster wrote: >> Peter Maydell writes: >>> + find . -name '*.[od]' | xargs rm -f >>> + rm -f *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod >>> *~ */*~ >> >> Shit happens if you somehow manage to create a "mean" file name

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

Am 31.07.2012 07:54, schrieb Stefan Weil: > Commit f90c2bcdbc69e41e575f868b984c3e2de8f51bac changed > PCIUnregisterFunc, therefore the function prototype > needs an update. > > megasas.o is currently not linked, so this bug was not > detected by the buildbots. Why would megasas be in master but n

Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target

On Tue, Jul 31, 2012 at 04:35:42PM +0200, Markus Armbruster wrote: > Peter Maydell writes: > > > On 31 July 2012 15:19, Markus Armbruster wrote: > >> Peter Maydell writes: > >>> + find . -name '*.[od]' | xargs rm -f > >>> + rm -f *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod >

Re: [Qemu-devel] [PATCH V4 07/12] hw/sd.c: make sd_wp_addr() return bool

On 27 July 2012 20:29, Igor Mitsyanko wrote: > For the sake of code clarity > > Signed-off-by: Igor Mitsyanko Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

Il 31/07/2012 16:39, Andreas Färber ha scritto: >> > Commit f90c2bcdbc69e41e575f868b984c3e2de8f51bac changed >> > PCIUnregisterFunc, therefore the function prototype >> > needs an update. >> > >> > megasas.o is currently not linked, so this bug was not >> > detected by the buildbots. > Why would m

Re: [Qemu-devel] [RFC 00/27]: add new error format

On Fri, 27 Jul 2012 18:31:41 -0300 Luiz Capitulino wrote: > [Please, read below why this is an RFC] > > This series implements the 'Plan for error handling in QMP' as described > by Anthony in this email: For anyone willing to try this series, it applies on top of dfe1ce5d80 on master. My local

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

Am 31.07.2012 16:43, schrieb Paolo Bonzini: > Il 31/07/2012 16:39, Andreas Färber ha scritto: Commit f90c2bcdbc69e41e575f868b984c3e2de8f51bac changed PCIUnregisterFunc, therefore the function prototype needs an update. megasas.o is currently not linked, so this bug was not

  1   2   3   >