Il 31/07/2012 15:04, Stefan Hajnoczi ha scritto: >> > Looks good to me. A minor nit: 2/2 keeps the close(s->fd) call (instead >> > of calling closesocket(s->fd), like in eoc handling) in >> > net_socket_cleanup(). > The reason I didn't change close(2) to closesocket() is because > -netdev socket,fd= can pass arbitrary file descriptors. I suspect > only real socket objects will work but we basically don't know what > the passed file descriptor is. This is the reason why I didn't feel > 100% happy converting it to closesocket(). >
-netdev socket,fd= is probably not usable from Windows, so no problem using close(). Paolo
