Re: [Qemu-devel] [Qemu-discuss] qemu-kvm: -netdev user: Parameter 'id' is missing

2012-07-26 Thread anatoly techtonik
On Wed, Jul 25, 2012 at 6:00 PM, Stefan Hajnoczi wrote: > On Tue, Jul 24, 2012 at 8:02 PM, anatoly techtonik > wrote: >> On Tue, Jul 24, 2012 at 1:23 PM, Stefan Hajnoczi wrote: >>> On Mon, Jul 23, 2012 at 10:41 PM, anatoly techtonik >>> wrote: Forwarding per discussion in qemu-discuss. >

[Qemu-devel] [Bug 1021649] Re: qemu 1.1.0 waits for a keypress at boot

2012-07-26 Thread Michael Tokarev
This is definitely a wrong way to "fix" this issue. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1021649 Title: qemu 1.1.0 waits for a keypress at boot Status in QEMU: Confirmed Status in “qemu

[Qemu-devel] Qemu crashed with lsi booting

2012-07-26 Thread Frediano Ziglio
I always get an assert launching this command sudo ./x86_64-softmmu/qemu-system-x86_64 -m 1024 -hda test.qcow -device lsi -drive file=/dev/sdb,if=none,id=XXX -device scsi-block,drive=XXX -enable-kvm -bios ~/seabios/out/bios.bin -serial file:out.txt lsi_scsi: error: Multiple IO pending for request

Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu

2012-07-26 Thread Avi Kivity
On 07/25/2012 10:53 PM, Alex Williamson wrote: > On Wed, 2012-07-25 at 22:30 +0300, Avi Kivity wrote: >> On 07/25/2012 08:03 PM, Alex Williamson wrote: >> > This adds PCI based device assignment to Qemu using the Linux VFIO >> > userspace driver interface. After setting up VFIO device access, >> >

[Qemu-devel] [PATCH v4 06/07] s390: sclp ascii console support

2012-07-26 Thread Christian Borntraeger
From: Heinz Graalfs This code adds console support by implementing SCLP's ASCII Console Data event. This is the same console as LPARs ASCII console or z/VMs sysascii. The console can be specified manually with something like -chardev stdio,id=charconsole0 -device sclpconsole,chardev=charconsol

Re: [Qemu-devel] [PATCH] tcm_vhost: Expose ABI version via VHOST_SCSI_GET_ABI_VERSION

2012-07-26 Thread Avi Kivity
On 07/26/2012 05:34 AM, Nicholas A. Bellinger wrote: > > In that case, respinning a -v5 for tcm_vhost to start from ABI=0 and > will post an updated patch shortly. > >> The main thing I would like to confirm is that this only versions the >> tcm_vhost ioctls? In that case a single version number

Re: [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-07-26 Thread Kevin Wolf
Am 26.07.2012 05:57, schrieb Corey Bryant: > On 07/25/2012 03:43 PM, Eric Blake wrote: >> On 07/23/2012 07:08 AM, Corey Bryant wrote: >>> +int monitor_fdset_get_fd(Monitor *mon, int64_t fdset_id, int flags) >>> +{ >>> +mon_fdset_t *mon_fdset; >>> +mon_fdset_fd_t *mon_fdset_fd; >>> +int

[Qemu-devel] [PATCH v4 07/07] s390: make sclp ascii console the default

2012-07-26 Thread Christian Borntraeger
This patch makes the sclp ascii default for S390. It requires a guest kernel that autodetects the console and which not blindly assumes that kvm means virtio console. (commit cd1834591fe9564720ac4b0193bf1c790fe89f0d KVM: s390: Perform early event mask processing during boot) Otherwise the guest

[Qemu-devel] [PATCH v4 07/07] s390: make sclp ascii console the default

2012-07-26 Thread Christian Borntraeger
This patch makes the sclp ascii default for S390. It requires a guest kernel that autodetects the console and which not blindly assumes that kvm means virtio console. (commit cd1834591fe9564720ac4b0193bf1c790fe89f0d KVM: s390: Perform early event mask processing during boot) Otherwise the guest

Re: [Qemu-devel] [PATCH 04/27] add a version number to ram_list

2012-07-26 Thread Juan Quintela
Michael Roth wrote: > On Tue, Jul 24, 2012 at 08:36:29PM +0200, Juan Quintela wrote: >> From: Umesh Deshpande >> >> This will be used to detect if last_block might have become invalid >> across different calls to ram_save_live. > > Was it a bug in the old code to not do this? In the unthreaded

Re: [Qemu-devel] [PATCH 10/27] Separate migration bitmap

2012-07-26 Thread Juan Quintela
Avi Kivity wrote: > On 07/24/2012 09:36 PM, Juan Quintela wrote: >> This patch creates a migration bitmap, which is periodically kept in >> sync with the qemu bitmap. A separate copy of the dirty bitmap for the >> migration limits the amount of concurrent access to the qemu bitmap >> from iothread

Re: [Qemu-devel] [Qemu-discuss] qemu-kvm: -netdev user: Parameter 'id' is missing

2012-07-26 Thread Stefan Hajnoczi
On Thu, Jul 26, 2012 at 9:21 AM, anatoly techtonik wrote: > On Wed, Jul 25, 2012 at 6:00 PM, Stefan Hajnoczi wrote: >> On Tue, Jul 24, 2012 at 8:02 PM, anatoly techtonik >> wrote: >>> On Tue, Jul 24, 2012 at 1:23 PM, Stefan Hajnoczi wrote: On Mon, Jul 23, 2012 at 10:41 PM, anatoly techton

Re: [Qemu-devel] How to share disk image between two kvm guests

2012-07-26 Thread Stefan Hajnoczi
On Thu, Jul 26, 2012 at 3:51 AM, Bing Bu Cao wrote: > Hi,all > > I want to use qemu-nbd to share disk between two kvm guests. > > I. > # qemu-nbd -p 1024 -e 2 -n my-disk.qcow2 > # nbd-client localhost 1024 /dev/nbd0 > # nbd-client localhost 1024 /dev/nbd1 > > II. > guest1: > # /usr/local/bin/qemu

Re: [Qemu-devel] [RFC 00/14]: add printf-like human msg to error_set()

2012-07-26 Thread Kevin Wolf
Am 26.07.2012 04:43, schrieb Anthony Liguori: > Luiz Capitulino writes: > >> Basically, this series changes a call like: >> >> error_set(errp, QERR_DEVICE_NOT_FOUND, device); >> >> to: >> >> error_set(errp, QERR_DEVICE_NOT_FOUND, >>"Device 'device=%s' not found", device); >> >> In t

[Qemu-devel] [PATCH] configure: Fix xen probe with Xen 4.2 and later.

2012-07-26 Thread Anthony PERARD
The xs.h header is now deprecated and produce a warning. This prevent the configure script from enabling xen with Xen unstable whom will become 4.2. As this header is not anymore common to every version of Xen, we just remove it from the early probe for Xen. Signed-off-by: Anthony PERARD --- co

Re: [Qemu-devel] How to share disk image between two kvm guests

2012-07-26 Thread Bing Bu Cao
On 07/26/2012 05:30 PM, Stefan Hajnoczi wrote: On Thu, Jul 26, 2012 at 3:51 AM, Bing Bu Cao wrote: Hi,all I want to use qemu-nbd to share disk between two kvm guests. I. # qemu-nbd -p 1024 -e 2 -n my-disk.qcow2 # nbd-client localhost 1024 /dev/nbd0 # nbd-client localhost 1024 /dev/nbd1 II. g

Re: [Qemu-devel] [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-26 Thread Stefan Hajnoczi
On Wed, Jul 25, 2012 at 10:13 AM, Yoshihiro YUNOMAE wrote: > Hi Stefan, > > > (2012/07/24 22:41), Stefan Hajnoczi wrote: >> >> On Tue, Jul 24, 2012 at 12:19 PM, Yoshihiro YUNOMAE >> wrote: > > Are you using text formatted ftrace? >>> >>> No, currently using raw format, but we'd like to re

[Qemu-devel] [PATCH v2] qemu-iotests: add qed.py image manipulation utility

2012-07-26 Thread Stefan Hajnoczi
The qed.py utility can inspect and manipulate QED image files. It can be used for testing to see the state of image metadata and also to inject corruptions into the image file. It also has a scrubbing feature to copy just the metadata out of an image file, allowing users to share broken image fil

Re: [Qemu-devel] [RFC 00/27] Migration thread (WIP)

2012-07-26 Thread Jan Kiszka
On 2012-07-24 20:36, Juan Quintela wrote: > Hi > > This series are on top of the migration-next-v5 series just posted. > > First of all, this is an RFC/Work in progress. Just a lot of people > asked for it, and I would like review of the design. > > It does: > - get a new bitmap for migration,

Re: [Qemu-devel] [PATCH 06/11] qerror: QERR_AMBIGUOUS_PATH: drop %(object) from human msg

2012-07-26 Thread Markus Armbruster
Luiz Capitulino writes: > Actually, renames it to 'object'. This must be what the original author > meant to write, as there's no 'object' in the error's data member. > > Signed-off-by: Luiz Capitulino > --- > qerror.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qer

[Qemu-devel] [PATCH V4 0/3] Show backing file depth in HMP

2012-07-26 Thread benoit . canet
From: Benoît Canet In some setups many backing files and snapshot are chained. This lead to the formation of huge trees of snapshots all depending on a common ancestor. Hence if something bad happen to this common ancestor all the snapshot of the tree will be broken. This patch add an easy way

[Qemu-devel] [PATCH V4 1/3] block: create bdrv_get_backing_file_depth()

2012-07-26 Thread benoit . canet
From: Benoît Canet Create bdrv_get_backing_file_depth() in order to be able to show in QMP and HMP how many ancestors backing an image a block device have. Signed-off-by: Benoit Canet --- block.c | 13 + block.h |1 + 2 files changed, 14 insertions(+) diff --git a/block.c b/

[Qemu-devel] [PATCH V4 3/3] hmp: show the backing file depth

2012-07-26 Thread benoit . canet
From: Benoît Canet Signed-off-by: Benoit Canet --- hmp.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hmp.c b/hmp.c index 6b72a64..25688ab 100644 --- a/hmp.c +++ b/hmp.c @@ -227,6 +227,8 @@ void hmp_info_block(Monitor *mon) if (info->value->inserted->has_backing_file) {

[Qemu-devel] [PATCH V4 2/3] block: Use bdrv_get_backing_file_depth()

2012-07-26 Thread benoit . canet
From: Benoît Canet Use the dedicated counting function in qmp_query_block in order to propagate the backing file depth to HMP. Signed-off-by: Benoit Canet --- block.c |3 +++ qapi-schema.json |9 ++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/block.c

Re: [Qemu-devel] [RFC 00/27] Migration thread (WIP)

2012-07-26 Thread Juan Quintela
Jan Kiszka wrote: > On 2012-07-24 20:36, Juan Quintela wrote: >> Hi >> Appart of the review: >> - Are there any locking issues that I have missed (I guess so) >> - stop all cpus correctly. vm_stop should be called from the iothread, >> I use the trick of using a bottom half to get that working

Re: [Qemu-devel] [PATCH 07/11] qapi: qapi.py: allow the "'" character be escaped

2012-07-26 Thread Markus Armbruster
Peter Maydell writes: > On 25 July 2012 20:18, Luiz Capitulino wrote: >> Peter Maydell wrote: >>> On 25 July 2012 17:54, Luiz Capitulino wrote: >>> > --- a/scripts/qapi.py >>> > +++ b/scripts/qapi.py >>> > @@ -21,7 +21,9 @@ def tokenize(data): >>> > elif data[0] == "'": >>> >

Re: [Qemu-devel] [PATCH v2] qemu-iotests: add qed.py image manipulation utility

2012-07-26 Thread Kevin Wolf
Am 26.07.2012 09:08, schrieb Stefan Hajnoczi: > The qed.py utility can inspect and manipulate QED image files. It can > be used for testing to see the state of image metadata and also to > inject corruptions into the image file. It also has a scrubbing feature > to copy just the metadata out of a

Re: [Qemu-devel] [RFC PATCH 0/6] virtio-trace: Support virtio-trace

2012-07-26 Thread Amit Shah
On (Tue) 24 Jul 2012 [11:36:57], Yoshihiro YUNOMAE wrote: > Hi All, > > The following patch set provides a low-overhead system for collecting kernel > tracing data of guests by a host in a virtualization environment. > > A guest OS generally shares some devices with other guests or a host, so > r

Re: [Qemu-devel] [PATCH 09/11] qapi: add qapi-errors.py

2012-07-26 Thread Markus Armbruster
Paolo, Eric, I got a make puzzle for you below. Luiz Capitulino writes: > This script generates two files from qapi-schema-errors.json: > > o qapi-errors.h: contains error macro definitions, eg. QERR_BASE_NOT_FOUND, > corresponds to most of today's qerror.h > > o qapi-errors.

Re: [Qemu-devel] [PATCH 09/11] qapi: add qapi-errors.py

2012-07-26 Thread Paolo Bonzini
Il 26/07/2012 13:50, Markus Armbruster ha scritto: >> > +qapi-errors.h qapi-errors.c :\ >> > +$(SRC_PATH)/qapi-schema-errors.json $(SRC_PATH)/scripts/qapi-errors.py >> > + $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-errors.py -o >> > "." < $<, " GEN $@") > I'm afraid this isn't qui

Re: [Qemu-devel] [PATCH 10/11] qerror: switch to qapi generated error macros and table

2012-07-26 Thread Markus Armbruster
Luiz Capitulino writes: > Previous commits added qapi infrastructure to automatically generate > qerror macros and the qerror table from qapi-schema-errors.json. > > This commit drops the current error macros from qerror.h and the error > table from qerror.c and use the generated ones instead. >

Re: [Qemu-devel] [RFC 00/27] Migration thread (WIP)

2012-07-26 Thread Jan Kiszka
On 2012-07-26 13:16, Juan Quintela wrote: > Jan Kiszka wrote: >> On 2012-07-24 20:36, Juan Quintela wrote: >>> Hi > >>> Appart of the review: >>> - Are there any locking issues that I have missed (I guess so) >>> - stop all cpus correctly. vm_stop should be called from the iothread, >>> I use

Re: [Qemu-devel] [PATCH 11/11] scripts: update check-qerror.sh

2012-07-26 Thread Markus Armbruster
Luiz Capitulino writes: > The qerror.h file doesn't contain the macros anymore, the script should > check qapi-schema-errors.json instead. > > Signed-off-by: Luiz Capitulino > --- > scripts/check-qerror.sh | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/scripts/ch

Re: [Qemu-devel] [PATCH v2] qemu-iotests: add qed.py image manipulation utility

2012-07-26 Thread Stefan Hajnoczi
On Thu, Jul 26, 2012 at 01:34:06PM +0200, Kevin Wolf wrote: > Am 26.07.2012 09:08, schrieb Stefan Hajnoczi: > > The qed.py utility can inspect and manipulate QED image files. It can > > be used for testing to see the state of image metadata and also to > > inject corruptions into the image file.

Re: [Qemu-devel] [PATCH 09/11] qapi: add qapi-errors.py

2012-07-26 Thread Markus Armbruster
Luiz Capitulino writes: > This script generates two files from qapi-schema-errors.json: > > o qapi-errors.h: contains error macro definitions, eg. QERR_BASE_NOT_FOUND, > corresponds to most of today's qerror.h > > o qapi-errors.c: contains the error table that currently exists

[Qemu-devel] [PATCH v3] qemu-iotests: add qed.py image manipulation utility

2012-07-26 Thread Stefan Hajnoczi
The qed.py utility can inspect and manipulate QED image files. It can be used for testing to see the state of image metadata and also to inject corruptions into the image file. It also has a scrubbing feature to copy just the metadata out of an image file, allowing users to share broken image fil

[Qemu-devel] [PATCH RFC v4 18/18] MAINTAINERS: Document virtex_ml507 machine

2012-07-26 Thread Andreas Färber
It's a ppc440, so place it close to Bamboo. Signed-off-by: Andreas Färber Cc: Alexander Graf Cc: Edgar E. Iglesias --- MAINTAINERS |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 00fb0fa..7a24e4d 100644 --- a/MAINTAINERS +++ b/MAINT

Re: [Qemu-devel] [PATCH V4 2/3] block: Use bdrv_get_backing_file_depth()

2012-07-26 Thread Eric Blake
On 07/26/2012 05:16 AM, benoit.ca...@gmail.com wrote: > From: Benoît Canet > > Use the dedicated counting function in qmp_query_block in order to > propagate the backing file depth to HMP. > > # > +# @backing-file-depth: the count of ancestor's backing files (since: 1.2) > +# That still reads

Re: [Qemu-devel] [PATCH v3] qemu-iotests: add qed.py image manipulation utility

2012-07-26 Thread Kevin Wolf
Am 26.07.2012 14:24, schrieb Stefan Hajnoczi: > The qed.py utility can inspect and manipulate QED image files. It can > be used for testing to see the state of image metadata and also to > inject corruptions into the image file. It also has a scrubbing feature > to copy just the metadata out of a

Re: [Qemu-devel] [PATCH 03/14] qerror: drop qerror_abort()

2012-07-26 Thread Markus Armbruster
Luiz Capitulino writes: > Previously, developers had to create error dicts manually and also enter > the matching desc table entry. Thus, qerro_abort() was added to help s/qerro_/qerror_/ > catching bad error dicts. > > Today, all that stuff is generated automatically which makes the chance > o

Re: [Qemu-devel] [PATCH v2] qemu-iotests: add qed.py image manipulation utility

2012-07-26 Thread Eric Blake
On 07/26/2012 01:08 AM, Stefan Hajnoczi wrote: > The qed.py utility can inspect and manipulate QED image files. It can > be used for testing to see the state of image metadata and also to > inject corruptions into the image file. It also has a scrubbing feature > to copy just the metadata out of

Re: [Qemu-devel] [PATCH 04/14] qerror: drop qerror_report_internal()

2012-07-26 Thread Markus Armbruster
Luiz Capitulino writes: > It's not needed anymore and conflicts with future error improvements. > > Also drops related error information, that is, the file where the error > ocurred, the line number and function. This has never been fully used. Suggest "Subject: qerror: drop file, linenr, func",

Re: [Qemu-devel] [PATCH 09/11] qapi: add qapi-errors.py

2012-07-26 Thread Eric Blake
On 07/26/2012 05:55 AM, Paolo Bonzini wrote: > Il 26/07/2012 13:50, Markus Armbruster ha scritto: +qapi-errors.h qapi-errors.c :\ +$(SRC_PATH)/qapi-schema-errors.json $(SRC_PATH)/scripts/qapi-errors.py + $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/qapi-errors.py -o "."

[Qemu-devel] [PATCH v4 13/18] pci: Derive PCI host bridges from TYPE_PCI_HOST_BRIDGE

2012-07-26 Thread Andreas Färber
Some typedef'ed their state to PCIHostState. Use a proper struct, and use PCIHostState and PCI_HOST_BRIDGE() where appropriate. Signed-off-by: Andreas Färber --- hw/alpha_typhoon.c |2 +- hw/bonito.c| 22 +++--- hw/dec_pci.c |4 ++-- hw/grackle_pci.c |

Re: [Qemu-devel] [PATCH RFC v4 15/18] MAINTAINERS: Document sPAPR (pSeries) machine

2012-07-26 Thread David Gibson
On Thu, Jul 26, 2012 at 02:28:33PM +0200, Andreas Färber wrote: > Signed-off-by: Andreas Färber > Cc: Alexander Graf > Cc: Benjamin Herrenschmidt > Cc: David Gibson Acked-by: David Gibson -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.i

Re: [Qemu-devel] [PATCH v4 10/18] spapr_pci: QOM'ify sPAPR PCI host bridge

2012-07-26 Thread David Gibson
On Thu, Jul 26, 2012 at 02:28:28PM +0200, Andreas Färber wrote: > Introduce type constant. Introduce cast macro to drop bogus busdev field > that would've broken SYS_BUS_DEVICE(). I believe there's already a patch making its way through agraf's tree that removes the bogus extra busdev. -- David

Re: [Qemu-devel] [RFC 00/14]: add printf-like human msg to error_set()

2012-07-26 Thread Anthony Liguori
Kevin Wolf writes: > Am 26.07.2012 04:43, schrieb Anthony Liguori: >> Luiz Capitulino writes: >> >>> Basically, this series changes a call like: >>> >>> error_set(errp, QERR_DEVICE_NOT_FOUND, device); >>> >>> to: >>> >>> error_set(errp, QERR_DEVICE_NOT_FOUND, >>>"Device 'device=%s

Re: [Qemu-devel] [PATCH 09/11] qapi: add qapi-errors.py

2012-07-26 Thread Eric Blake
On 07/26/2012 06:38 AM, Eric Blake wrote: >>> Paolo, Eric, maybe you can provide advice on how to best tell make that >>> a recipe generates multiple files. >> >> Hmm, I would just do >> >> qapi-errors.h: qapi-errors.c >> qapi-errors.c: $(SRC_PATH)/qapi-schema-errors.json >> $(SRC_PATH)/scripts/qa

[Qemu-devel] [PATCH for-ppc-next 0/2] target-ppc: e500 MAINTAINERS update

2012-07-26 Thread Andreas Färber
Hi Alex, As discussed, here's a patchset on top of my master-based pci_host series that updates the proposed MAINTAINERS entries to match Scott's pending changes. This should go through ppc-next if the other series gets applied to master. Otherwise the second patch can be squashed into the origin

[Qemu-devel] [PATCH for-ppc-next 2/2] MAINTAINERS: Update e500 machine

2012-07-26 Thread Andreas Färber
Files were relocated and a new generic machine extracted. hw/ppce500_* pattern is still needed for the PCI host bridge. Signed-off-by: Andreas Färber Cc: Scott Wood --- MAINTAINERS |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7b26818.

[Qemu-devel] [PATCH for-ppc-next 1/2] MAINTAINERS: Downgrade ppc405 to Odd Fixes

2012-07-26 Thread Andreas Färber
As requested by Alex. Signed-off-by: Andreas Färber --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7a24e4d..7b26818 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -349,7 +349,7 @@ PowerPC Machines 405 M: Alexander Graf

Re: [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output

2012-07-26 Thread Daniel P. Berrange
On Wed, Jul 25, 2012 at 02:47:57PM -0500, Anthony Liguori wrote: > The help output is going to change dramatically for 0.13. We've spent too > long > waiting for a perfect solution to capabilities handling and the end loser is > the direct consumer of QEMU because the help output is awful. > > I

Re: [Qemu-devel] [PATCH 08/14] qerror: add build_error_dict() and error_object_table[]

2012-07-26 Thread Markus Armbruster
Luiz Capitulino writes: > In the near future, the QERR_ macros (which are json strings today) will > be turned into an enumeration. When we get there, build_error_dict() > will be used to (guess what) build an error dict by: > > 1. Using the error class as an index to error_object_table[], which

Re: [Qemu-devel] [PATCH 21/27] migration: stop all cpus correctly

2012-07-26 Thread Eric Blake
On 07/24/2012 12:36 PM, Juan Quintela wrote: > You can only stop all cpus from the iothread or an vcpu. As we want > to do it from the migration_thread, we need to do this dance with the > botton handlers. s/botton/bottom/ ? > > This patch is a request for ideas. I can move this function to cp

Re: [Qemu-devel] [PATCH 11/14] qerror: drop qerror_table[] for good

2012-07-26 Thread Markus Armbruster
Luiz Capitulino writes: > Last commit deprecated it. Do you mean "Unused since last commit"? >Also drops the code that used it to generate > error objects.

Re: [Qemu-devel] [PATCH v3] qemu-iotests: add qed.py image manipulation utility

2012-07-26 Thread Eric Blake
On 07/26/2012 06:24 AM, Stefan Hajnoczi wrote: > The qed.py utility can inspect and manipulate QED image files. It can > be used for testing to see the state of image metadata and also to > inject corruptions into the image file. It also has a scrubbing feature > to copy just the metadata out of

Re: [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it

2012-07-26 Thread liu ping fan
On Wed, Jul 25, 2012 at 5:08 PM, Paolo Bonzini wrote: > Il 25/07/2012 05:31, Liu Ping Fan ha scritto: >> From: Liu Ping Fan >> >> rwlock: >> qemu_device_tree_mutex >> >> rd side: >> --device_del(destruction of device will be postphoned until unplug >> ack from guest), >> --pci hot-unplu

Re: [Qemu-devel] [PATCH v2 3/7] docs: add lazy refcounts bit to qcow2 specification

2012-07-26 Thread Kevin Wolf
Am 25.07.2012 14:21, schrieb Stefan Hajnoczi: > The lazy refcounts bit indicates that this image can take advantage of > the dirty bit and that refcount updates can be postponed. > > Signed-off-by: Stefan Hajnoczi > --- > docs/specs/qcow2.txt |7 ++- > 1 file changed, 6 insertions(+), 1

[Qemu-devel] [PATCH RFC v4 15/18] MAINTAINERS: Document sPAPR (pSeries) machine

2012-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber Cc: Alexander Graf Cc: Benjamin Herrenschmidt Cc: David Gibson --- MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2d219d2..282d497 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -374,6 +374

[Qemu-devel] [PATCH v4 01/18] pci: Make host bridge TypeInfos const

2012-07-26 Thread Andreas Färber
During the QOM migration they were amended with further info but this is no longer the case. All static TypeInfos can be const these days. Signed-off-by: Andreas Färber --- hw/alpha_typhoon.c |2 +- hw/bonito.c|4 ++-- hw/dec_pci.c |6 +++--- hw/grackle_pci.c |4 +

Re: [Qemu-devel] [PATCH 03/14] qerror: drop qerror_abort()

2012-07-26 Thread Eric Blake
On 07/25/2012 02:50 PM, Luiz Capitulino wrote: > Previously, developers had to create error dicts manually and also enter > the matching desc table entry. Thus, qerro_abort() was added to help s/qerro_/qerror_/ > catching bad error dicts. > > Today, all that stuff is generated automatically whic

Re: [Qemu-devel] [PATCH 2/5] exec.c: use refcnt to protect device during dispatching

2012-07-26 Thread liu ping fan
On Wed, Jul 25, 2012 at 5:18 PM, Paolo Bonzini wrote: > Il 25/07/2012 10:12, liu ping fan ha scritto: >> +qemu_rwlock_rdlock_devtree(); >> section = phys_page_find(page >> TARGET_PAGE_BITS); >> +if (!(memory_region_is_ram(section->mr) || >> +

Re: [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it

2012-07-26 Thread Avi Kivity
On 07/26/2012 03:56 PM, liu ping fan wrote: > On Wed, Jul 25, 2012 at 5:08 PM, Paolo Bonzini wrote: >> Il 25/07/2012 05:31, Liu Ping Fan ha scritto: >>> From: Liu Ping Fan >>> >>> rwlock: >>> qemu_device_tree_mutex >>> >>> rd side: >>> --device_del(destruction of device will be postphoned unt

Re: [Qemu-devel] [PATCH v3] qemu-iotests: add qed.py image manipulation utility

2012-07-26 Thread Kevin Wolf
Am 26.07.2012 14:56, schrieb Eric Blake: > On 07/26/2012 06:24 AM, Stefan Hajnoczi wrote: >> The qed.py utility can inspect and manipulate QED image files. It can >> be used for testing to see the state of image metadata and also to >> inject corruptions into the image file. It also has a scrubbi

Re: [Qemu-devel] [PATCH v4 10/18] spapr_pci: QOM'ify sPAPR PCI host bridge

2012-07-26 Thread Andreas Färber
Am 26.07.2012 14:31, schrieb David Gibson: > On Thu, Jul 26, 2012 at 02:28:28PM +0200, Andreas Färber wrote: >> Introduce type constant. Introduce cast macro to drop bogus busdev field >> that would've broken SYS_BUS_DEVICE(). > > I believe there's already a patch making its way through agraf's tr

Re: [Qemu-devel] Synchronize issue and lost character when using serial as pipe type

2012-07-26 Thread Wei Xu
Hi Wei-Ren & All, I have tried to upgrade qemu, but it looks so hard, my guest domain can't boot up with the new "qemu 1.0.1", and i'm not sure if I make a wrong usage or something else. Cos I don't know how to tell xend to use "qemu-1.0.1" to replace it's "qemu-dm", so I try to find out some othe

Re: [Qemu-devel] [PATCH 2/5] exec.c: use refcnt to protect device during dispatching

2012-07-26 Thread liu ping fan
On Wed, Jul 25, 2012 at 8:27 PM, Avi Kivity wrote: > On 07/25/2012 01:58 PM, Avi Kivity wrote: >>> while (len > 0) { >>> page = addr & TARGET_PAGE_MASK; >>> l = (page + TARGET_PAGE_SIZE) - addr; >>> if (l > len) >>> l = len; >>> + >>> +qemu_rwlo

Re: [Qemu-devel] [PATCH] vl: add -libvirt-caps option for libvirt to stop parsing help output

2012-07-26 Thread Daniel P. Berrange
On Thu, Jul 26, 2012 at 01:47:23PM +0100, Daniel P. Berrange wrote: > On Wed, Jul 25, 2012 at 02:47:57PM -0500, Anthony Liguori wrote: > > The help output is going to change dramatically for 0.13. We've spent too > > long > > waiting for a perfect solution to capabilities handling and the end los

[Qemu-devel] [PATCH v4 05/18] grackle_pci: QOM'ify Grackle PCI host bridge

2012-07-26 Thread Andreas Färber
Introduce type constant. Introduce cast macro to drop dummy busdev field used with FROM_SYSBUS() that would've broken SYS_BUS_DEVICE(). Avoid accessing parent fields directly. Drop no-op reset function. Signed-off-by: Andreas Färber --- hw/grackle_pci.c | 57 ++

[Qemu-devel] [PATCH v4 08/18] ppce500_pci: QOM'ify e500 PCI host bridge

2012-07-26 Thread Andreas Färber
Introduce type constant and cast macro. Avoid accessing parent fields directly. Signed-off-by: Andreas Färber --- hw/ppce500_pci.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c index 99748b3..e4f065a 100644 --- a/hw/p

Re: [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-07-26 Thread Eric Blake
On 07/25/2012 09:21 PM, Corey Bryant wrote: > > > On 07/25/2012 03:25 PM, Eric Blake wrote: >> On 07/25/2012 02:22 AM, Kevin Wolf wrote: > Hm, not a nice interface where qemu_close() needs the filename and > (worse) could be given a wrong filename. Maybe it would be better to > mainta

Re: [Qemu-devel] [PATCH 2/5] exec.c: use refcnt to protect device during dispatching

2012-07-26 Thread Avi Kivity
On 07/26/2012 04:06 PM, liu ping fan wrote: > On Wed, Jul 25, 2012 at 8:27 PM, Avi Kivity wrote: >> On 07/25/2012 01:58 PM, Avi Kivity wrote: while (len > 0) { page = addr & TARGET_PAGE_MASK; l = (page + TARGET_PAGE_SIZE) - addr; if (l > len) >>>

[Qemu-devel] [PATCH v4 07/18] ppc4xx_pci: QOM'ify ppc4xx PCI host bridge

2012-07-26 Thread Andreas Färber
Introduce type constant and cast macro. Avoid accessing its parent field directly. Signed-off-by: Andreas Färber --- hw/ppc440_bamboo.c |3 ++- hw/ppc4xx.h|2 ++ hw/ppc4xx_pci.c| 13 - 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/ppc440_bam

Re: [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it

2012-07-26 Thread liu ping fan
On Thu, Jul 26, 2012 at 9:00 PM, Avi Kivity wrote: > On 07/26/2012 03:56 PM, liu ping fan wrote: >> On Wed, Jul 25, 2012 at 5:08 PM, Paolo Bonzini wrote: >>> Il 25/07/2012 05:31, Liu Ping Fan ha scritto: From: Liu Ping Fan rwlock: qemu_device_tree_mutex rd side: >

[Qemu-devel] [PATCH v4 03/18] bonito: QOM'ify Bonito PCI host bridge

2012-07-26 Thread Andreas Färber
Introduce type constant. Avoid accessing DeviceState or SysBusDevice indirectly through PCIHostState field. Drop global state by passing BonitoState as opaque and adding the IRQs and a pointer to PCIBonitoState to its state. Signed-off-by: Andreas Färber --- hw/bonito.c | 146 +

Re: [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it

2012-07-26 Thread Avi Kivity
On 07/26/2012 04:14 PM, liu ping fan wrote: >> >> From the description above, I don't see why it can't be a mutex. >> > Searching in the device tree (or MemoryRegion view) can be often in > parallel, especially in mmio-dispatch code path In mmio dispatch we have a pointer to the object, we don't n

Re: [Qemu-devel] [PATCH v2 5/7] qcow2: implement lazy refcounts

2012-07-26 Thread Kevin Wolf
Am 25.07.2012 14:21, schrieb Stefan Hajnoczi: > Lazy refcounts is a performance optimization for qcow2 that postpones > refcount metadata updates and instead marks the image dirty. In the > case of crash or power failure the image will be left in a dirty state > and repaired next time it is opened

Re: [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets

2012-07-26 Thread Kevin Wolf
Am 26.07.2012 15:13, schrieb Eric Blake: > On 07/25/2012 09:21 PM, Corey Bryant wrote: >> >> >> On 07/25/2012 03:25 PM, Eric Blake wrote: >>> On 07/25/2012 02:22 AM, Kevin Wolf wrote: >> Hm, not a nice interface where qemu_close() needs the filename and >> (worse) could be given a wrong fil

[Qemu-devel] [PATCH V5 4/4] hmp: show the backing file depth

2012-07-26 Thread benoit . canet
From: Benoît Canet Signed-off-by: Benoit Canet --- hmp.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hmp.c b/hmp.c index 6b72a64..25688ab 100644 --- a/hmp.c +++ b/hmp.c @@ -227,6 +227,8 @@ void hmp_info_block(Monitor *mon) if (info->value->inserted->has_backing_file) {

[Qemu-devel] [PATCH V5 3/4] qmp: Add backing-file-depth to qmp-commands.hx

2012-07-26 Thread benoit . canet
From: Benoît Canet Signed-off-by: Benoit Canet --- qmp-commands.hx |2 ++ 1 file changed, 2 insertions(+) diff --git a/qmp-commands.hx b/qmp-commands.hx index e3cf3c5..5de3adf 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -1317,6 +1317,7 @@ Each json-object contain the following:

[Qemu-devel] [PATCH V5 0/4] Show backing file depth in HMP and QMP

2012-07-26 Thread benoit . canet
From: Benoît Canet In some setups many backing files and snapshot are chained. This lead to the formation of huge trees of snapshots all depending on a common ancestor. Hence if something bad happen to this common ancestor all the snapshot of the tree will be broken. This patch add an easy way

[Qemu-devel] [PATCH V5 2/4] block: Use bdrv_get_backing_file_depth()

2012-07-26 Thread benoit . canet
From: Benoît Canet Use the dedicated counting function in qmp_query_block in order to propagate the backing file depth to HMP. Signed-off-by: Benoit Canet --- block.c |3 +++ qapi-schema.json |9 ++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/block.c

[Qemu-devel] [PATCH V5 1/4] block: create bdrv_get_backing_file_depth()

2012-07-26 Thread benoit . canet
From: Benoît Canet Create bdrv_get_backing_file_depth() in order to be able to show in QMP and HMP how many ancestors backing an image a block device have. Signed-off-by: Benoit Canet --- block.c | 13 + block.h |1 + 2 files changed, 14 insertions(+) diff --git a/block.c b/

[Qemu-devel] [PATCH v4 02/18] alpha_typhoon: QOM'ify Typhoon PCI host bridge

2012-07-26 Thread Andreas Färber
Introduce type constant and cast macro. Don't access DeviceState indirectly through parent fields. Signed-off-by: Andreas Färber --- hw/alpha_typhoon.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/alpha_typhoon.c b/hw/alpha_typhoon.c index cc63737..

Re: [Qemu-devel] [PATCH 02/27] split MRU ram list

2012-07-26 Thread Avi Kivity
On 07/25/2012 11:20 PM, Michael Roth wrote: > On Tue, Jul 24, 2012 at 08:36:27PM +0200, Juan Quintela wrote: >> From: Paolo Bonzini >> >> Outside the execution threads the normal, non-MRU-ized order of >> the RAM blocks should always be enough. So manage two separate >> lists, which will have se

Re: [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it

2012-07-26 Thread liu ping fan
On Thu, Jul 26, 2012 at 9:15 PM, Avi Kivity wrote: > On 07/26/2012 04:14 PM, liu ping fan wrote: >>> >>> From the description above, I don't see why it can't be a mutex. >>> >> Searching in the device tree (or MemoryRegion view) can be often in >> parallel, especially in mmio-dispatch code path >

[Qemu-devel] [PATCH v4 11/18] unin_pci: QOM'ify UniNorth PCI host bridges

2012-07-26 Thread Andreas Färber
Introduce type constants and cast macros. Avoid accessing parent fields directly. Signed-off-by: Andreas Färber --- hw/unin_pci.c | 133 ++--- 1 files changed, 70 insertions(+), 63 deletions(-) diff --git a/hw/unin_pci.c b/hw/unin_pci.c index

[Qemu-devel] [PATCH RFC v4 16/18] MAINTAINERS: Document e500 machine

2012-07-26 Thread Andreas Färber
Will need to be updated for the upcoming file reorganization. Signed-off-by: Andreas Färber Cc: Alexander Graf Cc: Scott Wood --- MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 282d497..1796421 100644 --- a/MAINTAINERS

[Qemu-devel] [PATCH v4 12/18] pci_host: Turn into SysBus-derived QOM type

2012-07-26 Thread Andreas Färber
From: Andreas Färber The preceding commits fixed misuses of FROM_SYSBUS() that led people to add a bogus busdev field. For qdev the field order was less relevant but for QOM the PCIHostState field (including the SysBusDevice actually initialized with a value) must be placed first within the state

Re: [Qemu-devel] [PATCH v2 7/7] qemu-iotests: add 039 qcow2 lazy refcounts test

2012-07-26 Thread Kevin Wolf
Am 25.07.2012 14:21, schrieb Stefan Hajnoczi: > This tests establishes the basic post-conditions of the qcow2 lazy > refcounts features: > > 1. If the image was closed normally, it is marked clean. > > 2. If an allocating write was performed and the image was not close > normally, then i

[Qemu-devel] [PATCH v4 00/18] pci_host: Convert to QOM

2012-07-26 Thread Andreas Färber
Hello Anthony, As requested on the KVM call, here's a resend of the series making pci_host a first-class QOM type. In order to cc all relevant parties I have appended some patches adding MAINTAINERS entries for the ppc devices touched herein. Those should only be applied with the respective propo

[Qemu-devel] [PATCH v4 04/18] dec_pci: QOM'ify DEC 21154 PCI-PCI bridge

2012-07-26 Thread Andreas Färber
Introduce type constant. Introduce cast macro and drop dummy busdev field used with FROM_SYSBUS() that would've broken SYS_BUS_DEVICE(). Avoid accessing parent fields directly. Signed-off-by: Andreas Färber --- hw/dec_pci.c | 21 +++-- hw/dec_pci.h |2 ++ 2 files changed, 1

[Qemu-devel] [PATCH v4 10/18] spapr_pci: QOM'ify sPAPR PCI host bridge

2012-07-26 Thread Andreas Färber
Introduce type constant. Introduce cast macro to drop bogus busdev field that would've broken SYS_BUS_DEVICE(). Signed-off-by: Andreas Färber Reviewed-by: Anthony Liguori [AF: Moved type_init function rename here] --- hw/spapr_pci.c | 13 +++-- hw/spapr_pci.h |6 +- 2 files ch

Re: [Qemu-devel] [PATCH V5 0/4] Show backing file depth in HMP and QMP

2012-07-26 Thread Eric Blake
On 07/26/2012 07:18 AM, benoit.ca...@gmail.com wrote: > From: Benoît Canet > > In some setups many backing files and snapshot are chained. > This lead to the formation of huge trees of snapshots all depending > on a common ancestor. > > Hence if something bad happen to this common ancestor all t

[Qemu-devel] [PATCH RFC v4 17/18] MAINTAINERS: Document Bamboo machine

2012-07-26 Thread Andreas Färber
Place it close to ppc405 due to ppc4xx code sharing. Signed-off-by: Andreas Färber Cc: Alexander Graf --- MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1796421..00fb0fa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -35

Re: [Qemu-devel] [PATCH] ide scsi: Mess with geometry only for hard disk devices

2012-07-26 Thread Kevin Wolf
Am 23.07.2012 12:03, schrieb Paolo Bonzini: > Il 23/07/2012 09:25, Markus Armbruster ha scritto: >> Ping? >> >> Markus Armbruster writes: >> >>> Legacy -drive cyls=... are now ignored completely when the drive >>> doesn't back a hard disk device. Before, they were first checked >>> against a hard

[Qemu-devel] [PATCH v4 09/18] prep_pci: QOM'ify Raven PCI host bridge

2012-07-26 Thread Andreas Färber
Introduce type constant and cast macro. Avoid accessing parent fields directly. Also add missing space and braces. Signed-off-by: Andreas Färber --- hw/prep_pci.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/hw/prep_pci.c b/hw/prep_pci.c index a8cdc2

[Qemu-devel] [PATCH v4 06/18] gt64xxx: QOM'ify GT64120 PCI host bridge

2012-07-26 Thread Andreas Färber
Introduce type constant. Introduce cast macro to drop dummy busdev field used with FROM_SYSBUS() macro that would've broken SYS_BUS_DEVICE(). Avoid accessing DeviceState indirectly through PCIHostState. Signed-off-by: Andreas Färber --- hw/gt64xxx.c | 35 --- 1

Re: [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it

2012-07-26 Thread Avi Kivity
On 07/26/2012 04:21 PM, liu ping fan wrote: > On Thu, Jul 26, 2012 at 9:15 PM, Avi Kivity wrote: >> On 07/26/2012 04:14 PM, liu ping fan wrote: From the description above, I don't see why it can't be a mutex. >>> Searching in the device tree (or MemoryRegion view) can be often in >>

Re: [Qemu-devel] [PATCH 7/7] s390: make sclp ascii console the default

2012-07-26 Thread Andreas Färber
Am 25.07.2012 08:55, schrieb Christian Borntraeger: > On 24/07/12 21:35, Blue Swirl wrote: > [...] >> Braces > [...] >> Braces, also below two times. > > a generic question. We did it that way because the other code in vl.c is like > that. > > So we should make new code follow the CodingStyle ev

  1   2   3   >