Luiz Capitulino <lcapitul...@redhat.com> writes:
> Previous commits added qapi infrastructure to automatically generate
> qerror macros and the qerror table from qapi-schema-errors.json.
>
> This commit drops the current error macros from qerror.h and the error
> table from qerror.c and use the generated ones instead.
>
> Please, note that qapi-error.c is actually _included_ by qerror.c.
> This is hacky, but the alternative is to make the table private to
> qapi-error.c and generate functions to return table entries. I think that
> doesn't pay much off.
Functions? Why can't you simply put
const QErrorStringTable qerror_table[NUMBER_OF_ERRORS];
into qapi-errors.h?
With a literal number instead of NUMBER_OF_ERRORS. If you suffer from
literal-phobia, you can also #define it instead.
