Re: [Qemu-devel] [PATCH] audio: Make PC speaker audio card available by default

2012-07-20 Thread Jan Kiszka
On 2012-07-20 02:01, malc wrote: > On Thu, 19 Jul 2012, Anthony Liguori wrote: > >> On 07/19/2012 10:57 AM, Jan Kiszka wrote: >>> Signed-off-by: Jan Kiszka >> >> Broke the build. I'm also confused about why this is necessary. > > It built fine here[1]. So was i, but... Yeah, sorry, was to quick

[Qemu-devel] [PATCH RESEND] Recognize PCID feature

2012-07-20 Thread Mao, Junjie
This patch makes Qemu recognize the PCID feature specified from configuration or command line options. Signed-off-by: Junjie Mao --- target-i386/cpu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 5521709..efc6ece 100644 --

[Qemu-devel] [PATCH] audio: Make pcspk card selectable again

2012-07-20 Thread Jan Kiszka
From: Jan Kiszka Since we moved pcspk into hwlib, CONFIG_PCSPK is no longer defined per target. Therefore, statically built soundhw array in arch_init.c stopped including this card. Work around this by re-adding this define to config-target.mak. Long-term, a dynamic creation of this soundhw list

Re: [Qemu-devel] [SeaBIOS] [PATCH 2/2] lsi53c895a boot support

2012-07-20 Thread Gerd Hoffmann
Hi, >> +/* FIXME: probably not the best idea to have this on the stack ... */ >> +u32 script[] = { > > Several places in the code DMA to the stack already (usb-ehci, > usb-uhci, ata). My concern isn't DMA'ing to the stack, but the size of the script and possible stack overruns. But ma

[Qemu-devel] [PATCH v10 00/15] QEMU OpenRISC support

2012-07-20 Thread Jia Liu
This is the OpenCores OpenRISC 1200 support for QEMU. Full implementation of the system-model and linux-user-model support. OpenRISC 1200 is a OpenCores open source CPU, its architecture manual can be found at http://opencores.org/svnget,or1k?file=/trunk/docs/openrisc_arch.pdf A OpenRISC Linux ke

[Qemu-devel] [PATCH v10 01/15] target-or32: Add target stubs and QOM cpu

2012-07-20 Thread Jia Liu
Add OpenRISC target stubs, QOM cpu and basic machine. Signed-off-by: Jia Liu --- arch_init.c |2 + arch_init.h |1 + configure| 14 +- cpu-exec.c |2 + default-configs/or32-softmmu.mak |4 +

[Qemu-devel] [PATCH v10 02/15] target-or32: Add MMU support

2012-07-20 Thread Jia Liu
Add OpenRISC MMU support. Signed-off-by: Jia Liu --- target-openrisc/cpu.h| 79 +++- target-openrisc/mmu.c| 206 +- target-openrisc/mmu_helper.c | 20 3 files changed, 303 insertions(+), 2 deletions(-) diff --git a/ta

[Qemu-devel] [PATCH v10 03/15] target-or32: Add interrupt support

2012-07-20 Thread Jia Liu
Add OpenRISC interrupt support. Signed-off-by: Jia Liu --- cpu-exec.c | 17 +++ target-openrisc/Makefile.objs |2 +- target-openrisc/cpu.h |8 - target-openrisc/helper.h | 25 target-openrisc/interrupt.c

[Qemu-devel] [PATCH v10 04/15] target-or32: Add exception support

2012-07-20 Thread Jia Liu
Add OpenRISC exception support. Signed-off-by: Jia Liu --- target-openrisc/Makefile.objs |4 ++-- target-openrisc/exception.c| 27 +++ target-openrisc/exception.h| 28 target-openrisc/exception_helper.c | 29

[Qemu-devel] [PATCH v10 07/15] target-or32: Add instruction translation

2012-07-20 Thread Jia Liu
Add OpenRISC instruction tanslation routines. Signed-off-by: Jia Liu --- target-openrisc/translate.c | 1734 +++ 1 file changed, 1734 insertions(+) diff --git a/target-openrisc/translate.c b/target-openrisc/translate.c index a2b9b4f..a17455d 100644 --- a/

[Qemu-devel] [PATCH v10 09/15] target-or32: Add timer support

2012-07-20 Thread Jia Liu
Add OpenRISC timer support. Signed-off-by: Jia Liu --- hw/openrisc/Makefile.objs |2 +- hw/openrisc_timer.c | 101 + target-openrisc/cpu.h | 22 ++ 3 files changed, 124 insertions(+), 1 deletion(-) create mode 100644 hw/openri

[Qemu-devel] [PATCH v10 10/15] target-or32: Add a IIS dummy board

2012-07-20 Thread Jia Liu
Add a IIS dummy board. Signed-off-by: Jia Liu --- hw/openrisc/Makefile.objs |2 +- hw/openrisc_sim.c | 150 + 2 files changed, 151 insertions(+), 1 deletion(-) create mode 100644 hw/openrisc_sim.c diff --git a/hw/openrisc/Makefile.objs b

[Qemu-devel] [PATCH v10 11/15] target-or32: Add system instructions

2012-07-20 Thread Jia Liu
Add OpenRISC system instructions. Signed-off-by: Jia Liu --- target-openrisc/Makefile.objs |2 +- target-openrisc/cpu.h |3 + target-openrisc/helper.h |4 + target-openrisc/sys_helper.c | 287 + target-openrisc/translate.c |

[Qemu-devel] [PATCH v10 12/15] target-or32: Add gdb stub support

2012-07-20 Thread Jia Liu
Add OpenRISC gdb stub support. Signed-off-by: Jia Liu --- gdbstub.c | 64 + 1 file changed, 64 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 08cf864..5d37dd9 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1155,6 +1155,68 @@ stat

[Qemu-devel] [PATCH v10 13/15] target-or32: Add linux syscall, signal and termbits

2012-07-20 Thread Jia Liu
Add OpenRISC linux syscall, signal and termbits. Signed-off-by: Jia Liu --- linux-user/openrisc/syscall.h | 24 ++ linux-user/openrisc/syscall_nr.h| 506 +++ linux-user/openrisc/target_signal.h | 26 ++ linux-user/openrisc/termbits.h | 294 +++

[Qemu-devel] [PATCH v10 14/15] target-or32: Add linux user support

2012-07-20 Thread Jia Liu
Add QEMU OpenRISC linux user support. Signed-off-by: Jia Liu --- configure |1 + default-configs/or32-linux-user.mak |1 + linux-user/elfload.c| 41 +++ linux-user/main.c | 100 +++ linux-user/signal.c

[Qemu-devel] [PATCH v10 05/15] target-or32: Add int instruction helpers

2012-07-20 Thread Jia Liu
Add OpenRISC int instruction helpers. Signed-off-by: Jia Liu --- target-openrisc/Makefile.objs |2 +- target-openrisc/helper.h |5 +++ target-openrisc/int_helper.c | 79 + 3 files changed, 85 insertions(+), 1 deletion(-) create mode 100644

[Qemu-devel] [PATCH v10 06/15] target-or32: Add float instruction helpers

2012-07-20 Thread Jia Liu
Add OpenRISC float instruction helpers. Signed-off-by: Jia Liu --- target-openrisc/Makefile.objs |3 +- target-openrisc/fpu_helper.c | 300 + target-openrisc/helper.h | 33 + 3 files changed, 335 insertions(+), 1 deletion(-) create mode 1

[Qemu-devel] [PATCH v10 08/15] target-or32: Add PIC support

2012-07-20 Thread Jia Liu
Add OpenRISC Programmable Interrupt Controller support. Signed-off-by: Jia Liu --- hw/openrisc/Makefile.objs |2 ++ hw/openrisc_pic.c | 60 + target-openrisc/cpu.h |3 +++ 3 files changed, 65 insertions(+) create mode 100644 hw/o

Re: [Qemu-devel] [RFC PATCH v2 03/21][SeaBIOS] acpi-dsdt: Implement functions for memory hotplug

2012-07-20 Thread Vasilis Liaskovitis
On Tue, Jul 17, 2012 at 03:23:00PM +0800, Wen Congyang wrote: > > +Method(MESC, 0) { > > +// Local5 = active memdevice bitmap > > +Store (MES, Local5) > > +// Local2 = last read byte from bitmap > > +Store (Zero, Local2) > > +// Lo

[Qemu-devel] [PATCH v2 2/3] usb attached scsi boot support

2012-07-20 Thread Gerd Hoffmann
This patch adds support for booting from UAS (usb attached scsi) devices. For now only usb 2.0 support is there. On usb 3.0 the UAS protocol uses streams, so changes will be required to make usb 3.0 devices fly once we have a xhci host controller driver. So far the driver has been tested on qemu

[Qemu-devel] [PATCH v2 3/3] lsi53c895a boot support

2012-07-20 Thread Gerd Hoffmann
This patch adds support for the lsi53c895a scsi host adapter, allowing seabios to boot from scsi disks and cdroms connected to the lsi scsi hba emulated by qemu. This driver was written by looking at the expectations of qemu's lsi emulation. I have no idea idea how close this is to work on real h

[Qemu-devel] [PATCH v2 0/3] scsi boot

2012-07-20 Thread Gerd Hoffmann
Hi, Quick review, giving me the opportunity for a quick v2 before disappearing into my summer vacation, fixing the nits pointed out by Kevin. The series also got a third commit which moves the usb mass storage defines from usb-msc.h to usb.h, so the uas code can easily reuse them. cheers, Ge

[Qemu-devel] [PATCH v2 1/3] move usb mass storage defines to usb.h

2012-07-20 Thread Gerd Hoffmann
With the arrival of usb attached scsi support they will be needed outside usb-msd.c too. Signed-off-by: Gerd Hoffmann --- src/usb-msc.h | 11 --- src/usb.h | 10 ++ 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/src/usb-msc.h b/src/usb-msc.h index 31c81b

[Qemu-devel] question about commit: "block: implement is_allocated for raw"

2012-07-20 Thread Alexandre DERUMIER
Hi, I have a question about commit http://git.qemu.org/?p=qemu.git;a=commit;h=5500316ded9db5b10072334cde1e27fb37682240 "block: implement is_allocated for raw" Does it works with virtio-blk ? Or does it discard support ? Regards, Alexandre Derumier

Re: [Qemu-devel] question about commit: "block: implement is_allocated for raw"

2012-07-20 Thread Paolo Bonzini
Il 20/07/2012 11:07, Alexandre DERUMIER ha scritto: > Hi, > > I have a question about commit > http://git.qemu.org/?p=qemu.git;a=commit;h=5500316ded9db5b10072334cde1e27fb37682240 > "block: implement is_allocated for raw" > > Does it works with virtio-blk ? Or does it discard support ? It is unr

Re: [Qemu-devel] question about commit: "block: implement is_allocated for raw"

2012-07-20 Thread Alexandre DERUMIER
Ok, that's clear. Thanks for your fast response ! Regards, Alexandre - Mail original - De: "Paolo Bonzini" À: "Alexandre DERUMIER" Cc: qemu-devel@nongnu.org Envoyé: Vendredi 20 Juillet 2012 11:09:20 Objet: Re: question about commit: "block: implement is_allocated for raw" Il 20/07/

Re: [Qemu-devel] [PATCH v3 00/18] introduce OptsVisitor, rebase -net/-netdev parsing

2012-07-20 Thread Stefan Hajnoczi
On Tue, Jul 17, 2012 at 3:17 PM, Laszlo Ersek wrote: > The first two patches clean up error propagation and enable the release of > incompletely parsed/created objects. A new test case is added as well. > > Inspired by [1], patches 3-6 add a new visitor that should simplify > defining and processi

Re: [Qemu-devel] [PATCH v4 4/5] prepare to create HPET, RTC and i8254 through composition

2012-07-20 Thread Markus Armbruster
Anthony Liguori writes: > Markus Armbruster writes: > >> Wanpeng Li writes: >> >>> [CCing ML] >>> >>> From: Anthony Liguori >>> >>> The HPET usually sits on the LPC bus (which replaces ISA in modern systems). >>> It's sometimes a dedicated chip but can certain co-exist in a Super IO chip. >

Re: [Qemu-devel] [PATCH] qemu: add .exrc

2012-07-20 Thread Stefan Hajnoczi
On Thu, Jul 19, 2012 at 4:24 PM, Michael S. Tsirkin wrote: > On Thu, Jul 19, 2012 at 04:11:21PM +0100, Peter Maydell wrote: >> On 19 July 2012 15:29, Michael S. Tsirkin wrote: >> > I've been using this to get correct indenting with vim >> > in qemu for a while, but it's a bit easier if we >> > pu

Re: [Qemu-devel] [PATCH] qemu: add .exrc

2012-07-20 Thread Peter Maydell
On 20 July 2012 11:26, Stefan Hajnoczi wrote: > From my .vimrc: > > au BufNewFile,BufRead */qemu/*.c,*/qemu/*.h,*/qemu/*.hx,*/qemu/*tool > setlocal ts=4 sw=4 et Basically I think editor preferences are a local matter which can reasonably differ between different developers, so they shouldn't be i

Re: [Qemu-devel] [PATCH] qemu: add .exrc

2012-07-20 Thread Wei-Ren Chen
> In any case, 3 settings clearly don't encompass the whole of > QEMU's coding style. The relevant bit of my .emacs tweaks about > 20 different settings... Just leave the coding style checking to checkpatch.pl, I think? Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of

[Qemu-devel] [PATCH 0/7] Remove periodic wakeup from RTC timer

2012-07-20 Thread Paolo Bonzini
The current RTC emulation has two timers firing every second, one on each edge of the UIP bit. This will prevent CPUs from staying at deep C-states. Intel's measurements from previous submissions show the C6 residency reduced by 6% when running 64 idle guests. The following patches remove the tw

[Qemu-devel] [PATCH 1/7] RTC: Remove the logic to update time format when DM bit changed

2012-07-20 Thread Paolo Bonzini
From: "Zhang, Yang Z" Changing the DM (binary/BCD) and 24/12 control bit doesn't affect the internal registers. It only indicates what format is used for those registers. Signed-off-by: Yang Zhang Signed-off-by: Paolo Bonzini --- hw/mc146818rtc.c | 10 +- 1 file changed, 1 insertion

Re: [Qemu-devel] qemu 1.1.0 slow as hell booting ?

2012-07-20 Thread Luigi Rizzo
On Thu, Jul 19, 2012 at 04:43:05PM +0200, Luigi Rizzo wrote: > hi, > while playing with various qemu versions i noticed that > qemu-devel now in FreeBSD ports (1.1.0) is slow as hell when > booting FreeBSD (take for instance the netmap image at > > http://info.iet.unipi.it/~luigi/netmap/20120608-n

Re: [Qemu-devel] [PATCH] qemu: add .exrc

2012-07-20 Thread Michael S. Tsirkin
On Fri, Jul 20, 2012 at 11:34:21AM +0100, Peter Maydell wrote: > On 20 July 2012 11:26, Stefan Hajnoczi wrote: > > From my .vimrc: > > > > au BufNewFile,BufRead */qemu/*.c,*/qemu/*.h,*/qemu/*.hx,*/qemu/*tool > > setlocal ts=4 sw=4 et > > Basically I think editor preferences are a local matter whi

Re: [Qemu-devel] qemu 1.1.0 slow as hell booting ?

2012-07-20 Thread ronnie sahlberg
Is it only very slow during boot but then becomes normal speed when the system is fully booted and kernel and userspace are all up and running normally? regards ronnie sahlberg On Fri, Jul 20, 2012 at 12:43 AM, Luigi Rizzo wrote: > hi, > while playing with various qemu versions i noticed that

[Qemu-devel] [PATCH 3/7] RTC: Update interrupt state when interrupts are masked/unmasked

2012-07-20 Thread Paolo Bonzini
From: "Zhang, Yang Z" If an interrupt flag is already set when the interrupt becomes enabled, raise an interrupt immediately, and vice versa if interrupts become disabled. Signed-off-by: Yang Zhang Signed-off-by: Paolo Bonzini --- hw/mc146818rtc.c |9 + hw/mc146818rtc_regs.h

Re: [Qemu-devel] qemu 1.1.0 slow as hell booting ?

2012-07-20 Thread Luigi Rizzo
On Fri, Jul 20, 2012 at 09:04:51PM +1000, ronnie sahlberg wrote: > Is it only very slow during boot but then becomes normal speed when > the system is fully booted and kernel and userspace are all up and > running normally? i did not have enough patience to go past the 2 minutes needed to load t

[Qemu-devel] [PATCH 7/7] RTC: Allow to migrate from old QEMU

2012-07-20 Thread Paolo Bonzini
From: "Zhang, Yang Z" The new logic is compatible with old, and it should not block migration from old QEMU. However, the new version cannot migrate to the old one. Cc: Juan Quintela Signed-off-by: Yang Zhang Signed-off-by: Paolo Bonzini --- hw/mc146818rtc.c | 42 +

[Qemu-devel] [PATCH 4/7] RTC: Update the RTC clock only when reading it

2012-07-20 Thread Paolo Bonzini
From: "Zhang, Yang Z" Calculate guest RTC based on the time of the last update, instead of using timers. The formula is (base_rtc + guest_time_now - guest_time_last_update + offset) Base_rtc is the RTC value when the RTC was last updated. Guest_time_now is the guest time when the access ha

[Qemu-devel] [PATCH 5/7] RTC: Add divider reset support

2012-07-20 Thread Paolo Bonzini
From: "Zhang, Yang Z" The first update cycle begins one-half seconds after divider reset is removed. This feature is useful for testing. Signed-off-by: Yang Zhang Signed-off-by: Paolo Bonzini --- hw/mc146818rtc.c | 50 +- 1 file changed, 41 i

[Qemu-devel] [PATCH 2/7] RTC: Rename rtc_timer_update

2012-07-20 Thread Paolo Bonzini
From: "Zhang, Yang Z" Signed-off-by: Yang Zhang Signed-off-by: Paolo Bonzini --- hw/mc146818rtc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index 1ccfb50..6a7dcb8 100644 --- a/hw/mc146818rtc.c +++ b/hw/mc146818rtc.c @@

[Qemu-devel] [PATCH 6/7] RTC: Do not fire timer periodically to catch next alarm

2012-07-20 Thread Paolo Bonzini
This patch limits further the usage of a periodic timer. It computes the time of the next alarm, and uses it to skip all intermediate occurrences of the timer. Cc: Yang Zhang Signed-off-by: Paolo Bonzini --- The patch from Yang had some problems, for example if the alarm was 9:X

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-20 Thread Daniel P. Berrange
On Thu, Jul 19, 2012 at 01:37:11PM +0200, Paolo Bonzini wrote: > Il 18/07/2012 17:35, Daniel P. Berrange ha scritto: > > Oh, and will this library depend on glib > > Yes, in all likelihood. > > , and will it have the > > abort-on-oom behaviour QEMU has ? From a libvirt POV, we won't > > use any l

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-20 Thread Paolo Bonzini
Il 20/07/2012 13:38, Daniel P. Berrange ha scritto: > There's two aspects to it. First we forbid use of malloc/free/realloc > in favour of an alternative set of APIs designed such that we can get > compile time errors when people don't check the result for NULL. > > > http://berrange.com/posts/

[Qemu-devel] [PATCH 08/16] net: Remove VLANState

2012-07-20 Thread Stefan Hajnoczi
VLANState is no longer used and can be removed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/dp8393x.c |1 - hw/exynos4_boards.c |2 +- hw/highbank.c|2 +- hw/integratorcp.c|2 +- hw/kzm.c |2 +- hw/mcf5208.c |

[Qemu-devel] [PATCH 14/16] net: cleanup deliver/deliver_iov func pointers

2012-07-20 Thread Stefan Hajnoczi
From: Zhi Yong Wu Reviewed-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi --- net.c | 35 +++ net.h | 11 +++ net/queue.c | 13 - net/queue.h | 17 ++--- 4 files changed, 28 inse

[Qemu-devel] [PATCH 09/16] net: Rename non_vlan_clients to net_clients

2012-07-20 Thread Stefan Hajnoczi
There is no longer a distinction between vlan clients and non-vlan clients in the net core. The net core only knows about point-to-point clients which are connected to a peer. It's time to rename the global list of net clients since it no longer refers to vlans at all. Signed-off-by: Stefan Hajn

[Qemu-devel] [PATCH 03/16] net: Look up 'vlan' net clients using hubs

2012-07-20 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 28 +--- net/hub.c | 24 net/hub.h |2 ++ net/slirp.c |7 +-- 4 files changed, 32 insertions(+), 29 deletions(-) diff --git a/net.c b/net.c index f275

[Qemu-devel] [PATCH 04/16] hub: Check that hubs are configured correctly

2012-07-20 Thread Stefan Hajnoczi
Checks can be performed to make sure that hubs have at least one NIC and one host device, warning the user if this is not the case. Configurations which do not meet this rule tend to be broken but just emit a warning. This patch preserves compatibility with the checks performed by net core on vlan

Re: [Qemu-devel] [PATCH 1/2] configure: Replace bash code by standard shell code

2012-07-20 Thread Andreas Färber
Am 17.07.2012 21:19, schrieb Peter Maydell: > On 17 July 2012 20:07, Stefan Weil wrote: >> If the user overrides CFLAGS, I expect that he/she will notice >> that compilation fails and hopefully find the cause (only >> expert users should override CFLAGS). Overriding -march=i486 >> might be useful

Re: [Qemu-devel] [PATCH 1/2] configure: Replace bash code by standard shell code

2012-07-20 Thread Peter Maydell
On 20 July 2012 13:28, Andreas Färber wrote: > Am 17.07.2012 21:19, schrieb Peter Maydell: >> On 17 July 2012 20:07, Stefan Weil wrote: >>> If the user overrides CFLAGS, I expect that he/she will notice >>> that compilation fails and hopefully find the cause (only >>> expert users should override

[Qemu-devel] [PATCH 11/16] net: Rename vc local variables to nc

2012-07-20 Thread Stefan Hajnoczi
Now that VLANClientState has been renamed to NetClientState all 'vc' local variables should be 'nc'. Much of the code already used 'nc' but there are places where 'vc' needs to be renamed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/ne2000.h |4 +- hw/vhost_net.c

[Qemu-devel] [PATCH 07/16] net: Remove vlan code from net.c

2012-07-20 Thread Stefan Hajnoczi
The vlan implementation in net.c has been replaced by hubs so we can remove the code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/xen_nic.c |1 - net.c| 108 -- net.h|1 - 3 files changed, 110

[Qemu-devel] [PATCH 16/16] hub: add the support for hub own flow control

2012-07-20 Thread Stefan Hajnoczi
From: Zhi Yong Wu Only when all other hub port's *peer* .can_receive() all return 1, the source hub port .can_receive() return 1. Reviewed-off-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi --- net/hub.c | 27 --- 1 file changed, 24 inse

[Qemu-devel] [PATCH 02/16] net: Use hubs for the vlan feature

2012-07-20 Thread Stefan Hajnoczi
Stop using the special-case vlan code in net.c. Instead use the hub net client to implement the vlan feature. The next patch will remove vlan code from net.c completely. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 38 +-

Re: [Qemu-devel] [SeaBIOS] [PATCH 2/2] lsi53c895a boot support

2012-07-20 Thread Kevin O'Connor
On Fri, Jul 20, 2012 at 09:33:05AM +0200, Gerd Hoffmann wrote: > Hi, > > >> +/* FIXME: probably not the best idea to have this on the stack ... */ > >> +u32 script[] = { > > > > Several places in the code DMA to the stack already (usb-ehci, > > usb-uhci, ata). > > My concern isn't DMA'

[Qemu-devel] [PATCH 15/16] net: determine if packets can be sent before net queue deliver packets

2012-07-20 Thread Stefan Hajnoczi
From: Zhi Yong Wu Reviewed-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi --- net/queue.c |9 + net/slirp.c |7 --- slirp/if.c |5 - slirp/libslirp.h |1 - 4 files changed, 5 insertions(+), 17 deletions(-) diff --

[Qemu-devel] [PATCH 01/16] net: Add a hub net client

2012-07-20 Thread Stefan Hajnoczi
The vlan feature can be implemented in terms of hubs. By introducing a hub net client it becomes possible to remove the special case vlan code from net.c and push the vlan feature out of generic networking code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c |

[Qemu-devel] [PATCH 12/16] net: Rename qemu_del_vlan_client() to qemu_del_net_client()

2012-07-20 Thread Stefan Hajnoczi
Another step in moving the vlan feature out of net core. Users only deal with NetClientState and therefore qemu_del_vlan_client() should be named qemu_del_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/e1000.c |2 +- hw/eepro100.c|2 +-

[Qemu-devel] [PATCH 06/16] net: Convert qdev_prop_vlan to peer with hub

2012-07-20 Thread Stefan Hajnoczi
From: Zhi Yong Wu Instead of using VLANState use net/hub.h to support the vlan qdev property. The vlan qdev property becomes an alias for the peer qdev property but is represented as a VLAN ID number. When a VLAN ID is selected the device will really peer with a hub port. Signed-off-by: Zhi Yo

[Qemu-devel] [PATCH 13/16] net: Make "info network" output more readable info

2012-07-20 Thread Stefan Hajnoczi
From: Zhi Yong Wu Reviewed-by: Jan Kiszka Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi --- net.c | 14 +- net.h |1 + net/hub.c | 23 +-- net/hub.h |1 + 4 files changed, 32 insertions(+), 7 deletions(-) diff --git a/net.c b

[Qemu-devel] [PATCH 00/16] net: Move legacy QEMU VLAN code into net/hub.c

2012-07-20 Thread Stefan Hajnoczi
[These patches are based on Laszlo Ersek's net OptsVisitor series.] The QEMU net subsystem has the concept of separate network segments, called "VLANs". Each VLAN is a broadcast domain so all net clients connected to the same VLAN can communicate with each other. Today this feature is mostly use

[Qemu-devel] [PATCH 05/16] net: Drop vlan argument to qemu_new_net_client()

2012-07-20 Thread Stefan Hajnoczi
Since hubs are now used to implement the 'vlan' feature and the vlan argument is always NULL, remove the argument entirely and update all net clients that use qemu_new_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 27 ++-

Re: [Qemu-devel] [PATCH 1/2] hw/exynos4210_rtc.c: Fix calculating for value of year

2012-07-20 Thread Peter Maydell
On 11 July 2012 11:03, Oleg Ogurtsov wrote: > > Signed-off-by: Oleg Ogurtsov Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH 2/2] hw/exynos4210_rtc.c: remove unnecessary code

2012-07-20 Thread Peter Maydell
On 11 July 2012 11:03, Oleg Ogurtsov wrote: > > Signed-off-by: Oleg Ogurtsov Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [PATCH 0/4] Simpletrace v2: Code cleanup, refactoring.

2012-07-20 Thread Harsh Prateek Bora
Minor code cleanups, refactoring for Simpletrace v2. Harsh Prateek Bora (4): trace/simple.c: rename TraceRecordHeader to TraceLogHeader as appropriate. trace/simple.c: remove unnecessary typecasting trace/simple.c: remove obsolete code trace/simple.c: minor code refactoring trace/sim

[Qemu-devel] [PATCH 4/4] trace/simple.c: minor code refactoring

2012-07-20 Thread Harsh Prateek Bora
Signed-off-by: Harsh Prateek Bora --- trace/simple.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/trace/simple.c b/trace/simple.c index 4fed07f..8e175ec 100644 --- a/trace/simple.c +++ b/trace/simple.c @@ -269,12 +269,11 @@ static unsigned int write_to_buffer(u

[Qemu-devel] [PATCH 3/4] trace/simple.c: remove obsolete code

2012-07-20 Thread Harsh Prateek Bora
Signed-off-by: Harsh Prateek Bora --- trace/simple.c |2 -- trace/simple.h |1 - 2 files changed, 3 deletions(-) diff --git a/trace/simple.c b/trace/simple.c index a0e0f05..4fed07f 100644 --- a/trace/simple.c +++ b/trace/simple.c @@ -231,8 +231,6 @@ int trace_record_start(TraceBufferRec

[Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work

2012-07-20 Thread Stefan Hajnoczi
The socket backend does not support the listen= option with -netdev. The problem is how the socket NetClientState lifecycle is implemented: the socket backend waits for an incoming client connection before creating a NetClientState. The guest -device wants a peer= on startup, so QEMU fails with a

[Qemu-devel] [PATCH 1/2] net: fix the coding style

2012-07-20 Thread Stefan Hajnoczi
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi --- net/socket.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/socket.c b/net/socket.c index 312730a..4a093cb 100644 --- a/net/socket.c +++ b/net/socket.c @@ -301,7 +301,9 @@ static NetS

[Qemu-devel] [PATCH 2/2] net: add the support for -netdev socket, listen

2012-07-20 Thread Stefan Hajnoczi
From: Zhi Yong Wu The -net socket,listen option does not work with the newer -netdev syntax: http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01508.html This patch makes it work now. For the case where one vlan has multiple listenning sockets, the patch will also provide the support. S

Re: [Qemu-devel] [PATCH V4] exynos4210: add Exynos4210 i2c implementation

2012-07-20 Thread Peter Maydell
On 18 July 2012 19:18, Igor Mitsyanko wrote: > Create 9 exynos4210 i2c interfaces. > > Signed-off-by: Igor Mitsyanko > Reviewed-by: Andreas Färber Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [PATCH 1/4] trace/simple.c: rename TraceRecordHeader to TraceLogHeader as appropriate.

2012-07-20 Thread Harsh Prateek Bora
Signed-off-by: Harsh Prateek Bora --- trace/simple.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/trace/simple.c b/trace/simple.c index b700ea3..5d92939 100644 --- a/trace/simple.c +++ b/trace/simple.c @@ -70,7 +70,7 @@ typedef struct { uint64_t header_event_id

[Qemu-devel] [PATCH 2/4] trace/simple.c: remove unnecessary typecasting

2012-07-20 Thread Harsh Prateek Bora
Signed-off-by: Harsh Prateek Bora --- trace/simple.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/trace/simple.c b/trace/simple.c index 5d92939..a0e0f05 100644 --- a/trace/simple.c +++ b/trace/simple.c @@ -235,9 +235,9 @@ int trace_record_start(TraceBufferRecord *

Re: [Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-20 Thread jagan
I think I understand the situation, like when I called pflash_cfi01_register, it verifies BlockDriverState is < 0. Was my understanding correct? If ie so. I think I need to change drive_get(IF_PFLASH, 0, 0) to drive_get_next(IF_PFLASH) on second flash access by keeping drive_get(IF_PFLASH, 0, 0

Re: [Qemu-devel] [SeaBIOS] [PATCH 2/2] lsi53c895a boot support

2012-07-20 Thread Gerd Hoffmann
On 07/20/12 14:47, Kevin O'Connor wrote: > On Fri, Jul 20, 2012 at 09:33:05AM +0200, Gerd Hoffmann wrote: >> My concern isn't DMA'ing to the stack, but the size of the script and >> possible stack overruns. But maybe it is a moot point with the stack >> switching added to seabios recently. > > Di

[Qemu-devel] [PATCH] MAINTAINERS: Replace net maintainer Mark McLoughlin with Stefan Hajnoczi

2012-07-20 Thread Stefan Hajnoczi
The net subsystem has lacked an active maintainer since 2009. I have built and tested a net-next tree to get the ball rolling again. Signed-off-by: Stefan Hajnoczi --- MAINTAINERS |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 30ed56d..2

Re: [Qemu-devel] [PATCH 3/4] ARM: exynos4210_pmu: Introduced exynos4210_pmu_get_register_index

2012-07-20 Thread Peter Maydell
On 6 July 2012 16:49, Maksim Kozlov wrote: > This patch just introduces exynos4210_pmu_get_register_index function > to get index of the register's value in the array on its offset. And > functions _read and _write were modified accordingly. > > Signed-off-by: Maksim Kozlov Reviewed-by: Peter Ma

Re: [Qemu-devel] [PATCH 1/4] ARM: exynos4210_pmu: just formatting changes

2012-07-20 Thread Peter Maydell
On 6 July 2012 16:49, Maksim Kozlov wrote: > Mainly to make 'exynos4210_pmu_regs' array more readable. > > static const Exynos4210PmuReg exynos4210_pmu_regs[] = { > -{"OM_STAT", OM_STAT, 0x}, > +{ "OM_STAT", OM_STAT, > 0x }, If

Re: [Qemu-devel] [PATCH 2/6] s390: sclp base support

2012-07-20 Thread Andreas Färber
Am 13.07.2012 12:52, schrieb Christian Borntraeger: > From: Heinz Graalfs > > This adds a more generic infrastructure for handling Service-Call > requests on s390. Currently we only support a small subset of Read > SCP Info directly in target-s390x. This patch provides the base > infrastructure f

Re: [Qemu-devel] [PATCH 4/4] xen: Always set the vram dirty during migration.

2012-07-20 Thread Anthony PERARD
On 17/07/12 19:30, Stefano Stabellini wrote: On Tue, 17 Jul 2012, Stefano Stabellini wrote: On Tue, 17 Jul 2012, Anthony PERARD wrote: Because the call to track the dirty bit in the video ram during migration won't work (it returns -1), we set dirtybit on the all video ram. Signed-off-by: Anth

Re: [Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-20 Thread jagan
And one more point is when I tried drive_get(IF_PFLASH, 0, 0) and then drive_get_next(IF_PFLASH) individually on second flash. I didn't observe any issue on bdrv_attach_dev_nofail, as it seems to be failed on second case if we re-access the flash. Code snippet: -- + bdrv_attach_d

Re: [Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-20 Thread Igor Mitsyanko
On 07/20/2012 05:30 PM, jagan wrote: I think I understand the situation, like when I called pflash_cfi01_register, it verifies BlockDriverState is < 0. Was my understanding correct? If ie so. I think I need to change drive_get(IF_PFLASH, 0, 0) to drive_get_next(IF_PFLASH) on second flash acce

Re: [Qemu-devel] [PATCH 2/4] ARM: exynos4210_pmu: changes in PRINT_DEBUG macro set.

2012-07-20 Thread Peter Maydell
On 6 July 2012 16:49, Maksim Kozlov wrote: > Subject: ARM: exynos4210_pmu: changes in PRINT_DEBUG macro set. This is a rather vague summary. > It make possible to set DEBUG_PMU and DEBUG_PMU_EXTEND "This makes it possible" > independently of each other The patch doesn't actually do this, tho

Re: [Qemu-devel] [PATCH v2 4/4] ARM: exynos4210_pmu: Add software reset support

2012-07-20 Thread Peter Maydell
On 12 July 2012 17:54, Maksim Kozlov wrote: > Signed-off-by: Maksim Kozlov > --- > hw/exynos4210_pmu.c | 40 +--- > 1 files changed, 33 insertions(+), 7 deletions(-) > > diff --git a/hw/exynos4210_pmu.c b/hw/exynos4210_pmu.c > index 7f09c79..96588d9 100644 >

[Qemu-devel] [PATCH V2 5/5] xen: Always set the vram dirty during migration.

2012-07-20 Thread Anthony PERARD
Because the call to track the dirty bit in the video ram during migration won't work (it returns -1), we set dirtybit on the all video ram. Signed-off-by: Anthony PERARD --- xen-all.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index 54e54cb

Re: [Qemu-devel] [PATCH 1/2] vexpress: Add NOR0 Flash support

2012-07-20 Thread Peter Maydell
On 18 July 2012 20:03, <402ja...@gmail.com> wrote: > From: Jagan <402ja...@gmail.com> > > This patch adds support for NOR0 flash (Bank #1) on > vexpress-a9 platform. It is 64MB CFI01 compliant flash. > > Tested on stable u-boot version through Linux. You might want to look at a previous attempt a

[Qemu-devel] [PATCH V2 3/5] exec: Introduce helper to set dirty flags.

2012-07-20 Thread Anthony PERARD
This new helper/hook is used in the next patch to add an extra call in a single place. Signed-off-by: Anthony PERARD --- exec.c | 42 ++ 1 files changed, 14 insertions(+), 28 deletions(-) diff --git a/exec.c b/exec.c index feb4795..b24a03a 100644 --- a/

Re: [Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-20 Thread jagan
Thanks for your info, In fact I was thinking about to use drive_get(IF_PFLASH, 0, 0) for first and drive_get(IF_PFLASH, 0, 1) also. But the point I was still uncover is even I was using drive_get(IF_PFLASH, 0, 0) on both the flashes, If I tested through u-boot I was able to detect two flashes

[Qemu-devel] [PATCH V2 4/5] exec, memory: Call to xen_modified_memory.

2012-07-20 Thread Anthony PERARD
This patch add some calls to xen_modified_memory to notify Xen about dirtybits during migration. Signed-off-by: Anthony PERARD --- exec.c |1 + memory.c |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index b24a03a..84f9557 100644 --- a/exec.c +++

[Qemu-devel] [PATCH V2 1/5] QMP, Introduce xen-set-global-dirty-log command.

2012-07-20 Thread Anthony PERARD
This command is used during a migration of a guest under Xen. It calls memory_global_dirty_log_start or memory_global_dirty_log_stop according to the argument pass to the command. Signed-off-by: Anthony PERARD --- qapi-schema.json | 13 + qmp-commands.hx | 24 +++

[Qemu-devel] [PATCH 04/10] hw/arm_boot.c: Check for RAM sizes exceeding ATAGS capacity

2012-07-20 Thread Peter Maydell
The legacy ATAGS format for passing information to the kernel only allows RAM sizes which fit in 32 bits; enforce this restriction rather than silently doing something weird. Signed-off-by: Peter Maydell Reviewed-by: Peter A. G. Crosthwaite --- hw/arm_boot.c |6 ++ 1 files changed, 6 in

[Qemu-devel] [PATCH 03/10] hw/arm_boot.c: Consistently use ram_size from arm_boot_info struct

2012-07-20 Thread Peter Maydell
Clean up the mix of getting the RAM size from the global ram_size and from the ram_size field in the arm_boot_info structure, so that we always use the structure field. Signed-off-by: Peter Maydell Reviewed-by: Peter A. G. Crosthwaite --- hw/arm_boot.c |5 +++-- 1 files changed, 3 insertion

[Qemu-devel] [PATCH 01/10] hw/pl011.c: Avoid crash on read when no chr backend present

2012-07-20 Thread Peter Maydell
Add a missing guard that meant we would segfault if the guest read UARTDR on a PL011 serial device which had no chr backend connected. (This didn't happen for Linux guests because Linux reads the flags register and doesn't try to read the UART if it's empty.) Reported-by: Christian Müller Signed-

[Qemu-devel] [PATCH 05/10] device_tree: Add support for reading device tree properties

2012-07-20 Thread Peter Maydell
Add support for reading device tree properties (both generic and single-cell ones) to QEMU's convenience wrapper layer. Signed-off-by: Peter Maydell Reviewed-by: Peter A. G. Crosthwaite --- device_tree.c | 30 ++ device_tree.h |4 2 files changed, 34 inser

Re: [Qemu-devel] [PATCH 1/2] vexpress: Add NOR0 Flash support

2012-07-20 Thread jagan
Was flash support on express is already there, I haven't seen this on mainline (master) that is the reason I worked this. Should I send the patches again with changing full name at Signed-off-by Regards, Jagan. On Fri, Jul 20, 2012 at 8:11 PM, Peter Maydell wrote: > On 18 July 2012 20:03, <40

[Qemu-devel] [PATCH 09/10] hw/exynos4210_rtc.c: remove unnecessary code

2012-07-20 Thread Peter Maydell
From: Oleg Ogurtsov Signed-off-by: Oleg Ogurtsov Signed-off-by: Peter Maydell --- hw/exynos4210_rtc.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/exynos4210_rtc.c b/hw/exynos4210_rtc.c index b42586e..42a4ddc 100644 --- a/hw/exynos4210_rtc.c +++ b/hw/exynos42

[Qemu-devel] [PATCH 10/10] exynos4210: add Exynos4210 i2c implementation

2012-07-20 Thread Peter Maydell
From: Mitsyanko Igor Create 9 exynos4210 i2c interfaces. Signed-off-by: Igor Mitsyanko Reviewed-by: Andreas Färber Signed-off-by: Peter Maydell --- hw/arm/Makefile.objs |2 +- hw/exynos4210.c | 27 hw/exynos4210.h |3 + hw/exynos4210_i2c.c | 334 +++

  1   2   >