On 6 July 2012 16:49, Maksim Kozlov <m.koz...@samsung.com> wrote: > Subject: ARM: exynos4210_pmu: changes in PRINT_DEBUG macro set.
This is a rather vague summary. > It make possible to set DEBUG_PMU and DEBUG_PMU_EXTEND "This makes it possible" > independently of each other The patch doesn't actually do this, though -- if you set DEBUG_PMU_EXTEND you always get DEBUG_PMU's effects even if DEBUG_PMU isn't set. Plus you have two versions of the "do nothing" version of PRINT_DEBUG_EXTEND, which isn't very pretty. The patch also introduces the new PRINT_ERROR without mentioning it in the commit message. > +#if DEBUG_PMU || DEBUG_PMU_EXTEND > + > + #define PRINT_DEBUG(fmt, args...) \ Indenting preprocessor defines with space before the "#" rather than after definitely puts you in the minority: $ git grep '^#\s\+define' | wc -l 862 $ git grep '^\s\+#define' | wc -l 126 -- PMM
