On 27 June 2012 05:38, Peter Crosthwaite
wrote:
> Ping!
>
> Whats the action item here? Put out an RFC about unifying bootloaders
> or some such?
Something like that -- identify what all the architectures currently
do with these command line arguments and propose something to bring
the outliers i
On Tue, Jun 26, 2012 at 8:34 PM, Marcelo Tosatti wrote:
> On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote:
> net.txt
>
>
>
> iothread flow
> =
>
> 1) Skip-work-if-device-locked
>
> select(tap fd ready)
> tap_send
> if (trylock(TAPState->NetClientState->dev))
>
The action is the same as -onpanic parameter.
Signed-off-by: Wen Congyang
---
qemu-config.c |4
qemu-options.hx |4 +++-
vl.c|7 +++
3 files changed, 14 insertions(+), 1 deletions(-)
diff --git a/qemu-config.c b/qemu-config.c
index 5c3296b..805e7c4 100644
---
On Wed, Jun 27, 2012 at 8:39 AM, Stefan Hajnoczi wrote:
> On Tue, Jun 26, 2012 at 8:34 PM, Marcelo Tosatti wrote:
>> On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote:
>> net.txt
>>
>>
>>
>> iothread flow
>> =
>>
>> 1) Skip-work-if-device-locked
>>
>> select(tap fd r
On Wed, Jun 27, 2012 at 4:05 AM, Peter Crosthwaite
wrote:
> I still think this thread points out a major flaw in block+coroutines,
> regardless of the fact im using it from a machine model. This bug is
> going to happen in any coroutine code that touches the block layer
> (E.G. what happens if the
On 06/26/2012 10:34 PM, Marcelo Tosatti wrote:
>
> 1. read_lock(memmap_lock)
> 2. MemoryRegionSection mrs = lookup(addr)
> 3. qom_ref(mrs.mr->dev)
> 4. read_unlock(memmap_lock)
>
> 5. mutex_lock(dev->lock)
> 6. dispatch(&mrs, addr, data, size)
> 7. mutex_unlock(dev->lock)
>
> 8. qom_unre
On 27 June 2012 08:48, Stefan Hajnoczi wrote:
> I'd like to see your code though because I still don't understand why
> it relies on the exact yield behavior. Have you pushed it to a public
> git repo?
I haven't seen Peter's code either, but his complaint makes sense
to me -- the whole point of
Before:
$ qemu-system-x86_64 -display none -drive if=ide
qemu-system-x86_64: Device needs media, but drive is empty
qemu-system-x86_64: Initialization of device ide-hd failed
[Exit 1 ]
After:
$ qemu-system-x86_64 -display none -drive if=ide
qemu-system-x86_64: Device need
On Wed, Jun 27, 2012 at 8:59 AM, Peter Maydell wrote:
> On 27 June 2012 08:48, Stefan Hajnoczi wrote:
>> I'd like to see your code though because I still don't understand why
>> it relies on the exact yield behavior. Have you pushed it to a public
>> git repo?
>
> I haven't seen Peter's code eit
Makes "make check" hang:
QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 gtester -k --verbose
-m=quick tests/crash-test tests/rtc-test
TEST: tests/crash-test... (pid=972)
qemu-system-x86_64: Device needs media, but drive is empty
[Nothing happens, wait a while, then hit ^C]
ma
Maybe I'm doing something wrong. But for me, "make check" hangs when
a test cases manages to crash QEMU. I include a stupid test case that
does just that.
Markus Armbruster (1):
Stupid test case to demonstrate flawed crash handling
tests/Makefile |2 ++
tests/crash-test.c | 18
On Tue, Jun 26, 2012 at 5:48 PM, Mike Lovell wrote:
> On 06/26/2012 02:29 AM, Stefan Hajnoczi wrote:
>>
>> On Mon, Jun 25, 2012 at 5:32 PM, Mike Lovell wrote:
>>>
>>>
>>> Oh. I forgot another reason why I decided to do this over using VDE. I'll
>>> do
>>> this one with an example. Say you have 3
Stefan Hajnoczi writes:
> On Wed, Jun 27, 2012 at 8:59 AM, Peter Maydell
> wrote:
>> On 27 June 2012 08:48, Stefan Hajnoczi wrote:
>>> I'd like to see your code though because I still don't understand why
>>> it relies on the exact yield behavior. Have you pushed it to a public
>>> git repo?
Am 27.06.2012 00:28, schrieb Corey Bryant:
>
>
> On 06/26/2012 04:50 PM, Luiz Capitulino wrote:
>> On Tue, 26 Jun 2012 13:45:52 +0200
>> Kevin Wolf wrote:
>>
>>> Am 26.06.2012 11:10, schrieb Daniel P. Berrange:
I was thinking about some of the sources complexity when using
FD passing f
Am 26.06.2012 20:40, schrieb Corey Bryant:
>>> Here is a quick proof of concept (ie untested) patch to demonstrate
>>> what I mean. It relies on Cory's patch which converts everything
>>> to use qemu_open. It is also still valuable to make the change
>>> to qemu_open() to support "/dev/fd/N" for pa
Am 22.06.2012 12:59, schrieb Peter Crosthwaite:
> On Fri, Jun 22, 2012 at 6:53 PM, Kevin Wolf wrote:
>> Am 22.06.2012 10:20, schrieb Peter Crosthwaite:
>>> [...] I thought that was the point of coroutines vs
>>> threads? coroutines you control yield behaviour explicitly whearas
>>> thread you cant
On 27 June 2012 10:10, Andreas Färber wrote:
> Maybe I'm misunderstanding the discussion, but there's three coroutine
> implementations, including one based on GThread. So in that case any
> coroutine can be preempted anywhere and there are no such guarantees as
> discussed here, are there?
No, b
Am 27.06.2012 00:54, schrieb Eric Blake:
>> It seems like libvirt would be in a better position to understand when a
>> file is no longer in use, and then it can call close_fd. No? Of course
>> the the only fd that needs to be closed is the originally passed fd. The
>> dup'd fd's are closed by QE
At 06/27/2012 04:27 AM, Luiz Capitulino Wrote:
> On Wed, 20 Jun 2012 22:58:20 +0530
> Rabin Vincent wrote:
>
>> Make dump-guest-memory not create read-only files, so that it can
>> overwrite a file created by a previous invocation without having it to
>> be removed externally.
>
> I think we nee
On Wed, Jun 27, 2012 at 11:16:32AM +0200, Kevin Wolf wrote:
> Am 27.06.2012 00:54, schrieb Eric Blake:
> >> It seems like libvirt would be in a better position to understand when a
> >> file is no longer in use, and then it can call close_fd. No? Of course
> >> the the only fd that needs to be cl
On Wed, Jun 27, 2012 at 6:33 PM, Markus Armbruster wrote:
> Stefan Hajnoczi writes:
>
>> On Wed, Jun 27, 2012 at 8:59 AM, Peter Maydell
>> wrote:
>>> On 27 June 2012 08:48, Stefan Hajnoczi wrote:
I'd like to see your code though because I still don't understand why
it relies on the e
Hello Paolo,
We backported most of the block migration fixes from upstream to the
RHEL6 qemu-kvm package ourselves and are now unable to reproduce the
disk corruption problem anymore. So I guess the issues are (mostly)
fixed upstream.
You can close this bug, but I would still appreciate it if you
Am 27.06.2012 11:20, schrieb Daniel P. Berrange:
> On Wed, Jun 27, 2012 at 11:16:32AM +0200, Kevin Wolf wrote:
>> The really bad case that nobody thought of is that, when block-commit
>> has finished, we need to switch back to read-only. This is an event that
>> is not triggered by a certain monito
This is the OpenCores OpenRISC 1200 support for QEMU.
Full implementation of the system-model and linux-user-model support.
OpenRISC 1200 is a OpenCores open source CPU,
its architecture manual can be found at
http://opencores.org/svnget,or1k?file=/trunk/docs/openrisc_arch.pdf
A OpenRISC Linux ke
Add OpenRISC target stubs and cpu support.
Signed-off-by: Jia Liu
---
arch_init.c |2 +
arch_init.h |1 +
configure| 14 +-
cpu-exec.c |2 +
default-configs/or32-softmmu.mak |4 +
elf.h
Add OpenRISC MMU support.
Signed-off-by: Jia Liu
---
target-openrisc/cpu.h| 75 +++-
target-openrisc/mmu.c| 199 +-
target-openrisc/mmu_helper.c | 20 +
3 files changed, 292 insertions(+), 2 deletions(-)
diff --git a/t
Add OpenRISC machine.
Signed-off-by: Jia Liu
---
target-openrisc/cpu.h | 67 -
target-openrisc/machine.c | 22 ++-
2 files changed, 87 insertions(+), 2 deletions(-)
diff --git a/target-openrisc/cpu.h b/target-openrisc/cpu.h
index 0
Add OpenRISC exception support.
Signed-off-by: Jia Liu
---
target-openrisc/Makefile.objs |4 ++--
target-openrisc/excp.c| 27 +++
target-openrisc/excp.h| 28
target-openrisc/excp_helper.c | 27
Add a IIS dummy board.
Signed-off-by: Jia Liu
---
hw/openrisc/Makefile.objs |2 +-
hw/openrisc_sim.c | 149 +
2 files changed, 150 insertions(+), 1 deletion(-)
create mode 100644 hw/openrisc_sim.c
diff --git a/hw/openrisc/Makefile.objs b
On 27/06/12 04:22, Luiz Capitulino wrote:
On Wed, 20 Jun 2012 06:53:40 -0600
Eric Blake wrote:
On 06/19/2012 10:47 PM, Amos Kong wrote:
Convert 'sendkey' to use QAPI. do_sendkey() depends on some
variables/functions in monitor.c, so reserve qmp_sendkey()
to monitor.c
key_defs[] in monitor.c
On Wed, Jun 27, 2012 at 10:25 AM, Peter Crosthwaite
wrote:
> On Wed, Jun 27, 2012 at 6:33 PM, Markus Armbruster wrote:
>> Stefan Hajnoczi writes:
>>
>>> On Wed, Jun 27, 2012 at 8:59 AM, Peter Maydell
>>> wrote:
On 27 June 2012 08:48, Stefan Hajnoczi wrote:
> I'd like to see your code
On Tue, Jun 26, 2012 at 02:29:39PM +1000, Peter A. G. Crosthwaite wrote:
> Set some missing maintainer ships. Patch 1 is the Petalogix ML605 machine
> model (me). Patch 2 is the Xilinx EDK device suite (me + Edgar). Patch 3 is
> the device tree subsystem (me + Alex).
Applied, Thanks!
>
> Ch
Add OpenRISC float instruction helpers.
Signed-off-by: Jia Liu
---
target-openrisc/Makefile.objs |2 +-
target-openrisc/fpu_helper.c | 275 +
target-openrisc/helper.h | 33 +
3 files changed, 309 insertions(+), 1 deletion(-)
create mode 1
Add OpenRISC interrupt support.
Signed-off-by: Jia Liu
---
cpu-exec.c | 17 +
target-openrisc/Makefile.objs |2 +-
target-openrisc/cpu.h |9 ++-
target-openrisc/helper.h| 25 +++
target-openrisc/intrpt.c
Add OpenRISC system instructions.
Signed-off-by: Jia Liu
---
target-openrisc/Makefile.objs |3 +-
target-openrisc/helper.h |4 +
target-openrisc/sys_helper.c | 244 +
target-openrisc/translate.c | 10 ++
4 files changed, 260 insertions(+
Hi Andreas,
I send out this patch with vga enablement on papr, which needs usb enabled.
Is there any more suggestion about this patch?
Who else need to ack it?
Thank you very much. :)
On Mon, Jun 18, 2012 at 5:22 PM, Li Zhang wrote:
> For pseries machine, it needs to enable usb to add
> keyboar
Add OpenRISC gdb stub support.
Signed-off-by: Jia Liu
---
gdbstub.c | 64 +
1 file changed, 64 insertions(+)
diff --git a/gdbstub.c b/gdbstub.c
index 08cf864..5d37dd9 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1155,6 +1155,68 @@ stat
Add OpenRISC linux syscall, signal and termbits.
Signed-off-by: Jia Liu
---
linux-user/openrisc/syscall.h | 24 ++
linux-user/openrisc/syscall_nr.h| 506 +++
linux-user/openrisc/target_signal.h | 26 ++
linux-user/openrisc/termbits.h | 294 +++
Hi Andreas,
This patch is to enable vga which works well on our internal tree.
Would you please help review it?
Any suggestion is appreciated.
Thanks a lot. :)
On Mon, Jun 18, 2012 at 5:34 PM, Li Zhang wrote:
> Also instanciate the USB keyboard and mouse when that option is used
> (you can sti
On 27/06/12 04:21, Luiz Capitulino wrote:
On Wed, 20 Jun 2012 12:47:40 +0800
Amos Kong wrote:
Convert 'sendkey' to use QAPI. do_sendkey() depends on some
variables/functions in monitor.c, so reserve qmp_sendkey()
to monitor.c
key_defs[] in monitor.c is the mapping of key name to keycode,
Keys
Add field32() and field64() functions which extract a particular
bit field from a word and return it. Based on an idea by Jia Liu.
Suggested-by: Jia Liu
Signed-off-by: Peter Maydell
---
v1->v2: added missing brackets to field32() to bring it in to line
with field64()
(Still using 'int' r
Add OpenRISC Programmable Interrupt Controller support.
Signed-off-by: Jia Liu
---
hw/openrisc_pic.c | 48
1 file changed, 48 insertions(+)
diff --git a/hw/openrisc_pic.c b/hw/openrisc_pic.c
index 0d14bbe..76bd792 100644
--- a/hw/openrisc_pic.c
On 06/04/2012 03:28 PM, Anthony Liguori wrote:
>> Michael has some concern on this patch, so I post another patch of
>> validating
>> the rx buf instead of checking the opmode, please see
>> http://lists.gnu.org/archive/html/qemu-devel/2012-05/msg02385.html. So
>> maybe we
>> can apply that or I n
From: Isaku Yamahata
Signed-off-by: Isaku Yamahata
---
block-migration.c |8
migration.c | 13 -
migration.h |8 ++--
qemu-common.h |1 +
savevm.c | 13 +
sysemu.h |3 ++-
vmstate.h |2 +-
7 f
Change XBZRLE cache size in bytes (the size should be a power of 2).
If XBZRLE cache size is too small there will be many cache miss.
Signed-off-by: Benoit Hudzia
Signed-off-by: Petter Svard
Signed-off-by: Aidan Shribman
Signed-off-by: Orit Wasserman
---
arch_init.c |9 +
hmp
It will return 0 if the page is unmodifed.
Signed-off-by: Orit Wasserman
---
arch_init.c | 15 +--
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index ee20c33..ef7b4d6 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -184,11 +184,11 @@ static
In the outgoing migration check to see if the page is cached and
changed than send compressed page by using save_xbrle_page function.
In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is set
and decompress the page (by using load_xbrle function).
Signed-off-by: Benoit Hudzia
Signed-of
Signed-off-by: Benoit Hudzia
Signed-off-by: Petter Svard
Signed-off-by: Aidan Shribman
Signed-off-by: Orit Wasserman
---
migration.h |4 ++
savevm.c| 145 +++
2 files changed, 149 insertions(+), 0 deletions(-)
diff --git a/migra
Add OpenRISC timer support.
Signed-off-by: Jia Liu
---
hw/openrisc_timer.c | 130 +++
1 file changed, 130 insertions(+)
diff --git a/hw/openrisc_timer.c b/hw/openrisc_timer.c
index df384f6..25cde1a 100644
--- a/hw/openrisc_timer.c
+++ b/hw/openri
Add LRU page cache mechanism.
The page are accessed by their address.
Signed-off-by: Benoit Hudzia
Signed-off-by: Petter Svard
Signed-off-by: Aidan Shribman
Signed-off-by: Orit Wasserman
---
Makefile.objs|1 +
cache.c | 217 +++
Implement Unsigned Little Endian Base 128.
Signed-off-by: Orit Wasserman
---
cutils.c | 32
qemu-common.h |8
2 files changed, 40 insertions(+), 0 deletions(-)
diff --git a/cutils.c b/cutils.c
index af308cd..3f81d53 100644
--- a/cutils.c
+++
Hi,
we recently came across multiple VMs racing and stopping working. It
seems to happen when the system is at 100% cpu.
One way to reproduce this is:
qemu-kvm-1.0.1 with vnc-thread enabled
cmdline (or similar):
/usr/bin/qemu-kvm-1.0.1 -net
tap,vlan=141,script=no,downscript=no,ifname=tap15,vn
Signed-off-by: Orit Wasserman
---
arch_init.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index ef7b4d6..6703c72 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -304,6 +304,11 @@ static void sort_ram_list(void)
g_free(blocks);
}
+
Signed-off-by: Benoit Hudzia
Signed-off-by: Petter Svard
Signed-off-by: Aidan Shribman
Signed-off-by: Orit Wasserman
---
arch_init.c | 68 +-
hmp.c| 13 ++
migration.c | 38 ++
m
On Wed, Jun 27, 2012 at 1:54 PM, Jia Liu wrote:
> Add OpenRISC instruction tanslation routines.
>
> Signed-off-by: Jia Liu
[...]
> + case 0x0009:
> + switch (op1) {
> + case 0x03: /* l.div */
> + LOG_DIS("l.div r%d, r%d, r%d\n", rd, ra, rb);
> + {
> +
Add OpenRISC instruction tanslation routines.
Signed-off-by: Jia Liu
---
target-openrisc/translate.c | 1680 +++
1 file changed, 1680 insertions(+)
diff --git a/target-openrisc/translate.c b/target-openrisc/translate.c
index 1d87d76..ce99e49 100644
--- a/
Add migration capabilites that can be queried by the management.
The management can query the source QEMU and the destination QEMU in order to
verify both support some migration capability (currently only XBZRLE).
The managment can enable a capability for the next migration by using
migrate_set_par
Add OpenRISC int instruction helpers.
Signed-off-by: Jia Liu
---
target-openrisc/Makefile.objs |2 +-
target-openrisc/helper.h |5 +++
target-openrisc/int_helper.c | 85 +
3 files changed, 91 insertions(+), 1 deletion(-)
create mode 100644
Hi,
we recently came across multiple VMs racing and stopping working. It
seems to happen when the system is at 100% cpu.
One way to reproduce this is:
qemu-kvm-1.0.1 with vnc-thread enabled
cmdline (or similar):
/usr/bin/qemu-kvm-1.0.1 -net
tap,vlan=141,script=no,downscript=no,ifname=tap15,vn
Add QEMU OpenRISC linux user support.
Signed-off-by: Jia Liu
---
configure |1 +
default-configs/or32-linux-user.mak |1 +
linux-user/elfload.c| 41 +++
linux-user/main.c | 100 +++
linux-user/signal.c
Signed-off-by: Orit Wasserman
---
docs/xbzrle.txt | 142 +++
1 files changed, 142 insertions(+), 0 deletions(-)
create mode 100644 docs/xbzrle.txt
diff --git a/docs/xbzrle.txt b/docs/xbzrle.txt
new file mode 100644
index 000..d29b0a7
---
Signed-off-by: Benoit Hudzia
Signed-off-by: Petter Svard
Signed-off-by: Aidan Shribman
Signed-off-by: Orit Wasserman
---
arch_init.c | 26 ++
1 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index a9e8b74..9dafb6e 100644
--- a
Signed-off-by: Orit Wasserman
---
arch_init.c | 33 +++--
1 files changed, 27 insertions(+), 6 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 9dafb6e..ee20c33 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -44,6 +44,14 @@
#include "exec-memory.h"
#includ
On Wed, Jun 27, 2012 at 08:41:49AM +0100, Stefan Hajnoczi wrote:
> On Wed, Jun 27, 2012 at 8:39 AM, Stefan Hajnoczi wrote:
> > On Tue, Jun 26, 2012 at 8:34 PM, Marcelo Tosatti
> > wrote:
> >> On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote:
> >> net.txt
> >>
> >>
> >>
> >> io
Am 27.06.2012 12:29, schrieb Peter Maydell:
> Add field32() and field64() functions which extract a particular
> bit field from a word and return it. Based on an idea by Jia Liu.
>
> Suggested-by: Jia Liu
> Signed-off-by: Peter Maydell
> ---
> v1->v2: added missing brackets to field32() to bring
Changes from v12:
- use bool for blk and shared params
- use long when decoding buffer
- fix QMP commands
- always display migration parameters in "info migrate"
- update current_addr inside the while loop in ram_save_block
- display statistics after
On 06/27/2012 04:29 AM, Peter Maydell wrote:
> Add field32() and field64() functions which extract a particular
> bit field from a word and return it. Based on an idea by Jia Liu.
>
> +static inline uint64_t field64(uint64_t value, int start, int length)
> +{
> +assert(start >= 0 && start <=
Am 18.06.2012 11:22, schrieb Li Zhang:
> For pseries machine, it needs to enable usb to add
> keyboard or usb mouse. -usb option won't be used in
> the future, and machine options is a better way to
> enable usb.
>
> So this patch is to add usb option to machine options
> (-machine type=psereis,us
On 18.06.2012, at 11:34, Li Zhang wrote:
> Also instanciate the USB keyboard and mouse when that option is used
> (you can still use -device to create individual devices without all
> the defaults)
>
> Signed-off-by: Benjamin Herrenschmidt
> Signed-off-by: Li Zhang
> ---
> hw/spapr.c | 43 ++
From: David Gibson
This adds support for then new "reset htab" ioctl which allows qemu
to properly cleanup the MMU hash table when the guest is reset. With
the corresponding kernel support, reset of a guest now works properly.
This also paves the way for indicating a different size hash table
to
On Wed, 2012-06-27 at 22:10 +1000, Benjamin Herrenschmidt wrote:
> From: David Gibson
>
> This adds support for then new "reset htab" ioctl which allows qemu
> to properly cleanup the MMU hash table when the guest is reset. With
> the corresponding kernel support, reset of a guest now works prope
On 06/27/2012 03:59 AM, Amos Kong wrote:
>>> The interface looks like we have settled into something useful that
>>> libvirt can live with. I will leave a more thorough review of the
>>> series to those more familiar with qemu's internals. However, as long
>>> as we are fine-tuning things, I hav
Hi Jia,
On Wed, Jun 27, 2012 at 7:54 PM, Jia Liu wrote:
> Add a IIS dummy board.
>
> Signed-off-by: Jia Liu
> ---
> hw/openrisc/Makefile.objs | 2 +-
> hw/openrisc_sim.c | 149
> +
> 2 files changed, 150 insertions(+), 1 deletion(-)
> cr
On 27.06.2012, at 14:10, Benjamin Herrenschmidt wrote:
> From: David Gibson
>
> This adds support for then new "reset htab" ioctl which allows qemu
> to properly cleanup the MMU hash table when the guest is reset. With
> the corresponding kernel support, reset of a guest now works properly.
>
Hi Max,
On Wed, Jun 27, 2012 at 7:03 PM, Max Filippov wrote:
> On Wed, Jun 27, 2012 at 1:54 PM, Jia Liu wrote:
>> Add OpenRISC instruction tanslation routines.
>>
>> Signed-off-by: Jia Liu
>
> [...]
>
>> + case 0x0009:
>> + switch (op1) {
>> + case 0x03: /* l.div */
>> +
>From Markus:
Before:
$ qemu-system-x86_64 -display none -drive if=ide
qemu-system-x86_64: Device needs media, but drive is empty
qemu-system-x86_64: Initialization of device ide-hd failed
[Exit 1 ]
After:
$ qemu-system-x86_64 -display none -drive if=ide
qemu-system-x86_
On Wed, 27 Jun 2012 17:59:04 +0800
Amos Kong wrote:
> On 27/06/12 04:22, Luiz Capitulino wrote:
> > On Wed, 20 Jun 2012 06:53:40 -0600
> > Eric Blake wrote:
> >
> >> On 06/19/2012 10:47 PM, Amos Kong wrote:
> >>> Convert 'sendkey' to use QAPI. do_sendkey() depends on some
> >>> variables/functio
On 27 June 2012 12:29, Andreas Färber wrote:
> Do you have followup patches that make use of this? Might illustrate
> what variables and types are being passed in.
Here's a random snippet from the LPAE patch I'm working on:
uint32_t t0sz = field32(env->cp15.c2_control, 0, 3);
uint32_t t1
Am 27.06.2012 14:25, schrieb Peter Crosthwaite:
> Hi Jia,
>
> On Wed, Jun 27, 2012 at 7:54 PM, Jia Liu wrote:
>> +static void openrisc_sim_init(ram_addr_t ram_size,
>> + const char *boot_device,
>> + const char *kernel_filename,
>> +
On 27 June 2012 12:39, Eric Blake wrote:
> On 06/27/2012 04:29 AM, Peter Maydell wrote:
>> +static inline uint64_t field64(uint64_t value, int start, int length)
>> +{
>> + assert(start >= 0 && start <= 63 && length > 0 && start + length <= 64);
>
> You're failing to account for wraparound:
>
>
Eric Blake wrote:
> assert(start >= 0 && length > 0 && (unsigned) start + length <= 64);
This is shorter and avoids the ugly cast:
assert(start >= 0 && length > 0 && length <= 64 - start);
Jay.
On Wed, Jun 27, 2012 at 11:04 PM, Andreas Färber wrote:
> Am 27.06.2012 14:25, schrieb Peter Crosthwaite:
>> Hi Jia,
>>
>> On Wed, Jun 27, 2012 at 7:54 PM, Jia Liu wrote:
>>> +static void openrisc_sim_init(ram_addr_t ram_size,
>>> + const char *boot_device,
>>> +
On Wed, Jun 27, 2012 at 8:00 PM, Andreas Färber wrote:
> Am 18.06.2012 11:22, schrieb Li Zhang:
>> For pseries machine, it needs to enable usb to add
>> keyboard or usb mouse. -usb option won't be used in
>> the future, and machine options is a better way to
>> enable usb.
>>
>> So this patch is t
Am 27.06.2012 14:41, schrieb Anthony Liguori:
> From Markus:
>
> Before:
>
> $ qemu-system-x86_64 -display none -drive if=ide
> qemu-system-x86_64: Device needs media, but drive is empty
> qemu-system-x86_64: Initialization of device ide-hd failed
> [Exit 1 ]
>
> After:
>
>
On 06/27/2012 01:29 PM, Peter Maydell wrote:
> Add field32() and field64() functions which extract a particular
> bit field from a word and return it. Based on an idea by Jia Liu.
>
>
> +/**
> + * field64 - return a specified bit field from a uint64_t value
> + * @value: The value to extract the
On Wed, 27 Jun 2012 18:22:48 +0800
Amos Kong wrote:
> On 27/06/12 04:21, Luiz Capitulino wrote:
> > On Wed, 20 Jun 2012 12:47:40 +0800
> > Amos Kong wrote:
> >
> >> Convert 'sendkey' to use QAPI. do_sendkey() depends on some
> >> variables/functions in monitor.c, so reserve qmp_sendkey()
> >> to
On 06/27/2012 04:15 PM, Avi Kivity wrote:
> On 06/27/2012 01:29 PM, Peter Maydell wrote:
>> Add field32() and field64() functions which extract a particular
>> bit field from a word and return it. Based on an idea by Jia Liu.
>>
>>
>> +/**
>> + * field64 - return a specified bit field from a uin
On 27 June 2012 14:15, Avi Kivity wrote:
> I suggest adding the analogous functions for writing. I believe the
> common naming is extract/deposit.
>
> static inline uint64_t deposit64(uint64_t *pvalue, unsigned start,
> unsigned length, uint64_t fieldval)
> {
>
On Wed, Jun 27, 2012 at 11:13 PM, Li Zhang wrote:
> On Wed, Jun 27, 2012 at 8:00 PM, Andreas Färber wrote:
>> Am 18.06.2012 11:22, schrieb Li Zhang:
>>> For pseries machine, it needs to enable usb to add
>>> keyboard or usb mouse. -usb option won't be used in
Grammar: The pseries machine needs t
Am 27.06.2012 15:13, schrieb Li Zhang:
> On Wed, Jun 27, 2012 at 8:00 PM, Andreas Färber wrote:
>> Am 18.06.2012 11:22, schrieb Li Zhang:
>>> +bool usb_on = false;
>>
>> Didn't you want this to be true for sPAPR in absence of -machine?
>>
> It is set in the following:
>
> if (machine_opt
>From Markus:
Makes "make check" hang:
QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 gtester -k --verbose
-m=quick tests/crash-test tests/rtc-test
TEST: tests/crash-test... (pid=972)
qemu-system-x86_64: Device needs media, but drive is empty
[Nothing happens, wait a while, then
On 06/27/2012 07:15 AM, Avi Kivity wrote:
> On 06/27/2012 01:29 PM, Peter Maydell wrote:
>> Add field32() and field64() functions which extract a particular
>> bit field from a word and return it. Based on an idea by Jia Liu.
>>
>> +static inline uint64_t field64(uint64_t value, int start, int len
On Wed, Jun 27, 2012 at 9:22 PM, Peter Crosthwaite
wrote:
> On Wed, Jun 27, 2012 at 11:13 PM, Li Zhang wrote:
>> On Wed, Jun 27, 2012 at 8:00 PM, Andreas Färber wrote:
>>> Am 18.06.2012 11:22, schrieb Li Zhang:
For pseries machine, it needs to enable usb to add
keyboard or usb mouse. -
On 06/27/2012 04:22 PM, Peter Maydell wrote:
> On 27 June 2012 14:15, Avi Kivity wrote:
>> I suggest adding the analogous functions for writing. I believe the
>> common naming is extract/deposit.
>>
>> static inline uint64_t deposit64(uint64_t *pvalue, unsigned start,
>>
On 05/17/2012 08:25 AM, Jason Wang wrote:
> Commit ff71f2e8cacefae99179993204172bc65e4303df prevent the possible
> crash during initialization of linux driver by checking the operating
> mode.This seems too strict as:
>
> - the real card could still work in mode other than normal
> - some buggy dr
On Wed, Jun 27, 2012 at 4:40 PM, Jia Liu wrote:
> Hi Max,
>
> On Wed, Jun 27, 2012 at 7:03 PM, Max Filippov wrote:
>> On Wed, Jun 27, 2012 at 1:54 PM, Jia Liu wrote:
>>> Add OpenRISC instruction tanslation routines.
>>>
>>> Signed-off-by: Jia Liu
>>
>> [...]
>>
>>> + case 0x0009:
>>> +
On Wed, Jun 27, 2012 at 9:24 PM, Andreas Färber wrote:
> Am 27.06.2012 15:13, schrieb Li Zhang:
>> On Wed, Jun 27, 2012 at 8:00 PM, Andreas Färber wrote:
>>> Am 18.06.2012 11:22, schrieb Li Zhang:
+ bool usb_on = false;
>>>
>>> Didn't you want this to be true for sPAPR in absence of -mach
Am 18.06.2012 11:34, schrieb Li Zhang:
> Also instanciate the USB keyboard and mouse when that option is used
> (you can still use -device to create individual devices without all
> the defaults)
>
> Signed-off-by: Benjamin Herrenschmidt
> Signed-off-by: Li Zhang
> ---
> hw/spapr.c | 43 +
Thanks for the tips :)
On Tue, Jun 26, 2012 at 10:27 AM, Stefan Hajnoczi wrote:
> On Mon, Jun 25, 2012 at 7:58 PM, Alberich de megres
> wrote:
>> Thank you guys for the reply :)
>>
>> One last question,
>> my device is like a physical console with buttons and indicators.
>>
>> I saw the android
On Wed, Jun 27, 2012 at 9:47 PM, Andreas Färber wrote:
> Am 18.06.2012 11:34, schrieb Li Zhang:
>> Also instanciate the USB keyboard and mouse when that option is used
>> (you can still use -device to create individual devices without all
>> the defaults)
>>
>> Signed-off-by: Benjamin Herrenschmid
1 - 100 of 214 matches
Mail list logo
