On 06/27/2012 03:59 AM, Amos Kong wrote: >>> The interface looks like we have settled into something useful that >>> libvirt can live with. I will leave a more thorough review of the >>> series to those more familiar with qemu's internals. However, as long >>> as we are fine-tuning things, I have some questions that might be worth >>> one more spin: >>> >>>> +## >>>> +# @sendkey: >>> >>> Should this be named 'send-key', given that most QMP commands separate >>> words with '-' rather than squasheverythingtogether? >> >> Yes, that's right. > > still use sendkey for hmp ?
Libvirt won't care if you rename the hmp command, once the QMP command is in place. However, for back-compat, since hmp already had 'sendkey', it probably makes sense to keep that naming instead of gratuitously changing it, so for now, I'd go with 'send-key' only for QMP. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
