Re: [Qemu-devel] [PATCH v4 1/2] pl330: initial version

2012-06-18 Thread Igor Mitsyanko
Hi Peter, sorry for not properly reviewing your patch for such a long time, I'll try to do this as soon as possible. Right now I have a few small coments On 06/18/2012 04:42 AM, Peter A. G. Crosthwaite wrote: Device model for Primecell PL330 dma controller. Signed-off-by: Peter A. G. Crost

[Qemu-devel] [PATCH 11/22] qdev: Move bus properties to a separate global

2012-06-18 Thread Andreas Färber
From: Paolo Bonzini Simple code movement in order to simplify future refactoring. Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/i2c.c | 10 ++ hw/ide/qdev.c | 10 ++ hw/intel-hda.c| 10 ++ h

[Qemu-devel] [PULL] qom-next queue, second batch: QBus, API additions and cleanups

2012-06-18 Thread Andreas Färber
Hello Anthony, Seeing no update from Jan nor PULL from mst, here's - hopefully - the final batch of qom-next patches, as requested. As usual, I had remarked in my reply when I've taken the liberty of applying, e.g., style fixes myself. For the preview link that I posted as reply to the 1st batch,

[Qemu-devel] [PATCH 09/22] arm_l2x0: Rename "type" property to "cache-type"

2012-06-18 Thread Andreas Färber
Resolves a name conflict with the qdev "type" property that is about to be moved to Object. Signed-off-by: Andreas Färber Acked-by: Mark Langsdorf --- hw/arm_l2x0.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/arm_l2x0.c b/hw/arm_l2x0.c index 09f290c..de6a086 100

[Qemu-devel] [PATCH 22/22] qom: Push error reporting to object_property_find()

2012-06-18 Thread Andreas Färber
From: Paolo Bonzini Avoids duplicated error_set(). Signed-off-by: Paolo Bonzini [AF: Also drop error_set() in object_property_del().] Signed-off-by: Andreas Färber --- hw/qdev.c |2 +- hw/scsi-bus.c |2 +- include/qemu/object.h |4 +++- qom/object.c |

Re: [Qemu-devel] [PATCH 3/3] qom: add unit test for Interfaces

2012-06-18 Thread Anthony Liguori
On 06/18/2012 08:51 AM, Andreas Färber wrote: Am 18.06.2012 15:46, schrieb Peter Crosthwaite: +#define HERBIVORE(obj) \ +INTERFACE_CHECK(Herbivore, (obj), TYPE_HERBIVORE) + +typedef struct Herbivore +{ +Object obj; +} Herbivore; All this is doing is saying Herbivores are Objects right

[Qemu-devel] [PATCH 05/22] qom: Make Object a type

2012-06-18 Thread Andreas Färber
From: Paolo Bonzini Right now the base Object class has a special NULL type. Change this so that we will be able to add class_init and class_base_init callbacks. To do this, remove some special casing of ObjectClass that is not really necessary. Signed-off-by: Paolo Bonzini Signed-off-by: Andr

[Qemu-devel] [PATCH 10/22] qdev: Push "type" property up to Object

2012-06-18 Thread Andreas Färber
From: Paolo Bonzini Now that Object is a type, add an instance_init function and push the "type" property from qdev to there. Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/qdev.c|6 -- qom/object.c | 11 +++ 2 files changed, 11 insertions(+), 6 deleti

[Qemu-devel] [PATCH 21/22] qdev: Remove qdev_prop_exists()

2012-06-18 Thread Andreas Färber
From: Paolo Bonzini Can be replaced everywhere with object_property_find(). Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/qdev-properties.c |5 - hw/qdev.c |2 +- hw/qdev.h |1 - hw/scsi-bus.c |2 +- include/qemu/object.

Re: [Qemu-devel] [PATCH v2 0/2] pci_host: Convert to QOM

2012-06-18 Thread Anthony Liguori
On 06/10/2012 10:57 AM, Andreas Färber wrote: Hello Michael, This series, based on a recent PReP RFC series, in turn based on Anthony's and Wanpeng's i440fx refactoring, makes pci_host a proper QOM type and in this v2 also updates all remaining host controllers beyond PReP. Only compile-tested

[Qemu-devel] [PATCH 20/22] qbus: Initialize in standard way

2012-06-18 Thread Andreas Färber
From: Anthony Liguori Move code to an initfn and finalizer. Replace do_qbus_create_inplace() with qbus_realize(). Signed-off-by: Anthony Liguori Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/qdev.c | 80 1 fil

[Qemu-devel] [PATCH 02/22] qom: Introduce object_property_is_{child, link}()

2012-06-18 Thread Andreas Färber
Avoids hardcoding partial string comparisons. Signed-off-by: Alexander Barabash Signed-off-by: Andreas Färber Reviewed-by: Paolo Bonzini --- qom/object.c | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/qom/object.c b/qom/object.c index 9582230..105c

Re: [Qemu-devel] ARM QEMU/KVM and TrustZone

2012-06-18 Thread Christoffer Dall
On Sat, Jun 16, 2012 at 9:09 PM, Peter Maydell wrote: > On 16 June 2012 18:37, Christoffer Dall wrote: >>> On 22 May 2012 13:22, Peter Maydell wrote: Historically for QEMU we haven't implemented TrustZone support even though we claim to emulate CPUs that provide it. Instead we provide

[Qemu-devel] [PATCH 07/22] qom: Assert that public types have a non-NULL parent field

2012-06-18 Thread Andreas Färber
From: Paolo Bonzini This protects against unwanted effects of changing TYPE_OBJECT from NULL to a string. Suggested-by: Andreas Färber Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- qom/object.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --

Re: [Qemu-devel] q35 chipset support

2012-06-18 Thread Anthony Liguori
On 06/18/2012 09:35 AM, Michael S. Tsirkin wrote: On Mon, Jun 18, 2012 at 09:16:24AM -0500, Anthony Liguori wrote: On 06/17/2012 03:25 AM, Michael S. Tsirkin wrote: On Fri, Jun 15, 2012 at 12:58:33PM -0500, Anthony Liguori wrote: The Q35 is much more sophisticated. The PCI-e complex itself ca

[Qemu-devel] [PATCH 16/22] qdev: Move SysBus initialization to sysbus.c

2012-06-18 Thread Andreas Färber
From: Paolo Bonzini TYPE_SYSTEM_BUS will be local to hw/sysbus.c, so move existing references to main_system_bus and system_bus_info there. Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/qdev.c | 26 ++ hw/sysbus.c | 21 + 2

[Qemu-devel] KVM call agenda for Tuesday, June 19th

2012-06-18 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Anthony suggested for last week: - multithreading vhost (and general vhost improvements) I suggest: - status of migration: post-copy, IDL, XBRLE, huge memory, ... Will send an email with an status before tomorrow call. Thanks

[Qemu-devel] [PATCH 01/22] qom: Add object_class_get_parent()

2012-06-18 Thread Andreas Färber
From: Paolo Bonzini This simple bit of functionality was missing and we'll need it soon, so add it. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori [AF: Document possible NULL return value] Signed-off-by: Andreas Färber --- include/qemu/object.h |8 qom/object.c

[Qemu-devel] [PATCH 04/22] qom: Add class_base_init

2012-06-18 Thread Andreas Färber
From: Paolo Bonzini The class_base_init TypeInfo callback was present in one of the early QOM versions but removed (on my request...) before committing. We will need it soon, add it. Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Signed-off-by: Andreas Färber --- include/qemu/obj

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Corey Bryant
On 06/18/2012 04:33 AM, Daniel P. Berrange wrote: On Fri, Jun 15, 2012 at 07:04:45PM +, Blue Swirl wrote: On Wed, Jun 13, 2012 at 8:33 PM, Daniel P. Berrange wrote: On Wed, Jun 13, 2012 at 07:56:06PM +, Blue Swirl wrote: On Wed, Jun 13, 2012 at 7:20 PM, Eduardo Otubo wrote: I adde

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Corey Bryant
On 06/18/2012 04:31 AM, Daniel P. Berrange wrote: On Fri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: I think allowing execve() would render seccomp pretty much useless. Not necessarily. I'll agree that it does seem a bit odd t

Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16

2012-06-18 Thread Amos Kong
On 06/15/2012 09:35 PM, Luiz Capitulino wrote: > On Fri, 15 Jun 2012 09:57:49 +0200 > Gerd Hoffmann wrote: > >> Hi, >> It seems we need to notice user when inputted keys are more than 16. >>> >>> Hi Gerd, >>> >>> When I use 'sendkey' command to send key-series to guest, some keyboard >>> e

[Qemu-devel] [PATCH 18/22] qdev: Connect busses with their parent devices

2012-06-18 Thread Andreas Färber
From: Anthony Liguori This makes SysBus part of the root hierarchy and all busses children of their respective parent DeviceState. Signed-off-by: Anthony Liguori Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/qdev.c |4 hw/sysbus.c |3 +++ 2 files changed, 7

Re: [Qemu-devel] [PATCH 1/6 v10] docs: spec for add-cow file format

2012-06-18 Thread Eric Blake
On 06/17/2012 08:08 PM, Dong Xu Wang wrote: Mention that if this is not 0, then it must be between 36 and 4094 (a file name must be at least 1 byte). What are the semantics if the filename is relative? >>> >>> relative filename is ok, I tested it just now. >> >> I believe Eric want

Re: [Qemu-devel] [RFC PATCH 0/3] GlusterFS support in QEMU

2012-06-18 Thread Stefan Hajnoczi
On Mon, Jun 11, 2012 at 3:18 PM, Bharata B Rao wrote: > 4. Creating VM image > > # qemu-img create -f gluster gluster:c-qemu.vol:/F16 5G Do you really need "-f gluster"? The format should be "raw" (default) and the protocol should be "gluster". Specifying "gluster:..." as the filename takes car

Re: [Qemu-devel] q35 chipset support

2012-06-18 Thread Andreas Färber
Am 18.06.2012 16:37, schrieb Michael S. Tsirkin: > On Mon, Jun 18, 2012 at 09:22:43AM -0500, Anthony Liguori wrote: >> On 06/18/2012 09:20 AM, Michael S. Tsirkin wrote: >>> On Fri, Jun 15, 2012 at 12:58:33PM -0500, Anthony Liguori wrote: So we need to fix our topological representation of plat

Re: [Qemu-devel] The latest qemu.git/master build break

2012-06-18 Thread Dunrong Huang
2012/6/18 Zhi Yong Wu : > HI, > > When i want to rebase my hub-based network patchset to latest > qemu.git/master, i found the build break. > >  lt LINK libcacard.la > ar: libcacard/cac.o: No such file or directory > make[1]: *** [libcacard.la] Error 1 > make: *** [subdir-libcacard] Error 2 > I als

Re: [Qemu-devel] Adding errno to QMP errors

2012-06-18 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Fri, Jun 15, 2012 at 11:52:57AM -0500, Anthony Liguori wrote: >> On 06/13/2012 12:49 PM, Luiz Capitulino wrote: >> No, you're confusing things I think. { 'error': 'NoSpace' } is bad. >> errno is not an intrinsically bad thing but errno critically relies >> on th

Re: [Qemu-devel] q35 chipset support

2012-06-18 Thread Anthony Liguori
On 06/18/2012 10:36 AM, Andreas Färber wrote: Am 18.06.2012 16:37, schrieb Michael S. Tsirkin: On Mon, Jun 18, 2012 at 09:22:43AM -0500, Anthony Liguori wrote: On 06/18/2012 09:20 AM, Michael S. Tsirkin wrote: On Fri, Jun 15, 2012 at 12:58:33PM -0500, Anthony Liguori wrote: So we need to fix

Re: [Qemu-devel] q35 chipset support

2012-06-18 Thread Jason Baron
On Mon, Jun 18, 2012 at 05:35:02PM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 18, 2012 at 09:16:24AM -0500, Anthony Liguori wrote: > > On 06/17/2012 03:25 AM, Michael S. Tsirkin wrote: > > >On Fri, Jun 15, 2012 at 12:58:33PM -0500, Anthony Liguori wrote: > > >>The Q35 is much more sophisticated

[Qemu-devel] [PATCH v5 00/17] hub-based networking patches

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu All comments have been addressed and stefan has completed one more reviewing. Changelog from v4: 1.) roll back qdev_prop_vlan [stefanha] v4: 1.) refactor hub own flow control [paolo] 2.) refactor the output for monitor command "info network" [jan kiszka] v3: 1.) add the s

[Qemu-devel] [PATCH v5 01/17] net: Add a hub net client

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi The vlan feature can be implemented in terms of hubs. By introducing a hub net client it becomes possible to remove the special case vlan code from net.c and push the vlan feature out of generic networking code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu -

[Qemu-devel] [PATCH v5 03/17] net: Look up 'vlan' net clients using hubs

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 28 +--- net/hub.c | 24 net/hub.h |2 ++ net/slirp.c |5 +++-- 4 files changed, 30 insertions(+), 29 deletions(-) diff --git a/ne

[Qemu-devel] [PATCH v5 07/17] net: Remove vlan code from net.c

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi The vlan implementation in net.c has been replaced by hubs so we can remove the code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/xen_nic.c |1 - net.c| 108 -- net.h|1

[Qemu-devel] [PATCH v5 08/17] net: Remove VLANState

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi VLANState is no longer used and can be removed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 127 ++--- net.h |8 net/socket.c |6 +- net/tap.c |6 +- net/

[Qemu-devel] [PATCH v5 12/17] net: Rename qemu_del_vlan_client() to qemu_del_net_client()

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi Another step in moving the vlan feature out of net core. Users only deal with NetClientState and therefore qemu_del_vlan_client() should be named qemu_del_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/e1000.c |2 +- hw/eepr

[Qemu-devel] [PATCH v5 04/17] hub: Check that hubs are configured correctly

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi Checks can be performed to make sure that hubs have at least one NIC and one host device, warning the user if this is not the case. Configurations which do not meet this rule tend to be broken but just emit a warning. This patch preserves compatibility with the checks perfo

[Qemu-devel] [PATCH v5 11/17] net: Rename vc local variables to nc

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi Now that VLANClientState has been renamed to NetClientState all 'vc' local variables should be 'nc'. Much of the code already used 'nc' but there are places where 'vc' needs to be renamed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/ne2000.h |

[Qemu-devel] [PATCH v5 13/17] net: Make "info network" output more readable info

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu Reviewed-by: Jan Kiszka Signed-off-by: Zhi Yong Wu --- net.c | 14 +- net.h |1 + net/hub.c | 23 +-- net/hub.h |1 + 4 files changed, 32 insertions(+), 7 deletions(-) diff --git a/net.c b/net.c index e7d49b3..d0be471 10

[Qemu-devel] [PATCH v5 16/17] hub: add the support for hub own flow control

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu Only when all other hub port's *peer* .can_receive() all return 1, the source hub port .can_receive() return 1. Reviewed-off-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu --- net/hub.c | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH 2/3] net: add the support for -netdev socket, listen

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu The -net socket,listen option does not work with the newer -netdev syntax: http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01508.html This patch makes it work now. For the case where one vlan has multiple listenning sockets, the patch will also provide the support. S

[Qemu-devel] [PATCH 1/3] net: fix the coding style

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/socket.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/net/socket.c b/net/socket.c index dc5ba40..ba8583f 100644 --- a/net/socket.c +++ b/net/socket.c @@ -301,7 +301,9 @@ static NetSocketState *net_socket_fd_ini

[Qemu-devel] [PATCH 0/3] Some socket fix patches

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu The patchset is on top of hub-based networking patchset. Zhi Yong Wu (3): net: fix the coding style net: add the support for -netdev socket, listen net: complete NetSocketState lifecycle handling net/socket.c | 82 +++---

[Qemu-devel] [PATCH 3/3] net: complete NetSocketS?tate lifecycle handling

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu The NetSocketState struct contains two file descriptors: an active connection and a listen socket for new connections. It's important that we clean up after ourselves so these file descriptors are initialized to -1 when unused. This allows makes it possible to call cleanup fun

[Qemu-devel] [PATCH 3/3] net: complete NetSocketState lifecycle handling

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu The NetSocketState struct contains two file descriptors: an active connection and a listen socket for new connections. It's important that we clean up after ourselves so these file descriptors are initialized to -1 when unused. This allows makes it possible to call cleanup fun

Re: [Qemu-devel] [PATCH 3/3] net: complete NetSocketS?tate lifecycle handling

2012-06-18 Thread Zhi Yong Wu
please ignore this. thanks. On Tue, Jun 19, 2012 at 1:13 AM, wrote: > From: Zhi Yong Wu > > The NetSocketState struct contains two file descriptors: an active > connection and a listen socket for new connections.  It's important that > we clean up after ourselves so these file descriptors are i

[Qemu-devel] [PATCH v5 09/17] net: Rename non_vlan_clients to net_clients

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi There is no longer a distinction between vlan clients and non-vlan clients in the net core. The net core only knows about point-to-point clients which are connected to a peer. It's time to rename the global list of net clients since it no longer refers to vlans at all. Si

Re: [Qemu-devel] [RFC PATCH 3/3] block: gluster as block backend

2012-06-18 Thread Stefan Hajnoczi
On Mon, Jun 11, 2012 at 3:21 PM, Bharata B Rao wrote: > +#include "block_int.h" > +#include "gluster-helpers.h" > + > +typedef void *gluster_file_t; This typedef is already in gluster-helpers.h. It's ugly BTW, "typedef struct gluster_file gluster_file_t" is nicer since it won't cast to other poi

Re: [Qemu-devel] [RFC PATCH 2/3] block: GlusterFS helpers to interface with libglusterfs

2012-06-18 Thread Stefan Hajnoczi
On Mon, Jun 11, 2012 at 3:20 PM, Bharata B Rao wrote: > +    ret = pthread_create(&thread, NULL, gluster_handle_poll, > +    (void *)gctx); Please use qemu-thread.h. QEMU uses signals so you almost certainly want to mask signals for this thread (qemu_thread_create() does that). Stefan

[Qemu-devel] [PATCH v5 05/17] net: Drop vlan argument to qemu_new_net_client()

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi Since hubs are now used to implement the 'vlan' feature and the vlan argument is always NULL, remove the argument entirely and update all net clients that use qemu_new_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 27

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Corey Bryant
On 06/16/2012 02:46 AM, Blue Swirl wrote: On Fri, Jun 15, 2012 at 9:36 PM, Paul Moore wrote: On Friday, June 15, 2012 09:23:46 PM Blue Swirl wrote: On Fri, Jun 15, 2012 at 9:02 PM, Paul Moore wrote: On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: I think allowing execve() would ren

[Qemu-devel] [PATCH v5 14/17] net: cleanup deliver/deliver_iov func pointers

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu Reviewed-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu --- net.c | 35 +++ net.h | 11 +++ net/queue.c | 13 - net/queue.h | 17 ++--- 4 files changed, 28 insertions(+), 48 deletions(-) diff

[Qemu-devel] [PATCH v5 17/17] net: roll back qdev_prop_vlan

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu We're trying to preserve backward compatibility. This command-line break: x86_64-softmmu/qemu-system-x86_64 -net user,vlan=1 -device virtio-net-pci,vlan=1 Instead of dropping the qdev_prop_vlan completely the hw/qdev-properties.c code needs to call net/hub.h external function

[Qemu-devel] [PATCH v5 02/17] net: Use hubs for the vlan feature

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi Stop using the special-case vlan code in net.c. Instead use the hub net client to implement the vlan feature. The next patch will remove vlan code from net.c completely. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 38 ++

[Qemu-devel] [PATCH v5 15/17] net: determine if packets can be sent before net queue deliver packets

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu Reviewed-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu --- net/queue.c |8 net/slirp.c |7 --- slirp/if.c |5 - slirp/libslirp.h |1 - 4 files changed, 4 insertions(+), 17 deletions(-) diff --git a/net/queue.c b/net/queue.c i

[Qemu-devel] [PATCH v5 06/17] net: Remove vlan qdev property

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi The vlan feature is implemented using hubs and no longer uses special-purpose VLANState structs that are accessible as qdev properties. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/qdev-properties.c | 72 -

[Qemu-devel] [Bug 1014681] Re: BSOD with newer host kernels (x64) and W2k8S guest (x64)

2012-06-18 Thread Arndt Kritzner
** Tags added: qemu-kvm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1014681 Title: BSOD with newer host kernels (x64) and W2k8S guest (x64) Status in QEMU: New Bug description: Hallo, I att

Re: [Qemu-devel] [PATCH v5 02/16] target-or32: Add target machine

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 1:02 AM, Jia Liu wrote: > Add OpenRISC target machine. > > Signed-off-by: Jia Liu > --- >  target-openrisc/cpu.h     |   67 > - >  target-openrisc/machine.c |   22 ++- >  2 files changed, 87 insertions(+), 2 deletion

Re: [Qemu-devel] [PATCH v5 01/16] target-or32: Add target stubs and cpu support

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 1:02 AM, Jia Liu wrote: > Add OpenRISC target stubs and basic cpu support. > > Signed-off-by: Jia Liu > --- >  arch_init.c                      |    2 + >  arch_init.h                      |    1 + >  configure                        |   14 +- >  cpu-exec.c                

Re: [Qemu-devel] [PATCH v2 0/2] pci_host: Convert to QOM

2012-06-18 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 05:57:53PM +0200, Andreas Färber wrote: > Hello Michael, > > This series, based on a recent PReP RFC series, in turn based on Anthony's and > Wanpeng's i440fx refactoring, makes pci_host a proper QOM type and in this v2 > also updates all remaining host controllers beyond P

Re: [Qemu-devel] [PATCH v2 1/2] pci_host: Turn into SysBus-derived QOM type

2012-06-18 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 05:57:54PM +0200, Andreas Färber wrote: > From: Andreas Färber > > Allows us to access PCIHostState QOM-style with PCI_HOST() macro. > > Update PReP Raven PCI to derive from this type. > > Signed-off-by: Anthony Liguori > Signed-off-by: Wanpeng Li > Signed-off-by: Andr

Re: [Qemu-devel] Adding errno to QMP errors

2012-06-18 Thread Anthony Liguori
On 06/18/2012 10:41 AM, Markus Armbruster wrote: "Daniel P. Berrange" writes: On Fri, Jun 15, 2012 at 11:52:57AM -0500, Anthony Liguori wrote: On 06/13/2012 12:49 PM, Luiz Capitulino wrote: No, you're confusing things I think. { 'error': 'NoSpace' } is bad. errno is not an intrinsically bad

[Qemu-devel] [Bug 1014681] Re: BSOD with newer host kernels (x64) and W2k8S guest (x64)

2012-06-18 Thread Arndt Kritzner
** Attachment added: "example windows minidump" https://bugs.launchpad.net/qemu/+bug/1014681/+attachment/3194733/+files/Mini061612-12.dmp -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1014681 Tit

[Qemu-devel] [Bug 1014681] [NEW] BSOD with newer host kernels (x64) and W2k8S guest (x64)

2012-06-18 Thread Arndt Kritzner
Public bug reported: Hallo, I attempted to move virtual machines from one host to another but got stuck with Windows-BSODs on the target host. The host-side console message is "virtio_ioport_write: unexpected address 0x13 value 0x1". Eventually there are overlaps to bug #990364, but I'm not sure.

[Qemu-devel] [Bug 1014681] Re: BSOD with newer host kernels (x64) and W2k8S guest (x64)

2012-06-18 Thread Arndt Kritzner
** Attachment added: "table of testet component variants" https://bugs.launchpad.net/qemu/+bug/1014681/+attachment/3194732/+files/varianten.txt ** Description changed: Hallo, I attempted to move virtual machines from one host to another but got stuck with Windows-BSODs on the target host.

Re: [Qemu-devel] [PATCH v5 12/16] target-or32: Add system instructions

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 1:03 AM, Jia Liu wrote: > Add OpenRISC system instruction support. > > Signed-off-by: Jia Liu > --- >  target-openrisc/Makefile.objs |    3 +- >  target-openrisc/helper.h      |    4 + >  target-openrisc/sys_helper.c  |  233 > + >  

[Qemu-devel] [Bug 1014681] Re: BSOD with newer host kernels (x64) and W2k8S guest (x64)

2012-06-18 Thread Arndt Kritzner
** Attachment added: "qemu run arguments" https://bugs.launchpad.net/bugs/1014681/+attachment/3194721/+files/ads.w2k8s.qcow2.start -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1014681 Title: B

Re: [Qemu-devel] [PATCH v5 00/16] QEMU OpenRISC support

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 1:02 AM, Jia Liu wrote: > This is the OpenCores OpenRISC 1200 support for QEMU. > Full implementation of the system-model and linux-user-model support. > > OpenRISC 1200 is a OpenCores open source CPU, > its architecture manual can be found at > http://opencores.org/svnget,

Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 4:59 AM, YeongKyoon Lee wrote: >> The idea looks nice, but instead of different TLB functions selected >> at configure time, the optimization should be enabled by default. >> >> Maybe a 'call' instruction could be used to jump to the slow path, >> that way the slow path cou

Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 6:57 AM, 陳韋任 (Wei-Ren Chen) wrote: >> The idea looks nice, but instead of different TLB functions selected >> at configure time, the optimization should be enabled by default. >> >> Maybe a 'call' instruction could be used to jump to the slow path, >> that way the slow path

Re: [Qemu-devel] [PATCH 8/8] s390: Fix the storage increment size calculation

2012-06-18 Thread Christian Borntraeger
On 18/06/12 15:46, Alexander Graf wrote: > Is that one publicly available anywhere? Unfortunately no. Sorry.

Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 8:28 AM, 陳韋任 (Wei-Ren Chen) wrote: >>   The reason why we want to do the measuring is we want to use KVM (sounds >> crazy >> idea) MMU virtualization to speedup the guest -> host memory address >> translation. >> I talked to some people on LinuxCon Japan, included Paolo,

Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-18 Thread Lluís Vilanova
陳韋任 (Wei-Ren Chen) writes: >> The reason why we want to do the measuring is we want to use KVM (sounds >> crazy >> idea) MMU virtualization to speedup the guest -> host memory address >> translation. >> I talked to some people on LinuxCon Japan, included Paolo, about this idea. >> The >> feedba

Re: [Qemu-devel] [PATCH 2/2] fdc: Move floppy geometry guessing back from block.c

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 9:10 AM, Markus Armbruster wrote: > Commit 5bbdbb46 moved it to block.c because "other geometry guessing > functions already reside in block.c".  Device-specific functionality > should be kept in device code, not the block layer.  Move it back. As discussed earlier, this i

Re: [Qemu-devel] [PATCHv3 02/14] unicore32-softmmu: Add coprocessor 0(sysctrl) and 1(ocd) instruction support

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 9:24 AM, Guan Xuetao wrote: > Coprocessor 0 is system control coprocessor, and we need get/set its contents. > Also, all cache/tlb ops shoule be implemented here, but just ignored with no > harm. > > Coprocessor 1 is OCD (on-chip-debugger), which is used for faked console,

Re: [Qemu-devel] [PATCHv3 12/14] unicore32-softmmu: Add puv3 dma support

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 9:25 AM, Guan Xuetao wrote: > This patch adds puv3 dma (Direct Memory Access) support, > include dma device simulation for kernel booting. > > Signed-off-by: Guan Xuetao > --- >  hw/Makefile.objs |    1 + >  hw/puv3.c        |    1 + >  hw/puv3_dma.c    |  109 > +

Re: [Qemu-devel] [PATCHv3 07/14] unicore32-softmmu: Add puv3 soc/board support

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 9:25 AM, Guan Xuetao wrote: > This patch only add puv3 soc/board support, which introduces puv3 > machine description, and specifies console type. > > Signed-off-by: Guan Xuetao > --- >  default-configs/unicore32-softmmu.mak |    1 + >  hw/puv3.c                          

Re: [Qemu-devel] [PATCHv3 11/14] unicore32-softmmu: Add puv3 pm support

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 9:25 AM, Guan Xuetao wrote: > This patch adds puv3 pm (power management) support, > include pm device simulation for kernel booting. > > Signed-off-by: Guan Xuetao > --- >  hw/Makefile.objs |    1 + >  hw/puv3.c        |    1 + >  hw/puv3_pm.c     |  148 > +++

[Qemu-devel] [PATCH] configure: Fix typo

2012-06-18 Thread Stefan Weil
The typo did not cause an error because open_by_handle_at was only compared to "yes". Signed-off-by: Stefan Weil --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 5d73c82..20a0fd3 100755 --- a/configure +++ b/configure @@ -2809,7 +28

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Eduardo Otubo
On Mon, Jun 18, 2012 at 02:55:35PM +0100, Daniel P. Berrange wrote: > On Mon, Jun 18, 2012 at 09:52:44AM -0400, Paul Moore wrote: > > On Monday, June 18, 2012 09:31:03 AM Daniel P. Berrange wrote: > > > On Fri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: > > > > On Friday, June 15, 2012 07:

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 8:31 AM, Daniel P. Berrange wrote: > On Fri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: >> On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: >> > I think allowing execve() would render seccomp pretty much useless. >> >> Not necessarily. >> >> I'll agree that i

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 3:22 PM, Corey Bryant wrote: > > > On 06/18/2012 04:33 AM, Daniel P. Berrange wrote: >> >> On Fri, Jun 15, 2012 at 07:04:45PM +, Blue Swirl wrote: >>> >>> On Wed, Jun 13, 2012 at 8:33 PM, Daniel P. Berrange >>> wrote: On Wed, Jun 13, 2012 at 07:56:06PM +,

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Blue Swirl
On Mon, Jun 18, 2012 at 8:13 PM, Eduardo Otubo wrote: > On Mon, Jun 18, 2012 at 02:55:35PM +0100, Daniel P. Berrange wrote: >> On Mon, Jun 18, 2012 at 09:52:44AM -0400, Paul Moore wrote: >> > On Monday, June 18, 2012 09:31:03 AM Daniel P. Berrange wrote: >> > > On Fri, Jun 15, 2012 at 05:02:19PM -

Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-18 Thread Lluís Vilanova
Blue Swirl writes: > On Mon, Jun 18, 2012 at 8:28 AM, 陳韋任 (Wei-Ren Chen) > wrote: >>>   The reason why we want to do the measuring is we want to use KVM (sounds >>> crazy >>> idea) MMU virtualization to speedup the guest -> host memory address >>> translation. >>> I talked to some people on Lin

Re: [Qemu-devel] [PATCH] Fixes related to processing of qemu's -numa option

2012-06-18 Thread Eduardo Habkost
On Sun, Jun 17, 2012 at 01:12:31PM -0700, Chegu Vinod wrote: > The -numa option to qemu is used to create [fake] numa nodes > and expose them to the guest OS instance. > > There are a couple of issues with the -numa option: > > a) Max VCPU's that can be specified for a guest while using >the

Re: [Qemu-devel] q35 chipset support

2012-06-18 Thread Jason Baron
On Mon, Jun 18, 2012 at 09:05:17AM -0500, Anthony Liguori wrote: > On 06/18/2012 08:51 AM, Markus Armbruster wrote: > >Anthony Liguori writes: > > > >>On 06/15/2012 02:04 AM, Markus Armbruster wrote: > >>>Anthony Liguori writes: > >>> > On 06/14/2012 02:54 PM, Jason Baron wrote: > >Hi, >

Re: [Qemu-devel] q35 chipset support

2012-06-18 Thread Anthony Liguori
On 06/18/2012 03:36 PM, Jason Baron wrote: On Mon, Jun 18, 2012 at 09:05:17AM -0500, Anthony Liguori wrote: On 06/18/2012 08:51 AM, Markus Armbruster wrote: Anthony Liguori writes: On 06/15/2012 02:04 AM, Markus Armbruster wrote: Anthony Liguoriwrites: On 06/14/2012 02:54 PM, Jason B

Re: [Qemu-devel] [PATCH v2 1/2] pci_host: Turn into SysBus-derived QOM type

2012-06-18 Thread Andreas Färber
Am 18.06.2012 20:28, schrieb Michael S. Tsirkin: > On Sun, Jun 10, 2012 at 05:57:54PM +0200, Andreas Färber wrote: >> From: Andreas Färber >> >> Allows us to access PCIHostState QOM-style with PCI_HOST() macro. >> >> Update PReP Raven PCI to derive from this type. >> >> Signed-off-by: Anthony Ligu

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Corey Bryant
On 06/18/2012 04:18 PM, Blue Swirl wrote: On Mon, Jun 18, 2012 at 3:22 PM, Corey Bryant wrote: On 06/18/2012 04:33 AM, Daniel P. Berrange wrote: On Fri, Jun 15, 2012 at 07:04:45PM +, Blue Swirl wrote: On Wed, Jun 13, 2012 at 8:33 PM, Daniel P. Berrange wrote: On Wed, Jun 13, 2012

Re: [Qemu-devel] [PATCH] Fixes related to processing of qemu's -numa option

2012-06-18 Thread Chegu Vinod
On 6/18/2012 1:29 PM, Eduardo Habkost wrote: On Sun, Jun 17, 2012 at 01:12:31PM -0700, Chegu Vinod wrote: The -numa option to qemu is used to create [fake] numa nodes and expose them to the guest OS instance. There are a couple of issues with the -numa option: a) Max VCPU's that can be specifi

Re: [Qemu-devel] [PATCH] Fixes related to processing of qemu's -numa option

2012-06-18 Thread Andreas Färber
Am 17.06.2012 22:12, schrieb Chegu Vinod: > diff --git a/vl.c b/vl.c > index 204d85b..1906412 100644 > --- a/vl.c > +++ b/vl.c > @@ -28,6 +28,7 @@ > #include > #include > #include > +#include Did you check whether this and the macros you're using are available on POSIX and mingw32? vl.c is

Re: [Qemu-devel] [PATCH] Fixes related to processing of qemu's -numa option

2012-06-18 Thread Eric Blake
On 06/18/2012 04:05 PM, Andreas Färber wrote: > Am 17.06.2012 22:12, schrieb Chegu Vinod: >> diff --git a/vl.c b/vl.c >> index 204d85b..1906412 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -28,6 +28,7 @@ >> #include >> #include >> #include >> +#include > > Did you check whether this and the mac

Re: [Qemu-devel] [PATCH] Fixes related to processing of qemu's -numa option

2012-06-18 Thread Chegu Vinod
On 6/18/2012 3:11 PM, Eric Blake wrote: On 06/18/2012 04:05 PM, Andreas Färber wrote: Am 17.06.2012 22:12, schrieb Chegu Vinod: diff --git a/vl.c b/vl.c index 204d85b..1906412 100644 --- a/vl.c +++ b/vl.c @@ -28,6 +28,7 @@ #include #include #include +#include Did you check whether this a

Re: [Qemu-devel] [PATCH v2 1/2] pci_host: Turn into SysBus-derived QOM type

2012-06-18 Thread Anthony Liguori
On 06/18/2012 04:44 PM, Andreas Färber wrote: Am 18.06.2012 20:28, schrieb Michael S. Tsirkin: On Sun, Jun 10, 2012 at 05:57:54PM +0200, Andreas Färber wrote: From: Andreas Färber Allows us to access PCIHostState QOM-style with PCI_HOST() macro. Update PReP Raven PCI to derive from this type.

Re: [Qemu-devel] [PATCH v2 1/2] pci_host: Turn into SysBus-derived QOM type

2012-06-18 Thread Michael S. Tsirkin
On Mon, Jun 18, 2012 at 05:23:32PM -0500, Anthony Liguori wrote: > On 06/18/2012 04:44 PM, Andreas Färber wrote: > >Am 18.06.2012 20:28, schrieb Michael S. Tsirkin: > >>On Sun, Jun 10, 2012 at 05:57:54PM +0200, Andreas Färber wrote: > >>>From: Andreas Färber > >>> > >>>Allows us to access PCIHostSt

Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location

2012-06-18 Thread Jan Kiszka
On 2012-06-18 12:36, Jan Kiszka wrote: > Could you publish your queue? I'd like to rebase my missing bits. > > Thanks, > Ja > Will do. FYI Anthony said on irc he objects to the caching approach, asked for more time to review it all. Maybe we'll have to go bac

Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location

2012-06-18 Thread Michael S. Tsirkin
On Tue, Jun 19, 2012 at 12:37:13AM +0200, Jan Kiszka wrote: > On 2012-06-18 12:36, Jan Kiszka wrote: > > Could you publish your queue? I'd like to rebase my missing bits. > > > > Thanks, > > Ja > > > > Will do. FYI Anthony said on irc he objects to the caching approach

Re: [Qemu-devel] The latest qemu.git/master build break

2012-06-18 Thread Zhi Yong Wu
On Mon, Jun 18, 2012 at 11:37 PM, Dunrong Huang wrote: > 2012/6/18 Zhi Yong Wu : >> HI, >> >> When i want to rebase my hub-based network patchset to latest >> qemu.git/master, i found the build break. >> >>  lt LINK libcacard.la >> ar: libcacard/cac.o: No such file or directory >> make[1]: *** [li

[Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-18 Thread Scott Wood
If tci_out_label is called in the context of tcg_gen_code_search_pc, we could be overwriting an already patched relocation with zero -- and not repatch it because the set_label is past search_pc, causing a QEMU crash when it tries to branch to a zero label. Not writing anything to the relocation a

Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-18 Thread Stefan Weil
Am 19.06.2012 04:31, schrieb Scott Wood: If tci_out_label is called in the context of tcg_gen_code_search_pc, we could be overwriting an already patched relocation with zero -- and not repatch it because the set_label is past search_pc, causing a QEMU crash when it tries to branch to a zero label

<    1   2   3   >